Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-12-16 Thread Johannes Berg
On Thu, 2015-12-17 at 11:19 +0800, Dave Young wrote: >  > Cool, has the fix been in mainline or somewhere else? > https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=a87da0cbc42949cefc8282c39ab4cb8c460bd6ea johannes -- To unsubscribe from this list: send the line "unsubscribe n

[Patch net] net: check both type and procotol for tcp sockets

2015-12-16 Thread Cong Wang
Dmitry reported the following out-of-bound access: Call Trace: [] __asan_report_load4_noabort+0x3e/0x40 mm/kasan/report.c:294 [] sock_setsockopt+0x1284/0x13d0 net/core/sock.c:880 [< inline >] SYSC_setsockopt net/socket.c:1746 [] SyS_setsockopt+0x1fe/0x240 net/socket.c:1729 [] entry_SY

[PATCH v2] drivers: net: xgene: fix Tx flow control

2015-12-16 Thread Iyappan Subramanian
Currently the Tx flow control is based on reading the hardware state, which is not accurate since it may not reflect the descriptors that are not yet reached the memory. To accurately control the Tx flow, changing it to be software based. Signed-off-by: Iyappan Subramanian --- v2: Address v1 re

Re: Load Balancing for AF_INET Raw Sockets

2015-12-16 Thread Prashant Upadhyaya
On Tue, Dec 15, 2015 at 8:09 PM, Eric Dumazet wrote: > On Tue, 2015-12-15 at 18:26 +0530, Prashant Upadhyaya wrote: >> Hi, >> >> I open a raw socket for listening to all the UDP packets in a raw fashion -- >> >> socket(AF_INET, SOCK_RAW, IPPROTO_UDP); >> >> Then I use recvfrom to read the packets

linux-next: manual merge of the akpm-current tree with the net-next tree

2015-12-16 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm-current tree got a conflict in: include/net/sock.h net/ipv4/tcp_ipv4.c between commit: 64be0aed59ad ("net: diag: Add the ability to destroy a socket.") from the net-next tree and commit: 0e2cde9cf7b6 ("net: tcp_memcontrol: simplify linka

Re: [PATCH] Add tcindex to conntrack and add netfilter target/matches

2015-12-16 Thread kbuild test robot
Hi Luuk, [auto build test ERROR on nf-next/master] [also build test ERROR on v4.4-rc5 next-20151216] url: https://github.com/0day-ci/linux/commits/Luuk-Paulussen/Add-tcindex-to-conntrack-and-add-netfilter-target-matches/20151216-082324 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH 15/15] i40iw: changes for build of i40iw module

2015-12-16 Thread kbuild test robot
Hi Faisal, [auto build test WARNING on net/master] [also build test WARNING on v4.4-rc5 next-20151216] [cannot apply to net-next/master] url: https://github.com/0day-ci/linux/commits/Faisal-Latif/add-Intel-R-X722-iWARP-driver/20151217-040340 config: sparc-allyesconfig (attached as .config

Re: [PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-16 Thread David Rivshin (Allworx)
On Wed, 16 Dec 2015 07:39:16 +0100 Markus Brunner wrote: > On Monday 14 December 2015 13:04:46 David Rivshin wrote: > > On Sat, 12 Dec 2015 16:44:19 +0100 > ... > > > Your patch works fine on my board, which uses MII and dual_emac > > > with a fixed_phy and a real one. > > > > Thanks for checkin

Re: [PATCH net-next 1/4] cxgb4: Use mask & shift while returning vlan_prio

2015-12-16 Thread David Miller
From: Casey Leedom Date: Wed, 16 Dec 2015 17:40:41 -0800 > >> On Dec 16, 2015, at 4:07 PM, David Miller wrote: >> >> From: Hariprasad Shenai >> Date: Wed, 16 Dec 2015 13:16:25 +0530 >> >>> @@ -66,7 +66,7 @@ struct l2t_data { >>> >>> static inline unsigned int vlan_prio(const struct l2t_entr

[PATCH v2 3/3] drivers: net: cpsw: increment reference count on fixed-link PHY node

2015-12-16 Thread David Rivshin (Allworx)
From: David Rivshin When a fixed-link sub-node exists in a slave node, the slave node is also the PHY node. Since this is a separate use of the slave node, of_node_get() should be used to increment the reference count. Fixes: 1f71e8c96fc6 ("drivers: net: cpsw: Add support for fixed-link PHY") Si

[PATCH v2 1/3] ethernet:ti:cpsw: fix phy identification with multiple slaves on fixed-phy

2015-12-16 Thread David Rivshin (Allworx)
From: Pascal Speck (Iktek) Date: Fri, 04 Dec 2015 16:55:17 +0100 When using more than one slave with ti cpsw and fixed phy the pd->phy_id will be always zero, but slave_data->phy_id must be unique. pd->phy_id means a "phy hardware id" whereas slave_data->phy_id means an "unique id", so we should

[PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-16 Thread David Rivshin (Allworx)
Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: Add support for fixed-link PHY") added initial fixed-link PHY support for CPSW, but missed a few considerations. This series is based on the tip of the net tree. The first two patches fix user-visible errors in different hardwar

[PATCH v2 2/3] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-16 Thread David Rivshin (Allworx)
From: David Rivshin Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: Add support for fixed-link PHY") did not parse the "phy-mode" property in the case of a fixed-link PHY, leaving slave_data->phy_if with its default of PHY_INTERFACE_MODE_NA(0). This later gets passed to phy_

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-12-16 Thread Dave Young
Hi, On 12/11/15 at 03:26pm, Johannes Berg wrote: > On Mon, 2015-11-23 at 09:37 +0800, Dave Young wrote: > > > Seems there're a lot of other wireless messages. Should we refactor > > them as well? I still did not get chance to see where is the code. > > (My wireless driver being used is iwlwifi)

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-12-16 Thread Dave Young
Hi, Johannes Sorry for late feedback, I was busying on other things. On 12/11/15 at 03:38pm, Johannes Berg wrote: > On Sun, 2015-11-15 at 15:31 +0800, Dave Young wrote: > > cfg80211 module prints a lot of messages like below. Actually > > printing once is acceptable but sometimes it will print ag

Re: [PATCH net-next 1/4] cxgb4: Use mask & shift while returning vlan_prio

2015-12-16 Thread Casey Leedom
> On Dec 16, 2015, at 4:07 PM, David Miller wrote: > > From: Hariprasad Shenai > Date: Wed, 16 Dec 2015 13:16:25 +0530 > >> @@ -66,7 +66,7 @@ struct l2t_data { >> >> static inline unsigned int vlan_prio(const struct l2t_entry *e) >> { >> -return e->vlan >> 13; >> +return (e->vlan & VL

Re: [PATCH] inet: sanitize socket() protocol value

2015-12-16 Thread Vegard Nossum
On 12/17/2015 02:01 AM, Eric Dumazet wrote: On Wed, Dec 16, 2015 at 4:57 PM, Vegard Nossum wrote: If you create a raw socket with a protocol of e.g. 0x1, then inet_sk(sk)->inet_num will get set to 0 since it only has room for 16 bits. This causes problems further down the line as lots of co

Re: [PATCH] inet: sanitize socket() protocol value

2015-12-16 Thread Eric Dumazet
On Wed, Dec 16, 2015 at 4:57 PM, Vegard Nossum wrote: > If you create a raw socket with a protocol of e.g. 0x1, then > inet_sk(sk)->inet_num will get set to 0 since it only has room for 16 > bits. This causes problems further down the line as lots of code makes > assumptions about ->inet_num,

[PATCH] inet: sanitize socket() protocol value

2015-12-16 Thread Vegard Nossum
If you create a raw socket with a protocol of e.g. 0x1, then inet_sk(sk)->inet_num will get set to 0 since it only has room for 16 bits. This causes problems further down the line as lots of code makes assumptions about ->inet_num, for example connect()...inet_autobind() will attempt to call sk

Re: [PATCH net-next v4 8/8] openvswitch: Interface with NAT.

2015-12-16 Thread Jarno Rajahalme
Thanks for review, I removed these in version 5. Jarno > On Dec 10, 2015, at 11:10 AM, Pablo Neira Ayuso wrote: > > On Tue, Dec 08, 2015 at 05:01:10PM -0800, Jarno Rajahalme wrote: >> -/* Call the helper right after nf_conntrack_in() for confirmed >> - * connections, but only when com

[PATCH net-next v5 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

2015-12-16 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/con

[PATCH net-next v5 7/8] openvswitch: Delay conntrack helper call for new connections.

2015-12-16 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno Rajaha

[PATCH net-next v5 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2015-12-16 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 9 ++--- 1 file changed

[PATCH net-next v5 3/8] netfilter: Allow calling into nat helper without skb_dst.

2015-12-16 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar Signed-of

[PATCH net-next v5 0/8] openvswitch: NAT support.

2015-12-16 Thread Jarno Rajahalme
This series adds NAT support to openvswitch kernel module. A few changes are needed to the netfilter code to facilitate this (patches 1-3/8). Patches 4-7 make the openvswitch kernel module ready for the patch 8 that adds the NAT support by calling into netfilter NAT code from the openvswitch conn

[PATCH net-next v5 8/8] openvswitch: Interface with NAT.

2015-12-16 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed

[PATCH net-next v5 2/8] netfilter: Factor out nf_ct_get_info().

2015-12-16 Thread Jarno Rajahalme
Define a new inline function to map conntrack status to enum ip_conntrack_info. This removes the need to otherwise duplicate this code in a later patch ("openvswitch: Find existing conntrack entry after upcall."). Signed-off-by: Jarno Rajahalme --- include/net/netfilter/nf_conntrack.h | 15

[PATCH net-next v5 5/8] openvswitch: Find existing conntrack entry after upcall.

2015-12-16 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall. ovs_ct_find_exis

[PATCH net-next v5 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-12-16 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +--- net/openvswitch/conntrack.c

Re: [PATCH net-next v5 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-16 Thread David Decotigny
Thanks David: you are right, we should copy back sizeof(struct ethtool_settings) in that case and not sizeof(usettings). Sorry about that, will fix for v6. a few questions before sending update: - is this handshake reasonable? or should we have an ethtool cmd dedicated to this kind of handshake,

Re: [PATCH] net: add Qualcomm IPC router

2015-12-16 Thread David Miller
From: Courtney Cavin Date: Wed, 16 Dec 2015 16:01:41 -0800 > We could hardcode the value in kconfig, but that seems like a worse > solution than a module parameter. > > I'm open to further suggestions. No module parameters, configure it via netlink or similar at run time. -- To unsubscribe from

Re: [PATCH v7 0/4] Support administratively closing application sockets

2015-12-16 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Dec 2015 15:35:35 -0800 > socket can be shared by fd passing to multiple users. > > Who really owns it ? Oh yes the old fd permission discussion... Probably need to use the openner's permissions. -- To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH net-next 1/4] cxgb4: Use mask & shift while returning vlan_prio

2015-12-16 Thread David Miller
From: Hariprasad Shenai Date: Wed, 16 Dec 2015 13:16:25 +0530 > @@ -66,7 +66,7 @@ struct l2t_data { > > static inline unsigned int vlan_prio(const struct l2t_entry *e) > { > - return e->vlan >> 13; > + return (e->vlan & VLAN_PRIO_MASK) >> VLAN_PRIO_SHIFT; e->vlan is a u16, the vlan p

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-16 Thread David Miller
From: Hannes Frederic Sowa Date: Tue, 15 Dec 2015 21:01:54 +0100 > udp tunnel offloads tend to aggregate datagrams based on inner > headers. gro engine gets notified by tunnel implementations about > possible offloads. The match is solely based on the port number. > > Imagine a tunnel bound to p

Re: [PATCH net 1/2] fou: clean up socket with kfree_rcu

2015-12-16 Thread David Miller
From: Hannes Frederic Sowa Date: Tue, 15 Dec 2015 21:01:53 +0100 > fou->udp_offloads is managed by RCU. As it is actually included inside > the fou sockets, we cannot let the memory go out of scope before a grace > period. We either can synchronize_rcu or switch over to kfree_rcu to > manage the

Re: [PATCH] net: add Qualcomm IPC router

2015-12-16 Thread Courtney Cavin
On Tue, Dec 15, 2015 at 10:01:14PM +0100, David Miller wrote: > From: Bjorn Andersson > Date: Fri, 11 Dec 2015 12:41:59 -0800 > > > +static unsigned int qrtr_local_nid = 1; > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO); > > +MODULE_PARM_DESC(idVendor, "Local Node Identifier"); >

Re: [PATCH] net: add Qualcomm IPC router

2015-12-16 Thread Courtney Cavin
On Fri, Dec 11, 2015 at 09:41:59PM +0100, Bjorn Andersson wrote: > From: Courtney Cavin > > Add an implementation of Qualcomm's IPC router protocol, used to > communicate with service providing remote processors. > > Signed-off-by: Courtney Cavin > --- [...] > +static int qrtr_sendmsg(struct so

Re: [PATCH net-next] net: Pass ndm_state to route netlink FDB notifications.

2015-12-16 Thread David Miller
From: "Sokolowski, Hubert" Date: Tue, 15 Dec 2015 13:20:30 + > Before this change applications monitoring FDB notifications > were not able to determine whether a new FDB entry is permament > or not: > bridge fdb add f1:f2:f3:f4:f5:f8 dev sw0p1 temp self > bridge fdb add f1:f2:f3:f4:f5:f9 dev

Re: [PATCH v7 0/4] Support administratively closing application sockets

2015-12-16 Thread Eric Dumazet
On Wed, 2015-12-16 at 14:55 -0500, Jamal Hadi Salim wrote: > On 15-12-16 10:50 AM, Eric Dumazet wrote: > > On Wed, 2015-12-16 at 07:43 -0800, Stephen Hemminger wrote: > > > >> > >> I see no security checks in the diag infrastructure. > >> Up until now diag has been read-only access and therefore ha

Re: pull-request: mac80211 2015-12-15

2015-12-16 Thread David Miller
From: Johannes Berg Date: Tue, 15 Dec 2015 13:30:21 +0100 > After going through my patch queue, I have another set of fixes that > I think is still appropriate for the current cycle. > > Two of my own restart changes there are fairly big but for the most > part just move code around so it can be

Re: [PATCH] 82xx: FCC: Fixing a bug causing to FCC port lock-up

2015-12-16 Thread David Miller
From: Martin Roth Date: Tue, 15 Dec 2015 04:17:53 +0200 > The patch fixes FCC port lock-up, which occurs as a result of a bug > during underrun/collision handling. Within the tx_startup() function > in mac-fcc.c, the address of last BD is not calculated correctly. > As a result of wrong calculati

Re: [PATCH] gianfar: Don't enable RX Filer if not supported

2015-12-16 Thread David Miller
From: Manoil Claudiu Date: Tue, 15 Dec 2015 10:12:36 + >>-Original Message- >>From: Hamish Martin [mailto:hamish.mar...@alliedtelesis.co.nz] >>Sent: Tuesday, December 15, 2015 3:15 AM >>To: Manoil Claudiu-B08782 >>Cc: netdev@vger.kernel.org; Hamish Martin >> >>Subject: [PATCH] gianfa

Re: [PATCH v7 0/4] Support administratively closing application sockets

2015-12-16 Thread David Miller
From: Jamal Hadi Salim Date: Wed, 16 Dec 2015 14:55:15 -0500 > The question i had was the opposite when i saw this: why are > regular users allowed to read admin (and any other users) details?;-> > On this specific feature: why, as a regular user, I cant close > connections attributed to me (and

Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers

2015-12-16 Thread David Miller
From: Haiyang Zhang Date: Wed, 16 Dec 2015 19:20:44 + > In our test, we have bisected and found the following patch introduced big > overhead into skb_flow_dissect_flow_keys(), and caused performance > regression: > commit: d34af823 > net: Add VLAN ID to flow_keys NEVER _EVER_ work around

[PATCH RFC] AF_UNIX SOCK_STREAM SO_PEEK_OFS oddity

2015-12-16 Thread Rainer Weikusat
While moving towards rectifying some more of my past missteps, I noticed that the unix_stream_read_generic code loads the peek offset (into a variable named skip) before entering the actual receive loop with the u->readlock mutex held. If there's no data to return, it drops this lock and goes to sl

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-16 Thread Dmitrii Shcherbakov
Phil, > Dmitrii, did iproute2 without your change even print the overhead as set by you before? Looking at the code, I'd assume not. I used an iproute2 provided by the distribution and an OpenVZ 3.10 kernel so there are differences there but I noticed the 'manual' overhead-related code is include

Re: [PATCH net] tcp: restore fastopen with no data in SYN packet

2015-12-16 Thread Yuchung Cheng
On Wed, Dec 16, 2015 at 1:53 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > Yuchung tracked a regression caused by commit 57be5bdad759 ("ip: convert > tcp_sendmsg() to iov_iter primitives") for TCP Fast Open. > > Some Fast Open users do not actually add any data in the SYN packet. > > Fixes:

Re: net: heap-out-of-bounds in sock_setsockopt

2015-12-16 Thread Willem de Bruijn
> > Hmm, we should exclude the raw socket case, something like the > following, but I am not sure if the check is too strict or not, also > not sure if we should return an error for this raw socket case. No, SOF_TIMESTAMPING_OPT_ID with SOCK_RAW/IPPROTO_TCP is legitimate. It should fall through to

[PATCH net] tcp: restore fastopen with no data in SYN packet

2015-12-16 Thread Eric Dumazet
From: Eric Dumazet Yuchung tracked a regression caused by commit 57be5bdad759 ("ip: convert tcp_sendmsg() to iov_iter primitives") for TCP Fast Open. Some Fast Open users do not actually add any data in the SYN packet. Fixes: 57be5bdad759 ("ip: convert tcp_sendmsg() to iov_iter primitives") Rep

Re: [PATCH net-next 2/2] net/mlx5_en: Add HW timestamping (TS) support

2015-12-16 Thread Or Gerlitz
On Wed, Dec 16, 2015 at 6:46 PM, Saeed Mahameed > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h > index ea6a137..b6651b8 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h > +++ b/drivers/net/ethernet/mellanox

Re: [PATCH net-next 2/2] net/mlx5_en: Add HW timestamping (TS) support

2015-12-16 Thread Or Gerlitz
On Wed, Dec 16, 2015 at 6:46 PM, Saeed Mahameed wrote: > From: Eran Ben Elisha > > Add support for enable/disable HW timestamping [..] > drivers/net/ethernet/mellanox/mlx5/core/Kconfig|1 + > drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- > drivers/net/ethernet/mellanox/m

Re: [PATCH 00/15] add Intel(R) X722 iWARP driver

2015-12-16 Thread Joe Perches
On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > This series contains the addition of the i40iw.ko driver. This series should probably be respun against -next instead of linus' tree. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...

[PATCH net-next v3 0/2] net: Allow accepted sockets to be bound to l3mdev domain

2015-12-16 Thread David Ahern
Allow accepted sockets to derive their sk_bound_dev_if setting from the l3mdev domain in which the packets originated. This version adds a sysctl to control whether the setting is inherited, making the functionality similar to sk_mark and its sysctl_tcp_fwmark_accept setting. This effectively allo

[PATCH net-next v3 2/2] net: Allow accepted sockets to be bound to l3mdev domain

2015-12-16 Thread David Ahern
Allow accepted sockets to derive their sk_bound_dev_if setting from the l3mdev domain in which the packets originated. A sysctl setting is added to control the behavior which is similar to sk_mark and sysctl_tcp_fwmark_accept. This effectively allow a process to have a "VRF-global" listen socket,

[PATCH net-next 1/2] net: l3mdev: Add master device lookup by index

2015-12-16 Thread David Ahern
Add helper to lookup l3mdev master index given a device index. Signed-off-by: David Ahern --- include/net/l3mdev.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h index 774d85b2d5d9..786226f8e77b 100644 --- a/include/net/l3

Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers

2015-12-16 Thread Eric Dumazet
On Wed, 2015-12-16 at 19:20 +, Haiyang Zhang wrote: > > -Original Message- > > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > > Sent: Wednesday, December 16, 2015 12:08 PM > > > > This looks very very wrong to me. > > > > How many times this is called per second, for the 'one fl

Re: net: heap-out-of-bounds in sock_setsockopt

2015-12-16 Thread Eric Dumazet
On Wed, Dec 16, 2015 at 12:22 PM, Cong Wang wrote: > Hmm, we should exclude the raw socket case, something like the > following, but I am not sure if the check is too strict or not, also > not sure if we should return an error for this raw socket case. > > diff --git a/net/core/sock.c b/net/core/

[PATCH] Octeon: Fix logic for waking octoen ethernet tx queue.

2015-12-16 Thread Luuk Paulussen
The ethernet driver tx queue is stopped when the queue length exceeds what is allowed. It should only be started again when the queue length is back within bounds. The logic here was just reenabling the queue when any buffers had been freed. the queue was stopped whenever the length exceeded 100

Re: [PATCH 15/15] i40iw: changes for build of i40iw module

2015-12-16 Thread Christoph Hellwig
> --- a/include/uapi/rdma/rdma_netlink.h > +++ b/include/uapi/rdma/rdma_netlink.h > @@ -5,6 +5,7 @@ > > enum { > RDMA_NL_RDMA_CM = 1, > + RDMA_NL_I40IW, > RDMA_NL_NES, > RDMA_NL_C4IW, > RDMA_NL_LS, /* RDMA Local Services */ This changes the values for the existin

Re: [PATCH 15/15] i40iw: changes for build of i40iw module

2015-12-16 Thread kbuild test robot
Hi Faisal, [auto build test WARNING on net/master] [also build test WARNING on v4.4-rc5 next-20151216] [cannot apply to net-next/master] url: https://github.com/0day-ci/linux/commits/Faisal-Latif/add-Intel-R-X722-iWARP-driver/20151217-040340 config: arm-allyesconfig (attached as .config

Re: [PATCH 02/15] i40iw: add main, hdr, status

2015-12-16 Thread Joe Perches
On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > i40iw_main.c contains routines for i40e <=> i40iw interface and setup. > i40iw.h is header file for main device data structures. > i40iw_status.h is for return status codes. [] > diff --git a/drivers/infiniband/hw/i40iw/i40iw.h > b/drivers/i

Re: [PATCH 01/15] i40e: Add support for client interface for IWARP driver

2015-12-16 Thread Joe Perches
On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > From: Anjali Singhai Jain > > This patch adds a Client interface for i40iw driver > support. Also expands the Virtchannel to support messages > from i40evf driver on behalf of i40iwvf driver. [] > diff --git a/drivers/net/ethernet/intel/i40

Re: net: heap-out-of-bounds in sock_setsockopt

2015-12-16 Thread Cong Wang
On Wed, Dec 16, 2015 at 11:34 AM, Dmitry Vyukov wrote: > BUG: KASAN: slab-out-of-bounds in sock_setsockopt+0x1284/0x13d0 at > addr 88006563ec10 > Read of size 4 by task syzkaller_execu/4755 > = > BUG RAWv6 (Not tainted

[PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

2015-12-16 Thread Rainer Weikusat
With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM receive code was changed from using mutex_lock(&u->readlock) to mutex_lock_interruptible(&u->readlock) to prevent signals from being delayed for an indefinite time if a thread sleeping on the mutex happened to be selected for ha

Re: [PATCH v7 0/4] Support administratively closing application sockets

2015-12-16 Thread Jamal Hadi Salim
On 15-12-16 10:50 AM, Eric Dumazet wrote: On Wed, 2015-12-16 at 07:43 -0800, Stephen Hemminger wrote: I see no security checks in the diag infrastructure. Up until now diag has been read-only access and therefore has been allowed for all users. It is still allowed to all users. Only the 'de

[PATCH 12/15] i40iw: user kernel shared files

2015-12-16 Thread Faisal Latif
i40iw_user.h and i40iw_uk.c are used by both user library as well as kernel requests. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_uk.c | 1213 ++ drivers/infiniband/hw/i40iw/i40iw_user.h

[PATCH 05/15] i40iw: add pble resource files

2015-12-16 Thread Faisal Latif
i40iw_pble.[ch] to manage pble resource for iwarp clients. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_pble.c | 618 +++ drivers/infiniband/hw/i40iw/i40iw_pble.h | 131 +++ 2 files chan

[PATCH 06/15] i40iw: add hmc resource files

2015-12-16 Thread Faisal Latif
i40iw_hmc.[ch] are to manage hmc for the device. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_hmc.c | 823 drivers/infiniband/hw/i40iw/i40iw_hmc.h | 241 ++ 2 files changed, 106

[PATCH 07/15] i40iw: add hw and utils files

2015-12-16 Thread Faisal Latif
i40iw_hw.c, i40iw_utils.c and i40iw_osdep.h are files to handle interrupts and processing. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_hw.c| 705 + drivers/infiniband/hw/i40iw/i40iw_osdep.h | 235

[PATCH 03/15] i40iw: add connection management code

2015-12-16 Thread Faisal Latif
i40iw_cm.c i40iw_cm.h are used for connection management. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 4447 drivers/infiniband/hw/i40iw/i40iw_cm.h | 456 2 files changed,

[PATCH 13/15] i40iw: virtual channel handling files

2015-12-16 Thread Faisal Latif
i40iw_vf.[ch] and i40iw_virtchnl[ch] are used for virtual channel support for iWARP VF module. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_vf.c | 85 +++ drivers/infiniband/hw/i40iw/i40iw_vf.h | 62 +++

[PATCH 10/15] i40iw: add hardware related header files

2015-12-16 Thread Faisal Latif
header files for hardware accesses Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_d.h| 1713 ++ drivers/infiniband/hw/i40iw/i40iw_p.h| 106 ++ drivers/infiniband/hw/i40iw/i40iw_type.h | 1308 +++ 3 files changed, 3127 in

[PATCH 14/15] i40iw: Kconfig and Kbuild for iwarp module

2015-12-16 Thread Faisal Latif
Kconfig and Kbuild needed to build iwarp module. Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/Kbuild | 43 + drivers/infiniband/hw/i40iw/Kconfig | 7 ++ 2 files changed, 50 insertions(+) create mode 100644 drivers/infiniband/hw/i40iw/Kbui

[PATCH 02/15] i40iw: add main, hdr, status

2015-12-16 Thread Faisal Latif
i40iw_main.c contains routines for i40e <=> i40iw interface and setup. i40iw.h is header file for main device data structures. i40iw_status.h is for return status codes. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw.h

[PATCH 15/15] i40iw: changes for build of i40iw module

2015-12-16 Thread Faisal Latif
IAINTAINERS< Kconfig, Makefile and rdma_netlink.h to include i40iw Signed-off-by: Faisal Latif --- MAINTAINERS | 10 ++ drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + include/uapi/rdma/rdma_netlink.h | 1 + 4 files changed, 13 inse

[PATCH 09/15] i40iw: add file to handle cqp calls

2015-12-16 Thread Faisal Latif
i40iw_ctrl.c provides for hardware wqe supporti and cqp. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 4774 ++ 1 file changed, 4774 insertions(+) create mode 100644 drivers/infinib

[PATCH 08/15] i40iw: add files for iwarp interface

2015-12-16 Thread Faisal Latif
i40iw_verbs.[ch] are to handle iwarp interface. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_ucontext.h | 110 ++ drivers/infiniband/hw/i40iw/i40iw_verbs.c| 2492 ++ drivers/infiniband/hw/i

[PATCH 04/15] i40iw: add puda code

2015-12-16 Thread Faisal Latif
i40iw_puda.[ch] are files to handle iwarp connection packets as well as exception packets over multiple privilege mode uda queues. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_puda.c | 1443

[PATCH 11/15] i40iw: add X722 register file

2015-12-16 Thread Faisal Latif
X722 Hardware registers defines for iWARP component. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_register.h | 1027 ++ 1 file changed, 1027 insertions(+) create mode 100644 drivers/infiniband/

[PATCH 00/15] add Intel(R) X722 iWARP driver

2015-12-16 Thread Faisal Latif
This series contains the addition of the i40iw.ko driver. This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet controller for PCI Physical Functions. It also has support for Virtual Function driver (i40iwvf.ko) that will be part of seperate patch series. It cooperates with

[PATCH 01/15] i40e: Add support for client interface for IWARP driver

2015-12-16 Thread Faisal Latif
From: Anjali Singhai Jain This patch adds a Client interface for i40iw driver support. Also expands the Virtchannel to support messages from i40evf driver on behalf of i40iwvf driver. This client API is used by the i40iw and i40iwvf driver to access the core driver resources brokered by the i40e

RE: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers

2015-12-16 Thread Haiyang Zhang
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Wednesday, December 16, 2015 12:08 PM > > This looks very very wrong to me. > > How many times this is called per second, for the 'one flow' case ? > > Don't you use TSO in this driver ? > > What about enc

net: heap-out-of-bounds in sock_setsockopt

2015-12-16 Thread Dmitry Vyukov
Hello, The following program triggers heap-out-of-bounds access in sock_setsockopt: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include #include #define SOF_TIMESTAMPING_OPT_ID (1<<7) int main() { int fd = socke

Re: [PATCH net-next 2/2] net/mlx5_en: Add HW timestamping (TS) support

2015-12-16 Thread Richard Cochran
On Wed, Dec 16, 2015 at 06:46:34PM +0200, Saeed Mahameed wrote: > From: Eran Ben Elisha > > Add support for enable/disable HW timestamping for incoming and/or > outgoing packets. It adds and initializes all structs and callbacks > needed by kernel TS API. To enable/disable HW timestamping approp

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-16 Thread Arnd Bergmann
On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index 88c1e1a..35661aa 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -28,6 +28,7 @@ > #i

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-16 Thread Gregory CLEMENT
Hi Richard, On mer., déc. 16 2015, Richard Cochran wrote: > On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote: >> +Optional properties for PHY child node: >> +- reset-gpios : Should specify the gpio for phy reset > > reset-gpios plural or reset-gpio singular? The bindings name i

[PATCH net-next] nfp: clear ring delayed kick counters

2015-12-16 Thread Jakub Kicinski
We need to clear delayed kick counters when we free rings otherwise after ndo_close()/ndo_open() we could kick HW by more entries than actually written to rings. Signed-off-by: Jakub Kicinski Reviewed-by: Rolf Neugebauer --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 ++ 1 file cha

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-16 Thread Richard Cochran
On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote: > +Optional properties for PHY child node: > +- reset-gpios : Should specify the gpio for phy reset reset-gpios plural or reset-gpio singular? > + > Examples: > > macb0: ethernet@fffc4000 { > @@ -29,4 +32,8 @@ Examples: >

Re: [PATCH net-next] ipv6: add IPV6_HDRINCL option for raw sockets

2015-12-16 Thread Joe Perches
On Wed, 2015-12-16 at 17:22 +0100, Hannes Frederic Sowa wrote: > Same as in Windows, we miss IPV6_HDRINCL for SOL_IPV6 and SOL_RAW. > The SOL_IP/IP_HDRINCL is not available for IPv6 sockets. [] > diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c [] > @@ -972,6 +972,11 @@ static int do_rawv6_setsockopt(s

Re: Information leak in llcp_sock_bind/llcp_raw_sock_bind

2015-12-16 Thread Dmitry Vyukov
On Tue, Dec 15, 2015 at 9:58 PM, David Miller wrote: > From: Dmitry Vyukov > Date: Tue, 15 Dec 2015 21:55:37 +0100 > >> I've seen a kernel address at least in pptp_bind, > > We're not talking about pptp_bind. > > We're talking about llcp_{,raw}_sock_bind(). > > If your hex dump doesn't show it, d

Re: [PATCH iproute2] ipv6: allow setting stable_secret mode

2015-12-16 Thread Stephen Hemminger
On Wed, 16 Dec 2015 12:30:08 +0100 Hannes Frederic Sowa wrote: > Signed-off-by: Hannes Frederic Sowa > --- > ip/iplink.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ip/iplink.c b/ip/iplink.c > index f30de86d1858a0..e824082f7d8149 100644 > --- a/ip/iplink.c > +++

Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers

2015-12-16 Thread Sergei Shtylyov
On 12/16/2015 09:34 PM, Sergei Shtylyov wrote: To avoid performance overhead when using skb_flow_dissect_flow_keys(), we switch to the simple parsers to get the IP and port numbers. Performance comparison: throughput (Gbps): Number of connections, before patch, after patch 18.56

Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers

2015-12-16 Thread Sergei Shtylyov
Hello. On 12/16/2015 09:03 PM, Haiyang Zhang wrote: To avoid performance overhead when using skb_flow_dissect_flow_keys(), we switch to the simple parsers to get the IP and port numbers. Performance comparison: throughput (Gbps): Number of connections, before patch, after patch 1

[PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-16 Thread Gregory CLEMENT
With device tree it is no more possible to reset the PHY at board level. Furthermore, doing in the driver allow to power down the PHY when the network interface is no more used. This reset can't be done at the PHY driver level. The PHY must be able to answer to the mii bus scan to let the kernel c

Re: [PATCH 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-16 Thread Dan Williams
On Wed, 2015-12-16 at 10:39 +0100, Daniele Palmas wrote: > This patch series add support in the cdc_ncm driver for two devices > based on the same platform, that are different only for carrier > customization. > > The devices do not have ARP capabilities. > > Daniele Palmas (2): > net: usb: cdc

Re: [PATCH net-next v3 3/3] geneve: Remote Checksum Offload support

2015-12-16 Thread Jesse Gross
On Wed, Dec 16, 2015 at 8:41 AM, Tom Herbert wrote: > On Thu, Dec 10, 2015 at 1:17 PM, Jesse Gross wrote: >> On Thu, Dec 10, 2015 at 12:37 PM, Tom Herbert wrote: >>> Add support for remote checksum offload in both the normal and GRO >>> paths. netlinks command are used to enable sending of the R

Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers

2015-12-16 Thread Eric Dumazet
On Wed, 2015-12-16 at 10:03 -0800, Haiyang Zhang wrote: > To avoid performance overhead when using skb_flow_dissect_flow_keys(), > we switch to the simple parsers to get the IP and port numbers. > > Performance comparison: throughput (Gbps): > Number of connections, before patch, after patch > 1

Re: [PATCH iproute2] ipv6: allow setting stable_secret mode

2015-12-16 Thread Hannes Frederic Sowa
On 16.12.2015 17:56, Bjørn Mork wrote: > > > On December 16, 2015 12:30:08 PM CET, Hannes Frederic Sowa > wrote: >> Signed-off-by: Hannes Frederic Sowa >> --- >> ip/iplink.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/ip/iplink.c b/ip/iplink.c >> index f30de86

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-16 Thread Dan Williams
On Wed, 2015-12-16 at 17:50 +0800, Xin Long wrote: > Add the support for adding expire value to routes, requested by > Tom Gundersen for systemd-networkd, and NetworkManager > wants it too. > > implement it by adding the new RTNETLINK attribute RTA_EXPIRES. Could you also add bits to send RTA_E

[PATCH net-next] tun: honor IFF_UP in tun_get_user()

2015-12-16 Thread Eric Dumazet
From: Eric Dumazet If a tun interface is turned down, we should not allow packet injection into the kernel. Kernel does not send packets to the tun already. TUNATTACHFILTER can not be used as only tun_net_xmit() is taking care of it. Reported-by: Curt Wohlgemuth Signed-off-by: Eric Dumazet -

  1   2   >