[PATCH] ixgbe: on recv increment rx.ring->stats.yields instead of tx

2015-12-10 Thread Pavel Tikhomirov
It seem to be non intentionaly changed to tx in ms commit: adc810900a703ee78fe88fd65e086d359fec04b2 ixgbe: Refactor busy poll socket code to address multiple issues Lock is taken from ixgbe_low_latency_recv, and there under this lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment

Re: [PATCH v3 3/4] i40e: Kernel dependency update for i40e to support geneve offload

2015-12-10 Thread Jeff Kirsher
On Tue, 2015-12-08 at 10:12 -0800, Anjali Singhai Jain wrote: > Update the Kconfig file with dependency for supporting GENEVE tunnel > offloads. > > Signed-off-by: Anjali Singhai Jain > Signed-off-by: Kiran Patil Acked-by: Jeff Kirsher > --- >  drivers/net/ethernet/intel/Kconfig | 10

Re: [PATCH v3 2/4] i40e: geneve tunnel offload support

2015-12-10 Thread Jeff Kirsher
On Tue, 2015-12-08 at 10:12 -0800, Anjali Singhai Jain wrote: > This patch adds driver hooks to implement ndo_ops to add/del > udp port in the HW to identify GENEVE tunnels. > > Signed-off-by: Anjali Singhai Jain > Signed-off-by: Kiran Patil Acked-by: Jeff Kirsher > --- >  drivers/net/etherne

Re: [PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

2015-12-10 Thread Stefan Hajnoczi
On Thu, Dec 10, 2015 at 09:23:25PM +, Alex Bennée wrote: > Stefan Hajnoczi writes: > > > From: Asias He > > > > VM sockets virtio transport implementation. This module runs in guest > > kernel. > > checkpatch warns on a bunch of whitespace/tab issues. Will fix in the next version. > > +st

Re: [PATCH v3 1/4] VSOCK: Introduce virtio-vsock-common.ko

2015-12-10 Thread Stefan Hajnoczi
On Thu, Dec 10, 2015 at 10:17:07AM +, Alex Bennée wrote: > Stefan Hajnoczi writes: > > > From: Asias He > > > > This module contains the common code and header files for the following > > virtio-vsock and virtio-vhost kernel modules. > > General comment checkpatch has a bunch of warnings ab

Re: [PATCH v5 1/4] stmmac: create of compatible mdio bus for stmacc driver

2015-12-10 Thread Phil Reid
G'day Giuseppe, On 11/12/2015 1:16 AM, Giuseppe CAVALLARO wrote: Hi also pls fix this typo stmmac: create of compatible mdio bus for stmacc driver stmmac Will do. On 12/9/2015 9:39 AM, Phil Reid wr

[PATCH net-next v4 2/4] rhashtable: add function to replace an element

2015-12-10 Thread Tom Herbert
Add the rhashtable_replace_fast function. This replaces one object in the table with another atomically. The hashes of the new and old objects must be equal. Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 82 ++ 1 file changed, 82 insertio

[PATCH net-next v4 4/4] ila: Add generic ILA translation facility

2015-12-10 Thread Tom Herbert
This patch implements an ILA tanslation table. This table can be configured with identifier to locator mappings, and can be be queried to resolve a mapping. Queries can be parameterized based on interface, direction (incoming or outoing), and matching locator. The table is implemented using rhasht

[PATCH net-next v4 1/4] ila: Create net/ipv6/ila directory

2015-12-10 Thread Tom Herbert
Create ila directory in preparation for supporting other hooks in the kernel than LWT for doing ILA. This includes: - Moving ila.c to ila/ila_lwt.c - Splitting out some common functions into ila_common.c Signed-off-by: Tom Herbert --- net/ipv6/Makefile | 2 +- net/ipv6/ila.c

[PATCH net-next v4 3/4] netlink: add a start callback for starting a netlink dump

2015-12-10 Thread Tom Herbert
The start callback allows the caller to set up a context for the dump callbacks. Presumably, the context can then be destroyed in the done callback. Signed-off-by: Tom Herbert --- include/linux/netlink.h | 2 ++ include/net/genetlink.h | 2 ++ net/netlink/af_netlink.c | 4 net/netlink/

[PATCH net-next v4 0/4] ila: Optimization to preserve value of early demux

2015-12-10 Thread Tom Herbert
In the current implementation of ILA, LWT is used to perform translation on both the input and output paths. This is functional, however there is a big performance hit in the receive path. Early demux occurs before the routing lookup (a hit actually obviates the route lookup). Therefore the stack c

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-10 Thread Francois Romieu
Corinna Vinschen : [...] > It's still a bit weird. On the machines I tested this on, if I disable > LanWake and shutdown the machine, I can send, e.g., MagicPackets as much > as I like, the machined don't come up. Isn't it a bit misleading then > if ethtool reports that some WoL method is enable

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-12-10 Thread Joe Stringer
On 10 December 2015 at 13:43, Or Gerlitz wrote: > On Thu, Dec 10, 2015 at 11:23 PM, Joe Stringer wrote: >> On 10 December 2015 at 13:06, Or Gerlitz wrote: >>> On Wed, Dec 9, 2015 at 2:22 AM, Joe Stringer wrote: > >> As far as the mask, I briefly discussed this with Jarno and it seems >>

Suspicious RCU from iwlwifi driver

2015-12-10 Thread Laura Abbott
Hi, I'm currently seeing a suspicous RCU usage warning: === [ INFO: suspicious RCU usage. ] 4.4.0-rc4-next-20151210 #23 Not tainted --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1226 suspicious rcu_dereference_protected()

RE: [Intel-wired-lan] [next PATCH 11/11] ixgbe: Clean stale VLANs when changing port vlan or resetting

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:11 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 11/11] ixgbe: Cle

RE: [Intel-wired-lan] [next PATCH 10/11] ixgbe: Clear stale pool mappings

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 10/11] ixgbe: Cle

RE: [Intel-wired-lan] [next PATCH 04/11] ixgbe: Reduce VT code indent in set_vfta by introducing jump label

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 04/11] ixgbe: Red

RE: [Intel-wired-lan] [next PATCH 09/11] ixgbe: Fix VLAN promisc in relation to SR-IOV

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 09/11] ixgbe: Fix

RE: [Intel-wired-lan] [next PATCH 02/11] ixgbe: Fix SR-IOV VLAN pool configuration

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 02/11] ixgbe: Fix

RE: [Intel-wired-lan] [next PATCH 05/11] ixgbe: Simplify configuration of setting VLVF and VLVFB

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 05/11] ixgbe: Sim

RE: [Intel-wired-lan] [next PATCH 08/11] ixgbe: Add support for VLAN promiscuous with SR-IOV

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 08/11] ixgbe: Add

RE: [Intel-wired-lan] [next PATCH 07/11] ixgbe: Reorder search to work from the top down instead of bottom up

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 07/11] ixgbe: Reo

RE: [Intel-wired-lan] [next PATCH 06/11] ixgbe: Add support for adding/removing VLAN on PF bypassing the VLVF

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 06/11] ixgbe: Add

RE: [Intel-wired-lan] [next PATCH 03/11] ixgbe: Simplify definitions for regidx and bit in set_vfta

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:10 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 03/11] ixgbe: Sim

RE: [Intel-wired-lan] [next PATCH 01/11] ixgbe: Return error on failure to allocate mac_table

2015-12-10 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alexander Duyck > Sent: Monday, November 02, 2015 5:09 PM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [next PATCH 01/11] ixgbe: Ret

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

2015-12-10 Thread Stefan Schmidt
Hello. On 10/12/15 19:16, Marcel Holtmann wrote: Hi Stefan, From: Markus Elfring Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-10 Thread Corinna Vinschen
On Dec 10 21:40, Francois Romieu wrote: > Corinna Vinschen : > [...] > > I could do this (after I could lay my hands on such a board, that is), > > but I'm not convinced that this makes a lot of sense for two reasons. > > Ok, let's get this change applied. Whatever happens should not be > hard to

Re: [PATCH net-next v4 2/8] netfilter: Factor out nf_ct_get_info().

2015-12-10 Thread Jarno Rajahalme
> On Dec 10, 2015, at 11:14 AM, Pablo Neira Ayuso wrote: > > On Tue, Dec 08, 2015 at 05:01:04PM -0800, Jarno Rajahalme wrote: >> Define a new inline function to map conntrack status to enum >> ip_conntrack_info. This removes the need to otherwise duplicate this >> code in a later patch ("openvs

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-12-10 Thread Or Gerlitz
On Thu, Dec 10, 2015 at 11:23 PM, Joe Stringer wrote: > On 10 December 2015 at 13:06, Or Gerlitz wrote: >> On Wed, Dec 9, 2015 at 2:22 AM, Joe Stringer wrote: > As far as the mask, I briefly discussed this with Jarno and it seems > like it could be something as simple as zeroing the ip_

[PATCH net-next] bpf, inode: allow for rename and link ops

2015-12-10 Thread Daniel Borkmann
Add support for renaming and hard links to the fs. Most of this can be implemented by using simple library operations under the same constraints that we don't use a reserved name like elsewhere. Linking can be useful to share/manage things like maps across subsystem users. It works within the file

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-12-10 Thread Joe Stringer
On 10 December 2015 at 13:06, Or Gerlitz wrote: > On Wed, Dec 9, 2015 at 2:22 AM, Joe Stringer wrote: >> On 8 December 2015 at 13:23, Or Gerlitz wrote: >>> On Tue, Dec 8, 2015 at 9:20 PM, Joe Stringer wrote: > > Apologies for the delayed response, we haven't found anything > interesting

Re: [PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

2015-12-10 Thread Alex Bennée
Stefan Hajnoczi writes: > From: Asias He > > VM sockets virtio transport implementation. This module runs in guest > kernel. checkpatch warns on a bunch of whitespace/tab issues. > > Signed-off-by: Asias He > Signed-off-by: Stefan Hajnoczi > --- > v2: > * Fix total_tx_buf accounting > * A

Re: [PATCH net-next v3 3/3] geneve: Remote Checksum Offload support

2015-12-10 Thread Jesse Gross
On Thu, Dec 10, 2015 at 12:37 PM, Tom Herbert wrote: > Add support for remote checksum offload in both the normal and GRO > paths. netlinks command are used to enable sending of the Remote > Checksum Data, and allow processing of it on receive. > > Signed-off-by: Tom Herbert Tom, can you please

Re: [RFC PATCHv2 net-next 1/2] tcp: RTO Restart (RTOR)

2015-12-10 Thread Per Hurtig
> 10 dec. 2015 kl. 16:37 skrev Neal Cardwell : > >> On Thu, Dec 10, 2015 at 1:51 AM, Per Hurtig wrote: >> >>> On 08 Dec 2015, at 14:47, Eric Dumazet wrote: >>> >>> On Tue, 2015-12-08 at 10:19 +0100, Per Hurtig wrote: >>> +static u32 tcp_unsent_pkts(const struct sock *sk, u32 ulimit) >>

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-12-10 Thread Or Gerlitz
On Wed, Dec 9, 2015 at 2:22 AM, Joe Stringer wrote: > On 8 December 2015 at 13:23, Or Gerlitz wrote: >> On Tue, Dec 8, 2015 at 9:20 PM, Joe Stringer wrote: Apologies for the delayed response, we haven't found anything interesting yet although we've mostly looked at plain set-field >>>

Re: Checksum offload queries

2015-12-10 Thread Rustad, Mark D
Edward Cree wrote: > I have just realised something startling. Assuming the inner protocol uses > the ones complement checksum in the way IP, UDP and TCP do, the outer > checksum can be computed *without looking at the payload*. Why? Because the > ones complement sum of (say) a correctly ch

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-10 Thread Francois Romieu
Corinna Vinschen : [...] > I could do this (after I could lay my hands on such a board, that is), > but I'm not convinced that this makes a lot of sense for two reasons. Ok, let's get this change applied. Whatever happens should not be hard to manage (I'm thinking about other boards or BIOSes rel

[PATCH net-next v3 1/3] rco: Clean up casting errors

2015-12-10 Thread Tom Herbert
Fixe a couple of cast errors found by sparse. Signed-off-by: Tom Herbert --- include/net/checksum.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/checksum.h b/include/net/checksum.h index 9fcaedf..10a16b5 100644 --- a/include/net/checksum.h +++ b/include/net/c

[PATCH net-next v3 3/3] geneve: Remote Checksum Offload support

2015-12-10 Thread Tom Herbert
Add support for remote checksum offload in both the normal and GRO paths. netlinks command are used to enable sending of the Remote Checksum Data, and allow processing of it on receive. Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 162 ---

[PATCH net-next v3 0/3] geneve: Add support for Remote Checksum Offload

2015-12-10 Thread Tom Herbert
This patch set adds UDP checksum configuration via netlink and Remote Checksum Offload for Geneve, v2: - Fix type in commi log v3: - Fix issue of taking sizeof a pointer instead of the actual object (for real) Testing (10Gbps mlx4): Single connection TCP_STREAM in netperf - No UDP checks

[PATCH net-next v3 2/3] geneve: UDP checksum configuration via netlink

2015-12-10 Thread Tom Herbert
Add support to enable and disable UDP checksums via netlink. This is similar to how VXLAN and GUE allow this. This includes support for enabling the UDP zero checksum (for both TX and RX). Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 93 +-

[PATCH net-next v2 1/3] rco: Clean up casting errors

2015-12-10 Thread Tom Herbert
Fixe a couple of cast errors found by sparse. Signed-off-by: Tom Herbert --- include/net/checksum.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/checksum.h b/include/net/checksum.h index 9fcaedf..10a16b5 100644 --- a/include/net/checksum.h +++ b/include/net/c

[PATCH net-next v2 0/3] geneve: Add support for Remote Checksum Offload

2015-12-10 Thread Tom Herbert
This patch set adds UDP checksum configuration via netlink and Remote Checksum Offload for Geneve, v2: - Fix issue of taking sizeof a pointer instead of the actual object - Fix type in commi log Testing (10Gbps mlx4): Single connection TCP_STREAM in netperf - No UDP checksums, no RCO

[PATCH net-next v2 3/3] geneve: Remote Checksum Offload support

2015-12-10 Thread Tom Herbert
Add support for remote checksum offload in both the normal and GRO paths. netlinks command are used to enable sending of the Remote Checksum Data, and allow processing of it on receive. Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 162 ---

[PATCH net-next v2 2/3] geneve: UDP checksum configuration via netlink

2015-12-10 Thread Tom Herbert
Add support to enable and disable UDP checksums via netlink. This is similar to how VXLAN and GUE allow this. This includes support for enabling the UDP zero checksum (for both TX and RX). Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 93 +-

Re: Checksum offload queries

2015-12-10 Thread Edward Cree
On 10/12/15 16:26, Tom Herbert wrote: > It sounds like potentially interesting work. You'll probably want my patches > that provider helper functions that allow a driver to verify that it can > offload a checksum. We'll have to update those also to allow two checksums. I have just realised somet

[PATCH net 2/4] mpls: don't dump RTA_VIA attribute if not specified

2015-12-10 Thread Robert Shearman
The problem seen is that when adding a route with a nexthop with no via address specified, iproute2 generates bogus output: # ip -f mpls route add 100 dev lo # ip -f mpls route list 100 via inet 0.0.8.0 dev lo The reason for this is that the kernel generates an RTA_VIA attribute with the fa

[PATCH net 1/4] mpls: validate L2 via address length

2015-12-10 Thread Robert Shearman
If an L2 via address for an mpls nexthop is specified, the length of the L2 address must match that expected by the output device, otherwise it could access memory beyond the end of the via address buffer in the route. This check was present prior to commit f8efb73c97e2 ("mpls: multipath route sup

[PATCH net 0/4] mpls: fixes for nexthops without via addresses

2015-12-10 Thread Robert Shearman
These four fixes all apply to the case of having an mpls route with an output device, but without a nexthop. Patches 2 and 3 could really have been combined in one patch, but I wanted to separate the fix for some recent breakage from the fix for a day-1 issue. Robert Shearman (4): mpls: validat

[PATCH net 4/4] mpls: make via address optional for multipath routes

2015-12-10 Thread Robert Shearman
The via address is optional for a single path route, yet is mandatory when the multipath attribute is used: # ip -f mpls route add 100 dev lo # ip -f mpls route add 101 nexthop dev lo RTNETLINK answers: Invalid argument Make them consistent by making the via address optional when the RTA_MU

[PATCH net 3/4] mpls: fix out-of-bounds access when via address not specified

2015-12-10 Thread Robert Shearman
When a via address isn't specified, the via table is left initialised to 0 (NEIGH_ARP_TABLE), and the via address length also left initialised to 0. This results in a via address array of length 0 being allocated (contiguous with route and nexthop array), meaning that when a packet is sent using ne

Re: [PATCH net-next v4 2/8] netfilter: Factor out nf_ct_get_info().

2015-12-10 Thread Pablo Neira Ayuso
On Tue, Dec 08, 2015 at 05:01:04PM -0800, Jarno Rajahalme wrote: > Define a new inline function to map conntrack status to enum > ip_conntrack_info. This removes the need to otherwise duplicate this > code in a later patch ("openvswitch: Find existing conntrack entry > after upcall."). > > Signed

Re: [PATCH net-next v4 8/8] openvswitch: Interface with NAT.

2015-12-10 Thread Pablo Neira Ayuso
On Tue, Dec 08, 2015 at 05:01:10PM -0800, Jarno Rajahalme wrote: > - /* Call the helper right after nf_conntrack_in() for confirmed > - * connections, but only when commiting for unconfirmed connections. > - */ > ct = nf_ct_get(skb, &ctinfo); > - if (ct && (nf_ct_is_confirme

[PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-10 Thread Haiyang Zhang
In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the locking for MSD (Multi-Send Data) field was removed. This could cause a race condition between RNDIS control messages and data packets processing, because these two types of traffic are not synchronized. This patch fixes thi

Re: [PATCH] sched/cls_flow.c : allow nfct-* keys work on ingress interfaces

2015-12-10 Thread Cong Wang
Hello, On Thu, Dec 10, 2015 at 5:24 AM, Гаврилов Игорь wrote: > Improved CTTUPLE macro with code from sched/act_connmark.c, so it be able to > get unNATed addresses from nf_conntrack. Please follow the guideline to submit a formal kernel patch: https://www.kernel.org/doc/Documentation/Submittin

Re: [PATCH net v2] net: Flush local routes when device changes vrf association

2015-12-10 Thread Nikolay Aleksandrov
On 12/10/2015 07:25 PM, David Ahern wrote: > The VRF driver cycles netdevs when an interface is enslaved or released: > the down event is used to flush neighbor and route tables and the up > event (if the interface was already up) effectively moves local and > connected routes to the proper table.

[PATCH net v2] net: Flush local routes when device changes vrf association

2015-12-10 Thread David Ahern
The VRF driver cycles netdevs when an interface is enslaved or released: the down event is used to flush neighbor and route tables and the up event (if the interface was already up) effectively moves local and connected routes to the proper table. As of 4f823defdd5b the local route is left hanging

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

2015-12-10 Thread Marcel Holtmann
Hi Stefan, >>> From: Markus Elfring >>> Date: Mon, 16 Nov 2015 13:50:23 +0100 >>> >>> The kfree_skb() function tests whether its argument is NULL and then >>> returns immediately. Thus the test around the call is not needed. >>> >>> This issue was detected by using the Coccinelle software. >>>

Re: [PATCH net] sfc: only use RSS filters if we're using RSS

2015-12-10 Thread David Miller
From: Bert Kenward Date: Thu, 10 Dec 2015 13:30:08 + > Without this filter insertion on a VF would fail if only one channel > was in use. This would include the unicast station filter and therefore > no traffic would be received. > > Signed-off-by: Bert Kenward > --- > drivers/net/ethernet

Re: [BUG] net: performance regression on ixgbe (Intel 82599EB 10-Gigabit NIC)

2015-12-10 Thread Rick Jones
On 12/10/2015 06:18 AM, Otto Sabart wrote: *) Is irqbalance disabled and the IRQs set the same each time, or might there be variability possible there? Each of the five netperf runs will be a different four-tuple which means each may (or may not) get RSS hashed/etc differently. The irqbalance

RE: [PATCH net] ipv6: sctp: clone options to avoid use after free

2015-12-10 Thread David Laight
From: Eric Dumazet > Sent: 10 December 2015 15:58 > > BTW, are you even using IPv6 SCTP sessions ? Our M3UA/SCTP protocol stack supports them and defaults to using IPv6 listening sockets for IPv4 connections. I very much doubt than any customers have used them yet. So most of the IPv6 connections

Re: [PATCH v5 1/4] stmmac: create of compatible mdio bus for stmacc driver

2015-12-10 Thread Giuseppe CAVALLARO
Hi also pls fix this typo stmmac: create of compatible mdio bus for stmacc driver stmmac On 12/9/2015 9:39 AM, Phil Reid wrote: The DSA driver needs to be passed a reference to an mdio bus. Typically th

[PATCH net] uapi: export ila.h

2015-12-10 Thread Stephen Hemminger
The file ila.h used for lightweight tunnels is being used by iproute2 but is not exported yet. Signed-off-by: Stephen Hemminger --- include/uapi/linux/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild index 628e6e6..c2e5d6c 100644 --

Re: [PATCH] ip neigh: device is optional for proxy entries

2015-12-10 Thread Stephen Hemminger
On Tue, 01 Dec 2015 01:17:06 +0300 Konstantin Khlebnikov wrote: > Though dumping such entries crashes present kernels. > > Signed-off-by: Konstantin Khlebnikov Applied thanks, but I nobody will use it until after your kernel patch makes it to stable. -- To unsubscribe from this list: send the

Re: [PATCH iproute2 -next] examples, bpf: further improve examples

2015-12-10 Thread Stephen Hemminger
On Wed, 2 Dec 2015 00:25:36 +0100 Daniel Borkmann wrote: > Improve example files further and add a more generic set of possible > helpers for them that can be used. > > Signed-off-by: Daniel Borkmann Sure, applied to net-next -- To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH iproute] ila: Add support for ILA lwtunnels

2015-12-10 Thread Stephen Hemminger
On Mon, 30 Nov 2015 14:57:28 -0800 Tom Herbert wrote: > This patch: > - Adds a utility function for parsing a 64 bit address > - Adds a utility function for converting a 64 bit address to ASCII > - Adds and ILA encap type in lwt tunnels > > Signed-off-by: Tom Herbert Looks good applied. Yo

Re: [PATCH iproute2] vrf: Add support for table names

2015-12-10 Thread Stephen Hemminger
On Tue, 8 Dec 2015 12:24:44 -0800 David Ahern wrote: > Currently, the table id for VRF devices requires an integer. Convert > it to use rtnl_rttable_a2n which handles table names from the iproute2 > directory. > > This also fixes a bug in the original commit where table name are not > properly

Re: [iproute PATCH] route: ignore RTAX_HOPLIMIT of value -1

2015-12-10 Thread Stephen Hemminger
On Wed, 2 Dec 2015 12:50:22 + Phil Sutter wrote: > Older kernels use -1 internally as indicator to use the sysctl default, > but they still export the setting. Newer kernels use 0 to indicate that > (which is why the conversion from -1 to 0 was done here), but they also > stopped exporting th

Re: [PATCH iproute2] libnetlink: don't confuse variables in rtnl_talk()

2015-12-10 Thread Stephen Hemminger
On Thu, 3 Dec 2015 17:13:48 +0100 Nicolas Dichtel wrote: > There is two variables named 'len' in rtnl_talk. In fact, commit > c079e121a73a didn't work. For example, it was possible to trigger > a seg fault with this command: > $ ip link set gre2 type ip6gre hoplimit 32 > > Let's rename the argu

Re: [PATCH 1/4] list: introduce list_is_first()

2015-12-10 Thread Jiri Kosina
On Thu, 10 Dec 2015, Jens Axboe wrote: > It's a balance, as we also should not make APIs out of everything. As I said, > purely my opinion, but I think the is_last/is_first have jumped the shark. I don't have a strong opinion either way. What I think we should do though, is to either have both (

Re: [iproute PATCH] tc.8: Fix reference to tc-tcindex.8

2015-12-10 Thread Stephen Hemminger
On Thu, 10 Dec 2015 13:24:51 +0100 Phil Sutter wrote: > Just a typo there, it's spelled correctly in SEE ALSO section.. > > Signed-off-by: Phil Sutter Applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH net] net: Flush local routes when device changes vrf association

2015-12-10 Thread David Ahern
On 12/9/15 6:35 PM, David Ahern wrote: The VRF driver cycles netdevs when an interface is enslaved or released: the down event is used to flush neighbor and route tables and the up event (if the interface was already up) effectively moves local and connected routes to the proper table. As of 4f8

Re: Checksum offload queries

2015-12-10 Thread Tom Herbert
On Thu, Dec 10, 2015 at 7:49 AM, Edward Cree wrote: > On 09/12/15 18:00, Tom Herbert wrote: >> That is not at all true. If the stack has set up VXLAN RCO and the > device >> decides to set the inner checksum itself then the checksum > will be bad. >> The checksum interface is very specific pleas

Re: [PATCH net] ipv6: sctp: clone options to avoid use after free

2015-12-10 Thread Eric Dumazet
On Thu, 2015-12-10 at 12:26 +, David Laight wrote: > Yes, I'm worried about whether our M3UA code is likely to crash customer > systems, not whether hostile applications can crash it. > These boxes ought to be on private networks since the sigtran protocols > themselves have nothing that even

Re: Checksum offload queries

2015-12-10 Thread Edward Cree
On 09/12/15 18:00, Tom Herbert wrote: > That is not at all true. If the stack has set up VXLAN RCO and the > device > decides to set the inner checksum itself then the checksum > will be bad. The > checksum interface is very specific please read it > carefully (sk_buff.h), > if the driver/device

Re: [PATCH 1/4] list: introduce list_is_first()

2015-12-10 Thread Christoph Hellwig
On Thu, Dec 10, 2015 at 09:23:57AM -0600, Josh Poimboeuf wrote: > Personally I would disagree. Something like: > > if (list_is_first(&rq->queuelist, &nd->queue)) > > is much more readable to me than: > > if (rq->queuelist.prev == &nd->queue) > > The first one takes no effort for me -- it's

Re: [PATCH 1/4] list: introduce list_is_first()

2015-12-10 Thread Jens Axboe
On 12/10/2015 08:23 AM, Josh Poimboeuf wrote: On Thu, Dec 10, 2015 at 08:10:34AM -0700, Jens Axboe wrote: On 12/10/2015 07:17 AM, Geliang Tang wrote: We already have list_is_last(), it makes sense to also add list_is_first() for consistency. This list utility function to check for first element

Re: [RFC PATCHv2 net-next 1/2] tcp: RTO Restart (RTOR)

2015-12-10 Thread Neal Cardwell
On Thu, Dec 10, 2015 at 1:51 AM, Per Hurtig wrote: > >> On 08 Dec 2015, at 14:47, Eric Dumazet wrote: >> >> On Tue, 2015-12-08 at 10:19 +0100, Per Hurtig wrote: >> >>> +static u32 tcp_unsent_pkts(const struct sock *sk, u32 ulimit) >>> +{ >>> +struct sk_buff *skb = tcp_send_head(sk); >>> +

Re: [PATCH 1/4] list: introduce list_is_first()

2015-12-10 Thread Josh Poimboeuf
On Thu, Dec 10, 2015 at 08:10:34AM -0700, Jens Axboe wrote: > On 12/10/2015 07:17 AM, Geliang Tang wrote: > >We already have list_is_last(), it makes sense to also add > >list_is_first() for consistency. This list utility function > >to check for first element in a list. > > Honestly, I think we a

[PATCH v1 1/2] net:hns: annotate IO address space properly

2015-12-10 Thread Andy Shevchenko
Mark address pointer with __iomem in the IO accessors. Otherwise we will get a sparse complain like following .../hns/hns_dsaf_reg.h:991:36: warning: incorrect type in argument 1 (different address spaces) .../hns/hns_dsaf_reg.h:991:36:expected unsigned char [noderef] [usertype] *base .../h

[PATCH v1 2/2] net:hns: print MAC with %pM

2015-12-10 Thread Andy Shevchenko
printf() has a dedicated specifier to print MAC addresses. Use it instead of pushing each byte via stack. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 49 +++--- 1 file changed, 14 insertions(+), 35 deletions(-) diff --git a/drivers/net

[PATCH net-next V1 9/9] net/mlx5e: Rename en_flow_table.c to en_fs.c

2015-12-10 Thread Saeed Mahameed
From: Maor Gottlieb Rename en_flow_table.c to en_fs.c in order to be aligned with the new flow steering files. Signed-off-by: Maor Gottlieb Signed-off-by: Moni Shoua Signed-off-by: Matan Barak Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- ..

[PATCH net-next V1 3/9] net/mlx5_core: Introduce flow steering firmware commands

2015-12-10 Thread Saeed Mahameed
From: Maor Gottlieb Introduce new Flow Steering (FS) firmware commands, in-order to support the new flow steering infrastructure. Signed-off-by: Maor Gottlieb Signed-off-by: Moni Shoua Signed-off-by: Matan Barak Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/Makef

[PATCH net-next V1 2/9] net/mlx5e: Assign random MAC address if needed

2015-12-10 Thread Saeed Mahameed
Under SRIOV there might be a case where VFs are loaded without pre-assigned MAC address. In this case, the VF will randomize its own MAC. This will address the case of administrator not assigning MAC to the VF through the PF OS APIs and keep udev happy. Signed-off-by: Saeed Mahameed --- drivers

[PATCH net-next V1 5/9] net/mlx5_core: Add flow steering lookup algorithms

2015-12-10 Thread Saeed Mahameed
From: Maor Gottlieb Introduce the flow steering mlx5_flow_namespace (Namespace) and fs_prio (Flow Steering Priority) tree nodes. Namespaces are used in order to isolate different usages or types of steering (for example, downstream patches will add a different namespaces for the NIC driver and f

[PATCH net-next V1 8/9] net/mlx5: Use flow steering infrastructure for mlx5_en

2015-12-10 Thread Saeed Mahameed
From: Maor Gottlieb Expose the new flow steering API and remove the old one. Few changes are required: 1. The Ethernet flow steering follows the existing implementation, but uses the new steering API. The old flow steering implementation is removed. 2. Move the E-switch FDB management to use t

[PATCH net-next V1 6/9] net/mlx5_core: Introduce flow steering API

2015-12-10 Thread Saeed Mahameed
From: Maor Gottlieb Introducing the following objects: mlx5_flow_root_namespace: represent the root of specific flow table type tree(e.g NIC receive, FDB, etc..) mlx5_flow_group: define the mask of the flow specification. fs_fte(flow steering flow table entry): defines the value of the flow sp

[PATCH net-next V1 0/9] mlx5 improved flow steering management

2015-12-10 Thread Saeed Mahameed
Hi Dave, First two patches fixes some minor issues in recently introduced SRIOV code. The other seven patches modifies the driver's code that manages flow steering rules with Connectx-4 devices. Basic introduction: The flow steering device specification model is composed of the following enti

[PATCH net-next V1 7/9] net/mlx5_core: Flow steering tree initialization

2015-12-10 Thread Saeed Mahameed
From: Maor Gottlieb Flow steering initialization is based on static tree which illustrates the flow steering tree when the driver is loaded. The initialization considers the max supported flow table level of the device, a minimum of 2 kernel flow tables(vlan and mac) are required to have kernel f

[PATCH net-next V1 4/9] net/mlx5_core: Add flow steering base data structures

2015-12-10 Thread Saeed Mahameed
From: Maor Gottlieb Introducing the base data structure and its operations that are going to represent ConnectX-4 Flow Steering, this data structure is basically a tree and all Flow steering objects such as (Flow Table/Flow Group/FTE/etc ..) are represented as fs_node(s). fs_node is the base obj

[PATCH net-next V1 1/9] net/mlx5: Fix query E-Switch capabilities

2015-12-10 Thread Saeed Mahameed
E-Switch capabilities should be queried only if E-Switch flow table is supported and not only when vport group manager. Fixes: d753c6e8 ("net/mlx5: E-Switch, Introduce HCA cap and E-Switch vport context") Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fw.c |2

Re: [PATCH 1/4] list: introduce list_is_first()

2015-12-10 Thread Jens Axboe
On 12/10/2015 07:17 AM, Geliang Tang wrote: We already have list_is_last(), it makes sense to also add list_is_first() for consistency. This list utility function to check for first element in a list. Honestly, I think we already have way too many of these kind of helpers. IMHO they don't real

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-10 Thread Gregory CLEMENT
Hi Sascha, On jeu., déc. 10 2015, Sascha Hauer wrote: > Hi Gregory, > > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: >> With device tree it is no more possible to reset the PHY at board >> level. Furthermore, doing in the driver allow to power down the PHY when >> the netwo

[PATCH 4/4] elevator: use list_is_{first,last}

2015-12-10 Thread Geliang Tang
For better readability, use list_is_{first,last}() instead of open-coded. Signed-off-by: Geliang Tang --- block/noop-iosched.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/noop-iosched.c b/block/noop-iosched.c index a163c48..d44326e 100644 --- a/block/noop-iosche

[PATCH 1/4] list: introduce list_is_first()

2015-12-10 Thread Geliang Tang
We already have list_is_last(), it makes sense to also add list_is_first() for consistency. This list utility function to check for first element in a list. Signed-off-by: Geliang Tang --- include/linux/list.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linux/list.h

[PATCH 2/4] livepatch: use list_is_first()

2015-12-10 Thread Geliang Tang
For better readability, use list_is_first() instead of open-coded. Signed-off-by: Geliang Tang --- kernel/livepatch/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index bc2c85c..be64106 100644 --- a/kernel/livepatch/co

[PATCH 3/4] netfilter: ipset: use list_is_first()

2015-12-10 Thread Geliang Tang
For better readability, use list_is_first() instead of open-coded. Signed-off-by: Geliang Tang --- net/netfilter/ipset/ip_set_list_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipset/ip_set_list_set.c b/net/netfilter/ipset/ip_set_list_set.c index bbede9

Re: [BUG] net: performance regression on ixgbe (Intel 82599EB 10-Gigabit NIC)

2015-12-10 Thread Otto Sabart
Hi Rick, > *) It is good to be binding netperf and netserver - helps with > reproducibility, but why the two -T options? A brief look at src/netsh.c > suggests it will indeed set the two binding options separately but that is > merely a side-effect of how I wrote the code. It wasn't an intentio

Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

2015-12-10 Thread Peter Hurley
Hi Tilman, On 12/09/2015 03:10 AM, Tilman Schmidt wrote: > Am 09.12.2015 um 00:12 schrieb Paul Bolle: > >>> --- a/drivers/isdn/gigaset/ser-gigaset.c >>> +++ b/drivers/isdn/gigaset/ser-gigaset.c >>> @@ -370,19 +370,23 @@ static void gigaset_freecshw(struct cardstate >>> *cs) >>> tasklet_kill(&

Re: [PATCH] [BACKPORT] [3.14.56] bnx2x: Don't notify about scratchpad parities

2015-12-10 Thread Patrick Schaaf
On Friday 06 November 2015 09:32:46 Greg KH wrote: > On Thu, Nov 05, 2015 at 11:18:37AM +0100, Patrick Schaaf wrote: > > bnx2x: Don't notify about scratchpad parities > > > > This is a (trivial) "backport" of ad6afbe9578d1fa26680faf78c846bd8c00d1d6e > > to stable kernel 3.14.56. > > This patch is

  1   2   >