Re: Fixing full name in patchwork

2015-12-07 Thread Kalle Valo
Sudip Mukherjee writes: > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: >> Hi Sudip, >> >> Sudip Mukherjee writes: >> >> > We were dereferencing cmd first and checking for NULL later. Lets first >> > check for NULL. >> > >> > Signed-off-by: Sudip Mukherjee >> >> I noticed that

[PATCH v2] net: thunderx: Correctly distinguish between VF and LMAC count

2015-12-07 Thread Pavel Fedin
Commit bc69fdfc6c13 ("net: thunderx: Enable BGX LMAC's RX/TX only after VF is up") introduces lmac_cnt member and starts verifying VF number against it. This is plain wrong, and works only because currently we have hardcoded 1:1 mapping between VFs and LMACs, and in this case num_vf_en and lmac_cnt

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-07 Thread John Fastabend
On 15-12-02 04:15 PM, Tom Herbert wrote: > On Wed, Dec 2, 2015 at 3:35 PM, John Fastabend > wrote: >> [...] >> I wonder why we need protocol generic offloads? I know there are currently a lot of overlay encapsulation protocols. Are there many more coming? >>> Yes, and ass

Re: [P.A. Semi] Does the ethernet interface work on your Electra, Chitra, Nemo, and Athena board?

2015-12-07 Thread Denis Kirjanov
On 12/7/15, Christian Zigotzky wrote: > Hi all, > > I have some good news for you. I was able to fix the issue with the P.A. > Semi Ethernet. It was a problem with the new DMA handling. The patch ' > [RFC/PATCH,v2] powerpc/iommu: Support "hybrid" iommu/direct DMA ops for > coherent_mask < dma_mask

Re: MPLS decap with iproute2

2015-12-07 Thread Sam Russell
Thanks all for your help, I got it working with Robert and Roopa's sysctl settings, the following works: ip route -f mpls add 100 dev lo On 8 December 2015 at 15:37, roopa wrote: > On 12/7/15, 11:42 AM, Sam Russell wrote: >> Hi, >> >> I've had success with the iproute2 manpage example for encaps

Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage

2015-12-07 Thread Yankejian (Hackim Yim)
On 2015/12/8 14:30, Du, Fan wrote: > > > On 2015/12/8 14:22, Yankejian (Hackim Yim) wrote: >> >> On 2015/12/7 16:58, Du, Fan wrote: >>> > >>> > >>> >On 2015/12/5 15:32, yankejian wrote: >>here is the patch raising the performance of XGE by: >>1)changes the way page management method for

Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage

2015-12-07 Thread Du, Fan
On 2015/12/8 14:22, Yankejian (Hackim Yim) wrote: On 2015/12/7 16:58, Du, Fan wrote: > > >On 2015/12/5 15:32, yankejian wrote: >>here is the patch raising the performance of XGE by: >>1)changes the way page management method for enet momery, and >>2)reduces the count of rmb, and >>3)adds Mem

Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage

2015-12-07 Thread Yankejian (Hackim Yim)
On 2015/12/7 16:58, Du, Fan wrote: > > > On 2015/12/5 15:32, yankejian wrote: >> here is the patch raising the performance of XGE by: >> 1)changes the way page management method for enet momery, and >> 2)reduces the count of rmb, and >> 3)adds Memory prefetching > > Any numbers on how much it boo

netlink: Add missing goto statement to netlink_insert

2015-12-07 Thread Herbert Xu
On Mon, Dec 07, 2015 at 07:58:25AM +0100, Stefan Priebe - Profihost AG wrote: > > Thanks, good. Can you help me to get this fix upstream into the stable > lines? Sure. Greg, please apply this patch to fix up the backport for 4.1. ---8<--- The backport of 1f770c0a09da855a2b51af6d19de97fb955eca85

next-20151207 - crash in IPv6 code

2015-12-07 Thread Valdis Kletnieks
Seen this in 2 boots out of two on next-20151207 when IPV6 networking was available. It was stable when no net was available. Also, next-20161127 is OK. Haven't bisected it yet - this ring any bells? [ 92.231022] BUG: unable to handle kernel NULL pointer dereference at

[PATCH v3 1/4] stmmac: create of compatible mdio bus for stmacc driver

2015-12-07 Thread Phil Reid
The DSA driver needs to be passed a reference to an mdio bus. Typically the mac is configured to use a fixed link but the mdio bus still needs to be registered so that it con configure the switch. This patch follows the same process as the altera tse ethernet driver for creation of the mdio bus. A

[PATCH v3 2/4] stmmac: Correct documentation on stmmac clocks.

2015-12-07 Thread Phil Reid
devm_get_clk looks in clock-name property for matching clock. the ptp_ref_clk property is ignored. Acked-by: Rob Herring Signed-off-by: Phil Reid --- Documentation/devicetree/bindings/net/stmmac.txt | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/Documentat

[PATCH v3 0/4] stmmac: Fixed Phy & PTP fixes

2015-12-07 Thread Phil Reid
Provide ability to specify a fixed phy in the device tree and retain the mdio bus if no phy is found. This is needed where a dsa is connected via a fixed phy and uses the mdio bus for config. Fixed ptp ref clock calculatins for the stmmac when ptp ref clock is running at <= 50Mhz. Also add device

[PATCH v3 3/4] stmmac: Fix calculations for ptp counters when clock input = 50Mhz.

2015-12-07 Thread Phil Reid
stmmac_config_sub_second_increment set the sub second increment to 20ns. Driver is configured to use the fine adjustment method where the sub second register is incremented when the acculumator incremented by the addend register wraps overflows. This accumulator is update on every ptp clk cycle. If

[PATCH v3 4/4] stmmac: socfpga: Provide dt node to config ptp clk source.

2015-12-07 Thread Phil Reid
Provides an options to use the ptp clock routed from the Altera FPGA fabric. Instead of the defalt eosc1 clock connected to the ARM HPS core. This setting affects all emacs in the core as the ptp clock is common. Signed-off-by: Phil Reid --- Documentation/devicetree/bindings/net/socfpga-dwmac.tx

Re: Fixing full name in patchwork

2015-12-07 Thread Sudip Mukherjee
On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: > Hi Sudip, > > Sudip Mukherjee writes: > > > We were dereferencing cmd first and checking for NULL later. Lets first > > check for NULL. > > > > Signed-off-by: Sudip Mukherjee > > I noticed that your name in git log is not your full

[PATCHv2 net-next 4/7] cxgb4: prevent simultaneous execution of service_ofldq()

2015-12-07 Thread Hariprasad Shenai
Change mutual exclusion mechanism to prevent multiple threads of execution from running in service_ofldq() at the same time. The old mechanism used an implicit guard on the down-call path and none on the restart path and wasn't working. This checking makes the mechanism explicit and is much easier

[PATCHv2 net-next 2/7] cxgb4/cxgb4vf: update Kconfig file to include T6 adapter

2015-12-07 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/Kconfig | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/chelsio/Kconfig b/drivers/net/ethernet/chelsio/Kconfig index a79813a..4d187f2 100644 --- a/drivers/net/ethernet/che

[PATCHv2 net-next 6/7] cxgb4: Add FL DMA mapping error and low counter

2015-12-07 Thread Hariprasad Shenai
Add Free List DMA Mapping Errors to SGE Queue info for Free Lists. Add Free List "Low" counter to count the number of times we see the number of pointers that we _think_ the hardware sees in the Free List below the Egress Threshold. Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chels

[PATCHv2 net-next 7/7] cxgb4: Adds PCI device id for new T5 adapters

2015-12-07 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index 03ed00c..a8dda63 100644 --- a/drivers/net/e

[PATCHv2 net-next 5/7] cxgb4: Deal with wrap-around of queue for Work request

2015-12-07 Thread Hariprasad Shenai
The WR headers may not fit within one descriptor. So we need to deal with wrap-around here. Based on original patch by Pranjal Joshi Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 57 +--- 1 file changed, 53 insertions(+), 4 deletio

[PATCHv2 net-next 0/7] Update Kconfig and some fixes for cxgb4

2015-12-07 Thread Hariprasad Shenai
Hi This series update Kconfig to add description for Chelsio's next generation T6 family of adapters, also fixes ethtool stats alignment and prevents simultaneous execution of service_ofldq thread, deals with queue wrap around and adds some fl counters for debugging purpose and device ID for new T

[PATCHv2 net-next 1/7] cxgb4: Align rest of the ethtool get stats

2015-12-07 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 146 ++--- 1 file changed, 73 insertions(+), 73 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c index a077f

[PATCHv2 net-next 3/7] cxgb4: Use ACCES_ONCE macro to read queue's consumer index

2015-12-07 Thread Hariprasad Shenai
Use helper macro ACCESS_ONCE() to load from the SGE status page to prevent the compiler loading multiple times. Based on original work by Mike Werner Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH net-next] vrf: Add ip rules at vrf device create

2015-12-07 Thread David Ahern
VRFs require ip rules for route lookups to work properly. Currently creating a VRF means instantiating a device and then adding the 4 ip and ip6 rules: ip link add vrf-${VRF} type vrf table ${TBID} ip ru add oif vrf-${VRF} table ${TBID} ip ru add iif vrf-${VRF} table ${TBID} ip -6

RE: [PATCH] r8152: fix lockup when runtime PM is enabled

2015-12-07 Thread Hayes Wang
Peter Wu [mailto:pe...@lekensteyn.nl] > Sent: Tuesday, December 08, 2015 12:59 AM [...] > + if (tp->netdev->flags & IFF_UP) { Maybe you could just replace the checking of netif_running(tp->netdev) with this. Excuse me. I have a question. Before the open() is finished, the ne

Re: [PATCH] fix inverted test in __skb_recv_datagram

2015-12-07 Thread David Miller
From: Rainer Weikusat Date: Mon, 07 Dec 2015 23:30:58 + > As the kernel generally uses negated error numbers, *err needs to be > compared with -EAGAIN (d'oh). > > Signed-off-by: Rainer Weikusat > Fixes: ea3793ee29d3 Improperly formatted Fixes: tag, you must also include the commit header l

[PATCH net] geneve: Fix IPv6 xmit stats update.

2015-12-07 Thread Pravin B Shelar
Call to iptunnel_xmit_stats() is not required after udp-tunnel6-xmit. By calling iptunnel_xmit_stats() results in incorrect device stats. Following patch drops this call. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --g

[PATCH v2 net-next] net: hns: optimize XGE capability by reducing cpu usage

2015-12-07 Thread Kejian Yan
here is the patch raising the performance of XGE by: 1)changes the way page management method for enet momery, and 2)reduces the count of rmb, and 3)adds Memory prefetching Signed-off-by: Kejian Yan --- change log: v2: fixes the review comments by Devid and joe: - makes indented properly - rem

Re: MPLS decap with iproute2

2015-12-07 Thread roopa
On 12/7/15, 11:42 AM, Sam Russell wrote: > Hi, > > I've had success with the iproute2 manpage example for encapsulating > outgoing traffic in MPLS, but I've not found a way to add decap routes > inbound. > > I've tried "ip route -f mpls add 100 dev lo" and other variations, but I > get netlink erro

Re: [RFC PATCH net-next 1/2] tcp: RTO Restart (RTOR)

2015-12-07 Thread Yuchung Cheng
On Mon, Dec 7, 2015 at 1:00 AM, Per Hurtig wrote: > This patch implements the RTO restart modification (RTOR). When data is > ACKed, and the RTO timer is restarted, the time elapsed since the last > outstanding segment was transmitted is subtracted from the calculated RTO > value. This way, the RT

Re: [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board

2015-12-07 Thread Yankejian (Hackim Yim)
On 2015/12/7 21:48, Bintian wrote: > On 2015/12/7 21:16, Rob Herring wrote: >> On Sat, Dec 05, 2015 at 03:54:48PM +0800, yankejian wrote: >>> This patch adds documentation for the devicetree bindings used by the >>> DT files of Hisilicon Hip05-D02 development board. >>> >>> Signed-off-by: yankeji

Re: [PATCH 3/3] sh_eth: get rid of bb_{set|clr|read}()

2015-12-07 Thread Simon Horman
On Tue, Dec 08, 2015 at 12:41:43AM +0300, Sergei Shtylyov wrote: > After the MDIO bitbang code consolidation, there's no need anymore for > bb_{set|clr}() as well as bb_read() -- just expand them inline, thus > saving more LoCs... > > Signed-off-by: Sergei Shtylyov Acked-by: Simon Horman -- To

Re: [PATCH 2/3] sh_eth: factor out common code from MDIO bitbang methods

2015-12-07 Thread Simon Horman
On Tue, Dec 08, 2015 at 12:40:57AM +0300, Sergei Shtylyov wrote: > sh_mm[cd]_ctrl() and sh_set_mdio() all look mostly the same -- factor out > their common code and put it into sh_mdio_ctrl(). > > Signed-off-by: Sergei Shtylyov Acked-by: Simon Horman -- To unsubscribe from this list: send the

Re: [PATCH 1/3] sh_eth: remove mask fields from 'struct bb_info'

2015-12-07 Thread Simon Horman
On Tue, Dec 08, 2015 at 12:40:19AM +0300, Sergei Shtylyov wrote: > The MDIO control bits are always mapped to the same bits of the same register > (PIR), so there's no need to store their masks in the 'struct bb_info'... > > Signed-off-by: Sergei Shtylyov Acked-by: Simon Horman -- To unsubscrib

Re: [PATCH] net: emac: emac gigabit ethernet controller driver

2015-12-07 Thread Gilad Avidov
On Tue, 8 Dec 2015 00:33:04 +0100 Felix Fietkau wrote: > On 2015-12-07 23:58, Gilad Avidov wrote: > > +/* RRD (Receive Return Descriptor) */ > > +union emac_rrd { > > + struct { > > + /* 32bit word 0 */ > > + u32 xsum:16; > > + u32 nor:4; /* number of RFD

Re: [PATCH] net: emac: emac gigabit ethernet controller driver

2015-12-07 Thread kbuild test robot
Hi Gilad, [auto build test ERROR on net/master] [also build test ERROR on v4.4-rc4 next-20151207] url: https://github.com/0day-ci/linux/commits/Gilad-Avidov/net-emac-emac-gigabit-ethernet-controller-driver/20151208-070026 config: openrisc-allyesconfig (attached as .config) reproduce

Re: [PATCH] net: emac: emac gigabit ethernet controller driver

2015-12-07 Thread Felix Fietkau
On 2015-12-07 23:58, Gilad Avidov wrote: > +/* RRD (Receive Return Descriptor) */ > +union emac_rrd { > + struct { > + /* 32bit word 0 */ > + u32 xsum:16; > + u32 nor:4; /* number of RFD */ > + u32 si:12; /* start index of rfd-ring

[PATCH] fix inverted test in __skb_recv_datagram

2015-12-07 Thread Rainer Weikusat
As the kernel generally uses negated error numbers, *err needs to be compared with -EAGAIN (d'oh). Signed-off-by: Rainer Weikusat Fixes: ea3793ee29d3 --- diff --git a/net/core/datagram.c b/net/core/datagram.c index 7daff66..fa9dc64 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -27

Re: [PATCH net] macvlan: fix leak in macvlan_handle_frame

2015-12-07 Thread Paul Gortmaker
On Sun, Dec 6, 2015 at 6:35 PM, Paul Gortmaker wrote: > On Tue, Nov 17, 2015 at 2:40 PM, David Miller wrote: >> From: Sabrina Dubroca >> Date: Mon, 16 Nov 2015 22:54:20 +0100 >> >>> Reset pskb in macvlan_handle_frame in case skb_share_check returned a >>> clone. >>> >>> Fixes: 8a4eb5734e8d ("net

breaks blocking receive for other users (was: [PATCH 01/02] core: enable more fine-grained datagram reception control)

2015-12-07 Thread Rainer Weikusat
David Miller writes: > From: Rainer Weikusat > Date: Sun, 06 Dec 2015 21:11:34 + > >> The __skb_recv_datagram routine in core/ datagram.c provides a general >> skb reception factility supposed to be utilized by protocol modules >> providing datagram sockets. It encompasses both the actual rec

[PATCH 1/8] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it

2015-12-07 Thread Tejun Heo
cgroup_is_descendant() currently walks up the hierarchy and compares each ancestor to the cgroup in question. While enough for cgroup core usages, this can't be used in hot paths to test cgroup membership. This patch adds cgroup->ancestor_ids[] which records the IDs of all ancestors including self

[PATCH 2/8] kernfs: implement kernfs_walk_and_get()

2015-12-07 Thread Tejun Heo
Implement kernfs_walk_and_get() which is similar to kernfs_find_and_get() but can walk a path instead of just a name. v2: Use strlcpy() instead of strlen() + memcpy() as suggested by David. Signed-off-by: Tejun Heo Acked-by: Greg Kroah-Hartman Cc: David Miller --- fs/kernfs/dir.c|

[PATCHSET v4] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

2015-12-07 Thread Tejun Heo
Hello, This is v4 of the xt_cgroup2 patchset. Changes from v3 are * Refreshed on top of net-next/master e72c932d3f8a ("cxgb3: Convert simple_strtoul to kstrtox"). Dropped "cgroups: Allow dynamically changing net_classid" from series as it's already applied. The changes from v2 to v3 are *

[PATCH 3/8] cgroup: implement cgroup_get_from_path() and expose cgroup_put()

2015-12-07 Thread Tejun Heo
Implement cgroup_get_from_path() using kernfs_walk_and_get() which obtains a default hierarchy cgroup from its path. This will be used to allow cgroup path based matching from outside cgroup proper - e.g. networking and perf. v2: Add EXPORT_SYMBOL_GPL(cgroup_get_from_path). Signed-off-by: Tejun

[PATCH 6/8] sock, cgroup: add sock->sk_cgroup

2015-12-07 Thread Tejun Heo
In cgroup v1, dealing with cgroup membership was difficult because the number of membership associations was unbound. As a result, cgroup v1 grew several controllers whose primary purpose is either tagging membership or pull in configuration knobs from other subsystems so that cgroup membership te

[PATCH 7/8] netfilter: prepare xt_cgroup for multi revisions

2015-12-07 Thread Tejun Heo
xt_cgroup will grow cgroup2 path based match. Postfix existing symbols with _v0 and prepare for multi revision registration. Signed-off-by: Tejun Heo Cc: Daniel Borkmann Cc: Daniel Wagner CC: Neil Horman Cc: Jan Engelhardt Cc: Pablo Neira Ayuso --- include/uapi/linux/netfilter/xt_cgroup.h

[PATCH 4/8] netprio_cgroup: limit the maximum css->id to USHRT_MAX

2015-12-07 Thread Tejun Heo
netprio builds per-netdev contiguous priomap array which is indexed by css->id. The array is allocated using kzalloc() effectively limiting the maximum ID supported to some thousand range. This patch caps the maximum supported css->id to USHRT_MAX which should be way above what is actually useabl

[PATCH 5/8] net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct

2015-12-07 Thread Tejun Heo
Introduce sock->sk_cgrp_data which is a struct sock_cgroup_data. ->sk_cgroup_prioidx and ->sk_classid are moved into it. The struct and its accessors are defined in cgroup-defs.h. This is to prepare for overloading the fields with a cgroup pointer. This patch mostly performs equivalent conversio

[PATCH 8/8] netfilter: implement xt_cgroup cgroup2 path match

2015-12-07 Thread Tejun Heo
This patch implements xt_cgroup path match which matches cgroup2 membership of the associated socket. The match is recursive and invertible. For rationales on introducing another cgroup based match, please refer to a preceding commit "sock, cgroup: add sock->sk_cgroup". v3: Folded into xt_cgroup

Re: [PATCH net] xfrm: take care of request sockets

2015-12-07 Thread David Miller
From: Eric Dumazet Date: Mon, 07 Dec 2015 08:53:17 -0800 > From: Eric Dumazet > > TCP SYNACK messages might now be attached to request sockets. > > XFRM needs to get back to a listener socket. > > Adds new helpers that might be used elsewhere : > sk_to_full_sk() and sk_const_to_full_sk() > >

Re: [PATCH net] ipv6: sctp: fix lockdep splat in sctp_v6_get_dst()

2015-12-07 Thread David Miller
From: Eric Dumazet Date: Mon, 07 Dec 2015 08:25:21 -0800 > From: Eric Dumazet > > While cooking the sctp np->opt rcu fixes, I forgot to move > one rcu_read_unlock() after the added rcu_dereference() in > sctp_v6_get_dst() > > This gave lockdep warnings reported by Dave Jones. > > Fixes: c836a

Re: [PATCH net] vxlan: interpret IP headers for ECN correctly

2015-12-07 Thread David Miller
From: Jiri Benc Date: Mon, 7 Dec 2015 16:29:08 +0100 > When looking for outer IP header, use the actual socket address family, not > the address family of the default destination which is not set for metadata > based interfaces (and doesn't have to match the address family of the > received pack

Re: pull request [net]: batman-adv 20151207

2015-12-07 Thread David Miller
From: Antonio Quartulli Date: Mon, 7 Dec 2015 23:12:11 +0800 > I know it starts to be a bit late in the release cycle, but I think that > these 4 small bug-fixes are still worth being merged. Pulled, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM

2015-12-07 Thread Shannon Nelson
Acked-by: Shannon Nelson wrote: > From: Sowmini Varadhan > Date: Mon, 7 Dec 2015 15:06:34 -0500 > >> This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC >> address in Open Firmware or IDPROM"). >> >> As with that fix, attempt to look up the MAC address in Open Firmware >> on s

Re: MPLS decap with iproute2

2015-12-07 Thread Sam Russell
Hi Robert, Thanks for the tip, I'll give it a shot when I get home this evening (UTC+13). I'm planning to put together a blog on how to manually string up an MPLS l3vpn, to help people start playing with the new MPLS support now that it's finally in the mainline kernel. Cheers Sam -- To unsubscri

Re: [PATCH v2 1/1] cxgb3: Convert simple_strtoul to kstrtox

2015-12-07 Thread David Miller
From: LABBE Corentin Date: Mon, 7 Dec 2015 14:11:33 +0100 > the simple_strtoul function is obsolete. This patch replace it by > kstrtox. > > Signed-off-by: LABBE Corentin Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord..

Re: MPLS decap with iproute2

2015-12-07 Thread Robert Shearman
On 07/12/15 19:42, Sam Russell wrote: Hi, I've had success with the iproute2 manpage example for encapsulating outgoing traffic in MPLS, but I've not found a way to add decap routes inbound. I've tried "ip route -f mpls add 100 dev lo" and other variations, but I get netlink errors back. Has t

[PATCH 3/3] sh_eth: get rid of bb_{set|clr|read}()

2015-12-07 Thread Sergei Shtylyov
After the MDIO bitbang code consolidation, there's no need anymore for bb_{set|clr}() as well as bb_read() -- just expand them inline, thus saving more LoCs... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 27 ++- 1 file changed, 6 insertio

[PATCH 2/3] sh_eth: factor out common code from MDIO bitbang methods

2015-12-07 Thread Sergei Shtylyov
sh_mm[cd]_ctrl() and sh_set_mdio() all look mostly the same -- factor out their common code and put it into sh_mdio_ctrl(). Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 35 +++--- 1 file changed, 12 insertions(+), 23 deletions(-) Ind

[PATCH 1/3] sh_eth: remove mask fields from 'struct bb_info'

2015-12-07 Thread Sergei Shtylyov
The MDIO control bits are always mapped to the same bits of the same register (PIR), so there's no need to store their masks in the 'struct bb_info'... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 22 +++--- 1 file changed, 7 insertions(+), 15 del

[PATCH 0/3] sh_eth: optimize MDIO code

2015-12-07 Thread Sergei Shtylyov
Hello. Here's a set of 3 patches against DaveM's 'net-next.git' repo which gets rid of ~35 LoCs in the MDIO bitbang methods. [1/3] sh_eth: remove mask fields from 'struct bb_info' [2/3] sh_eth: factor out common code from MDIO bitbang methods [3/3] sh_eth: get rid of bb_{set|clr|read}() MBR,

Re: [PATCH v3 net-next 0/4] Further fix for dsa unbinding

2015-12-07 Thread David Miller
From: Neil Armstrong Date: Mon, 7 Dec 2015 13:57:31 +0100 > This serie fixes further issues for DSA dynamic unbinding. > The first patch completely removes the PHY link state polling. > The two following cleans up the dsa state upon removal. > The last patch moves slave destroy code as slave fun

Re: [PATCH net] mpls: fix sending of local encapped packets

2015-12-07 Thread David Miller
From: Robert Shearman Date: Mon, 7 Dec 2015 12:53:15 + > Locally generated IPv4 and (probably) IPv6 packets are dropped because > skb->protocol isn't set. We could write wrappers to lwtunnel_output > for IPv4 and IPv6 that set the protocol accordingly and then call > lwtunnel_output, but mpls

Re: [PATCH net v3 0/2] vxlan: IPv6 fill_metadata_dst support

2015-12-07 Thread David Miller
From: Jiri Benc Date: Mon, 7 Dec 2015 13:04:29 +0100 > This adds IPv6 support to ndo_fill_metadata_dst in vxlan. The IPv4 part > needs some restructuring to avoid duplicate code, this will be sent as > a separate patch targeting net-next. Series applied. -- To unsubscribe from this list: send t

Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM

2015-12-07 Thread David Miller
From: Sowmini Varadhan Date: Mon, 7 Dec 2015 15:06:34 -0500 > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware > on systems that support it, and use IDPROM on

Re: use-after-free in sctp_do_sm

2015-12-07 Thread Marcelo Ricardo Leitner
Em 07-12-2015 18:37, Vlad Yasevich escreveu: On 12/07/2015 02:50 PM, Marcelo Ricardo Leitner wrote: On Mon, Dec 07, 2015 at 02:33:52PM -0500, Vlad Yasevich wrote: On 12/07/2015 01:52 PM, Marcelo Ricardo Leitner wrote: Vlad, I reviewed the places on which it returns SCTP_DISPOSITION_ABORT, and

Re: [PATCH v3 net-next 0/4] Further fix for dsa unbinding

2015-12-07 Thread Florian Fainelli
On 07/12/15 04:57, Neil Armstrong wrote: > This serie fixes further issues for DSA dynamic unbinding. > The first patch completely removes the PHY link state polling. > The two following cleans up the dsa state upon removal. > The last patch moves slave destroy code as slave function and > adds mis

Re: use-after-free in sctp_do_sm

2015-12-07 Thread Vlad Yasevich
On 12/07/2015 02:50 PM, Marcelo Ricardo Leitner wrote: > On Mon, Dec 07, 2015 at 02:33:52PM -0500, Vlad Yasevich wrote: >> On 12/07/2015 01:52 PM, Marcelo Ricardo Leitner wrote: >>> On Mon, Dec 07, 2015 at 02:20:47PM +0100, Dmitry Vyukov wrote: On Mon, Dec 7, 2015 at 2:15 PM, Marcelo Ricardo L

[PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM

2015-12-07 Thread Sowmini Varadhan
This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC address in Open Firmware or IDPROM"). As with that fix, attempt to look up the MAC address in Open Firmware on systems that support it, and use IDPROM on SPARC if no OF address is found. In the case of the i40e there is an a

Re: use-after-free in sctp_do_sm

2015-12-07 Thread Marcelo Ricardo Leitner
On Mon, Dec 07, 2015 at 02:33:52PM -0500, Vlad Yasevich wrote: > On 12/07/2015 01:52 PM, Marcelo Ricardo Leitner wrote: > > On Mon, Dec 07, 2015 at 02:20:47PM +0100, Dmitry Vyukov wrote: > >> On Mon, Dec 7, 2015 at 2:15 PM, Marcelo Ricardo Leitner > >> wrote: > >>> On Mon, Dec 07, 2015 at 12:26:09

Re: [PATCH net-next] Driver for IBM System i/p VNIC protocol

2015-12-07 Thread David Miller
From: Thomas Falcon Date: Mon, 7 Dec 2015 12:50:00 -0600 > Hi. Thanks for you feedback. Could you clarify on what constitutes > basic operation? I just want to be sure if we should remove the > other module parameters or just this one in particular? With very minute exceptions, there should be

MPLS decap with iproute2

2015-12-07 Thread Sam Russell
Hi, I've had success with the iproute2 manpage example for encapsulating outgoing traffic in MPLS, but I've not found a way to add decap routes inbound. I've tried "ip route -f mpls add 100 dev lo" and other variations, but I get netlink errors back. Has this been built yet? Is there sample conf

Re: Checksum offload queries

2015-12-07 Thread David Miller
From: Edward Cree Date: Mon, 7 Dec 2015 15:39:52 + > 1) Receive checksums. Given that CHECKSUM_UNNECESSARY conversion > exists (and is a cheap operation), what is the advantage to the > stack of using CHECKSUM_COMPLETE if the packet happens to be a > protocol which CHECKSUM_UNNECESSARY conve

Re: rhashtable: Use __vmalloc with GFP_ATOMIC for table allocation

2015-12-07 Thread David Miller
From: Thomas Graf Date: Mon, 7 Dec 2015 16:35:24 +0100 > Did you look into what __vmalloc prevents to work with BH disabled? You can't issue the cross-cpu TLB flushes from atomic contexts. It's the kernel page table updates that create the restriction. -- To unsubscribe from this list: send the

Re: use-after-free in sctp_do_sm

2015-12-07 Thread Vlad Yasevich
On 12/07/2015 01:52 PM, Marcelo Ricardo Leitner wrote: > On Mon, Dec 07, 2015 at 02:20:47PM +0100, Dmitry Vyukov wrote: >> On Mon, Dec 7, 2015 at 2:15 PM, Marcelo Ricardo Leitner >> wrote: >>> On Mon, Dec 07, 2015 at 12:26:09PM +0100, Dmitry Vyukov wrote: On Sat, Dec 5, 2015 at 5:39 PM, Vlad

Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms

2015-12-07 Thread Josh Cartwright
On Mon, Dec 07, 2015 at 11:58:33AM +0100, Neil Armstrong wrote: > On some platforms, the macb integration does not use the USRIO > register to configure the (R)MII port and clocks. > When the register is not implemented and the MACB error signal > is connected to the bus error, reading or writing t

Re: [PATCH v2 net 0/4] qed: Bug fixes

2015-12-07 Thread David Miller
From: Manish Chopra Date: Mon, 7 Dec 2015 06:25:55 -0500 > Please consider applying this series to net. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or

Re: pull-request: mac80211-next 2015-12-07

2015-12-07 Thread David Miller
From: Johannes Berg Date: Mon, 07 Dec 2015 11:19:34 +0100 > This is the first pull request for 4.5 from me - apologies for taking > so long and letting it grow, we had a bunch of issues to figure out, > most of which ended up unrelated to this code. > > I don't know what git is doing with the di

Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms

2015-12-07 Thread David Miller
From: Neil Armstrong Date: Mon, 7 Dec 2015 11:58:33 +0100 > - regs_buff[12] = macb_or_gem_readl(bp, USRIO); > + if (!of_property_read_bool(bp->pdev->dev.of_node, "no-usrio")) { > + regs_buff[12] = macb_or_gem_readl(bp, USRIO); > + } Single statement basic blocks shall no

Re: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA

2015-12-07 Thread David Miller
From: Geert Uytterhoeven Date: Mon, 7 Dec 2015 10:09:06 +0100 > If NO_DMA=y: > > ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined! > ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined! > ERROR: "dma_sync_single_for_cpu" [drivers/net/et

Re: use-after-free in sctp_do_sm

2015-12-07 Thread Marcelo Ricardo Leitner
On Mon, Dec 07, 2015 at 02:20:47PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 7, 2015 at 2:15 PM, Marcelo Ricardo Leitner > wrote: > > On Mon, Dec 07, 2015 at 12:26:09PM +0100, Dmitry Vyukov wrote: > >> On Sat, Dec 5, 2015 at 5:39 PM, Vlad Yasevich wrote: ... > >> > Hi Marcelo > >> > > >> > I thin

Re: [PATCH net-next] Driver for IBM System i/p VNIC protocol

2015-12-07 Thread Thomas Falcon
On 12/05/2015 09:25 PM, David Miller wrote: > From: Thomas Falcon > Date: Fri, 4 Dec 2015 11:49:46 -0600 > >> +static int ibmvnic_buffs_per_pool = IBMVNIC_BUFFS_PER_POOL; >> +module_param(ibmvnic_buffs_per_pool, int, S_IRUGO); >> +MODULE_PARM_DESC(ibmvnic_buffs_per_pool, >> + "IBMVNIC

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-07 Thread Alexander Duyck
On Mon, Dec 7, 2015 at 9:39 AM, Michael S. Tsirkin wrote: > On Mon, Dec 07, 2015 at 09:12:08AM -0800, Alexander Duyck wrote: >> On Mon, Dec 7, 2015 at 7:40 AM, Lan, Tianyu wrote: >> > On 12/5/2015 1:07 AM, Alexander Duyck wrote: >> > If can't do that, we have to stop DMA in a short time to mark

Re: gigaset: freeing an active object

2015-12-07 Thread Tilman Schmidt
Am 07.12.2015 um 13:25 schrieb Paul Bolle: >>> Otherwise we'd still be freeing memory >>> managed through reference counting. >> >> Now I#m confused. I thought by following Peter's suggestion to put the >> kfree() in the release method we'd avoid just that. > > Apparently it does, because I can't

Re: [PATCH 0/2] net: thunderx: Miscellaneous cleanups

2015-12-07 Thread David Miller
From: Sunil Goutham Date: Mon, 7 Dec 2015 10:30:31 +0530 > This patch series contains contains couple of cleanup patches. Series applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [BUG] net: performance regression on ixgbe (Intel 82599EB 10-Gigabit NIC)

2015-12-07 Thread Rick Jones
On 12/07/2015 03:28 AM, Otto Sabart wrote: Hi Ota, It looks like there were a few changes that went through that could be causing the regression. The most obvious one that jumps out at me is commit 72bfd32d2f84 ("ixgbe: disable LRO by default"). As such one thing you might try doing is turning

Fixing full name in patchwork

2015-12-07 Thread Kalle Valo
Hi Sudip, Sudip Mukherjee writes: > We were dereferencing cmd first and checking for NULL later. Lets first > check for NULL. > > Signed-off-by: Sudip Mukherjee I noticed that your name in git log is not your full name: commit 0a38c8e1b592c16d959da456f425053e323a5153 Author: sudip Date: Tu

Re: [PATCH net] mpls: fix sending of local encapped packets

2015-12-07 Thread Sam Russell
I can confirm that this patch works for IPv4 and IPv6 modprobe mpls_router modprobe mpls_gso modprobe mpls_iptunnel ifconfig enp0s8 192.168.99.2/24 up ifconfig enp0s9 up arp -s 192.168.99.5 00:12:34:56:78:90 ip -6 neigh add fe80::a00:27ff:1234:5678 lladdr 00:12:34:56:78:90 dev enp0s8 ./dev/iprout

Re: Checksum offload queries

2015-12-07 Thread Tom Herbert
On Mon, Dec 7, 2015 at 9:29 AM, Tom Herbert wrote: > On Mon, Dec 7, 2015 at 7:39 AM, Edward Cree wrote: >> Having decided to take Dave Miller's advice to push our hardware guys in the >> direction of generic checksum offload, I found I wasn't quite sure exactly >> what's being encouraged. Afte

pull-request: wireless-drivers-next 2015-12-07

2015-12-07 Thread Kalle Valo
Hi Dave, here's the first "real" pull request after the wireless directory reorganisation. Nothing really out ordinary, new features and bugfixes as usual. This time there's a regression in ath10k because of a bugfix in wireless-drivers.git which conflicted with a patch in wireless-drivers-next.gi

Re: [PATCH net] ravb: Remove clear unhandled interrupt

2015-12-07 Thread Sergei Shtylyov
Hello. On 12/07/2015 07:59 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi AVB-DMAC Reception Warning interrupt is not enabled, so it is not necessary to clear the interrupt. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko In principle I agree but perhaps we shoul

[PATCH RFC 22/26] phylink: add EEE support

2015-12-07 Thread Russell King
Add EEE hooks to phylink to allow the phylib EEE functions for the connected phy to be safely accessed. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 58 ++- include/linux/phylink.h | 7 +- 2 files changed, 63 insertions(+), 2 dele

[PATCH RFC 19/26] phylink: add flow control support

2015-12-07 Thread Russell King
Add flow control support, including ethtool support, to phylink. We add support to allow ethtool to get and set the current flow control settings, and the 802.3 specified resolution for the local and remote link partner abilities. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 128

[PATCH RFC 15/26] net: mvneta: convert to phylink

2015-12-07 Thread Russell King
Convert mvneta to use phylink, which models the MAC to PHY link in a generic, reusable form. Signed-off-by: Russell King --- drivers/net/ethernet/marvell/Kconfig | 2 +- drivers/net/ethernet/marvell/mvneta.c | 399 +++--- 2 files changed, 224 insertions(+), 177 del

[PATCH RFC 20/26] net: mvneta: add flow control support via phylink

2015-12-07 Thread Russell King
Add flow control support to mvneta, including the ethtool hooks. This uses the phylink code to calculate the result of autonegotiation where a phy is attached, and to handle the ethtool settings. Signed-off-by: Russell King --- drivers/net/ethernet/marvell/mvneta.c | 29

[PATCH RFC 26/26] sfp/phylink: hook up eeprom functions

2015-12-07 Thread Russell King
Signed-off-by: Russell King --- drivers/net/phy/sfp.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 678298844203..feb5f7062b2c 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -902,11 +

[PATCH RFC 16/26] phy: fixed-phy: remove fixed_phy_update_state()

2015-12-07 Thread Russell King
mvneta is the only user of fixed_phy_update_state(), which has been converted to use phylink instead. Remove fixed_phy_update_state(). Signed-off-by: Russell King --- drivers/net/phy/fixed_phy.c | 31 --- include/linux/phy_fixed.h | 9 - 2 files changed, 4

[PATCH RFC 13/26] sfp: add phylink based SFP module support

2015-12-07 Thread Russell King
Add support for SFP hotpluggable modules via phylink. This supports both copper and optical SFP modules, which require different Serdes modes in order to properly negotiate the link. Optical SFP modules typically require the Serdes link to be talking 1000base-X mode - this is the gigabit ethernet

[PATCH RFC 23/26] net: mvneta: add EEE support

2015-12-07 Thread Russell King
Add EEE support to mvneta. This allows us to enable the low power idle support at MAC level if there is a PHY attached through phylink which supports LPI. The appropriate ethtool support is provided to allow the feature to be controlled, including ethtool statistics for EEE wakeup errors. Signed

  1   2   3   >