Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread Jiri Pirko
Mon, Nov 16, 2015 at 07:48:34AM CET, pjonn...@broadcom.com wrote: >> >> Thu, Nov 12, 2015 at 05:02:18PM CET, pjonn...@broadcom.com wrote: >> >Packet forwarding to/from bond interfaces is done in software. >> > >> >This patch enables certain platforms to bridge traffic to/from >> >bond interfaces i

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread David Miller
From: Premkumar Jonnala Date: Mon, 16 Nov 2015 06:49:49 + >> Thank you for the feedback David. I am currently handling/implementing >> these notifications in a custom (closed source) driver. I will update the >> diff >> with an actual demo of the handler, and resend the diffs. > > Clarifi

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread David Miller
From: Premkumar Jonnala Date: Mon, 16 Nov 2015 06:12:24 + > Thank you for the feedback David. I am currently handling/implementing > these notifications in a custom (closed source) driver. I will update the > diff > with an actual demo of the handler, and resend the diffs. No, I don't wa

RE: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread Premkumar Jonnala
> -Original Message- > From: Premkumar Jonnala > Sent: Monday, November 16, 2015 11:42 AM > To: 'David Miller'; f.faine...@gmail.com > Cc: netdev@vger.kernel.org; sfel...@gmail.com; j...@resnulli.us; > niko...@cumulusnetworks.com; ido...@mellanox.com; > go...@cumulusnetworks.com > Subject

RE: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread Premkumar Jonnala
> > Thu, Nov 12, 2015 at 05:02:18PM CET, pjonn...@broadcom.com wrote: > >Packet forwarding to/from bond interfaces is done in software. > > > >This patch enables certain platforms to bridge traffic to/from > >bond interfaces in hardware. Notifications are sent out when > >the "active" slave set f

RE: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread Premkumar Jonnala
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Saturday, November 14, 2015 2:42 AM > To: Premkumar Jonnala > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH] bonding: Offloading bonds to hardware > > On Thu, Nov 12, 2015 at 04:02:18PM +, Premkumar Jonnala w

RE: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread Premkumar Jonnala
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, November 14, 2015 12:40 AM > To: f.faine...@gmail.com > Cc: Premkumar Jonnala; netdev@vger.kernel.org; sfel...@gmail.com; > j...@resnulli.us; niko...@cumulusnetworks.com; ido...@mellanox.com; > go...@

RE: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread Premkumar Jonnala
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Saturday, November 14, 2015 12:09 AM > To: Premkumar Jonnala; netdev@vger.kernel.org; sfel...@gmail.com; > j...@resnulli.us; niko...@cumulusnetworks.com; ido...@mellanox.com; > go...@cumulusnetworks.com >

Re: [net] net: fix feature changes on devices without ndo_set_features

2015-11-15 Thread Dave Young
On 11/15/15 at 03:25pm, Dave Young wrote: > On 11/13/15 at 02:54pm, Nikolay Aleksandrov wrote: > > From: Nikolay Aleksandrov > > > > When __netdev_update_features() was updated to ensure some features are > > disabled on new lower devices, an error was introduced for devices which > > don't have

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-11-15 Thread Dave Young
On 11/15/15 at 09:38am, Joe Perches wrote: > On Sun, 2015-11-15 at 15:31 +0800, Dave Young wrote: > > cfg80211 module prints a lot of messages like below. Actually printing > > once is acceptable but sometimes it will print again and again, it looks > > very annoying. It is better to change these d

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-11-15 Thread Dave Young
Hi, On 11/15/15 at 07:25pm, Stefan Lippers-Hollmann wrote: > Hi > > On 2015-11-15, Dave Young wrote: > > cfg80211 module prints a lot of messages like below. Actually printing > > once is acceptable but sometimes it will print again and again, it looks > > very annoying. It is better to change th

Re: Kernel 4.1 hang, apparently in __inet_lookup_established

2015-11-15 Thread Grant Zhang
Hi Patrick, Have you tried the two patches Eric mentioned? One of my 4.1.11 server just hanged with very similar stack trace and I am wondering whether the aforementioned patches would help. Thanks, Grant On 23/09/2015 09:31, Eric Dumazet wrote: On Wed, 2015-09-23 at 10:25 +0200, Patrick S

Re: [PATCH net 0/6] Mellanox NIC driver update, Nov 12, 2015

2015-11-15 Thread David Miller
From: Or Gerlitz Date: Thu, 12 Nov 2015 19:35:24 +0200 > Few small mlx5 and mlx4 fixes from the team... done over > net commit c5a3788 "Merge branch 'akpm' (patches from Andrew)" > > Eran's patch needs to go to 4.2 and 4.3 stable kernels. > > Tariq's patch need to go to 4.3 stable too. Series

Re: [PATCH net] ipvs: use skb_to_full_sk() helper

2015-11-15 Thread David Miller
From: Eric Dumazet Date: Thu, 12 Nov 2015 09:14:12 -0800 > From: Eric Dumazet > > SYNACK packets might be attached to request sockets. > > Use skb_to_full_sk() helper to avoid illegal accesses to > inet_sk(skb->sk) > > Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets inste

Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

2015-11-15 Thread David Miller
From: Eric Dumazet Date: Thu, 12 Nov 2015 08:43:18 -0800 > From: Eric Dumazet > > Some functions access TCP sockets without holding a lock and > might output non consistent data, depending on compiler and or > architecture. > > tcp_diag_get_info(), tcp_get_info(), tcp_poll(), get_tcp4_sock() .

Re: [PATCH] net: thunder: Fix crash upon shutdown after failed probe

2015-11-15 Thread David Miller
From: Pavel Fedin Date: Thu, 12 Nov 2015 14:55:18 +0300 > If device probe fails, driver remains bound to the PCI device. However, > driver data has been reset to NULL. This causes crash upon dereferencing > it in nicvf_remove() > > Signed-off-by: Pavel Fedin Applied, thanks. -- To unsubscribe

Re: [PATCH net] sctp: translate host order to network order when setting a hmacid

2015-11-15 Thread David Miller
From: Xin Long Date: Thu, 12 Nov 2015 13:07:07 +0800 > now sctp auth cannot work well when setting a hmacid manually, which > is caused by that we didn't use the network order for hmacid, so fix > it by adding the transformation in sctp_auth_ep_set_hmacs. > > even we set hmacid with the network

Re: [PATCH net v3 0/5] packet fixes

2015-11-15 Thread David Miller
From: Daniel Borkmann Date: Wed, 11 Nov 2015 23:25:39 +0100 > Fixes a couple of issues in packet sockets, i.e. on TX ring side. See > individual patches for details. > > v2 -> v3: > - First two patches unchanged, kept Jason's Ack > - Reworked 3rd patch and split into 3: > - check for dev typ

Re: [PATCH] tools/net: Use include/uapi with __EXPORTED_HEADERS__

2015-11-15 Thread David Miller
From: Kamal Mostafa Date: Wed, 11 Nov 2015 14:24:27 -0800 > Use the local uapi headers to keep in sync with "recently" added #define's > (e.g. SKF_AD_VLAN_TPID). Refactored CFLAGS, and bpf_asm doesn't need -I. > > Fixes: 3f356385e8a449e1d7cfc6b6f8d634ac4f5581a0 > Signed-off-by: Kamal Mostafa

Re: [PATCH net 0/3] ipv6: Fixes for pmtu update and DST_NOCACHE route

2015-11-15 Thread David Miller
From: Martin KaFai Lau Date: Wed, 11 Nov 2015 11:51:05 -0800 > This patchset fixes: > 1. An oops during IPv6 pmtu update on a IPv4 GRE running >in an IPSec setup > 2. Misc fixes on DST_NOCACHE route Series applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the

Re: [PATCH] fjes: fix inconsistent indenting

2015-11-15 Thread David Miller
From: Colin King Date: Wed, 11 Nov 2015 15:22:40 + > From: Colin Ian King > > minor change, indenting is one tab out. > > Signed-off-by: Colin Ian King Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread David Miller
From: Ondrej Zary Date: Sun, 15 Nov 2015 21:04:58 +0100 > Tested it with D-Link DGE-550T (chip marked DL-2000, probably > rebranded TC9020) and it works fine. Even the TC9020 datasheet > says: "Access Rule: Word, Double Word". So it was always wrong but > worked anyway. Great, thanks for the in

[PATCH 2/2] ipg: Remove ipg driver

2015-11-15 Thread Ondrej Zary
Now that IP1000A chips are supported by dl2k driver, the buggy ipg driver can be removed. Signed-off-by: Ondrej Zary --- MAINTAINERS |7 - drivers/net/ethernet/Kconfig |1 - drivers/net/ethernet/Makefile|1 - drivers/net/ethernet/icplus/Kconfi

[PATCH 1/2 v2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread Ondrej Zary
Add support for IP1000A chips to dl2k driver. IP1000A chip looks like a TC9020 with integrated PHY. This allows IP1000A chips to work reliably because the ipg driver is buggy - it loses packets under load and then completely stops transmitting data. Tested with Asus NX1101 v2.0 at 10, 100 and 100

Re: "hw csum failure" error on skge driver with 4.3 kernel upon receiving ICMPv6 multicast listener discovery packets

2015-11-15 Thread Stephen Hemminger
; Nov 15 17:52:13 pleiades kernel: [ 661.395192] [] > x86_64_start_reservations+0x2a/0x2c > Nov 15 17:52:13 pleiades kernel: [ 661.395192] [] > x86_64_start_kernel+0xe5/0xe8 > > > I can unfortunately offer no additional information: I will no longer > be using this Ethe

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread Ondrej Zary
On Sunday 15 November 2015 18:59:05 David Miller wrote: > From: Andy Shevchenko > Date: Sun, 15 Nov 2015 04:30:25 +0200 > > > On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary > > > >> @@ -433,9 +474,10 @@ rio_open (struct net_device *dev) > >> > >> alloc_list (dev); > >> > >> - /* Get s

"hw csum failure" error on skge driver with 4.3 kernel upon receiving ICMPv6 multicast listener discovery packets

2015-11-15 Thread David Madore
only access the machine physically on rare occasions, so I can do no further tests. Here are links to the basic config information, though: Kernel config: http://www.madore.org/~david/.tmp/config.20151115 Initial dmesg: http://www.madore.org/~david/.tmp/dmesg.20151115 -- David A. Madore

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-15 Thread Rainer Weikusat
Jason Baron writes: > On 11/13/2015 01:51 PM, Rainer Weikusat wrote: > > [...] > >> >> -if (unix_peer(other) != sk && unix_recvq_full(other)) { >> -if (!timeo) { >> -err = -EAGAIN; >> -goto out_unlock; >> -} >> +if (unix_pee

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-11-15 Thread Stefan Lippers-Hollmann
Hi On 2015-11-15, Dave Young wrote: > cfg80211 module prints a lot of messages like below. Actually printing > once is acceptable but sometimes it will print again and again, it looks > very annoying. It is better to change these detail messages to debugging > only. It is a lot of info, easily re

Re: [PATCH v2 0/6] net: dsa: mv88e6060: cleanup and fix setup

2015-11-15 Thread David Miller
From: Neil Armstrong Date: Tue, 10 Nov 2015 16:51:09 +0100 > This patchset introduces some fixes and a registers addressing cleanup for > the mv88e6060 DSA driver. > > The first patch removes the poll_link as mv88e6xxx. > The 3 following patches fixes the setup in regards of the datasheet. > The

Re: [PATCH net v3] af-unix: fix use-after-free with concurrent readers while splicing

2015-11-15 Thread David Miller
From: Hannes Frederic Sowa Date: Tue, 10 Nov 2015 16:23:15 +0100 > During splicing an af-unix socket to a pipe we have to drop all > af-unix socket locks. While doing so we allow another reader to enter > unix_stream_read_generic which can read, copy and finally free another > skb. If exactly thi

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread David Miller
From: Andy Shevchenko Date: Sun, 15 Nov 2015 04:30:25 +0200 > On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary >> @@ -433,9 +474,10 @@ rio_open (struct net_device *dev) >> >> alloc_list (dev); >> >> - /* Get station address */ >> - for (i = 0; i < 6; i++) >> - dw8(S

Re: [PATCH -stable] multiple backports requested

2015-11-15 Thread David Miller
From: "Charles (Chas) Williams" <3ch...@gmail.com> Date: Sun, 15 Nov 2015 06:19:09 -0500 > On Fri, 2015-11-13 at 16:10 -0500, David Miller wrote: >> From: "Charles (Chas) Williams" <3ch...@gmail.com> >> Date: Fri, 13 Nov 2015 15:13:11 -0500 >> >> > Dave, could you please add the following backpor

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-11-15 Thread Joe Perches
On Sun, 2015-11-15 at 15:31 +0800, Dave Young wrote: > cfg80211 module prints a lot of messages like below. Actually printing > once is acceptable but sometimes it will print again and again, it looks > very annoying. It is better to change these detail messages to debugging > only. So maybe add s

Re: [PATCH 14/14] mm: memcontrol: hook up vmpressure to socket pressure

2015-11-15 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:33PM -0500, Johannes Weiner wrote: > Let the networking stack know when a memcg is under reclaim pressure > so that it can clamp its transmit windows accordingly. > > Whenever the reclaim efficiency of a cgroup's LRU lists drops low > enough for a MEDIUM or HIGH vmpre

[PATCH net] bnx2x: Fix VLANs null-pointer for 57710, 57711

2015-11-15 Thread Yuval Mintz
Commit 05cc5a39ddb7 "bnx2x: add vlan filtering offload" introduced a regression in regard for vlans for 57710, 57711 adapters - Loading 8021q module on a machine with such an adapter would cause a null pointer dereference, as the driver mistakenly publishes it has capabilities for vlan CTAG filteri

[PATCH net] ravb: remove unhandle int cause

2015-11-15 Thread Yoshihiro Kaneko
From: Masaru Nagai This driver does not handle the AVB-DMAC Receive FIFO Warning interrupt now, so the interrupt should not be enabled. Signed-off-by: Masaru Nagai Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of David Miller's networking tree. drivers/net/eth

Re: [PATCH -stable] multiple backports requested

2015-11-15 Thread Charles (Chas) Williams
On Fri, 2015-11-13 at 16:10 -0500, David Miller wrote: > From: "Charles (Chas) Williams" <3ch...@gmail.com> > Date: Fri, 13 Nov 2015 15:13:11 -0500 > > > Dave, could you please add the following backports? > > > > For the 3.14.y stable queue: > > I am no longer handling 3.14.y -stable submission

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread Ondrej Zary
On Sunday 15 November 2015 03:30:25 Andy Shevchenko wrote: > On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary > > wrote: > > Add support for IP1000A chips to dl2k driver. > > IP1000A chip looks like a TC9020 with integrated PHY. > > > > This allows IP1000A chips to work reliably because the ipg dri

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-15 Thread Jiri Pirko
Sun, Nov 15, 2015 at 06:51:28AM CET, john.fastab...@gmail.com wrote: >On 15-11-14 01:39 AM, Jiri Pirko wrote: >> Thu, Nov 12, 2015 at 05:02:18PM CET, pjonn...@broadcom.com wrote: >>> Packet forwarding to/from bond interfaces is done in software. >>> >>> This patch enables certain platforms to bridg

[PATCH 2/2] batman-adv: Less checks in batadv_tvlv_unicast_send()

2015-11-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Nov 2015 09:00:42 +0100 * Let us return directly if a call of the batadv_orig_hash_find() function returned a null pointer. * Omit the initialisation for the variable "skb" at the beginning. * Replace an assignment by a call of the kfree_skb() function and

[PATCH 1/2] batman-adv: Delete unnecessary checks before the function call "kfree_skb"

2015-11-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Nov 2015 08:04:43 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/ba

[PATCH 0/2] batman-adv: Deletion of some unnecessary checks

2015-11-15 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 15 Nov 2015 09:34:12 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete unnecessary checks before the function call "kfree_skb" Less checks in batadv_tvlv_unicast_send()