> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Michael Chan
> Sent: Saturday, October 10, 2015 2:39 PM
> To: David Miller
> Cc: netdev
> Subject: [PATCH net-next] bnxt_en: New Broadcom ethernet driver.
>
> +config BNXT
> +
On Fri, Oct 09, 2015 at 03:42:21PM -0700, Eric Dumazet wrote:
> From: Eric Dumazet
>
> timewait or request sockets are small and do not contain sk->sk_tsflags
>
> Without this fix, we might read garbage, and crash later in
>
> __skb_complete_tx_timestamp()
> -> sock_queue_err_skb()
>
> (These
2015-10-10 15:41 GMT-07:00 Vivien Didelot :
> On Oct. Saturday 10 (41) 11:09 PM, Jiri Pirko wrote:
>> Sat, Oct 10, 2015 at 05:56:19PM CEST, vivien.dide...@savoirfairelinux.com
>> wrote:
>> >On Oct. Saturday 10 (41) 09:04 AM, Jiri Pirko wrote:
>> >> Sat, Oct 10, 2015 at 04:53:52AM CEST, sfel...@gma
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..88d1be4 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,23 @@ stati
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F H
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow handling, actions, vlan parsing and netlink attributes
include/linux/if_vlan.h | 17
include/uapi/linux/openvswitch.h | 17 ++--
net/openvswitch/action
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op
Hi Vivien,
[auto build test ERROR on net-next/master -- if it's inappropriate base, please
ignore]
config: x86_64-randconfig-n0-10110700 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
d
On Oct. Saturday 10 (41) 11:09 PM, Jiri Pirko wrote:
> Sat, Oct 10, 2015 at 05:56:19PM CEST, vivien.dide...@savoirfairelinux.com
> wrote:
> >On Oct. Saturday 10 (41) 09:04 AM, Jiri Pirko wrote:
> >> Sat, Oct 10, 2015 at 04:53:52AM CEST, sfel...@gmail.com wrote:
> >> >On Thu, Oct 8, 2015 at 9:38 PM
Sat, Oct 10, 2015 at 05:56:19PM CEST, vivien.dide...@savoirfairelinux.com wrote:
>On Oct. Saturday 10 (41) 09:04 AM, Jiri Pirko wrote:
>> Sat, Oct 10, 2015 at 04:53:52AM CEST, sfel...@gmail.com wrote:
>> >On Thu, Oct 8, 2015 at 9:38 PM, Premkumar Jonnala
>> >wrote:
>> >>
>> >>
>> >>> -Origina
[ forgot to addr Felipe here, sorry ]
On 10/10/2015 04:00 PM, Peter Hurley wrote:
> close_wait is no longer needed or provided by the tty core.
> Move close_wait to struct gs_port.
>
> Signed-off-by: Peter Hurley
> ---
> drivers/usb/gadget/function/u_serial.c | 6 --
> 1 file changed, 4 ins
tty_wait_until_sent_from_close() drops the tty lock while waiting
for the tty driver to finish sending previously accepted data (ie.,
data remaining in its write buffer and transmit fifo).
tty_wait_until_sent_from_close() was added by commit a57a7bf3fc7e
("TTY: define tty_wait_until_sent_from_clos
The tty core provides read_wait waitqueue specifically for line
disciplines to wait readers; otherwise, the line discipline may
miss wakeups generated by the tty core.
NB: The tty core already provides serialization for the line discipline's
close() method, and guarantees no readers or writers wil
Since at least before 2.6.30, tty drivers that do not drop the tty lock
while closing cannot observe ASYNC_CLOSING set while holding the
tty lock; this includes the tty driver's open() and hangup() methods,
since the tty core calls these methods holding the tty lock.
For these drivers, waiting for
The tty lock is strictly for serializing tty lifetime events
(open/close/hangup), and not for line discipline serialization.
The tty core already provides serialization of concurrent writes
to the same tty, and line discipline lifetime management (by ldisc
references), so pinning the tty via tty_l
Hi Greg,
This series is a redux of cleanup I originally submitted back in 2014;
the point is to remove the cruft which stems from dropping the tty lock
while waiting for output to drain before closing the tty.
Dropping the tty lock during close was added by "TTY: define
tty_wait_until_sent_from_c
close_wait is no longer needed or provided by the tty core.
Move close_wait to struct gs_port.
Signed-off-by: Peter Hurley
---
drivers/usb/gadget/function/u_serial.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/u_serial.c
b/drivers/usb/ga
With the removal of tty_wait_until_sent_from_close(), tty drivers
no longer wait during open for parallel closes to complete (instead,
the tty core waits before calling the driver open() method). Thus,
the close_wait waitqueue is no longer used for waiting.
Remove struct tty_port::close_wait.
Sig
In-tree users of wait_event_interruptible_tty() have been removed;
remove.
Signed-off-by: Peter Hurley
---
include/linux/tty.h | 26 --
1 file changed, 26 deletions(-)
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 090ce2a..c2889f4 100644
--- a/include/linu
Fix a smatch warning:
drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended?
The code is correct, the indention is misleading. In case the allocation
of skb fails, we want to skip to the end.
Signed-off-by: Tillmann Heidsieck
---
drivers/atm/iphase.c | 2 +-
1 file changed, 1 insertion
OK here it goes ...
There are three non-indention specific smatch warnings in atm/iphase.c
drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM
is sloppy
drivers/atm/iphase.c:148 ia_hack_tcq() warn: if();
drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended?
Smatch complains about returning hard coded error codes, silence this
warning.
drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM
is sloppy
Signed-off-by: Tillmann Heidsieck
---
drivers/atm/iphase.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --gi
On Oct. Saturday 10 (41) 11:10 AM, Florian Fainelli wrote:
> 2015-10-10 9:33 GMT-07:00 Vivien Didelot
> :
> > On Oct. Friday 09 (41) 09:22 PM, Scott Feldman wrote:
> >> On Fri, Oct 9, 2015 at 4:30 PM, Vivien Didelot
> >> wrote:
> >> > Hi All,
> >> >
> >> > I understand that specifying a VLAN rang
On Fri, Oct 9, 2015 at 4:32 AM, Jeff Kirsher
wrote:
> From: Jesse Brandeburg
>
> To help users and developers know what compile options
> and hardware features are enabled at compile time, print
> VxLAN is available.
What neato means?
Or.
--
To unsubscribe from this list: send the line "unsubsc
On Sat, 2015-10-10 at 02:32 -0700, Geliang Tang wrote:
> Use kstrdup instead of strlen-kmalloc-strcpy.
Not the same code.
Instead of returning early, a 0 length string will
now set pipeline->inuse to 0.
Maybe that's OK, but you should state why in the
commit log.
> diff --git a/drivers/isdn/mIS
Hi Michael,
[auto build test WARNING on net-next/master -- if it's inappropriate base,
please ignore]
config: tile-allmodconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +
2015-10-10 0:01 GMT-07:00 Jiri Pirko :
> Sat, Oct 10, 2015 at 05:20:28AM CEST, sfel...@gmail.com wrote:
>>On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot
>> wrote:
>>> Hi Jiri,
>>>
>>> On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote:
From: Jiri Pirko
Some drivers need to implement
2015-10-10 9:33 GMT-07:00 Vivien Didelot :
> On Oct. Friday 09 (41) 09:22 PM, Scott Feldman wrote:
>> On Fri, Oct 9, 2015 at 4:30 PM, Vivien Didelot
>> wrote:
>> > Hi All,
>> >
>> > I understand that specifying a VLAN range on the command line is nice
>> > for the user, and it makes no big deal fo
On Fri, 2015-10-09 at 21:56 -0700, Alexei Starovoitov wrote:
> yep. as I said it shouldn't be increased and proposed in-band sign bit.
I believe we still would like to keep some helpers to clearly identify
when a packet crosses domains. Even if the helper is empty.
It helps a lot when a new feat
Hi Michael,
[auto build test ERROR on net-next/master -- if it's inappropriate base, please
ignore]
config: microblaze-allmodconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chm
On Oct. Friday 09 (41) 09:22 PM, Scott Feldman wrote:
> On Fri, Oct 9, 2015 at 4:30 PM, Vivien Didelot
> wrote:
> > Hi All,
> >
> > I understand that specifying a VLAN range on the command line is nice
> > for the user, and it makes no big deal for software implementation.
>
> [Adding Roopa, sinc
On Oct. Friday 09 (41) 08:20 PM, Scott Feldman wrote:
> On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot
> wrote:
> > Hi Jiri,
> >
> > On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote:
> >> From: Jiri Pirko
> >>
> >> Some drivers need to implement both switchdev vlan ops and
> >> vid_add/kill ndos
On Oct. Saturday 10 (41) 09:04 AM, Jiri Pirko wrote:
> Sat, Oct 10, 2015 at 04:53:52AM CEST, sfel...@gmail.com wrote:
> >On Thu, Oct 8, 2015 at 9:38 PM, Premkumar Jonnala
> >wrote:
> >>
> >>
> >>> -Original Message-
> >>> From: sfel...@gmail.com [mailto:sfel...@gmail.com]
> >>> Sent: Frid
On Sat, 2015-10-10 at 07:39 -0400, Michael Chan wrote:
> Broadcom ethernet driver for the new family of NetXtreme-C/E
> ethernet devices.
Thanks.
In addition to the kbuild test robot suggestions,
you might try running scripts/checkpatch.pl on this
and fix up some style trivia.
Maybe try "scripts
From: Roopa Prabhu
This patch makes ip6_route_info_create return err pointer instead of
returning the rt pointer by reference as suggested by Dave
Signed-off-by: Roopa Prabhu
---
v1 - v2: remove unnecessary NULL initialization of rt as pointed out by scott
feldman
net/ipv6/route.c | 32
On 10/9/15, 9:52 PM, Scott Feldman wrote:
> @@ -640,7 +641,7 @@ static int fdb_fill_info(struct sk_buff *skb, const
> struct net_bridge *br,
> ndm->ndm_flags = fdb->added_by_external_learn ? NTF_EXT_LEARNED : 0;
> ndm->ndm_type= 0;
> ndm->ndm_ifindex = fdb->dst ? fd
Hi Willy,
It seems fine to me.
You may reword the commit message at will.
Thx,
Jose
On 2015-10-06 11:09, Willy Tarreau wrote:
> Hi guys,
>
> I've updated Jose's patch to make it slightly simpler (eg: calloc instead
> of malloc+memset), and ported it to 4.2.0 which requires it as well, and
> att
> > +config QED
> > + tristate "QLogic QED 25/40/100Gb core driver"
> > + depends on PCI && X86_64
> > + ---help---
> > + This enables the support for ...
> You should be maximizing the number of platforms that can at least
> build test this driver, rather than restricting things
Hi,
Linux 4.2.0 and above dereferences a NULL pointer for me when sending an
IPsec secured packet for the first time. I use kernel IPsec with racoon
and setkey. This is what my configuration looks like:
Local host: 2001:4dd0:ff3b:13::23
Remote host: 2001:4dd0:ff3b:13::5
Setkey instructions:
| #
From: Yuval Mintz
Date: Wed, 7 Oct 2015 14:25:18 +0300
> +config QED
> + tristate "QLogic QED 25/40/100Gb core driver"
> + depends on PCI && X86_64
> + ---help---
> + This enables the support for ...
You should be maximizing the number of platforms that can at least
build test
Hi Michael,
[auto build test WARNING on net-next/master -- if it's inappropriate base,
please ignore]
coccinelle warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:2773:41-42: WARNING: Use ARRAY_SIZE
--
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:1290:5-7: Unneed
drivers/net/ethernet/broadcom/bnxt/bnxt.c:4071:1-3: WARNING: end returns can be
simpified and declaration on line 4064 can be dropped
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Michael
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:521:5-7: Unneeded variable:
"rc". Return "0" on line 595
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
CC: Michael Chan
Signed-off-by: Fengguang Wu
---
Please take the patch only
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:156:1-3: WARNING: end returns
can be simpified and declaration on line 154 can be dropped
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:140:1-3: WARNING: end returns
can be simpified and declaration on line 138 can be dropped
Simplify a trivial
drivers/net/ethernet/broadcom/bnxt/bnxt.c:2773:41-42: WARNING: Use ARRAY_SIZE
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element
Semantic patch information:
This makes an effort to find cases where ARRAY_SIZE can be used such as
where there is a division of sizeof the array
drivers/net/ethernet/broadcom/bnxt/bnxt.c:2763:30-31: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Michael Chan
Signed-off-by: Fengguang Wu
---
bnxt.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethe
drivers/net/ethernet/broadcom/bnxt/bnxt.c:1290:5-7: Unneeded variable: "rc".
Return "0" on line 1304
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
CC: Michael Chan
Signed-off-by: Fengguang Wu
---
Please take the patch only if it'
Hi Michael,
[auto build test WARNING on net-next/master -- if it's inappropriate base,
please ignore]
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/bro
On 10/10/2015 09:49 AM, Elad Raz wrote:
>
>> On Oct 10, 2015, at 2:30 AM, Vivien Didelot
>> wrote:
>>
>> I have two concerns in mind:
>>
>> a) if we imagine that drivers like Rocker allocate memory in the prepare
>> phase for each VID, preparing a range like 100-4000 would definitely not
>> be r
Use kstrdup instead of strlen-kmalloc-strcpy.
Signed-off-by: Geliang Tang
---
drivers/isdn/mISDN/dsp_pipeline.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/isdn/mISDN/dsp_pipeline.c
b/drivers/isdn/mISDN/dsp_pipeline.c
index 8b1a66c..c60722d 100644
--- a/
Sat, Oct 10, 2015 at 11:20:38AM CEST, huangda...@hisilicon.com wrote:
>This patch fix the building error reported by Jiri Pirko
>
>drivers/net/ethernet/hisilicon/hns/hnae.h:465:2: error: unknown type
>name 'phy_interface_t'
>phy_interface_t phy_if;
> ^
>the full build log is on https
This patch fix the building error reported by Jiri Pirko
drivers/net/ethernet/hisilicon/hns/hnae.h:465:2: error: unknown type
name 'phy_interface_t'
phy_interface_t phy_if;
^
the full build log is on https://lists.01.org/pipermail/kbuild-all.
Signed-off-by: huangdaode
Signed-off
> On Oct 10, 2015, at 2:30 AM, Vivien Didelot
> wrote:
>
> I have two concerns in mind:
>
> a) if we imagine that drivers like Rocker allocate memory in the prepare
> phase for each VID, preparing a range like 100-4000 would definitely not
> be recommended.
>
> b) imagine that you have two Li
On 10/09/2015 02:35 AM, Kosuke Tatsukawa wrote:
> brcmf_msgbuf_ioctl_resp_wake() seems to be missing a memory barrier
> which might cause the waker to not notice the waiter and miss sending a
> wake_up as in the following figure.
>
>brcmf_msgbuf_ioctl_resp_wake brcmf_msgbuf_i
Sat, Oct 10, 2015 at 09:21:15AM CEST, j...@resnulli.us wrote:
>>
>>I had just re-run the tests against net-next before submitting the
>>ageing_time patchset and everything passes.
>>
>>Are you using a namespace or a VM for host1? Either one should work.
>>
>>This would be a bad test, as the ker
Sat, Oct 10, 2015 at 04:43:43AM CEST, sfel...@gmail.com wrote:
>
>>
>>>
>>>patch 3/3 I haven't looked at yet...I'm stuck on 2/3.
>>
>> It is very similar to 2/3, only for obj_add/del.
>
>Do we have examples of a deferred obj add or del? Maybe we should
>hold off adding that support until someon
Sat, Oct 10, 2015 at 04:51:20AM CEST, sfel...@gmail.com wrote:
>On Fri, Oct 9, 2015 at 7:36 AM, Jiri Pirko wrote:
>> Wed, Oct 07, 2015 at 07:39:56PM CEST, j...@resnulli.us wrote:
>>>Wed, Oct 07, 2015 at 06:53:22PM CEST, sfel...@gmail.com wrote:
On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko wrot
Sat, Oct 10, 2015 at 04:53:52AM CEST, sfel...@gmail.com wrote:
>On Thu, Oct 8, 2015 at 9:38 PM, Premkumar Jonnala
>wrote:
>>
>>
>>> -Original Message-
>>> From: sfel...@gmail.com [mailto:sfel...@gmail.com]
>>> Sent: Friday, October 09, 2015 7:53 AM
>>> To: netdev@vger.kernel.org
>>> Cc: d
Sat, Oct 10, 2015 at 05:20:28AM CEST, sfel...@gmail.com wrote:
>On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot
> wrote:
>> Hi Jiri,
>>
>> On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote:
>>> From: Jiri Pirko
>>>
>>> Some drivers need to implement both switchdev vlan ops and
>>> vid_add/kill ndos
59 matches
Mail list logo
