The complate semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@ok exists@
identifier f,ret,i;
expression e;
constant c;
@@
// identify a function that returns a negative return value at least once.
f(...) {
... when any
(
return -c@i;
|
ret = -c@i;
... when !
Propagate error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
In rds_cmsg_rdma_args() 'ret' is used by rds_pin_pages() which returns
number of pinned pages on success. And the same value is returned to the
caller of rds_cmsg_rdma_args() on success which is not intended.
Commit f4a3fc03c1d7 ("RDS: Clean up error handling in rds_cmsg_rdma_args")
removed the 'r
rds_send_xmit() marks the rds message map flag after
xmit_[rdma/atomic]() which is clearly wrong. We need
to maintain the ownership between transport and rds.
Also take care of error path.
Reviewed-by: Ajaykumar Hotchandani
Signed-off-by: Santosh Shilimkar
Signed-off-by: Santosh Shilimkar
---
We were still seeing rare occurrences of the WARN_ON(recv->r_frag) which
indicates that the recv refill path was finding allocated frags in ring
entries that were marked free. These were usually followed by OOM crashes.
They only seem to be occurring in the presence of completion errors and
connect
Ensure we don't keep sending the data if the link is congested.
Reviewed-by: Ajaykumar Hotchandani
Signed-off-by: Santosh Shilimkar
Signed-off-by: Santosh Shilimkar
---
net/rds/send.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/rds/send.c b/net/rds/send.c
index e9
Destroy ib state early during shutdown. Otherwise we can get callbacks
after the QP isn't really able to handle them.
Reviewed-by: Ajaykumar Hotchandani
Signed-off-by: Santosh Shilimkar
Signed-off-by: Santosh Shilimkar
---
net/rds/ib_cm.c | 18 ++
1 file changed, 10 insertions(
If the ip address tables hasn't changed, there is no need to remove
them only to be added back again.
Lets fix it.
Reviewed-by: Ajaykumar Hotchandani
Signed-off-by: Santosh Shilimkar
Signed-off-by: Santosh Shilimkar
---
net/rds/ib_rdma.c | 9 +++--
1 file changed, 7 insertions(+), 2 deleti
If we get an ENOMEM during rds_ib_recv_refill, we might never come
back and refill again later. Patch makes sure to kick krdsd into
helping out.
To achieve this we add RDS_RECV_REFILL flag and update in the refill
path based on that so that at least some therad will keep posting
receive buffers.
Fix the asserion level since its not fatal and can be hit
in normal execution paths. There is no need to take the
system down.
We keep the WARN_ON() to detect the condition if we get
here with bad pages.
Reviewed-by: Ajaykumar Hotchandani
Signed-off-by: Santosh Shilimkar
Signed-off-by: Santosh
From: Santosh Shilimkar
During connection resets, we are destroying the rdma id too soon. We can't
destroy it when it is still in use. So lets move rdma_destroy_id() after
we clear the rings.
Reviewed-by: Ajaykumar Hotchandani
Signed-off-by: Santosh Shilimkar
Signed-off-by: Santosh Shilimkar
This helps to detect the accidental processes/apps trying to destroy
the RDS socket which they are sharing with other processes/apps.
Reviewed-by: Ajaykumar Hotchandani
Signed-off-by: Santosh Shilimkar
Signed-off-by: Santosh Shilimkar
---
net/rds/af_rds.c | 9 +
1 file changed, 9 inser
Connection could have been dropped while the route is being resolved
so check for valid cm_id before initiating the connection.
Reviewed-by: Ajaykumar Hotchandani
Signed-off-by: Santosh Shilimkar
Signed-off-by: Santosh Shilimkar
---
net/rds/rdma_transport.c | 15 +--
1 file changed
We would like to improve RDS upstream support and in that context, I
started playing with it. But run into number of issues including as
basic is RDS IB RDMA doesn't work. As part of the debug, I ended up
creating the $subject series which has bunch of assorted fixes. At
least with this series I c
WR(Work Requests )always generate a WC(Work Completion) with
signaled send. Default RDS ib code is setup for un-signaled
completion. Since RDS connction is persistent, we can end up
sending the data even after large-send when the remote end is
not active(for any reason).
By doing a signaled send
rds_send_drop_to() is used during socket tear down to find all the
messages on the socket and flush them . It can race with the
acking code unless it takes the m_rs_lock on each and every message.
This plugs a hole where we didn't take m_rs_lock on any message that
didn't have the RDS_MSG_ON_CONN
From: Mukesh Kacker
rds_send_queue_rm() allows for the "current datagram" being queued
to exceed SO_SNDBUF thresholds by checking bytes queued without
counting in length of current datagram. (Since sk_sndbuf is set
to twice requested SO_SNDBUF value as a kernel heuristic this
is usually fine!)
I
On Sat, Aug 22, 2015 at 10:33:48PM +0200, Thomas Gleixner wrote:
> > @@ -196,19 +197,31 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int
> > cmd, unsigned long arg)
> > break;
> > }
> > pct = &sysoff->ts[0];
> > - for (i = 0; i < sysoff->
❦ 20 août 2015 14:07 -0700, David Miller :
I also don't know what is the best way to handle this. veth advertises
its peer via IFLA_LINK since 4.1, so it's too late to change it for
this
release.
>>>
>>> Apparently we need to pick our poison. Either way, we break something.
>
On Fri, 21 Aug 2015, Christopher S. Hall wrote:
> From: Christopher Hall
>
> Add getsynctime() PTP device callback to cross timestamp system device
> clock using ART translation depends on platform being >= SPT
> and having ART
>
> getsynctime() reads ART (TSC-derived)/device cross t
On Fri, 21 Aug 2015, Christopher S. Hall wrote:
> From: Christopher Hall
>
> This patch allows system and device time ("cross-timestamp") to be
> performed by the driver. Currently, the cross-timestamping is performed
> in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday()
> and
On Fri, 21 Aug 2015, Christopher S. Hall wrote:
> Add detect_art() call to early TSC initialization which reads ART->TSC
> numerator/denominator and sets CPU feature if present
>
> Add convert_art_to_tsc() function performing conversion ART to TSC
>
> Add art_timestamp referencing art_to_t
On Fri, 21 Aug 2015, Christopher S. Hall wrote:
> Add struct correlated_cs with pointer to original clocksource and
> function pointer to convert correlated clocksource to the original
>
> Add get_correlated_timestamp() function which given specific correlated_cs
> and correlated_ts c
Your name and email was randomly picked by Visa Debit Card Europe Inc. in our
Barclay premier league 2015/2016 season prize pay-out promo. Please contact the
Coordinator @barclaypremiershipinc2...@hotmail.com.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a
Cc'ing Andrew, since he's got a similar patch in mmotm [1].
On Sat, Aug 22, 2015 at 08:11:18PM +0200, Jozsef Kadlecsik wrote:
> On Sat, 22 Aug 2015, Elad Raz wrote:
>
> > In continue to proposed Vinson Lee's post [1], this patch fixes compilation
> > issues founded at gcc 4.4.7. The initializatio
I was wondering about that, too. The referenced patch,
net-netfilter-ipset-work-around-gcc-444-initializer-bug.patch
was confirmed to fix the issue. What I cannot figure out is the
procedure by which this patch gets added to Linus' tree. It was in the
-mm tree back in mid June but still is not in
On Sat, 22 Aug 2015, Elad Raz wrote:
> In continue to proposed Vinson Lee's post [1], this patch fixes compilation
> issues founded at gcc 4.4.7. The initialization of .cidr field of unnamed
> unions causes compilation error in gcc 4.4.x.
There's already a (couple of weeks old) patch in the -mm t
From: Nicolas Dichtel
Date: Sat, 22 Aug 2015 18:10:20 +0200
> This patch renames the recently added vrf driver. 'VRF' term is very
> generic and there is no clear definition of it.
> For example, someone may expect more isolation and uses network namespaces
> to implement VRF,
This is a rediculo
This patch renames the recently added vrf driver. 'VRF' term is very
generic and there is no clear definition of it.
For example, someone may expect more isolation and uses network namespaces
to implement VRF,
MRF was suggested by Cumulus people, so let's use this term.
This patch also enlightens
let us talk
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ondrej Zary :
[...]
> The patch below is enough to make my IP1000A card work with dl2k driver - no
> more lost packets and hangs. Haven't tested gigabit speed yet - the PHY will
> probably need some tweaking but that should be easy.
Neither dl2k nor ipg uses napi. They are a bit dusty.
> So mayb
Corinna Vinschen :
[...]
> That won't happen with the current patch because only
> rtl8169_reset_counters would print a log message, it's only called from
> open, and open occurs rather seldom. Atop of that the code only tries
> to reset counters on HW supporting it, and only if resetting on the
Corcodel Marian :
> Disable interrupts when close the interface.
>
>
> Signed-off-by: Corcodel Marian
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c
> b/drivers/net/ethernet/realtek/r8169.c
> index 6cd7226..ea461fe 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net
Disable writting on registers on probe stage because
register CplusCmd must init first.Here is order: 1. CplusCmd, 2. ChipCmd, 3.
Rest regs. I split __rtl8169_set_features func for solve this issue.
Signed-off-by: Corcodel Marian
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers
On Aug 22 01:59, Francois Romieu wrote:
> Corinna Vinschen :
> > On Aug 21 21:39, Francois Romieu wrote:
> [...]
> > > The code should propagate failure when both rtl8169_reset_counters and
> > > rtl8169_update_counters fail.
> >
> > This one I don't understand. Neither failing to reset the coun
37 matches
Mail list logo
