Re: [lkp] [rhashtable] 9d901bc0515: WARNING: CPU: 0 PID: 1 at arch/x86/mm/ioremap.c:63 __ioremap_check_ram+0x6a/0x99()

2015-08-20 Thread Herbert Xu
On Fri, Aug 21, 2015 at 02:05:19PM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > commit 9d901bc05153bbf33b5da2cd6266865e531f0545 ("rhashtable: Free bucket > tables asynchronously after rehash")

Re: [PATCH 2/5] net: add Hisilicon Network Subsystem hnae framework support

2015-08-20 Thread Kenneth Lee
Thanks, Klimov, You are right. I will fix it in next patches. On Tue, Aug 18, 2015 at 03:12:02AM +0300, Alexey Klimov wrote: > Date: Tue, 18 Aug 2015 03:12:02 +0300 > From: Alexey Klimov > To: Kenneth Lee > CC: robh...@kernel.org, pawel.m...@arm.com, Mark Rutland > , ijc+devicet...@hellion.org

[net-next:master 790/1189] xt_TEE.c:undefined reference to `nf_dup_ipv6'

2015-08-20 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: a9e01ed986aa80d3092134428f453072752da223 commit: bbde9fc1824aab58bc78c084163007dd6c03fe5b [790/1189] netfilter: factor out packet duplication for IPv4/IPv6 config: x86_64-nfsroot (attached as .config) reproduce

[net-next:master 791/1189] net/ipv4/netfilter/nft_dup_ipv4.c:29:37: sparse: incorrect type in initializer (different base types)

2015-08-20 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: a9e01ed986aa80d3092134428f453072752da223 commit: d877f07112f1e5a247c6b585c971a93895c9f738 [791/1189] netfilter: nf_tables: add nft_dup expression reproduce: # apt-get install sparse git checkout d877f07112f

Re: [net-next:master 1179/1189] include/linux/compiler.h:447:38: error: call to '__compiletime_assert_243' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct dst_entry, __refcnt) & 63

2015-08-20 Thread David Miller
Yeah, I should have predicted this would happen on 32-bit builds when I saw the adjustment of __pad_to_align_refcnt[] for 64-bit. Jiri, you might not have any reasonable options to fix this I'm afraid. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

[net-next:master 790/1189] net/ipv6/netfilter/nf_dup_ipv6.c:48:23: sparse: incorrect type in assignment (different base types)

2015-08-20 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: a9e01ed986aa80d3092134428f453072752da223 commit: bbde9fc1824aab58bc78c084163007dd6c03fe5b [790/1189] netfilter: factor out packet duplication for IPv4/IPv6 reproduce: # apt-get install sparse git checkout b

RE: [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-08-20 Thread Izumi, Taku
Dear David, Thank you for reviewing. I'll update patchset according to your comment. Sincerely, Taku Izumi > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, August 21, 2015 7:49 AM > To: Izumi, Taku/泉 拓 > Cc: netdev@vger.kernel.org; platform-drive

[net-next:master 1179/1189] include/linux/compiler.h:447:38: error: call to '__compiletime_assert_243' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct dst_entry, __refcnt) & 63

2015-08-20 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: a9e01ed986aa80d3092134428f453072752da223 commit: 61adedf3e3f1d3f032c5a6a299978d91eff6d555 [1179/1189] route: move lwtunnel state to dst_entry config: m68k-sun3_defconfig (attached as .config) reproduce: wget

Re: [PATCH 00/15] Netfilter updates for net-next

2015-08-20 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 21 Aug 2015 06:32:29 +0200 > This is second pull request includes the conflict resolution patch that > resulted from the updates that we got for the conntrack template through > kmalloc. No changes with regards to the previously sent 15 patches. ... > You can p

Re: [PATCH net-next RFC 00/10] socket sendmsg MSG_ZEROCOPY

2015-08-20 Thread David Miller
From: Willem de Bruijn Date: Thu, 20 Aug 2015 22:49:25 -0400 > But there may still be others. Most obvious use case for copy > avoidance is pure device transmit. Excluding loopback may be > a reasonable way to initially limit the attack surface. With a flag > NETIF_F_ZC not supported on lo. Good

Bug in tc of iproute2 ? Deleting single filter, deletes all the filters (apart from hashtable 800::) ...

2015-08-20 Thread Akshat Kakkar
When I am trying to delete a single tc filter, it deleting all the filters with the same priority/preference. i.e. it is ignoring the handle specified. But, When I am deleting in hashtable 800: it is deleting only the specified filter. For example, following set of commands create a hashtable 1

Re: RX packet loss on i.MX6Q running 4.2-rc7

2015-08-20 Thread Jon Nettleton
On Fri, Aug 21, 2015 at 12:30 AM, Clemens Gruber wrote: > Hi, > > I am experiencing massive RX packet loss on my i.MX6Q (Chip rev 1.3) on Linux > 4.2-rc7 with a Marvell 88E1510 Gigabit Ethernet PHY connected over RGMII. > I noticed it when doing an UDP benchmark with iperf3. When sending UDP packe

[PATCH 08/15] netfilter: nft_limit: add burst parameter

2015-08-20 Thread Pablo Neira Ayuso
This patch adds the burst parameter. This burst indicates the number of packets that can exceed the limit. Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/nf_tables.h |2 ++ net/netfilter/nft_limit.c| 20 ++-- 2 files changed, 20 insertions

[PATCH 03/15] netfilter: factor out packet duplication for IPv4/IPv6

2015-08-20 Thread Pablo Neira Ayuso
Extracted from the xtables TEE target. This creates two new modules for IPv4 and IPv6 that are shared between the TEE target and the new nf_tables dup expressions. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/ipv4/nf_dup_ipv4.h |7 ++ include/net/netfilter/ipv6/nf_dup_ipv6.h |

[PATCH 07/15] netfilter: nft_limit: factor out shared code with per-byte limiting

2015-08-20 Thread Pablo Neira Ayuso
This patch prepares the introduction of per-byte limiting. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_limit.c | 86 - 1 file changed, 53 insertions(+), 33 deletions(-) diff --git a/net/netfilter/nft_limit.c b/net/netfilter/nft_limit.c in

[PATCH 10/15] netfilter: nft_limit: add per-byte limiting

2015-08-20 Thread Pablo Neira Ayuso
This patch adds a new NFTA_LIMIT_TYPE netlink attribute to indicate the type of limiting. Contrary to per-packet limiting, the cost is calculated from the packet path since this depends on the packet length. The burst attribute indicates the number of bytes in which the rate can be exceeded. Sig

[PATCH 11/15] netfilter: nfacct: per network namespace support

2015-08-20 Thread Pablo Neira Ayuso
From: Andreas Schultz - Move the nfnl_acct_list into the network namespace, initialize and destroy it per namespace - Keep track of refcnt on nfacct objects, the old logic does not longer work with a per namespace list - Adjust xt_nfacct to pass the namespace when registring objects Signed-o

[PATCH 09/15] netfilter: nft_limit: constant token cost per packet

2015-08-20 Thread Pablo Neira Ayuso
The cost per packet can be calculated from the control plane path since this doesn't ever change. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_limit.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/net/netfilter/nft_limit.c b/net/netfil

[PATCH 05/15] netfilter: nft_limit: rename to nft_limit_pkts

2015-08-20 Thread Pablo Neira Ayuso
To prepare introduction of bytes ratelimit support. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_limit.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/netfilter/nft_limit.c b/net/netfilter/nft_limit.c index 435c1cc..d0788e1 100644 --- a/net/netf

[PATCH 12/15] netfilter: nf_conntrack: push zone object into functions

2015-08-20 Thread Pablo Neira Ayuso
From: Daniel Borkmann This patch replaces the zone id which is pushed down into functions with the actual zone object. It's a bigger one-time change, but needed for later on extending zones with a direction parameter, and thus decoupling this additional information from all call-sites. No functi

[PATCH 06/15] netfilter: nft_limit: convert to token-based limiting at nanosecond granularity

2015-08-20 Thread Pablo Neira Ayuso
Rework the limit expression to use a token-based limiting approach that refills the bucket gradually. The tokens are calculated at nanosecond granularity instead jiffies to improve precision. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_limit.c | 42 ++

[PATCH 04/15] netfilter: nf_tables: add nft_dup expression

2015-08-20 Thread Pablo Neira Ayuso
This new expression uses the nf_dup engine to clone packets to a given gateway. Unlike xt_TEE, we use an index to indicate output interface which should be fine at this stage. Moreover, change to the preemtion-safe this_cpu_read(nf_skb_duplicated) from nf_dup_ipv{4,6} to silence a lockdep splat.

[PATCH 13/15] netfilter: nf_conntrack: add direction support for zones

2015-08-20 Thread Pablo Neira Ayuso
From: Daniel Borkmann This work adds a direction parameter to netfilter zones, so identity separation can be performed only in original/reply or both directions (default). This basically opens up the possibility of doing NAT with conflicting IP address/port tuples from multiple, isolated tenants

[PATCH 14/15] netfilter: nf_conntrack: add efficient mark to zone mapping

2015-08-20 Thread Pablo Neira Ayuso
From: Daniel Borkmann This work adds the possibility of deriving the zone id from the skb->mark field in a scalable manner. This allows for having only a single template serving hundreds/thousands of different zones, for example, instead of the need to have one match for each zone as an extra CT

[PATCH 15/15] netfilter: nft_payload: work around vlan header stripping

2015-08-20 Thread Pablo Neira Ayuso
From: Florian Westphal make payload expression aware of the fact that VLAN offload may have removed a vlan header. When we encounter tagged skb, transparently insert the tag into the register so that vlan header matching can work without userspace being aware of offload features. Signed-off-by:

[PATCH 02/15] netfilter: xt_TEE: get rid of WITH_CONNTRACK definition

2015-08-20 Thread Pablo Neira Ayuso
Use IS_ENABLED(CONFIG_NF_CONNTRACK) instead. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/xt_TEE.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/netfilter/xt_TEE.c b/net/netfilter/xt_TEE.c index c5d6556..0ed9fb6 100644 --- a/net/netfilter/xt_TEE.c +++ b

[PATCH 01/15] netfilter: nft_counter: convert it to use per-cpu counters

2015-08-20 Thread Pablo Neira Ayuso
This patch converts the existing seqlock to per-cpu counters. Suggested-by: Eric Dumazet Suggested-by: Patrick McHardy Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_counter.c | 97 ++- 1 file changed, 69 insertions(+), 28 deletions(-) diff --

[PATCH 00/15] Netfilter updates for net-next

2015-08-20 Thread Pablo Neira Ayuso
Hi David, This is second pull request includes the conflict resolution patch that resulted from the updates that we got for the conntrack template through kmalloc. No changes with regards to the previously sent 15 patches. The following patchset contains Netfilter updates for your net-next tree,

Re: [PATCH net-next RFC 00/10] socket sendmsg MSG_ZEROCOPY

2015-08-20 Thread Willem de Bruijn
On Thu, Aug 20, 2015 at 6:56 PM, David Miller wrote: > From: Willem de Bruijn > Date: Thu, 20 Aug 2015 10:36:39 -0400 > >> Datapath integrity does not otherwise depend on payload, with three >> exceptions: checksums, optional sk_filter/tc u32/.. and device + >> driver logic. The effect of wrong c

[PATCH net-next] 3c59x: Add BQL support for 3c59x ethernet driver.

2015-08-20 Thread Loganaden Velvindron
This BQL patch is based on work done by Tino Reichardt. Tested on :05:00.0: 3Com PCI 3c905C Tornado at c9e6e000 by running Flent several times. Signed-off-by: Loganaden Velvindron --- drivers/net/ethernet/3com/3c59x.c | 23 --- 1 file changed, 20 insertions(+),

[PATCH v2] net: bcmgenet: fix uncleaned dma flags

2015-08-20 Thread Jaedon Shin
Clean the dma flags of multiq ring buffer int the interface stop process. This patch fixes that the genet is not running while the interface is re-enabled. $ ifup eth0 - running after booting $ ifdown eth0 $ ifup eth0 - not running and occur tx_timeout The bcmgenet_dma_disable() in bcmgenet_open(

Re: [PATCH] net: bcmgenet: fix uncleaned dma flags

2015-08-20 Thread Jaedon Shin
> 2015. 8. 21., 오전 7:04, Florian Fainelli 작성: > > On 19/08/15 20:17, Jaedon Shin wrote: >> Clean the dma flags of multiq ring buffer int the interface stop >> process. This patch fixes that the genet is not running while the >> interface is re-enabled. >> >> $ ifup eth0 - running after booting >

[PATCH net] net: bcmgenet: Avoid sleeping in bcmgenet_timeout

2015-08-20 Thread Florian Fainelli
bcmgenet_timeout() executes in atomic context, yet we will invoke napi_disable() which does sleep. Looking back at the changes, disabling TX napi and re-enabling it is completely useless, since we reclaim all TX buffers and re-enable interrupts, and wake up the TX queues. Fixes: 13ea657806cf ("net

Re: [PATCHv4 net-next 10/10] openvswitch: Allow attaching helpers to ct action

2015-08-20 Thread Joe Stringer
On 19 August 2015 at 15:57, Pravin Shelar wrote: > On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: >> Add support for using conntrack helpers to assist protocol detection. >> The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper >> to be used for this connection. >> >> Exa

Re: [PATCHv4 net-next 06/10] openvswitch: Allow matching on conntrack mark

2015-08-20 Thread Joe Stringer
On 19 August 2015 at 13:47, Pravin Shelar wrote: > On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: >> Allow matching and setting the conntrack mark field. As with conntrack >> state and zone, these are populated when the CT action is executed, >> and are made available for matching via RECIR

Re: [PATCHv4 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-20 Thread Joe Stringer
On 20 August 2015 at 14:01, Pravin Shelar wrote: > On Thu, Aug 20, 2015 at 12:13 PM, Joe Stringer wrote: >> On 20 August 2015 at 08:45, Pravin Shelar wrote: >>> On Wed, Aug 19, 2015 at 4:04 PM, Joe Stringer >>> wrote: Thanks for the review, On 19 August 2015 at 14:24, Pravin She

[GIT] [4.3] NFC update

2015-08-20 Thread Samuel Ortiz
Hi David, This is the NFC pull request for 4.3. With this one we have: - A new driver for Samsung's S3FWRN5 NFC chipset. In order to properly support this driver, a few NCI core routines needed to be exported. Future drivers like Intel's Fields Peak will benefit from this. - SPI support as

Re: [PATCH] net af_key: Fix RCU splat

2015-08-20 Thread Eric Dumazet
On Thu, 2015-08-20 at 15:57 -0700, David Ahern wrote: > On 8/20/15 9:51 AM, Eric Dumazet wrote: > > On Thu, 2015-08-20 at 08:51 -0700, David Ahern wrote: > >> Hit the following splat testing VRF change for ipsec: ... > >> > >> diff --git a/net/key/af_key.c b/net/key/af_key.c > >> index b397f0aa90

Re: [PATCH ipsec-next v2] xfrm: Use VRF master index if output device is enslaved

2015-08-20 Thread Nikolay Aleksandrov
> On Aug 21, 2015, at 1:06 AM, David Ahern wrote: > > Directs route lookups to VRF table. Compiles out if NET_VRF is not > enabled. With this patch able to successfully bring up ipsec tunnels > in VRFs, even with duplicate network configuration. > > Signed-off-by: David Ahern > --- > v2 > - us

Re: [PATCH] net af_key: Fix RCU splat

2015-08-20 Thread David Ahern
On 8/20/15 9:51 AM, Eric Dumazet wrote: On Thu, 2015-08-20 at 08:51 -0700, David Ahern wrote: Hit the following splat testing VRF change for ipsec: [ 113.475692] === [ 113.476194] [ INFO: suspicious RCU usage. ] [ 113.476667] 4.2.0-rc6-1+deb7u2+clUNRELEASED #3.2.6

Re: [PATCH net-next RFC 00/10] socket sendmsg MSG_ZEROCOPY

2015-08-20 Thread David Miller
From: Willem de Bruijn Date: Thu, 20 Aug 2015 10:36:39 -0400 > Datapath integrity does not otherwise depend on payload, with three > exceptions: checksums, optional sk_filter/tc u32/.. and device + > driver logic. The effect of wrong checksums is limited to the > misbehaving process. Filters may

Re: [PATCH net-next] 3c59x: Add BQL support for 3c59x ethernet driver.

2015-08-20 Thread David Miller
This is not a proper submission. You must at the very least provide an appropriate signoff in the commit message of your change. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or

Re: [PATCH v2.2 04/22] fjes: platform_driver's .probe and .remove routine

2015-08-20 Thread David Miller
From: Taku Izumi Date: Thu, 20 Aug 2015 17:46:08 +0900 > + > +err_register: > + fjes_hw_exit(&adapter->hw); > +err_hw_init: > +err_sw_init: > + free_netdev(netdev); > +err_alloc_netdev: > + return err; Having multiple code labels in the same exact spot is suboptimal. Instead, name t

Re: [PATCH v2.2 02/22] fjes: Hardware initialization routine

2015-08-20 Thread David Miller
From: Taku Izumi Date: Thu, 20 Aug 2015 17:46:06 +0900 > diff --git a/drivers/net/fjes/fjes.h b/drivers/net/fjes/fjes.h > index 4622da1..15ded96 100644 > --- a/drivers/net/fjes/fjes.h > +++ b/drivers/net/fjes/fjes.h > @@ -28,6 +28,6 @@ > > extern char fjes_driver_name[]; > extern char fjes_dr

Re: [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-08-20 Thread David Miller
From: Taku Izumi Date: Thu, 20 Aug 2015 17:46:05 +0900 > +obj-$(CONFIG_FUJITSU_ES) += fjes.o > + > +fjes-objs := fjes_main.o > + Please do not have trailing empty lines in any files you add or edit, 'git' warns about this even when applying patches. > +static int fjes_acpi_add(struct acpi_devic

Re: [PATCH v3 net-next 00/13] lwtunnel: per route ipv6 support for vxlan

2015-08-20 Thread David Miller
From: Jiri Benc Date: Thu, 20 Aug 2015 13:56:19 +0200 > v3: Moved LWTUNNEL_ENCAP_IP6 definition in patch 13. > v2: Fixed issues in patch 4 pointed out by Alexei. > > This series enables IPv6 tunnels based on lwtunnel infrastructure. Only > vxlan is supported for now. > > Tested in all combinati

RX packet loss on i.MX6Q running 4.2-rc7

2015-08-20 Thread Clemens Gruber
Hi, I am experiencing massive RX packet loss on my i.MX6Q (Chip rev 1.3) on Linux 4.2-rc7 with a Marvell 88E1510 Gigabit Ethernet PHY connected over RGMII. I noticed it when doing an UDP benchmark with iperf3. When sending UDP packets from a Debian PC to the i.MX6 with a rate of 100 Mbit/s, 99% of

Re: [PATCH] net: bcmgenet: fix uncleaned dma flags

2015-08-20 Thread Florian Fainelli
On 19/08/15 20:17, Jaedon Shin wrote: > Clean the dma flags of multiq ring buffer int the interface stop > process. This patch fixes that the genet is not running while the > interface is re-enabled. > > $ ifup eth0 - running after booting > $ ifdown eth0 > $ ifup eth0 - not running and occur tx_t

[PATCH ipsec-next v2] xfrm: Use VRF master index if output device is enslaved

2015-08-20 Thread David Ahern
Directs route lookups to VRF table. Compiles out if NET_VRF is not enabled. With this patch able to successfully bring up ipsec tunnels in VRFs, even with duplicate network configuration. Signed-off-by: David Ahern --- v2 - use vrf_master_ifindex rather than vrf_master_ifindex_rcu net/ipv4/xfrm

Re: [PATCH] netcp:Fix error checking in the function gbe_open

2015-08-20 Thread Murali Karicheri
On 08/13/2015 11:26 AM, nick wrote: On 2015-07-30 03:44 PM, Murali Karicheri wrote: On 07/30/2015 02:27 PM, Nicholas Krause wrote: This fixes error checking in the function gbe_open by checking if the function netcp_register_txhook has failed by returning a error code and if so jump to the go

Re: [net-next 04/16] i40e/i40evf: Move helper functions to a header file

2015-08-20 Thread David Miller
From: Jeff Kirsher Date: Wed, 19 Aug 2015 17:57:54 -0700 > +inline int i40e_allocate_dma_mem_d(struct i40e_hw *hw, > +struct i40e_dma_mem *mem, > +u64 size, u32 alignment) > +{ All of these should be "static inline" otherwise GCC is

Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers

2015-08-20 Thread Javier Martinez Canillas
Hello Brian, On 08/20/2015 11:11 PM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: >> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches > > ^^^ I'm dying to know how this sentence ends :) > Sigh, I did some last minute restructu

Re: [PATCH 00/15] Netfilter updates for net-next

2015-08-20 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 19 Aug 2015 21:18:16 +0200 > The following patchset contains Netfilter updates for your net-next tree, they > are: This doesn't pull cleanly, I get a couple of conflicts: [davem@localhost net-next]$ git pull --no-ff git://git.kernel.org/pub/scm/linux/kernel/g

Re: [PATCH] net: xgene Remove xgene specific phy and MAC lookup functions

2015-08-20 Thread David Miller
From: Jeremy Linton Date: Wed, 19 Aug 2015 13:56:42 -0500 > Convert the xgene_get_mac_address to device_get_mac_address(), and > xgene_get_phy_mode() to device_get_phy_mode(). > > Signed-off-by: Jeremy Linton Applied, thanks Jeremy. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] net: Fix nexthop lookups

2015-08-20 Thread David Miller
From: David Ahern Date: Wed, 19 Aug 2015 11:40:31 -0700 > Andreas reported breakage adding routes with local nexthops: > $ ip route show table main > ... > 172.28.0.0/24 dev vnf-xe1p0 proto kernel scope link src 172.28.0.16 > > $ ip route add 10.0.0.0/8 via 172.28.0.32 table 100 dev vnf-xe1p0

Re: [PATCH net-next] bridge: fix netlink max attr size

2015-08-20 Thread David Miller
From: sfel...@gmail.com Date: Wed, 19 Aug 2015 11:29:35 -0700 > From: Scott Feldman > > .maxtype should match .policy. Probably just been getting lucky here > because IFLA_BRPORT_MAX > IFLA_BR_MAX. > > Fixes: 13323516 ("bridge: implement rtnl_link_ops->changelink") > Signed-off-by: Scott Feldm

Re: [PATCH 2/2] smsc911x: Remove dev==NULL check.

2015-08-20 Thread David Miller
From: Jeremy Linton Date: Wed, 19 Aug 2015 11:46:43 -0500 > The dev==NULL check in smsc911x_probe_config is useless > and isn't providing any additional protection. If a fwnode > doesn't exist then an appropriate error should be returned > by device_get_phy_mode() covering the original case > of

Re: [PATCH 1/2] device property: Add ETH_ALEN check, update comments.

2015-08-20 Thread David Miller
From: Jeremy Linton Date: Wed, 19 Aug 2015 11:46:42 -0500 > This patch adds MAC address length check back into > the device_get_mac_addr() function before calling > is_valid_ether_addr() similar to the way the OF > routine does it. > > Update the comments for the two new functions. > > Signed-o

Re: [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb board

2015-08-20 Thread Florian Fainelli
On 20/08/15 14:05, David Miller wrote: > From: Fugang Duan > Date: Wed, 19 Aug 2015 13:33:58 +0800 > >> The patch series is to add fec support for i.MX7d sdb board. Since i.MX7d >> fec ip is >> the same as i.MX6SX, so there have no change for driver itself. >> >> Patch#1: add bcm54220 PHY ID ent

Re: pull-request: wireless-drivers-next 2015-08-19

2015-08-20 Thread David Miller
From: Kalle Valo Date: Wed, 19 Aug 2015 14:03:56 +0300 > here's one more pull request for 4.3. More info in the signed tag below. > > This time I had to merge mac80211-next.git due to some iwlwifi > dependencies and apparently that broke git-request-pull's diffstat > again, it was showing change

Re: [PATCH net-next] ipv4: Make fib_encap_match static

2015-08-20 Thread David Miller
From: Ying Xue Date: Wed, 19 Aug 2015 16:04:51 +0800 > Make fib_encap_match() static as it isn't used outside the file. > > Signed-off-by: Ying Xue Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: > Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches ^^^ I'm dying to know how this sentence ends :) > Patch #18 changes the logic of spi_uevent() to report an OF modalias if > the device was registered usi

Re: [PATCH 0/4] average: convert users to inline implementation

2015-08-20 Thread David Miller
From: Johannes Berg Date: Wed, 19 Aug 2015 09:46:18 +0200 > Since there's very little benefit of the out-of-line implementation > (a single byte of .text in one driver as far as I've seen), convert > all drivers to the inline implementation, saving memory, and remove > the out-of-line implementat

Re: [PATCH net-next] bnx2x: Fix vxlan endianity issue

2015-08-20 Thread David Miller
From: Yuval Mintz Date: Wed, 19 Aug 2015 10:21:58 +0300 > Commit f34fa14cc033 ("bnx2x: Add vxlan RSS support") has introduced an > endianity issue when passing the vxlan UDP port to the HW. > > Reported-by: > Signed-off-by: Yuval Mintz Applied, thanks. -- To unsubscribe from this list: send t

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

2015-08-20 Thread David Miller
From: Nicolas Dichtel Date: Thu, 20 Aug 2015 16:31:11 +0200 > Le 20/08/2015 13:53, Jiri Benc a écrit : >> On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote: >>> Probably better to introduce veth netlink attribute then, something >>> like >>> IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID. >>

Re: [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb board

2015-08-20 Thread David Miller
From: Fugang Duan Date: Wed, 19 Aug 2015 13:33:58 +0800 > The patch series is to add fec support for i.MX7d sdb board. Since i.MX7d fec > ip is > the same as i.MX6SX, so there have no change for driver itself. > > Patch#1: add bcm54220 PHY ID entry into brcmphy.h file. This is completely, and

Re: [PATCHv4 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-20 Thread Pravin Shelar
On Thu, Aug 20, 2015 at 12:13 PM, Joe Stringer wrote: > On 20 August 2015 at 08:45, Pravin Shelar wrote: >> On Wed, Aug 19, 2015 at 4:04 PM, Joe Stringer wrote: >>> Thanks for the review, >>> >>> On 19 August 2015 at 14:24, Pravin Shelar wrote: On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer

Re: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread David Miller
From: Vaishali Thakkar Date: Fri, 21 Aug 2015 00:28:59 +0530 > On Thu, Aug 20, 2015 at 11:28 PM, David Miller wrote: >> From: Ursula Braun >> Date: Thu, 20 Aug 2015 15:53:42 +0200 >> >>> qeth is an s390-driver, and s390 is a big-endian architecture. Thus >>> arguments valid for little-endian do

xen-netfront: bug with napi_synchronize()

2015-08-20 Thread Charles (Chas) Williams
I have seen some hangs in recent versions of the xen-netfront driver. If I unload or unbind the driver immediately befor bringing up the interface, I get a hang as show in the traceback here. ... [ 194.037351] [] ? msleep+0x27/0x30 [ 194.037358] [] ? xennet_disconnect_backend+0xfa/0x390 [xen

[PATCH v3 05/10] ss: framed skeleton for json output in ss

2015-08-20 Thread Matthias Tafelmeier
This patch just adds the --json flag to ss. Also it ensures proper stats components bracketization – that goes for ex. TCP, UDP, NETLINK etc. Moreover, this patch prevents human readable headers to be printed. The first element flag ensures, that every first output json container element is treate

[PATCH v3 04/10] ss: prepare timer for output handler usage

2015-08-20 Thread Matthias Tafelmeier
Minor preparation Patch Renamed, and exported timer to not have to pass it as a function local parameter argument. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 4

[PATCH v3 06/10] ss: replaced old output mechanisms with fmt handlers interfaces

2015-08-20 Thread Matthias Tafelmeier
Now, since the fmt (json, hr) handlers are in place, all can be output via these newly deviced code parts. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 330 +- 1 file changed, 152 insertions(+), 1

[PATCH v3 03/10] ss: removed obsolet fmt functions

2015-08-20 Thread Matthias Tafelmeier
Those functions are obsoleted since the new fmt handler mechanism subsumes their tasks. Rendundancy would be contradictory to the new mechanism. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 190 --

[PATCH v3 10/10] ss: fixed free on local array for valid json output

2015-08-20 Thread Matthias Tafelmeier
Minor fix to enable json output. Freeing of automatic char array name which will get freed after function stack cleanup. Another one after tcp_stats_fmt for freeing automatic tcpstats struct instance. Signed-off-by: Matthias Tafelmeier --- misc/ss.c | 6 -- 1 file changed, 6 deletions(-) di

[PATCH v3 09/10] ss: symmetrical subhandler output extension example

2015-08-20 Thread Matthias Tafelmeier
This small sized patch shall convey the locations which have to be changed for a symmetrical output extension. Symmetrical means in this context all existing semantically related handlers in the diverse formatters (for hr and json up to now). Suggested-by: Hagen Paul Pfeifer Signed-off-by: Matthi

[PATCH v3 07/10] ss: renaming and export of current_filter

2015-08-20 Thread Matthias Tafelmeier
Exported current_filter as ss_current_filter, because in the fmt handlers, I need that piece of info to resolve out issues of json. Signed-off-by: Matthias Tafelmeier Conflicts: misc/ss.c --- misc/ss.c | 220 +++--- 1 file changed,

[PATCH v3]iproute2: full ss json support and general output simplification

2015-08-20 Thread Matthias Tafelmeier
TLDR: - add full JSON support for ss - Patchset provides a general and easy to use abstraction to extend ss later - Patchset size is large to minimize daily use ("user" should not deal with formation (json, human readble) later on) - Patches 8/10 and 9/10 illustrate how to extend ss for ne

[PATCH v3 08/10] ss: symmetrical formatter extension example

2015-08-20 Thread Matthias Tafelmeier
This commit shall show shortly where to place changes when one wants to extend an ss output formatter with a new handler (format print procedure). The extension is done symmetrically. That means, every up to now existing formatter is extended with a semantically equivalent handler (hr and json form

[PATCH v3 01/10] ss: rooted out ss type declarations for output formatters

2015-08-20 Thread Matthias Tafelmeier
The prospected output formatters and ss do share type declarations like slabstat or tcpstat so that the decision has been made to centralize those declarations in ss_types.h. Potential future declarations shall be placed there. The latter should help amend the extent of ss.c as well. Signed-off-b

[PATCH v3 02/10] ss: created formatters for json and hr

2015-08-20 Thread Matthias Tafelmeier
This patch creates a central formatter module that acts as a kind of switch. From there, more specific handler modules for the certain output formats are called. Up to now, humand readable and json do exist. That prepares ss for potential output format extensions in the future. With the help of su

Re: [PATCH net-next v2 3/9] tunnel: introduce udp_tun_rx_dst()

2015-08-20 Thread Pravin Shelar
On Thu, Aug 20, 2015 at 9:56 AM, Thomas Graf wrote: > On 08/17/15 at 02:11pm, Pravin B Shelar wrote: >> Introduce function udp_tun_rx_dst() to initialize tunnel dst on >> receive path. >> >> Signed-off-by: Pravin B Shelar >> Reviewed-by: Jesse Gross > > This looks great but conflicts with Jiri B

Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-20 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 2:12 PM, David Miller wrote: > From: Pravin B Shelar > Date: Mon, 17 Aug 2015 14:11:41 -0700 > >> + if (tun_dst) >> + skb_dst_set(skb, (struct dst_entry *)tun_dst); >> + > > Please don't cast things like this, it is completely unnecessary: > > skb_d

Re: [PATCH net-next v2 9/9] geneve: Implement rtnl changelink

2015-08-20 Thread Pravin Shelar
On Wed, Aug 19, 2015 at 3:39 PM, Jesse Gross wrote: > On Wed, Aug 19, 2015 at 1:12 PM, Pravin Shelar wrote: >> On Wed, Aug 19, 2015 at 12:40 PM, Jesse Gross wrote: >>> On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c inde

Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-20 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 6:07 PM, Jesse Gross wrote: > On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: >> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >> index 546494d..cb2d874 100644 >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> +static int geneve_configure(st

Re: e1000e: possible reggresion?

2015-08-20 Thread Eric Dumazet
On Thu, 2015-08-20 at 21:37 +0200, Tomas Papan wrote: > Hi there, > > I’m observing a freeze with the recent kernel (4.2-rc7). Unfortunately I > can’t preserver the full traces. > There is nothing in the messages after reboot, I was just lucky one time to > see it when tail -f /var/log/messages

Re: [PATCH net-next 0/4] vrf: cleanups part 2

2015-08-20 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 19 Aug 2015 06:27:06 +0300 > This is the next part of vrf cleanups, patch 1 drops the SLAB_PANIC when > creating kmem cache since it's handled, patch 02 removes a slave duplicate > check which is already done by the lower/upper code, patch 3 moves the > ndo_ad

Re: [PATCH net-next] vrf: plug skb leaks

2015-08-20 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 19 Aug 2015 06:12:29 +0300 > From: Nikolay Aleksandrov > > Currently whenever a packet different from ETH_P_IP is sent through the > VRF device it is leaked so plug the leaks and properly drop these > packets. > > Signed-off-by: Nikolay Aleksandrov Applie

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Eric Dumazet
On Thu, 2015-08-20 at 19:34 +, Grumbach, Emmanuel wrote: > > Err... no :( It won't work for me because the MSS impacts the number of > segments which in turns impact the number of time the headers have to be > copied which impacts... the A-MSDU maximal size which must be bigger > than gso_max

e1000e: possible reggresion?

2015-08-20 Thread Tomas Papan
Hi there, I’m observing a freeze with the recent kernel (4.2-rc7). Unfortunately I can’t preserver the full traces. There is nothing in the messages after reboot, I was just lucky one time to see it when tail -f /var/log/messages was running. This is the only line which I was able to get:

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 04:53 PM, Grumbach, Emmanuel wrote: > > > On 08/20/2015 04:11 PM, Eric Dumazet wrote: >> On Thu, 2015-08-20 at 06:21 +, Grumbach, Emmanuel wrote: >>> >>> On 08/19/2015 11:39 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: > Hm

Re: [PATCH v2 2/2] virtio-net: add default_mtu configuration field

2015-08-20 Thread Flavio Leitner
On Sun, Aug 16, 2015 at 04:42:25PM +0300, Victor Kaplansky wrote: > Sometimes it is essential for libvirt to be able to configure MTU > on guest's NICs to a value different from 1500. > > The change adds a new field to configuration area of network > devices. It will be used to pass initial MTU fr

Re: [PATCHv4 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-20 Thread Joe Stringer
On 20 August 2015 at 08:45, Pravin Shelar wrote: > On Wed, Aug 19, 2015 at 4:04 PM, Joe Stringer wrote: >> Thanks for the review, >> >> On 19 August 2015 at 14:24, Pravin Shelar wrote: >>> On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer >>> wrote: Allow matching and setting the conntrack la

Re: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread Vaishali Thakkar
On Thu, Aug 20, 2015 at 11:28 PM, David Miller wrote: > From: Ursula Braun > Date: Thu, 20 Aug 2015 15:53:42 +0200 > >> qeth is an s390-driver, and s390 is a big-endian architecture. Thus >> arguments valid for little-endian do not apply to qeth-code. > > You can not throw out generally good tree

[PATCH net-next v2 2/2] ila: Precompute checksum difference for translations

2015-08-20 Thread Tom Herbert
In the ILA build state for LWT compute the checksum difference to apply to transport checksums that include the IPv6 pseudo header. The difference is between the route destination (from fib6_config) and the locator to write. Signed-off-by: Tom Herbert --- net/ipv6/ila.c | 18 ++

[PATCH net-next v2 0/2] ila: Precompute checksums

2015-08-20 Thread Tom Herbert
This patch set: - Adds argument ot LWT build_state that holds a pointer to the fib configuration being applied to the new route - Adds support in ILA to precompute checksum difference for performance optimization v2: Move return argument in build_state to end of arguments Tom Herbert (2)

[PATCH net-next v2 1/2] lwt: Add cfg argumnt to build_state

2015-08-20 Thread Tom Herbert
Add cfg and family arguments to lwt build state functions. cfg is a void pointer and will either be a pointer to a fib_config or fib6_config structure. The family parametter indicates which one (either AF_INET or AF_INET6). LWT encpasulation implementation may use the fib configuration to build th

Re: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread David Miller
From: Ursula Braun Date: Thu, 20 Aug 2015 15:53:42 +0200 > qeth is an s390-driver, and s390 is a big-endian architecture. Thus > arguments valid for little-endian do not apply to qeth-code. You can not throw out generally good tree-wide conventions just because it happens to work on your platfor

[PATCH net-next] tcp: fix slow start after idle vs TSO/GSO

2015-08-20 Thread Eric Dumazet
From: Eric Dumazet slow start after idle might reduce cwnd, but we perform this after first packet was cooked and sent. With TSO/GSO, it means that we might send a full TSO packet even if cwnd should have been reduced to IW10. Moving the SSAI check in skb_entail() makes sense, because we slight

Re: [PATCH net-next v2 4/9] geneve: Make dst-port configurable.

2015-08-20 Thread Thomas Graf
On 08/17/15 at 02:11pm, Pravin B Shelar wrote: > @@ -403,6 +416,7 @@ static size_t geneve_get_size(const struct net_device > *dev) > nla_total_size(sizeof(struct in_addr)) + /* IFLA_GENEVE_REMOTE > */ > nla_total_size(sizeof(__u8)) + /* IFLA_GENEVE_TTL */ >

Re: [PATCH net-next v2 3/9] tunnel: introduce udp_tun_rx_dst()

2015-08-20 Thread Thomas Graf
On 08/17/15 at 02:11pm, Pravin B Shelar wrote: > Introduce function udp_tun_rx_dst() to initialize tunnel dst on > receive path. > > Signed-off-by: Pravin B Shelar > Reviewed-by: Jesse Gross This looks great but conflicts with Jiri Benc's IPv6 series. Can we rebase this on top of his work so we

  1   2   >