Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Michal Kubecek
On Thu, Aug 20, 2015 at 06:40:01AM +, Premkumar Jonnala wrote: > > From: Michal Kubecek [mailto:mkube...@suse.cz] > > > > This would break existing scripts using ip to set the parameter. Is the > > possibility to use any of the two really that bad? > > There was another email on this thread w

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
> -Original Message- > From: Michal Kubecek [mailto:mkube...@suse.cz] > Sent: Thursday, August 20, 2015 12:00 PM > To: Premkumar Jonnala > Cc: Wilson, Daniel G; Scott Feldman; netdev@vger.kernel.org > Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for > bridges > an

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Michal Kubecek
On Thu, Aug 20, 2015 at 05:08:51AM +, Premkumar Jonnala wrote: > > From: Wilson, Daniel G [mailto:daniel.wil...@intel.com] > > > > > > Can you extend bridge command to allow setting/getting these bridge attrs? > > > Looks like you construct a RTM_NEWLINK IFLA_INFO_DATA msg. No changes > > > ne

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 11:39 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: > >> Hm.. how would net/core/tso.c avoid this? > > Because a driver using these helpers keep around the original LSO packet > and frees it normally at TX completion time. > Which is why

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
> -Original Message- > From: Scott Feldman [mailto:sfel...@gmail.com] > Sent: Thursday, August 20, 2015 11:09 AM > To: Premkumar Jonnala > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for > bridges > and switch devices. > > On Wed, Au

[PATCH net-next 2/3] tipc: interrupt link synchronization when a link goes down

2015-08-19 Thread Jon Maloy
When we introduced the new link failover/synch mechanism in commit 6e498158a827fd515b514842e9a06bdf0f75ab86 ("tipc: move link synch and failover to link aggregation level"), we missed the case when the non-tunnel link goes down during the link synchronization period. In this case the tunnel link wi

[PATCH net-next 0/3] tipc: fix link failover/synch problems

2015-08-19 Thread Jon Maloy
We fix three problems with the new link failover/synch implementation, which was introduced earlier in this release cycle. They are all related to situations where there is a very short interval between the disabling and enabling of interfaces. Jon Maloy (3): tipc: eliminate risk of premature li

[PATCH net-next 1/3] tipc: eliminate risk of premature link setup during failover

2015-08-19 Thread Jon Maloy
When a link goes down, and there is still a working link towards its destination node, a failover is initiated, and the failed link is not allowed to re-establish until that procedure is finished. To ensure this, the concerned link endpoints are set to state LINK_FAILINGOVER, and the node endpoints

[PATCH net-next 3/3] tipc: fix stale link problem during synchronization

2015-08-19 Thread Jon Maloy
Recent changes to the link synchronization means that we can now just drop packets arriving on the synchronizing link before the synch point is reached. This has lead to significant simplifications to the implementation, but also turns out to have a flip side that we need to consider. Under unluck

Re: Exporting obscene amounts of data in rtnl_link_ops->fill_info()

2015-08-19 Thread Scott Feldman
On Wed, Aug 19, 2015 at 5:47 PM, Jason A. Donenfeld wrote: > Hi guys, > > I have a new link driver that registers a rtnl_link_ops. For many > things, the rtnl interfaces are perfectly suited: I can use netlink in > userspace to check out packet counts, adjust interface parameters, and > all sorts

[PATCH net] netlink: rx mmap: fix POLLIN condition

2015-08-19 Thread Ken-ichirou MATSUZAWA
Now poll() returns immediately after setting kernel current frame (ring->head) to SKIP from user space even if there are no new frames. And in a case of all frames is VALID, user space program unintensionally sets (only) kernel current frame to UNUSED, then calls poll(), it will not return immediat

Re: netlink_route kernel data dump size increased

2015-08-19 Thread tej parkash
On Thu, Aug 20, 2015 at 2:47 AM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 23:41 +0530, tej parkash wrote: >> All, >> >> We are running application on Linux Kernel 3.10 to collect network >> interface information using NETLINK_ROUTE protocol. earlier (kernel >> 2.6.32) we were having 8K buffer

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Scott Feldman
On Wed, Aug 19, 2015 at 10:12 PM, Premkumar Jonnala wrote: > > >> -Original Message- >> From: Scott Feldman [mailto:sfel...@gmail.com] >> Sent: Thursday, August 20, 2015 10:31 AM >> To: Premkumar Jonnala >> Cc: netdev@vger.kernel.org >> Subject: Re: [PATCH] bridge: Enable configuration of

Re: linux-next: build failure after merge of the net-next tree

2015-08-19 Thread David Miller
From: Stephen Rothwell Date: Thu, 20 Aug 2015 12:57:34 +1000 > After merging the net-next tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > net/ipv4/fib_semantics.c: In function 'fib_encap_match': > net/ipv4/fib_semantics.c:553:3: error: implicit declaration of func

Re: [PATCH v2 net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel

2015-08-19 Thread David Miller
From: YOSHIFUJI Hideaki Date: Thu, 20 Aug 2015 11:29:06 +0900 > Jiri Benc wrote: >> On Wed, 19 Aug 2015 19:27:22 +0900, YOSHIFUJI Hideaki wrote: You're right generally. But this one should be okay and I did this deliberately: the patch adding LWTUNNEL_ENCAP_ILA was merged two days

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
> -Original Message- > From: Scott Feldman [mailto:sfel...@gmail.com] > Sent: Thursday, August 20, 2015 10:31 AM > To: Premkumar Jonnala > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH] bridge: Enable configuration of ageing interval for > bridges > and switch devices. > > On Wed, Au

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
Hi Daniel, Thank you for the comments. Please see inline. > -Original Message- > From: Wilson, Daniel G [mailto:daniel.wil...@intel.com] > Sent: Wednesday, August 19, 2015 11:33 PM > To: Scott Feldman; Premkumar Jonnala > Cc: netdev@vger.kernel.org > Subject: RE: [PATCH] bridge: Enable c

[v2 5/5] NET: nps_enet: minor namespace cleanup

2015-08-19 Thread Noam Camus
From: Noam Camus We define buf_int_enable in the minimal namespace it is used. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchi

[v2 4/5] NET: nps_enet: TX done acknowledge.

2015-08-19 Thread Noam Camus
From: Noam Camus This is needed for when TX done interrupt is in "level mode". For example it is true for some simulators of this device. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/

[v2 1/5] NET: nps_enet: replace use of cause register

2015-08-19 Thread Noam Camus
From: Noam Camus When interrupt is received we read directly from control register for RX/TX instead of reading cause register since this register fails to indicate TX done when TX interrupt is "edge mode". Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |9 +

[v2 3/5] NET: nps_enet: drop control frames

2015-08-19 Thread Noam Camus
From: Noam Camus We set controller to drop control frames and not trying to pass them on. This is only needed for debug reasons. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethe

[v2 2/5] NET: nps_enet: TX done race condition

2015-08-19 Thread Noam Camus
From: Noam Camus We need to set tx_skb pointer before send frame. If we receive interrupt before we set pointer we will try to free SKB with wrong pointer. Now we are sure that SKB pointer will never be NULL during handling TX done and check is removed. Signed-off-by: Noam Camus --- drivers/ne

[v2 0/5] *** nps_enet fixups ***

2015-08-19 Thread Noam Camus
From: Noam Camus Change v2 TX done is handled back with NAPI poll. Change v1 This patch set is a bunch of fixes to make nps_enet work correctly with all platforms, i.e. real device, emulation system, and simulation system. The main trigger for this patch set was that in our emulation system the

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Scott Feldman
On Wed, Aug 19, 2015 at 9:56 PM, Premkumar Jonnala wrote: > Thank you Scott. Please see inline. > >> >> -Original Message- >> >> From: Scott Feldman [mailto:sfel...@gmail.com] >> >> Sent: Tuesday, August 18, 2015 12:48 PM >> >> To: Premkumar Jonnala >> >> Cc: netdev@vger.kernel.org >> >>

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-19 Thread Premkumar Jonnala
Thank you Scott. Please see inline. > >> -Original Message- > >> From: Scott Feldman [mailto:sfel...@gmail.com] > >> Sent: Tuesday, August 18, 2015 12:48 PM > >> To: Premkumar Jonnala > >> Cc: netdev@vger.kernel.org > >> Subject: Re: [PATCH] bridge: Enable configuration of ageing interval

Re: Re: [PATCH] usbnet: dereference after null check in usbnet_start_xmit() and __usbnet_read_cmd()

2015-08-19 Thread Vivek Kumar Bhagat
Dear Bjorn, >>This is wrong. There are usbnet minidrivers depending on info->tx_fixup >> being called with a NULL skb. Also, if dev_hard_start_xmit() ensures that skb can not be NULL in usbnet_start_xmit() then we should remove below check. if (skb) <--- This check is confusing which sa

Re^2:: [PATCH] usbnet: dereference after null check in usbnet_start_xmit() and __usbnet_read_cmd()

2015-08-19 Thread Vivek Kumar Bhagat
Dear Bjorn, >> This is wrong. There are usbnet minidrivers depending on info->tx_fixup >> being called with a NULL skb. I am using ax88179_178a driver and not familiar with usbnet minidrivers. When ax88179_tx_fixup() is called with NULL skb from usbnet_start_xmit(), I get a kernel crash. Back

[PATCH net] netlink: mmap: fix tx type check

2015-08-19 Thread Ken-ichirou MATSUZAWA
I can't send netlink message via mmaped netlink socket since commit: a8866ff6a5bce7d0ec465a63bc482a85c09b0d39 netlink: make the check for "send from tx_ring" deterministic msg->msg_iter.type is set to WRITE (1) at SYSCALL_DEFINE6(sendto, ... import_single_range(WRITE, ...

[PATCH] net: bcmgenet: fix uncleaned dma flags

2015-08-19 Thread Jaedon Shin
Clean the dma flags of multiq ring buffer int the interface stop process. This patch fixes that the genet is not running while the interface is re-enabled. $ ifup eth0 - running after booting $ ifdown eth0 $ ifup eth0 - not running and occur tx_timeout The bcmgenet_dma_disable() in bcmgenet_open(

linux-next: build failure after merge of the net-next tree

2015-08-19 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (arm multi_v7_defconfig) failed like this: net/ipv4/fib_semantics.c: In function 'fib_encap_match': net/ipv4/fib_semantics.c:553:3: error: implicit declaration of function 'lwtstate_free' [-Werror=implicit-function-declaration]

Re: [PATCH v2 2/2] virtio-net: add default_mtu configuration field

2015-08-19 Thread Jason Wang
On 08/19/2015 07:31 PM, Victor Kaplansky wrote: > On Mon, Aug 17, 2015 at 11:07:15AM +0800, Jason Wang wrote: >> >> On 08/16/2015 09:42 PM, Victor Kaplansky wrote: >>> @@ -3128,6 +3134,7 @@ struct virtio_net_config { >>> u8 mac[6]; >>> le16 status; >>> le16 max_virtqueu

Re: [PATCH v2 1/2] virtio-net: rephrase devconf fields description

2015-08-19 Thread Jason Wang
On 08/19/2015 07:54 PM, Victor Kaplansky wrote: > On Mon, Aug 17, 2015 at 10:43:46AM +0800, Jason Wang wrote: >> >> On 08/16/2015 09:42 PM, Victor Kaplansky wrote: >>> Clarify general description of the mac, status and >>> max_virtqueue_pairs fields. Specifically, the old description is >>> vague

RE: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

2015-08-19 Thread Hayes Wang
Corinna Vinschen [mailto:vinsc...@redhat.com] > Sent: Thursday, August 20, 2015 3:24 AM [...] > + /* > + * Versions prior to RTL_GIGA_MAC_VER_19 don't support resetting the > + * tally counters. > + */ > + if (tp->mac_version >= RTL_GIGA_MAC_VER_19) { > + RTL_W32(

Re: [PATCH v2 net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel

2015-08-19 Thread YOSHIFUJI Hideaki
Jiri Benc wrote: > On Wed, 19 Aug 2015 19:27:22 +0900, YOSHIFUJI Hideaki wrote: >>> You're right generally. But this one should be okay and I did this >>> deliberately: the patch adding LWTUNNEL_ENCAP_ILA was merged two days >>> ago, is in net-next only, is not used by anything in user space yet. >

RE: [PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID

2015-08-19 Thread Duan Andy
From: Florian Fainelli Sent: Thursday, August 20, 2015 5:29 AM > To: Duan Fugang-B38611 > Cc: shawn...@kernel.org; David Miller; netdev; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID > > 2015-08-18 22:33 GMT-07:00 Fugang Duan : > >

[net-next 10/16] i40e: correct spelling error

2015-08-19 Thread Jeff Kirsher
From: Mitch Williams Turns out that 'inavlid' is an inavlid spelling for 'invalid'. Change-ID: Ie1fe2d0f8d1ba75ab880594875ec2e4152a76f61 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 file change

[net-next 11/16] i40evf: Use the correct defines to match the VF registers

2015-08-19 Thread Jeff Kirsher
From: Anjali Singhai Jain Use CTLN1 instead of CTLN for the VF relative register space. Change-ID: Iefba63faf0307af55fec8dbb64f26059f7d91318 Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 28 ++

[net-next 15/16] i40e/i40evf: Cache the CEE TLV status returned from firmware

2015-08-19 Thread Jeff Kirsher
From: Neerav Parikh Store the CEE TLV status returned by firmware to allow drivers to dump that for debug purposes. Change-ID: Ie3c4cf8cebabee4f15e1e3fdc4fc8a68bbca40ee Signed-off-by: Neerav Parikh Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_

[net-next 08/16] i40e/i40evf: Add capability to gather VEB per TC stats

2015-08-19 Thread Jeff Kirsher
From: Neerav Parikh This patch adds capability to update per VEB per TC statistics and dump it via ethtool. It also adds a structure to hold VEB per TC statistics. The fields can be filled by reading the GLVEBTC_* counters. Change-ID: I28b4759b9ab6ad5a61f046a1bc9ef6b16fe31538 Signed-off-by: Neer

[net-next 16/16] i40e/i40evf: Bump i40e to 1.3.9 and i40evf to 1.3.5

2015-08-19 Thread Jeff Kirsher
From: Catherine Sullivan Bump version and update the copyright year for i40evf. Change-ID: Iddb81b9dba09f0dc57ab54937b5821ecdd721ff6 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/

[net-next 06/16] i40e: Fix legacy interrupt mode in the driver

2015-08-19 Thread Jeff Kirsher
From: Anjali Singhai Jain This patch fixes the driver flow to take into account legacy interrupts. Over time we added code that assumes MSIX is the only mode that the driver runs in. It also enables a legacy workaround to trigger SWINT when the TX ring has non-cache aligned descriptors pending an

[net-next 13/16] i40e: Remove redundant and unneeded messages

2015-08-19 Thread Jeff Kirsher
From: Greg Rose The kernel notifies all VXLAN capable registered drivers, i.e. any driver that implements ndo_add_vxlan_port(), of the addition of a port so that the driver can track which ports are in use. There's no need to log this - it just fills the system log with useless and irksome noise

[net-next 04/16] i40e/i40evf: Move helper functions to a header file

2015-08-19 Thread Jeff Kirsher
From: Anjali Singhai Jain A new header file i40e_helper.h is added to both the PF and VF driver with functions used by both drivers. Change-ID: I3c6daedc2ff6f32bc7624bf5eaef05899d35f28b Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/et

[net-next 03/16] i40e: add RX to port CRC errors label

2015-08-19 Thread Jeff Kirsher
From: Shannon Nelson The port.crc_errors is really an RX counter, so let's mark it as such. Change-ID: I179afd3f8a95d45229bb4163a6aeb01f0d2d250b Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 fil

[net-next 14/16] i40e/i40evf: add VIRTCHNL_VF_OFFLOAD flag

2015-08-19 Thread Jeff Kirsher
From: Anjali Singhai Jain Add virtual channel offload capability to support RX polling mode in the VF. Change-ID: Ib643ae2a7506dfc75fc489fc207493fabefa4832 Signed-off-by: Jingjing Wu Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethe

[net-next 05/16] i40e: Move function calls to i40e_shutdown instead of i40e_suspend

2015-08-19 Thread Jeff Kirsher
From: Catherine Sullivan We should be stopping the service task and flow director on shutdown not on suspension. Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +--- 1 file changed, 13 in

[net-next 00/16][pull request] Intel Wired LAN Driver Updates 2015-08-19

2015-08-19 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Anjali provides a fix for i40e where the part is not receiving multicast or VLAN tagged packets when in promiscuous mode. This can occur when a software bridge is created on top of the device. Added a new header for helper functions for both

[net-next 02/16] i40e: don't degrade __le16

2015-08-19 Thread Jeff Kirsher
From: Mitch Williams Sparse cries when we compare an __le16 to a u16, almost like it cares about architectures other than x86. Weird. Use the le16_to_cpu macro to make it stop crying. Change-ID: Id068f4d7868a2d3df234a791a76d15938f37db35 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Si

[net-next 07/16] i40e: Fix ethtool offline diagnostic with netqueues

2015-08-19 Thread Jeff Kirsher
From: Greg Rose Treat netqueues the same way we do virtual functions when someone wants to run the ethtool offline diagnostic test. Change-ID: Id48d2b933f1fd0db7be06305a93c6ebe3dc821f5 Signed-off-by: Greg Rose Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/inte

[net-next 09/16] i40e: Fix comment for ethtool diagnostic link test

2015-08-19 Thread Jeff Kirsher
From: Greg Rose The existing comment is incorrect. Add new comment to point out that the PF reset does not affect link but if the reset is changed to a different type that does affect link then the link test would need to be moved to before the reset. Change-ID: I28d786f46e9465860babdee61c1dba5

[net-next 01/16] i40e: Set defport behavior for the Main VSI when in promiscuous mode

2015-08-19 Thread Jeff Kirsher
From: Anjali Singhai Jain This fixes bugs where the port is not receiving multicast or vlan tagged packets when in promiscuous mode. This can occur when a SW bridge is created on top of the device. This also fixes issues where the promiscuous behavior setting was not being preserved across a res

Exporting obscene amounts of data in rtnl_link_ops->fill_info()

2015-08-19 Thread Jason A. Donenfeld
Hi guys, I have a new link driver that registers a rtnl_link_ops. For many things, the rtnl interfaces are perfectly suited: I can use netlink in userspace to check out packet counts, adjust interface parameters, and all sorts of things. There is even the "fill_info" function exporting interface-s

DEBUG_LOCKS_WARN_ON(in_interrupt()) triggering in socket code

2015-08-19 Thread Jason A. Donenfeld
Hi folks, In setting up a socket, there are two functions I make use of that in turn wind up calling static_key_slow_inc: setup_udp_tunnel_sock and sk_set_memalloc. These both make use of static_key_slow_inc because they selectively enable certain important code paths. This is all fine, except it

Re: [PATCH RESEND net-next] lwtunnel: Fix the sparse warnings in fib_encap_match

2015-08-19 Thread David Miller
From: Ying Xue Date: Wed, 19 Aug 2015 15:46:17 +0800 > When CONFIG_LWTUNNEL config is not enabled, the lwtstate_free() is not > declared in lwtunnel.h at all. However, even in this case, the function > is still referenced in fib_semantics.c so that there appears the > following sparse warnings: >

[GIT] Networking

2015-08-19 Thread David Miller
1) Out of bounds array access in 802.11 minstrel code, from Adrien Schildknecht. 2) Don't use skb_get() in IGMP/MLD code paths, as this makes pskb_may_pull() BUG. From Linus Luessing. 3) Fix off by one in ipv4 route dumping code, from Andy Whitcroft. 4) Fix deadlock in reqsk_queue_unlink

RE: [Intel-wired-lan] [Patch V3 5/9] i40e: Use numa_mem_id() to better support memoryless node

2015-08-19 Thread David Rientjes
On Wed, 19 Aug 2015, Patil, Kiran wrote: > Acked-by: Kiran Patil Where's the call to preempt_disable() to prevent kernels with preemption from making numa_node_id() invalid during this iteration? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to ma

[PATCH net-next v3 2/3] vxlan: GRO support at tunnel layer

2015-08-19 Thread Tom Herbert
Add calls to gro_cells infrastructure to do GRO when receiving on a tunnel. Testing: Ran 200 netperf TCP_STREAM instance - With fix (GRO enabled on VXLAN interface) Verify GRO is happening. 9084 MBps tput 3.44% CPU utilization - Without fix (GRO disabled on VXLAN interface)

[PATCH net-next v3 3/3] fou: Do WARN_ON_ONCE in gue_gro_receive for bad proto callbacks

2015-08-19 Thread Tom Herbert
Do WARN_ON_ONCE instead of WARN_ON in gue_gro_receive when the offload callcaks are bad (either don't exist or gro_receive is not specified). Signed-off-by: Tom Herbert --- net/ipv4/fou.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index eb

[PATCH net-next v3 0/3] gro: Fixes for tunnels and GRO

2015-08-19 Thread Tom Herbert
This patch set addresses some issue related to tunneling and GRO: - Fix remote checksum offload to properly deal with frag0 in GRO. - Add support for GRO at VXLAN tunnel (call gro_cells) Testing: Ran one netperf TCP_STREAM to highlight impact of different configurations: GUE Zero UDP checksum

[PATCH net-next v3 1/3] gro: Fix remcsum offload to deal with frags in GRO

2015-08-19 Thread Tom Herbert
The remote checksum offload GRO did not consider the case that frag0 might be in use. This patch fixes that by accessing headers using the skb_gro functions and not saving offsets relative to skb->head. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 23 +-- includ

Re: [PATCH] net: Provide lwtstate_free for non-lwt config

2015-08-19 Thread Alex Gartrell
On Wed, Aug 19, 2015 at 4:28 PM, Eric Dumazet wrote: > We've seen similar patches earlier today on netdev ;) Ah, the mailing list equivalent of someone letting you know that you left your fly down :) Sorry for the noise! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH iproute2 1/2] libs: close file in netns_switch()

2015-08-19 Thread Stephen Hemminger
On Fri, 14 Aug 2015 02:56:52 + Zhang Shengju wrote: > Add mising close() calls. > > Signed-off-by: Zhang Shengju Patch does not apply cleanly to current git code. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH iproute2] ip-link: cut one level indentation

2015-08-19 Thread Stephen Hemminger
On Fri, 14 Aug 2015 03:13:41 + Zhang Shengju wrote: > Cut one level indentation to make things easier to read. > > Signed-off-by: Zhang Shengju Applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [iproute PATCH] ip-address.8.in: fix BNF syntax error

2015-08-19 Thread Stephen Hemminger
On Tue, 18 Aug 2015 16:11:12 + Phil Sutter wrote: > The previous man page fixup introduced a syntax error due to missing > opening bracket, which might crash some humanoid BNF parsers. > > Fixes: 4e972d5 ("ip-address: fix and extend documentation") > Signed-off-by: Phil Sutter Both applied

Re: [PATCH iproute2] ip: replace exit with return

2015-08-19 Thread Stephen Hemminger
On Tue, 11 Aug 2015 09:40:23 + Zhang Shengju wrote: > In our manual, we have this description of 'EXIT STATUS': > Exit status is 0 if command was successful, and 1 if there is a syntax > error. > > But we exit in command functions with code -1 when there is a syntax error. > It's better to u

Re: [PATCH] net: Provide lwtstate_free for non-lwt config

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 15:41 -0700, Alex Gartrell wrote: > On Wed, Aug 19, 2015 at 3:16 PM, Alex Gartrell wrote: > > Fixes: df383e624 ("lwtunnel: fix memory leak") > > Ah sorry, this is PATCH net-next, obviously :/ We've seen similar patches earlier today on netdev ;) -- To unsubscribe from th

Re: [PATCH 07/10] ss: renaming and export of current_filter

2015-08-19 Thread Stephen Hemminger
The series looks good, but this patch does not apply to current master branch. The rejected part was. --- misc/ss.c +++ misc/ss.c @@ -3273,7 +3273,7 @@ int main(int argc, char *argv[]) { char *p, *p1; if (!saw_query) { -

[PATCH net-next] net/xen-netfront: only clean up queues if present

2015-08-19 Thread Charles (Chas) Williams
From: Chas Williams <3ch...@gmail.com> If you simply load and unload the module without starting the interfaces, the queues are never created and you get a bad pointer dereference. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drivers/net/xen-netfront.c | 5 +++-- 1 file changed, 3 inserti

Re: [PATCH] bluetooth:Make the function sco_conn_del have a return type of void

2015-08-19 Thread Marcel Holtmann
Hi Nicholas, > This makes the function sco_conn_del have a return type of void now > due to this function always running successfully and thus never > needing to signal its caller when a non recoverable internal failure > occurs by returning a error code to its respective caller. > > Signed-off-b

Re: [PATCHv4 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-19 Thread Joe Stringer
Thanks for the review, On 19 August 2015 at 14:24, Pravin Shelar wrote: > On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: >> Allow matching and setting the conntrack label field. As with ct_mark, >> this is populated by executing the CT action, and is a writable field. >> Specifying a label

Re: [PATCHv4 net-next 10/10] openvswitch: Allow attaching helpers to ct action

2015-08-19 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: > Add support for using conntrack helpers to assist protocol detection. > The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper > to be used for this connection. > > Example ODP flows allowing FTP connections from ports 1->2:

[PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback

2015-08-19 Thread Vivien Didelot
The current Secure port mode requires the port-based VLANs to also be valid in the 802.1Q VLAN Table Unit. The current hardware bridging support only configures the port-based VLANs, thus is broken. A new patchset is required to adapt the hardware bridging code to fully support the Secure port mod

Re: [PATCH] net: Provide lwtstate_free for non-lwt config

2015-08-19 Thread Alex Gartrell
On Wed, Aug 19, 2015 at 3:16 PM, Alex Gartrell wrote: > Fixes: df383e624 ("lwtunnel: fix memory leak") Ah sorry, this is PATCH net-next, obviously :/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next v2 9/9] geneve: Implement rtnl changelink

2015-08-19 Thread Jesse Gross
On Wed, Aug 19, 2015 at 1:12 PM, Pravin Shelar wrote: > On Wed, Aug 19, 2015 at 12:40 PM, Jesse Gross wrote: >> On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: >>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>> index e47cdd9..0d7fbef 100644 >>> --- a/drivers/net/geneve.c >>

RE: [Intel-wired-lan] [Patch V3 5/9] i40e: Use numa_mem_id() to better support memoryless node

2015-08-19 Thread Patil, Kiran
Acked-by: Kiran Patil -Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Jiang Liu Sent: Sunday, August 16, 2015 8:19 PM To: Andrew Morton; Mel Gorman; David Rientjes; Mike Galbraith; Peter Zijlstra; Wysocki, Rafael J; Tang Chen; Teju

[PATCH] net: Provide lwtstate_free for non-lwt config

2015-08-19 Thread Alex Gartrell
Fixes: df383e624 ("lwtunnel: fix memory leak") Signed-off-by: Alex Gartrell --- include/net/lwtunnel.h | 4 1 file changed, 4 insertions(+) diff --git a/include/net/lwtunnel.h b/include/net/lwtunnel.h index 34fd8f7..cfee539 100644 --- a/include/net/lwtunnel.h +++ b/include/net/lwtunnel.h @

Re: [PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID

2015-08-19 Thread Florian Fainelli
2015-08-18 22:33 GMT-07:00 Fugang Duan : > Add bcm54220 phy ID entry. This change itself is fine, but looking at the rest of your changes, we are not adding an entry for this PHY in drivers/net/phy/broadcom.c, which means that we will bind to the Generic PHY driver, and so this looks sufficient, e

Re: [PATCH net-next 0/3] D in DSA patches

2015-08-19 Thread Florian Fainelli
2015-08-17 14:52 GMT-07:00 Andrew Lunn : > The D in DSA is distributed, meaning multiple switches can be > connected together. Currently no mainline system does this, and so the > code is broken. This patchset contains two fixes, and a small helper. > > With three of more switches, the current devi

Re: [PATCHv4 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-19 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: > Allow matching and setting the conntrack label field. As with ct_mark, > this is populated by executing the CT action, and is a writable field. > Specifying a label and optional mask allows the label to be modified, > which takes effect on the

Re: netlink_route kernel data dump size increased

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 23:41 +0530, tej parkash wrote: > All, > > We are running application on Linux Kernel 3.10 to collect network > interface information using NETLINK_ROUTE protocol. earlier (kernel > 2.6.32) we were having 8K buffer allocated to collect all data but > with new kernel (3.10) w

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Phil Sutter
On Wed, Aug 19, 2015 at 01:33:40PM -0700, Eric Dumazet wrote: > On Wed, 2015-08-19 at 13:31 -0700, Eric Dumazet wrote: > > > lpaa5:~# tc qd sh dev eth1 > > qdisc mq 0: root > > qdisc fq 0: parent :4 limit 1p flow_limit 1000p buckets 1024 bands 3 > > priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 qu

Re: [PATCH net-next] vrf: plug skb leaks

2015-08-19 Thread David Ahern
On 8/19/15 1:17 PM, Nikolay Aleksandrov wrote: On Aug 19, 2015, at 8:27 PM, Nikolay Aleksandrov wrote: On Aug 19, 2015 20:13, "David Ahern" wrote: Hi Nikolay: On 8/18/15 8:12 PM, Nikolay Aleksandrov wrote: diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index ed208317cbb5..4aa0645

Re: [PATCHv4 net-next 08/10] netfilter: connlabels: Export setting connlabel length

2015-08-19 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: > Add functions to change connlabel length into nf_conntrack_labels.c so > they may be reused by other modules like OVS and nftables without > needing to jump through xt_match_check() hoops. > > Suggested-by: Florian Westphal > Signed-off-by: J

Re: [PATCHv4 net-next 07/10] netfilter: Always export nf_connlabels_replace()

2015-08-19 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: > The following patches will reuse this code from OVS. > > Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCHv4 net-next 06/10] openvswitch: Allow matching on conntrack mark

2015-08-19 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: > Allow matching and setting the conntrack mark field. As with conntrack > state and zone, these are populated when the CT action is executed, > and are made available for matching via RECIRC. To write to this field, > a value and optional mark

Re: [PATCH v2 net-next 12/13] ipv6: route: extend flow representation with tunnel key

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:10pm, Jiri Benc wrote: > Use flowi_tunnel in flowi6 similarly to what is done with IPv4. > This complements commit 1b7179d3adff ("route: Extend flow representation > with tunnel key"). > > Signed-off-by: Jiri Benc Acked-by: Thomas Graf -- To unsubscribe from this list: send th

Re: [PATCH v2 net-next 10/13] vxlan: do not shadow flags variable

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:10pm, Jiri Benc wrote: > The 'flags' variable is already defined in the outer scope. > > Signed-off-by: Jiri Benc Acked-by: Thomas Graf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH v2 net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:10pm, Jiri Benc wrote: > Allow specification of per route IP tunnel instructions also for IPv6. > This complements commit 3093fbe7ff4b ("route: Per route IP tunnel metadata > via lightweight tunnel"). > > Signed-off-by: Jiri Benc Acked-by: Thomas Graf -- To unsubscribe from th

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: > Hm.. how would net/core/tso.c avoid this? Because a driver using these helpers keep around the original LSO packet and frees it normally at TX completion time. > I can't see anything related to truesize there. > Note that this work s

Re: [PATCH v2 net-next 11/13] vxlan: metadata based tunneling for IPv6

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:10pm, Jiri Benc wrote: > Support metadata based (formerly flow based) tunneling also for IPv6. > This complements commit ee122c79d422 ("vxlan: Flow based tunneling"). > > Signed-off-by: Jiri Benc Acked-by: Thomas Graf -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH ipsec-next] xfrm: Use VRF master index if output device is enslaved

2015-08-19 Thread Steffen Klassert
On Wed, Aug 19, 2015 at 11:35:55AM -0700, David Ahern wrote: > > > >I think you should use the new vrf_master_index() helper that acquires rcu > >because > >it looks possible to call ->decode_session() without rcu read lock, e.g. in > >the hold_timer > >function xfrm_policy_queue_process(), thoug

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 13:31 -0700, Eric Dumazet wrote: > lpaa5:~# tc qd sh dev eth1 > qdisc mq 0: root > qdisc fq 0: parent :4 limit 1p flow_limit 1000p buckets 1024 bands 3 > priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 quantum 3028 initial_quantum 15140 > qdisc fq 0: parent :3 limit 1p flo

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Eric Dumazet
On Wed, 2015-08-19 at 22:21 +0200, Phil Sutter wrote: > On Wed, Aug 19, 2015 at 08:39:24PM +0200, Phil Sutter wrote: > [...] > > I'll start implementing the above immediately, but would appreciate to > > hear your comments on it meanwhile. I wonder especially what makes the > > difference between p

Re: [PATCHv4 net-next 05/10] openvswitch: Add conntrack action

2015-08-19 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer wrote: > Expose the kernel connection tracker via OVS. Userspace components can > make use of the "ct()" action, followed by "recirculate", to populate > the conntracking state in the OVS flow key, and subsequently match on > that state. > > Example OD

Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

2015-08-19 Thread Phil Sutter
On Wed, Aug 19, 2015 at 08:39:24PM +0200, Phil Sutter wrote: [...] > I'll start implementing the above immediately, but would appreciate to > hear your comments on it meanwhile. I wonder especially what makes the > difference between pfifo and pfifo_fast and why the latter can't be > selected expli

Re: linux-next: unregister_netdevice: waiting for lo to become free. Usage count = 1

2015-08-19 Thread Andrey Wagin
2015-08-18 18:27 GMT+03:00 David Ahern : > On 8/18/15 9:24 AM, Andrey Wagin wrote: >> >> Hello David, >> >> CRIU tests detetect that references on net devices leak on >> 4.2.0-rc6-next-20150817. Looks like it started with >> v4.2-rc6-882-g3bfd847. > > > 1e3136789975f03e461798149309034e5213c1b4 shou

Re: [PATCH net-next] vrf: plug skb leaks

2015-08-19 Thread Nikolay Aleksandrov
> On Aug 19, 2015, at 8:27 PM, Nikolay Aleksandrov > wrote: > > > On Aug 19, 2015 20:13, "David Ahern" wrote: > > > > Hi Nikolay: > > > > > > On 8/18/15 8:12 PM, Nikolay Aleksandrov wrote: > >> > >> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c > >> index ed208317cbb5..4aa06450fafa 10064

Re: [PATCH net-next v2 7/9] geneve: Consolidate Geneve functionality in single module.

2015-08-19 Thread Pravin Shelar
On Wed, Aug 19, 2015 at 12:50 PM, Jesse Gross wrote: > On Wed, Aug 19, 2015 at 11:49 AM, Pravin Shelar wrote: >> On Wed, Aug 19, 2015 at 11:37 AM, Jesse Gross wrote: >>> On Wed, Aug 19, 2015 at 11:29 AM, Pravin Shelar wrote: On Wed, Aug 19, 2015 at 11:18 AM, Jesse Gross wrote: > My gu

Re: [PATCH net-next v2 9/9] geneve: Implement rtnl changelink

2015-08-19 Thread Pravin Shelar
On Wed, Aug 19, 2015 at 12:40 PM, Jesse Gross wrote: > On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: >> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >> index e47cdd9..0d7fbef 100644 >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> -static int geneve_configure(s

[PATCH net-next] 3c59x: Add BQL support for 3c59x ethernet driver.

2015-08-19 Thread Loganaden Velvindron
--- drivers/net/ethernet/3com/3c59x.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c index 753887d..2839af0 100644 --- a/drivers/net/ethernet/3com/3c59x.c +++ b/drivers/net/ethernet

  1   2   3   >