Re: sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-19 Thread Herbert Xu
On Fri, Jul 17, 2015 at 05:38:30PM +0200, Wolfgang Walter wrote: > > eth1 stops sending with the patch after some time > disabling gro on eth0 helps > disabling tso or gso on eth0 and/or eth1 or both does not help > > eth0 and eth1 are both intel I350. What does ethtool -k eth1 say? Can you conf

RE: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-19 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov > Sent: Friday, July 17, 2015 23:04 > To: Dexuan Cui > Dexuan Cui writes: > > >> From: David Miller > >> Sent: Thursday, July 16, 2015 12:19 > >> > >> From: Dexuan Cui > >> Date: Tue, 14 Jul 2015 03:00:48 -0700 > >> > >> > +pr_debug("hv

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-19 Thread Kalle Valo
Johannes Berg writes: > And while at it, please use links that include the message-id (e.g. > mid.gmane.org) so it's searchable even if the archive disappears. BTW, I recently found out that kernel.org has a this type of service as well. From https://lkml.kernel.org/: http://lkml.kernel.org/r/

[netfilter] INFO: task kworker/u2:0:6 blocked for more than 120 seconds.

2015-07-19 Thread Fengguang Wu
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git master commit 085db2c04557d31db61541f361bd8b4de92c9939 Author: Eric W. Biederman AuthorDate: Fri Jul 10 18:15:06 2015 -0500 Commit: Pabl

Re: patch for udp_sendmsg

2015-07-19 Thread Li Wei
Hello, Read "Documentation/SubmittingPatches" before sending out the first patch. On 07/19/2015 10:38 PM, Zhenwei Pi wrote: > Dear Sirs, > > Commit : the max length of udp msg is (0x - sizeof(struct udphdr) - > sizeof(struct iphdr). return -EMSGSIZE in udp_sendmsg. > Patch : as the

Re: [PATCH v2 -next] net: fib: use fib result when zero-length prefix aliases exist

2015-07-19 Thread Florian Westphal
Julian Anastasov wrote: > ip neigh add $IP dev $DEV nud none > ip neigh list nud none > > It is present and not used yet. Even ip route get > can not trigger neigh resolving, state will remain same. > Only traffic can trigger resolving. Right. > > > round-robin only among reachables? Bu

[PATCHv2 net-next] net: #ifdefify sk_classid member of struct sock

2015-07-19 Thread Mathias Krause
The sk_classid member is only required when CONFIG_CGROUP_NET_CLASSID is enabled. #ifdefify it to reduce the size of struct sock on 32 bit systems, at least. Signed-off-by: Mathias Krause --- v2: - ensure we'll error out in nft_meta_get_init() if CONFIG_CGROUP_NET_CLASSID is not set include/n

Re: [PATCH net-next] net: #ifdefify sk_classid member of struct sock

2015-07-19 Thread Mathias Krause
On 19 July 2015 at 20:42, David Miller wrote: > From: Mathias Krause > Date: Sun, 19 Jul 2015 20:17:41 +0200 > >> The sk_classid member is only required when CONFIG_CGROUP_NET_CLASSID is >> enabled. #ifdefify it to reduce the size of struct sock on 32 bit >> systems, at least. >> >> Signed-off-by

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-19 Thread Joe Perches
On Sun, 2015-07-19 at 11:38 -0700, David Miller wrote: > From: Sowmini Varadhan > Date: Sun, 19 Jul 2015 14:01:34 +0200 > > > On 07/18/2015 08:06 PM, Joe Perches wrote: > > > >> It seems that this code has had unaligned accesses > >> on this field even before compare_ether_addr was > >> converte

Re: [PATCH net-next] net: #ifdefify sk_classid member of struct sock

2015-07-19 Thread David Miller
From: Mathias Krause Date: Sun, 19 Jul 2015 20:17:41 +0200 > The sk_classid member is only required when CONFIG_CGROUP_NET_CLASSID is > enabled. #ifdefify it to reduce the size of struct sock on 32 bit > systems, at least. > > Signed-off-by: Mathias Krause Are you sure NFT_META_CGROUP cannot e

Re: [PATCH v3] jhash: Deinline jhash and jhash2

2015-07-19 Thread David Miller
From: Denys Vlasenko Date: Sun, 19 Jul 2015 17:36:00 +0200 > This patch deinlines jhash and jhash2. > > It also removes rhashtable_jhash2(key, length, seed) > because it was merely calling jhash2(key, length, seed). > > With this .config: http://busybox.net/~vda/kernel_config, > after deinlinin

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-19 Thread David Miller
From: Denys Vlasenko Date: Sun, 19 Jul 2015 17:14:53 +0200 > On 07/16/2015 08:17 PM, David Miller wrote: >> From: Tom Herbert >> Date: Thu, 16 Jul 2015 08:43:25 -0700 >> >>> On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko wrote: This patch deinlines jhash, jhash2 and __jhash_nwords.

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-19 Thread David Miller
From: Sowmini Varadhan Date: Sun, 19 Jul 2015 14:01:34 +0200 > On 07/18/2015 08:06 PM, Joe Perches wrote: > >> It seems that this code has had unaligned accesses >> on this field even before compare_ether_addr was >> converted to ether_addr_equal. >> >> Is sparc64 the only one that emits / ratel

[PATCH net-next] net: #ifdefify sk_classid member of struct sock

2015-07-19 Thread Mathias Krause
The sk_classid member is only required when CONFIG_CGROUP_NET_CLASSID is enabled. #ifdefify it to reduce the size of struct sock on 32 bit systems, at least. Signed-off-by: Mathias Krause --- include/net/sock.h |2 ++ net/netfilter/nft_meta.c |2 ++ 2 files changed, 4 insertions(+)

[PATCH v3] jhash: Deinline jhash and jhash2

2015-07-19 Thread Denys Vlasenko
This patch deinlines jhash and jhash2. It also removes rhashtable_jhash2(key, length, seed) because it was merely calling jhash2(key, length, seed). With this .config: http://busybox.net/~vda/kernel_config, after deinlining these functions have sizes and callsite counts as follows: jhash: 297 by

Re: [PATCH v2] jhash: Deinline jhash, jhash2 and __jhash_nwords

2015-07-19 Thread Denys Vlasenko
On 07/16/2015 08:17 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 16 Jul 2015 08:43:25 -0700 > >> On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko wrote: >>> This patch deinlines jhash, jhash2 and __jhash_nwords. >>> >>> It also removes rhashtable_jhash2(key, length, seed) >>> because

RE: [PATCH 1/2] bnx2x:Fix error handling in the function bnxc2x_dbcx_set_params

2015-07-19 Thread Yuval Mintz
> I am used to sending out one patch per each fix like this for each function. > If you don't like me doing this I don't when sending patches for your > subsystem(s). I think that would be preferable. > In addition would something like this fix your complains about not fixing > error > handling

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-19 Thread Sowmini Varadhan
On 07/18/2015 08:06 PM, Joe Perches wrote: It seems that this code has had unaligned accesses on this field even before compare_ether_addr was converted to ether_addr_equal. Is sparc64 the only one that emits / ratelimits that unaligned access message? I looked a little, but I didn't find a fi

Re: [PATCH v2 -next] net: fib: use fib result when zero-length prefix aliases exist

2015-07-19 Thread Julian Anastasov
Hello, On Sat, 18 Jul 2015, Florian Westphal wrote: > Julian Anastasov wrote: > > > The only difference I see is that NUD_NODE is > > declared by fib_nud_is_unreach() as reachable. May be > > it is better, for example, new route in NUD_NONE state > > will be tried for a while, unti

[PATCH v2] net: mvneta: fix refilling for Rx DMA buffers

2015-07-19 Thread Simon Guinot
With the actual code, if a memory allocation error happens while refilling a Rx descriptor, then the original Rx buffer is both passed to the networking stack (in a SKB) and let in the Rx ring. This leads to various kernel oops and crashes. As a fix, this patch moves Rx descriptor refilling ahead

Re: [PATCH net-next] inet: Always increment refcount in inet_twsk_schedule

2015-07-19 Thread Eric Dumazet
On Sun, 2015-07-19 at 03:31 +, subas...@codeaurora.org wrote: > I am seeing an issue with the reference count of time wait sockets which > leads to freeing of active timer object. This occurs in some data stress > test setups, so I am unable to determine the exact step when it occured. > Howeve

RE: Re : Re :

2015-07-19 Thread Kimberly Barnes
I have a biz proposal if you are interested contact me: mrpatrickchan...@yahoo.com.hk From: Kimberly Barnes Sent: Sunday, July 19, 2015 3:27 AM To: Kimberly Barnes Cc: Kimberly Barnes Subject: Re : Re : I have a biz proposal if you are interested contact

[PATCH] net: vnet: relocate netlink code section comment

2015-07-19 Thread Baruch Siach
The veth_setup() routine and the VETH_FEATURES macro are also part of the netlink interface (referenced from struct rtnl_link_ops). Include them under the netlink code section comment. Signed-off-by: Baruch Siach --- drivers/net/veth.c | 8 1 file changed, 4 insertions(+), 4 deletions(-