Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-18 Thread Julian Anastasov
Hello, On Thu, 18 Jun 2015, Roopa Prabhu wrote: > @@ -366,6 +371,7 @@ static inline size_t fib_nlmsg_size(struct fib_info *fi) > payload += nla_total_size((RTAX_MAX * nla_total_size(4))); > > if (fi->fib_nhs) { > + size_t nh_encapsize = 0; Var not in #i

Re: [PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs().

2015-06-18 Thread Eric Dumazet
On Thu, 2015-06-18 at 20:40 +0900, Hiroaki Shimoda wrote: > inet_diag_dump_reqs() is called from inet_diag_dump_icsk() with BH > disabled. So no need to disable BH in inet_diag_dump_reqs(). > > Signed-off-by: Hiroaki Shimoda > --- > net/ipv4/inet_diag.c | 4 ++-- > 1 file changed, 2 insertions(+

Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-18 Thread Eric Dumazet
On Tue, 2015-06-16 at 22:56 +0300, Julian Anastasov wrote: > The lockless lookups can return entry that is unlinked. > Sometimes they get reference before last neigh_cleanup_and_release, > sometimes they do not need reference. Later, any > modification attempts may result in the following problems:

[PATCH net-next RFC v2 3/3] mpls: support for ip tunnels

2015-06-18 Thread Roopa Prabhu
From: Roopa Prabhu Support ip mpls tunnels using the new lwt infrastructure. Signed-off-by: Roopa Prabhu --- include/linux/mpls_iptunnel.h |6 ++ include/net/mpls_iptunnel.h| 29 + include/uapi/linux/mpls_iptunnel.h | 26 + net/mpls/Kconfig |5

[PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-18 Thread Roopa Prabhu
From: Roopa Prabhu Introduces two netlink attributes RTA_ENCAP_TYPE and RTA_ENCAP to support attaching encap information to ipv4 routes. RTA_ENCAP is a nested attribute as suggested by Thomas (and also as Robert had it in his series). RTA_ENCAP netlink policy is declared by the light weight tunn

[PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-18 Thread Roopa Prabhu
From: Roopa Prabhu provides ops to parse, build and output encaped packets for drivers that want to attach tunnel encap information to routes. Signed-off-by: Roopa Prabhu --- include/linux/lwtunnel.h |6 ++ include/net/lwtunnel.h| 84 + include/uapi/linux

[PATCH net-next RFC v2 0/3] light weight tunnel infrastructure and driver

2015-06-18 Thread Roopa Prabhu
From: Roopa Prabhu This series implements infrastructure for light weight tunnels to support mpls label edge routers (ie mpls ip tunnels). As previously discussed having netdevices will not scale. Hence this series introduces new RTA_ENCAP* attributes to attach encap information with routes (fol

RE: [PATCH 00/22] FUJITSU Extended Socket network device driver

2015-06-18 Thread Izumi, Taku
Thank you for reviewing. > As Alex mentioned earlier, I suspect this is more appropriate for drivers/net. > If David objects, we can consider for platform/drivers/x86. OK, I'll migrate the code from drivers/platform/x86 to drivers/net and also incorporate comments. I'm going to resend one soo

[PATCH 1/1] ixgbe: use kzalloc for allocating one thing

2015-06-18 Thread Maninder Singh
Use kzalloc rather than kcalloc(1.. The semantic patch that makes this change is as follows: // @@ @@ - kcalloc(1, + kzalloc( ...) // and removing checkpatch below CHECK: CHECK: Prefer kzalloc(sizeof(*fwd_adapter)...) over kzalloc(sizeof(struct ixgbe_fwd_adapter)...) Signed-off-by

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-18 Thread Steven Rostedt
On Thu, 18 Jun 2015 21:37:02 -0400 Jeff Layton wrote: > > Note, the box has been rebooted since I posted my last trace. > > > > Ahh pity. The port has probably changed...if you trace it again maybe > try to figure out what it's talking to before rebooting the server? I could probably re-enable

Re: [PATCH next v3] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-18 Thread Andy Gospodarek
On Thu, Jun 18, 2015 at 11:30:54AM -0700, Mahesh Bandewar wrote: > Actor and Partner details can be accessed via proc-fs, sys-fs > entries or netlink interface. These interfaces are world readable > at this moment. The earlier patch-series made the LACP communication > secure to avoid nuisance atta

[PATCH v2] fm10k: Report MAC address on driver load

2015-06-18 Thread Alexander Duyck
This change adds the MAC address to the list of values recorded on driver load. The MAC address represents the serial number of the unit and allows us to track the value should a card be replaced in a system. The log message should now be similar in output to that of ixgbe. Signed-off-by: Alexan

Re: [Intel-wired-lan] [PATCH] fm10k: Report MAC address on driver load

2015-06-18 Thread Alexander Duyck
On 06/18/2015 04:49 PM, Jeff Kirsher wrote: On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote: This change adds the MAC address to the list of values recorded on driver load. The MAC address represents the serial number of the unit and allows us to track the value should a card be replac

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-18 Thread Jeff Layton
On Thu, 18 Jun 2015 21:08:43 -0400 Steven Rostedt wrote: > On Thu, 18 Jun 2015 18:50:51 -0400 > Jeff Layton wrote: > > > The interesting bit here is that the sockets all seem to connect to port > > 55201 on the remote host, if I'm reading these traces correctly. What's > > listening on that po

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-18 Thread Steven Rostedt
On Thu, 18 Jun 2015 18:50:51 -0400 Jeff Layton wrote: > The interesting bit here is that the sockets all seem to connect to port > 55201 on the remote host, if I'm reading these traces correctly. What's > listening on that port on the server? > > This might give some helpful info: > > $ rp

Re: [PATCH v2] bpf: fix a bug in verification logic when SUB operation taken on FRAME_PTR

2015-06-18 Thread Wangnan (F)
On 2015/6/19 0:00, Alexei Starovoitov wrote: On Thu, Jun 18, 2015 at 08:31:45AM +, Wang Nan wrote: Original code has a problem, cause following code failed to pass verifier: r1 <- r10 r1 -= 8 r2 = 8 r3 = unsafe pointer call BPF_FUNC_probe_read <-- R1 type=inv expected=fp Howev

Re: [PATCH] fm10k: Report MAC address on driver load

2015-06-18 Thread Jeff Kirsher
On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote: > This change adds the MAC address to the list of values recorded on > driver > load. The MAC address represents the serial number of the unit and > allows > us to track the value should a card be replaced in a system. > > Signed-off-by: A

Re: [PATCH net-next 2/3] ipv4: L3 and L4 hash-based multipath routing

2015-06-18 Thread Alexander Duyck
On 06/17/2015 01:08 PM, Peter Nørlund wrote: This patch adds L3 and L4 hash-based multipath routing, selectable on a per-route basis with the reintroduced RTA_MP_ALGO attribute. The default is now RT_MP_ALG_L3_HASH. Signed-off-by: Peter Nørlund --- include/net/ip_fib.h | 4 ++-

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-18 Thread Jeff Layton
On Thu, 18 Jun 2015 15:49:14 -0400 Steven Rostedt wrote: > On Thu, 18 Jun 2015 15:24:52 -0400 > Trond Myklebust wrote: > > > On Wed, Jun 17, 2015 at 11:08 PM, Steven Rostedt > > wrote: > > > On Fri, 12 Jun 2015 11:50:38 -0400 > > > Steven Rostedt wrote: > > > > > >> I reverted the following

Re: [PATCH] fm10k: Report MAC address on driver load

2015-06-18 Thread Jeff Kirsher
On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote: > This change adds the MAC address to the list of values recorded on > driver > load. The MAC address represents the serial number of the unit and > allows > us to track the value should a card be replaced in a system. > > Signed-off-by: A

[PATCH] NET: ROSE: Don't dereference NULL neighbour pointer.

2015-06-18 Thread Ralf Baechle
A ROSE socket doesn't necessarily always have a neighbour pointer so check if the neighbour pointer is valid before dereferencing it. Signed-off-by: Ralf Baechle Tested-by: Bernard Pidoux Cc: sta...@vger.kernel.org #2.6.11+ diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index 8ae6030..dd3

Re: e1000e driver - hang after 4 hours of uptime - finally bisected!

2015-06-18 Thread Jeff Kirsher
On Thu, 2015-06-18 at 12:46 -0400, Valdis Kletnieks wrote: > (follow up to a report from last week - bisecting took a while as I could > only do 1 or 2 tests an evening) > > My Dell Latitude E6530 crashes with a specific kernel lockup almost > exactly 4 hours after boot if there isn't a cable conn

Re: [PATCH 00/22] FUJITSU Extended Socket network device driver

2015-06-18 Thread Darren Hart
On Thu, Jun 18, 2015 at 09:45:59AM +0900, Taku Izumi wrote: > This patchsets adds FUJITSU Extended Socket network device driver. > Extended Socket network device is a shared memory based high-speed network > interface between Extended Partitions of PRIMEQUEST 2000 E2 series. > > You can get some

[GIT] [4.2] 2nd NFC update

2015-06-18 Thread Samuel Ortiz
Hi David, This is a follow up fix for a typo that I introduced while cleaning the 1st 4.2 NFC pull request patches. The following changes since commit d0dcad8bd32a34aa85bcbd5d2033658cb3964377: NFC: nfcmrvl: set PB_BAIL_OUT at setup (2015-06-13 00:08:55 +0200) are available in the git reposito

Re: [PATCH] net: fix search limit handling in skb_find_text()

2015-06-18 Thread Pablo Neira Ayuso
On Tue, Jun 16, 2015 at 03:13:41PM +0300, Roman Khimov wrote: > В письме от 16 июня 2015 12:48:41 пользователь Pablo Neira Ayuso написал: [...] > > But if we change the existing behaviour, users may be relying on it > > and we'll get things broken for them. Someone else will come later one > > with

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-18 Thread Steven Rostedt
On Thu, 18 Jun 2015 15:24:52 -0400 Trond Myklebust wrote: > On Wed, Jun 17, 2015 at 11:08 PM, Steven Rostedt wrote: > > On Fri, 12 Jun 2015 11:50:38 -0400 > > Steven Rostedt wrote: > > > >> I reverted the following commits: > >> > >> c627d31ba0696cbd829437af2be2f2dee3546b1e > >> 9e2b9f37760e129

Re: [PATCH net-next 1/3] ipv4: Lock-less per-packet multipath

2015-06-18 Thread Alexander Duyck
On 06/17/2015 01:08 PM, Peter Nørlund wrote: The current multipath attempted to be quasi random, but in most cases it behaved just like a round robin balancing. This patch refactors the algorithm to be exactly that and in doing so, avoids the spin lock. The new design paves the way for hash-base

Re: [PATCH net-next 0/3 v5] changes to make ipv4 routing table aware of next-hop link status

2015-06-18 Thread Andy Gospodarek
On Thu, Jun 18, 2015 at 10:51:37AM -0700, Scott Feldman wrote: > On Thu, Jun 18, 2015 at 8:22 AM, Andy Gospodarek > wrote: > > This series adds the ability to have the Linux kernel track whether or > > not a particular route should be used based on the link-status of the > > interface associated w

Re: [PATCH net-next 00/43] Simplify netfilter and network namespaces (take 2)

2015-06-18 Thread Pablo Neira Ayuso
On Wed, Jun 17, 2015 at 10:09:40AM -0500, Eric W. Biederman wrote: [...] > There are a few extra cleanups in the first group of changes sprinkled > in as I noticed a few other things as I was sorting out the network > namespace computation logic. This is a rather large patchset that address many p

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-18 Thread Trond Myklebust
On Wed, Jun 17, 2015 at 11:08 PM, Steven Rostedt wrote: > On Fri, 12 Jun 2015 11:50:38 -0400 > Steven Rostedt wrote: > >> I reverted the following commits: >> >> c627d31ba0696cbd829437af2be2f2dee3546b1e >> 9e2b9f37760e129cee053cc7b6e7288acc2a7134 >> caf4ccd4e88cf2795c927834bc488c8321437586 >> >>

Re: [PATCH net-next 00/15] Simplify netfilter and network namespaces

2015-06-18 Thread Julian Anastasov
Hello, On Thu, 18 Jun 2015, Eric W. Biederman wrote: > My incremental patch for ipvs on top of everything else I have pushed > out looks like this: > > From: "Eric W. Biederman" > Date: Fri, 12 Jun 2015 18:34:12 -0500 > Subject: [PATCH] ipvs: Pass struct net down to where it is needed

Re: [PATCH net-next] x_table: align per cpu xt_counter

2015-06-18 Thread Pablo Neira Ayuso
On Wed, Jun 17, 2015 at 07:08:15PM +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > From: Eric Dumazet > > > > Let's force a 16 bytes alignment on xt_counter percpu allocations, > > so that bytes and packets sit in same cache line. > > > > xt_counter being exported to user space, we can

pull request: bluetooth-next 2015-06-18

2015-06-18 Thread Johan Hedberg
Hi Dave, Here's the final bluetooth-next pull request for 4.2. - Cleanups & fixes to 802.15.4 code and related drivers - Fix btusb driver memory leak - New USB IDs for Atheros controllers - Support for BCM4324B3 UART based Broadcom controller - Fix for Bluetooth encryption key size handling

[PATCH next v3] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-18 Thread Mahesh Bandewar
Actor and Partner details can be accessed via proc-fs, sys-fs entries or netlink interface. These interfaces are world readable at this moment. The earlier patch-series made the LACP communication secure to avoid nuisance attack from within the same L2 domain but it did not prevent "someone unprivi

Re: [PATCH next v2] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-18 Thread Mahesh Bandewar
>> >> Hmm... I would rather not send these fake attributes at all ? > > That would be my preference as well. Sorry if my lack of elaboration on > on my earlier email made this confusing. > > If there are values that should not be visible to non-root users, then > don't send them at all. Do not ju

Re: [PATCH net-next 0/3 v5] changes to make ipv4 routing table aware of next-hop link status

2015-06-18 Thread Scott Feldman
On Thu, Jun 18, 2015 at 8:22 AM, Andy Gospodarek wrote: > This series adds the ability to have the Linux kernel track whether or > not a particular route should be used based on the link-status of the > interface associated with the next-hop. > > Before this patch any link-failure on an interface

Re: [PATCH net 2/2] bridge: multicast: start querier timer when running user-space stp

2015-06-18 Thread Nikolay Aleksandrov
> On Jun 18, 2015, at 6:37 AM, Herbert Xu wrote: > > On Wed, Jun 17, 2015 at 04:28:31AM -0700, Nikolay Aleksandrov wrote: >> From: Satish Ashok >> >> When STP is running in user-space and querier is configured, the >> querier timer is not started when a port goes to forwarding state. >> >> Si

e1000e driver - hang after 4 hours of uptime - finally bisected!

2015-06-18 Thread Valdis Kletnieks
(follow up to a report from last week - bisecting took a while as I could only do 1 or 2 tests an evening) My Dell Latitude E6530 crashes with a specific kernel lockup almost exactly 4 hours after boot if there isn't a cable connected to the Ethernet port: [14508.846327] Kernel panic - not syncin

[PATCH net v2] tcp: Do not call tcp_fastopen_reset_cipher from interrupt context

2015-06-18 Thread Christoph Paasch
tcp_fastopen_reset_cipher really cannot be called from interrupt context. It allocates the tcp_fastopen_context with GFP_KERNEL and calls crypto_alloc_cipher, which allocates all kind of stuff with GFP_KERNEL. Thus, we might sleep when the key-generation is triggered by an incoming TFO cookie-requ

Re: [PATCH net-next 3/3 v5] iproute2: add support to print 'linkdown' nexthop flag

2015-06-18 Thread Scott Feldman
On Thu, Jun 18, 2015 at 8:57 AM, Andy Gospodarek wrote: > On Thu, Jun 18, 2015 at 08:43:08AM -0700, Scott Feldman wrote: >> On Thu, Jun 18, 2015 at 8:22 AM, Andy Gospodarek >> wrote: >> > Signed-off-by: Andy Gospodaerk >> > Signed-off-by: Dinesh Dutt >> > >> > --- >> > ip/iproute.c | 4 >>

Re: [PATCH v2] bpf: fix a bug in verification logic when SUB operation taken on FRAME_PTR

2015-06-18 Thread Alexei Starovoitov
On Thu, Jun 18, 2015 at 08:31:45AM +, Wang Nan wrote: > Original code has a problem, cause following code failed to pass verifier: > > r1 <- r10 > r1 -= 8 > r2 = 8 > r3 = unsafe pointer > call BPF_FUNC_probe_read <-- R1 type=inv expected=fp > > However, by replacing 'r1 -= 8' to 'r1 +=

Re: [PATCH net-next 3/3 v5] iproute2: add support to print 'linkdown' nexthop flag

2015-06-18 Thread Andy Gospodarek
On Thu, Jun 18, 2015 at 08:43:08AM -0700, Scott Feldman wrote: > On Thu, Jun 18, 2015 at 8:22 AM, Andy Gospodarek > wrote: > > Signed-off-by: Andy Gospodaerk > > Signed-off-by: Dinesh Dutt > > > > --- > > ip/iproute.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/ip/iproute

[PATCH] mvneta: add forgotten initialization of autonegotiation bits

2015-06-18 Thread Stas Sergeev
The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state signaling") changed mvneta_adjust_link() so that it does not clear the auto-negotiation bits in MVNETA_GMAC_AUTONEG_CONFIG register. This was necessary for auto-negotiation mode to work. Unfortunately I haven't checked if t

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Michal Hocko
On Thu 18-06-15 17:22:40, Vlastimil Babka wrote: > On 06/18/2015 04:43 PM, Michal Hocko wrote: > >On Thu 18-06-15 07:35:53, Eric Dumazet wrote: > >>On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko wrote: > >> > >>>Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the > >>>_current_ i

Re: [PATCH net] Revert "tcp: switch tcp_fastopen key generation to net_get_random_once"

2015-06-18 Thread Christoph Paasch
On 18/06/15 - 04:14:13, Eric Dumazet wrote: > On Thu, 2015-06-18 at 11:32 +0200, Hannes Frederic Sowa wrote: > > > There does not seem to be a better way to handle this. We could try > > > to make the call to kmalloc and crypto_alloc_cipher during bootup, and > > > then generate the random value on

Re: [PATCH net-next 3/3 v5] iproute2: add support to print 'linkdown' nexthop flag

2015-06-18 Thread Scott Feldman
On Thu, Jun 18, 2015 at 8:22 AM, Andy Gospodarek wrote: > Signed-off-by: Andy Gospodaerk > Signed-off-by: Dinesh Dutt > > --- > ip/iproute.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/ip/iproute.c b/ip/iproute.c > index 3795baf..3369c49 100644 > --- a/ip/iproute.c > +++ b/ip/i

Re: [PATCH v2 0/4] net/macb: add sama5d2 support

2015-06-18 Thread Alexandre Belloni
On 18/06/2015 at 16:27:19 +0200, Nicolas Ferre wrote : > Hi, > > This series is basically the support for another flavor of the GEM IP > configuration. It ended up being a series because of some little fixes made to > the binding documentation before adding the new compatibility string. > > Bye,

[PATCH net-next 1/3 v5] net: track link-status of ipv4 nexthops

2015-06-18 Thread Andy Gospodarek
Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are reachable via an interface where carrier is off. No action is taken, but additional flags are passed to userspace to indicate carrier status. This also includes a cleanup to fib_disable_ip to more clearly indicate what event made

[PATCH net-next 2/3 v5] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-18 Thread Andy Gospodarek
This feature is only enabled with the new per-interface or ipv4 global sysctls called 'ignore_routes_with_linkdown'. net.ipv4.conf.all.ignore_routes_with_linkdown = 0 net.ipv4.conf.default.ignore_routes_with_linkdown = 0 net.ipv4.conf.lo.ignore_routes_with_linkdown = 0 ... When the above sysctls

[PATCH net-next 3/3 v5] iproute2: add support to print 'linkdown' nexthop flag

2015-06-18 Thread Andy Gospodarek
Signed-off-by: Andy Gospodaerk Signed-off-by: Dinesh Dutt --- ip/iproute.c | 4 1 file changed, 4 insertions(+) diff --git a/ip/iproute.c b/ip/iproute.c index 3795baf..3369c49 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -451,6 +451,8 @@ int print_route(const struct sockaddr_nl *who, s

[PATCH net-next 0/3 v5] changes to make ipv4 routing table aware of next-hop link status

2015-06-18 Thread Andy Gospodarek
This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving as a gateway for some systems could result in tho

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Vlastimil Babka
On 06/18/2015 04:43 PM, Michal Hocko wrote: On Thu 18-06-15 07:35:53, Eric Dumazet wrote: On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko wrote: Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the _current_ implementation of the allocator has this nasty and very subtle side e

Re: [PATCH net-next 1/3 v4] net: track link-status of ipv4 nexthops

2015-06-18 Thread Andy Gospodarek
On Thu, Jun 18, 2015 at 03:26:30AM -0700, David Miller wrote: > From: Andy Gospodarek > Date: Mon, 15 Jun 2015 12:33:19 -0400 > > > @@ -1107,9 +1107,10 @@ static int fib_netdev_event(struct notifier_block > > *this, unsigned long event, vo > > struct net_device *dev = netdev_notifier_info_to

Re: [PATCH net-next 00/15] Simplify netfilter and network namespaces

2015-06-18 Thread Eric W. Biederman
Cc' list trimmed as this is not longer about the original patch submission. Julian Anastasov writes: > Hello, > > On Wed, 17 Jun 2015, Eric W. Biederman wrote: > >> p.s. I do have my patch that I can toss in your direction if you are >> interested. > > Of course... I'll be able to

Re: [PATCH next v2] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-18 Thread Andy Gospodarek
On Thu, Jun 18, 2015 at 04:17:36AM -0700, Eric Dumazet wrote: > On Wed, 2015-06-17 at 17:59 -0700, Mahesh Bandewar wrote: > > Actor and Partner details can be accessed via proc-fs, sys-fs > > entries or netlink interface. These interfaces are world readable > > at this moment. The earlier patch-ser

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Michal Hocko
On Thu 18-06-15 07:35:53, Eric Dumazet wrote: > On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko wrote: > > > Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the > > _current_ implementation of the allocator has this nasty and very subtle > > side effect but that doesn't mean it s

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Eric Dumazet
On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko wrote: > Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the > _current_ implementation of the allocator has this nasty and very subtle > side effect but that doesn't mean it should be abused outside of the mm > proper. Why shouldn'

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Michal Hocko
On Wed 17-06-15 16:02:59, David Rientjes wrote: > On Fri, 12 Jun 2015, Vlastimil Babka wrote: > > > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > > index 3cfff2a..41ec022 100644 > > > --- a/net/core/skbuff.c > > > +++ b/net/core/skbuff.c > > > @@ -4398,7 +4398,7 @@ struct sk_buff *alloc

[PATCH v2 3/4] net/macb: bindings doc: add sama5d2 compatibility sting

2015-06-18 Thread Nicolas Ferre
Add sama5d2 to the biding documentation for this use of the GEM IP. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt

[PATCH v2 4/4] net/macb: add config for Atmel sama5d2 SoCs

2015-06-18 Thread Nicolas Ferre
From: Cyrille Pitchen Add the compatible string for Atmel sama5d2 SoC family as the configuration options differ from other instances of the GEM. Signed-off-by: Cyrille Pitchen Signed-off-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb.c | 8 1 file changed, 8 insertions(+)

[PATCH v2 2/4] net/macb: bindings doc/trivial: fix sama5d4 comment

2015-06-18 Thread Nicolas Ferre
On sama5d4, we only have a GEM IP that is configured to do 10/100 Mbits. So the use of "Gigabit" can be confusing. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/net/macb.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[PATCH v2 1/4] net/macb: bindings doc: fix compatibility string

2015-06-18 Thread Nicolas Ferre
In the driver and the DT bindings we use the "atmel" prefix. Fix it in the binding documentation. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/net/macb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/macb.txt

[PATCH v2 0/4] net/macb: add sama5d2 support

2015-06-18 Thread Nicolas Ferre
Hi, This series is basically the support for another flavor of the GEM IP configuration. It ended up being a series because of some little fixes made to the binding documentation before adding the new compatibility string. Bye, v2: - fix bindings - add sama5d2 compatibility string to the bin

Re: [PATCH] net/macb: add config for Atmel sama5d2 SoCs

2015-06-18 Thread Nicolas Ferre
Le 18/06/2015 15:30, Alexandre Belloni a écrit : > On 18/06/2015 at 12:18:19 +0200, Nicolas Ferre wrote : >> From: Cyrille Pitchen >> >> Add the compatible string for Atmel sama5d2 SoC family as the configuration >> options differ from other instances of the GEM. >> >> Signed-off-by: Cyrille Pitch

Re: [RFC PATCH net-next v2 2/5] net: add phys ID compare helper to test if two IDs are the same

2015-06-18 Thread Sergei Shtylyov
Hello. On 6/18/2015 12:53 AM, sfel...@gmail.com wrote: From: Scott Feldman Signed-off-by: Scott Feldman --- include/linux/netdevice.h |7 +++ net/switchdev/switchdev.c |8 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/include/linux/netdevice.h b/

Re: [PATCH 12/22] fjes: net_device_ops.ndo_get_stats64

2015-06-18 Thread Sergei Shtylyov
Hello. On 6/18/2015 3:49 AM, Taku Izumi wrote: This patch adds net_device_ops.ndo_get_stats64 callback. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drive

Re: [PATCH 14/22] fjes: net_device_ops.ndo_tx_timeout

2015-06-18 Thread Sergei Shtylyov
Hello. On 6/18/2015 3:49 AM, Taku Izumi wrote: This patch adds net_device_ops.ndo_tx_timeout callback. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platf

Re: [PATCH 20/22] fjes: epstop_task

2015-06-18 Thread Sergei Shtylyov
Hello. On 6/18/2015 3:49 AM, Taku Izumi wrote: This patch adds epstop_task. This task is used to process other receiver's cancellation request. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 34 ++ drivers/platform/x86/fjes/fjes_hw.h

Re: [PATCH] net/macb: add config for Atmel sama5d2 SoCs

2015-06-18 Thread Alexandre Belloni
On 18/06/2015 at 12:18:19 +0200, Nicolas Ferre wrote : > From: Cyrille Pitchen > > Add the compatible string for Atmel sama5d2 SoC family as the configuration > options differ from other instances of the GEM. > > Signed-off-by: Cyrille Pitchen > Signed-off-by: Nicolas Ferre > --- > drivers/ne

[PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs().

2015-06-18 Thread Hiroaki Shimoda
inet_diag_dump_reqs() is called from inet_diag_dump_icsk() with BH disabled. So no need to disable BH in inet_diag_dump_reqs(). Signed-off-by: Hiroaki Shimoda --- net/ipv4/inet_diag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_dia

Re: [PATCH ipv6 0/1] ipv6: addrconf: routes are not deleted if last ipv6 address is removed

2015-06-18 Thread Hannes Frederic Sowa
On Thu, 2015-06-18 at 14:59 +0530, Mazhar Rana wrote: > Hi, > > After 'commit 876fd05ddbae03166e7037fca957b55bb3be6594 > ("ipv6: don't disable interface if last ipv6 address is removed")' > it is not clearing ipv6 interface configurations(routes, neighbours, > etc) when last ipv6 address of interf

Re: [PATCH next v2] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-18 Thread Eric Dumazet
On Wed, 2015-06-17 at 17:59 -0700, Mahesh Bandewar wrote: > Actor and Partner details can be accessed via proc-fs, sys-fs > entries or netlink interface. These interfaces are world readable > at this moment. The earlier patch-series made the LACP communication > secure to avoid nuisance attack from

Re: [PATCH net] Revert "tcp: switch tcp_fastopen key generation to net_get_random_once"

2015-06-18 Thread Eric Dumazet
On Thu, 2015-06-18 at 11:32 +0200, Hannes Frederic Sowa wrote: > Hello Christoph, > > There does not seem to be a better way to handle this. We could try > > to make the call to kmalloc and crypto_alloc_cipher during bootup, and > > then generate the random value only on-the-fly (when the first TF

Re: [PATCH RFC] tun, macvtap: higher order allocations for skbs

2015-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 12:54:44PM +0200, Christian Borntraeger wrote: > Am 18.06.2015 um 12:20 schrieb Michael S. Tsirkin: > > Needs more testing. Anyone see anything wrong with this? > Can you explain the motivation? > FWIW, basic networking between two guest over macvtap still > seems to work o

Re: [PATCH net v2] packet: avoid out of bounds read in round robin fanout

2015-06-18 Thread Eric Dumazet
On Wed, 2015-06-17 at 15:59 -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > PACKET_FANOUT_LB computes f->rr_cur such that it is modulo > f->num_members. It returns the old value unconditionally, but > f->num_members may have changed since the last store. Ensure > that the return value

Re: [PATCH RFC] tun, macvtap: higher order allocations for skbs

2015-06-18 Thread Christian Borntraeger
Am 18.06.2015 um 12:20 schrieb Michael S. Tsirkin: > Needs more testing. Anyone see anything wrong with this? Can you explain the motivation? FWIW, basic networking between two guest over macvtap still seems to work on s390 so I dont see any obvious regression. Christian > > Signed-off-by: Mich

Administrador do sistema

2015-06-18 Thread ADMIN
Sua caixa de correio excedeu o limite de armazenamento, que é de 20 GB como definido pelo administrador, você está atualmente em execução no 20,9 GB, você pode não ser capaz de enviar ou receber novas mensagens até que você re-validar sua caixa de correio. Para re-validar sua caixa de co

Re: [net-next v2 00/17][pull request] Intel Wired LAN Driver Updates 2015-06-17

2015-06-18 Thread David Miller
From: Jeff Kirsher Date: Wed, 17 Jun 2015 05:54:47 -0700 > This series contains updates to fm10k only. > > Alex provides two fixes for the fm10k, first folds the fm10k_pull_tail() > call into fm10k_add_rx_frag(), this way the fragment does not have to be > modified after it is added to the skb.

Re: [PATCH net-next] x_table: align per cpu xt_counter

2015-06-18 Thread Pablo Neira Ayuso
On Thu, Jun 18, 2015 at 03:43:26AM -0700, David Miller wrote: > From: Eric Dumazet > Date: Mon, 15 Jun 2015 18:10:13 -0700 > > > From: Eric Dumazet > > > > Let's force a 16 bytes alignment on xt_counter percpu allocations, > > so that bytes and packets sit in same cache line. > > > > xt_counte

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-18 Thread Haggai Eran
On 17/06/2015 20:06, Jason Gunthorpe wrote: > On Tue, Jun 16, 2015 at 02:25:07PM +0300, Haggai Eran wrote: >> Regarding APM, currently the ib_cm code always sends the GMP to the >> primary path anyway, right? And in any case, one would expect the >> primary path's GID to have a valid net_device an

Re: [PATCH net-next] x_table: align per cpu xt_counter

2015-06-18 Thread David Miller
From: Eric Dumazet Date: Mon, 15 Jun 2015 18:10:13 -0700 > From: Eric Dumazet > > Let's force a 16 bytes alignment on xt_counter percpu allocations, > so that bytes and packets sit in same cache line. > > xt_counter being exported to user space, we cannot add __align(16) on > the structure its

[PATCH RFC] tun, macvtap: higher order allocations for skbs

2015-06-18 Thread Michael S. Tsirkin
Needs more testing. Anyone see anything wrong with this? Signed-off-by: Michael S. Tsirkin --- drivers/net/macvtap.c | 2 +- drivers/net/tun.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 928f3f4..80e87e4 100644 --

Re: [PATCH] net: stmmac: dwmac-rk: Don't add function name in info or err messages

2015-06-18 Thread David Miller
From: Romain Perier Date: Mon, 15 Jun 2015 17:44:19 + > These kind of informations are only useful for debugging and should not be > displayed in normal modules message. > > Signed-off-by: Romain Perier Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH net] bridge: fix br_stp_set_bridge_priority race conditions

2015-06-18 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 15 Jun 2015 20:28:51 +0300 > After the ->set() spinlocks were removed br_stp_set_bridge_priority > was left running without any protection when used via sysfs. It can > race with port add/del and could result in use-after-free cases and > corrupted lists. Test

[PATCH] net/macb: add config for Atmel sama5d2 SoCs

2015-06-18 Thread Nicolas Ferre
From: Cyrille Pitchen Add the compatible string for Atmel sama5d2 SoC family as the configuration options differ from other instances of the GEM. Signed-off-by: Cyrille Pitchen Signed-off-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb.c | 8 1 file changed, 8 insertions(+)

Re: [PATCH net-next 2/3 v4] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-18 Thread David Miller
From: Andy Gospodarek Date: Mon, 15 Jun 2015 12:33:20 -0400 > @@ -1035,12 +1036,18 @@ int fib_dump_info(struct sk_buff *skb, u32 portid, > u32 seq, int event, > nla_put_in_addr(skb, RTA_PREFSRC, fi->fib_prefsrc)) > goto nla_put_failure; > if (fi->fib_nhs == 1) { > +

Re: [PATCH net-next 1/3 v4] net: track link-status of ipv4 nexthops

2015-06-18 Thread David Miller
From: Andy Gospodarek Date: Mon, 15 Jun 2015 12:33:19 -0400 > @@ -1107,9 +1107,10 @@ static int fib_netdev_event(struct notifier_block > *this, unsigned long event, vo > struct net_device *dev = netdev_notifier_info_to_dev(ptr); > struct in_device *in_dev; > struct net *net = d

Re: [PATCH] net: fix search limit handling in skb_find_text()

2015-06-18 Thread David Miller
From: Roman I Khimov Date: Mon, 15 Jun 2015 12:11:58 +0300 > Suppose that we're trying to use an xt_string netfilter module to match a > string in a specially crafted packet that has "a nice string" starting at > offset 28. > > It could be done in iptables like this: > > -A some_chain -m string

Re: [PATCH net] Revert "tcp: switch tcp_fastopen key generation to net_get_random_once"

2015-06-18 Thread Hannes Frederic Sowa
Hello Christoph, On Wed, 2015-06-17 at 17:28 -0700, Christoph Paasch wrote: > This reverts commit 222e83d2e0aecb6a5e8d42b1a8d51332a1eba960. > > tcp_fastopen_reset_cipher really cannot be called from interrupt > context. It allocates the tcp_fastopen_context with GFP_KERNEL and > calls crypto_allo

[PATCH ipv6 1/1] ipv6: addrconf: do addrconf_ifdown when last ipv6 address is removed

2015-06-18 Thread Mazhar Rana
After 'commit 876fd05ddbae03166e7037fca957b55bb3be6594 ("ipv6: don't disable interface if last ipv6 address is removed")' it is not clearing ipv6 interface configurations(routes, neighbours, etc) when last ipv6 address of interface is removed. This patch will call addrconf_ifdown when last ipv6 ad

[PATCH ipv6 0/1] ipv6: addrconf: routes are not deleted if last ipv6 address is removed

2015-06-18 Thread Mazhar Rana
Hi, After 'commit 876fd05ddbae03166e7037fca957b55bb3be6594 ("ipv6: don't disable interface if last ipv6 address is removed")' it is not clearing ipv6 interface configurations(routes, neighbours, etc) when last ipv6 address of interface is removed. This is now creating functionality issue with bel

Re: [PATCH net-next] switchdev: fdb filter_dev is always NULL for self (device), so remove check

2015-06-18 Thread Jiri Pirko
Thu, Jun 18, 2015 at 01:08:31AM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Remove the filter_dev check when dumping fdb entries, otherwise dump >returns empty list. filter_dev is always passed as NULL when dumping fdbs >on SELF. We want the fdbs installed on the device to be listed i

[PATCH] net/phy: Add support for Realtek RTL8211F

2015-06-18 Thread Shengzhou Liu
RTL8211F has different register definitions from RTL8211E. Specially it needs to enable TXDLY in case of RGMII. Signed-off-by: Shengzhou Liu --- drivers/net/phy/realtek.c | 68 ++- 1 file changed, 67 insertions(+), 1 deletion(-) diff --git a/drivers/n

Re: [PATCH 08/11] IB/cma: Add net_dev and private data checks to RDMA CM

2015-06-18 Thread Haggai Eran
On 17/06/2015 20:18, Jason Gunthorpe wrote: > On Tue, Jun 16, 2015 at 08:26:26AM +0300, Haggai Eran wrote: >> On 15/06/2015 20:08, Jason Gunthorpe wrote: >>> On Mon, Jun 15, 2015 at 11:47:13AM +0300, Haggai Eran wrote: Instead of relying on a the ib_cm module to check an incoming CM request's

[PATCH v2] bpf: fix a bug in verification logic when SUB operation taken on FRAME_PTR

2015-06-18 Thread Wang Nan
Original code has a problem, cause following code failed to pass verifier: r1 <- r10 r1 -= 8 r2 = 8 r3 = unsafe pointer call BPF_FUNC_probe_read <-- R1 type=inv expected=fp However, by replacing 'r1 -= 8' to 'r1 += -8' the above program can be loaded successfully. This is because the verif

[PATCH] bpf: fix a bug in verification logic when SUB operation taken on FRAME_PTR

2015-06-18 Thread Wang Nan
Original code has a problem, cause following code failed to pass verifier: r1 <- r10 r1 -= 8 r2 = 8 r3 = unsafe pointer call BPF_FUNC_probe_read <-- R1 type=inv expected=fp However, by replacing 'r1 -= 8' to 'r1 += -8' the above program can be loaded successfully. This is because the verif

Re: [PATCH v2 net-next 0/3] bpf: share helpers between tracing and networking

2015-06-18 Thread Daniel Borkmann
On 06/16/2015 07:10 PM, Alexei Starovoitov wrote: ... Ideally we would allow a blend of tracing and networking programs, then the best solution would be one or two stable tracepoints in networking stack where skb is visible and receiving/transmitting task is also visible, then skb->len and task->

Re: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta"

2015-06-18 Thread Thomas Petazzoni
Dear Jason Cooper, On Wed, 17 Jun 2015 21:39:26 +, Jason Cooper wrote: > Odd, I'd use that as an example of the process working. ;-) we have > everyone using 'armada-370-neta' for a given block. We discovered that > the original IP block (on the 370s) had a limitation (no hw checksum > for