[PATCH net-next v5 02/11] ipv6: Remove external dependency on rt6i_dst and rt6i_src

2015-05-22 Thread Martin KaFai Lau
This patch removes the assumptions that the returned rt is always a RTF_CACHE entry with the rt6i_dst and rt6i_src containing the destination and source address. The dst and src can be recovered from the calling site. We may consider to rename (rt6i_dst, rt6i_src) to (rt6i_key_dst, rt6i_key_src)

[PATCH net-next v5 08/11] ipv6: Create RTF_CACHE clone when FLOWI_FLAG_KNOWN_NH is set

2015-05-22 Thread Martin KaFai Lau
This patch always creates RTF_CACHE clone with DST_NOCACHE when FLOWI_FLAG_KNOWN_NH is set so that the rt6i_dst is set to the fl6->daddr. Signed-off-by: Martin KaFai Lau Acked-by: Julian Anastasov Tested-by: Julian Anastasov Cc: Hannes Frederic Sowa Cc: Steffen Klassert --- include/net/ip6_f

[PATCH net-next v5 00/11] ipv6: Only create RTF_CACHE route after encountering pmtu exception

2015-05-22 Thread Martin KaFai Lau
v4 -> v5: - Patch 1 is new. Clean up the ipv6_select_ident() and ip6_fragment(). - Further simplify the newly added rt6_get_pcpu_route(). If there is a 'prev' after cmpxchg, return prev instead of the newly created percpu clone. v3 -> v4: - Patch 8 is new. It keeps track of the DST_NOCACHE r

[PATCH net-next v5 04/11] ipv6: Combine rt6_alloc_cow and rt6_alloc_clone

2015-05-22 Thread Martin KaFai Lau
A prep work for creating RTF_CACHE on exception only. After this patch, the same condition (rt->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)) is checked twice. This redundancy will be removed in the later patch. Signed-off-by: Martin KaFai Lau Cc: Hannes Frederic Sowa Cc: Steffen Klassert Cc: Ju

[PATCH net-next v5 07/11] ipv6: Set FLOWI_FLAG_KNOWN_NH at flowi6_flags

2015-05-22 Thread Martin KaFai Lau
The neighbor look-up used to depend on the rt6i_gateway (if there is a gateway) or the rt6i_dst (if it is a RTF_CACHE clone) as the nexthop address. Note that rt6i_dst is set to fl6->daddr for the RTF_CACHE clone where fl6->daddr is the one used to do the route look-up. Now, we only create RTF_CA

[PATCH net-next v5 11/11] ipv6: Create percpu rt6_info

2015-05-22 Thread Martin KaFai Lau
After the patch 'ipv6: Only create RTF_CACHE routes after encountering pmtu exception', we need to compensate the performance hit (bouncing dst->__refcnt). Signed-off-by: Martin KaFai Lau Cc: Hannes Frederic Sowa Cc: Steffen Klassert Cc: Julian Anastasov --- include/net/ip6_fib.h |

[PATCH net-next v5 05/11] ipv6: Only create RTF_CACHE routes after encountering pmtu exception

2015-05-22 Thread Martin KaFai Lau
This patch creates a RTF_CACHE routes only after encountering a pmtu exception. After ip6_rt_update_pmtu() has inserted the RTF_CACHE route to the fib6 tree, the rt->rt6i_node->fn_sernum is bumped which will fail the ip6_dst_check() and trigger a relookup. Signed-off-by: Martin KaFai Lau Cc: Han

[PATCH net-next v5 03/11] ipv6: Remove external dependency on rt6i_gateway and RTF_ANYCAST

2015-05-22 Thread Martin KaFai Lau
When creating a RTF_CACHE route, RTF_ANYCAST is set based on rt6i_dst. Also, rt6i_gateway is always set to the nexthop while the nexthop could be a gateway or the rt6i_dst.addr. After removing the rt6i_dst and rt6i_src dependency in the last patch, we also need to stop the caller from depending on

[PATCH net-next v5 09/11] ipv6: Keep track of DST_NOCACHE routes in case of iface down/unregister

2015-05-22 Thread Martin KaFai Lau
This patch keeps track of the DST_NOCACHE routes in a list and replaces its dev with loopback during the iface down/unregister event. Signed-off-by: Martin KaFai Lau Cc: Hannes Frederic Sowa Cc: Steffen Klassert Cc: Julian Anastasov --- include/net/ip6_fib.h | 3 ++ net/ipv6/route.c | 7

[PATCH net-next v5 10/11] ipv6: Break up ip6_rt_copy()

2015-05-22 Thread Martin KaFai Lau
This patch breaks up ip6_rt_copy() into ip6_rt_copy_init() and ip6_rt_cache_alloc(). In the later patch, we need to create a percpu rt6_info copy. Hence, refactor the common rt6_info init codes to ip6_rt_copy_init(). Signed-off-by: Martin KaFai Lau Cc: Hannes Frederic Sowa Cc: Steffen Klassert

[PATCH net-next v5 06/11] ipv6: Add rt6_get_cookie() function

2015-05-22 Thread Martin KaFai Lau
Instead of doing the rt6->rt6i_node check whenever we need to get the route's cookie. Refactor it into rt6_get_cookie(). It is a prep work to handle FLOWI_FLAG_KNOWN_NH and also percpu rt6_info later. Signed-off-by: Martin KaFai Lau Cc: Hannes Frederic Sowa Cc: Steffen Klassert Cc: Julian Anas

[PATCH net-next v5 01/11] ipv6: Clean up ipv6_select_ident() and ip6_fragment()

2015-05-22 Thread Martin KaFai Lau
This patch changes the ipv6_select_ident() signature to return a fragment id instead of taking a whole frag_hdr as a param to only set the frag_hdr->identification. It also cleans up ip6_fragment() to obtain the fragment id at the beginning instead of using multiple "if" later to check fragment id

[PATCH net-next v5 0/2] Adding support for Cavium ThunderX network controller

2015-05-22 Thread Aleksey Makarov
This patchset adds support for the Cavium ThunderX network controller. changes in v5: * __packed were removed. now we rely on C language ABI * nic_dbg() -> netdev_dbg() * fixes for a typo, constant spelling and using BIT_ULL * use print_hex_dump() * unnecessary conditions in a long if() chai

[PATCH] net: stmmac: create one debugfs dir per net-device

2015-05-22 Thread Mathieu Olivari
stmmac DebugFS entries are currently global to the driver. As a result, having more than one stmmac device in the system creates the following error: * ERROR stmmaceth, debugfs create directory failed * stmmac_hw_setup: failed debugFS registration This also results in being able to access the debu

[PATCH net-next v5 1/2] pci: Add Cavium PCI vendor id

2015-05-22 Thread Aleksey Makarov
From: Sunil Goutham This vendor id will be used by network (vNIC), USB (xHCI), SATA (AHCI), GPIO, I2C, MMC and maybe other drivers for ThunderX SoC. Acked-by: Bjorn Helgaas Signed-off-by: Sunil Goutham Signed-off-by: Aleksey Makarov --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 inser

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Suravee Suthikulanit
On 5/22/2015 8:25 PM, Rafael J. Wysocki wrote: On Friday, May 22, 2015 07:15:17 PM Suravee Suthikulanit wrote: On 5/22/2015 6:05 PM, Rafael J. Wysocki wrote: On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: Not sure if this went out earlier. So I am resending. On 5/22/15 16:56,

[PATCHv3 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread Linus Lüssing
Network managers like netifd (used in OpenWRT for instance) try to configure interface options after creation but before setting the interface up. Unfortunately the sysfs / bridge currently only allows to configure the hash_max and multicast_router options when the bridge interface is up. But sinc

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
On Friday, May 22, 2015 07:15:17 PM Suravee Suthikulanit wrote: > On 5/22/2015 6:05 PM, Rafael J. Wysocki wrote: > > On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: > >> Not sure if this went out earlier. So I am resending. > >> > >> On 5/22/15 16:56, Rafael J. Wysocki wrote: >

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Suravee Suthikulanit
On 5/22/2015 6:05 PM, Rafael J. Wysocki wrote: On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: Not sure if this went out earlier. So I am resending. On 5/22/15 16:56, Rafael J. Wysocki wrote: diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 39c485b..b9657af 100644

Re: [PATCH net-next 1/3] cxgb4: Add support for loopback between VI of same port

2015-05-22 Thread Casey Leedom
Okay, really: I’m not arguing for module parameters. I’m agreeing with you 100%. I’m not trying to be snarky or back you into admitting that there are some times when a module parameter is needed. I’m not being sneaky, etc. I’m really just asking a mechanism question. It is, on the other han

Re: [PATCH net-next] test_bpf: add more eBPF jump torture cases

2015-05-22 Thread Alexei Starovoitov
On 5/22/15 4:10 PM, Daniel Borkmann wrote: Add two more eBPF test cases for JITs, i.e. the second one revealed a bug in the x86_64 JIT compiler, where only an int3 filled image from the allocator was emitted and later wrongly set by the compiler as the bpf_func program code since optimization pas

[PATCH v2 net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-22 Thread Neil McKee
If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions in the upcall. This Directly associates the sampled packet with the path it takes through the virtual switch. Path information currently includes mangling, encaps

[PATCH] mlx4_core: Fix fallback from MSI-X to INTx

2015-05-22 Thread Benjamin Poirier
The test in mlx4_load_one() to remove MLX4_FLAG_MSI_X expects mlx4_NOP() to fail with -EBUSY. It is also necessary to avoid the reset since the device is not fully reinitialized before calling mlx4_start_hca() a second time. Note that this will also affect mlx4_test_interrupts(), the only other us

[PATCH net-next] test_bpf: add more eBPF jump torture cases

2015-05-22 Thread Daniel Borkmann
Add two more eBPF test cases for JITs, i.e. the second one revealed a bug in the x86_64 JIT compiler, where only an int3 filled image from the allocator was emitted and later wrongly set by the compiler as the bpf_func program code since optimization pass boundary was surpassed w/o actually emittin

Re: [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs

2015-05-22 Thread Hannes Frederic Sowa
On Fri, May 22, 2015, at 21:03, David Miller wrote: > From: Florian Westphal > Date: Fri, 22 May 2015 16:32:49 +0200 > > > IP (ttl 64, id 12345, offset 0, flags [+, DF], proto UDP (17), length 1204) > > 192.168.7.1.42 > 10.23.42.2.42: UDP, length 1400 > > IP (ttl 64, id 12345, offset 1184, fl

Re: [PATCH net] x86: bpf_jit: fix compilation of large bpf programs

2015-05-22 Thread Daniel Borkmann
On 05/23/2015 12:42 AM, Alexei Starovoitov wrote: x86 has variable length encoding. x86 JIT compiler is trying to pick the shortest encoding for given bpf instruction. While doing so the jump targets are changing, so JIT is doing multiple passes over the program. Typical program needs 3 passes. S

[PATCH 1/2] ethtool: Clear the command data structure before sending requests

2015-05-22 Thread Arun Parameswaran
The 'ethtool' is not clearing the command data structure in the do_gset() & do_sset() API's while sending commands to get/set parametres. This used to work since the Kernel clears the data structure (which was a bug and is being fixed). This patch adds a 'memset' to the do_gset() & do_sset() to cl

[PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

2015-05-22 Thread Arun Parameswaran
Hi, The patch fixes 2 issues with 'ethtool' getting/setting parametres in the do_gset() do_sset() API's. I have pushed a patch to the Kernel to fix an issue in the handling of the 'ethtool' commands which got accepted. This Kernel patch was based on Linux v4.1-rc4 and is available in: https://gith

[PATCH 2/2] ethtool: Fix an issue with handling 'phyad' while updating settings

2015-05-22 Thread Arun Parameswaran
When using the 'ethtool' to set PHY1's settings, the 'ethtool' seems to do the 'get' settings with incorrect PHY ID and then apply the new settings on it. For example when using the command, to change PHY1's speed, 'ethtool -s eth0 phyad 1 speed 100', the 'ethtool' will end up querying PHY0's sett

[PATCH net] x86: bpf_jit: fix compilation of large bpf programs

2015-05-22 Thread Alexei Starovoitov
x86 has variable length encoding. x86 JIT compiler is trying to pick the shortest encoding for given bpf instruction. While doing so the jump targets are changing, so JIT is doing multiple passes over the program. Typical program needs 3 passes. Some very short programs converge with 2 passes. Larg

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: > Not sure if this went out earlier. So I am resending. > > On 5/22/15 16:56, Rafael J. Wysocki wrote: > >> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c > >> >index 39c485b..b9657af 100644 > >> >--- a/drivers/acpi/glue.c > >

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Suravee Suthikulanit
Not sure if this went out earlier. So I am resending. On 5/22/15 16:56, Rafael J. Wysocki wrote: diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c >index 39c485b..b9657af 100644 >--- a/drivers/acpi/glue.c >+++ b/drivers/acpi/glue.c >@@ -13,6 +13,7 @@ > #include > #include > #include >

Re: [PATCH net] net: phy: bcm7xxx: Fix 7425 PHY ID and flags

2015-05-22 Thread Petri Gynther
On Fri, May 22, 2015 at 2:07 PM, Florian Fainelli wrote: > While adding support for 7425 PHY in the 7xxx PHY driver, the ID that > was used was actually coming from an external PHY: a BCM5461x. Fix this > by using the proper ID for the internal 7425 PHY and set the > PHY_IS_INTERNAL flag, otherwis

[PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-22 Thread Neil McKee
If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions in the upcall. This Directly associates the sampled packet with the path it takes through the virtual switch. Path information currently includes mangling, encaps

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 11:04:39PM +0200, Stephan Mueller wrote: > > Note, gcm(aes) looks good. Only rfc4106(gcm(aes)) causes the crash. Actually it looks like the culprit hasn't been merged yet so I'll just respin the series. Anyway, this patch should fix your crash: diff --git a/crypto/ablkcip

[PATCH 0/2] crypto: Use tmpl->create when registering geniv

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 11:04:39PM +0200, Stephan Mueller wrote: > Am Freitag, 22. Mai 2015, 22:59:34 schrieb Stephan Mueller: > > Hi Stephan, > > > Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: > > > > Hi Herbert, > > > > > This patch makes use of the new AEAD interface which uses a s

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Alexander Holler
Am 22.05.2015 um 23:29 schrieb Cong Wang: On Fri, May 22, 2015 at 2:12 PM, Alexander Holler wrote: Bridge doesn't have an underlying link, so no LINK_NETNSID. LINK_NETNSID is only added when its underlying link is in a different netns. I'm using "link" similiar as interface. Maybe I've no i

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
On Wednesday, May 20, 2015 05:09:14 PM Suravee Suthikulpanit wrote: > This patch implements support for ACPI _CCA object, which is introduced in > ACPIv5.1, can be used for specifying device DMA coherency attribute. > > The parsing logic traverses device namespace to parse coherency > information,

[PATCH net-next v1 3/3] amd-xgbe: Add more netif_dbg output to the driver

2015-05-22 Thread Tom Lendacky
Change more netdev_dbg statements over to netif_dbg and add some new netif_dbg statements to the driver. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 68 ++--- 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethe

[PATCH net-next v1 2/3] amd-xgbe: Fix initial mode when auto-negotiation is disabled

2015-05-22 Thread Tom Lendacky
When the ethtool command is used to set the speed of the device while the device is down, the check to set the initial mode may fail when the device is brought up, causing failure to bring the device up. Update the code to set the initial mode based on the desired speed if auto-negotiation is disa

[PATCH net-next v1 0/3] amd-xgbe: AMD XGBE driver updates 2015-05-22

2015-05-22 Thread Tom Lendacky
The following patches are included in this driver update series: - Retrieve and set an additional hardware feature setting - Fix the initial mode/speed determination when auto-negotiation is disabled - Add additional netif_dbg support to the driver This patch series is based on net-next. ---

[PATCH net-next v1 1/3] amd-xgbe: Add setting of a missing hardware feature

2015-05-22 Thread Tom Lendacky
The device private data structure contains all the defined hardware features for the device. However one of the features is not set. Even though the feature is not currently used, set it to avoid future issues of the feature being checked thinking it has been properly set. Signed-off-by: Tom Lenda

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Alexander Holler
Am 22.05.2015 um 23:19 schrieb Eric W. Biederman: Alexander Holler writes: Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id. Me too, You need t

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 2:12 PM, Alexander Holler wrote: >> >> Bridge doesn't have an underlying link, so no LINK_NETNSID. LINK_NETNSID >> is only added when its underlying link is in a different netns. > > > I'm using "link" similiar as interface. Maybe I've no idea what the > attribute LINK:NETS

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Eric W. Biederman
Alexander Holler writes: > Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: >> >> So I am dense. I have read through the patches and I don't see where >> you tag packets from other network namespaces with a network namespace >> id. > > Me too, You need to use recvmsg, and then parse out the NE

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Alexander Holler
Am 22.05.2015 um 23:04 schrieb Cong Wang: On Fri, May 22, 2015 at 1:50 PM, Alexander Holler wrote: Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id

[PATCH net] net: phy: bcm7xxx: Fix 7425 PHY ID and flags

2015-05-22 Thread Florian Fainelli
While adding support for 7425 PHY in the 7xxx PHY driver, the ID that was used was actually coming from an external PHY: a BCM5461x. Fix this by using the proper ID for the internal 7425 PHY and set the PHY_IS_INTERNAL flag, otherwise consumers of this PHY driver would not be able to properly ident

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 1:50 PM, Alexander Holler wrote: > Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: >> >> >> So I am dense. I have read through the patches and I don't see where >> you tag packets from other network namespaces with a network namespace >> id. > > > Me too, > > I've recent

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Stephan Mueller
Am Freitag, 22. Mai 2015, 22:59:34 schrieb Stephan Mueller: Hi Stephan, > Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: > > Hi Herbert, > > > This patch makes use of the new AEAD interface which uses a single > > SG list instead of separate lists for the AD and plain text. > > Using a

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Stephan Mueller
Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, > This patch makes use of the new AEAD interface which uses a single > SG list instead of separate lists for the AD and plain text. Using an up-to date tree with the full set of patches of this patch set, I get the following oop

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Alexander Holler
Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id. Me too, I've recently written a little tool called snetmanmon (source is available at github) to m

[GIT] Networking

2015-05-22 Thread David Miller
1) Don't leak ipvs->sysctl_tbl, from Tommi Rentala. 2) Fix neighbour table entry leak in rocker driver, from Ying Xue. 3) Do not emit bonding notifications for unregistered interfaces, from Nicolas Dichtel. 4) Set ipv6 flow label properly when in TIME_WAIT state, from Florent Fourcot. 5)

Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings

2015-05-22 Thread David Miller
From: Arun Parameswaran Date: Wed, 20 May 2015 14:35:30 -0700 > When trying to configure the settings for PHY1, using commands > like 'ethtool -s eth0 phyad 1 speed 100', the 'ethtool' seems to > modify other settings apart from the speed of the PHY1, in the > above case. > > The ethtool seems t

Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-22 Thread Tom Herbert
On Fri, May 22, 2015 at 8:22 AM, Jiri Pirko wrote: > Fri, May 22, 2015 at 05:14:21PM CEST, t...@herbertland.com wrote: >>On Fri, May 22, 2015 at 1:14 AM, Jiri Pirko wrote: >>> Fri, May 22, 2015 at 02:11:44AM CEST, t...@herbertland.com wrote: In flow_dissector set the flow label in flow_keys f

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
On 05/22/2015 11:16 AM, Hannes Frederic Sowa wrote: On Fri, May 22, 2015, at 18:24, Mark Salyzyn wrote: On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: I still wonder if we need to actually recheck the condition and not simply break out of unix_stream_data_wait: We return to the unix_strea

Re: [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs

2015-05-22 Thread Florian Westphal
David Miller wrote: [ cc'd Maxime Bizon ] > From: Florian Westphal > Date: Fri, 22 May 2015 16:32:49 +0200 > > > IP (ttl 64, id 12345, offset 0, flags [+, DF], proto UDP (17), length 1204) > > 192.168.7.1.42 > 10.23.42.2.42: UDP, length 1400 > > IP (ttl 64, id 12345, offset 1184, flags [DF

[PATCH net-next 3/4] sfc: add module parameter to enable MCDI logging on new functions

2015-05-22 Thread Edward Cree
As many issues are encountered at probe time, where MCDI logging can't be enabled through the sysfs node, this change adds a module parameter 'mcdi_logging_default', which defaults to false. When set to true, newly- probed functions will have MCDI logging enabled. The setting can subsequently

[PATCH net-next 4/4] sfc: Initialise MCDI buffers to 0 on declaration.

2015-05-22 Thread Edward Cree
From: Jon Cooper Prevents possible kernel memory disclosure from MCDI logging if some fields of an MCDI request were not initialised, or if a response length is not a multiple of 32 bits. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 24 +--- drivers/ne

[PATCH net-next 2/4] sfc: add sysfs entry to control MCDI tracing

2015-05-22 Thread Edward Cree
MCDI tracing is enabled per-function with a sysfs file /sys/class/net//device/mcdi_logging Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/Kconfig | 3 ++- drivers/net/ethernet/sfc/efx.c | 49 ++-- drivers/net/ethernet/sfc/mcdi.c | 4 ++-- dri

[PATCH net-next v3 0/4] sfc: add MCDI tracing

2015-05-22 Thread Edward Cree
This patchset adds support for logging MCDI (Management-Controller-to- Driver Interface) interactions between the sfc driver and a bound device, to aid in debugging. Solarflare has a tool to decode the resulting traces and will look to open-source this if there is any external interest, but the

[PATCH net-next 1/4] sfc: add tracing of MCDI commands

2015-05-22 Thread Edward Cree
MCDI tracing is conditional on CONFIG_SFC_MCDI_LOGGING, which is enabled by default. Each MCDI command will produce a console line like sfc dom:bus:dev:fn ifname: MCDI RPC REQ: [...] where etc. are the raw MCDI payload in 32-bit hex chunks. The response will then pro

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread Vittorio G (VittGam)
Il 22.05.2015 21:05 David Miller ha scritto: From: "Vittorio G (VittGam)" Date: Fri, 22 May 2015 20:48:38 +0200 I think this should also be backported up to Linux mainline 3.10, since the original commit that introduced the bug first appeared in 3.6. Ummm, that's what "queued up for -stable"

Re: [PATCH net-next] test_bpf: Add backward jump test case

2015-05-22 Thread David Miller
From: Alexei Starovoitov Date: Fri, 22 May 2015 08:36:40 -0700 > From: Michael Holzheu > > Currently the testsuite does not have a test case with a backward jump. > The s390x JIT (kernel 4.0) had a bug in that area. > So add one new test case for this now. > > Signed-off-by: Michael Holzheu >

Re: [PATCH] bridge: fix parsing of MLDv2 reports

2015-05-22 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Fri, 22 May 2015 12:18:59 -0300 > When more than a multicast address is present in a MLDv2 report, all but > the first address is ignored, because the code breaks out of the loop if > there has not been an error adding that address. > > This has caused f

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread David Miller
From: "Vittorio G (VittGam)" Date: Fri, 22 May 2015 20:48:38 +0200 > Il 22.05.2015 20:24 David Miller ha scritto: >> Looks good, applied and queued up for -stable, thanks! > > That's great! > > I think this should also be backported up to Linux mainline 3.10, > since > the original commit that

Re: [PATCH net-next v2 0/4] sfc: add MCDI tracing

2015-05-22 Thread David Miller
From: Edward Cree Date: Fri, 22 May 2015 15:49:46 +0100 > On 21/05/15 23:52, David Miller wrote: >> All of this work to allocate the buffer, add messages to it, and dump it >> to some user obtainable location duplicates existing infrastructure in >> the kernel. >> Please do not do this, and inste

Re: [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs

2015-05-22 Thread David Miller
From: Florian Westphal Date: Fri, 22 May 2015 16:32:49 +0200 > IP (ttl 64, id 12345, offset 0, flags [+, DF], proto UDP (17), length 1204) > 192.168.7.1.42 > 10.23.42.2.42: UDP, length 1400 > IP (ttl 64, id 12345, offset 1184, flags [DF], proto UDP (17), length 244) > 192.168.7.1 > 10.23.

Re: [PATCH v2 1/3] net: macb: Document zynq gem dt binding

2015-05-22 Thread David Miller
From: Nathan Sullivan Date: Fri, 22 May 2015 09:22:09 -0500 > Signed-off-by: Nathan Sullivan Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/3] net: macb: Disable half duplex gigabit on Zynq

2015-05-22 Thread David Miller
From: Nathan Sullivan Date: Fri, 22 May 2015 09:22:10 -0500 > According to the Zynq TRM, gigabit half duplex is not supported. Add a > new cap and compatible string so Zynq can avoid advertising that mode. > > Signed-off-by: Nathan Sullivan Applied. -- To unsubscribe from this list: send the

Re: [PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread David Miller
From: Linus Lüssing Date: Fri, 22 May 2015 15:32:37 +0200 > @@ -1786,14 +1784,8 @@ int br_multicast_set_router(struct net_bridge *br, > unsigned long val) > case 1: > br->multicast_router = val; > err = 0; > - break; > - > - default: > -

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread Vittorio G (VittGam)
Il 22.05.2015 20:24 David Miller ha scritto: Looks good, applied and queued up for -stable, thanks! That's great! I think this should also be backported up to Linux mainline 3.10, since the original commit that introduced the bug first appeared in 3.6. -- To unsubscribe from this list: send th

Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

2015-05-22 Thread Bjørn Mork
On 22 May 2015 19:22:47 CEST, Ben Hutchings wrote: >On Fri, 2015-05-22 at 13:15 +0200, Bjørn Mork wrote: >> The tx_curr_frame_payload field is u32. When we try to calculate a >> small negative delta based on it, we end up with a positive integer >> close to 2^32 instead. So the tx_bytes pointe

Re: [PATCH v3] iproute2: GENEVE support

2015-05-22 Thread John W. Linville
On Thu, May 21, 2015 at 03:19:01PM -0700, Stephen Hemminger wrote: > On Wed, 13 May 2015 13:02:28 -0400 > "John W. Linville" wrote: > > > Signed-off-by: John W. Linville > > Applied. > Please send update to man pages as well. Sorry for that oversight...coming right up! John -- John W. Linvil

[PATCH] iproute2: update ip-link.8 for geneve tunnels

2015-05-22 Thread John W. Linville
Signed-off-by: John W. Linville --- man/man8/ip-link.8.in | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 714aab488d4a..8cac246d7296 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip-link.8.in @@

Re: [PATCH net] ipv4: fill in table id when replacing a route

2015-05-22 Thread David Miller
From: Michal Kubecek Date: Fri, 22 May 2015 13:40:09 +0200 (CEST) > When replacing an IPv4 route, tb_id member of the new fib_alias > structure is not set in the replace code path so that the new route is > ignored. > > Fixes: 0ddcf43d5d4a ("ipv4: FIB Local/MAIN table collapse") > > Signed-off-

Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

2015-05-22 Thread David Miller
From: Bjørn Mork Date: Fri, 22 May 2015 13:15:22 +0200 > The tx_curr_frame_payload field is u32. When we try to calculate a > small negative delta based on it, we end up with a positive integer > close to 2^32 instead. So the tx_bytes pointer increases by about > 2^32 for every transmitted frame

Re: [PATCH 0/3] Netfilter fixes for net

2015-05-22 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 22 May 2015 12:34:03 +0200 > The following patchset contain Netfilter fixes for your net tree, they are: > > 1) Fix a race in nfnetlink_log and nfnetlink_queue that can lead to a crash. >This problem is due to wrong order in the per-net registration and net

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Fri, 22 May 2015 04:58:12 -0500 > ip_error does not check if in_dev is NULL before dereferencing it. > > IThe following sequence of calls is possible: > CPU A CPU B > ip_rcv_finish > ip_route_input_noref() >

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread David Miller
From: Eric Dumazet Date: Fri, 22 May 2015 11:08:39 -0700 > On Fri, 2015-05-22 at 11:03 -0700, Eric Dumazet wrote: > >> Also I am wondering if not explicitly include >> could break one arch... > > Sorry for the false alarm, we should be good because of snmp.h Right. -- To unsubscribe from this

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Hannes Frederic Sowa
On Fri, May 22, 2015, at 18:24, Mark Salyzyn wrote: > On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: > > I still wonder if we need to actually recheck the condition and not > > simply break out of unix_stream_data_wait: > > > > We return to the unix_stream_recvmsg loop and recheck the > > sk_r

Re: [patch net-next] flow_dissector: do not break if ports are not needed in flowlabel

2015-05-22 Thread David Miller
From: Jiri Pirko Date: Fri, 22 May 2015 11:05:58 +0200 > This restored previous behaviour. If caller does not want ports to be > filled, we should not break. > > Fixes: 06635a35d13d ("flow_dissect: use programable dissector in > skb_flow_dissect and friends") > Signed-off-by: Jiri Pirko Appli

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread David Miller
From: Eric Dumazet Date: Fri, 22 May 2015 10:56:36 -0700 > On Fri, 2015-05-22 at 13:50 -0400, David Miller wrote: > >> This bug exists in 'net' so I've applied it there. >> >> Thanks Eric. > > Oh thats right, sorry for this, as you'll probably have a conflict when > merging net into net-next.

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread Eric Dumazet
On Fri, 2015-05-22 at 11:03 -0700, Eric Dumazet wrote: > Also I am wondering if not explicitly include > could break one arch... Sorry for the false alarm, we should be good because of snmp.h -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to major

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread Eric Dumazet
On Fri, 2015-05-22 at 10:56 -0700, Eric Dumazet wrote: > On Fri, 2015-05-22 at 13:50 -0400, David Miller wrote: > > > This bug exists in 'net' so I've applied it there. > > > > Thanks Eric. > > Oh thats right, sorry for this, as you'll probably have a conflict when > merging net into net-next.

Re: [PATCH net-next 1/3] cxgb4: Add support for loopback between VI of same port

2015-05-22 Thread David Miller
From: Casey Leedom Date: Fri, 22 May 2015 16:49:03 + > Oh I definitely understand that and agree. Unfortunately I've > inherited a driver architecture that makes that ... "difficult" > for many operations ... And I have an internal bug filed > against me to fix those particular issues. >

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread Eric Dumazet
On Fri, 2015-05-22 at 13:50 -0400, David Miller wrote: > This bug exists in 'net' so I've applied it there. > > Thanks Eric. Oh thats right, sorry for this, as you'll probably have a conflict when merging net into net-next. Thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-22 Thread Pravin Shelar
On Wed, May 20, 2015 at 12:32 PM, Neil McKee wrote: > Directly associate a sampled packet with the path it takes through the > virtual switch. > Path information currently includes mangling, encapsulation and decapsulation > actions > for tunneling protocols GRE, VXLAN, Geneve, MPLS and QinQ, bu

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-22 Thread Skidmore, Donald C
> -Original Message- > From: Rose, Gregory V > Sent: Friday, May 22, 2015 8:08 AM > To: Hiroshi Shimamoto; Skidmore, Donald C; Kirsher, Jeffrey T; intel-wired- > l...@lists.osuosl.org > Cc: nhor...@redhat.com; jogre...@redhat.com; Linux Netdev List; Choi, > Sy Jong; Rony Efraim; David Mil

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread David Miller
From: Eric Dumazet Date: Thu, 21 May 2015 21:51:19 -0700 > From: Eric Dumazet > > Taking socket spinlock in tcp_get_info() can deadlock, as > inet_diag_dump_icsk() holds the &hashinfo->ehash_locks[i], > while packet processing can use the reverse locking order. > > We could avoid this locking

Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

2015-05-22 Thread Ben Hutchings
On Fri, 2015-05-22 at 13:15 +0200, Bjørn Mork wrote: > The tx_curr_frame_payload field is u32. When we try to calculate a > small negative delta based on it, we end up with a positive integer > close to 2^32 instead. So the tx_bytes pointer increases by about > 2^32 for every transmitted frame. >

Re: [RFC PATCH 08/13] xen-netback: clone skb if skb->xmit_more is set

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:36, Wei Liu wrote: > On Tue, May 12, 2015 at 07:18:32PM +0200, Joao Martins wrote: >> On xenvif_start_xmit() we have an additional queue to the netback RX >> kthread that will sends the packet. When using burst>1 pktgen sets >> skb->xmit_more to tell the driver that there m

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

2015-05-22 Thread Marek Marczykowski-Górecki
On Fri, May 22, 2015 at 05:58:41PM +0100, David Vrabel wrote: > On 22/05/15 17:42, Marek Marczykowski-Górecki wrote: > > On Fri, May 22, 2015 at 05:25:44PM +0100, David Vrabel wrote: > >> On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: > >>> Hi all, > >>> > >>> I'm experiencing xen-netfront cr

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

2015-05-22 Thread David Vrabel
On 22/05/15 17:42, Marek Marczykowski-Górecki wrote: > On Fri, May 22, 2015 at 05:25:44PM +0100, David Vrabel wrote: >> On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: >>> Hi all, >>> >>> I'm experiencing xen-netfront crash when doing xl network-detach while >>> some network activity is going

RE: [PATCH net-next 1/3] cxgb4: Add support for loopback between VI of same port

2015-05-22 Thread Casey Leedom
| From: David Miller [da...@davemloft.net] | Sent: Thursday, May 21, 2015 12:30 PM | | The prevailing assumption is that it's OK to have configuration | settings that can't be undone. | | And that's bogus from the beginning. Oh I definitely understand that and agree. Unfortunately I've inheri

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

2015-05-22 Thread Marek Marczykowski-Górecki
On Fri, May 22, 2015 at 05:25:44PM +0100, David Vrabel wrote: > On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: > > Hi all, > > > > I'm experiencing xen-netfront crash when doing xl network-detach while > > some network activity is going on at the same time. It happens only when > > domU has

Re: [PATCH] bridge: fix parsing of MLDv2 reports

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 8:18 AM, Thadeu Lima de Souza Cascardo wrote: > When more than a multicast address is present in a MLDv2 report, all but > the first address is ignored, because the code breaks out of the loop if > there has not been an error adding that address. > > This has caused failure

Re: [PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 6:32 AM, Linus Lüssing wrote: > Changelog v2: > * remove another now unnecessary -ENOENT initialization > * consistently initialize to -EINVAL, allowing to shorten two switch-cases > Looks perfect now. :) Thanks for update. -- To unsubscribe from this list: send the line

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

2015-05-22 Thread David Vrabel
On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: > Hi all, > > I'm experiencing xen-netfront crash when doing xl network-detach while > some network activity is going on at the same time. It happens only when > domU has more than one vcpu. Not sure if this matters, but the backend > is in anot

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: I still wonder if we need to actually recheck the condition and not simply break out of unix_stream_data_wait: We return to the unix_stream_recvmsg loop and recheck the sk_receive_queue. At this point sk_receive_queue is not really protected wi

Re: [Intel-wired-lan] [PATCH v5] ixgbe: Add module parameter to disable VLAN filter

2015-05-22 Thread Alexander Duyck
On 05/21/2015 06:10 AM, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto Introduce module parameter "disable_hw_vlan_filter" to disable HW VLAN filter on ixgbe module load. From the hardware limitation, there are only 64 VLAN entries for HW VLAN filter, and it leads to limit the number of V

  1   2   >