Re: rhashtable: Add cap on number of elements in hash table

2015-05-14 Thread David Miller
From: Herbert Xu Date: Fri, 15 May 2015 11:06:23 +0800 > On Thu, May 14, 2015 at 10:22:17PM -0400, David Miller wrote: >> >> In my opinion, up to at least 2 X max_size, it's safe to allow the >> insert. Assuming a well choosen hash function and a roughly even >> distribution. > > OK I can make

Re: [PATCH] ipv6: Fix udp checksums with raw sockets

2015-05-14 Thread Eric Dumazet
On Thu, 2015-05-14 at 22:27 -0400, David Miller wrote: > From: Vladislav Yasevich > Date: Thu, 14 May 2015 20:34:08 -0400 > > > It was reported that trancerout6 would cause > > a kernel to crash when trying to compute checksums > > on raw UDP packets. The cause was the check in > > __ip6_append_

Re: [PATCH net-next,v2,1/1] hv_netvsc: use per_cpu stats to calculate TX/RX data

2015-05-14 Thread David Miller
From: Simon Xiao Date: Thu, 14 May 2015 01:00:25 -0700 > Current code does not lock anything when calculating the TX and RX stats. > As a result, the RX and TX data reported by ifconfig are not accuracy in a > system with high network throughput and multiple CPUs (in my test, > RX/TX = 83% betwee

Re: [PATCH net-next] test_bpf: fix sparse warnings

2015-05-14 Thread David Miller
From: Alexei Starovoitov Date: Wed, 13 May 2015 20:40:39 -0700 > From: Michael Holzheu > > Fix several sparse warnings like: > lib/test_bpf.c:1824:25: sparse: constant 4294967295 is so big it is long > lib/test_bpf.c:1878:25: sparse: constant 0x is so big it is > long > > Fixe

Re: [PATCH net] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD

2015-05-14 Thread David Miller
From: ro...@cumulusnetworks.com Date: Wed, 13 May 2015 21:17:41 -0700 > From: Roopa Prabhu > > RTNH_F_EXTERNAL today is printed as "offload" in iproute2 output. > > This patch renames the flag to be consistent with what the user sees. > > Signed-off-by: Roopa Prabhu Applied, thanks. -- To un

Re: [PATCH net-next] netns: fix unbalanced spin_lock on error

2015-05-14 Thread David Miller
From: Nicolas Dichtel Date: Wed, 13 May 2015 13:43:09 +0200 > Unlock was missing on error path. > > Fixes: 95f38411df05 ("netns: use a spin_lock to protect nsid management") > Reported-by: Dan Carpenter > Signed-off-by: Nicolas Dichtel Applied. -- To unsubscribe from this list: send the line

Re: [PATCH] mdio-gpio: Propagate mii_bus.phy_ignore_ta_mask

2015-05-14 Thread David Miller
From: Bert Vermeulen Date: Wed, 13 May 2015 13:35:39 +0200 > This also changes mii_bus.phy_mask to u32 for consistency. > > Signed-off-by: Bert Vermeulen Applied, thanks Bert. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel

Re: [PATCH net-next] test_bpf: add tests related to BPF_MAXINSNS

2015-05-14 Thread David Miller
From: Daniel Borkmann Date: Wed, 13 May 2015 13:12:43 +0200 > Couple of torture test cases related to the bug fixed in 0b59d8806a31 > ("ARM: net: delegate filter to kernel interpreter when imm_offset() > return value can't fit into 12bits."). > > I've added a helper to allocate and fill the insn

Re: [net-next PATCH v3] ip_tunnel: Report Rx dropped in ip_tunnel_get_stats64

2015-05-14 Thread David Miller
From: Alexander Duyck Date: Thu, 14 May 2015 14:31:28 -0700 > The rx_dropped stat wasn't being reported when ip_tunnel_get_stats64 was > called. This was leading to some confusing results in my debug as I was > seeing rx_errors increment but no other value which pointed me toward the > type of e

Re: [PATCH net-next] tcp: syncookies: extend validity range

2015-05-14 Thread David Miller
From: Eric Dumazet Date: Thu, 14 May 2015 14:26:56 -0700 > From: Eric Dumazet > > Now we allow storing more request socks per listener, we might > hit syncookie mode less often and hit following bug in our stack : > > When we send a burst of syncookies, then exit this mode, > tcp_synq_no_recen

Re: [PATCH] net/mlx4: Avoid 'may be used uninitialized' warnings

2015-05-14 Thread David Miller
From: Bjorn Helgaas Date: Thu, 14 May 2015 18:17:08 -0500 > With a cross-compiler based on gcc-4.9, I see warnings like the following: > > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function > 'mlx4_SW2HW_CQ_wrapper': > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:30

Re: [PATCH] ipv6: Fix udp checksums with raw sockets

2015-05-14 Thread David Miller
From: Vladislav Yasevich Date: Thu, 14 May 2015 20:34:08 -0400 > It was reported that trancerout6 would cause > a kernel to crash when trying to compute checksums > on raw UDP packets. The cause was the check in > __ip6_append_data that would attempt to use > partial checksums on the packet. Ho

Re: [PATCH net-next v2] rocker: fix a neigh entry leak issue

2015-05-14 Thread David Miller
From: Ying Xue Date: Fri, 15 May 2015 09:33:25 +0800 > Once we get a neighbour through looking up arp cache or creating a > new one in rocker_port_ipv4_resolve(), the neighbour's refcount is > already taken. But as we don't put the refcount again after it's > used, this makes the neighbour entry

Re: rhashtable: Add cap on number of elements in hash table

2015-05-14 Thread David Miller
From: Herbert Xu Date: Wed, 13 May 2015 16:06:40 +0800 > We currently have no limit on the number of elements in a hash table. > This is a problem because some users (tipc) set a ceiling on the > maximum table size and when that is reached the hash table may > degenerate. Others may encounter OO

[PATCH] net/mlx4: Avoid 'may be used uninitialized' warnings

2015-05-14 Thread Bjorn Helgaas
With a cross-compiler based on gcc-4.9, I see warnings like the following: drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_SW2HW_CQ_wrapper': drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3048:10: error: 'cq' may be used uninitialized in this function [-Werro

Re: [PATCH net] netlink: move nl_table in read_mostly section

2015-05-14 Thread David Miller
From: Eric Dumazet Date: Tue, 12 May 2015 17:24:50 -0700 > From: Eric Dumazet > > netlink sockets creation and deletion heavily modify nl_table_users > and nl_table_lock. > > If nl_table is sharing one cache line with one of them, netlink > performance is really bad on SMP. > > 81ff5f

Re: [net-next fragmentation icmp v4 3/4] bridge_netfilter: No ICMP packet on IPv4 defragmentation timeout

2015-05-14 Thread David Miller
From: Andy Zhou Date: Thu, 14 May 2015 12:54:23 -0700 > On Thu, May 14, 2015 at 1:59 AM, Florian Westphal wrote: >> Andy Zhou wrote: >>> Currently, on defragmentation timeout error, ICMP error message >>> will be generated. This is fine when they are used in a routing context, >>> but does not

Re: [PATCH net-next v2] packet: fix warnings in rollover lock contention

2015-05-14 Thread David Miller
From: Willem de Bruijn Date: Thu, 14 May 2015 15:25:02 -0400 > From: Willem de Bruijn > > Avoid two xchg calls whose return values were unused, causing a > warning on some architectures. > > The relevant variable is a hint and read without mutual exclusion. > This fix makes all writers hold th

Re: [PATCH net-next] be2net: be_hwmon_show_temp() can be static

2015-05-14 Thread David Miller
From: kbuild test robot Date: Fri, 15 May 2015 03:02:35 +0800 > > Signed-off-by: Fengguang Wu > --- > be_main.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/emulex/benet/be_main.c > b/drivers/net/ethernet/emulex/benet/be_main.c > index dc7c

Re: [PATCH net-next 1/1] net: batch of last_rx update avoidance in ethernet drivers.

2015-05-14 Thread David Miller
From: Francois Romieu Date: Thu, 14 May 2015 20:17:22 +0200 > None of those drivers uses last_rx for its own needs. > > See 4dc89133f49b8cfd77ba7e83f5960aed63aaa99e ("net: add a comment on > netdev->last_rx") for reference. > > Signed-off-by: Francois Romieu Looks good, applied, thanks! -- To

Re: [net-next PATCH] ip_tunnel: Report Rx dropped in ip_tunnel_get_stats64

2015-05-14 Thread Eric Dumazet
On Thu, 2015-05-14 at 13:56 -0700, Eric Dumazet wrote: > > Or use netdev_stats_to_stats64() to remove all these copies, as we > obviously can miss some of them. Something like following untested patch : diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index 3998b1822d8521ad39

[PATCH net-next] be2net: be_hwmon_show_temp() can be static

2015-05-14 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- be_main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index dc7c0fd..76d491f 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/driver

Re: [PATCH net-next] packet: fix warnings in rollover lock contention

2015-05-14 Thread David Miller
From: Willem de Bruijn Date: Thu, 14 May 2015 14:35:57 -0400 > This looks great, thanks. I can submit it, but it is essentially your fix. Just give me your Acked-by: and I'll apply my patch then. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

Re: [PATCH net-next 0/3] net: phy: broken turn-around support

2015-05-14 Thread David Miller
From: Florian Fainelli Date: Tue, 12 May 2015 10:33:23 -0700 > This is an attempt at solving the broken turn-around problem in a way that > is not specific to the mdio-gpio driver, since it affects different kinds of > platforms. > > We cannot make that localized to PHY device drivers because pr

Re: [PATCH net-next] tipc: use sock_create_kern interface to create kernel socket

2015-05-14 Thread David Miller
From: Ying Xue Date: Wed, 13 May 2015 11:20:38 +0800 > After commit eeb1bd5c40ed ("net: Add a struct net parameter to > sock_create_kern"), we should use sock_create_kern() to create kernel > socket as the interface doesn't reference count struct net any more. > > Signed-off-by: Ying Xue Appli

Re: [PATCH v3] cls_flower: Fix compile error

2015-05-14 Thread David Miller
From: Brian Haley Date: Thu, 14 May 2015 13:20:15 -0400 > Fix compile error in net/sched/cls_flower.c > > net/sched/cls_flower.c: In function ‘fl_set_key’: > net/sched/cls_flower.c:240:3: error: implicit declaration of > function ‘tcf_change_indev’ [-Werror=implicit-function-dec

[RFC 21/23] net/xen-netback: Make it running on 64KB page granularity

2015-05-14 Thread Julien Grall
The PV network protocol is using 4KB page granularity. The goal of this patch is to allow a Linux using 64KB page granularity working as a network backend on a non-modified Xen. It's only necessary to adapt the ring size and break skb data in small chunk of 4KB. The rest of the code is relying on

Re: [PATCH v2] cls_flower: Fix compile error

2015-05-14 Thread David Miller
From: Brian Haley Date: Thu, 14 May 2015 12:50:17 -0400 > Fix compile error in net/sched/cls_flower.c > > net/sched/cls_flower.c: In function ‘fl_set_key’: > net/sched/cls_flower.c:240:3: error: implicit declaration of function > ‘tcf_change_indev’ [-Werror=implicit-function-declarat

Re: [PATCH net-next] packet: fix warnings in rollover lock contention

2015-05-14 Thread David Miller
From: Eric Dumazet Date: Thu, 14 May 2015 09:24:46 -0700 > On Thu, 2015-05-14 at 11:53 -0400, Willem de Bruijn wrote: > >> I principally want to avoid the lock contention on sk_receive_queue.lock, >> which is held for a lot longer while probing frames. But yes, I'd prefer to >> avoid the cacheli

Re: [PATCH] fix net/sched compile error

2015-05-14 Thread David Miller
From: Brian Haley Date: Thu, 14 May 2015 12:33:11 -0400 > Fix compile error in net/sched/cls_flower.c > > net/sched/cls_flower.c: In function ‘fl_set_key’: > net/sched/cls_flower.c:240:3: error: implicit declaration of function > ‘tcf_change_indev’ [-Werror=implicit-function-declarat

Re: [PATCH net-next 0/8] tipc: some link layer improvements

2015-05-14 Thread David Miller
From: Jon Maloy Date: Thu, 14 May 2015 10:46:10 -0400 > We continue eliminating redundant complexity at the link layer, and > add a couple of improvements to the packet sending functionality. Series applied, thanks Jon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH net-next 0/3] be2net: patch-set

2015-05-14 Thread David Miller
From: Venkat Duvvuru Date: Wed, 13 May 2015 13:00:11 +0530 > The following patch set has one new feature addition and two fixes. > > Patch 1 adds support for hwmon sysfs interface to display board temperature. > Board temperature display through ethtool statistics is removed. > > Patch 2 report

Re: [PATCH net-next] rocker: fix a neigh entry leak issue

2015-05-14 Thread David Miller
From: Eric Dumazet Date: Thu, 14 May 2015 07:06:22 -0700 > On Thu, 2015-05-14 at 15:06 +0800, Ying Xue wrote: >> Once we get a neighbour through looking up arp cache or creating a >> new one in rocker_port_ipv4_resolve(), the neighbour's refcount is >> already taken. But we don't put the refcount

Re: [PATCH] netfilter: ipset: deinline ip_set_put_extensions()

2015-05-14 Thread Pablo Neira Ayuso
On Wed, May 06, 2015 at 04:28:57PM +0200, Denys Vlasenko wrote: > On x86 allyesconfig build: > The function compiles to 489 bytes of machine code. > It has 25 callsites. > > textdata bss dec hex filename > 82441375 22255384 20627456 125324215 7784bb7 vmlinux.before > 824349

[PATCH net-next 03/11] stmmac: prepare stmmac platform to support stand alone drivers

2015-05-14 Thread Joachim Eastwood
Prepare the stmmac platform code to support standalone drivers by exporting the need functions and having of_match_device use the match table reference already present in the driver struct. This will allow us to reuse the platform driver functions from this code easily in other stand alone platfor

[PATCH net-next 07/11] stmmac: convert dwmac-rk to platform driver

2015-05-14 Thread Joachim Eastwood
Convert platform glue layer into a proper platform driver and add it to the build system. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/Kconfig| 11 + drivers/net/ethernet/stmicro/stmmac/Makefile | 3 ++- drivers/net/ethernet/stmicro/stmmac/dwmac-

Re: qla3xxx: Odd likely incorrect use of test_bit in qla3xxx.c

2015-05-14 Thread Joe Perches
On Thu, 2015-05-14 at 11:01 +0300, Dan Carpenter wrote: > On Wed, May 13, 2015 at 10:34:51AM -0700, Joe Perches wrote: > > In case the patches you found weren't of this type, > > there are other possibly suspicious uses with & like: > > drivers/usb/host/ehci-tegra.c: set_bit((wIndex &