In flow_dissector set vlan_id in flow_keys when VLAN is found.
Signed-off-by: Tom Herbert
---
include/net/flow_keys.h | 1 +
net/core/flow_dissector.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/net/flow_keys.h b/include/net/flow_keys.h
index c8bc6aa..14298e2 100644
--- a/inc
On Mon, 2015-05-11 at 18:34 -0700, Venkat Venkatsubra wrote:
> In ed1f50c3a ("net: add skb_checksum_setup") some checksum functions
> were introduced in core. Subsequent change b5cf66cd1 ("xen-netfront:
> use new skb_checksum_setup function") made use of those functions to
> replace its own impleme
On Sat, May 9, 2015 at 6:10 AM, Jiri Pirko wrote:
> __skb_tx_hash function has no relation to flow_dissect so just muve it
> to skbuff.c (it is declared in skbuff.h)
>
It calls __skb_get_hash() in most of the cases, and __skb_get_hash()
is in flow_dissector.c.
There are many functions declared i
On Mon, May 11, 2015 at 3:33 PM, Daniel Borkmann wrote:
> On 05/12/2015 12:03 AM, Cong Wang wrote:
> ...
>>
>> BTW, it should be protected by CONFIG_NET_SCH_INGRESS
>> rather than CONFIG_NET_CLS_ACT.
>
>
> Sure, I agree, this can further be improved. Feel free to send a patch.
I never agree on th
Hi David,
This patch series adds support for RX & TX interrupt coalescing in the
systemport driver.
Florian Fainelli (2):
net: systemport: Implement TX coalescing control knobs
net: systemport: Implement RX coalescing control knobs
drivers/net/ethernet/broadcom/bcmsysport.c | 63 +++
Hello,
On Mon, May 11, 2015 at 01:23:39PM -0400, David Miller wrote:
> From: Tejun Heo
> Date: Mon, 11 May 2015 12:41:34 -0400
>
> > + /* need to insert extra header fields, detect header and body */
> > + header = msg;
> > + body = memchr(msg, ';', msg_len);
> > + if (WARN_ON_ONCE(!body
On 05/11/2015 08:31 PM, Alexander Duyck wrote:
While trying to build for some performance testing I received the error
message below multiple times:
include/linux/netdevice.h:1658:5: warning: "CONFIG_NET_CLS_ACT" is not defined
[-Wundef]
#if CONFIG_NET_CLS_ACT
It looks like this was just a t
While trying to build for some performance testing I received the error
message below multiple times:
include/linux/netdevice.h:1658:5: warning: "CONFIG_NET_CLS_ACT" is not defined
[-Wundef]
#if CONFIG_NET_CLS_ACT
It looks like this was just a typo and should have been "#ifdef" instead of
"#if"
From: Eric Dumazet
Date: Mon, 11 May 2015 09:06:56 -0700
> From: Eric Dumazet
>
> Only left enqueue_root() user is netem, and it looks not necessary :
>
> qdisc_skb_cb(skb)->pkt_len is preserved after one skb_clone()
>
> Signed-off-by: Eric Dumazet
This looks fine, applied, thanks Eric.
--
From: Michal Simek
Date: Mon, 11 May 2015 16:05:02 +0200
> Use one return statement instead of two to simplify the code.
> Both are returning the same value.
>
> Signed-off-by: Michal Simek
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a m
From: Edward Cree
Date: Mon, 11 May 2015 13:19:03 +0100
> When the NIC doesn't support PTP, probe-time MCDI commands fail in
> predictable ways. Instead of logging cryptic MCDI errors, just log that
> PTP isn't supported.
These patches are severely corrupted by your email client, in particular
From: Philippe Reynes
Date: Mon, 11 May 2015 00:01:42 +0200
> This enables the ethtool's "-d" and "--register-dump"
> options for fec devices.
>
> Signed-off-by: Philippe Reynes
> ---
> drivers/net/ethernet/freescale/fec_main.c | 78
> +
> 1 files changed, 78 ins
From: Justin Cormack
Date: Sun, 10 May 2015 13:50:15 +0100
> The macvtap driver tries to emulate all the ioctls supported by a normal
> tun/tap driver, however it was missing the generic SIOCGIFHWADDR and
> SIOCSIFHWADDR ioctls to get and set the mac address that are supported
> by tun/tap. This
> On 11 May 2015, at 14:24, Jonas Gorski wrote:
>
> Hi,
>
>> On Mon, May 11, 2015 at 12:38 PM, Kalle Valo wrote:
>> Okash Khawaja writes:
>>
>>> Sure, I'll create v2 of the patch with updated commit log.
>>>
>>> Since it's part of a patch set, do you want me to send both the
>>> patches in t
From: Amir Vadai
Date: Sun, 10 May 2015 12:38:57 +0300
> +int mlx5_rename_eq(struct mlx5_core_dev *dev, int eq_ix, char *name)
> +{
> + struct mlx5_priv *priv = &dev->priv;
> + struct mlx5_eq_table *table = &priv->eq_table;
> + struct mlx5_eq *eq;
> + int err = -ENOENT;
> +
> +
From: Daniel Borkmann
Date: Mon, 11 May 2015 19:28:49 +0200
> This should have been #ifdef not #if.
>
> Reported-by: Fengguang Wu
> Fixes: d2788d34885d ("net: sched: further simplify handle_ing")
> Signed-off-by: Daniel Borkmann
> ---
> Very sorry for the typo.
Applied, thanks Daniel.
--
To
From: David Miller
Date: Mon, 11 May 2015 13:11:06 -0400 (EDT)
> From: David Ahern
> Date: Sat, 9 May 2015 16:21:43 -0600
>
>> Commit e2c6544829f removed pm_qos from struct net_device but left the
>> comment above header file. Remove those.
>>
>> Signed-off-by: David Ahern
>
> Applied, than
From: Tejun Heo
Date: Mon, 11 May 2015 12:41:34 -0400
> + /* need to insert extra header fields, detect header and body */
> + header = msg;
> + body = memchr(msg, ';', msg_len);
> + if (WARN_ON_ONCE(!body))
> + return;
> +
> + header_len = body - header;
> + b
On Thu, May 07, 2015 at 07:37:13PM -0500, Suravee Suthikulpanit wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 4269dba..c7227e8 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1,5 +1,6 @@
> config ARM64
> def_bool y
> + select ACPI_CCA_REQUIRED i
From: David Ahern
Date: Sat, 9 May 2015 16:21:43 -0600
> Commit e2c6544829f removed pm_qos from struct net_device but left the
> comment above header file. Remove those.
>
> Signed-off-by: David Ahern
Applied, thanks David.
--
To unsubscribe from this list: send the line "unsubscribe netdev"
From: Willem de Bruijn
Date: Sat, 9 May 2015 17:25:01 -0400
> From: Willem de Bruijn
>
> Rollover indicates exceptional conditions. Export a counter to inform
> socket owners of this state.
>
> If no socket with sufficient room is found, rollover fails. Also count
> these events.
>
> Finally
From: Felix Fietkau
Date: Sat, 9 May 2015 23:08:38 +0200
> After receiving a PADT and the socket is closed, user space will no
> longer drop the reference to the pppoe device.
> This leads to errors like this:
>
> [ 488.57] unregister_netdevice: waiting for eth0.2 to become free. Usage
>
netconsole uses both bool and int for boolean values. Let's convert
nt->enabled to bool for consistency.
Signed-off-by: Tejun Heo
Cc: David Miller
---
drivers/net/netconsole.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/netconsole.c b/driv
On Fri, 08 May 2015 13:28:40 -0700
Eric Dumazet wrote:
> From: Eric Dumazet
>
> Missing space before dctcp: markers.
>
> With dctcp, cwnd=2 is pretty common, just display cwnd value even
> if cwnd has this value, it makes parsing easier.
>
> Signed-off-by: Eric Dumazet
Applied, thanks
--
To
On Wed, 6 May 2015 17:25:39 +0200
Thomas Graf wrote:
> Signed-off-by: Thomas Graf
Thanks for catching this, applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordom
Le 11/05/2015 18:04, Nicolas Dichtel a écrit :
Le 11/05/2015 17:37, Jiri Pirko a écrit :
[snip]
I don't think this is the correct way to fix this.
How ifindex can be 0 here? Ifindex is set in register_netdevice and
looking at bond_create, I don't see any call to __bond_opt_set before
that. But
From: Eric Dumazet
Only left enqueue_root() user is netem, and it looks not necessary :
qdisc_skb_cb(skb)->pkt_len is preserved after one skb_clone()
Signed-off-by: Eric Dumazet
---
include/net/sch_generic.h |6 --
net/sched/sch_netem.c |4 ++--
2 files changed, 2 insertions(+
Mon, May 11, 2015 at 05:55:11PM CEST, alexander.h.du...@redhat.com wrote:
>On 05/09/2015 06:10 AM, Jiri Pirko wrote:
>>__skb_tx_hash function has no relation to flow_dissect so just muve it
>>to skbuff.c (it is declared in skbuff.h)
>>
>>Signed-off-by: Jiri Pirko
>
>Minor nit, move is spelled with
On 05/09/2015 06:10 AM, Jiri Pirko wrote:
__skb_tx_hash function has no relation to flow_dissect so just muve it
to skbuff.c (it is declared in skbuff.h)
Signed-off-by: Jiri Pirko
Minor nit, move is spelled with an o, not a u.
Also any reason for moving this to skbuff.c instead of dev.c? It
From: Daniel Borkmann
Date: Sat, 9 May 2015 22:51:30 +0200
> These are a couple of cleanups to make ingress a bit more lightweight.
Series applied, thanks Daniel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majo
From: Pablo Neira Ayuso
Date: Sun, 10 May 2015 19:05:50 +0200
> On Sat, May 09, 2015 at 10:51:30PM +0200, Daniel Borkmann wrote:
>> These are a couple of cleanups to make ingress a bit more lightweight.
>
> This is plain wrong at many levels.
>
> You're persisting on embedding the ingress code
From: Stefan Wahren
Date: Sat, 9 May 2015 07:58:09 +
> Registering the netdev before setting the priv data is unsafe.
> So fix this possible race by setting the priv data first.
>
> Signed-off-by: Stefan Wahren
> Cc: # v3.18+
> Fixes: 291ab06e (net: qualcomm: new Ethernet over SPI driver
From: Xi Wang
Date: Sat, 9 May 2015 04:14:30 -0400
> Extend the testcase to catch a signedness bug in the arm64 JIT:
>
> test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times)
>
> This is useful to ensure other JITs won't have a similar bug.
>
> Link: https://lkml.org/lkml/201
From: Jonathan Toppins
Date: Sat, 9 May 2015 00:01:54 -0700
> This is a resubmit of Mahesh's last 3 bonding patches from this series
> (http://marc.info/?l=linux-netdev&m=142432864626179&w=2) with one
> additional kernel patch which adds the netlink bits. I have noted any
> modifications I did t
From: ebied...@xmission.com (Eric W. Biederman)
Date: Fri, 08 May 2015 21:05:33 -0500
> Right now the situtation for allocating kernel sockets is a mess.
> - sock_create_kern does not take a namespace parameter.
> - kernel sockets must not reference count a network namespace and keep
> it alive
From: KY Srinivasan
Date: Mon, 11 May 2015 08:59:53 +
>
>
>> -Original Message-
>> From: Joe Perches [mailto:j...@perches.com]
>> Sent: Sunday, May 10, 2015 10:58 PM
>> To: KY Srinivasan
>> Cc: da...@davemloft.net; netdev@vger.kernel.org; linux-
>> ker...@vger.kernel.org; de...@linu
From: Johannes Berg
Date: Mon, 11 May 2015 10:31:43 +0200
> On Sat, 2015-05-09 at 17:34 -0400, David Miller wrote:
>
>> Johhannes, the hash table size Kconfig entry absolutely not appropriate.
>>
>> If anything, it should be hidden behind the strongest possible "DEBUG
>> ONLY" type dependencies
From: Nicolas Ferre
Date: Mon, 11 May 2015 12:10:54 +0200
> Le 09/05/2015 22:04, David Miller a écrit :
>> From: Nathan Sullivan
>> Date: Tue, 5 May 2015 15:00:25 -0500
>>
>>> The same hardware issue the at91 must work around applies to at least the
>>> Zynq ethernet, and possibly more devices.
On 05/07/2015 05:30 PM, Julia Lawall wrote:
> On Thu, 7 May 2015, Michal Simek wrote:
>
>> From: Michal Simek
>>
>> Use one return statement instead of two to simplify the code.
>> Both are returning the same value.
>>
>> Signed-off-by: Michal Simek
>
> The from should be the same as the signed
Don't do clock-mode-select if clk == NULL,
since when building without CONFIG_HAVE_CLK,
clk_get returns NULL and clk_get_rate returns 0.
Doing clock-mode-select in this cause causes kszphy_probe to
return -EINVAL and thus prevents the device from being probed.
The original code (before regression
Mon, May 11, 2015 at 02:08:34PM CEST, j...@mojatatu.com wrote:
>On 05/09/15 09:10, Jiri Pirko wrote:
>>This patch introduces a flow-based filter. So far, the very essential
>>packet fields are supported.
>>
>>This patch is only the first step. There is a lot of potential performance
>>improvements
41 matches
Mail list logo
