Re: [PATCH net] net: fix crash in build_skb()

2015-04-25 Thread David Miller
From: Eric Dumazet Date: Fri, 24 Apr 2015 16:05:01 -0700 > From: Eric Dumazet > > When I added pfmemalloc support in build_skb(), I forgot netlink > was using build_skb() with a vmalloc() area. > > In this patch I introduce __build_skb() for netlink use, > and build_skb() is a wrapper handling

iproute2: Make linux/in6.h a stub?

2015-04-25 Thread Felix Janda
Hello. Background: Current iproute2 does not build when the libc is musl instead of glibc. This is because of redefinition of in6_addr in netinet/in.h and linux/in6.h. There are workarounds in linux/libc-compat.h to make it somehow work for glibc. As I can see linux/in6.h is only indirectly used

[PATCH iproute2] Use PATH_MAX instead of MAXPATHLEN

2015-04-25 Thread Felix Janda
They are equivalent but the former is more common. PATH_MAX is specified by POSIX and needs while MAXPATHLEN has BSD origin and needs . PATH_MAX has already been in use in misc/lnstat.h. Signed-off-by: Felix Janda --- ip/ipnetns.c| 15 +++ lib/namespace.c | 11 ++- 2 fi

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-25 Thread David Miller
From: Murali Karicheri Date: Fri, 24 Apr 2015 15:01:41 -0400 > Currently when interface type is MAC to Phy, netif_carrier_(on/off) > is called which is not needed as Phy lib already updates the carrier > status to net stack. This is needed only for other interface types > > Signed-off-by: Murali

Re: [PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into netvsc module

2015-04-25 Thread David Miller
From: six...@microsoft.com Date: Fri, 24 Apr 2015 11:34:48 -0700 > + net_device_ctx->msg_enable = netif_msg_init(debug, default_msg); > + if (netif_msg_probe(net_device_ctx)) > + netdev_dbg(net, "netvsc msg_enable: %d", > +net_device_ctx->msg_enable); >

Question about raw_socket

2015-04-25 Thread Mindiell
Hi there, I'm using recvfrom with a raw_socket and I was wondering if the frame "captured" was totally blocked or if it will be passed to the rest of the other processes or daemons or whatever ? I mean: If I'm "sniffing" traffic, will my network be blocked or not ? Thx, Mindiell -- To unsubscrib

Re: [patch net-next v4 RFC 12/15] flow_dissector: introduce support for ipv6 addressses

2015-04-25 Thread Jiri Pirko
Fri, Apr 24, 2015 at 07:28:05PM CEST, t...@herbertland.com wrote: >Hi Jiri, > >Thanks for this work, I think it's a good direction! Some comments below... > >On Fri, Apr 24, 2015 at 8:51 AM, Jiri Pirko wrote: ... >> enum flow_dissector_key_id { >> FLOW_DISSECTOR_KEY_BASIC, /* struct flo

Re: [PATCH] net: eth: altera: Resolve false errors from MSGDMA to TSE

2015-04-25 Thread David Miller
From: Vince Bridgers Date: Fri, 24 Apr 2015 02:32:07 -0500 > From: Chee Nouk Phoon > > This patch resolves false errors from MSGDMA in TX mSGDMA MM to ST > mode, and is a continuation of the patch recently submitted by Andrea > Oetken. The MSGDMA had a logic bug that masked detection of this is

Re: [PATCH] ehea: Fix memory hook reference counting crashes

2015-04-25 Thread David Miller
From: Michael Ellerman Date: Fri, 24 Apr 2015 15:52:32 +1000 > The recent commit to only register the EHEA memory hotplug hooks on > adapter probe has a few problems. > > Firstly the reference counting is wrong for multiple adapters, in that > the hooks are registered multiple times. Secondly th

Re: [PATCH] net/tg3: Release IRQs on permanent error

2015-04-25 Thread David Miller
From: Gavin Shan Date: Fri, 24 Apr 2015 15:22:23 +1000 > When having permanent EEH error, the PCI device will be removed > from the system. For this case, we shouldn't set pcierr_recovery > to true wrongly, which blocks the driver to release the allocated > interrupts and their handlers. Eventual

Re: [PATCH net-next 3/6] ipv6: netfilter: remove unnecessary braces

2015-04-25 Thread Joe Perches
On Sat, 2015-04-25 at 19:54 +0300, Sergei Shtylyov wrote: > Parens around the *return* expression are not necessary. :-) Yeah, what Sergei said... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next 3/6] ipv6: netfilter: remove unnecessary braces

2015-04-25 Thread Sergei Shtylyov
Hello. On 04/25/2015 06:59 PM, Joe Perches wrote: Remove braces from a few if statements where not required. trivia: diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c [] @@ -151,9 +151,8 @@ ip6_packet_match(const struct sk_buff *skb,

[PATCH net] net: rfs: fix crash in get_rps_cpus()

2015-04-25 Thread Eric Dumazet
From: Eric Dumazet Commit 567e4b79731c ("net: rfs: add hash collision detection") had one mistake : RPS_NO_CPU is no longer the marker for invalid cpu in set_rps_cpu() and get_rps_cpu(), as @next_cpu was the result of an AND with rps_cpu_mask This bug showed up on a host with 72 cpus : next_cpu

Re: [PATCH net-next 6/6] ipv6: netfilter: simply if-else statements

2015-04-25 Thread Joe Perches
On Sat, 2015-04-25 at 10:27 +0100, Ian Morris wrote: > Remove "else" branch of "if" statements where a return is always done > when the condition is true. trivia: > diff --git a/net/ipv6/netfilter/ip6t_hbh.c b/net/ipv6/netfilter/ip6t_hbh.c [] > @@ -95,70 +95,67 @@ hbh_mt6(const struct sk_buff *sk

[PATCH v3] altera tse: add support for fixed-links.

2015-04-25 Thread Andreas Oetken
From: Andreas Oetken Add support for fixed-links in configurations without PHY. (e.g. connection to a switch, SGMII point to point, SFPs) Check: Documentation/devicetree/bindings/net/fixed-link.txt. Signed-off-by: Andreas Oetken --- drivers/net/ethernet/altera/altera_tse_main.c | 37 ++

Re: [PATCH net-next 3/6] ipv6: netfilter: remove unnecessary braces

2015-04-25 Thread Joe Perches
On Sat, 2015-04-25 at 10:26 +0100, Ian Morris wrote: > Remove braces from a few if statements where not required. trivia: > diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c [] > @@ -151,9 +151,8 @@ ip6_packet_match(const struct sk_buff *skb, >

Re: [PATCH net-next 2/6] ipv6: netfilter: whitespace in line layouts

2015-04-25 Thread Joe Perches
On Sat, 2015-04-25 at 10:26 +0100, Ian Morris wrote: > Try to improve coding readability by adding spaces in line layouts. No > changes to functionality. No changes according to objdiff. trivia: > diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c [] > @@ -44,13 +44,13

[PATCH net-next 2/6] ipv6: netfilter: whitespace in line layouts

2015-04-25 Thread Ian Morris
Try to improve coding readability by adding spaces in line layouts. No changes to functionality. No changes according to objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c| 12 ++-- net/ipv6/netfilter/ip6t_rpfilter.c | 2 +- net/ipv6/netfi

[PATCH net-next 0/6] ipv6: netfilter - coding style improvements

2015-04-25 Thread Ian Morris
This series of patches removes some style issues in the ipv6 netfilter code detected by checkpatch. There is no change to functionality and no changes to the resultant object determined by objdiff. Ian Morris (6): ipv6: netfilter: Tidy up indenting ipv6: netfilter: whitespace in line layouts

[PATCH net-next 1/6] ipv6: netfilter: Tidy up indenting

2015-04-25 Thread Ian Morris
This patch cleanses some indent issues in the ipv6 netfilter code by converting spaces to tabs etc. No changes to functionality. No changes according to objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 12 ++-- net/ipv6/netfilter/nft_chain_route_ipv6.c |

[PATCH net-next 3/6] ipv6: netfilter: remove unnecessary braces

2015-04-25 Thread Ian Morris
Remove braces from a few if statements where not required. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 3 +-- net/ipv6/netfilter/nf_conntrack_reasm.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/net/ipv6/net

[PATCH net-next 4/6] ipv6: netfilter: comparison for equality with NULL

2015-04-25 Thread Ian Morris
The code uses a mixture of coding styles. In some instances check for NULL pointer is done as x == NULL and sometimes as !x. !x is preferred according to checkpatch and this patch makes the code consistent by adopting the latter form. No changes detected by objdiff. Signed-off-by: Ian Morris ---

[PATCH net-next 6/6] ipv6: netfilter: simply if-else statements

2015-04-25 Thread Ian Morris
Remove "else" branch of "if" statements where a return is always done when the condition is true. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c| 7 +- net/ipv6/netfilter/ip6t_hbh.c | 105 -

[PATCH net-next 5/6] ipv6: netfilter: comparison for inequality with NULL

2015-04-25 Thread Ian Morris
The code uses a mixture of coding styles. In some instances check for NULL pointer is done as x != NULL and sometimes as x. x is preferred according to checkpatch and this patch makes the code consistent by adopting the latter form. No changes detected by objdiff. Signed-off-by: Ian Morris ---