Re: [PATCH 2.6.25 0/8][BNX2X]: bugfixes and updates

2008-02-20 Thread Eliezer Tamir
> > This patch-set updates several sections of the bnx2x driver. > > It is not appropriate to be adding features at this time > to the 2.6.25 tree. > > Please wait for the opportunity to submit 2.6.26 bound > patches for new features. > > I encourage you to split out just the bug fixes from this

ni52.c warnings explosion

2008-02-20 Thread Harvey Harrison
Dave, Somewhere between 2.6.25-rc1 and -rc2 something changed that produces a few hundred sparse warnings in ni52.c. I see Alan touched it last. drivers/net/ni52.c:219:15: warning: incorrect type in argument 1 (different address spaces) drivers/net/ni52.c:219:15:expected void const volatile

Re: printk_ratelimit and net_ratelimit conflict and tunable behavior

2008-02-20 Thread Joe Perches
On Wed, 2008-02-20 at 22:32 -0800, David Miller wrote: > > + if (lost) { > > + printk(KERN_WARNING > > + "printk: %d %s%smessage%s suppressed.\n", > > + lost, > > + (state->facility == 0 ? "" : >

RE: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
> From: "Divy Le Ray" <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 21:57:08 -0800 > > > The driver is cxgb3 here, it uses LLTX. > > That's extremely unfortunate, hopefully you can update it to > use a model like tg3 and others use. LLTX is a lost cause > for hardware device drivers, and in fact

Re: [PATCH] cls_u32 u32_classify()

2008-02-20 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 06:54:48 -0500 > On Mon, 2008-18-02 at 21:46 -0800, David Miller wrote: > > > > Can some u32 expert review this? > > http://marc.info/?l=linux-netdev&m=120178638323045&w=2 Fair enough. Dzianis, please provide the feedback Jamal is asking

Re: printk_ratelimit and net_ratelimit conflict and tunable behavior

2008-02-20 Thread David Miller
From: "Hawkes Steve-FSH016" <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 15:30:51 -0600 [ netdev CC:'d ] > The printk_ratelimit() and net_ratelimit() functions are coupled and > interfere with each other. Each has their own tunable parameters to > control their respective rate limiting feature, but

Re: [git patches] net driver updates

2008-02-20 Thread David Miller
From: "Divy Le Ray" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 21:57:08 -0800 > The driver is cxgb3 here, it uses LLTX. That's extremely unfortunate, hopefully you can update it to use a model like tg3 and others use. LLTX is a lost cause for hardware device drivers, and in fact we'd like to rem

Re: pull request: wireless-2.6 2008-02-20

2008-02-20 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 21:11:32 -0500 > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git > master Pulled and pushed back out, thanks John. > ssb: Fix the GPIO API This could have had a much better changelog, it's way t

RE: [git patches] net driver updates

2008-02-20 Thread Krishna Kumar2
Hi Divy, But the race doesn't exist even for LLTX drivers these days. There is no way two cpu's can execute the xmit handler at the same time. Thanks, - KK > > > > The first part of the patch removes the !netif_queue_stopped(dev). > > > > It opens the race discussed a while ago between Stephen

RE: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
> -Original Message- > From: David Miller [mailto:[EMAIL PROTECTED] > Sent: Wednesday, February 20, 2008 9:47 PM > To: [EMAIL PROTECTED] > Cc: Divy Le Ray; [EMAIL PROTECTED]; [EMAIL PROTECTED]; > netdev@vger.kernel.org > Subject: Re: [git patches] net driver updates > > From: Krishna Kum

Re: kernel BUG at net/core/skbuff.c:95!

2008-02-20 Thread David Miller
From: Jim Westfall <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 21:46:48 -0800 > static inline void llc_pdu_init_as_test_rsp(struct sk_buff *skb, > struct sk_buff *ev_skb) > { > struct llc_pdu_un *pdu = llc_pdu_un_hdr(skb); > > pd

Re: kernel BUG at net/core/skbuff.c:95!

2008-02-20 Thread Jim Westfall
Hi Poking around in the llc and net code I think I see the issue, but am not sure of the best way to fix the it. static int llc_station_ac_send_test_r(struct sk_buff *skb) { u8 mac_da[ETH_ALEN], dsap; int rc = 1; struct sk_buff *nskb = llc_alloc_frame(NULL, skb->dev);

Re: [git patches] net driver updates

2008-02-20 Thread David Miller
From: Krishna Kumar2 <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 09:13:49 +0530 > Hi Divy, > > > > Explain why, so I can include it in the changelog please... > > > > Hi Jeff, > > > > The first part of the patch removes the !netif_queue_stopped(dev). > > It opens the race discussed a while ago bet

Re: [PATCH] [NETFILTER]: fix ebtable targets return

2008-02-20 Thread David Miller
From: Joonwoo Park <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 14:36:32 +0900 > The function ebt_do_table doesn't take NF_DROP as a verdict from the targets. > > Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> Whoops, good catch :-) Patrick, if you want you can just signoff on this and I can put

[PATCH] [NETFILTER]: fix ebtable targets return

2008-02-20 Thread Joonwoo Park
The function ebt_do_table doesn't take NF_DROP as a verdict from the targets. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- net/bridge/netfilter/ebt_dnat.c |2 +- net/bridge/netfilter/ebt_redirect.c |2 +- net/bridge/netfilter/ebt_snat.c |2 +- 3 files changed, 3 inserti

Re: [git patches] net driver updates

2008-02-20 Thread Krishna Kumar2
Hi Divy, > > Explain why, so I can include it in the changelog please... > > Hi Jeff, > > The first part of the patch removes the !netif_queue_stopped(dev). > It opens the race discussed a while ago between Stephen hemminger and > David Miller: > http://marc.info/?l=linux-netdev&m=113383224512427&

Re: [PATCH 01/04] smc91x: pass along private data

2008-02-20 Thread Nicolas Pitre
On Thu, 21 Feb 2008, Magnus Damm wrote: > On Thu, Feb 21, 2008 at 12:42 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote: > > On Wed, 20 Feb 2008, Magnus Damm wrote: > > > > > Pass a private data pointer to macros and functions. This makes it easy > > > to later on make run time decisions. This patch

Re: [PATCH 02/04] smc91x: introduce platform data flags

2008-02-20 Thread Nicolas Pitre
On Thu, 21 Feb 2008, Magnus Damm wrote: > On Thu, Feb 21, 2008 at 12:58 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote: > > On Wed, 20 Feb 2008, Magnus Damm wrote: > > > > > This patch introduces struct smc91x_platdata and modifies the driver so > > > bus width is checked during run time using SMC_

[patch 5/6] pasemi_mac: Enable GSO by default

2008-02-20 Thread Olof Johansson
Ethtool support will handle the runtime toggling, but we do quite a bit better with it on by default so just leave it on for now. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.

[patch 4/6] pasemi_mac: jumbo frame support

2008-02-20 Thread Olof Johansson
First cut at jumbo frame support. To support large MTU, one or several separate channels must be allocated to calculate the TCP/UDP checksum separately, since the mac lacks enough buffers to hold a whole packet while it's being calculated. Furthermore, it seems that a single function channel is no

[patch 6/6] pasemi_mac: basic ethtool support

2008-02-20 Thread Olof Johansson
First cut at ethtool support, to be completed over time. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: 2.6.25/drivers/net/Makefile === --- 2.6.25.orig/drivers/net/Makefile +++ 2.6.25/drivers/net/Makefile @@ -218,7 +218,8

[patch 0/6] pasemi_mac updates for 2.6.26

2008-02-20 Thread Olof Johansson
Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch the dma_lib in the platform code as well, but it's easier if it's all merged through netdev to avoid dependencies. Major highlights are jumbo frame support and ethtool basics, the rest is mostly minor plumbing around it. -- -

[patch 2/6] [POWERPC] pasemi: Add flag management functions to dma_lib

2008-02-20 Thread Olof Johansson
Add functions to manage the channel syncronization flags to dma_lib Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/arch/powerpc/platforms/pasemi/dma_lib.c === --- k.org.orig/arch/powerpc/platforms/pasemi/dma_lib.c

[patch 1/6] pasemi_mac: Move RX/TX section enablement to dma_lib

2008-02-20 Thread Olof Johansson
Also stop both rx and tx sections before changing the configuration of the dma device during init. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/arch/powerpc/platforms/pasemi/dma_lib.c === --- k.org.orig/arch/powerpc

[patch 3/6] [POWERPC] pasemi: Add function engine management functions to dma_lib

2008-02-20 Thread Olof Johansson
Used to allocate functions for crypto/checksum offload. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/arch/powerpc/platforms/pasemi/dma_lib.c === --- k.org.orig/arch/powerpc/platforms/pasemi/dma_lib.c +++ k.org/a

Re: sungem triggers NAPI warning

2008-02-20 Thread Benjamin Herrenschmidt
On Tue, 2008-02-19 at 22:38 +0100, Johannes Berg wrote: > I started getting this warning with recent kernels: Do that help ? In gem_poll(), do: - work_done += gem_rx(gp, budget); + work_done += gem_rx(gp, budget - work_done); Cheers, Ben. > [ 773.908927] [ cut here ]---

Re: [PATCH 00/04] smc91x: request bus width using platform data

2008-02-20 Thread Magnus Damm
On Thu, Feb 21, 2008 at 12:36 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote: > On Wed, 20 Feb 2008, Magnus Damm wrote: > > > These patches make it possible to request bus width in the platform data. > > > > Instead of keep on updating smc91x.h with board specific configuration, > > use platform d

Re: [PATCH 04/04] smc91x: add insw/outsw to default config

2008-02-20 Thread Magnus Damm
On Thu, Feb 21, 2008 at 1:00 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote: > On Wed, 20 Feb 2008, Magnus Damm wrote: > > > This patch makes sure SMC_insw()/SMC_outsw() are defined for the > > default configuration. Without this change BUG()s will be triggered > > when using 16-bit only platform d

Re: [PATCH 02/04] smc91x: introduce platform data flags

2008-02-20 Thread Magnus Damm
On Thu, Feb 21, 2008 at 12:58 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote: > On Wed, 20 Feb 2008, Magnus Damm wrote: > > > This patch introduces struct smc91x_platdata and modifies the driver so > > bus width is checked during run time using SMC_nBIT() instead of > > SMC_CAN_USE_nBIT. > > > >

pull request: wireless-2.6.26 2008-02-20

2008-02-20 Thread John W. Linville
David, Here are a slew of developments intended for 2.6.26. The patches are too diverse to comment upon in this summary... :-) Please let me know if there are problems! Thanks, John --- Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wir

pull request: wireless-2.6 2008-02-20

2008-02-20 Thread John W. Linville
David, Here are some fixes intended for 2.6.25. These are mostly small things: a couple of USB IDs, some sparse warnings, and an ath5k warning you should recognize. :-) There are also a number of SSB bus fixes -- Michael has been hacking on a new AP... Please let me know if there are problems!

Re: [PATCH 01/04] smc91x: pass along private data

2008-02-20 Thread Magnus Damm
On Thu, Feb 21, 2008 at 12:42 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote: > On Wed, 20 Feb 2008, Magnus Damm wrote: > > > Pass a private data pointer to macros and functions. This makes it easy > > to later on make run time decisions. This patch does not change any logic. > > These changes shou

Re: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.kernel.org:/pu

RE: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread Ramkrishna Vepa
> From: Patrick McHardy [mailto:[EMAIL PROTECTED] > Sent: Wednesday, February 20, 2008 3:22 PM > To: David Miller > Cc: Ramkrishna Vepa; Sreenivasa Honnur; netdev@vger.kernel.org; > [EMAIL PROTECTED]; support > Subject: Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - > FIFO selectio

[PATCH 2.6.25] RDMA/cxgb3: Shift calculation wrong for single sge entries.

2008-02-20 Thread Steve Wise
RDMA/cxgb3: Shift calculation wrong for single sge entries. A single entry (addr 0x10001000, size 0x2000) will get converted to page address 0x1000 with a page size of 0x4000. The code as it stands doesn't address the single buffer case, but in fact it allows the subsequent single-buffer spe

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-20 Thread Michael Chan
On Wed, 2008-02-20 at 15:08 -0800, David Miller wrote: > From: Tony Battersby <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 18:04:09 -0500 > > > The following patch fixes the problem for me. Do we want to accept this > > patch and call it a day or continue investigating the source of the problem?

Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 00:15:13 +0100 I missed those discussions, but this has already been agreed on, fine by me. It would still be preferable to use queue_mapping instead of priority IMO, even if its activated by a module parame

Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 00:15:13 +0100 > I missed those discussions, but this has already been agreed on, > fine by me. It would still be preferable to use queue_mapping > instead of priority IMO, even if its activated by a module > parameter, since that le

Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 00:08:52 +0100 Ramkrishna Vepa wrote: Sreenivasa Honnur wrote: - Resubmit #2 - Transmit fifo selection based on TCP/UDP ports. - Added tx_steering_type loadable parameter for transmit fi

Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 00:08:52 +0100 > Ramkrishna Vepa wrote: > >> Sreenivasa Honnur wrote: > >> > >>> - Resubmit #2 > >>> - Transmit fifo selection based on TCP/UDP ports. > >>> - Added tx_steering_type loadable parameter for transmit fifo > >>>

Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread Patrick McHardy
Ramkrishna Vepa wrote: Sreenivasa Honnur wrote: - Resubmit #2 - Transmit fifo selection based on TCP/UDP ports. - Added tx_steering_type loadable parameter for transmit fifo selection. 0x0 NO_STEERING: Default FIFO is selected. 0x1 TX_PRIORITY_STEERING: FIFO is selected base

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-20 Thread David Miller
From: Tony Battersby <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 18:04:09 -0500 > The following patch fixes the problem for me. Do we want to accept this > patch and call it a day or continue investigating the source of the problem? > > Patch applies to 2.6.24.2, but doesn't apply to 2.6.25-rc.

Re: [git patches] net driver fixes

2008-02-20 Thread David Miller
From: Francois Romieu <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 23:40:53 +0100 > David Miller <[EMAIL PROTECTED]> : > [...] > > Because it forces me to pull Linus's upstream into net-2.6, > > I don't have any choice in the matter. > > Jeff's choice is a bit surprizing. That being said, it would

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-20 Thread Tony Battersby
The following patch fixes the problem for me. Do we want to accept this patch and call it a day or continue investigating the source of the problem? Patch applies to 2.6.24.2, but doesn't apply to 2.6.25-rc. If everyone agrees that this is the right solution, I will resubmit with a proper subjec

RE: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread Ramkrishna Vepa
> Sreenivasa Honnur wrote: > > - Resubmit #2 > > - Transmit fifo selection based on TCP/UDP ports. > > - Added tx_steering_type loadable parameter for transmit fifo selection. > > 0x0 NO_STEERING: Default FIFO is selected. > > 0x1 TX_PRIORITY_STEERING: FIFO is selected based on skb->priority. >

Re: [git patches] net driver fixes

2008-02-20 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > Because it forces me to pull Linus's upstream into net-2.6, > I don't have any choice in the matter. Jeff's choice is a bit surprizing. That being said, it would had been nice to fast-forward net-2.6 from a442585952f137bd4cdb1f2f3166e4157d383b82 to Linus'

Re: [git patches] net driver fixes

2008-02-20 Thread David Miller
From: "J. Bruce Fields" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 17:25:30 -0500 > The advantages include earlier warning of merge problems, and avoidance > of duplicate commits--if Jeff's done work that depends on patches that > already upstream, then he either does that work against upstream, o

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-20 Thread James Chapman
Jarek Poplawski wrote: (testing patch #1) But I hope you tested with the fixed (take 2) version of this patch... Yes I did. :) But I just got another lockdep error (attached). Since it's quite experimental (testing) this patch could be wrong as it is, but I hope it should show the proper

Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Ilpo Järvinen
On Wed, 20 Feb 2008, Vlad Yasevich wrote: > Ilpo Järvinen wrote: > > I added inline to sctp_add_cmd and appropriate comment there to > > avoid adding another call into the call chain. This works at least > > with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alternatively, > > __sctp_add_cmd coul

Re: [git patches] net driver fixes

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 01:42:57PM -0800, David Miller wrote: > From: "J. Bruce Fields" <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 16:23:02 -0500 > > > On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: > > > From: Jeff Garzik <[EMAIL PROTECTED]> > > > Date: Wed, 20 Feb 2008 11:55:57

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Ilpo Järvinen
On Wed, 20 Feb 2008, Jan Engelhardt wrote: > > On Feb 20 2008 17:27, Patrick McHardy wrote: > >> Striking. How can this even happen? A callsite which calls > >> > >> dev_alloc_skb(n) > >> > >> is just equivalent to > >> > >> __dev_alloc_skb(n, GFP_ATOMIC); > >> > >> which means there's like

Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread Patrick McHardy
Sreenivasa Honnur wrote: - Resubmit #2 - Transmit fifo selection based on TCP/UDP ports. - Added tx_steering_type loadable parameter for transmit fifo selection. 0x0 NO_STEERING: Default FIFO is selected. 0x1 TX_PRIORITY_STEERING: FIFO is selected based on skb->priority. 0x2 TX_DEFAULT_STEE

Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Vlad Yasevich
Ilpo Järvinen wrote: I added inline to sctp_add_cmd and appropriate comment there to avoid adding another call into the call chain. This works at least with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alternatively, __sctp_add_cmd could be introduced to .h. My only concern was performance r

[Patch 2.6.25 4/4]S2io: Version update for multiqueue and vlan patches

2008-02-20 Thread Sreenivasa Honnur
- Updated version number. Signed-off-by: Surjit Reang <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> --- diff -Nurp 2-0-26-19-1/drivers/net/s2io.c 2-0-26-19-2/drivers/net/s2io.c --- 2-0-26-19-1/drivers/net/s2io.c 2008-02-15 07:03:10.0 +0530 +++ 2-0-26-19-2/driv

[Patch 2.6.25 3/4]S2io: Support for vlan_rx_kill_vid entry point

2008-02-20 Thread Sreenivasa Honnur
- Resubmit #3 - Added s2io_vlan_rx_kill_vid entry point function for unregistering vlan. - Fix to aggregate vlan packets. IP offset is incremented by 4 bytes if the packet contains vlan header. Signed-off-by: Surjit Reang <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> ---

[PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports

2008-02-20 Thread Sreenivasa Honnur
- Resubmit #2 - Transmit fifo selection based on TCP/UDP ports. - Added tx_steering_type loadable parameter for transmit fifo selection. 0x0 NO_STEERING: Default FIFO is selected. 0x1 TX_PRIORITY_STEERING: FIFO is selected based on skb->priority. 0x2 TX_DEFAULT_STEERING: FIFO is selected base

Re: 2.6.25-rc2-mm1 - several bugs and a crash

2008-02-20 Thread Patrick McHardy
Tilman Schmidt wrote: Still, X came up fine, I could log in (Gnome feeling subjectively a bit sluggish), call up a web page from the Internet in Firefox, and start perusing the logs, when the whole system froze: neither mouse nor keyboard would react anymore, and only the Wind^Wreset button would

Re: [PATCH] sungem: remove superfluous variable

2008-02-20 Thread Joe Perches
Make sungem.c checkpatch error clean gem_rx: reuse dma_addr temporary gem_clean_rings: remove an indentation level 80 columns (not function definitions) Remove spaces before tabs __inline__ to inline labels in column 1 printk cleanup begnign/benign typo Signed-off-by: Joe Perches diff --git a/dr

[PATCH 2.6.25 1/4]S2io: Multiqueue network device support implementation

2008-02-20 Thread Sreenivasa Honnur
- Resubmit #3 Multiqueue netwrok device support implementation. - Added a loadable parameter "multiq" to enable/disable multiqueue support, by default it is disabled. - skb->queue_mapping is not used for queue/fifo selection. FIFO selection is based on skb->priority. - Added per FIFO flags FIFO

Re: [git patches] net driver fixes

2008-02-20 Thread David Miller
From: "J. Bruce Fields" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 16:23:02 -0500 > On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: > > From: Jeff Garzik <[EMAIL PROTECTED]> > > Date: Wed, 20 Feb 2008 11:55:57 -0500 > > > > > > > > Note: this is based off of Linus's latest commit

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-20 Thread Tony Battersby
Update: Herbert's patch alters the arguments to alloc_skb_fclone() and skb_reserve() from within sk_stream_alloc_pskb(). This changes the skb_headroom() and skb_tailroom() of the returned skb. I decided to see if I could detect the precise point at which data corruption started to happen. The r

Re: [git patches] net driver fixes

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: > From: Jeff Garzik <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 11:55:57 -0500 > > > > > Note: this is based off of Linus's latest commit > > (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous > > submissions are now u

Re: [PATCH 2.6.25 0/8][BNX2X]: bugfixes and updates

2008-02-20 Thread David Miller
From: "Eliezer Tamir" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 19:33:47 +0200 > This patch-set updates several sections of the bnx2x driver. It is not appropriate to be adding features at this time to the 2.6.25 tree. Please wait for the opportunity to submit 2.6.26 bound patches for new featu

Re: [git patches] net driver fixes

2008-02-20 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 11:55:57 -0500 > > Note: this is based off of Linus's latest commit > (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous > submissions are now upstream (thanks!). The whole point of my not rebasing net-2.6 is so that yo

Re: [git patches] net driver updates

2008-02-20 Thread Jeff Garzik
Divy Le Ray wrote: Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/g

Re: [PATCH] sungem: remove superfluous variable

2008-02-20 Thread Joe Perches
On Wed, 2008-02-20 at 12:37 +0100, Johannes Berg wrote: > There's no need to have two variables called 'i' when one > suffices. Additional minor cleanups: tabs and style Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c index 9721279..8d52d20

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-20 Thread Jarek Poplawski
On Wed, Feb 20, 2008 at 04:02:52PM +, James Chapman wrote: ... > I tried your ppp_generic patch with only the hlist_lock bh patch in > pppol2tp and it seems to fix the ppp create/delete issue. However, when > I added much more traffic into the test (flood pings over ppp interfaces > while

Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...

2008-02-20 Thread Kok, Auke
Kok, Auke wrote: > Andrew Morton wrote: >> On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov <[EMAIL PROTECTED]> >> wrote: >> >>> ... and possibly reboot/poweroff (it flows by too fast to be legible). >>> >>> [ 8803.850634] ACPI: Preparing to enter system sleep state S3 >>> [ 8803.853141] Suspen

[PATCH] sungem: remove superfluous variable

2008-02-20 Thread Johannes Berg
There's no need to have two variables called 'i' when one suffices. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- drivers/net/sungem.c |1 - 1 file changed, 1 deletion(-) --- everything.orig/drivers/net/sungem.c2008-02-20 12:35:12.0 +0100 +++ everything/drivers/net/su

sungem triggers NAPI warning

2008-02-20 Thread Johannes Berg
I started getting this warning with recent kernels: [ 773.908927] [ cut here ] [ 773.908954] Badness at net/core/dev.c:2204 [ 773.908958] NIP: c0277960 LR: c0277948 CTR: c02b9948 [ 773.908963] REGS: ee8f1800 TRAP: 0700 Not tainted (2.6.25-rc2-00261-g54a6132-dirty) [

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-20 Thread Dave Hansen
On Mon, 2008-02-18 at 11:00 +0100, Jan-Bernd Themann wrote: > Dave Hansen <[EMAIL PROTECTED]> wrote on 15.02.2008 17:55:38: > > > I've been thinking about that, and I don't think you really *need* to > > keep a comprehensive map like that. > > > > When the memory is in a particular configuration

[PATCH 2.6.25 1/8][BNX2X]: fix spelling, some fashion policework, report PCI link

2008-02-20 Thread Eliezer Tamir
[BNX2X]: fix spelling, some fashion policework, report PCI link Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 272 ++- drivers/net/bnx2x.h |7 +- 2 files changed, 121 insertions(+), 158 deletions(-) diff --git a/d

Re: [PATCH] SUNRPC: Mark buffer used for debug printks with __maybe_unused

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 09:23 -0800, Joe Perches wrote: > On Wed, 2008-02-20 at 12:02 -0500, Trond Myklebust wrote: > > > #ifdef DEBUG > > > #define some_print_wrapper(fmt, arg...) \ > > > do { if (0) printk(KERN_DEBUG fmt, ##arg); } while (0) > > > #else > > > #define some_print_wrapper(fmt

[PATCH 2.6.25 3/8][BNX2X]: Fix FW client config and assert printing

2008-02-20 Thread Eliezer Tamir
[BNX2X]: Fix FW client config and assert printing Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 308 +++--- drivers/net/bnx2x.h | 11 +- 2 files changed, 170 insertions(+), 149 deletions(-) diff --git a/drivers/net/bnx2

[PATCH 2.6.25 4/8][BNX2X]: rework slowpath and hw attentions

2008-02-20 Thread Eliezer Tamir
[BNX2X]: rework slowpath and hw attentions Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 466 +++ drivers/net/bnx2x.h |3 - drivers/net/bnx2x_fw_defs.h |7 +- 3 files changed, 294 insertions(+), 182 del

[PATCH 2.6.25 6/8][BNX2X]: Xmit rework, add TSO6 and CSUM_HW support

2008-02-20 Thread Eliezer Tamir
[BNX2X]: Xmit rework, add TSO6 and CSUM_HW support Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c | 307 +++--- drivers/net/bnx2x.h | 18 +++ 2 files changed, 208 insertions(+), 117 deletions(-) diff --git a/drivers/net/bn

[PATCH 2.6.25 8/8][BNX2X]: add to MAINTAINERS

2008-02-20 Thread Eliezer Tamir
[BNX2X]: add to MAINTAINERS Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6680ec4..da69429 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -982,6 +982,12 @@ M: [EMAIL PR

[PATCH 2.6.25 7/8][BNX2X]: update version to 1.42.2

2008-02-20 Thread Eliezer Tamir
[BNX2X]: update version to 1.42.2 Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c index a213d67..fe96605 100644 --- a/drivers/net/bnx2x.c +++ b/drivers/net

[PATCH 2.6.25 0/8][BNX2X]: bugfixes and updates

2008-02-20 Thread Eliezer Tamir
Hello All, This patch-set updates several sections of the bnx2x driver. Patches 2-4 are a set that should not be applied partially. 1: fix spelling, some fashion policework, report PCI link Spelling corrections, style fixes and properly report the PCI link speed Many Thanks to Stephen Hemminger

[PATCH 2.6.25 5/8][BNX2X]: workaround for a PCI core bug

2008-02-20 Thread Eliezer Tamir
[BNX2X]: workaround for a PCI core bug Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]> --- drivers/net/bnx2x_init.h | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnx2x_init.h b/drivers/net/bnx2x_init.h index 04f93bf..dcaecc5 100644 --- a/drivers

Re: [PATCH] bonding: simplify code and get rid of warning

2008-02-20 Thread Stephen Hemminger
On Wed, 20 Feb 2008 08:57:56 -0800 Jay Vosburgh <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > >Get rid of warning and simplify code that looks up vlan tag. > >No need to get tag, then copy it. Also no need for a local status > >variable. > > Granted, the cur

Re: [PATCH] SUNRPC: Mark buffer used for debug printks with __maybe_unused

2008-02-20 Thread Joe Perches
On Wed, 2008-02-20 at 12:02 -0500, Trond Myklebust wrote: > > #ifdef DEBUG > > #define some_print_wrapper(fmt, arg...) \ > > do { if (0) printk(KERN_DEBUG fmt, ##arg); } while (0) > > #else > > #define some_print_wrapper(fmt, arg...) \ > > printk(KERN_DEBUG fmt, ##arg) > > #endif > Have

Re: [PATCH] SUNRPC: Mark buffer used for debug printks with __maybe_unused

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 08:36 -0800, Joe Perches wrote: > On Wed, 2008-02-20 at 16:35 +0100, Patrick McHardy wrote: > > Alternatively change the dprintk macro to behave similar like > > pr_debug() and mark things like svc_print_addr() __pure, which > > has the advantage that is still performs format

Re: [PATCH] SUNRPC: Mark buffer used for debug printks with __maybe_unused

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 19:27 +0300, Pavel Emelyanov wrote: > Patrick McHardy wrote: > > Joe Perches wrote: > >> On Wed, 2008-02-20 at 07:29 -0800, Joe Perches wrote: > >> > >>> fs/nfsd/nfsproc.c: char buf[RPC_MAX_ADDRBUFLEN]; > >>> Perhaps there should be a DECLARE_RPC_BUF(buf) macr

Re: [PATCH] bonding: simplify code and get rid of warning

2008-02-20 Thread Jay Vosburgh
Stephen Hemminger <[EMAIL PROTECTED]> wrote: >Get rid of warning and simplify code that looks up vlan tag. >No need to get tag, then copy it. Also no need for a local status >variable. Granted, the current code is suboptimal, but I don't see any warnings compiling this (gcc 4.1.2). What

[git patches] net driver fixes

2008-02-20 Thread Jeff Garzik
Note: this is based off of Linus's latest commit (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous submissions are now upstream (thanks!). Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive t

Re: [2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

2008-02-20 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6e9f619..963630c 100644 --- a/drivers/ne

Re: [PATCH] igb: Fix panic with NICs with 1000BASE-SX PHY

2008-02-20 Thread Jeff Garzik
Auke Kok wrote: From: Bill Hayes <[EMAIL PROTECTED]> This patch eliminates a kernel panic with the igb driver in 2.6.25-rc2 when running on a Intel 82575 Ethernet controller with a 1000BASE-SX PHY. The panic does not happen with the 1000BASE-T PHY, only with a SX connection. Signed-off-by

Re: [PATCH 1/1] sis190: read the mac address from the eeprom first

2008-02-20 Thread Jeff Garzik
Francois Romieu wrote: Reading a serie of zero from the cmos sram area do not work well with is_valid_ether_addr(). Let's read the mac address from the eeprom first as it seems more reliable. Fix for http://bugzilla.kernel.org/show_bug.cgi?id=9831 Signed-off-by: Francois Romieu <[EMAIL PROTECTE

Re: [PATCH v2.6.25] gianfar: don't pass NULL dev ptr to DMA ops

2008-02-20 Thread Jeff Garzik
Andy Fleming wrote: From: Becky Bruce <[EMAIL PROTECTED]> Change all dma op invocations in gianfar.c to actually pass in the device pointer. Currently, the value is ignored, but it will be used going forward as we implement archdata for 32-bit powerpc. Signed-off-by: Becky Bruce <[EMAIL PROTEC

Re: [patch 1/1] claw: make use of DIV_ROUND_UP

2008-02-20 Thread Jeff Garzik
applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tlan: add static to function definitions

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: The forward declarations were already marked static, make the definitions be static as well. Fixes the sparse warnings as well. drivers/net/tlan.c:1403:5: warning: symbol 'TLan_HandleInvalid' was not declared. Should it be static? drivers/net/tlan.c:1435:5: warning: symb

Re: [PATCH] update TULIP MAINTAINERS

2008-02-20 Thread Jeff Garzik
Grant Grundler wrote: Jeff, Kyle and I are co-maintaining tulip driver. Normally kyle will review my patchs and submit them. I'll deal with bugzilla.kernel.org bugs and try to resolve those bugs. thanks, grant Signed-off-by: Grant Grundler <[EMAIL PROTECTED]> applied this and the uli patch

Re: [PATCH resend] virtio_net: Fix oops on early interrupts - introduced by virtio reset code

2008-02-20 Thread Jeff Garzik
Christian Borntraeger wrote: Am Montag, 11. Februar 2008 schrieb Anthony Liguori: The reset support is in Linus's tree so we should try to push it for -rc2. You are right. My repository was borked. will push it to Jeff Garzik. Thanks Jeff can you schedule this fix into your network driver upd

Re: [PATCH] igb: fix legacy mode irq issue

2008-02-20 Thread Jeff Garzik
Auke Kok wrote: From: Andy Gospodarek <[EMAIL PROTECTED]> I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating: "DO NOT USE EIAME or IAME

Re: [PATCH] ehea: add kdump support

2008-02-20 Thread Jeff Garzik
Thomas Klein wrote: This patch adds kdump support to the ehea driver. As the firmware doesn't free resource handles automatically, the driver has to run an as simple as possible free resource function in case of a crash shutdown. The function iterates over two arrays freeing all resource handles

Re: [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.

2008-02-20 Thread Jeff Garzik
Scott Wood wrote: The lock acquisition in fs_ioctl() does not appear to actually be necessary, and thus is simply removed. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- This fixes the following bug: http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html drivers/net/fs_enet/fs_e

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Peter Zijlstra
On Wed, 2008-02-20 at 08:30 -0800, Randy Dunlap wrote: > On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: < grammar mistakes > Thanks Randy! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://

Re: [PATCH] SUNRPC: Mark buffer used for debug printks with __maybe_unused

2008-02-20 Thread Joe Perches
On Wed, 2008-02-20 at 16:35 +0100, Patrick McHardy wrote: > Alternatively change the dprintk macro to behave similar like > pr_debug() and mark things like svc_print_addr() __pure, which > has the advantage that is still performs format checking even > if debugging is disabled. I think it's better

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Randy Dunlap
On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > --- > Documentation/filesystems/Locking | 19 + > Documentation/filesystems/vfs.txt | 17 > include/linux/buffer_head.h |2 - > include/linux/fs.h

  1   2   3   >