Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread Jarek Poplawski
On Mon, Feb 11, 2008 at 11:41:18PM +, James Chapman wrote: > Jarek Poplawski wrote: >> On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: >> ... >>> Below is example output from lockdep. The oops is reproducible when >>> creating/deleting lots of sessions while passing data. The

Re: [git patches] net driver updates

2008-02-11 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 12:05:16 -0500 > Mostly fixes, a few cleanups (generally assisting fixes), and an > exception for PS3 wireless because it had been posted, reviewed and > acked for a while, just not committed. > > Please pull from 'upstream-davem' branch

Re: [PATCH][RFC] race in generic address resolution

2008-02-11 Thread David Miller
From: Frank Blaschka <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 10:01:20 +0100 > we run your patch during the weekend on single CPU and SMP > machines. We do not see any problems. Thanks for providing the fix. Thanks for testing Frank, I can now push this fix upstream. -- To unsubscribe from this

Re: [patch 6/7] hci_ldisc: fix null pointer deref

2008-02-11 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Tue, 05 Feb 2008 17:51:07 +0100 > Hi David, > > > > akpm: > > > > > > No idea. trollmerge. > > > > > > Cc: Arjan van de Ven <[EMAIL PROTECTED]> > > > Cc: Alan Cox <[EMAIL PROTECTED]> > > > Cc: Marcel Holtmann <[EMAIL PROTECTED]> > > > Signed-of

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-11 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 09:14:13 + > [AX25] ax25_ds_timer: use mod_timer instead of add_timer > > This patch changes current use of: init_timer(), add_timer() > and del_timer() to setup_timer() with mod_timer(), which > should be safer anyway. > > > R

Re: [PATCH][AX25] Fwd: SMP with AX.25

2008-02-11 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 08:15:09 + > On Wed, Feb 06, 2008 at 07:45:29AM +, Jarek Poplawski wrote: > ... > > From: Jann Traschewski <[EMAIL PROTECTED]> > > Subject: SMP with AX.25 > > > [AX25] ax25_timer: use mod_timer instead of add_timer > > Acco

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 23:41:18 + > Jarek Poplawski wrote: > > On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: > > ... > >> Below is example output from lockdep. The oops is reproducible when > >> creating/deleting lots of sessions while

Re: [PATCH][AX25] ax25_route: make ax25_route_lock BH safe

2008-02-11 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 12:42:51 + > [AX25] ax25_route: make ax25_route_lock BH safe > > > = > > [ INFO: inconsistent lock state ] > > 2.6.24-dg8ngn-p02 #1 > > - > > inconsistent {softirq-

Re: [PATCH v2][AX25] af_ax25: remove sock lock in ax25_info_show()

2008-02-11 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Sun, 10 Feb 2008 14:10:51 +0100 > [AX25] af_ax25: remove sock lock in ax25_info_show() > > This lockdep warning: > > > === > > [ INFO: possible circular locking dependency detected ] > > 2.6.24 #

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread David Miller
From: "Paul E. McKenney" <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 17:27:41 -0800 > On Mon, Feb 11, 2008 at 04:59:54PM -0800, Stephen Hemminger wrote: > > Eliminate warnings when rcu_assign_pointer is used with unsigned long. > > It is reasonable to use RCU with non-pointer values so allow it for

Re: [PATCH 2/2] fib_trie: /proc/net/route performance improvement

2008-02-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 17:16:59 -0800 > Use key/offset caching to change /proc/net/route (use by iputils route) > from O(n^2) to O(n). This improves performance from 30sec with 160,000 > routes to 1sec. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTE

Re: [PATCH 1/2] fib_trie: handle empty tree

2008-02-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 17:12:50 -0800 > To: David S. Miller <[EMAIL PROTECTED]> When a user's name has "special" characters such as a "." as mine does, it must be surrounded by double-quotes or else it is a syntax error by SMTP rules. For this reason

[PATCH] [RFC] Smack: unlabeled outgoing ambient packets - v2

2008-02-11 Thread Casey Schaufler
From: Casey Schaufler <[EMAIL PROTECTED]> Smack uses CIPSO labeling, but allows for unlabeled packets by specifying an "ambient" label that is applied to incoming unlabeled packets. Because the other end of the connection may dislike IP options, and ssh is one know application that behaves thus,

[PATCH]: Remove IP_TOS privilege checks

2008-02-11 Thread David Miller
I've committing the following upstream, for the reasons outlined in the commit message. These DSCP value meanings are advisory and the kernel is not the entity to enforce what values mean. This change makes us behave consistently with BSD and with our own IPV6 implementation, yet without breakin

[PATCH 2.6.25] ixgbe/igb: correctly obtain protocol information on transmit

2008-02-11 Thread Andy Gospodarek
I noticed a strange panic on a box with an ixgbe-based interface when using bridging. Protocol information ought to come from the frame itself rather than anywhere else. The igb driver has a similar coding error that would cause incorrect flags to be set, so it would not panic. It should still

[PATCH 4/4] docbook: make a networking book and fix a few errors

2008-02-11 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Move networking (core and drivers) docbook to its own networking book. Fix a few kernel-doc errors in header and source files. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- Documentation/DocBook/Makefile|2 Documentation/DocBook/kernel-ap

[PATCH 2/4] docbook: sunrpc filenames and notation fixes

2008-02-11 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Use updated file list for docbook files and fix kernel-doc warnings in sunrpc: Warning(linux-2.6.24-git12//net/sunrpc/rpc_pipe.c:689): No description found for parameter 'rpc_client' Warning(linux-2.6.24-git12//net/sunrpc/rpc_pipe.c:765): No description foun

[PATCH] [RFC] Smack: unlabeled outgoing ambient packets - v2

2008-02-11 Thread Casey Schaufler
From: Casey Schaufler <[EMAIL PROTECTED]> Smack uses CIPSO labeling, but allows for unlabeled packets by specifying an "ambient" label that is applied to incoming unlabeled packets. Because the other end of the connection may dislike IP options, and ssh is one know application that behaves thus,

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread Paul E. McKenney
On Mon, Feb 11, 2008 at 04:59:54PM -0800, Stephen Hemminger wrote: > Eliminate warnings when rcu_assign_pointer is used with unsigned long. > It is reasonable to use RCU with non-pointer values so allow it for general > use. Add a comment to explain the if test. Good catch!!! (An apologies for t

Re: [Bugme-new] [Bug 9937] New: Bug in bonding driver - Kernel oops whenever driver is loaded with max_bonds parameter

2008-02-11 Thread Jay Vosburgh
Andrew Morton <[EMAIL PROTECTED]> wrote: >> Problem Description: Kernel oops whenever bonding driver with max_bonds=2 >> (or > >> 2) is loaded ... I believe this is fixed by the following (from linux-2.6): From: Jay Vosburgh <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 18:07:45 -0800 Subj

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 16:59:54 -0800 linux-kernel added to CC:, any change to generic kernel infrastructure should be posted there > Eliminate warnings when rcu_assign_pointer is used with unsigned long. > It is reasonable to use RCU with non-pointer v

Re: [Bugme-new] [Bug 9937] New: Bug in bonding driver - Kernel oops whenever driver is loaded with max_bonds parameter

2008-02-11 Thread Andrew Morton
On Mon, 11 Feb 2008 15:04:03 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9937 > >Summary: Bug in bonding driver - Kernel oops whenever driver is > loaded with max_bonds parameter >Product: Networking >Ve

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread James Chapman
Jarek Poplawski wrote: On Mon, Feb 11, 2008 at 11:49:24PM +0100, Jarek Poplawski wrote: On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: ... Below is example output from lockdep. The oops is reproducible when creating/deleting lots of sessions while passing data. The lock is bein

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread James Chapman
Jarek Poplawski wrote: On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: ... Below is example output from lockdep. The oops is reproducible when creating/deleting lots of sessions while passing data. The lock is being acquired for read and write in softirq contexts. Is there a

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread Jarek Poplawski
On Mon, Feb 11, 2008 at 11:49:24PM +0100, Jarek Poplawski wrote: > On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: > ... > > Below is example output from lockdep. The oops is reproducible when > > creating/deleting lots of sessions while passing data. The lock is being > > acquir

Re: [PATCH] Execute tasklets in the same order they were queued

2008-02-11 Thread Andrew Morton
On Mon, 11 Feb 2008 16:28:13 -0600 Olof Johansson <[EMAIL PROTECTED]> wrote: > I noticed this when looking at an openswan issue. Openswan (ab?)uses > the tasklet API to defer processing of packets in some situations, > with one packet per tasklet_action(). I started noticing sequences of > reverse

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread Jarek Poplawski
On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: ... > Below is example output from lockdep. The oops is reproducible when > creating/deleting lots of sessions while passing data. The lock is being > acquired for read and write in softirq contexts. > > Is there a better way to fix

Re: [PATCH] mlx4: needs vmalloc.h for vmap()

2008-02-11 Thread Roland Dreier
thanks, just merged the same patch from Olof Johansson. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: WARN_ON() hit in fsl bitbanged phy driver

2008-02-11 Thread Scott Wood
Rune Torgersen wrote: Scott Wood wrote: Rune Torgersen wrote: I hit the following WARN_ON when using mii-tools agains a ethernet interface using a bit-banged mii interface It looks like the kernel thinks it's in an interrupt, even though it clearly isn't from the backtrace. Presumably, someth

[PATCH] mlx4: needs vmalloc.h for vmap()

2008-02-11 Thread Kyle McMartin
Commit 313abe55a87bc10e55d00f337d609e17ad5f8c9a added a vmap usage to mlx4. Unfortunately on some platforms (ppc64) is not implicitly included. Fix that. Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c index 521dc03..75ef9d0 1

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread James Chapman
Jarek Poplawski wrote: James Chapman wrote, On 02/11/2008 10:22 AM: Fix locking issues in the pppol2tp driver which can cause a kernel crash on SMP boxes when hundreds of L2TP sessions are created/deleted simultaneously (ISP environment). The driver was violating read_lock() and write_lock() sc

RE: WARN_ON() hit in fsl bitbanged phy driver

2008-02-11 Thread Rune Torgersen
Scott Wood wrote: > Rune Torgersen wrote: >> I hit the following WARN_ON when using mii-tools agains a ethernet >> interface using a bit-banged mii interface > > It looks like the kernel thinks it's in an interrupt, even though it > clearly isn't from the backtrace. Presumably, something > slept

WARN_ON() hit in fsl bitbanged phy driver

2008-02-11 Thread Rune Torgersen
I hit the following WARN_ON when using mii-tools agains a ethernet interface using a bit-banged mii interface It is only diplayed once, and does not seem to impact usage at all Does somebody know what is wrong, and how to fix it? The PHY is an Intel LXT973 Badness at kernel/softirq.c:139 NIP: c00

Re: WARN_ON() hit in fsl bitbanged phy driver

2008-02-11 Thread Scott Wood
Rune Torgersen wrote: I hit the following WARN_ON when using mii-tools agains a ethernet interface using a bit-banged mii interface It is only diplayed once, and does not seem to impact usage at all Does somebody know what is wrong, and how to fix it? It looks like the kernel thinks it's in an

An ioctl to delete an ipv6 tunnel leads to a kernel panic

2008-02-11 Thread Natalie Protasevich
Hello, This bug was reported to bugzilla.kernel.org: http://bugzilla.kernel.org/show_bug.cgi?id=8895 Hardware Environment: user mode linux and vmware Software Environment: an evolution of mip6d (ip mobility daemon) Problem Description: The mip6d HA was modified to make a redondancy evolut

Re: [patch 2.6.24-git] net/enc28j60: oops fix, low power mode

2008-02-11 Thread David Brownell
On Monday 11 February 2008, Claudio Lanconelli wrote: > I have tried your latest patch. Only after the following change it > works fine (no more rx errors during ifconfig up). Hmm, what chip rev do you have? Different errata and all. ISTR mine is rev4; so, not the most current, but not the oldest

Re: [git patches] net driver updates

2008-02-11 Thread Divy Le Ray
Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.

RE: [Patch 2.6.24 1/3]S2io: Support for vlan_rx_kill_vid entry point

2008-02-11 Thread Ramkrishna Vepa
Reply inline - > Subject: Re: [Patch 2.6.24 1/3]S2io: Support for vlan_rx_kill_vid entry > point > > Sreenivasa Honnur wrote: > > - Added s2io_vlan_rx_kill_vid entry point function for unregistering > vlan. > > - Fix to aggregate vlan packets. IP offset is incremented by > > 4 bytes if the pack

Re: [PATCH 1/6] [NET] replace code with FIELD_SIZEOF

2008-02-11 Thread Jeff Garzik
Auke Kok wrote: From: Julia Lawall <[EMAIL PROTECTED]> Signed-off-by: Julia Lawall <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |2 +- drivers/net/igb/igb_ethtool.c |2 +- drivers/net/ixgb/ixgb_ethtool.c |2 +- 3 files

Re: [PATCH 3/5 v3] Tsi108_eth: remove not needed code

2008-02-11 Thread Jeff Garzik
Alex Bounine wrote: Code clean-up for tsi108_eth network driver. This patch removes not needed dummy read and the corresponding comment. The PHY logic requires two reads from the status register to get current link status. This is done correctly inside mii_check_media(). Signed-off-by: Alexandre

Re: [PATCH] [IPV4]: Remove warning in node_set_parent.

2008-02-11 Thread Stephen Hemminger
On Mon, 11 Feb 2008 11:47:17 +0300 "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > net/ipv4/fib_trie.c: In function 'node_set_parent': > net/ipv4/fib_trie.c:184: warning: assignment makes integer from pointer > without a cast > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> > --- > net/ipv4/f

Re: [BUG] bad address in twothirdsMD4Transform

2008-02-11 Thread Jiri Slaby
On 02/11/2008 08:42 PM, Matt Mackall wrote: BUG: unable to handle kernel paging request at 8102366213f8 IP: [] twothirdsMD4Transform+0xc4/0x3b0 You should mention what kernel you're using. Kernel version is in the bug below modules and above registers. This bug is only in -mm (you didn

Re: [BUG] bad address in twothirdsMD4Transform

2008-02-11 Thread Matt Mackall
On Mon, 2008-02-11 at 20:29 +0100, Jiri Slaby wrote: > Hi, > > I get this with 32 bit Firefox 3b2 and java 1.6.0_03 on 64 bit: > > BUG: unable to handle kernel paging request at 8102366213f8 > IP: [] twothirdsMD4Transform+0xc4/0x3b0 You should mention what kernel you're using. This bug is on

[PATCH 5/5 v3] Tsi108_eth: Add ethtool support

2008-02-11 Thread Alex Bounine
Add ethtool support to tsi108_eth network driver. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/tsi108_eth.c 2008-02-06 17:10:53.0 -0500 +++ linux-2.6.

[PATCH 4/5 v3] Tsi108_eth: fix link recovery after disconnect

2008-02-11 Thread Alex Bounine
Bug fix for tsi108_eth network driver. This patch fixes a problem with link recovery after connection was lost. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/tsi108_e

[PATCH 3/5 v3] Tsi108_eth: remove not needed code

2008-02-11 Thread Alex Bounine
Code clean-up for tsi108_eth network driver. This patch removes not needed dummy read and the corresponding comment. The PHY logic requires two reads from the status register to get current link status. This is done correctly inside mii_check_media(). Signed-off-by: Alexandre Bounine <[EMAIL PROTE

[PATCH 2/5 v3] Tsi108_eth: fix detection of 1000Mb mode

2008-02-11 Thread Alex Bounine
Bug fix for tsi108_eth network driver. This patch fixes a problem with detection of 1000Mb speed. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/tsi108_eth.c 200

[PATCH 1/5 v3] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Alex Bounine
Bug fix for tsi108_eth network driver. This patch adds missing linking to driver data. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/tsi108_eth.c 2008-01-24 17:

[BUG] bad address in twothirdsMD4Transform

2008-02-11 Thread Jiri Slaby
Hi, I get this with 32 bit Firefox 3b2 and java 1.6.0_03 on 64 bit: BUG: unable to handle kernel paging request at 8102366213f8 IP: [] twothirdsMD4Transform+0xc4/0x3b0 PGD 8063 PUD 0 Oops: [1] SMP last sysfs file: /sys/devices/virtual/net/tun0/statistics/collisions CPU 1 Modules linked

Re: AW: Problem receiving multicast/promiscuous-mode with kernel.2.6.24

2008-02-11 Thread David Stevens
Another relevant piece of information is what the socket is bound to; "netstat -au" will tell you if you're bound to an address that will match the incoming multicast packets. If you suspect that the VLAN device is the problem, then it'd be a good idea to try it on ordinary ethernet. Re: imr_ifin

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread Jarek Poplawski
James Chapman wrote, On 02/11/2008 10:22 AM: > Fix locking issues in the pppol2tp driver which can cause a kernel > crash on SMP boxes when hundreds of L2TP sessions are created/deleted > simultaneously (ISP environment). The driver was violating read_lock() > and write_lock() scheduling rules so

Re: [2.6 patch] olympic_open() must be __devinit

2008-02-11 Thread Mike Phillips
On Wed, Jan 30, 2008 at 10:02:07PM +0200, Adrian Bunk wrote: > This patch fixes the following section mismatch: > > <-- snip --> > > ... > WARNING: drivers/net/built-in.o(.text+0x155573): Section mismatch in > reference from the function olympic_open() to the function > .devinit.text:olympic_

Re: [Bugme-new] [Bug 9933] New: kernel BUG at include/linux/skbuff.h:912

2008-02-11 Thread Andrew Morton
On Mon, 11 Feb 2008 03:46:45 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9933 > >Summary: kernel BUG at include/linux/skbuff.h:912 >Product: Networking >Version: 2.5 > KernelVersion: 2.6.24.2 > Platform: All

[PATCH 4/6] ixgbe: warn when device is in a x4 or lower width slot

2008-02-11 Thread Auke Kok
It's easy to oversee this issue when working with this card as evrything will work OK but performance is severely limited (something like 1.5gbit on a x1 link) if the pci-express slot does not offer more bandwidth. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe_main.c |

[PATCH 2/6] e1000: warn if this driver is used for e1000e devices

2008-02-11 Thread Auke Kok
We're already starting to see reports from users still using e1000 where they should be using e1000e now that this is actually possible. Just to prevent some of this thrash, add a big warning on load on these devices that people should switch to e1000e. Signed-off-by: Auke Kok <[EMAIL PROTECTED]>

[PATCH 5/6] ixgbe: Disallow device reset during ethtool test

2008-02-11 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 576fb51..a4aeaec 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drive

[PATCH 6/6] ixgbe: remove accidentally added #ifdef

2008-02-11 Thread Auke Kok
Let's not add these #ifdef NETIF_F_TSO's back. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe_main.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index a4aeaec..540b647 100644

[PATCH 1/6] [NET] replace code with FIELD_SIZEOF

2008-02-11 Thread Auke Kok
From: Julia Lawall <[EMAIL PROTECTED]> Signed-off-by: Julia Lawall <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |2 +- drivers/net/igb/igb_ethtool.c |2 +- drivers/net/ixgb/ixgb_ethtool.c |2 +- 3 files changed, 3 inserti

[PATCH 3/6] e1000e: Fix logic reversal keeping link active

2008-02-11 Thread Auke Kok
A logic mishap caused the adapter to keep link while we can disable it due to WoL not being active, and vice versa. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/

Re: [patch 1/2] qeth: new qeth device driver

2008-02-11 Thread Paul E. McKenney
On Mon, Feb 11, 2008 at 08:55:41AM +0100, Frank Blaschka wrote: > Paul E. McKenney schrieb: > > On Fri, Feb 08, 2008 at 03:10:00PM +0100, [EMAIL PROTECTED] wrote: > >> From: Frank Blaschka <[EMAIL PROTECTED]> > >> > >> List of major changes and improvements: > >> no manipulation of the global ARP

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Dave Hansen
On Mon, 2008-02-11 at 17:24 +0100, Jan-Bernd Themann wrote: > Drivers like eHEA need memory notifiers in order to > update their internal DMA memory map when memory is added > to or removed from the system. > > Patch for eHEA memory hotplug support that uses these functions: > http://www.spinics.

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Dave Hansen
On Mon, 2008-02-11 at 17:24 +0100, Jan-Bernd Themann wrote: > the eHEA patch belongs to a patchset that is usually > added by Jeff Garzik once this dependency (EXPORTS) > is resolved. I know that's already in mainline but, man, that code is nasty. It has stuff indented 7 levels or so and is vi

Re: [PATCH 1/5 v2] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Jeff Garzik
Alexandre Bounine wrote: Bug fix for tsi108_eth network driver. This patch adds missing linking to driver data. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/t

[PATCH 5/5 v2] Tsi108_eth: Add ethtool support

2008-02-11 Thread Alexandre Bounine
Add ethtool support to tsi108_eth network driver. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/tsi108_eth.c 2008-02-06 17:10:53.0 -0500 +++ linux-2.

[PATCH 4/5 v2] Tsi108_eth: fix link recovery after disconnect

2008-02-11 Thread Alexandre Bounine
Bug fix for tsi108_eth network driver. This patch fixes a problem with link recovery after connection was lost. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/tsi10

[PATCH 3/5 v2] Tsi108_eth: remove not needed code

2008-02-11 Thread Alexandre Bounine
Code clean-up for tsi108_eth network driver. This patch removes not needed dummy read and the corresponding comment. The PHY logic requires two reads from the status register to get current link status. This is done correctly inside mii_check_media(). Signed-off-by: Alexandre Bounine <[EMAIL

[PATCH 2/5 v2] Tsi108_eth: fix detection of 1000Mb mode

2008-02-11 Thread Alexandre Bounine
Bug fix for tsi108_eth network driver. This patch fixes a problem with detection of 1000Mb speed. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/tsi108_eth.c

[PATCH 1/5 v2] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Alexandre Bounine
Bug fix for tsi108_eth network driver. This patch adds missing linking to driver data. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/tsi108_eth.c 2008-01-24

Re: [PATCH] [RESENDING] netconsole: register cmdline netconsole configs to configfs

2008-02-11 Thread Matt Mackall
On Mon, 2008-02-11 at 18:08 +0900, Joonwoo Park wrote: > This patch intorduces cmdline netconsole configs to register to > configfs > with dynamic netconsole. Satyam Sharma who designed shiny dynamic > reconfiguration for netconsole, mentioned about this issue already. > (http://lkml.org/lkml/2007

[PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann
Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Patch for eHEA memory hotplug support that uses these functions: http://www.spinics.net/lists/netdev/msg54484.html Signed-off-by: Jan-Bernd Themann <[EMAIL

Re: [patch 1/5] claw: removal of volatile variables

2008-02-11 Thread Jeff Garzik
applied 1-5 to #upstream-fixes (2.6.25) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/5] resend forcedeth: tx pause watermarks

2008-02-11 Thread Jeff Garzik
Ayaz Abdulla wrote: New chipsets introduced variant Rx FIFO sizes that need to be taken into account when setting up the tx pause watermarks. This patch introduces the new device feature flags based on a version and implements the new watermarks. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]

Re: [PATCH 2/5] resend forcedeth: tx collision fix

2008-02-11 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch supports a new fix in hardware regarding tx collisions. In the cases where we are in autoneg mode and the link partner is in forced mode, we need to setup the tx deferral register differently in order to reduce collisions on the wire. Signed-off-by: Ayaz Abdulla

Re: [Patch 2.6.24 1/3]S2io: Support for vlan_rx_kill_vid entry point

2008-02-11 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Added s2io_vlan_rx_kill_vid entry point function for unregistering vlan. - Fix to aggregate vlan packets. IP offset is incremented by 4 bytes if the packet contains vlan header. - resubmit for 2.6.24 kernel Signed-off-by: Surjit Reang <[EMAIL PROTECTED]> Signed-off-b

Re: [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale.

2008-02-11 Thread Jeff Garzik
Steve Wise wrote: cxgb3: Handle ARP completions that mark neighbors stale. When ARP completes due to a request rather than a reply the neighbor is marked NUD_STALE instead of reachable (see arp_process()). The handler for the resulting netevent needs to check also for NUD_STALE. Failure to use

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-02-11 Thread Jeff Garzik
Josh Boyer wrote: On Wed, 6 Feb 2008 13:21:59 +0100 Stefan Roese <[EMAIL PROTECTED]> wrote: With the removal the the "rgmii-interface" device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese <[EMAIL PROTECTED

Re: Pull request for 'r6040' branch

2008-02-11 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'r6040' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git r6040 to get the changes below. I have simply rebased the r6040 branch from december on top of Linus's latest head and given each patch a compile test. The c

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 7 Feb 2008 21:49:26 -0800), Glenn Griffin <[EMAIL PROTECTED]> says: > Updated to incorporate Eric's suggestion of using a per cpu buffer > rather than allocating on the stack. Just a two line change, but will > resend in it's entirety. > > Signed-off-by:

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Dave Hansen
On Mon, 2008-02-11 at 16:57 +0100, Jan-Bernd Themann wrote: > Drivers like eHEA need memory notifiers in order to > update their internal DMA memory map when memory is added > to or removed from the system. Could you post this with the new users as well so we can make sure they're not abusing thi

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Sam Ravnborg
On Mon, Feb 11, 2008 at 04:57:06PM +0100, Jan-Bernd Themann wrote: > Drivers like eHEA need memory notifiers in order to > update their internal DMA memory map when memory is added > to or removed from the system. Can you please add proper kernel-doc formatted comments when you export a symbol so

Re: [patch 1/2] qeth: new qeth device driver

2008-02-11 Thread Jeff Garzik
please resend on top of the ctc driver update... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 1/3] drivers/s390/net: Kconfig brush up

2008-02-11 Thread Jeff Garzik
applied 1-3 to #upstream (2.6.26) Even the initial revision was outside the merge window, so it was never going to make 2.6.25, thus I waited a bit for further comments and revisions -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTEC

[PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann
Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- Hi, this is the modified version with EXPORT_SYMBOL_GPL Regards, Jan-Bernd drivers/base/

Re: [PATCH 10/10] atl1: reduce forward declarations

2008-02-11 Thread Jeff Garzik
applied 1-10 to #upstream (2.6.26) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] remove the obsolete xircom_tulip_cb driver

2008-02-11 Thread Jeff Garzik
Adrian Bunk wrote: The xircom_tulip_cb driver has been replaced the xircom_cb driver, and since it depended on BROKEN_ON_SMP it e.g. was no longer present in many distribution kernels. This patch therefore removes it. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/tulip/Kco

Re: [PATCH] sk98lin: remove obsolete driver

2008-02-11 Thread Jeff Garzik
applied to #upstream (2.6.26) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

AW: Problem receiving multicast/promiscuous-mode with kernel.2.6.24

2008-02-11 Thread Reither Robert
Visit AVD on prolight+sound in Frankfurt from 12.-15. March 2008 - Hall 8.0, Stand G16 OK, after some more testing, things become clearer ... joining eth0.3 gives this strange unreliable behaviour... Joining eth0 , and

Re: [PATCH 2/2] tulip: hardware mitigation simplify

2008-02-11 Thread Jeff Garzik
Jeff Garzik wrote: Stephen Hemminger wrote: The hardware mitigation in tulip can be simpified. 1. The budget with new NAPI will always be less than RX_RING_SIZE because RX_RING_SIZE is 128 and weight is 16. 2. The received counter is redundunt, just use the work_done value. 3. Only one value

[PATCH] virtio_net: Fix oops on early interrupts - introduced by virtio reset code

2008-02-11 Thread Christian Borntraeger
Am Montag, 11. Februar 2008 schrieb Anthony Liguori: > The reset support is in Linus's tree so we should try to push it for -rc2. You are right. My repository was borked. will push it to Jeff Garzik. Thanks Jeff can you schedule this fix into your network driver updates? Thanks --- With the lat

Re: [patch] pegasus.c

2008-02-11 Thread Jeff Garzik
Petko Manolov wrote: Hi Jeff, Attached you'll find a patch that is fixing a driver bug triggered when malformed string is passed to the 'devid' module parameter. The expected format is: "device_name:vendor_id:device_id:flags" but it turned out people often type: "somename::0"

Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

2008-02-11 Thread Greg KH
On Mon, Feb 11, 2008 at 11:47:50AM +0100, Jan-Bernd Themann wrote: > On Monday 11 February 2008 11:12, Dave Hansen wrote: > > On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote: > > > are you the right person to address this patch to? > > > > You might want to check the top of the file. ;)

Re: [PATCH 2/2] tulip: hardware mitigation simplify

2008-02-11 Thread Jeff Garzik
Stephen Hemminger wrote: The hardware mitigation in tulip can be simpified. 1. The budget with new NAPI will always be less than RX_RING_SIZE because RX_RING_SIZE is 128 and weight is 16. 2. The received counter is redundunt, just use the work_done value. 3. Only one value is used from the mit

Re: [PATCH 1/7] PS3: gelic: Fix the wrong dev_id passed

2008-02-11 Thread Jeff Garzik
Masakazu Mokuno wrote: PS3: gelic: Fix the wrong dev_id passed The device id for lv1_net_set_interrupt_status_indicator() is wrong. This path would be invoked only in the case of an initialization failure. Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]> --- drivers/net/ps3_gelic_net.c |

Re: [PATCH 2.6.24] pcnet32: use NET_IP_ALIGN instead of 2

2008-02-11 Thread Jeff Garzik
Don Fry wrote: Change hard coded 2 to NET_IP_ALIGN. Added new #define with comments. Tested amd_64 Signed-off-by: Don Fry <[EMAIL PROTECTED]> applied both -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] virtio_net: Fix oops on early interrupts - introduced by virtio reset code

2008-02-11 Thread Anthony Liguori
Christian Borntraeger wrote: Avi, this fixes a problem that was introduced by the virtio_reset patches. Can you apply that fix to kvm.git as a bugfix, as the virtio_reset infrastructure is not on Linus upstream yet? The reset support is in Linus's tree so we should try to push it for -rc2

Re: [PATCH 1/5] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Jeff Garzik
Alexandre Bounine wrote: Bug fix for tsi108_eth network driver. This patch adds missing linking to driver data. Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> --- diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c linux-2.6.24-fix/drivers/net/tsi108_eth.c --- linux-2.6.24/drivers/net/t

Re: oops with ipcomp

2008-02-11 Thread Beschorner Daniel
> Does every packet from A trigger the crash? In my last test the crash was triggered after 300MB of http output (on the fifth run of a script downloading the same 60MB of data). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

AW: Problem receiving multicast/promiscuous-mode with kernel.2.6.24

2008-02-11 Thread Reither Robert
Visit AVD on prolight+sound in Frankfurt from 12.-15. March 2008 - Hall 8.0, Stand G16 Hi David, thanks for your help. Your input is always welcome ;-) But according to Linux Programmer's Manual it should be OK to use ifi

Re: Protocol handler for Marvell DSA EtherType packets

2008-02-11 Thread Jesper Dangaard Brouer
Hi NetDev and Google, The answer to my question was: Aha, you are trying to use tcpdump to see the "encapsulated" packets, then you also need to adjust skb->mac.raw. I have attached the code (and inlined the receive func, for easier commenting), as I have another question: I use dev_get_by_inde

[PATCH] virtio_net: Fix oops on early interrupts - introduced by virtio reset code

2008-02-11 Thread Christian Borntraeger
Avi, this fixes a problem that was introduced by the virtio_reset patches. Can you apply that fix to kvm.git as a bugfix, as the virtio_reset infrastructure is not on Linus upstream yet? Anthony, Dor, are you ok with that change? -- With the latest virtio_reset patches I got the following oops

  1   2   >