Re: [PATCH][NET_SCHED] sch_htb: htb_requeue fix

2008-02-09 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 08:57:49 + > htb_requeue() enqueues skbs for which htb_classify() returns NULL. > This is wrong because such skbs could be handled by NET_CLS_ACT code, > and the decision could be different than earlier in htb_enqueue(). > So htb_

Re: [PATCH] [IPV6] Replace using the magic constant "1024" with IP6_RT_PRIO_USER for fc_metric.

2008-02-09 Thread David Miller
From: "Rami Rosen" <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 12:14:18 +0200 > This patch replaces the explicit usage of the magic constant "1024" > with IP6_RT_PRIO_USER in the IPV6 tree. > > Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> Applied, thanks. -- To unsubscribe from this list: send

Re: [patch 6/7] starfire secton fix

2008-02-09 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 08 Feb 2008 03:11:16 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > gcc-3.4.4 on powerpc: > > drivers/net/starfire.c:219: error: version causes a section type conflict > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Cc: Sam Ravnborg <[EMAIL PROTECTED]> > Signed

Re: [patch 2/7] natsemi section fix

2008-02-09 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 08 Feb 2008 03:11:15 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > gcc-3.4.4 on powerpc: > > drivers/net/natsemi.c:245: error: natsemi_pci_info causes a section type > conflict > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Cc: Sam Ravnborg <[EMAIL PROTECTED

Re: [patch 5/7] via-velocity section fix

2008-02-09 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 08 Feb 2008 03:11:16 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > gcc-3.4.4 on powerpc: > > drivers/net/via-velocity.c:443: error: chip_info_table causes a section type > conflict > > on this one I had to remove the __devinitdata too. Don't know why.

Re: [patch 1/7] typhoon section fix

2008-02-09 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 08 Feb 2008 03:11:13 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > gcc-3.4.4 on powerpc: > > drivers/net/typhoon.c:137: error: version causes a section type conflict > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Cc: Sam Ravnborg <[EMAIL PROTECTED]> > Signed-

Re: [PATCH] isdn: fix section mismatch warnings from hisax_cs_setup_card

2008-02-09 Thread David Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 21:00:01 +0100 > Fix the following warnings: ... > > checkcard() are the only user of hisax_cs_setup_card(). > And checkcard is only used during init or when hot plugging > ISDN devices. So annotate hisax_cs_setup_card() with __devini

Re: [PATCH] isdn: fix section mismatch warning for ISACVer

2008-02-09 Thread David Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 21:00:02 +0100 > Fix following warnings: > WARNING: drivers/isdn/hisax/built-in.o(.text+0x19723): Section mismatch in > reference from the function ISACVersion() to the variable > .devinit.data:ISACVer > WARNING: drivers/isdn/hisax/bu

Re: [PATCH] isdn: fix section mismatch warnings in isac.c and isar.c

2008-02-09 Thread David Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 21:00:03 +0100 > Fix the following warnings: ... > > initisar(), initisac() and clear_pending_isac_ints() > were all used via a cardmsg fnction - which may be called > ouside __devinit context. > So remove the bogus __devinit annotati

Re: [PATCH] isdn: fix section mismatch warning in hfc_sx.c

2008-02-09 Thread David Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 21:00:04 +0100 > Fix the following warning: > WARNING: drivers/isdn/hisax/built-in.o(.text+0x35818): Section mismatch in > reference from the function hfcsx_card_msg() to the function > .devinit.text:inithfcsx() > > hfcsx_card_msg()

Re: [PKT_SCHED] ematch: tcf_em_destroy robustness

2008-02-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 10:48:32 -0800 > Make the code in tcf_em_tree_destroy more robust and cleaner: > * Don't need to cast pointer to kfree() or avoid passing NULL. > * After freeing the tree, clear the pointer to avoid possible problems > from repeat

Re: [PKT_SCHED] deinline functions in meta match

2008-02-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 09:55:57 -0800 > A couple of functions in meta match don't need to be inline. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH 2/2][SCTP]: Convert sctp_dbg_objcnt to seq files.

2008-02-09 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 08 Feb 2008 10:00:23 -0500 > Pavel Emelyanov wrote: > > This makes the code use a good proc API and the text ~50 bytes shorter. > > > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > > Acked-by: Vlad Yasevich <[EMAIL PROTECTED]> Applied.

Re: [PATCH 1/2][SCTP]: Use snmp_fold_field instead of a homebrew analogue.

2008-02-09 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 08 Feb 2008 09:59:54 -0500 > Pavel Emelyanov wrote: > > SCPT already depends in INET, so this doesn't create additional > > dependencies. > > > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > > Acked-by: Vlad Yasevich <[EMAIL PROTECTED]>

Re: [PATCH] [IGMP]: Optimize kfree_skb in igmp_rcv.

2008-02-09 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 17:14:17 +0300 > Merge error paths inside igmp_rcv. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Applied, but this kind of cleanup is borderline during this time period. Please queue such things up for when I open up net

Re: [PATCH 2/2][KEY]: Convert net/pfkey to use seq files.

2008-02-09 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 08 Feb 2008 15:14:06 +0300 > The seq files API disposes the caller of the difficulty of > checking file position, the length of data to produce and > the size of provided buffer. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied,

Re: [patch 7/7] pppol2tp: fix printk warnings

2008-02-09 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 08 Feb 2008 03:11:17 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> ... > Not all platforms implement u64 with unsigned long long. eg: powerpc. > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Applied. -- To unsubscr

Re: [PATCH 1/2][KEY]: Clean up proc files creation a bit.

2008-02-09 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 08 Feb 2008 15:11:32 +0300 > Mainly this removes ifdef-s from inside the ipsec_pfkey_init. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [patch 4/7] bnx2.c section fix

2008-02-09 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 08 Feb 2008 03:11:15 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > gcc-3.4.4 on powerpc: > > drivers/net/bnx2.c:67: error: version causes a section type conflict > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Cc: Sam Ravnborg <[EMAIL PROTECTED]> > Signed-off-

Re: [patch 3/7] bnx2x section fix

2008-02-09 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 08 Feb 2008 03:11:15 -0800 > From: Andrew Morton <[EMAIL PROTECTED]> > > gcc-3.4.4 on powerpc: > > drivers/net/bnx2x.c:73: error: version causes a section type conflict > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Cc: Sam Ravnborg <[EMAIL PROTECTED]> > Signed-off

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 01:10:07AM +0100, Ondrej Zary wrote: > > > +typedef enum { EL3_ISA, EL3_PNP, EL3_MCA, EL3_EISA } el3_cardtype; > > > + > > > > No typedef please (see checkpatch) > > Is there any standard way to solve this without a typedef? I added > el3_dev_fill() function which fills th

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: > struct ip_vs_sync_thread_data { > - struct completion *startup; > + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run guarantees that the newly creates thread is run before r

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Simon Horman
On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: > Hi all, > > I'd like to get your feedback on this: > > - Use kthread_run instead of doing a double-fork via kernel_thread() > > - Return proper error codes to user-space on failures > > Currently ipvsadm --start-daemon with an invalid

[solved] Re: Bug? Kernels 2.6.2x drops TCP packets over wireless (independentofcard used)

2008-02-09 Thread Marcin Koziej
Dnia 7 lutego 2008 20:24 Eric Dumazet <[EMAIL PROTECTED]> napisaƂ(a): > Typical window scaling problem here... (well, for previous traces, with > wscaling of 5, since with wscale 2 it seems to work), you probably have a > buggy router or something... > > http://lwn.net/Articles/92727/ > > Try :

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Ondrej Zary
On Saturday 09 February 2008 22:48:05 Stephen Hemminger wrote: > On Sat, 9 Feb 2008 22:33:07 +0100 > > Ondrej Zary <[EMAIL PROTECTED]> wrote: > > Hello, > > this patch converts 3c509 driver to isa_driver and pnp_driver. The result > > is that autoloading using udev and hibernation works with ISA Pn

[PATCH][AX25] af_ax25: remove sock lock in ax25_info_show()

2008-02-09 Thread Jarek Poplawski
On Sat, Feb 09, 2008 at 07:44:50PM +0100, Bernard Pidoux F6BVP wrote: > Hi, > > With AX25 patches applied I still get this possible circular locking > message. IMHO this warning could happen earlier too... Thanks, Jarek P. --> Subject: [AX25] af_ax25: remove sock lock in ax25_info

[RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Sven Wegener
Hi all, I'd like to get your feedback on this: - Use kthread_run instead of doing a double-fork via kernel_thread() - Return proper error codes to user-space on failures Currently ipvsadm --start-daemon with an invalid --mcast-interface will silently suceed. With these changes we get an appro

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Stephen Hemminger
On Sat, 9 Feb 2008 22:33:07 +0100 Ondrej Zary <[EMAIL PROTECTED]> wrote: > Hello, > this patch converts 3c509 driver to isa_driver and pnp_driver. The result is > that autoloading using udev and hibernation works with ISA PnP cards. It also > adds hibernation support for non-PnP ISA cards. > >

[PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Ondrej Zary
Hello, this patch converts 3c509 driver to isa_driver and pnp_driver. The result is that autoloading using udev and hibernation works with ISA PnP cards. It also adds hibernation support for non-PnP ISA cards. xcvr module parameter was removed as its value was not used. Tested using 3 ISA cards

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-09 Thread Jarek Poplawski
On Sat, Feb 09, 2008 at 07:44:50PM +0100, Bernard Pidoux F6BVP wrote: > Hi, > > With AX25 patches applied I still get this possible circular locking > message. Hi Bernard, Could you confirm which exactly patches did you try? Is this vanilla 2.6.24 plus these two: ax25_timer and ax25_ds_timer or

[PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-09 Thread Bernard Pidoux F6BVP
Hi, With AX25 patches applied I still get this possible circular locking message. Regards, Bernard P. === [ INFO: possible circular locking dependency detected ] 2.6.24 #3 --- swapper/

Re: [Bugme-new] [Bug 9923] New: Unable conect to internet over ISDN AVM USB BlueFritz

2008-02-09 Thread Andrew Morton
On Sat, 9 Feb 2008 03:36:26 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9923 > >Summary: Unable conect to internet over ISDN AVM USB BlueFritz >Product: Networking >Version: 2.5 > KernelVersion: 2.6.24 > Pla

[patch] Documentation: fix tcp.txt

2008-02-09 Thread Matti Linnanvuori
From: Matti Linnanvuori <[EMAIL PROTECTED]> Replace BIC with CUBIC as default congestion control. Fix grammar. Signed-off-by: Matti Linnanvuori <[EMAIL PROTECTED]> --- --- a/Documentation/networking/tcp.txt 2008-02-09 16:07:39.547357400 +0200 +++ b/Documentation/networking/tcp.txt 2008-02-09 16

Re: [PATCH] libertas: Don't mark exported symbols as static

2008-02-09 Thread Dan Williams
On Fri, 2008-02-08 at 23:48 -0500, Christoph Hellwig wrote: > On Fri, Feb 08, 2008 at 06:01:02PM -0800, Roland Dreier wrote: > > > Why not pull the exports? they aren't used anywhere in the existing > > kernel. > > > > I'm guessing there's some not-(yet-)merged mesh networking stuff that > > use

Re: [PATCH] ematch: oops from uninitialized variable (resend)

2008-02-09 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 17:54:16 -0800 > Setting up a meta match causes a kernel OOPS because of uninitialized > elements in tree. ... > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied and I'll queue this up for -stable too, thanks! -- To uns

Re: [GIT-PULL Request]: SCTP fixes

2008-02-09 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 15:27:21 -0500 > The following changes since commit 3113e88c3cb3c0a22920b621f8e4d1f2ccc07f1e: > Stephen Hemminger (1): > [PKT_SCHED]: vlan tag match > > are available in the git repository at: > > [EMAIL PROTECTED]:/pub/s