Re: [PATCH] Optimize cxgb3 xmit path (a bit)

2008-01-29 Thread Krishna Kumar2
I forgot to mention but the patch is only compile tested as I don't have hardware to test it. Krishna Kumar2/India/[EMAIL PROTECTED] wrote on 01/30/2008 12:30:16 PM: > Changes: >1. Add common code for stopping queue. >2. No need to call netif_stop_queue followed by netif_wake_queue (and >

[PATCH] Optimize cxgb3 xmit path (a bit)

2008-01-29 Thread Krishna Kumar
Changes: 1. Add common code for stopping queue. 2. No need to call netif_stop_queue followed by netif_wake_queue (and infact a netif_start_queue could have been used instead), instead call stop_queue if required, and remove code under USE_GTS macro. 3.

Re: [RFC/PATCH] e100 driver didn't support any MII-less PHYs...

2008-01-29 Thread Andreas Mohr
Hi, On Tue, Jan 29, 2008 at 03:09:25PM -0800, Kok, Auke wrote: > Andreas Mohr wrote: > > Perhaps it's useful to file a bug/patch > > on http://sourceforge.net/projects/e1000/ ? Perhaps -mm testing? > > I wanted to push this though our testing labs first which has not happened > due to > time con

[PATCH] Debugfs compile fix.

2008-01-29 Thread Denis V. Lunev
Debugfs is not compiled without CONFIG_SYSFS in net-2.6 tree. Move kobject_create_and_add under appropriate ifdef. The fix looks correct from a first glance, but may be the dependency should be added into the Kconfig. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- fs/debugfs/inode.c |2

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-01-29 Thread Stefan Roese
On Wednesday 16 January 2008, Josh Boyer wrote: > On Wed, 16 Jan 2008 20:53:59 +1100 > > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote: > > > With the removal the the "rgmii-interface" device_type property from > > > the dts files, the n

Re: [PATCH 7/7][BNX2]: Update version to 1.7.3.

2008-01-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:20:37 -0800 > [BNX2]: Update version to 1.7.3. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Also applied, thanks Michael. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [PATCH 6/7][BNX2]: Update firmware.

2008-01-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:20:20 -0800 > [BNX2]: Update firmware. > > Update firmware to support programmable flow control. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH 5/7][BNX2]: Fine-tune flow control on 5709.

2008-01-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:20:00 -0800 > [BNX2]: Fine-tune flow control on 5709. > > Make use of the programmable high/low water marks in 5709 for > 802.3 flow control. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. -- To unsubscribe from th

Re: [PATCH 4/7][BNX2]: Remove CTX_WR macro.

2008-01-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:19:47 -0800 > [BNX2]: Remove CTX_WR macro. > > The CTX_WR macro is unnecessary and obfuscates the code. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe n

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-29 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: > Hi, > > The 2.6.24-git6 kernel build fails on various x86_64 machines with the build > failure > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[2]: *** [drivers/net/sis190.o] Error 1 > >

Re: [PATCH 3/7][BNX2]: Remove REG_WR_IND/REG_RD_IND macros.

2008-01-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:19:33 -0800 > [BNX2]: Remove REG_WR_IND/REG_RD_IND macros. > > The REG_WR_IND/REG_RD_IND macros are unnecessary and obfuscate the > code. Many callers to these macros read and write shared memory from > the bp->shmem_base, so we

Re: [PATCH 2/7][BNX2]: Refine tx coalescing setup.

2008-01-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:19:09 -0800 > [BNX2]: Refine tx coalescing setup. > > Make the tx coalescing setup code independent of the MSIX vector. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the lin

Re: [PATCH 1/7][BNX2]: Fix 5706 serdes link down bug.

2008-01-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:18:45 -0800 > [BNX2]: Fix 5706 serdes link down bug. > > 1. Correct the MII expansion serdes control register definition. > 2. Check an additional RUDI_INVALID bit when determining 5706S link. > > Signed-off-by: Michael Chan <[EM

Re: pull request: wireless-2.6 'rndis' 2008-01-29

2008-01-29 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:28:13 -0500 > Dave, > > RNDIS is a de facto standard from Microsoft for USB networking devices. > We already have support for ethernet devices, but wireless devices exist > as well. This series applies some fixes to the curre

Re: [PATCH 0/6] PS3: gelic: gelic updates for 2.6.25

2008-01-29 Thread Masakazu Mokuno
Hi Jeff, The patch set I posted on Dec 13 2007 (except v2 of #6) have been reviewed on the ML and seems to have no more outstanding comments/requests. http://marc.info/?l=linux-netdev&m=119754603814092 Is it OK to apply for 2.6.25? If OK, I'll ask Paul to merge this set into the powerpc tree wi

net-2.6.25 is no more...

2008-01-29 Thread David Miller
Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all current patch applying to net-2.6 instead of net-2.6.25, so the current tree to use is: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git Thanks. -- To unsubscribe from this li

Re: pull request: wireless-2.6 'upstream' 2008-01-29

2008-01-29 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 16:27:03 -0500 > Here are some stragglers for 2.6.25. Most of them are fixes for the > new stuff anyway -- I don't think there is anything convroversial. > > Please let me know if there are problems! Pulled and pushed back out

Re: [PATCH 6/7][BNX2]: Update firmware.

2008-01-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 29 Jan 2008 18:29:56 -0800 > Didn't we beat this topic to death last time? Yes we did. > Once again, the driver is tightly coupled with the firmware. We don't > want things to break when users upgrade or downgrade the kernel. Coding > the dri

Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail

2008-01-29 Thread David Miller
From: Dave Young <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:23:54 +0800 > > The bluetooth hci_conn sysfs add/del executed in the default workqueue. > If the del_conn is executed after the new add_conn with same target, > add_conn will failed with warning of "same kobject name". > > Here add b

Re: ipcomp regression in 2.6.24

2008-01-29 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 14:15:33 +1100 > Marco Berizzi <[EMAIL PROTECTED]> wrote: > > > >> > With 2.6.24 IPSEC/ESP tunnels to older kernels establish fine, data > >> > flows in both directions, but no data comes out of the tunnel. > >> > Needed to disable ipcomp

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-29 Thread Gabriel C
Kamalesh Babulal wrote: > Hi, > > The 2.6.24-git6 kernel build fails on various x86_64 machines with the build > failure > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[2]: *** [drivers/net/sis190.o] Error 1 > > # gcc --version (machine1) > gcc (GCC) 4.

[BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-29 Thread Kamalesh Babulal
Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 # gcc --version (machine1) gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) # gcc --ver

Re: sis190 build breakage

2008-01-29 Thread Sam Ravnborg
On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote: > maximilian attems <[EMAIL PROTECTED]> : > > CC [M] drivers/net/sis190.o > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type > > conflict > > make[5]: *** [drivers/net/sis190.o] Error 1 > > > > gcc --ve

Re: ipcomp regression in 2.6.24

2008-01-29 Thread Herbert Xu
Marco Berizzi <[EMAIL PROTECTED]> wrote: > >> > With 2.6.24 IPSEC/ESP tunnels to older kernels establish fine, data >> > flows in both directions, but no data comes out of the tunnel. >> > Needed to disable ipcomp. > > Same problem here: linux 2.6.24 driven by openswan 2.4.11 > on Slackware 11.0

Re: [Bugme-new] [Bug 9825] New: GPF in kernel when /sbin/ss used for display DCCP sockets.

2008-01-29 Thread Herbert Xu
Andrew Morton <[EMAIL PROTECTED]> wrote: > >> Jan 26 23:38:03 host general protection fault: [#1] PREEMPT >> Jan 26 23:38:03 host Modules linked in: iptable_mangle iptable_nat nf_nat >> ipt_REJECT xt_tcpudp nf_conntrack_ipv4 xt_state ipt_ULOG iptable_filter >> ip_tables x_ >> Jan 26 23:38:03 h

[PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail

2008-01-29 Thread Dave Young
The bluetooth hci_conn sysfs add/del executed in the default workqueue. If the del_conn is executed after the new add_conn with same target, add_conn will failed with warning of "same kobject name". Here add btaddconn & btdelconn workqueues, flush the btdelconn workqueue in the add_conn function

[PATCH 6/7] bonding: update version

2008-01-29 Thread Jay Vosburgh
Update bonding to version 3.2.4. Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/net/bonding/bonding.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h index 6d83be4..67ccad6 100644 --- a/

[PATCH 7/7] bonding: update MAINTAINERS

2008-01-29 Thread Jay Vosburgh
Remove Chad Tindel; he hasn't been involved for a number of years. Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> --- MAINTAINERS |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2340cfb..4b7fa32 100644 --- a/MAINTAINERS +++ b/MAIN

[PATCH 5/7] bonding: do not acquire rtnl in ARP monitor

2008-01-29 Thread Jay Vosburgh
The ARP monitor functions currently acquire RTNL when performing failover operations, but do so incorrectly (out of order). This causes various warnings from might_sleep. The ARP monitor isn't supported for any of the bonding modes that actually require RTNL, so it is safe to not

[PATCH 4/7] bonding: fix race that causes invalid statistics

2008-01-29 Thread Jay Vosburgh
From: Andy Gospodarek <[EMAIL PROTECTED]> I've seen reports of invalid stats in /proc/net/dev for bonding interfaces, and found it's a pretty easy problem to reproduce. Since the current code zeros the bonding stats when a read is requested and a pointer to that data is returned to the caller we

[PATCH 2/7] bonding: fix set_multicast_list locking

2008-01-29 Thread Jay Vosburgh
This patch eliminates a problem (reported by lockdep) in the bond_set_multicast_list function. It first reduces the locking on bond->lock to a simple read_lock, and second, adds netif_tx locking around the bonding mc_list manipulations that occur outside of the set_multicast_list function.

[PATCH 3/7] bonding: fix NULL pointer deref in startup processing

2008-01-29 Thread Jay Vosburgh
Fix the "are we creating a duplicate" check to not compare the name if the name is NULL (meaning that the system should select a name). Bug reported by Benny Amorsen <[EMAIL PROTECTED]>. Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c | 16 +-

[PATCH 1/7] bonding: fix parameter parsing

2008-01-29 Thread Jay Vosburgh
My last fix (commit ece95f7fefe3afae19e641e1b3f5e64b00d5b948) didn't handle one case correctly. This resolves that, and it will now correctly parse parameters with arbitrary white space, and either text names or mode values. Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/net

[PATCH 0/7] bonding: miscellaneous fixes

2008-01-29 Thread Jay Vosburgh
Following are 7 bonding related patches: patch 1: Revamp parameter parsing again to handle all cases (missed an edge case last time). patch 2: fix set_multicast_list locking issues patch 3: Fix possible NULL pointer deref at module init time patch 4: Fix

Re: [PATCH 6/7][BNX2]: Update firmware.

2008-01-29 Thread Michael Chan
On Wed, 2008-01-30 at 00:46 +0100, maximilian attems wrote: > happily omitted diffstat: > drivers/net/bnx2_fw.h | 1499 +++ > drivers/net/bnx2_fw2.h | 464 ++-- > 2 files changed, 982 insertions(+), 981 deletions(-) > > > when can bnx2 grow up to pr

Re: sis190 build breakage

2008-01-29 Thread Randy Dunlap
On Wed, 30 Jan 2008 00:12:23 +0100 maximilian attems wrote: > On Tue, Jan 29, 2008 at 11:27:48PM +0100, Francois Romieu wrote: > > maximilian attems <[EMAIL PROTECTED]> : > > [...] > > > probably i should to get interesting info. > > > > Don't bother. > > > > $ less +/devinitdata Documentation/p

Re: Udev coldplugging loads 8139too driver instead of 8139cp

2008-01-29 Thread Jon Masters
On Tue, 2008-01-29 at 03:46 +0300, Michael Tokarev wrote: > Udev in fact loads both - 8139cp and 8139too. The difference is the ORDER > in which it loads them - if for "cp-handled" hardware it first loads "too", > too will complain as above and will NOT claim the device. The same is > true for

2.6.24-git6 net build failure when SYSFS=n, PROC_FS=n

2008-01-29 Thread Randy Dunlap
linux-2.6.24-git6/net/ipv4/fib_frontend.c: In function 'fib_net_init': linux-2.6.24-git6/net/ipv4/fib_frontend.c:1024: error: implicit declaration of function 'fib_proc_init' linux-2.6.24-git6/net/ipv4/fib_frontend.c: In function 'fib_net_exit': linux-2.6.24-git6/net/ipv4/fib_frontend.c:1039: erro

Re: [PATCH 6/7][BNX2]: Update firmware.

2008-01-29 Thread maximilian attems
On Tue, 29 Jan 2008, Michael Chan wrote: > [BNX2]: Update firmware. > > Update firmware to support programmable flow control. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> > > diff --git a/drivers/net/bnx2_fw.h b/drivers/net/bnx2_fw.h > index c1ad4dd..3b839d4 100644 happily omitted diff

[PATCH 2/7][BNX2]: Refine tx coalescing setup.

2008-01-29 Thread Michael Chan
[BNX2]: Refine tx coalescing setup. Make the tx coalescing setup code independent of the MSIX vector. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 353c73f..8d0022d 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -4438,18

[PATCH 7/7][BNX2]: Update version to 1.7.3.

2008-01-29 Thread Michael Chan
[BNX2]: Update version to 1.7.3. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 7a2a71d..f8bc72e 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -56,8 +56,8 @@ #define DRV_MODULE_NAME"bnx2" #define PFX DRV

[PATCH 5/7][BNX2]: Fine-tune flow control on 5709.

2008-01-29 Thread Michael Chan
[BNX2]: Fine-tune flow control on 5709. Make use of the programmable high/low water marks in 5709 for 802.3 flow control. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 8af63b4..e41c723 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/

[PATCH 4/7][BNX2]: Remove CTX_WR macro.

2008-01-29 Thread Michael Chan
[BNX2]: Remove CTX_WR macro. The CTX_WR macro is unnecessary and obfuscates the code. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 8e9fe48..8af63b4 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -2237,7 +2237,7 @@ bnx2_i

[PATCH 3/7][BNX2]: Remove REG_WR_IND/REG_RD_IND macros.

2008-01-29 Thread Michael Chan
[BNX2]: Remove REG_WR_IND/REG_RD_IND macros. The REG_WR_IND/REG_RD_IND macros are unnecessary and obfuscate the code. Many callers to these macros read and write shared memory from the bp->shmem_base, so we add 2 similar functions that automatically add the shared memory base. Signed-off-by: Mic

[PATCH 1/7][BNX2]: Fix 5706 serdes link down bug.

2008-01-29 Thread Michael Chan
[BNX2]: Fix 5706 serdes link down bug. 1. Correct the MII expansion serdes control register definition. 2. Check an additional RUDI_INVALID bit when determining 5706S link. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 34aebc6..353c73f

Re: Udev coldplugging loads 8139too driver instead of 8139cp

2008-01-29 Thread Jan Engelhardt
On Jan 29 2008 18:34, Jon Masters wrote: >On Tue, 2008-01-29 at 03:46 +0300, Michael Tokarev wrote: > >> Udev in fact loads both - 8139cp and 8139too. The difference is the ORDER >> in which it loads them - if for "cp-handled" hardware it first loads "too", >> too will complain as above and will

Re: sis190 build breakage

2008-01-29 Thread maximilian attems
On Tue, Jan 29, 2008 at 11:27:48PM +0100, Francois Romieu wrote: > maximilian attems <[EMAIL PROTECTED]> : > [...] > > probably i should to get interesting info. > > Don't bother. > > $ less +/devinitdata Documentation/pci.txt > [...] > Tips on when/where to use the above attributes: > o

RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Waskiewicz Jr, Peter P
> Peter, I suspect that driver is just buggy in some other way > as opposed to being re-entered; couldnt tell by inspection. > It is possible it may be too eager to open up before it > really has space. > It will be easy to check your theory by having the driver > just check if it is netif_stop

Re: [RFC/PATCH] e100 driver didn't support any MII-less PHYs...

2008-01-29 Thread Kok, Auke
Andreas Mohr wrote: > Hi, > > On Tue, Jan 01, 2008 at 09:09:08PM +0100, Andreas Mohr wrote: >> Thanks for your quick reply! >> >> OK, here's part 1, the MII-less support stuff. >> (preliminary posting, for review only) >> >> Note that these diffs apply to 2.6.24-rc6-mm1 without much trouble, >> th

Re: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread jamal
On Tue, 2008-29-01 at 22:45 +0100, Erik Mouw wrote: > > The driver seems buggy. Make it return NETDEV_TX_BUSY instead of -EIO > > in xircom_start_xmit() and the messages will go away. > > Like this? > Indeed. Peter, I suspect that driver is just buggy in some other way as opposed to being re-

Re: [RFC/PATCH] e100 driver didn't support any MII-less PHYs...

2008-01-29 Thread Andreas Mohr
Hi, On Tue, Jan 01, 2008 at 09:09:08PM +0100, Andreas Mohr wrote: > Thanks for your quick reply! > > OK, here's part 1, the MII-less support stuff. > (preliminary posting, for review only) > > Note that these diffs apply to 2.6.24-rc6-mm1 without much trouble, > thus might want to do -mm testing

[PATCH 1/1] sis190: silence section type conflict

2008-01-29 Thread Francois Romieu
CC [M] drivers/net/sis190.o drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1 Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Reported-by: Maximilian Attems <[EMAIL PROTECTED]> diff --git a/drivers/net/sis190.c b/d

[PATCH] cxgb3: Remove incorrect __devinit annotations

2008-01-29 Thread Roland Dreier
When PCI error recovery was added to cxgb3, a function t3_io_slot_reset() was added. This function can call back into t3_prep_adapter() at any time, so t3_prep_adapter() can no longer be marked __devinit. This patch removes the __devinit annotation from t3_prep_adapter() and all the functions that

Re: sis190 build breakage

2008-01-29 Thread Francois Romieu
maximilian attems <[EMAIL PROTECTED]> : [...] > probably i should to get interesting info. Don't bother. $ less +/devinitdata Documentation/pci.txt [...] Tips on when/where to use the above attributes: o The module_init()/module_exit() functions (and all initialization functions

Re: sis190 build breakage

2008-01-29 Thread maximilian attems
On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote: > maximilian attems <[EMAIL PROTECTED]> : > > CC [M] drivers/net/sis190.o > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type > > conflict > > make[5]: *** [drivers/net/sis190.o] Error 1 > > > > gcc --ve

Re: sis190 build breakage

2008-01-29 Thread Francois Romieu
maximilian attems <[EMAIL PROTECTED]> : > CC [M] drivers/net/sis190.o > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type > conflict > make[5]: *** [drivers/net/sis190.o] Error 1 > > gcc --version > gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) Are you buildi

[REPOST] [PATCH] enable SMC911X for ARCH_MX3

2008-01-29 Thread Daniel Mack
Hi, this patch enables SMX911X support for Freescale's MX3 platforms. Signed-off-by: Daniel Mack <[EMAIL PROTECTED]> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 6cde4ed..1011735 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -926,7 +926,7 @@ config SMC911X

Re: netdev->priv and netdev_priv(dev)

2008-01-29 Thread Krzysztof Halasa
Stephen Hemminger <[EMAIL PROTECTED]> writes: > Those drivers were making a incorrect assumption and should be fixed. > The in-tree drivers were fixed when this was done. If you have an out > of tree driver, then too bad for you. I have few out-of-tree drivers (IOW not yet merged) but they aren't

sis190 build breakage

2008-01-29 Thread maximilian attems
CC [M] drivers/net/sis190.o drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1 gcc --version gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) -- To unsubscribe from this list: send the line "unsubscribe netdev" i

RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Waskiewicz Jr, Peter P
> > Are you using any specific qdisc, or just the default pfifo_fast? > > Have you done any specific tuning on your qdisc as well? > The default > > qlen seems to have been changed. > > The driver seems buggy. Make it return NETDEV_TX_BUSY instead > of -EIO in xircom_start_xmit() and the me

Re: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Erik Mouw
On Tue, Jan 29, 2008 at 03:57:23PM -0500, jamal wrote: > On Tue, 2008-29-01 at 11:57 -0800, Waskiewicz Jr, Peter P wrote: > > > I've just started to use 2.6.24 on my home firewall (before > > > it was running 2.6.24-rc2 for about 65 days) and I noticed a > > > couple of error messages I've never

pull request: wireless-2.6 'rndis' 2008-01-29

2008-01-29 Thread John W. Linville
Dave, RNDIS is a de facto standard from Microsoft for USB networking devices. We already have support for ethernet devices, but wireless devices exist as well. This series applies some fixes to the current ethernet RNDIS stuff to co-exist with wireless and adds a wireless RNDIS driver. I would l

[PATCH 1/3] Kernel support for flexible wakeup filters

2008-01-29 Thread Mitch Williams
Add ethtool infrastructure support for Wake-on-Lan flexible filters. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index 71d4ada..70b86da 100644 --- a/include/linux/ethtool.h +++ b/include/linux/ethtool.h @@ -56,6 +56,16 @@ struct

[PATCH 3/3] Add flexible wake filter support to ethtool-6

2008-01-29 Thread Mitch Williams
Add support for Wake-on-Lan flexible filters to ethtool.To set a filter: $ ethtool -F ethx where is a string of hex digits (or xx for ignore) describing bytes from the beginning of the expected packet. For example: $ ethtool -F eth0 0 00a055667788449976xx32 To show a filter: $ ethtool -

[PATCH 2/3] Add flexible wake filter support to e1000e

2008-01-29 Thread Mitch Williams
Add support to e1000e for Wake-on-Lan flexible filters. This feature is supported by all hardware that the driver supports. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000e/defines.h b/drivers/net/e1000e/defines.h index 6232c3e..3c18a09 100644 --- a/drivers/net/e

[PATCH 0/3] Add flexible wake filter support

2008-01-29 Thread Mitch Williams
This patchset adds support for Wake-on-Lan flexible filters to ethtool and to e1000e. Since this hardware feature is required for certification on Another Operating System(TM), it's likely that most current hardware supports it in one form or another. To set a filter: $ ethtool -F ethx where

Re: [PATCH net-2.6.25] [IPV6] ADDRLABEL: Fix double free on label deletion.

2008-01-29 Thread Paul E. McKenney
On Mon, Jan 28, 2008 at 09:02:22PM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > If an entry is being deleted because it has only one reference, > we immediately delete it and blindly register the rcu handler for it, > This results in oops by double freeing that object. > > This patch fixes it by cons

[PATCH 2.6.24] e1000e: add new wakeup cababilities

2008-01-29 Thread Mitch Williams
Ethtool supports wake-on-ARP and wake-on-link, and so does the hardware supported by e1000e. This patch just introduces the two. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000e/defines.h b/drivers/net/e1000e/defines.h index f2175ea..6232c3e 100644 --- a/drivers/

RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread jamal
On Tue, 2008-29-01 at 11:57 -0800, Waskiewicz Jr, Peter P wrote: > > I've just started to use 2.6.24 on my home firewall (before > > it was running 2.6.24-rc2 for about 65 days) and I noticed a > > couple of error messages I've never seen before: > > > > Jan 29 07:50:54 gateway kernel: BUG eth1

Re: [NET_SCHED]: sch_ingress: remove netfilter support

2008-01-29 Thread jamal
About time - Thanks Patrick. Acked-by: Jamal Hadi Salim <[EMAIL PROTECTED]> cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: netdev->priv and netdev_priv(dev)

2008-01-29 Thread Stephen Hemminger
On Tue, 29 Jan 2008 21:10:00 +0100 Krzysztof Halasa <[EMAIL PROTECTED]> wrote: > A commit few months ago introduced a change: > > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > > static inline void *netdev_priv(const struct net_device *dev) > { > - return (char *)de

PATCH[1/1]: Add ctr-aes support to ipsec

2008-01-29 Thread Joy Latten
The below patch allows IPsec to use CTR mode with AES encryption algorithm. Tested this using setkey in ipsec-tools. regards, Joy diff -urpN net-2.6.25/include/linux/pfkeyv2.h net-2.6.25.patch/include/linux/pfkeyv2.h --- net-2.6.25/include/linux/pfkeyv2.h 2008-01-29 11:48:00.0 -0600 +++

[PATCH] netdev->priv and netdev_priv(dev)

2008-01-29 Thread Krzysztof Halasa
[This version shouldn't confuse git/patch] A commit few months ago introduced a change: - a/include/linux/netdevice.h + b/include/linux/netdevice.h static inline void *netdev_priv(const struct net_device *dev) { - return (char *)dev + ((sizeof(struct net_device) -

[PATCH 1/1 resend][arm/at91_ether.c] logical/bitand typo in function reset_phy() (inactive), drivers/net/arm/at91_ether.c

2008-01-29 Thread Roel Kluin
include/linux/mii.h:48:#define BMCR_RESET 0x8000 The function reset_phy() is in "#if 0" inactivated code -- Replace logical "&&" by bit "&" before BMCR_RESET Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c index 25b114a..0

Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-01-29 Thread Haavard Skinnemoen
On Tue, 29 Jan 2008 10:05:09 -0600 Nate Case <[EMAIL PROTECTED]> wrote: > +/* PHY timer which schedules the state machine work */ > +static void phy_timer(unsigned long data) > +{ > + struct phy_device *phydev = (struct phy_device *)data; > + > + /* > + * PHY I/O operations can potent

netdev->priv and netdev_priv(dev)

2008-01-29 Thread Krzysztof Halasa
A commit few months ago introduced a change: --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h static inline void *netdev_priv(const struct net_device *dev) { - return (char *)dev + ((sizeof(struct net_device) - + NETDEV_ALIGN_CONST) -

RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Waskiewicz Jr, Peter P
> I've just started to use 2.6.24 on my home firewall (before > it was running 2.6.24-rc2 for about 65 days) and I noticed a > couple of error messages I've never seen before: > > Jan 29 07:50:54 gateway kernel: BUG eth1 code -5 qlen 0 Jan > 29 08:28:30 gateway kernel: BUG eth1 code -5 qlen 0 J

Re: [PATCH] bfin_mac: Fix MDIO clock frequency

2008-01-29 Thread Kalle Pokki
On Wed, 30 Jan 2008, Bryan Wu wrote: > > On Tue, 2008-01-29 at 20:27 +0800, Kalle Pokki wrote: > > The clock divisor is set to all ones at reset. > > --- > > drivers/net/bfin_mac.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/net/bfin_mac.c b/d

Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

2008-01-29 Thread Erik Mouw
Hi, I've just started to use 2.6.24 on my home firewall (before it was running 2.6.24-rc2 for about 65 days) and I noticed a couple of error messages I've never seen before: Jan 29 07:50:54 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 08:28:30 gateway kernel: BUG eth1 code -5 qlen 0 Jan 29 08:5

Re: [PATCH] bfin_mac: Fix MDIO clock frequency

2008-01-29 Thread Bryan Wu
On Tue, 2008-01-29 at 20:27 +0800, Kalle Pokki wrote: > The clock divisor is set to all ones at reset. > --- > drivers/net/bfin_mac.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c > index eb97175..c199633 100644

Re: [PATCH] bfin_mac: Make the MDIO polling faster

2008-01-29 Thread Bryan Wu
On Tue, 2008-01-29 at 20:28 +0800, Kalle Pokki wrote: > The poll routine always got 10 ms penalty when called immediately > after starting the transfer. The MDIO transfer takes 25.6 us at the > noinal 2.5 MHz, so MAX_TIMEOUT_CNT being 500 is still big enough. Exactly, but we got a same fixing

Re: Still oopsing in nf_nat_move_storage()

2008-01-29 Thread Patrick McHardy
Chuck Ebbert wrote: nf_nat_move_storage(): /usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612 87: f7 47 64 80 01 00 00testl $0x180,0x64(%edi) 8e: 74 39 je c9 line 612: if (!(ct->status & IPS_NAT_DONE_MAS

Re: [PATCH] SELinux: Fix double free in selinux_netlbl_sock_setsid()

2008-01-29 Thread Paul Moore
On Monday 28 January 2008 10:51:24 pm David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Mon, 28 Jan 2008 21:20:26 -0500 > > > As pointed out by Adrian Bunk, commit > > 45c950e0f839fded922ebc0bfd59b1081cc71b70 caused a double-free when > > security_netlbl_sid_to_secattr() fails. Th

Still oopsing in nf_nat_move_storage()

2008-01-29 Thread Chuck Ebbert
nf_nat_move_storage(): /usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612 87: f7 47 64 80 01 00 00testl $0x180,0x64(%edi) 8e: 74 39 je c9 line 612: if (!(ct->status & IPS_NAT_DONE_MASK)) re

Re: forcedeth oops

2008-01-29 Thread Ayaz Abdulla
Jeff Garzik wrote: Andrew Brooks wrote: > Hello > > I'm getting an oops in forcedeth whenever I shutdown, details below. > > I've tried kernel 2.6.16.59 and the latest forcedeth.c from nvidia.com > which is package-1.23 version-0.62 date-2007/04/27. > > How can I download the latest for

[PATCH] forcedeth: mac address mcp77/79

2008-01-29 Thread Ayaz Abdulla
This patch is a critical fix for MCP77 and MCP79 devices. The feature flags were missing the define for correct mac address (DEV_HAS_CORRECT_MACADDR). Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2008-01-28 10:15:28.0 -0500 +++ new/drivers/net/forcede

Re: Udev coldplugging loads 8139too driver instead of 8139cp

2008-01-29 Thread Ondrej Zary
On Tuesday 29 January 2008 11:43:53 Michael Tokarev wrote: > Stephen Hemminger wrote: > > On Tue, 29 Jan 2008 03:46:08 +0300 > > Michael Tokarev <[EMAIL PROTECTED]> wrote: > > [] > > >> There are 2 drivers for 8139-based NICs. For really different two kinds > >> of hardware, which both uses the sa

status inquiry#2 (RE: [PATCH 01/03] ISATAP V2 (header file changes))

2008-01-29 Thread Templin, Fred L
Would appreciate a status update on this submission, posted 1/15/08. Thanks - Fred [EMAIL PROTECTED] > -Original Message- > From: Templin, Fred L > Sent: Tuesday, January 15, 2008 11:57 AM > To: netdev@vger.kernel.org > Cc: YOSHIFUJI Hideaki / 吉藤英明 > Subject: [PATCH 01/03] ISATAP V2 (he

[PATCH] pktgen: pktgen should not print info that it is spinning

2008-01-29 Thread Jesse Brandeburg
when using pktgen to send delay packets the module prints repeatedly to the kernel log: sleeping for X sleeping for X ... This is probably just a debugging item left in and should not be enabled for regular use of the module. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> CC: Robert Olsson <

[PATCH] New driver "sfc" for Solarstorm SFC4000 controller

2008-01-29 Thread Ben Hutchings
This is a resubmission of a new driver for Solarflare network controllers. The driver supports several types of PHY (10Gbase-T, XFP, CX4) on six different 10G and 1G boards. It is accompanied by an MTD driver that allows access to the flash/EEPROM. NICs based on this controller are now available

[PATCH] PHYLIB: Add BCM5482 PHY support

2008-01-29 Thread Nate Case
This Broadcom PHY is similar to other bcm54xx devices. Signed-off-by: Nate Case <[EMAIL PROTECTED]> --- drivers/net/phy/broadcom.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 29666c8..5b

SKBs with shared fragments

2008-01-29 Thread kristrev
Hello, I am working on a patch to the TCP-code that, among others, share fragments between skbs, and have encountered a problem that I'm not sure if I have solved correctly. To share a fragment, I copy the skb_frag-struct to the correct place in the other skbs frags-array, increase the page-count

[PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-01-29 Thread Nate Case
PHY read/write functions can potentially sleep (e.g., a PHY accessed via I2C). The following changes were made to account for this: * Change spin locks to mutex locks * Add a BUG_ON() to phy_read() phy_write() to warn against calling them from an interrupt context. * Use work qu

[NET_SCHED]: sch_ingress: remove netfilter support

2008-01-29 Thread Patrick McHardy
commit 3b27667029825ba16f8509fb119bca1b445a3dc9 Author: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon Jan 28 13:57:56 2008 +0100 [NET_SCHED]: sch_ingress: remove netfilter support Since the old policer code is gone, TC actions are needed for policing. The ingress qdisc can get

Re: sky2: tx hang on dual-port Yukon XL when rx csum disabled

2008-01-29 Thread Tony Battersby
Tony Battersby wrote: > "iperf -c 192.168.1.1" never finishes, but "iperf -c 192.168.2.1" does > finish. Press Ctrl-C to abort the hung iperf. Ping 192.168.1.1 does > not respond. Ping 192.168.2.1 does respond, but each ping has almost > exactly 1 second latency (the latency should be < 1 ms). >

Re: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.

2008-01-29 Thread Patrick McHardy
Rami Rosen wrote: Hi, In drivers/net/macvlan.c, when rtnl_link_register() fails in macvlan_init_module(), there is no point to set it (second time in this method) to macvlan_handle_frame; macvlan_init_module() will return a negative number, so instead this patch sets macvlan_handle_frame_hook t

[PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.

2008-01-29 Thread Rami Rosen
Hi, In drivers/net/macvlan.c, when rtnl_link_register() fails in macvlan_init_module(), there is no point to set it (second time in this method) to macvlan_handle_frame; macvlan_init_module() will return a negative number, so instead this patch sets macvlan_handle_frame_hook to NULL. Regards, Ra

[VLAN]: set_rx_mode support for unicast address list

2008-01-29 Thread Patrick McHardy
commit fbf2742ff936c751444ae610ae45c6ef54c14658 Author: Chris Leech <[EMAIL PROTECTED]> Date: Thu Jan 24 18:24:53 2008 +0100 [VLAN]: set_rx_mode support for unicast address list Reuse the existing logic for multicast list synchronization for the unicast address list. The core o

[GIT PULL] pull request for lblnet-2.6_testing

2008-01-29 Thread Paul Moore
Hi James, I've just rebased the lblnet-2.6_testing tree against Linus' latest which already includes DaveM's net-2.6.25 tree so there shouldn't be any collisions with the core networking bits. Other than minor changes needed to merge cleanly with the current linux-2.6 tree there have been no

pppoe, /proc/net/pppoe wrong (extra entries)

2008-01-29 Thread Denys Fedoryshchenko
Hi again I notice strange thing, with /proc/net/pppoe, not sure if it is bug, but for me it looks wrong. cat /proc/net/pppoe there is normal entries of users, but at the end i have 0D00 00:16:D3:0B:F9:34 eth1 4000 00:50:22:00:1C:FC eth1 7E00 00:03:47:BD:34:25 eth1 0

  1   2   >