Re: [PATCH 3/6] [IPV4] trie: put leaf nodes in a slab cache

2008-01-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 16:46:21 -0800 > This improves locality for operations that touch all the leaves. > Later patch will grow the size of the leaf so it becomes more > important. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> I'll let 3, 4

Re: [PATCH] [IPV4] fib_trie: size and statistics

2008-01-14 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 07:55:57 +0100 > Keeping a 'size' counter is not necessary, since trie_collect_stats() must go > through all the tree and get this information for free. > > This 'size' field only slows down inserts/deletes and dirty a cacheline that

Re: [PATCH 2/6] [IPV4] fib hash|trie initialization

2008-01-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 21:00:08 -0800 > Initialization of the slab cache's should be done when IP is > initialized to make sure of available memory, and that code > can be marked __init. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied.

Re: questions on NAPI processing latency and dropped network packets

2008-01-14 Thread Jarek Poplawski
On 14-01-2008 16:58, Chris Friesen wrote: ... > How close to bleeding edge do we need to be for it to be considered > acceptable to ask questions on netdev? > > Given that the embedded space tends to be perpetually stuck on older > kernels (our "current" release is based on 2.6.14) do you have a

Re: [PATCH] [IPV4] fib_trie: size and statistics

2008-01-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 12:57:55 -0800 > Show number of entries in trie, the size field was being set but never used, > but it only counted leaves, not all entries. Refactor the two cases in > fib_triestat_seq_show into a single routine. > > Note: the st

Re: [FIB]: Avoid using static variables without proper locking

2008-01-14 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 20:27:11 +0100 > fib_trie_seq_show() uses two helper functions, rtn_scope() and > rtn_type() that can > write to static storage without locking. > > Just pass to them a temporary buffer to avoid potential corruption > (probably not t

Re: [PATCH 2/9] get rid of unused revision element

2008-01-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 08:35:55 -0800 > I will be glad to get this working. Is there any point in doing the a > small systems version as well? Not at this time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

Re: [PATCH 0/8 2.6.25] a set of small code cleanups

2008-01-14 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 17:59:23 +0300 > This set contains a set of small improvements found in IPv4 code during > preparations to support ARP in the network namespace. These fixes are > mostly independent except 2 last ones. > > Signed-off-by: Denis V. L

Re: [PATCH 6/8 net-2.6.25] [ARP] neigh_parms_put(destroy) are essentially local to core/neighbour.c.

2008-01-14 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 17:59:59 +0300 > Make them static. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> It's completely awkward to put the inline after all the call sites. A non-global-optimizing compiler won't be able to even inline it. I've

Re: [PATCH] [IPV4] fib_trie: size and statistics

2008-01-14 Thread Eric Dumazet
Stephen Hemminger a écrit : Show number of entries in trie, the size field was being set but never used, but it only counted leaves, not all entries. Refactor the two cases in fib_triestat_seq_show into a single routine. Note: the stat structure was being malloc'd but the stack usage isn't so hi

Re: [PATCH 3/6] [IPV4] trie: put leaf nodes in a slab cache

2008-01-14 Thread Eric Dumazet
Stephen Hemminger a écrit : This improves locality for operations that touch all the leaves. Later patch will grow the size of the leaf so it becomes more important. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-14 12:26:51.0 -0800 +++ b/n

[PATCH 4/4] bonding: Fix some RTNL taking

2008-01-14 Thread Makito SHIOKAWA
Fix some RTNL lock taking: * RTNL (mutex; may sleep) must not be taken under read_lock (spinlock; must be atomic). However, RTNL is taken under read_lock in bond_loadbalance_arp_mon() and bond_activebackup_arp_mon(). So change code to take RTNL outside of read_lock. * rtnl_unlock() calls netdev_

[PATCH 1/4] bonding: Fix work initing and cancelling

2008-01-14 Thread Makito SHIOKAWA
delayed_work_pending() is used to check whether work is being queued or not, when queueing or cancelling corresponding work. However, delayed_work_pending() returns 0 when work is just running, and in that case, work_struct will be destroyed or work won't be cancelled. So remove all delayed_work_pe

[PATCH 0/4] bonding: Fix workqueue manipulation and lock taking

2008-01-14 Thread Makito SHIOKAWA
These patches fix some workqueue manipulation and lock taking in bonding driver. PATCH 1/4 through PATCH 3/4 are on workqueue manipulation, PATCH 4/4 is on lock taking, and each patch are logically independent. Patches are for latest netdev-2.6 git. -- Makito SHIOKAWA MIRACLE LINUX CORPORATION

[PATCH 2/4] bonding: Add destroy_workqueue() to bond device destroying process

2008-01-14 Thread Makito SHIOKAWA
There is no destroy_workqueue() in bond device destroying process, therefore worker thread will remain even if bond device is destroyed. So add destroy_workqueue(), and also, ensure all works are canceled before destroy_workqueue() is called. Signed-off-by: Makito SHIOKAWA <[EMAIL PROTECTED]> ---

[PATCH 3/4] bonding: Fix work rearming

2008-01-14 Thread Makito SHIOKAWA
Change code not to rearm bond_mii_monitor() when value 0 is set for miimon. Signed-off-by: Makito SHIOKAWA <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-14 Thread Frans Pop
Wow. That's fast! :-) On Tuesday 15 January 2008, David Miller wrote: > From: Frans Pop <[EMAIL PROTECTED]> > > > kernel: e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang > > Does this make the problem go away? I'm compiling a kernel with the patch now. Will let you know the result. May tak

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-14 Thread Eric Dumazet
Eric Dumazet a écrit : Stephen Hemminger a écrit : Combine the prefix information and the leaf together into one allocation. This is furthur simplified by converting the hlist into a simple bitfield. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> This patch is experimental (ie it boots a

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-14 Thread Eric Dumazet
Stephen Hemminger a écrit : Combine the prefix information and the leaf together into one allocation. This is furthur simplified by converting the hlist into a simple bitfield. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> This patch is experimental (ie it boots and loads routes), but is

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-14 Thread David Miller
From: Frans Pop <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 06:25:10 +0100 > kernel: e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang Does this make the problem go away? (Note this isn't the final correct patch we should apply. There is no reason why this revert back to the older ->poll()

[REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-14 Thread Frans Pop
After compiling v2.6.24-rc7-163-g1a1b285 (x86_64) yesterday I suddenly see this error repeatedly: kernel: e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang kernel: Tx Queue <0> kernel: TDH kernel: TDT kernel: next_to_use kernel

[RFC 6/6] fib_trie: combine leaf and info

2008-01-14 Thread Stephen Hemminger
Combine the prefix information and the leaf together into one allocation. This is furthur simplified by converting the hlist into a simple bitfield. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> This patch is experimental (ie it boots and loads routes), but is slower for the 163,000 route

[PATCH 5/6] [IPV4] fib_trie: checkleaf calling convention

2008-01-14 Thread Stephen Hemminger
Another case where just returning a negative value gets rid of call by reference. In this case the return value for checkleaf is now: -1 no match 0..32 prefix length Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-14 18:02:18.00

[PATCH 4/6] [IPV4] fib_trie style cleanup

2008-01-14 Thread Stephen Hemminger
Get rid of #ifdef, and split out embedded function calls in if statements. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-14 14:24:58.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-14 14:26:05.0 -0800 @@ -1293,7 +1293,9 @@ static inli

[PATCH 2/6] [IPV4] fib hash|trie initialization

2008-01-14 Thread Stephen Hemminger
Initialization of the slab cache's should be done when IP is initialized to make sure of available memory, and that code can be marked __init. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- Applies after statistics (#1) patch for net-2.6.25 include/net/ip_fib.h|5 +++-- net/i

[PATCH 3/6] [IPV4] trie: put leaf nodes in a slab cache

2008-01-14 Thread Stephen Hemminger
This improves locality for operations that touch all the leaves. Later patch will grow the size of the leaf so it becomes more important. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-14 12:26:51.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-

Re: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

2008-01-14 Thread Kumar Gala
On Jan 14, 2008, at 3:15 PM, Andrew Morton wrote: On Mon, 14 Jan 2008 12:00:51 -0600 Kim Phillips <[EMAIL PROTECTED]> wrote: On Thu, 10 Jan 2008 21:41:20 -0700 "Aggrwal Poonam" <[EMAIL PROTECTED]> wrote: Hello All I am waiting for more feedback on the patches. If there are no objections

Re: [PATCH] atl1: fix frame length bug

2008-01-14 Thread Jay Cliburn
On Mon, 14 Jan 2008 19:56:41 -0600 Jay Cliburn <[EMAIL PROTECTED]> wrote: > The driver sets up the hardware to accept a frame with max length > equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to > add the VLAN tag size to the ingress buffer. When a VLAN-tagged > frame arrives, the

[PATCH] atl1: fix frame length bug

2008-01-14 Thread Jay Cliburn
The driver sets up the hardware to accept a frame with max length equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to add the VLAN tag size to the ingress buffer. When a VLAN-tagged frame arrives, the hardware passes it, but bad things happen because the buffer is too small. This p

[Patch 2.6.24 1/1]S2io: Fixed synchronization between scheduling of napi with card reset and close

2008-01-14 Thread Sreenivasa Honnur
- Fixed synchronization between scheduling of napi with card reset and close by moving the enabling and disabling of napi to card up and card down functions respectively instead of open and close. Signed-off-by: Surjit Reang <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTE

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-14 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : > From: Francois Romieu <[EMAIL PROTECTED]> > > > > I should be able to test your r8169 NAPI changes tomorrow. > > Thank you. (sorry for the delay) I think that the r8169 part should be reverted. . With it, my 8169 oopsed unexpectedly in rtl8169_reinit_task a

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Paul Moore
On Monday 14 January 2008 6:04:28 pm [EMAIL PROTECTED] wrote: > On Mon, 14 Jan 2008 14:07:46 EST, Paul Moore said: > > http://git.infradead.org/?p=users/pcmoore/lblnet-2.6_testing;a=commitdiff > >;h=02f1c89d6e36507476f78108a3dcc78538be460b > > Initial testing indicates that 2.6.24-rc6-mm1 plus this

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 14:07:46 EST, Paul Moore said: > > http://git.infradead.org/?p=users/pcmoore/lblnet-2.6_testing;a=commitdiff;h=02f1c89d6e36507476f78108a3dcc78538be460b Initial testing indicates that 2.6.24-rc6-mm1 plus this one commit is behaving itself correctly - my Tcl test case that reliab

Re: [patch for 2.6.24? 1/1] bonding: locking fix

2008-01-14 Thread Jay Vosburgh
Andrew Morton <[EMAIL PROTECTED]> wrote: [...] >That's bond_lock. > >This patch (below) addresses what appears to me to be an obvious >imbalance in rtnl_lock. > >I don't care how it's fixed, really. Someone please fix it? I posted a correct patch for this a few days ago: http://marc.info

[PATCH 5/5] forcedeth: multicast fix

2008-01-14 Thread Ayaz Abdulla
This patch fixes the case where no multicast addresses are requested to be added to the multicast filter. The multicast mask must be set to all 1's instead of all 0's. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2008-01-13 15:15:22.0 -0500 +++ new/dr

Re: [patch for 2.6.24? 1/1] bonding: locking fix

2008-01-14 Thread Andrew Morton
(cc's added) On Mon, 14 Jan 2008 23:14:25 +0100 (CET) Krzysztof Oledzki <[EMAIL PROTECTED]> wrote: > > > On Mon, 14 Jan 2008, [EMAIL PROTECTED] wrote: > > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > Remove stray rtnl_unlock(). > > > > Addresses http://bugzilla.kernel.org/show_bug.cgi?id

[PATCH 3/5] forcedeth: updated copyright section

2008-01-14 Thread Ayaz Abdulla
This patch updates the copyright section to include 2007 and 2008. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2008-01-13 15:10:18.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-13 15:11:47.0 -0500 @@ -13,7 +13,7 @@ * Copyright (C) 2004 Andr

[PATCH 4/5] forcedeth: tx pause fix

2008-01-14 Thread Ayaz Abdulla
This patch fixes the tx pause enable watermark flags. The new values where determined to be optimal during testing. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2008-01-13 15:12:16.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-13 15:14:55.0 -

[PATCH 1/5] forcedeth: reset register fix

2008-01-14 Thread Ayaz Abdulla
This patch fixes the reset register definition from 0x3C to 0x34. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2008-01-13 15:00:43.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-13 15:00:48.0 -0500 @@ -226,7 +226,7 @@ #define NVREG_MISC1_HD

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Stephen Hemminger
On Mon, 14 Jan 2008 22:58:51 +0100 "Oliver Pinter (Pintér Olivér)" <[EMAIL PROTECTED]> wrote: > I "tested" other devices resources file, and only with skge freezed > the system. from this think, that is skge driver bug > Its a property of the hardware, and the current device model has no way to

[PATCH 2/5] forcedeth: checksum fix

2008-01-14 Thread Ayaz Abdulla
The driver should inform the stack when checksum has been performed by the HW when both IP and TCP (or UDP) checksum flags are indicated by HW. Previously, it would also inform the stack when only IP checksum flag was indicated by HW. This can cause data corruption when IP fragments are used.

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-14 Thread Krzysztof Oledzki
On Sat, 12 Jan 2008, Jay Vosburgh wrote: Krzysztof Oledzki <[EMAIL PROTECTED]> wrote: [...] Exactly. All I need to do is to reboot my server, I have 100% probability to get the warning. I wish it were that easy for me; I'm not sure what magic thing you've got on your server or netwo

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Oliver Pinter (Pintér Olivér)
I "tested" other devices resources file, and only with skge freezed the system. from this think, that is skge driver bug -- Thanks, Oliver -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 10:41:52PM +0100, Oliver Pinter (Pintér Olivér) wrote: > On 1/14/08, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér) > > wrote: > > > I think, it is a potential security breakpoint, when applications with > >

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Greg KH
On Mon, Jan 14, 2008 at 10:41:52PM +0100, Oliver Pinter (Pint?r Oliv?r) wrote: > On 1/14/08, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pint?r Oliv?r) > > wrote: > > > I think, it is a potential security breakpoint, when applications with > >

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Oliver Pinter (Pintér Olivér)
On 1/14/08, Greg KH <[EMAIL PROTECTED]> wrote: > On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pint?r Oliv?r) > wrote: > > I think, it is a potential security breakpoint, when applications with > > root permission its read, then a machine is freezed, or only i thinK > > it's? > > I'm sor

Re: Why are network counters only updated once a second?

2008-01-14 Thread Michael Chan
On Mon, 2008-01-14 at 15:30 -0500, Mark Seger wrote: > Eventually the frequency became better aligned at a 1 second interval > because now the number look better, but the problem I see is that when > the sampling interval is very close to the monitoring interval you still > get periodic incorre

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Oliver Pinter (Pintér Olivér)
On 1/14/08, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér) > wrote: > > I think, it is a potential security breakpoint, when applications with > > root permission its read, then a machine is freezed, or only i thin > > it's? > > When

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Greg KH
On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pint?r Oliv?r) wrote: > I think, it is a potential security breakpoint, when applications with > root permission its read, then a machine is freezed, or only i thin > it's? I'm sorry, I don't quite understand what you are trying to say here.

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér) wrote: > I think, it is a potential security breakpoint, when applications with > root permission its read, then a machine is freezed, or only i thin > it's? When you are root there are infinite ways to kill your machine, so

RE: [PATCH] s2io LRO bugs

2008-01-14 Thread Ramkrishna Vepa
Al, Thanks for finding this. We have a few patches lined up and will submit this patch. Ram > -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > On Behalf Of Al Viro > Sent: Sunday, December 23, 2007 10:15 PM > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org; [EMA

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Oliver Pinter (Pintér Olivér)
I think, it is a potential security breakpoint, when applications with root permission its read, then a machine is freezed, or only i thin it's? -- Thanks, Oliver -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Greg KH
On Mon, Jan 14, 2008 at 11:01:05PM +0200, Adrian Bunk wrote: > On Mon, Jan 14, 2008 at 12:52:00PM -0800, Stephen Hemminger wrote: > > On Mon, 14 Jan 2008 20:57:49 +0100 > > "Oliver Pinter (Pint??r Oliv??r)" <[EMAIL PROTECTED]> wrote: > > > > > Hi All! > > > > > > It is fully reproductable under 2

Re: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

2008-01-14 Thread Andrew Morton
On Mon, 14 Jan 2008 12:00:51 -0600 Kim Phillips <[EMAIL PROTECTED]> wrote: > On Thu, 10 Jan 2008 21:41:20 -0700 > "Aggrwal Poonam" <[EMAIL PROTECTED]> wrote: > > > Hello All > > > > I am waiting for more feedback on the patches. > > > > If there are no objections please consider them for 2.6.2

Re: occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Eric Dumazet
Mark Seger a écrit : I had posted the following on linux-net and haven't see any responses possibly because nobody had any or that list is obsolete. I have been told this is the current list for everything networking on linux so I thought I'd try again... I suspect the answer will be that it

Re: [PATCH 1/3] drivers/misc :UCC based TDM driver for MPC83xx platforms.

2008-01-14 Thread Andrew Morton
On Mon, 10 Dec 2007 17:34:44 +0530 (IST) Poonam_Aggrwal-b10812 <[EMAIL PROTECTED]> wrote: > From: Poonam Aggrwal <[EMAIL PROTECTED]> > > The UCC TDM driver basically multiplexes and demultiplexes data from > different channels. It can interface with for example SLIC kind of devices > to receive

Re: [RFT] sky2: wake-on-lan configuration issues

2008-01-14 Thread supersud501
Stephen Hemminger wrote: Please test this patch against Linus's current (approx 2.6.24-rc7-git5). Ignore Andrew's premature reversion attempt... This patch disables config mode access after clearing PCI settings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Adrian Bunk
On Mon, Jan 14, 2008 at 12:52:00PM -0800, Stephen Hemminger wrote: > On Mon, 14 Jan 2008 20:57:49 +0100 > "Oliver Pinter (Pintér Olivér)" <[EMAIL PROTECTED]> wrote: > > > Hi All! > > > > It is fully reproductable under 2.6.22.15, 2.6.23.13 (all tainted and > > not tainted [4 different kernel] ) a

[PATCH] [IPV4] fib_trie: size and statistics

2008-01-14 Thread Stephen Hemminger
Show number of entries in trie, the size field was being set but never used, but it only counted leaves, not all entries. Refactor the two cases in fib_triestat_seq_show into a single routine. Note: the stat structure was being malloc'd but the stack usage isn't so high (288 bytes) that it is wort

Re: Why are network counters only updated once a second?

2008-01-14 Thread Mark Seger
Eric Dumazet wrote: Mark Seger a écrit : I had mentioned this in my previous post but perhaps it might get more attention all by itself. I can't say for sure when this changed, but for the longest time network counters were only updated once every 0.9765 seconds and unless you used a tools

Re: [BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Stephen Hemminger
On Mon, 14 Jan 2008 20:57:49 +0100 "Oliver Pinter (Pintér Olivér)" <[EMAIL PROTECTED]> wrote: > Hi All! > > It is fully reproductable under 2.6.22.15, 2.6.23.13 (all tainted and > not tainted [4 different kernel] ) and 2 different PC: > > [BUG] skge :02:05: read data parity error > [BUG] skg

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-14 Thread Andrew Morton
On Mon, 14 Jan 2008 08:39:26 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c > > index c27c7d6..4f41a94 100644 > > --- a/drivers/net/sky2.c > > +++ b/drivers/net/sky2.c > > @@ -2791,6 +2791,9 @@ static void sky2_reset(struct sky2_hw *hw)

Re: Why are network counters only updated once a second?

2008-01-14 Thread Eric Dumazet
Mark Seger a écrit : I had mentioned this in my previous post but perhaps it might get more attention all by itself. I can't say for sure when this changed, but for the longest time network counters were only updated once every 0.9765 seconds and unless you used a tools like collectl that coul

Why are network counters only updated once a second?

2008-01-14 Thread Mark Seger
I had mentioned this in my previous post but perhaps it might get more attention all by itself. I can't say for sure when this changed, but for the longest time network counters were only updated once every 0.9765 seconds and unless you used a tools like collectl that could monitor at fraction

Re: occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Mark Seger
outstanding! I'm just happy to hear it's not a bug in my monitoring code... 8-) -mark Michael Chan wrote: On Mon, 2008-01-14 at 20:12 +0100, Eric Dumazet wrote: Mark Seger a écrit : Ignore that last one as it was pointed out to me that we have both nic installed on many of our syste

Re: questions on NAPI processing latency and dropped network packets

2008-01-14 Thread Chris Friesen
Eric Dumazet wrote: Chris Friesen a écrit : Based on the profiling information we're spending time in sctp_endpoint_lookup_assoc() which doesn't actually use hashes, so I can't see how the hash would be related. I'm pretty new to SCTP though, so I may be missing something. Well, it does u

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Paul Moore
On Monday 14 January 2008 2:37:02 pm [EMAIL PROTECTED] wrote: > On Mon, 14 Jan 2008 14:07:46 EST, Paul Moore said: > > There have been quite a few changes in lblnet-2.6_testing since > > 2.6.24-rc6-mm1 so I would recommend taking the whole tree. I'm also not > > quite sure if > > Weird. I did a '

[BUG] skge 0000:02:05: read data parity error

2008-01-14 Thread Oliver Pinter (Pintér Olivér)
Hi All! It is fully reproductable under 2.6.22.15, 2.6.23.13 (all tainted and not tainted [4 different kernel] ) and 2 different PC: [BUG] skge :02:05: read data parity error [BUG] skge :02:05: read data parity error steps: 1. login as root 2. start mc 3. cd /sys/bus/pci/drivers/skge/000

Re: occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Michael Chan
On Mon, 2008-01-14 at 20:12 +0100, Eric Dumazet wrote: > Mark Seger a écrit : > > Ignore that last one as it was pointed out to me that we have both nic > > installed on many of our systems and ethtool told me the one > > associated with the nic is actually the broadcom one. > > > > version:

Re: [PATCH 2/2] ixgb: enable sun hardware support for broadcom phy

2008-01-14 Thread Matheos Worku
Jeff Garzik wrote: Auke Kok wrote: From: Matheos Worku <[EMAIL PROTECTED]> Implement support for a SUN-specific PHY. SUN provides a modified 82597-based board with their own PHY that works with very little modification to the code. This patch implements this new PHY which is identified by the

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 14:07:46 EST, Paul Moore said: > There have been quite a few changes in lblnet-2.6_testing since > 2.6.24-rc6-mm1 > so I would recommend taking the whole tree. I'm also not quite sure if Weird. I did a 'git clone git://git.infradead.org/users/pcmoore/lblnet-2.6_testing' in

Re: questions on NAPI processing latency and dropped network packets

2008-01-14 Thread Eric Dumazet
Chris Friesen a écrit : Eric Dumazet wrote: Chris Friesen a écrit : Based on profiling and instrumentation it seems like the cost of sctp_endpoint_lookup_assoc() more than triples, which means that the amount of time that bottom halves are disabled in that function also triples. Any idea

[FIB]: Avoid using static variables without proper locking

2008-01-14 Thread Eric Dumazet
fib_trie_seq_show() uses two helper functions, rtn_scope() and rtn_type() that can write to static storage without locking. Just pass to them a temporary buffer to avoid potential corruption (probably not triggerable but still...) Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/

Re: questions on NAPI processing latency and dropped network packets

2008-01-14 Thread Chris Friesen
Eric Dumazet wrote: Chris Friesen a écrit : Based on profiling and instrumentation it seems like the cost of sctp_endpoint_lookup_assoc() more than triples, which means that the amount of time that bottom halves are disabled in that function also triples. Any idea of the size of sctp hash

Re: occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Eric Dumazet
Mark Seger a écrit : Ignore that last one as it was pointed out to me that we have both nic installed on many of our systems and ethtool told me the one associated with the nic is actually the broadcom one. version:1.4.38 E1B1EC867DEEB8027B2DA0F license:GPL description:Broa

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Paul Moore
On Monday 14 January 2008 1:50:39 pm [EMAIL PROTECTED] wrote: > On Mon, 14 Jan 2008 13:22:10 EST, [EMAIL PROTECTED] said: > > Apparently the only new commit in there since the tree that was in > > 24-rc6-mm1 is 5d95575903fd3865b884952bd93c339d48725c33 adding some > > warning printk's. Would it be

Re: occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Ben Greear
Mark Seger wrote: Ignore that last one as it was pointed out to me that we have both nic installed on many of our systems and ethtool told me the one associated with the nic is actually the broadcom one. version:1.4.38 E1B1EC867DEEB8027B2DA0F license:GPL description:Broadco

Re: [PATCH][v2] phylib: add module owner to the mii_bus structure

2008-01-14 Thread Andy Fleming
On Dec 28, 2007, at 11:31, Ionut Nicu wrote: Prevent unloading mii bus driver module when other modules have references to some phydevs on that bus. Added a new member (module owner) to struct mii_bus and added code to increment the mii bus owner module usage count on phy_connect and decre

Re: [PATCH 9/9] fix sparse warnings

2008-01-14 Thread Eric Dumazet
Robert Olsson a écrit : Thanks for hacking and improving and the trie... another idea that could be also tested. If we look into routing table we see that most leafs only has one prefix Main: Aver depth: 2.57 Max depth: 7 Leaves: 231173 ip route | wc -

Re: occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Mark Seger
Ignore that last one as it was pointed out to me that we have both nic installed on many of our systems and ethtool told me the one associated with the nic is actually the broadcom one. version:1.4.38 E1B1EC867DEEB8027B2DA0F license:GPL description:Broadcom NetXtreme II BCM5

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 13:22:10 EST, [EMAIL PROTECTED] said: > Apparently the only new commit in there since the tree that was in > 24-rc6-mm1 is 5d95575903fd3865b884952bd93c339d48725c33 adding some warning > printk's. Would it be more productive to test against the full tree, or > leaving out the on

Re: [PATCH]drivers/net/phy/: default return value in ioctl phy.c

2008-01-14 Thread Andy Fleming
On Dec 11, 2007, at 09:02, Rini van Zetten wrote: Hello Andy, This patch (to 2.6.23.9) add a default return value EOPNOTSUPP to the ioctl function. The problem with the always 0 return value is that the iwconfig (wireless) tool found a valid device when an ethernet device uses the phy ab

Re: occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Mark Seger
I'll try to get data on the other systems reporting it and as I said it does not happen all that often AND you have to be looking for it. The system I've personally seen it happen on several times is running RHEL4/U4 which redhat numbers 2.6.9-42 and from modinfo I see: version:7.0.33

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 13:05:48 EST, [EMAIL PROTECTED] said: > I'm pulling git://git.infradead.org/users/pcmoore/lblnet-2.6_testing at the > moment, and seeing if there's already a fix in there for this. Apparently the only new commit in there since the tree that was in 24-rc6-mm1 is 5d95575903fd38

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-14 Thread Dzianis Kahanovich
jamal wrote: May be I am mix in mind other code (multi-class loop/walking) and this code. I am deprogramming... ;) Sorry, I just change focus from existing "tc_index=..." to common behaviour ;) [...] Please refer to what i said above; if what i said still doesnt make sense i can create (t

[RFT] sky2: wake-on-lan configuration issues

2008-01-14 Thread Stephen Hemminger
Please test this patch against Linus's current (approx 2.6.24-rc7-git5). Ignore Andrew's premature reversion attempt... This patch disables config mode access after clearing PCI settings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2008-01-14 09:44:22.000

Re: occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Ben Greear
Mark Seger wrote: I had posted the following on linux-net and haven't see any responses possibly because nobody had any or that list is obsolete. I have been told this is the current list for everything networking on linux so I thought I'd try again... Do you see this with multiple network dri

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 11:36:40 EST, Paul Moore said: > Are you still only seeing these problems on loopback? I can't help but > wonder > if this is the skb_clone() problem where it wasn't copying skb->iif causing > SELinux to silently drop the packets. Yes, I've only spotted it on loopback. Th

Re: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

2008-01-14 Thread Kim Phillips
On Thu, 10 Jan 2008 21:41:20 -0700 "Aggrwal Poonam" <[EMAIL PROTECTED]> wrote: > Hello All > > I am waiting for more feedback on the patches. > > If there are no objections please consider them for 2.6.25. > if this isn't going to go through Alessandro Rubini/misc drivers, can it go through th

Re: [PATCH 9/9] fix sparse warnings

2008-01-14 Thread Robert Olsson
Eric Dumazet writes: > > Thats 231173/241649 = 96% with the current Internet routing. > > > > How about if would have a fastpath and store one entry direct in the > > leaf struct this to avoid loading the leaf_info list in most cases? > > > > One could believe that both lookup and dump cou

Re: [patch 5/7] netxen: fix race in interrupt / napi

2008-01-14 Thread Dhananjay Phadke
Ok, I will respin the failed patches. Thanks, -Dhananjay On Sat, 12 Jan 2008, Jeff Garzik wrote: > patch conflicted with > > commit 1706287f6eb58726a9a0e5cbbde87f49757615e3 > Author: David S. Miller <[EMAIL PROTECTED]> > Date: Mon Jan 7 20:51:29 2008 -0800 > > [NETXEN]: Fix ->poll() done

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-14 Thread Rick Jones
*) netperf/netserver support CPU affinity within themselves with the global -T option to netperf. Is the result with taskset much different? The equivalent to the above would be to run netperf with: ./netperf -T 0,7 .. I checked the source codes and didn't find this option. I use netperf V

occasionally corrupted network stats in /proc/net/dev

2008-01-14 Thread Mark Seger
I had posted the following on linux-net and haven't see any responses possibly because nobody had any or that list is obsolete. I have been told this is the current list for everything networking on linux so I thought I'd try again... I suspect the answer will be that it is what it is, but he

Re: [PATCH/RFC] synchronize_rcu(): high latency on idle system

2008-01-14 Thread Stephen Hemminger
On Sun, 13 Jan 2008 16:34:17 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > > > I think it should be in netdev_unregister_kobject(). But that would > > only get rid of one of the two calls to synchronize_rcu() in the > > unregister_netdev. > > Would be already an improvement. > > > The other s

Re: questions on NAPI processing latency and dropped network packets

2008-01-14 Thread Eric Dumazet
Chris Friesen a écrit : Ray Lee wrote: On Jan 10, 2008 9:24 AM, Chris Friesen <[EMAIL PROTECTED]> wrote: After a recent userspace app change, we've started seeing packets being dropped by the ethernet hardware (e1000, NAPI is enabled). The error/dropped/fifo counts are going up in ethtool:

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-14 Thread Stephen Hemminger
On Sun, 13 Jan 2008 11:27:12 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 13 Jan 2008 16:08:38 +0100 supersud501 <[EMAIL PROTECTED]> wrote: > > > > > > > supersud501 wrote: > > > > > > > > > Rafael J. Wysocki wrote: > > > > > >> > > >> Since it seems to be 100% reproducible, it w

Re: [PATCH 2/9] get rid of unused revision element

2008-01-14 Thread Stephen Hemminger
On Mon, 14 Jan 2008 04:06:57 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Robert Olsson <[EMAIL PROTECTED]> > Date: Mon, 14 Jan 2008 12:44:32 +0100 > > > The idea was to have a selective flush of route cache entries when > > a fib insert/delete happened. From what I remember you

Re: Netconf at conf.au 2008?

2008-01-14 Thread martin f. krafft
also sprach YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> [2008.01.14.1206 +0100]: > Very confusing to me... FYI: http://lists.alioth.debian.org/pipermail/netconf-devel/2008-January/000214.html However, I am not entirely convinced. I think conference/tool/protocol are far apart enough so that the

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Paul Moore
On Monday 14 January 2008 11:15:38 am [EMAIL PROTECTED] wrote: > On Sun, 13 Jan 2008 02:35:33 EST, [EMAIL PROTECTED] said: > > I'm seeing problems with Sendmail on 24-rc6-mm1, where the main Sendmail > > is listening on ::1/25, and Fetchmail connects to 127.0.0.1:25 to inject > > mail it has just f

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Sun, 13 Jan 2008 02:35:33 EST, [EMAIL PROTECTED] said: > I'm seeing problems with Sendmail on 24-rc6-mm1, where the main Sendmail is > listening on ::1/25, and Fetchmail connects to 127.0.0.1:25 to inject mail it > has just fetched from an outside server via IMAP - it will often just hang and >

  1   2   >