ipg.c bugs

2008-01-09 Thread linux
I'm just about to test that second memory leak patch, but I gave the original code a careful reading, and found a few problems: * Huge monstrous glaring bug In ipg_interrupt_handler the code to habdle a shared interrupt not caused by this device: if (!(status & IPG_IS_RSVD_MASK))

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-09 Thread Al Viro
On Thu, Jan 10, 2008 at 03:13:48PM +1100, Neil Brown wrote: > > What guarantees that it doesn't happen before we get to callback? AFAICS, > > nothing whatsoever... > > Yes, that's bad isn't it :-) > > I think I should be using sysfs_schedule_callback here. That makes the > required 'get' and '

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-09 Thread Stephen Hemminger
On Wed, 9 Jan 2008 16:03:00 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > (switched to email. Please respond via emailed reply-to-all, not via the > bugzilla web interface). > > On Wed, 9 Jan 2008 13:05:34 -0800 (PST) > [EMAIL PROTECTED] wrote: > > > http://bugzilla.kernel.org/show_bug.c

Re: [Bugme-new] [Bug 9719] New: when a system is configured as a bridge, and at the same time configured to have multipath weighted route, with one leg goes thru NAT and another without NAT, the nat

2008-01-09 Thread Ming-Ching Tiew
Ming-Ching Tiew wrote: Ming-Ching Tiew wrote: What I meant was that it failed on both the kernel versions I tested. I am afraid it is a problem which exists all a long. Perhaps it has been broken quite sometime already. I need to go back to try some older kernel version and see if I could r

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-09 Thread Neil Brown
On Tuesday January 8, [EMAIL PROTECTED] wrote: > > FWIW, I'm going to go through Arjan's collection and post blow-by-blow > analysis of some of those suckers. Tonight, probably... > > Let's take e.g. http://www.kerneloops.org/raw.php?rawid=2618 Thanks for that analysis. ... > > Humm... So we

Re: [Bugme-new] [Bug 9719] New: when a system is configured as a bridge, and at the same time configured to have multipath weighted route, with one leg goes thru NAT and another without NAT, the nat

2008-01-09 Thread Ming-Ching Tiew
Ming-Ching Tiew wrote: What I meant was that it failed on both the kernel versions I tested. I am afraid it is a problem which exists all a long. Perhaps it has been broken quite sometime already. I need to go back to try some older kernel version and see if I could repeat the problem. OK

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Stephen Hemminger
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c > index 060bba4..2ffdf5b 100644 > --- a/net/unix/af_unix.c > +++ b/net/unix/af_unix.c > @@ -50,6 +50,9 @@ > *Arnaldo C. Melo: Remove MOD_{INC,DEC}_USE_COUNT, > * the core infrastructure i

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Brent Casavant
On Thu, 10 Jan 2008, Herbert Xu wrote: > Having said that, I do agree that having TCP and AF_UNIX behave > in the same way is a plus. However, if you really want this to > happen it would help if you had attached a patch :) The following patch appears to fix the problem. However, I would really

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Brent Casavant
On Thu, 10 Jan 2008, Herbert Xu wrote: > The POSIX text for MSG_WAITALL actually says that when used in > conjunction with MSG_PEEK it may not return the full data. That's fine. The problem is that the peek operation returns less data than requested even when sufficient data is available on the

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Herbert Xu
Brent Casavant <[EMAIL PROTECTED]> wrote: > >> Did you try MSG_WAITALL flag? See "man 2 recv". >> A TCP socket handles data in bytes. >> You cannot complain if the amount received by recv() is smaller than expected >> unless you use MSG_WAITALL flag. > > Yes. It made no difference, as noted in th

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Herbert Xu
On Wed, Jan 09, 2008 at 03:19:10PM -0800, Jay Vosburgh wrote: > > >No that's not the point. The point is to move the majority of the code > >into process context so that you can take the RTNL. Once you have taken > >the RTNL you can disable BH all you want and I don't care one bit. > > I'm

Re: 2.6.24-rc6-mm1

2008-01-09 Thread FUJITA Tomonori
On Wed, 9 Jan 2008 10:04:42 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On Wed, Jan 09, 2008 at 08:57:53AM +0900, FUJITA Tomonori wrote: > ... > > diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c > > new file mode 100644 > > index 000..495575a > > --- /dev/null > > +++ b/lib/iommu-h

Re: [Bugme-new] [Bug 9719] New: when a system is configured as a bridge, and at the same time configured to have multipath weighted route, with one leg goes thru NAT and another without NAT, the nat

2008-01-09 Thread Ming-Ching Tiew
Andrew Morton wrote: (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Wed, 9 Jan 2008 11:55:50 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9719 Summary: when a system is configured as a bri

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 09 Jan 2008 15:55:44 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > Because of the above, the existing behavior must still stay the > default. I hope this is your plan. > > By default Linux will not implement this SHOULD, it's a security > issue.

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-09 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Wed, 9 Jan 2008 13:05:34 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9721 > >Summary: wake on lan fails with sky2 module >Product:

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-09 Thread David Miller
From: Francois Romieu <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 00:34:58 +0100 > David Miller <[EMAIL PROTECTED]> : > [...] > > all resolved. All of that code cleanup stuff needs to wait > > until later, let's fix bugs before adding new ones. :-) > > Yes. > > I should be able to test your r816

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 08:46:55 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Wed, 09 Jan 2008 15:32:12 -0800 (PST)), > David Miller <[EMAIL PROTECTED]> says: > > > I question any RFC mandate that shuts down IP communication on a node > > bec

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-09 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > all resolved. All of that code cleanup stuff needs to wait > until later, let's fix bugs before adding new ones. :-) Yes. I should be able to test your r8169 NAPI changes tomorrow. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 09 Jan 2008 15:32:12 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > I question any RFC mandate that shuts down IP communication on a node > because of packets received from remote systems. RFC4862 tell us that we SHOULD disable IP communication. (I

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-09 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > That doesn't seem to do it. Not entirely, at least. After downloading > and partially re-uploading an 800M file, slabtop reports: Ok, enjoy this one. It is definitely better wrt the current problem. More work tomorrow. diff --git a/drivers/net/ip

Re: [PATCH 0/0]: Cassini bug fixes.

2008-01-09 Thread David Miller
From: Laszlo Attila Toth <[EMAIL PROTECTED]> Date: Wed, 09 Jan 2008 17:13:07 +0100 > We tested the card, it works well, all previous bugs are gone (truesize > bug messages and memory comsumption). Thank you for testing. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread David Miller
From: Karsten Keil <[EMAIL PROTECTED]> Date: Wed, 9 Jan 2008 16:36:56 +0100 >If the address is a link-local address formed from an interface >identifier based on the hardware address, which is supposed to be >uniquely assigned (e.g., EUI-64 for an Ethernet interface), IP >operation

Re: [Bugme-new] [Bug 9719] New: when a system is configured as a bridge, and at the same time configured to have multipath weighted route, with one leg goes thru NAT and another without NAT, the nat

2008-01-09 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Wed, 9 Jan 2008 11:55:50 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9719 > >Summary: when a system is configured as a bridge, and at the same

Re: Re : Re : Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread Jay Vosburgh
[EMAIL PROTECTED] wrote: >I mean that instead of arp test an ip in lan or else, i want it to test >127.0.0.1 but in order to do this it must go out and re-enter and then use >wlan0 to go out. In other words, what I think you're saying (and I'm not entirely sure here) is that you want pr

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Jay Vosburgh
Herbert Xu <[EMAIL PROTECTED]> wrote: >On Wed, Jan 09, 2008 at 03:17:09PM -0500, Andy Gospodarek wrote: >> >> Agreed. And despite Herbert's opinion that this isn't the correct fix, >> I think this will work fine. This is one of the cases where we can take >> a write_lock(bond->lock) in softirq c

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Herbert Xu
On Wed, Jan 09, 2008 at 03:17:09PM -0500, Andy Gospodarek wrote: > > Agreed. And despite Herbert's opinion that this isn't the correct fix, > I think this will work fine. This is one of the cases where we can take > a write_lock(bond->lock) in softirq context, so we need to drop that (or > make s

Re : Re : Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread patnel972-linux
I mean that instead of arp test an ip in lan or else, i want it to test 127.0.0.1 but in order to do this it must go out and re-enter and then use wlan0 to go out. - Message d'origine De : Jay Vosburgh <[EMAIL PROTECTED]> À : [EMAIL PROTECTED] Cc : John W. Linville <[EMAIL PROTECTED]>;

Re: Re : Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread Jay Vosburgh
[EMAIL PROTECTED] wrote: >I ignore it, but it seems like it prevent bonding detect link of wlan0. I >enslave wlan0 and i already use use_carrier=1; The default for bonding is use_carrier=1, which makes bonding use the device driver's netif_carrier_on/off state for link detection. Bonding

Re: Re : Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread Andy Gospodarek
On Wed, Jan 09, 2008 at 09:17:06PM +, [EMAIL PROTECTED] wrote: > I ignore it, but it seems like it prevent bonding detect link of wlan0. I > enslave wlan0 and i already use use_carrier=1; > I use bond to have my etherenet ip in wifi at office, else the wireless > connection give temporary and

[PATCH net-2.6.25 19/19] [NETNS] Enable routing configuration in non-initial namespace.

2008-01-09 Thread Denis V. Lunev
I.e. remove the net != &init_net checks from the places, that now can handle other-than-init net namespace. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/fib_frontend.c | 16 --

[PATCH net-2.6.25 16/19] [NETNS] Correctly fill fib_config data.

2008-01-09 Thread Denis V. Lunev
Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/fib_frontend.c | 27 ++- 1 files changed, 14 insertions(+), 13 deletions(-) diff --git a/net/ipv4/fib_frontend.c b/ne

[PATCH net-2.6.25 18/19] [NETNS] Replace init_net with the correct context in fib_frontend.c

2008-01-09 Thread Denis V. Lunev
Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/fib_frontend.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c

[PATCH net-2.6.25 15/19] [NETNS] Provide correct namespace for fibnl netlink socket.

2008-01-09 Thread Denis V. Lunev
This patch makes the netlink socket to be per namespace. That allows to have each namespace its own socket for routing queries. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/netns/ipv4.h

[PATCH net-2.6.25 13/19] [NETNS] Namespacing IPv4 fib rules.

2008-01-09 Thread Denis V. Lunev
The final trick for rules: place fib4_rules_ops into struct net and modify initialization path for this. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/netns/ipv4.h |5 + net/ipv4/

[PATCH net-2.6.25 14/19] [NETNS] Place fib tables into netns.

2008-01-09 Thread Denis V. Lunev
The preparatory work has been done. All we need is to substitute fib_table_hash with net->ipv4.fib_table_hash. Netns context is available when required. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> ---

[PATCH net-2.6.25 12/19] [NETNS] Show routing information from correct namespace (fib_trie.c)

2008-01-09 Thread Denis V. Lunev
This is the second part (for the CONFIG_IP_FIB_TRIE case) of the patch #4, where we have created proc files in namespaces. Now we can dump correct info in them. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTE

[PATCH net-2.6.25 8/19] [NETNS] Add netns parameter to fib_get_table/fib_new_table.

2008-01-09 Thread Denis V. Lunev
This patch extends the fib_get_table and the fib_new_table functions with the network namespace pointer. That will allow to access the table relatively from the network namespace. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lune

[PATCH net-2.6.25 10/19] [NETNS] Add netns to nl_info structure.

2008-01-09 Thread Denis V. Lunev
nl_info is used to track the end-user destination of routing change notification. This is a natural object to hold a namespace on. Place it there and utilize the context in the appropriate places. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-

[PATCH net-2.6.25 2/19] [NETNS] Pass fib_rules_ops into default_pref method.

2008-01-09 Thread Denis V. Lunev
fib_rules_ops contains operations and the list of configured rules. ops will become per/namespace soon, so we need them to be known in the default_pref callback. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTE

[PATCH net-2.6.25 4/19] [NETNS] Add namespace to API for routing /proc entries creation.

2008-01-09 Thread Denis V. Lunev
This adds netns parameter to fib_proc_init/exit and replaces __init specifier with __net_init. After this, we will not yet have these proc files show info from the specific namespace - this will be done when these tables become namespaced. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Dan

[PATCH net-2.6.25 5/19] [IPV4] Check fib4_rules_init failure.

2008-01-09 Thread Denis V. Lunev
This adds error paths into both versions of fib4_rules_init (with/without CONFIG_IP_MULTIPLE_TABLES) and returns error code to the caller. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip

[PATCH netns-2.6.25 0/19] routing virtualization v2

2008-01-09 Thread Denis V. Lunev
Hi, Dave! This set adds namespace support for routing tables & rules manipulation in the different namespaces. So, one could create a namespace and setup IPv4 routing there how he wants. After this patch user will have the ability to configure and observe its own isolated set of routing rules/tab

[PATCH net-2.6.25 1/19] [NETNS] Add netns parameter to fib_rules_(un)register.

2008-01-09 Thread Denis V. Lunev
The patch extends the different fib rules API in order to pass the network namespace pointer. That will allow to access the different tables from a namespace relative object. As usual, the pointer to the init_net variable is passed as parameter so we don't break the network. Acked-by: Benjamin The

[PATCH net-2.6.25 6/19] [NETNS] Refactor fib initialization so it can handle multiple namespaces.

2008-01-09 Thread Denis V. Lunev
This patch makes the fib to be initialized as a subsystem for the network namespaces. The code does not handle several namespaces yet, so in case of a creation of a network namespace, the creation/initialization will not occur. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano

[PATCH net-2.6.25 3/19] [NETNS] Namespacing in the generic fib rules code.

2008-01-09 Thread Denis V. Lunev
Move static rules_ops & rules_mod_lock to the struct net, register the pernet subsys to init them and enjoy the fact that the core rules infrastructure works in the namespace. Real IPv4 fib rules virtualization requires fib tables support in the namespace and will be done seriously later in the pa

[PATCH net-2.6.25 9/19] [NETNS] Add netns parameter to inet_(dev_)add_type.

2008-01-09 Thread Denis V. Lunev
The patch extends the inet_addr_type and inet_dev_addr_type with the network namespace pointer. That allows to access the different tables relatively to the network namespace. The modification of the signature function is reported in all the callers of the inet_addr_type using the pointer to the w

[PATCH net-2.6.25 7/19] [IPV4] Unify access to the routing tables.

2008-01-09 Thread Denis V. Lunev
Replace the direct pointers to local and main tables with calls to fib_get_table() with appropriate argument. This doesn't introduce additional dereferences, but makes the access to fib tables uniform in any (CONFIG_IP_MULTIPLE_TABLES) case. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by:

[PATCH net-2.6.25 11/19] [NETNS] Show routing information from correct namespace (fib_hash.c)

2008-01-09 Thread Denis V. Lunev
This is the second part (for the CONFIG_IP_FIB_HASH case) of the patch #4, where we have created proc files in namespaces. Now we can dump correct info in them. Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTE

Re : Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread patnel972-linux
I ignore it, but it seems like it prevent bonding detect link of wlan0. I enslave wlan0 and i already use use_carrier=1; I use bond to have my etherenet ip in wifi at office, else the wireless connection give temporary and you must pass through proxy then. I'll try arp monitoring but this is anno

[PATCH net-2.6.25 17/19] [NETNS] Pass namespace through ip_rt_ioctl.

2008-01-09 Thread Denis V. Lunev
... up to rtentry_to_fib_config Acked-by: Benjamin Thery <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/route.h |2 +- net/ipv4/af_inet.c |2 +- net/ipv4/fib_frontend.c |8 net/ipv4/i

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Vlad Yasevich
Neil Horman wrote: On Thu, Jan 10, 2008 at 01:38:57AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article <[EMAIL PROTECTED]> (at Wed, 9 Jan 2008 16:36:56 +0100), Karsten Keil <[EMAIL PROTECTED]> says: So I think we should disable the interface now, if DAD fails on a hardware based LLA. I don'

Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread patnel972-linux
I'm doing a bonding with my eth0(e1000 driver) and my wlan card(iwl4965). It work like i want, when i'm in wifi the dhcp give me my ethernet adress. When i unplug the cable, my wlan card become in charge of network. My problem is when i disconnect the wlan card, the bonding does not detect it

Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread linel patrice
I'm doing a bonding with my eth0(e1000 driver) and my wlan card(iwl4965). It work like i want, when i'm in wifi the dhcp give me my ethernet adress. When i unplug the cable, my wlan card become in charge of network. My problem is when i disconnect the wlan card, the bonding does not detect it

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Karsten Keil
On Thu, Jan 10, 2008 at 01:40:51AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Thu, 10 Jan 2008 01:38:57 +0900 (JST)), > YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says: > > > - we could have "dad_reaction" interface variable and > > > 1: disable interface > >

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Karsten Keil
On Wed, Jan 09, 2008 at 11:17:48AM -0500, Neil Horman wrote: > On Wed, Jan 09, 2008 at 04:36:56PM +0100, Karsten Keil wrote: > > Hi, > > > > I tried to run the 1.5.0 Beta2 TAHI Selftest on recent Linux kernel. > > It fails in the Stateless Address Autoconfiguration section with > > 6 tests. > > T

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Andy Gospodarek
On Wed, Jan 09, 2008 at 09:54:56AM -0800, Jay Vosburgh wrote: > Andy Gospodarek <[EMAIL PROTECTED]> wrote: > [...] > >My initial concern was that a slave device could disappear out from > >under us, but it seems like this certainly isn't the case since all > >calls to bond_release are protected by

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-09 Thread Matvejchikov Ilya
Hi folks! I had the same problem too. The solution was the following: http://www.mail-archive.com/netdev@vger.kernel.org/msg37951.html Also have a look at the potential multicasting recovery problem in fs_enet driver: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 Best regards, Matvejchikov

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-09 Thread Matvejchikov Ilya
Hi folks! I had the same problem too. The solution was the following: http://www.mail-archive.com/netdev@vger.kernel.org/msg37951.html Also have a look at the potential multicasting recovery problem in fs_enet driver: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 Best regards, Matvejchikov

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Neil Horman
On Thu, Jan 10, 2008 at 01:38:57AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Wed, 9 Jan 2008 16:36:56 +0100), Karsten > Keil <[EMAIL PROTECTED]> says: > > > So I think we should disable the interface now, if DAD fails on a > > hardware based LLA. > > I don't wan

Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2008-01-09 Thread Patrick McHardy
Pavel Emelyanov wrote: Hi, Patrick. Pavel Emelyanov wrote: There are tree paths in it, that set the skb->proto and then perform common receive manipulations (basically call netif_rx()). I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto() fun

Re: SACK scoreboard

2008-01-09 Thread John Heffner
SANGTAE HA wrote: On Jan 9, 2008 9:56 AM, John Heffner <[EMAIL PROTECTED]> wrote: I also wonder how much of a problem this is (for now, with window sizes of order 1 packets. My understanding is that the biggest problems arise from O(N^2) time for recovery because every ack was expensive. Ha

Re: [Bridge] Re: [ANNOUNCE] bridge-utils 1.4

2008-01-09 Thread Alon Bar-Lev
On 1/9/08, Denys Fedoryshchenko <[EMAIL PROTECTED]> wrote: > > As mentioned in > http://marc.info/?l=linux-bridge&m=113105949718826&w=2 > > Released package doesn't contain ./configure script > > For people who know what is make on, it is easy to run autoconf , but some > know only how to use ./con

Re: SACK scoreboard

2008-01-09 Thread SANGTAE HA
On Jan 9, 2008 9:56 AM, John Heffner <[EMAIL PROTECTED]> wrote: > >> I also wonder how much of a problem this is (for now, with window sizes > >> of order 1 packets. My understanding is that the biggest problems > >> arise from O(N^2) time for recovery because every ack was expensive. > >> Hav

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Brent Casavant
On Wed, 9 Jan 2008, Tetsuo Handa wrote: > Did you try MSG_WAITALL flag? See "man 2 recv". > A TCP socket handles data in bytes. > You cannot complain if the amount received by recv() is smaller than expected > unless you use MSG_WAITALL flag. Yes. It made no difference, as noted in the comments i

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Jay Vosburgh
Andy Gospodarek <[EMAIL PROTECTED]> wrote: [...] >My initial concern was that a slave device could disappear out from >under us, but it seems like this certainly isn't the case since all >calls to bond_release are protected by rtnl-locks, so I think you are >correct that we are safe. I'll test thi

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread Eric Dumazet
David Miller a écrit : From: "Paul E. McKenney" <[EMAIL PROTECTED]> Date: Wed, 9 Jan 2008 06:22:58 -0800 On Wed, Jan 09, 2008 at 11:37:27AM +0100, Eric Dumazet wrote: On Wed, 9 Jan 2008 20:46:37 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: diff --git a/net/ipv4/route.c b/net/ipv4/route

Re: Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread John W. Linville
On Wed, Jan 09, 2008 at 09:00:05AM +, [EMAIL PROTECTED] wrote: > Hi, > > I want to make a bond with my wireless card. The ipw driver create two > interfaces (wlan0 and wmaster0). When i switch the rf_kill button, > ifplug detect wlan0 unplugged but not wmaster0. If i down wlan0 (while > rf_

[patch net-2.6.25 10/10][NETNS][IPV6] make icmpv6_time sysctl per namespace

2008-01-09 Thread Daniel Lezcano
This patch moves the icmpv6_time sysctl to the network namespace structure. Because the ipv6 protocol is not yet per namespace, the variable is accessed relatively to the initial network namespace. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/netns/ipv6.h |1 + net/ipv

[patch net-2.6.25 07/10][NETNS][IPV6] make ip6_frags per namespace

2008-01-09 Thread Daniel Lezcano
The ip6_frags is moved to the network namespace structure. Because there can be multiple instances of the network namespaces, and the ip6_frags is no longer a global static variable, a helper function has been added to facilitate the initialization of the variables. Until the ipv6 protocol is not

[patch net-2.6.25 09/10][NETNS][IPV6] make sysctls route per namespace

2008-01-09 Thread Daniel Lezcano
All the sysctl concerning the routes are moved to the network namespace structure. A helper function is called to initialize the variables. Because the ipv6 protocol is not yet per namespace, the variables are accessed relatively from the network namespace. Signed-off-by: Daniel Lezcano <[EMAIL P

[patch net-2.6.25 05/10][NETNS][IPV6] make multiple instance of sysctl tables

2008-01-09 Thread Daniel Lezcano
Each network namespace wants its own set of sysctl value, eg. we should not be able from a namespace to set a sysctl value for another namespace , especially for the initial network namespace. This patch duplicates the sysctl table when we register a new network namespace for ipv6. The duplicated

[patch net-2.6.25 04/10][NETNS][IPV6] make the ipv6 sysctl to be a netns subsystem

2008-01-09 Thread Daniel Lezcano
The initialization of the sysctl for the ipv6 protocol is changed to a network namespace subsystem. That means when a new network namespace is created the initialization function for the sysctl will be called. That do not change the behavior of the sysctl in case of the kernel with the network nam

[patch net-2.6.25 06/10][NETNS][IPV6] make bindv6only sysctl per namespace

2008-01-09 Thread Daniel Lezcano
This patch moves the bindv6only sysctl to the network namespace structure. Until the ipv6 protocol is not per namespace, the sysctl variable is always from the initial network namespace. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/ipv6.h |1 - include/net/netns/i

[patch net-2.6.25 01/10][NETNS][IPV6] make ipv6_sysctl_register to return a value

2008-01-09 Thread Daniel Lezcano
This patch makes the function ipv6_sysctl_register to return a value. The af_inet6 init function is now able to handle an error and catch it from the initialization of the sysctl. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/ipv6.h |2 +- net/ipv6/af_inet6.c

[patch net-2.6.25 03/10][NETNS][IPV6] add ipv6 structure for netns

2008-01-09 Thread Daniel Lezcano
Like the ipv4 part, this patch adds an ipv6 structure in the net structure to aggregate the different resources to make ipv6 per namespace. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/net_namespace.h |4 include/net/netns/ipv6.h| 10 ++ 2 files changed

[patch net-2.6.25 08/10][NETNS][IPV6] make mld_max_msf readonly in other namespaces

2008-01-09 Thread Daniel Lezcano
The mld_max_msf protects the system with a maximum allowed multicast source filters. Making this variable per namespace can be potentially an problem if someone inside a namespace set it to a big value, that will impact the whole system including other namespaces. I don't see any benefits to have

[patch net-2.6.25 02/10][NETNS][IPV6] make a subsystem for af_inet6

2008-01-09 Thread Daniel Lezcano
This patch add a network namespace subsystem for the af_inet6 module. It does nothing right now, but one of its purpose is to receive the different variables for sysctl in order to initialize them. When the sysctl variable will be moved to the network namespace structure, they will be no longer

[patch net-2.6.25 00/10][NETNS][IPV6] make sysctl per namespace - V3

2008-01-09 Thread Daniel Lezcano
The following patchset makes the ipv6 sysctl to handle multiple network namespaces. Each instance of a network namespace as its own set of sysctl values, that means the behavior of the ipv6 stack can be different depending on the sysctl values setup in the different network namespaces. Changelog:

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 10 Jan 2008 01:38:57 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says: > - we could have "dad_reaction" interface variable and > > 1: disable interface > = 1: disable IPv6 > < 0: ignore (as we do now) Argh, >0, 0 and <0, maybe. --yoshfuj

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 9 Jan 2008 16:36:56 +0100), Karsten Keil <[EMAIL PROTECTED]> says: > So I think we should disable the interface now, if DAD fails on a > hardware based LLA. I don't want to do this, at least, unconditionally. Options (not exclusive): - we could have "ena

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Neil Horman
On Wed, Jan 09, 2008 at 04:36:56PM +0100, Karsten Keil wrote: > Hi, > > I tried to run the 1.5.0 Beta2 TAHI Selftest on recent Linux kernel. > It fails in the Stateless Address Autoconfiguration section with > 6 tests. > These tests are for Duplicate Address Detection (DAD). > They are detect for

Re: [PATCH 0/0]: Cassini bug fixes.

2008-01-09 Thread Laszlo Attila Toth
David Miller wrote: Over the past day I've put together the following set of bug fixes for the Cassini driver. At least with my setup it appears to basically work fine, not leak memory, and the SKB BUG messages go away too. I'll be honest and say that I've devoted a couple days to this work, an

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-09 Thread Arjan van de Ven
Johannes Berg wrote: Rank 1: __ieee80211_rx Warning at net/mac80211/rx.c:1672 Reported 6 times (11 total reports) Same issue that was ranked 2nd last week Johannes has diagnosed this as a driver bug in the iwlwifi drivers More info: http://www.kerneloops.or

Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Karsten Keil
Hi, I tried to run the 1.5.0 Beta2 TAHI Selftest on recent Linux kernel. It fails in the Stateless Address Autoconfiguration section with 6 tests. These tests are for Duplicate Address Detection (DAD). They are detect for the Link Local Address a duplicate address on the network. It seems that ou

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Andy Gospodarek
On Tue, Jan 08, 2008 at 11:58:34PM -0800, Jay Vosburgh wrote: > Krzysztof Oledzki <[EMAIL PROTECTED]> wrote: > > >Fine. Just let you know that someone test your patches and everything > >works, except mentioned problem. > > And I appreciate it; I just wanted to make sure our many fans > fol

Re: SACK scoreboard

2008-01-09 Thread John Heffner
David Miller wrote: From: John Heffner <[EMAIL PROTECTED]> Date: Tue, 08 Jan 2008 23:27:08 -0500 I also wonder how much of a problem this is (for now, with window sizes of order 1 packets. My understanding is that the biggest problems arise from O(N^2) time for recovery because every ack

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread Paul E. McKenney
On Wed, Jan 09, 2008 at 06:31:26AM -0800, David Miller wrote: > From: "Paul E. McKenney" <[EMAIL PROTECTED]> > Date: Wed, 9 Jan 2008 06:22:58 -0800 > > > On Wed, Jan 09, 2008 at 11:37:27AM +0100, Eric Dumazet wrote: > > > On Wed, 9 Jan 2008 20:46:37 +1100 > > > Herbert Xu <[EMAIL PROTECTED]> wrote

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread David Miller
From: "Paul E. McKenney" <[EMAIL PROTECTED]> Date: Wed, 9 Jan 2008 06:22:58 -0800 > On Wed, Jan 09, 2008 at 11:37:27AM +0100, Eric Dumazet wrote: > > On Wed, 9 Jan 2008 20:46:37 +1100 > > Herbert Xu <[EMAIL PROTECTED]> wrote: > > > > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > > index d337

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread Paul E. McKenney
On Wed, Jan 09, 2008 at 11:37:27AM +0100, Eric Dumazet wrote: > On Wed, 9 Jan 2008 20:46:37 +1100 > Herbert Xu <[EMAIL PROTECTED]> wrote: > > > On Wed, Jan 09, 2008 at 08:38:56AM +0100, Eric Dumazet wrote: > > > > > > I am not sure this is valid, since it will do this : > > > > > > r = rt_hash_t

Re: FW: ccid2/ccid3 oopses

2008-01-09 Thread Gerrit Renker
| > >> the easiest way to reproduce is: | > >> | > >> while true;do modprobe dccp_ccid2/3;modprobe -r dccp_ccid2/3;done | > >> after short time, the kernel oopses (messages below) | > >> | | Gerrit, the control socket isn't attached to any CCID module, so the | CCID modules should be safe to re

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-09 Thread Johannes Berg
> Rank 1: __ieee80211_rx > Warning at net/mac80211/rx.c:1672 > Reported 6 times (11 total reports) > Same issue that was ranked 2nd last week > Johannes has diagnosed this as a driver bug in the iwlwifi drivers > More info: http://www.kerneloops.org/search.php?search=

Re: FW: ccid2/ccid3 oopses

2008-01-09 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 09, 2008 at 12:28:27PM +, Gerrit Renker escreveu: > Roland, - > > >> apparently, i got crashes when loading/unloading other driver modules just > >> after ccid2 or ccid3 had been loaded/unloaded _once_ (have not used them at > >> all, just modprobe module;modprobe -r module) > > >>

Re: SACK scoreboard

2008-01-09 Thread Andi Kleen
> Postponing freeing of the skb has major drawbacks. Some time ago I Yes, the trick would be to make sure that it also does not tie up too much memory. e.g. it would need some throttling at least. Also the fast path of kmem_cache_free() is actually not that much different from just putting someth

Re: SACK scoreboard

2008-01-09 Thread Ilpo Järvinen
On Tue, 8 Jan 2008, John Heffner wrote: > Andi Kleen wrote: > > David Miller <[EMAIL PROTECTED]> writes: > > > The big problem is that recovery from even a single packet loss in a > > > window makes us run kfree_skb() for a all the packets in a full > > > window's worth of data when recovery compl

Re: FW: ccid2/ccid3 oopses

2008-01-09 Thread Gerrit Renker
Roland, - >> apparently, i got crashes when loading/unloading other driver modules just >> after ccid2 or ccid3 had been loaded/unloaded _once_ (have not used them at >> all, just modprobe module;modprobe -r module) > >> >> the easiest way to reproduce is: >> >> while true;do modprobe dccp_ccid

Re: [PATCH net-2.6.25] [IPVS] Added include for ip_vs.h for ctl_path (build was broken)

2008-01-09 Thread David Miller
From: "Rami Rosen" <[EMAIL PROTECTED]> Date: Wed, 9 Jan 2008 13:33:49 +0200 > Hi, >The build was broken with this error: > > In file included from net/ipv4/ipvs/ip_vs_rr.c:27: > include/net/ip_vs.h:857: error: array type has incomplete element type > make[3]: *** [net/ipv4/ipvs/ip

Re: [ATM]: Check IP header validity in mpc_send_packet

2008-01-09 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 9 Jan 2008 21:27:45 +1100 > [ATM]: Check IP header validity in mpc_send_packet > > Al went through the ip_fast_csum callers and found this piece of code > that did not validate the IP header. While root crashing the machine > by sending bogus packe

Re: make ipv6_sysctl_register to return a value

2008-01-09 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 09 Jan 2008 10:56:48 +0100 > To clear out any confusion, please can you just ignore all my previous > patches, I will resend a new serie rebased on the work done by Pavel. Ok, thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net-2.6.25 0/4] [NET]: Bloat, bloat and more bloat

2008-01-09 Thread Ilpo Järvinen
On Sat, 5 Jan 2008, Arnaldo Carvalho de Melo wrote: > Em Sat, Jan 05, 2008 at 03:39:04PM +0200, Ilpo Järvinen escreveu: > > Hi Dave, > > > > After Arnaldo got codiff's inline instrumentation bugs fixed > > (thanks! :-)), I got my .c-inline-bloat-o-meter to power up > > reliably after some tweakin

[PATCH net-2.6.25] [IPVS] Added include for ip_vs.h for ctl_path (build was broken)

2008-01-09 Thread Rami Rosen
Hi, The build was broken with this error: In file included from net/ipv4/ipvs/ip_vs_rr.c:27: include/net/ip_vs.h:857: error: array type has incomplete element type make[3]: *** [net/ipv4/ipvs/ip_vs_rr.o] Error 1 This was due to missing include to the header file for ctl_p

  1   2   >