Re: [PATCH] [IPV6] XFRM: Fix auditing rt6i_flags; use RTF_xxx flags instead of RTCF_xxx.

2007-12-07 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Fri, 07 Dec 2007 10:41:48 -0800 (PST) > RTCF_xxx flags, defined in include/linux/in_route.h) are available for > IPv4 route (rtable) entries only. Use RTF_xxx flags instead, > defined in include/linux/ipv6_route.h, for IPv6 route entries (r

2.6.24 net driver mis-patch

2007-12-07 Thread David Miller
Jeff, this belonged in netdev-2.6, Linus's tree doesn't have the BNX2X driver yet, your 2.6.25 bound tree does. As a result you added the ZLIB_INFLATE dependency to the TEHUTI driver in 2.6.24 instead of BNX2X where it belongs, please fix this, thanks :-) commit 70eba18b5664f90d7620905e005b89388

Re: [PATCH net-2.6.25] qdisc: new rate limiter

2007-12-07 Thread Patrick McHardy
Patrick McHardy wrote: Stephen Hemminger wrote: +struct tc_rlim_qopt +{ +__u32 limit;/* fifo limit (packets) */ +__u32rate;/* bits per sec */ This seems a bit small, 512mbit is the maximum rate. Its 4gbit of course, so I guess its enough :) -- To unsubscrib

Re: [PATCH net-2.6.25] qdisc: new rate limiter

2007-12-07 Thread Patrick McHardy
Stephen Hemminger wrote: This is a time based rate limiter for use in network testing. When doing network tests it is often useful to test at reduced bandwidths. The existing Token Bucket Filter provides rate control, but causes bursty traffic that can cause different performance than real world.

Re: [PATCH] iproute2: support dotted-quad netmask notation.

2007-12-07 Thread Andreas Henriksson
On tor, 2007-12-06 at 11:53 -0800, Stephen Hemminger wrote: > On Tue, 4 Dec 2007 14:58:18 +0100 > Andreas Henriksson <[EMAIL PROTECTED]> wrote: > > > Suggested patch for allowing netmask to be specified in dotted quad format. > > See http://bugs.debian.org/357172 > > > > (Known problem: this wil

Re: [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro

2007-12-07 Thread Herbert Xu
On Fri, Dec 07, 2007 at 07:19:38PM +0300, Pavel Emelyanov wrote: > This is essentially IN_DEV_ANDCONF with proper arguments. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Acked-by: Herbert Xu <[EMAIL PROTECTED]> Thanks Pavel! I must have written that one before writing the AND macro :)

Re: [RFC] TCP illinois max rtt aging

2007-12-07 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 7 Dec 2007 15:05:59 +0200 (EET) > On Fri, 7 Dec 2007, David Miller wrote: > > > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > > Date: Fri, 7 Dec 2007 13:05:46 +0200 (EET) > > > > > I guess if you get a large cumulative ACK, the amount of process

[PATCH iproute2] rlim qdisc support.

2007-12-07 Thread Stephen Hemminger
Setup code for new rlim qdisc. For use by anyone who wants to test rlim before kernel inclusion. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/pkt_sched.h |6 ++ tc/Makefile |1 + tc/q_rlim.c | 115 +

[PATCH net-2.6.25] qdisc: new rate limiter

2007-12-07 Thread Stephen Hemminger
This is a time based rate limiter for use in network testing. When doing network tests it is often useful to test at reduced bandwidths. The existing Token Bucket Filter provides rate control, but causes bursty traffic that can cause different performance than real world. Another alternative is the

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-07 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: > Jeff Garzik wrote: >> Divy Le Ray wrote: >>> From: Divy Le Ray <[EMAIL PROTECTED]> >>> >>> Add parity initialization for T3C adapters. >>> >>> Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> >>> --- >>> >>> drivers/net/cxgb3/adapter.h |1 >>> dri

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-07 Thread Jeff Garzik
Divy Le Ray wrote: Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Add parity initialization for T3C adapters. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h |1 drivers/net/cxgb3/cxgb3_main.c| 82 dr

[PATCH] sky2: RX lockup fix

2007-12-07 Thread Stephen Hemminger
I'm using a Marvell 88E8062 on a custom PPC64 blade and ran into RX lockups while validating the sky2 driver. The receive MAC FIFO would become stuck during testing with high traffic. One port of the 88E8062 would lockup, while the other port remained functional. Re-inserting the sky2 module wou

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-07 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Add parity initialization for T3C adapters. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h |1 drivers/net/cxgb3/cxgb3_main.c| 82 drivers/net/cxgb3/cxgb

Re: [PATCH] XFRM: RFC4303 compliant auditing

2007-12-07 Thread Joy Latten
On Fri, 2007-12-07 at 16:06 -0500, Paul Moore wrote: > On Friday 07 December 2007 3:52:31 pm Eric Paris wrote: > > On Fri, 2007-12-07 at 14:57 -0500, Paul Moore wrote: > > > NOTE: This really is an RFC patch, it compiles and boots but that is > > > pretty much all I can promise at this point. I'm

[RFC] [PATCH] easier PBR for dynamic source tables (via multipath)

2007-12-07 Thread Brian S Julin
This is a first swat and not in final form. I hope folks here will help vet my thinking on it. This fills in a missed niche in policy routing support. It allows multipath routes to select nexthop based on the source realm, inside the routing decision step, immediately after RPF is performed. I

Re: [PATCH] s2io: fix inconsistent hardware VLAN tagging during driver init

2007-12-07 Thread Jeff Garzik
Ramkrishna Vepa wrote: Jeff, This patch looks good. Please accept. Ram -Original Message- From: Andy Gospodarek [mailto:[EMAIL PROTECTED] Sent: Thursday, December 06, 2007 11:57 AM To: netdev@vger.kernel.org Cc: [EMAIL PROTECTED]; Rastapur Santosh; Sivakumar Subramani; Sreenivasa Honnur

Re: [PATCH] XFRM: RFC4303 compliant auditing

2007-12-07 Thread Paul Moore
On Friday 07 December 2007 3:52:31 pm Eric Paris wrote: > On Fri, 2007-12-07 at 14:57 -0500, Paul Moore wrote: > > NOTE: This really is an RFC patch, it compiles and boots but that is > > pretty much all I can promise at this point. I'm posting this patch to > > gather feedback from the audit crow

RE: [PATCH] s2io: fix inconsistent hardware VLAN tagging during driver init

2007-12-07 Thread Ramkrishna Vepa
Jeff, This patch looks good. Please accept. Ram > -Original Message- > From: Andy Gospodarek [mailto:[EMAIL PROTECTED] > Sent: Thursday, December 06, 2007 11:57 AM > To: netdev@vger.kernel.org > Cc: [EMAIL PROTECTED]; Rastapur Santosh; Sivakumar Subramani; > Sreenivasa Honnur > Subject: [P

Re: [PATCH] XFRM: RFC4303 compliant auditing

2007-12-07 Thread Eric Paris
On Fri, 2007-12-07 at 14:57 -0500, Paul Moore wrote: > NOTE: This really is an RFC patch, it compiles and boots but that is pretty > much all I can promise at this point. I'm posting this patch to gather > feedback from the audit crowd about the continued overloading of > the AU

Re: [PATCH] XFRM: assorted IPsec fixups

2007-12-07 Thread Paul Moore
On Friday 07 December 2007 3:36:08 pm Eric Paris wrote: > On Fri, 2007-12-07 at 12:11 -0500, Paul Moore wrote: > > This patch fixes a number of small but potentially troublesome things in > > the XFRM/IPsec code: > > > > * Use the 'audit_enabled' variable already in include/linux/audit.h > >Re

Re: [PATCH] XFRM: assorted IPsec fixups

2007-12-07 Thread Eric Paris
On Fri, 2007-12-07 at 12:11 -0500, Paul Moore wrote: > This patch fixes a number of small but potentially troublesome things in the > XFRM/IPsec code: > > * Use the 'audit_enabled' variable already in include/linux/audit.h >Removed the need for extern declarations local to each XFRM audit fu

[git patches] net driver fixes

2007-12-07 Thread Jeff Garzik
Nothing remarkable. Mainly bonding fixes and bringing ibm_newemac up to snuff. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: Documentation/networking/bonding.txt | 29 -

Re: [PATCH 2.6.24 1/1]S2io: Check for register initialization completion before accesing device registers

2007-12-07 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Making sure register initialisation is complete before proceeding further. The driver must wait until initialization is complete before attempting to access any other device registers. Signed-off-by: Surjit Reang <[EMAIL PROTECTED]> Signed-off-by: Sreenivasa Honn

Re: [PATCH 1/11] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support

2007-12-07 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: From: Stefan Roese <[EMAIL PROTECTED]> This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is based on the previous work by Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Stefa

Re: [PATCH 1/2] e1000: fix memcpy in e1000_get_strings

2007-12-07 Thread Jeff Garzik
Auke Kok wrote: From: Roel Kluin <[EMAIL PROTECTED]> drivers/net/e1000/e1000_ethtool.c:113: #define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN drivers/net/e1000e/ethtool.c:106: #define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN E1000_TEST_LEN*ETH_GSTRING_LEN

Re: [patch resend build-breakage] make bnx2x select ZLIB_INFLATE

2007-12-07 Thread Jeff Garzik
Eliezer Tamir wrote: The bnx2x module depends on the zlib_inflate functions. The build will fail if ZLIB_INFLATE has not been selected manually or by building another module that automatically selects it. Modify BNX2X config option to 'select ZLIB_INFLATE' like BNX2 and others. This seems to f

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-07 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Add parity initialization for T3C adapters. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h |1 drivers/net/cxgb3/cxgb3_main.c| 82 drivers/net/cxgb3/cxgb3_offload.c | 15 +

Re: [PATCH 1/8] bonding: Remove trailing NULs from sysfs interface.

2007-12-07 Thread Jeff Garzik
Jay Vosburgh wrote: From: Wagner Ferenc <[EMAIL PROTECTED]> From: Wagner Ferenc <[EMAIL PROTECTED]> Also remove trailing spaces from multivalued files. This fixes output like for example: $ od -c /sys/class/net/bond0/bonding/slaves 000 e t h - l e f t e t h -

Re: [PATCH 1/2] cxgb3 - T3C support update

2007-12-07 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Update GPIO mapping for T3C. Update xgmac for T3C support. Fix typo in mtu table. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> applied #upstream-fixes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

[PATCH] XFRM: RFC4303 compliant auditing

2007-12-07 Thread Paul Moore
NOTE: This really is an RFC patch, it compiles and boots but that is pretty much all I can promise at this point. I'm posting this patch to gather feedback from the audit crowd about the continued overloading of the AUDIT_MAC_IPSEC_EVENT message type - continue to use it or creat

[PATCH] [IPV6] XFRM: Fix auditing rt6i_flags; use RTF_xxx flags instead of RTCF_xxx.

2007-12-07 Thread YOSHIFUJI Hideaki / 吉藤英明
RTCF_xxx flags, defined in include/linux/in_route.h) are available for IPv4 route (rtable) entries only. Use RTF_xxx flags instead, defined in include/linux/ipv6_route.h, for IPv6 route entries (rt6_info). Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> -- diff --git a/net/ipv6/xfrm6_policy

Re: [patch 06/22] NET: DM9000: Use kthread to probe MII status when device open

2007-12-07 Thread Ben Dooks
On Fri, Nov 23, 2007 at 08:38:51PM -0500, Jeff Garzik wrote: > seems like a delayed workqueue would be most appropriate for this. I like the fact that the use of kthread shows the user how much cpu time is being used by the execution of monitoring the phy. How badly do people object to using a kth

Re: [patch 22/22] NET: DM9000: Show the MAC address source after printing MAC

2007-12-07 Thread Ben Dooks
On Fri, Nov 23, 2007 at 08:43:04PM -0500, Jeff Garzik wrote: > ACK patches 16-22 Is reposting here ok to get these queued for the next kernel release, or are there people to CC: for this? -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from th

Re: [RFC] TCP illinois max rtt aging

2007-12-07 Thread Ilpo Järvinen
On Fri, 7 Dec 2007, Ilpo Järvinen wrote: > On Fri, 7 Dec 2007, David Miller wrote: > > > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > > Date: Fri, 7 Dec 2007 13:05:46 +0200 (EET) > > > > > I guess if you get a large cumulative ACK, the amount of processing is > > > still overwhelming (added Dave

[PATCH] Use BUILD_BUG_ON in inet_timewait_sock.c checks

2007-12-07 Thread Pavel Emelyanov
Make the INET_TWDR_TWKILL_SLOTS vs sizeof(twdr->thread_slots) check nicer. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c index a60b99e..d43e787 100644 --- a/net/ipv4/inet_timewait_sock.c +++ b/net/ipv4/inet_timew

[PATCH] Use BUILD_BUG_ON for tcp_skb_cb size checking

2007-12-07 Thread Pavel Emelyanov
The sizeof(struct tcp_skb_cb) should not be less than the sizeof(skb->cb). This is checked in net/ipv4/tcp.c, but this check can be made more gracefully. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 8e65182..c8bebd3 100644 --- a/net/ip

[PATCH] XFRM: assorted IPsec fixups

2007-12-07 Thread Paul Moore
This patch fixes a number of small but potentially troublesome things in the XFRM/IPsec code: * Use the 'audit_enabled' variable already in include/linux/audit.h Removed the need for extern declarations local to each XFRM audit fuction * Convert 'sid' to 'secid' The 'sid' name is specific

Re: TCP event tracking via netlink...

2007-12-07 Thread Ilpo Järvinen
On Thu, 6 Dec 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Thu, 6 Dec 2007 01:18:28 +0200 (EET) > > > On Wed, 5 Dec 2007, David Miller wrote: > > > > > I assume you're using something like carefully crafted printk's, > > > kprobes, or even ad-hoc statistic counte

[PATCH net-2.6.25] Cleanup sysctl manipulations in devinet.c

2007-12-07 Thread Pavel Emelyanov
This includes: * moving neigh_sysctl_(un)register calls inside devinet_sysctl_(un)register ones, as they are always called in pairs; * making __devinet_sysctl_unregister() to unregister the ipv4_devconf struct, while original devinet_sysctl_unregister() works with the in_device to ha

[PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro

2007-12-07 Thread Pavel Emelyanov
This is essentially IN_DEV_ANDCONF with proper arguments. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h index dd093ea..962a062 100644 --- a/include/linux/inetdevice.h +++ b/include/linux/inetdevice.h @@ -78,9 +78,7 @@

[PATCH 2.6.25 3/3] ipv4: last default route is a fib table property

2007-12-07 Thread Denis V. Lunev
ipv4: last default route is a fib table property Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Acked-by: Alexey Kuznetsov <[EMAIL PROTECTED]> --- include/net/ip_fib.h |1 + net/ipv4/fib_hash.c | 16 net/ipv4/fib_trie.c | 18 +- 3 files changed, 18 in

[PATCH 2.6.25 2/3] ipv4: unify assignment of fi to fib_result

2007-12-07 Thread Denis V. Lunev
ipv4: unify assignment of fi to fib_result Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Acked-by: Alexey Kuznetsov <[EMAIL PROTECTED]> --- net/ipv4/fib_hash.c | 19 --- net/ipv4/fib_lookup.h | 10 ++ net/ipv4/fib_trie.c | 19 --- 3 files chan

[PATCH 2.6.25 1/3] ipv4: no need pass pointer to a default into fib_detect_death

2007-12-07 Thread Denis V. Lunev
ipv4: no need pass pointer to a default into fib_detect_death Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Acked-by: Alexey Kuznetsov <[EMAIL PROTECTED]> --- net/ipv4/fib_hash.c |4 ++-- net/ipv4/fib_lookup.h|2 +- net/ipv4/fib_semantics.c |6 +++--- net/ipv4/fib_trie.c

IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

2007-12-07 Thread Paul Moore
Hello all, As part of the IPv6 "gap analysis" that the Linux Foundation is currently doing I've been looking at the IPsec auditing requirements as defined in RFC4303 and I came across some odd behavior regarding SA sequence number overflows ... RFC4303 states the following: 3.3.3. Sequenc

Re: [patch 07/22] NET: DM9000: Use msleep() instead of udelay()

2007-12-07 Thread Ben Dooks
On Fri, Nov 23, 2007 at 08:39:45PM -0500, Jeff Garzik wrote: > are you sure you cannot sleep during suspend? Yes. This is not the first driver that has had this problem, see the sm501 as another example. -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To uns

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

2007-12-07 Thread Richard Knutsson
David Miller wrote: From: Richard Knutsson <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 15:37:46 +0100 David Miller wrote: But this time I'll just let you know up front that I don't see much value in this patch. It is not a clear improvement to replace int's with bool's in my mind and t

Re: [patch 0/3][IPV6]: remove ifdef in route6 init/fini functions

2007-12-07 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 07 Dec 2007 14:13:25 +0100), Daniel Lezcano <[EMAIL PROTECTED]> says: > The route6 init function is a little difficult to read because it contains > a lot of ifdef. The patchset redefines the usual static inline functions when > the code is to be disabled

[patch 1/3][IPV6]: create route6 proc init-fini functions

2007-12-07 Thread Daniel Lezcano
Make the proc creation/destruction to be a separate function. That allows to remove the #ifdef CONFIG_PROC_FS in the init/fini function and make them more readable. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/ipv6/route.c | 58 +-

[patch 0/3][IPV6]: remove ifdef in route6 init/fini functions

2007-12-07 Thread Daniel Lezcano
The route6 init function is a little difficult to read because it contains a lot of ifdef. The patchset redefines the usual static inline functions when the code is to be disabled by configuration, so we can call the code without taking care of the config option in the init function. -- -- To un

[patch 2/3][IPV6]: remove ifdef in route6 for xfrm6

2007-12-07 Thread Daniel Lezcano
The following patch create the usual static inline functions to disable the xfrm6_init and xfrm6_fini function when XFRM is off. That's allow to remove some ifdef and make the code a little more clear. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/xfrm.h | 16 +--

[patch 3/3][IPV6]: route6 remove ifdef for fib_rules

2007-12-07 Thread Daniel Lezcano
The patch defines the usual static inline functions when the code is disabled for fib6_rules. That's allow to remove some ifdef in route.c file and make the code a little more clear. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/ip6_fib.h | 12 +++- net/ipv6/route.c

Re: 2.6.24-rc4-mm1

2007-12-07 Thread Ilpo Järvinen
On Wed, 5 Dec 2007, David Miller wrote: > From: Reuben Farrelly <[EMAIL PROTECTED]> > Date: Thu, 06 Dec 2007 17:59:37 +1100 > > > On 5/12/2007 4:17 PM, Andrew Morton wrote: > > > - Lots of device IDs have been removed from the e1000 driver and moved > > > over > > > to e1000e. So if your e100

[PATCH net-2.6.25 3/3]sysctl: make sysctl_somaxconn per-namespace

2007-12-07 Thread Pavel Emelyanov
Just move the variable on the struct net and adjust its usage. Others sysctls from sys.net.core table are more difficult to virtualize (i.e. make them per-namespace), but I'll look at them as well a bit later. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/linux/soc

[PATCH net-2.6.25 2/3]sysctl: prepare core tables to point to netns variables

2007-12-07 Thread Pavel Emelyanov
Some of ctl variables are going to be on the struct net. Here's the way to adjust the ->data pointer on the ctl_table-s to point on the right variable. Since some pointers still point on the global variables, I keep turning the write bits off on such tables. This looks to become a common procedu

[PATCH net-2.6.25 1/3]sysctl: make the sys.net.core sysctls per-namespace

2007-12-07 Thread Pavel Emelyanov
Making them per-namespace is required for the following two reasons: First, some ctl values have a per-namespace meaning. Second, making them writable from the sub-namespace is an isolation hole. So I introduce the pernet operations to create these tables. For init_net I use the existing stat

Re: [RFC] TCP illinois max rtt aging

2007-12-07 Thread Ilpo Järvinen
On Fri, 7 Dec 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Fri, 7 Dec 2007 13:05:46 +0200 (EET) > > > I guess if you get a large cumulative ACK, the amount of processing is > > still overwhelming (added DaveM if he has some idea how to combat it). > > > > Even a

Re: [RFC] TCP illinois max rtt aging

2007-12-07 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 7 Dec 2007 13:05:46 +0200 (EET) > I guess if you get a large cumulative ACK, the amount of processing is > still overwhelming (added DaveM if he has some idea how to combat it). > > Even a simple scenario (this isn't anything fancy at all, wil

Re: [PATCH] AF_RXRPC: Add a missing goto

2007-12-07 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Fri, 07 Dec 2007 11:23:55 + > Add a missing goto to error handling in the RXKAD security module for > AF_RXRPC. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> Applied, thanks David. -- To unsubscribe from this list: send the line "unsubscr

[PATCH] AF_RXRPC: Add a missing goto

2007-12-07 Thread David Howells
Add a missing goto to error handling in the RXKAD security module for AF_RXRPC. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- net/rxrpc/rxkad.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index e09a95a..8e69d69 100644 ---

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-07 Thread Denis V. Lunev
Andrew Morton wrote: > On Fri, 07 Dec 2007 04:51:37 + David Woodhouse <[EMAIL PROTECTED]> wrote: > >> On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote: >>> Well I clearly goofed when I added the initial network namespace support >>> for /proc/net. Currently things work but there are

Re: [RFC] TCP illinois max rtt aging

2007-12-07 Thread Ilpo Järvinen
On Thu, 6 Dec 2007, Lachlan Andrew wrote: > On 04/12/2007, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > On Mon, 3 Dec 2007, Lachlan Andrew wrote: > > > > > > When SACK is active, the per-packet processing becomes more involved, > > > tracking the list of lost/SACKed packets. This causes a CPU spik

Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2007-12-07 Thread Patrick McHardy
Pavel Emelyanov wrote: There are tree paths in it, that set the skb->proto and then perform common receive manipulations (basically call netif_rx()). I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto() function (I hope the name is good) to set

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-07 Thread Andrew Morton
On Fri, 07 Dec 2007 04:51:37 + David Woodhouse <[EMAIL PROTECTED]> wrote: > On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote: > > Well I clearly goofed when I added the initial network namespace support > > for /proc/net. Currently things work but there are odd details visible > > t

[PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2007-12-07 Thread Pavel Emelyanov
There are tree paths in it, that set the skb->proto and then perform common receive manipulations (basically call netif_rx()). I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto() function (I hope the name is good) to setup the skb proto and merg

[PATCH net-2.6.25] Remove unused devconf macros

2007-12-07 Thread Pavel Emelyanov
The SNMP_INC_STATS_OFFSET_BH is used only by ICMP6_INC_STATS_OFFSET_BH. The ICMP6_INC_STATS_OFFSET_BH is unused. Can we drop them? Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/net/ipv6.h b/include/net/ipv6.h index a84f3f6..38df94b 100644 --- a/include/net/ipv6.h +

Re: sockets affected by IPsec always block (2.6.23)

2007-12-07 Thread Stefan Rompf
Am Freitag, 7. Dezember 2007 04:20 schrieb David Miller: > If IPSEC takes a long time to resolve, and we don't block, the > connect() can hard fail (we will just keep dropping the outgoing SYN > packet send attempts, eventually hitting the retry limit) in cases > where if we did block it would not

[PATCH][IPV4] Swap the ifa allocation with the"ipv4_devconf_setall" call

2007-12-07 Thread Pavel Emelyanov
According to Herbert, the ipv4_devconf_setall should be called only when the ifa is added to the device. However, failed ifa allocation may bring things into inconsistent state. Move the call to ipv4_devconf_setall after the ifa allocation. Fits both net-2.6 (with offsets) and net-2.6.25 (cleanl

Re: [PATCH 14/20] net/ipv4/cipso_ipv4.c: use LIST_HEAD instead of LIST_HEAD_INIT

2007-12-07 Thread David Miller
From: Denis Cheng <[EMAIL PROTECTED]> Date: Fri, 7 Dec 2007 00:04:36 +0800 > single list_head variable initialized with LIST_HEAD_INIT could almost > always can be replaced with LIST_HEAD declaration, this shrinks the code > and looks better. > > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> A

Re: [PATCH 13/20] net/core/dev.c: use LIST_HEAD instead of LIST_HEAD_INIT

2007-12-07 Thread David Miller
From: Denis Cheng <[EMAIL PROTECTED]> Date: Fri, 7 Dec 2007 00:01:26 +0800 > single list_head variable initialized with LIST_HEAD_INIT could almost > always can be replaced with LIST_HEAD declaration, this shrinks the code > and looks better. > > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> A

Re: [PATCH 2.6.25] net: move trie_local and trie_main into the proc iterator

2007-12-07 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 6 Dec 2007 18:00:12 +0300 > From: Eric W. Biederman <[EMAIL PROTECTED]> > > We only use these variables when displaying the trie in proc so > place them into the iterator to make this explicit. We should > probably do something smarter to han

Re: [PATCH 2.6.25] Remove ip_fib_local_table and ip_fib_main_table defines

2007-12-07 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 6 Dec 2007 17:58:25 +0300 > From: Eric W. Biederman <[EMAIL PROTECTED]> > > There are only 2 users and it doesn't hurt to call fib_get_table > instead, and it makes it easier to make the fib network namespace > aware. > > Signed-off-by: Eric

Re: [patch 6/6] ipv6 - route6/fib6 : dont panic a kmem_cache_create

2007-12-07 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:53:35 +0100 > If the kmem_cache_creation fails, the kernel will panic. It is acceptable > if the system is booting, but if the ipv6 protocol is compiled as a module > and it is loaded after the system has booted, do we want to pani

Re: [patch 5/6] ipv6 - make af_inet6 to check ip6_route_init return value

2007-12-07 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:53:34 +0100 > The af_inet6 initialization function does not check the return code > of the route initilization, so if something goes wrong, the protocol > initialization will continue anyway. > This patch takes into account the mod

Re: [patch 4/6] ipv6 - make ip6_route_init to return an error code

2007-12-07 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:53:33 +0100 > The route initialization function does not return any value to notify if > the initialization is successful or not. This patch checks all calls made > for the initilization in order to return a value for the caller. >

Re: [patch 3/6] ipv6 - make fib6_rules_init to return an error code

2007-12-07 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:53:32 +0100 > When the fib_rules initialization finished, no return code is provided > so there is no way to know, for the caller, if the initialization has > been successful or has failed. This patch fix that. > > Signed-off-by:

Re: [patch 2/6] ipv6 - make xfrm6_init to return an error code

2007-12-07 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:53:31 +0100 > The xfrm initialization function does not return any error code, so > if there is an error, the caller can not be advise of that. > This patch checks the return code of the different called functions > in order to ret

Re: [patch 1/6] ipv6 - make fib6_init to return an error code

2007-12-07 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:53:30 +0100 > If there is an error in the initialization function, nothing is followed up > to the caller. So I add a return value to be set for the init function. > > Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> > Acked-by:

Re: [PATCH 2.6.25] multiple namespaces in the all dst_ifdown routines

2007-12-07 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 6 Dec 2007 15:17:46 +0300 > move dst entries to a namespace loopback to catch refcounting leaks. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in th