Re: [PATCH 1/11] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support

2007-11-29 Thread Christoph Hellwig
On Fri, Nov 30, 2007 at 04:40:23PM +1100, Benjamin Herrenschmidt wrote: > From: Stefan Roese <[EMAIL PROTECTED]> > > This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. > These PHY chips are used on PowerPC 440EPx boards. > The PHY code is based on the previous work by Stef

forcedeth hangs on loading

2007-11-29 Thread Vasily Averin
Hi Ayaz, While testing new OpenVZ kernel based on RHEL5.1 kernel 2.6.18-53.el5 we have observed that node loads forcedeth driver too long: Nov 28 14:04:19 ts49 kjournald starting. Commit interval 5 seconds Nov 28 14:04:19 ts49 EXT3-fs: mounted filesystem with ordered data mode. ... Nov 28 19:34

[PATCH 2.6.24 1/1]S2io: Fixed the case when the card initialization fails on mtu change

2007-11-29 Thread Sreenivasa Honnur
Fix the case when the card initialization fails on a mtu change and then close is called (due to ifdown), which frees non existent rx buffers. - Returning appropriate error codes in init_nic function. - In s2io_close function s2io_card_down is called only when device is up. - In s2io_change_mtu fu

[PATCH 11/11] emac: Update file headers copyright notices

2007-11-29 Thread Benjamin Herrenschmidt
This updates the copyright notices of the new EMAC driver to avoid confusion as who is to be blamed for new bugs. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |5 + drivers/net/ibm_newemac/core.h |5 + drivers/net/ibm_newemac/deb

[PATCH 10/11] ibm_newemac: Call dev_set_drvdata() before tah_reset()

2007-11-29 Thread Benjamin Herrenschmidt
From: Valentine Barshak <[EMAIL PROTECTED]> The patch moves dev_set_drvdata(&ofdev->dev, dev) up before tah_reset(ofdev) is called to avoid a NULL pointer dereference, since tah_reset uses drvdata. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> Signed-off-by: Benjamin Herrenschmidt <[EMAIL

[PATCH 9/11] ibm_newemac: Fix typo reading TAH channel info

2007-11-29 Thread Benjamin Herrenschmidt
From: Valentine Barshak <[EMAIL PROTECTED]> This patch fixes a typo in ibm_newemac/core.c (tah_port should be used instead of tah_ph) Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |2 +- 1 fi

[PATCH 8/11] ibm_newemac: Correct opb_bus_freq value

2007-11-29 Thread Benjamin Herrenschmidt
From: Valentine Barshak <[EMAIL PROTECTED]> The EMAC4_MR1_OBCI(freq) macro expects freg in MHz, while opb_bus_freq is kept in Hz. Correct this. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- diff -pruN linux-2.6.orig/drivers/net

[PATCH 5/11] ibm_newemac: Cleanup/Fix RGMII MDIO support detection

2007-11-29 Thread Benjamin Herrenschmidt
More than just "AXON" version of EMAC RGMII supports MDIO, so replace the current test with a generic property in the device-tree that indicates such support. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Acked-by: Stefan Roese <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/sequoia.dt

[PATCH 7/11] ibm_newemac: Skip EMACs that are marked unused by the firmware

2007-11-29 Thread Benjamin Herrenschmidt
From: Hugh Blemings <[EMAIL PROTECTED]> Depending on how the 44x processors are wired, some EMAC cells might not be useable (and not connected to a PHY). However, some device-trees may choose to still expose them (since their registers are present in the MMIO space) but with an "unused" property i

[PATCH 6/11] ibm_newemac: Cleanup/fix support for STACR register variants

2007-11-29 Thread Benjamin Herrenschmidt
There are a few variants of the STACR register that affect more than just the "AXON" version of EMAC. Replace the current test of various chip models with tests for generic properties in the device-tree. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Acked-by: Stefan Roese <[EMAIL PROTE

[PATCH 3/11] ibm_newemac: Fix ZMII refcounting bug

2007-11-29 Thread Benjamin Herrenschmidt
When using ZMII for MDIO only (such as 440GX with RGMII for data and ZMII for MDIO), the ZMII code would fail to properly refcount, thus triggering a BUG_ON(). Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Acked-by: Stefan Roese <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/zmii.c

[PATCH 4/11] ibm_newemac: Workaround reset timeout when no link

2007-11-29 Thread Benjamin Herrenschmidt
With some PHYs, when the link goes away, the EMAC reset fails due to the loss of the RX clock I believe. The old EMAC driver worked around that using some internal chip-specific clock force bits that are different on various 44x implementations. This is an attempt at doing it differently, by avoi

[PATCH 1/11] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support

2007-11-29 Thread Benjamin Herrenschmidt
From: Stefan Roese <[EMAIL PROTECTED]> This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is based on the previous work by Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> Sign

[PATCH 2/11] ibm_newemac: Add ET1011c PHY support

2007-11-29 Thread Benjamin Herrenschmidt
From: Stefan Roese <[EMAIL PROTECTED]> This adds support for the Agere ET1011c PHY as found on the AMCC Taishan board. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/phy.c | 37 +

[PATCH 0/11] ibm_newemac: Candidate patches for 2.6.25

2007-11-29 Thread Benjamin Herrenschmidt
Here are the patches I have pending for EMAC. With those, along with some other powerpc patches scheduled for 2.6.25 for adding support for those various boards, I have EMAC now working properly on a variety of platforms, such as Taishan (440GX), Katmai (440SP), EP405 (405GP), Bamboo (440EP), etc..

Please pull 'fixes-davem' branch of wireless-2.6

2007-11-29 Thread John W. Linville
Dave/Herbert, Here is another clutch of patches intended for 2.6.24. Let me know if there are any problems! Thanks, John --- Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6.git fixes-davem --- The following changes since c

Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-11-29 Thread John W. Linville
Jeff, A few fixes intended for 2.6.24... Let me know if there are any problems! Thanks, John --- Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6.git fixes-jgarzik --- The following changes since commit d9f8bcbf67a0ee67c8cb

[PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-11-29 Thread Wang Chen
(This patch base on "PATCH 2/3".) UDP_MIB_INERRORS increment is in different way for IPv4 and IPv6. For the consistence, change UDP6_INC_STATS_USER to UDP6_INC_STATS_BH. Signed-off-by: Wang Chen <[EMAIL PROTECTED]> --- udp.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) --- linux-2.

[PATCH 2/3] [UDP]: Clean up for IS_UDPLITE macro

2007-11-29 Thread Wang Chen
(This patch base on "PATCH 1/3".) Since we have macro IS_UDPLITE, we can use it. Signed-off-by: Wang Chen <[EMAIL PROTECTED]> --- ipv4/udp.c | 19 +++ ipv6/udp.c | 14 -- 2 files changed, 19 insertions(+), 14 deletions(-) diff -Nurp linux-2.6.24.rc3.org/net/ipv4/

[PATCH 1/3] [SNMP]: Defer InDataGrams increment until recvmsg() does checksum

2007-11-29 Thread Wang Chen
From: Wang Chen <[EMAIL PROTECTED]> Thanks dave, herbert, gerrit, andi and other people for your discussion about this problem. UdpInDatagrams can be confusing because it counts packets that might be dropped later. Move UdpInDatagrams into recvmsg() as allowed by the RFC. Signed-off-by: Wang C

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 05:25:01PM -0800, Paul E. McKenney wrote: > > You have in mind something like the following? > > #define rcu_assign_pointer(p, v) \ > ({ \ > if (!__builtin_constant_p(v) || \ > ((v) != NULL)) \ > smp_wmb(); \ >

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-29 Thread Rusty Russell
On Friday 30 November 2007 03:53:34 Arjan van de Ven wrote: > On Mon, 26 Nov 2007 10:25:33 -0800 > > > Agreed. On first glance, I was intrigued but: > > > > 1) Why is everyone so concerned that export symbol space is large? > > - does it cost cpu or running memory? > > yes. about 120 bytes per

Re: [patch 1/1] ctc: make use of alloc_netdev()

2007-11-29 Thread Peter Tiedemann
To maintain the area used for sysfs attribute data which may be stored already previously. Mit freundlichen Grüßen / Best regards / Saluti, Peter Tiedemann - phone: +49-7031-16-4172 fax: ++3159e-mail: [EMAIL PROTECTED] IBM Deutschland Entwicklung Gmb

RE: [PATCH -mm] [RFC] I/OAT: Handle incoming udp through ioatdma

2007-11-29 Thread Nelson, Shannon
>From: J Hadi Salim [mailto:[EMAIL PROTECTED] On Behalf Of jamal > >On Thu, 2007-29-11 at 12:08 -0800, Nelson, Shannon wrote: >> [RFC] I/OAT: Handle incoming udp through ioatdma >> >> From: Shannon Nelson <[EMAIL PROTECTED]> >> >> If the incoming udp packet is larger than >sysctl_udp_dma_copybre

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Paul E. McKenney
On Fri, Nov 30, 2007 at 10:49:00AM +1100, Herbert Xu wrote: > On Thu, Nov 29, 2007 at 06:36:50AM -0800, Paul E. McKenney wrote: > > > > That certainly is an interesting tradeoff... Save a memory barrier > > when assigning NULL, but pay an extra test and branch in all cases. > > Though it does make

Re: wireless vs. alignment requirements

2007-11-29 Thread H. Peter Anvin
Herbert Xu wrote: On Thu, Nov 29, 2007 at 04:28:34PM -0800, H. Peter Anvin wrote: sky2 is the exception here, not the rule. It is, but it's not unique. Several USB adapters have the same problem, for example. Notice the common theme here that slow (or slower, i.e., certainly nowhere near 10G

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 04:28:34PM -0800, H. Peter Anvin wrote: > > >sky2 is the exception here, not the rule. > > It is, but it's not unique. Several USB adapters have the same problem, > for example. Notice the common theme here that slow (or slower, i.e., certainly nowhere near 10Gb) NICs ar

Re: wireless vs. alignment requirements

2007-11-29 Thread H. Peter Anvin
Herbert Xu wrote: On Thu, Nov 29, 2007 at 09:50:35AM -0800, H. Peter Anvin wrote: Uhm, most cards affected *ARE* Ethernet cards, due to the bloody 14-byte header. Well most Ethernet drivers are using NET_IP_ALIGN which means that IP stack gets aligned packets only. sky2 is the exception here,

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 09:50:35AM -0800, H. Peter Anvin wrote: > > Uhm, most cards affected *ARE* Ethernet cards, due to the bloody 14-byte > header. Well most Ethernet drivers are using NET_IP_ALIGN which means that IP stack gets aligned packets only. sky2 is the exception here, not the rule.

Re: + xfrm_policy-warning-fix.patch added to -mm tree

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 09:32:02AM -0800, Andrew Morton wrote: > > > diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c > > index b702bd8..9a4cf2e 100644 > > --- a/net/xfrm/xfrm_policy.c > > +++ b/net/xfrm/xfrm_policy.c > > @@ -1344,6 +1344,7 @@ restart: > > xfrm_nr += pols[0]->xfrm_n

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 06:36:50AM -0800, Paul E. McKenney wrote: > > That certainly is an interesting tradeoff... Save a memory barrier > when assigning NULL, but pay an extra test and branch in all cases. > Though it does make for a simpler rule -- just use rcu_assign_pointer() > in all cases.

Re: ZD1211RW unaligned accesses...

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 04:45:33PM -0500, John W. Linville wrote: > So, did the patch below fix the problem? Should I apply it? I'm keen to find out the result too :) Chances are it does make progress however we may still have the general wireless/IP stack alignment issue that we are still discu

Re: [PATCH -mm] [RFC] I/OAT: Handle incoming udp through ioatdma

2007-11-29 Thread jamal
On Thu, 2007-29-11 at 12:08 -0800, Nelson, Shannon wrote: > [RFC] I/OAT: Handle incoming udp through ioatdma > > From: Shannon Nelson <[EMAIL PROTECTED]> > > If the incoming udp packet is larger than sysctl_udp_dma_copybreak, try > pushing it through the ioatdma asynchronous memcpy. This is very

Re: [PATCH 2/2] [IPSEC]: Reinject v6 packet on input instead of calling netfilter

2007-11-29 Thread jamal
On Thu, 2007-29-11 at 22:21 +0100, Patrick McHardy wrote: > > http://lists.openwall.net/netdev/2007/10/16/88 > > I wouldnt mind just ipv4 going in - but that would be lacking > > consistency. Is there anything that can be done to get the extension > > headers to be processed only once? > > >

Re: [PATCH 0/2] netem: trace enhancement

2007-11-29 Thread Patrick McHardy
Stephen Hemminger wrote: Still interested in this. I got part way through integrating it but had concerns about the API from the application to netem for getting the data. It seemed like there ought to be a better way to do it that could handle large data sets better, but never really got a good

Re: [PATCH 0/2] netem: trace enhancement

2007-11-29 Thread Stephen Hemminger
On Tue, 27 Nov 2007 14:57:26 +0100 Ariane Keller <[EMAIL PROTECTED]> wrote: > I just wanted to ask whether there is a general interest in this patch. > If yes: great, how to proceed? > otherwise: please let me know why. > > Thanks! > > > > > Ariane Keller wrote: > > Hi Stephen > > > > Approx

Re: ZD1211RW unaligned accesses...

2007-11-29 Thread John W. Linville
So, did the patch below fix the problem? Should I apply it? John On Sat, Nov 24, 2007 at 11:02:16PM +0800, Herbert Xu wrote: > On Wed, Nov 21, 2007 at 01:00:44PM +, Shaddy Baddah wrote: > > > > It hasn't seemed to. I patched the source (confirming the patched lines > > are in), compiled, in

Re: [PATCH 2/2] [IPSEC]: Reinject v6 packet on input instead of calling netfilter

2007-11-29 Thread Patrick McHardy
jamal wrote: On Thu, 2007-29-11 at 21:55 +0100, Patrick McHardy wrote: jamal wrote: [ can't quote because non-inline attachment ] Evolution seems to have whitespace issues everytime i inlined the attachment; and Dave has been able to tolerate me doing this so far. I have just read it

Re: [PATCH 2/2] [IPSEC]: Reinject v6 packet on input instead of calling netfilter

2007-11-29 Thread jamal
On Thu, 2007-29-11 at 21:55 +0100, Patrick McHardy wrote: > jamal wrote: > > [ can't quote because non-inline attachment ] Evolution seems to have whitespace issues everytime i inlined the attachment; and Dave has been able to tolerate me doing this so far. I have just read it in > I think Yoshi

Re: [PATCH 2/2] [IPSEC]: Reinject v6 packet on input instead of calling netfilter

2007-11-29 Thread Patrick McHardy
jamal wrote: [ can't quote because non-inline attachment ] I think Yoshifuji had some objections to this because extension headers will be processed twice. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2/2] [IPSEC]: Reinject v6 packet on input instead of calling netfilter

2007-11-29 Thread jamal
2 of 2 cheers, jamal bins8dZMGaaLp.bin Description: application/mbox

[PATCH 1/2] [IPSEC]: Reinject v4 packet on input instead of calling netfilter

2007-11-29 Thread jamal
1 of 2. cheers, jamal binjYANAm8J6C.bin Description: application/mbox

[PATCH 0/2] [IPSEC]: Reinject packet instead of calling netfilter directly on input

2007-11-29 Thread jamal
Herbert, This is a simplified version of one of your earlier patches that never made it in. I liked it so much that i reduced it to this and infact given the cycles today, tested it (with transport and tunnel mode only;->). We re-inject a decrypted ipsec (other than tunnel mode) back and let it b

Re: [PATCH -mm] [RFC] I/OAT: Handle incoming udp through ioatdma

2007-11-29 Thread Shannon Nelson
Argh - mind the line breaks... sln On Nov 29, 2007 12:08 PM, Nelson, Shannon <[EMAIL PROTECTED]> wrote: > [RFC] I/OAT: Handle incoming udp through ioatdma > > From: Shannon Nelson <[EMAIL PROTECTED]> > > If the incoming udp packet is larger than sysctl_udp_dma_copybreak, try > pushing it through t

[PATCH -mm] [RFC] I/OAT: Handle incoming udp through ioatdma

2007-11-29 Thread Nelson, Shannon
[RFC] I/OAT: Handle incoming udp through ioatdma From: Shannon Nelson <[EMAIL PROTECTED]> If the incoming udp packet is larger than sysctl_udp_dma_copybreak, try pushing it through the ioatdma asynchronous memcpy. This is very much the same as the tcp copy offload. This is an RFC because we kno

Re: [PATCH 0/3] cxgb - driver fixes.

2007-11-29 Thread Ben Greear
Divy Le Ray wrote: Jeff, I'm submitting a patch series for inclusion in 2.6.24 for the cxgb driver. The patches are built against Linus'git tree. Here is a brief description: - Ensure that GSO skbs have enough headroom before encapsulating them, - Fix a crash in NAPI mode, - Fix statistics acco

Netchannels. The 21'th release.

2007-11-29 Thread Evgeniy Polyakov
Hi. This is the 21'th release of the netchannels, a peer-to-peer protocol agnostic communication channel between hardware and users. It uses unified cache to store channels, allows to allocate buffers for data from userspace mapped area or from other preallocated set of pages (like VFS cache). All

[PATCH 3/4] sysctl: Infrastructure for per namespace sysctls

2007-11-29 Thread Eric W. Biederman
This patch implements the basic infrastructure for per namespace sysctls. A list of lists of sysctl headers is added, allowing each namespace to have it's own list of sysctl headers. Each list of sysctl headers has a lookup function to find the first sysctl header in the list, allowing the lists

[PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-29 Thread Eric W. Biederman
The user interface is: register_net_sysctl_table and unregister_net_sysctl_table. Very much like the current interface except there is a network namespace parameter. With this any sysctl registered with register_net_sysctl_table will only show up to tasks in the same network namespace. All othe

[PATCH 2/4] sysctl: Remember the ctl_table we passed to register_sysctl_paths

2007-11-29 Thread Eric W. Biederman
By doing this we allow users of register_sysctl_paths that build and dynamically allocate their ctl_table to be simpler. This allows them to just remember the ctl_table_header returned from register_sysctl_paths from which they can now find the ctl_table array they need to free. Signed-off-by: E

Re: wireless vs. alignment requirements

2007-11-29 Thread H. Peter Anvin
Herbert Xu wrote: On Tue, Nov 27, 2007 at 09:16:07AM -0800, H. Peter Anvin wrote: I wrote a patch for the IP stack to realign packets if necessary at one point. I should dredge it up again and submit it for collective flamage. As long as it doesn't penalise Ethernet (e.g., the 10Gb crowd :) i

[PATCH 1/4] sysctl: Add register_sysctl_paths function

2007-11-29 Thread Eric W. Biederman
There are a number of modules that register a sysctl table somewhere deeply nested in the sysctl hierarchy, such as fs/nfs, fs/xfs, dev/cdrom, etc. They all specify several dummy ctl_tables for the path name. This patch implements register_sysctl_path that takes an additional path name, and makes

[PATCH 0/4] Sysctl namespace support

2007-11-29 Thread Eric W. Biederman
Currently the network namespace work has gotten about as far as we can without the ability to make sysctls that are per network namespace. The techniques we have been using for other namespace of examining current and replacing the ctl_table.data field depending on the namespace instance that cur

Re: + xfrm_policy-warning-fix.patch added to -mm tree

2007-11-29 Thread Andrew Morton
On Fri, 30 Nov 2007 00:51:33 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Wed, Nov 28, 2007 at 02:56:51AM -0800, [EMAIL PROTECTED] wrote: > > > > The patch titled > > xfrm_policy warning fix > > has been added to the -mm tree. Its filename is > > xfrm_policy-warning-fix.patch > >

Re: [PATCHv6 iptables]Interface group match

2007-11-29 Thread Patrick McHardy
Jan Engelhardt wrote: On Nov 29 2007 17:27, Patrick McHardy wrote: The syntax "name/0xmask" is simply too strange for me. Then how about name/name with masks also defined in rt_ifgroup? The same question applies for marks of course. I would find that confusing, which is why the new xt_TOS onl

Re: [patch 1/1] ctc: make use of alloc_netdev()

2007-11-29 Thread Stephen Hemminger
On Thu, 29 Nov 2007 17:36:27 +0100 Ursula Braun <[EMAIL PROTECTED]> wrote: > From: Peter Tiedemann <[EMAIL PROTECTED]> > > Currently ctc-device initialization is broken (kernel bug in > ctc_new_device). > The new network namespace code reveals a deficiency of the > ctc driver. It should make use

Re: [PATCHv6 iptables]Interface group match

2007-11-29 Thread Jan Engelhardt
On Nov 29 2007 17:27, Patrick McHardy wrote: > >> The syntax "name/0xmask" is simply too strange for me. > > Then how about name/name with masks also defined in rt_ifgroup? > The same question applies for marks of course. > I would find that confusing, which is why the new xt_TOS only allows names

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-29 Thread Arjan van de Ven
On Mon, 26 Nov 2007 10:25:33 -0800 > > Agreed. On first glance, I was intrigued but: > > 1) Why is everyone so concerned that export symbol space is large? > - does it cost cpu or running memory? yes. about 120 bytes per symbol > - does it cause bugs? yes, bad apis are causing bugs

Re: [PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-29 Thread Steven Whitehouse
Hi, On Thu, Nov 29, 2007 at 07:29:20PM +0300, Pavel Emelyanov wrote: > As far as I see from the err variable initialization > the dn_nl_deladdr() routine was designed to report errors > like "EADDRNOTAVAIL" and probaby "ENODEV". > > But the code sets this err to 0 after the first nlmsg_parse > an

[patch 1/1] ctc: make use of alloc_netdev()

2007-11-29 Thread Ursula Braun
From: Peter Tiedemann <[EMAIL PROTECTED]> Currently ctc-device initialization is broken (kernel bug in ctc_new_device). The new network namespace code reveals a deficiency of the ctc driver. It should make use of alloc_netdev() as described in Documentation/networking/netdevices.txt. Signed-off-b

[patch 0/1] s390: ctc patch for 2.6.24

2007-11-29 Thread Ursula Braun
-- The following patch is intended for 2.6.24 and repairs the ctc driver by introducing alloc_netdev(). - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv7 0/5 + 3] Interface group patches

2007-11-29 Thread Laszlo Attila Toth
Patrick McHardy írta: Laszlo Attila Toth wrote: Hello, This is the 7th version of our interface group patches. Patches: [1/5] Remove unnecessary locks from rtnetlink (in do_setlink) [2/5] rtnetlink: send a single notification on device state changes [3/5] Interface group: core (netlink)

[PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-29 Thread Pavel Emelyanov
As far as I see from the err variable initialization the dn_nl_deladdr() routine was designed to report errors like "EADDRNOTAVAIL" and probaby "ENODEV". But the code sets this err to 0 after the first nlmsg_parse and goes on, returning this 0 in any case. Is this made deliberately, or the patch

Re: [PATCHv6 iptables]Interface group match

2007-11-29 Thread Patrick McHardy
Laszlo Attila Toth wrote: Patrick McHardy írta: Laszlo Attila Toth wrote: Lutz Jaenicke írta: Should iptables be allowed to read "/etc/iproute2/rt_ifgroup"? It would be good but cannot be used if a mask is set and only values less than 256 can be used with names. Why 256? I can see no

Re: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller

2007-11-29 Thread Robert Stonehouse
Stephen Hemminger wrote: On Fri, 23 Nov 2007 17:08:15 + Ben Hutchings <[EMAIL PROTECTED]> wrote: 1. When we enable NAPI polling, we need to set __LINK_STATE_START in the net device used for NAPI. This bit is commented as private in netdevice.h, but e1000 also does this. Is this in

Re: [PATCHv7 0/5 + 3] Interface group patches

2007-11-29 Thread Patrick McHardy
Laszlo Attila Toth wrote: Hello, This is the 7th version of our interface group patches. Patches: [1/5] Remove unnecessary locks from rtnetlink (in do_setlink) [2/5] rtnetlink: send a single notification on device state changes [3/5] Interface group: core (netlink) part [4/5] Ifgroup rea

Re: [PATCHv6 iptables]Interface group match

2007-11-29 Thread Laszlo Attila Toth
Patrick McHardy írta: Laszlo Attila Toth wrote: Lutz Jaenicke írta: On Tue, Nov 20, 2007 at 02:14:28PM +0100, Laszlo Attila Toth wrote: Interface group values can be checked on both input and output interfaces with optional mask. Index: extensions/libxt_ifgroup.c ==

Re: [PATCHv6 iptables]Interface group match

2007-11-29 Thread Patrick McHardy
Laszlo Attila Toth wrote: Lutz Jaenicke írta: On Tue, Nov 20, 2007 at 02:14:28PM +0100, Laszlo Attila Toth wrote: Interface group values can be checked on both input and output interfaces with optional mask. Index: extensions/libxt_ifgroup.c =

[PATCHv7 iptables] Interface group match

2007-11-29 Thread Laszlo Attila Toth
Interface group values can be checked on both input and output interfaces with optional mask. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- extensions/Makefile |2 extensions/libxt_ifgroup.c | 201 +++ extensions/libxt_i

[PATCHv7 iproute2 1/2] Added IFLA_NET_NS_PID as in kernel v2.6.24-rc1

2007-11-29 Thread Laszlo Attila Toth
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> diff --git a/include/linux/if_link.h b/include/linux/if_link.h index 23b3a8e..c948395 100644 --- a/include/linux/if_link.h +++ b/include/linux/if_link.h @@ -78,6 +78,7 @@ enum IFLA_LINKMODE, IFLA_LINKINFO, #define IFLA_LINKINFO

[PATCHv7 4/5] Ifgroup read/write support in sysfs

2007-11-29 Thread Laszlo Attila Toth
The ifgroup member of each net device can be read and changed in sysfs. Author: Lutz Jaenicke <[EMAIL PROTECTED]> --- net/core/net-sysfs.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 61ead1d..5bd6d35 10

[PATCHv7 iproute2 2/2] Interface group as new ip link option

2007-11-29 Thread Laszlo Attila Toth
Interfaces can be grouped and each group has an unique positive integer ID. It can be set via ip link. Symbolic names can be specified in /etc/iproute2/rt_ifgroup. Any value of unsigned int32 is valid. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> diff --git a/include/linux/if_link.h b/in

[PATCHv7 1/5] Remove unnecessary locks from rtnetlink (in do_setlink)

2007-11-29 Thread Laszlo Attila Toth
The do_setlink function is protected by rtnl, additional locks are unnecessary, and the set_operstate() function is called from protected parts. Locks removed from both functions. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- net/core/rtnetlink.c |4 1 files changed, 0 inser

[PATCHv7 3/5] Interface group: core (netlink) part

2007-11-29 Thread Laszlo Attila Toth
Interface groups let handle different interfaces together. Modified net device structure and netlink interface. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/if_link.h |2 ++ include/linux/netdevice.h |2 ++ net/core/rtnetlink.c | 11 +++ 3 file

[PATCHv7 5/5] Netfilter Interface group match

2007-11-29 Thread Laszlo Attila Toth
Interface group values can be checked on both input and output interfaces. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/netfilter/xt_ifgroup.h | 17 + net/netfilter/Kconfig| 10 +++ net/netfilter/Makefile |1 net/netfilter/xt_

[PATCHv7 2/5] rtnetlink: send a single notification on device state changes

2007-11-29 Thread Laszlo Attila Toth
In do_setlink() a single ntification is sent at the end of the function if any modification occured. If the address has been changed, another notification is sent. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- net/core/rtnetlink.c | 27 --- 1 files changed,

[PATCHv7 0/5 + 3] Interface group patches

2007-11-29 Thread Laszlo Attila Toth
Hello, This is the 7th version of our interface group patches. The interface group value can be used to manage different interfaces at the same time such as in netfilter/iptables. As earlier discussed, it can be used for advanced routing, tc command and so on [1]. An u_int32_t member was added

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Paul E. McKenney
On Fri, Nov 30, 2007 at 12:04:20AM +1100, Herbert Xu wrote: > On Tue, Nov 27, 2007 at 07:21:08PM +0300, Pavel Emelyanov wrote: > > This hook is protected with the RCU, so simple > > > > if (br_should_route_hook) > > br_should_route_hook(...) > > > > is not enough on some architect

[GIT PULL] SCTP bug fixes for net-2.6

2007-11-29 Thread Vlad Yasevich
Hi Herbert The following changes since commit a357dde9df33f28611e6a3d4f88265e39bcc8880: Stephen Hemminger (1): [TCP] illinois: Incorrect beta usage are available in the git repository at: aster.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git pending Vlad Yasevich (5):

[PATCH] NET: parentheses around definitions

2007-11-29 Thread Roel Kluin
There are multiplictions wherein these defines are abused in: drivers/net/netxen/netxen_nic_ethtool.c:705 drivers/net/s2io.c:350 -- Add parentheses to prevent operator precedence errors Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/netxen/netxen_nic_ethtool.c b/driver

Re: [NET 00/02]: Remove NET_ACT_NAT dependency on NETFILTER

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 10:57:34AM +0100, Patrick McHardy wrote: > These patches remove the dependency of NET_ACT_NAT on NETFILTER > by moving the netfilter checksum helpers to include/net/checksum > and net/core/utils.c. I didn't find more appropriate locations, > but I'd happily change it if some

net-2.6.25 rebased

2007-11-29 Thread Herbert Xu
Hi: Just to let you all know that I've just rebased net-2.6.25 so that it now contains all of net-2.6 as it currently stands. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gon

Re: [PATCH] tcp-illinois: incorrect beta usage

2007-11-29 Thread Herbert Xu
On Wed, Nov 28, 2007 at 03:47:25PM -0800, Stephen Hemminger wrote: > Lachlan Andrew observed that my TCP-Illinois implementation uses the > beta value incorrectly: > The parameter beta in the paper specifies the amount to decrease > *by*: that is, on loss, > W <- W - beta*W > but in

Re: [PATCH net-2.6.25 (v2)] [TCP]: Two fixes to new sacktag code

2007-11-29 Thread Herbert Xu
On Wed, Nov 28, 2007 at 06:52:51PM +0200, Ilpo Järvinen wrote: > On Wed, 28 Nov 2007, Ilpo Järvinen wrote: > > > @@ -1575,7 +1575,7 @@ tcp_sacktag_write_queue(struct sock *sk, struct > > sk_buff *ack_skb, u32 prior_snd_ > > continue; > > } > > > > - if (!

Re: + xfrm_policy-warning-fix.patch added to -mm tree

2007-11-29 Thread Herbert Xu
On Wed, Nov 28, 2007 at 02:56:51AM -0800, [EMAIL PROTECTED] wrote: > > The patch titled > xfrm_policy warning fix > has been added to the -mm tree. Its filename is > xfrm_policy-warning-fix.patch > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > See

Re: [PATCH] XFRM: SPD auditing fix to include the netmask/prefix-length

2007-11-29 Thread Paul Moore
On Thursday 29 November 2007 5:34:59 am Herbert Xu wrote: > On Mon, Nov 26, 2007 at 07:55:12PM +, Paul Moore wrote: > > Currently the netmask/prefix-length of an IPsec SPD entry is not included > > in any of the SPD related audit messages. This can cause a problem when > > the audit log is exa

Re: [PATCH] Nicer WARN_ON in netstat_show

2007-11-29 Thread Herbert Xu
On Wed, Nov 28, 2007 at 01:11:24PM +0300, Pavel Emelyanov wrote: > The > > if (statement) > WARN_ON(1); > > looks much better as > > WARN_ON(statement); > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied to net-2.6.25. Thanks. -- Visit Openswan at http:/

Re: PATCH 2.6.24-rc3-mm2 - build breakage - bnx2x depends on ZLIB_INFLATE

2007-11-29 Thread Eliezer Tamir
On Wed, 2007-11-28 at 12:25 -0800, Lee Schermerhorn wrote: > Couldn't find one of these on the lists... > > PATCH 2.6.24-rc3-mm1: bnx2x depends on ZLIB_INFLATE > > The bnx2x module depends on the zlib_inflate functions. The > build will fail if ZLIB_INFLATE has not been selected manually > or

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 09:16:07AM -0800, H. Peter Anvin wrote: > > I wrote a patch for the IP stack to realign packets if necessary at one > point. I should dredge it up again and submit it for collective flamage. As long as it doesn't penalise Ethernet (e.g., the 10Gb crowd :) it would be goo

Re: [PATCH (resubmit)] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 04:01:25PM +0300, Pavel Emelyanov wrote: > > Besides, as Herbert pointed out, asynchronous dumps should hold > this mutex as well, and thus, we provide the mutex as cb_mutex one. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Thanks for the quick response! Patch

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 07:21:08PM +0300, Pavel Emelyanov wrote: > This hook is protected with the RCU, so simple > > if (br_should_route_hook) > br_should_route_hook(...) > > is not enough on some architectures. > > Use the rcu_dereference/rcu_assign_pointer in this case. >

[PATCH (resubmit)] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Pavel Emelyanov
The following race is possible when one cpu unregisters the handler while other one is trying to receive a message and call this one: CPU1: CPU2: inet_diag_rcv() inet_diag_unregister() mutex_lock(&inet_diag_mut

[2/4] dst: Core distributed storage files.

2007-11-29 Thread Evgeniy Polyakov
Core distributed storage files. Include userspace interfaces, initialization, block layer bindings and other core functionality. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index b4c8319..ca6592d 100644 --- a/drivers/block/Kconf

[3/4] dst: Network state machine.

2007-11-29 Thread Evgeniy Polyakov
Network state machine. Includes network async processing state machine and related tasks. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/kst.c b/drivers/block/dst/kst.c new file mode 100644 index 000..ba5e5ef --- /dev/null +++ b/drivers/block/dst/kst.c @

[4/4] dst: Algorithms used in distributed storage.

2007-11-29 Thread Evgeniy Polyakov
Algorithms used in distributed storage. Mirror and linear mapping code. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/alg_linear.c b/drivers/block/dst/alg_linear.c new file mode 100644 index 000..cb77b57 --- /dev/null +++ b/drivers/block/dst/alg_linear.c

[1/4] dst: Distributed storage documentation.

2007-11-29 Thread Evgeniy Polyakov
Distributed storage documentation. Algorithms used in the system, userspace interfaces (sysfs dirs and files), design and implementation details are described here. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/Documentation/dst/algorithms.txt b/Documentation/dst/algorithms.

[0/4] dst: Distributed storage.

2007-11-29 Thread Evgeniy Polyakov
Distributed storage. I'm pleased to announce the 9'th release of the distributed storage subsystem (DST). This is maintenance release and include bug fixing only. DST allows to form a storage on top of local and remote nodes and combine them into linear or mirroring setup, which in turn can be e

Re: [PATCHv6 iptables]Interface group match

2007-11-29 Thread Laszlo Attila Toth
Lutz Jaenicke írta: On Tue, Nov 20, 2007 at 02:14:28PM +0100, Laszlo Attila Toth wrote: Interface group values can be checked on both input and output interfaces with optional mask. Index: extensions/libxt_ifgroup.c === --- exten

Re: [PATCH] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 29, 2007 at 11:37:34PM +1100, Herbert Xu escreveu: > On Tue, Nov 27, 2007 at 04:09:43PM +0300, Pavel Emelyanov wrote: > > The following race is possible when one cpu unregisters the handler > > while other one is trying to receive a message and call this one: > > Good catch! But I thin

Re: [PATCH][BRIDGE] Lost call to br_fdb_fini() in br_init() error path

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 05:39:42PM +0300, Pavel Emelyanov wrote: > In case the br_netfilter_init() (or any subsequent call) > fails, the br_fdb_fini() must be called to free the allocated > in br_fdb_init() br_fdb_cache kmem cache. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Patch app

  1   2   >