Re: forcedeth ethernet driver & Low power state

2007-11-24 Thread Andrew Morton
On Sun, 25 Nov 2007 03:52:33 +0100 Jeroen <[EMAIL PROTECTED]> wrote: > Hi, > > I'm migrating my server from windows 2003 server to Ubuntu, but I am > stumbling over the "Low Power State Link Speed" option for my NIC > (forcedeth) > > I need to disable this option in my windows driver otherwise t

Re: sky2: eth0: hung mac 7:69 fifo 0 (165:176)

2007-11-24 Thread Elvis Pranskevichus
Paul Collins wrote: > Hi Stephen, > > Running amd64 kernel built from 2ffbb8377c7a0713baf6644e285adc27a5654582 > after about three days of uptime, this morning I found the network dead > and the following in dmesg: > > sky2 eth0: hung mac 7:69 fifo 0 (165:176) > sky2 eth0: receiver hang dete

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Alistair John Strachan
On Sunday 25 November 2007 01:27:54 Francois Romieu wrote: > Francois Romieu <[EMAIL PROTECTED]> : > > Alistair John Strachan <[EMAIL PROTECTED]> : > > [...] > > > > > The "choke" affects other devices on the system too, notably libata, > > > which does not recover gracefully. In my logs, I see a s

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Alistair John Strachan
On Sunday 25 November 2007 00:25:10 Francois Romieu wrote: > Alistair John Strachan <[EMAIL PROTECTED]> : > [...] > > > The "choke" affects other devices on the system too, notably libata, > > which does not recover gracefully. In my logs, I see a stream of: > > > > DMA: Out of SW-IOMMU space for 7

Re: wireless vs. alignment requirements

2007-11-24 Thread Herbert Xu
On Sat, Nov 24, 2007 at 10:13:19PM +0100, Johannes Berg wrote: > > Eight bytes really sucks for wireless, many things are multiples of four > and QoS vs. non-QoS frames have a multiple of four and common hardware > only adds two padding bytes to get it aligned on four bytes so there's > no easy way

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : > Alistair John Strachan <[EMAIL PROTECTED]> : > [...] > > The "choke" affects other devices on the system too, notably libata, which > > does not recover gracefully. In my logs, I see a stream of: > > > > DMA: Out of SW-IOMMU space for 7222 bytes at device 0

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Francois Romieu
Alan Cox <[EMAIL PROTECTED]> : [...] > You seem to have a leak, which actually isn't suprising > > rtl8169_xmit_frags allocates a set of maps for a fragmented packet > > rtl8169_start_xmit allocates a buffer > > When we finish the transit we free the main buffer (always using skb->le

Re: wireless vs. alignment requirements

2007-11-24 Thread Herbert Xu
On Sat, Nov 24, 2007 at 12:11:08PM -0800, Stephen Hemminger wrote: > > Then what about hardware that can't dma ethernet to non-aligned address. > Sky2 hardware breaks if DMA is not 8 byte aligned. IMHO the IP stack should > handle any alignment, and do the appropriate memove if the CPU requires >

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Alan Cox
> when these messages appear, removing r8169 would appear to be key. Indeed, if > there is no significant libata activity, the problem still occurs on the NIC > within approximately the same amount of transfer. You seem to have a leak, which actually isn't suprising rtl8169_xmit_frags a

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Francois Romieu
Alistair John Strachan <[EMAIL PROTECTED]> : [...] > The "choke" affects other devices on the system too, notably libata, which > does not recover gracefully. In my logs, I see a stream of: > > DMA: Out of SW-IOMMU space for 7222 bytes at device :04:00.0 > DMA: Out of SW-IOMMU space for 7222

2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Alistair John Strachan
Hi, I have recently assembled a Core 2 Duo system with 4GB RAM and I believe there might be a bug in the r8169 driver in >4GB RAM configurations. Initially I can use one of two active r8169 NICs on the motherboard with this quantity of RAM with other devices, without issue. But after some amoun

[CFT][PATCH] proc_net: Remove userspace visible changes.

2007-11-24 Thread Eric W. Biederman
Ok. I have kicked around a lot implementation ideas and took a good hard look at my /proc/net implementation. The patch below should close all of the holes with /proc/net that I am aware of. Bind mounts work and properly capture /proc/net/ stat of /proc/net and /proc/net/ return the same inform

Re: wireless vs. alignment requirements

2007-11-24 Thread Johannes Berg
> Then what about hardware that can't dma ethernet to non-aligned address. > Sky2 hardware breaks if DMA is not 8 byte aligned. IMHO the IP stack should > handle any alignment, and do the appropriate memove if the CPU requires > alignment. Wouldn't that better be handled in the driver rather th

Re: wireless vs. alignment requirements

2007-11-24 Thread Johannes Berg
> OK. Let me clarify this a bit more. We require at least one > of the following rules to be met: > > * the IPv4/IPv6 header is aligned by 8 bytes on reception; > * or the platform provides unaligned exception handlers. > > So if your platform violates both rules then it won't work with > the

Re: wireless vs. alignment requirements

2007-11-24 Thread Stephen Hemminger
Herbert Xu wrote: On Sat, Nov 24, 2007 at 02:49:36PM +0100, Johannes Berg wrote: Right. I just didn't think that would be a valid value for an architecture to set. OK. Let me clarify this a bit more. We require at least one of the following rules to be met: * the IPv4/IPv6 header is

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-24 Thread Matt Mackall
Simon, can you test this patch? I think it's the most straightforward 2.6.24 fix. diff -r c60016ba6237 net/core/netpoll.c --- a/net/core/netpoll.cTue Nov 13 09:09:36 2007 -0800 +++ b/net/core/netpoll.cFri Nov 23 13:10:28 2007 -0600 @@ -203,6 +203,12 @@ static void refill_skbs(void)

RE: [PATCH 2.6.24 2/2]S2io: Fix to aggregate vlan tagged packets

2007-11-24 Thread Ramkrishna Vepa
Jeff, Does this patch still fail? Ram > -Original Message- > From: Jeff Garzik [mailto:[EMAIL PROTECTED] > Sent: Friday, November 23, 2007 7:05 PM > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org; support > Subject: Re: [PATCH 2.6.24 2/2]S2io: Fix to aggregate vlan tagged packets >

RE: [PATCH 2.6.24 1/2]S2io: Strip the vlan tag if the vlan group is not NULL

2007-11-24 Thread Ramkrishna Vepa
Jeff, I don't think this functionality is present in ethtool. I only see #ifdef code in most of the drivers. What functionality do you mean? We created this patch in response to the following thread with subject line - RE: [PATCH 2/2] NET: Re-add VLAN tag for devices incapable of keeping it Sinc

[SKY2] Problems (2.6.24-rc3-git1)

2007-11-24 Thread Ian Kumlien
Hi, A little while ago, something went horribly wrong. I could still use my mouse and the desktop was still alive more or less... everything using networking was dead AND the keyboard was dead... So i composed commands using existing text on the screen. The device: sky2 :02:00.0: v1.20 addr

Re: ZD1211RW unaligned accesses...

2007-11-24 Thread Ulrich Kunitz
Herbert Xu wrote: > So please try the following patch (instead of the original one) > which should fix all the unailgned accesses in do_rx. > > Cheers, > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> > Home Page: http://gondor.apana.org.au/~he

Re: ZD1211RW unaligned accesses...

2007-11-24 Thread Herbert Xu
On Wed, Nov 21, 2007 at 01:00:44PM +, Shaddy Baddah wrote: > > It hasn't seemed to. I patched the source (confirming the patched lines > are in), compiled, installed and rebooted to effect the changes. My > zd1211rw modules timestamp indicates that I have an updated module: Thanks for your q

Re: wireless vs. alignment requirements

2007-11-24 Thread Herbert Xu
On Sat, Nov 24, 2007 at 02:49:36PM +0100, Johannes Berg wrote: > > Right. I just didn't think that would be a valid value for an > architecture to set. OK. Let me clarify this a bit more. We require at least one of the following rules to be met: * the IPv4/IPv6 header is aligned by 8 bytes on

Re: wireless vs. alignment requirements

2007-11-24 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Sat, 24 Nov 2007 14:49:36 +0100 > > On Sat, 2007-11-24 at 21:32 +0800, Herbert Xu wrote: > > On Sat, Nov 24, 2007 at 09:33:36AM +0100, Johannes Berg wrote: > > > > > > We still require four-byte alignment, no? > > > > Not at all. If NET_IP_ALIGN is

Re: wireless vs. alignment requirements

2007-11-24 Thread Johannes Berg
On Sat, 2007-11-24 at 21:32 +0800, Herbert Xu wrote: > On Sat, Nov 24, 2007 at 09:33:36AM +0100, Johannes Berg wrote: > > > > We still require four-byte alignment, no? > > Not at all. If NET_IP_ALIGN is zero then it won't be four-byte > aligned (since the Ethernet header is 14 bytes long). Righ

Re: wireless vs. alignment requirements

2007-11-24 Thread Ulrich Kunitz
Johannes, > Hence, going back to the 802.11 header and the IP header alignment > requirement, if we get the IP header alignment requirement right now I > cannot possibly see any way we would use compare_ether_addr() on an > address that is not at least two-byte aligned as required. ACK. I agree c

Re: wireless vs. alignment requirements

2007-11-24 Thread Herbert Xu
On Sat, Nov 24, 2007 at 09:33:36AM +0100, Johannes Berg wrote: > > We still require four-byte alignment, no? Not at all. If NET_IP_ALIGN is zero then it won't be four-byte aligned (since the Ethernet header is 14 bytes long). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-24 Thread Andi Kleen
On Sat, Nov 24, 2007 at 03:53:34PM +1100, Rusty Russell wrote: > So, you're saying that there's a problem with in-tree modules using symbols > they shouldn't? Can you give an example? > > > I believe that is fairly important in tree too because the > > kernel has become so big now that review ca

Re: wireless vs. alignment requirements

2007-11-24 Thread Johannes Berg
> > Now, the IP stack actually assumes that its header is four-byte aligned > > (see comment at NET_IP_ALIGN, although it is not said explicitly that > > the alignment requirement for an IP header is four) so that is actually > > something for the hardware/firmware (!) to do, for example Broadcom