Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 18 Nov 2007 10:07:37 +0800 > On Sat, Nov 17, 2007 at 04:45:42PM -0800, David Miller wrote: > > > > Herbert, you asked about just nop'ing out cond_resched() when we're > > doing real preemption. > > > > A lot of code goes: > > > > if (need_resch

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Herbert Xu
On Sat, Nov 17, 2007 at 04:45:42PM -0800, David Miller wrote: > > Herbert, you asked about just nop'ing out cond_resched() when we're > doing real preemption. > > A lot of code goes: > > if (need_resched()) { > /* drop some locks, etc. */ > cond_resched(); >

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-17 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kevin Winchester wrote: > However, I got around the problem by making the code change manually - > and my network connection is now working. Looking at the code being > bypassed: > > if (pE.cap[i] || pP.cap[i] || pP.cap[i]) > > looks somewhat we

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-17 Thread Kevin Winchester
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Morgan wrote: > Kevin, > > Can you try this quick hack? > > diff --git a/kernel/capability.c b/kernel/capability.c > index e57d1aa..4088610 100644 > --- a/kernel/capability.c > +++ b/kernel/capability.c > @@ -109,7 +109,7 @@ out: >

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-17 Thread Kevin Winchester
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kevin Winchester wrote: > Looking at the code being bypassed: > > if (pE.cap[i] || pP.cap[i] || pP.cap[i]) > > looks somewhat weird as it is testing the same condition twice. Should > it have been: > > if (pE.cap[i] || pP.cap[i] || pI.cap[i

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-17 Thread Kevin Winchester
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Morgan wrote: > Kevin, > > Can you try this quick hack? > > diff --git a/kernel/capability.c b/kernel/capability.c > index e57d1aa..4088610 100644 > --- a/kernel/capability.c > +++ b/kernel/capability.c > @@ -109,7 +109,7 @@ out: >

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 18 Nov 2007 00:29:39 +0800 > However, since you're already working on this as your next step > I can wait :) Me too. Herbert, you asked about just nop'ing out cond_resched() when we're doing real preemption. A lot of code goes: if (need_r

Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

2007-11-17 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Sat, 17 Nov 2007 22:46:40 +0100 > > The 25.000.000 ns and 88.000.000 ns numbers where on an empty table, but > > large (16 MB of memory) > > This would mean that cond_resched() needs ~4x as much time as checking > an empty bucket. I find that somewhat h

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-17 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Sat, 17 Nov 2007 14:18:46 +0100 > Wang Chen <[EMAIL PROTECTED]> writes: > > > Herbert Xu said the following on 2007-11-16 12:11: > >> Wang Chen <[EMAIL PROTECTED]> wrote: > >>> So, I think the checksum in udp_queue_rcv_skb() actually does > >>> the work,

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-17 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kevin, Can you try this quick hack? diff --git a/kernel/capability.c b/kernel/capability.c index e57d1aa..4088610 100644 - --- a/kernel/capability.c +++ b/kernel/capability.c @@ -109,7 +109,7 @@ out: kdata[i].permitted = pP.ca

Re: r8169 crash

2007-11-17 Thread Denys
Before it happens on 2.6.22, i tried to attach good cable, plug-unplug, whatever, interface up/down - card still remains dead. I try to plug cable to laptop with rtl8139 and pc with e100 - it is worked when i shake bad cable(interface was going up/down as well), and good cable also worked fine

[PATCH, REPOST] Fix/Rewrite of the mipsnet driver

2007-11-17 Thread Thiemo Seufer
Hello All, currently the mipsnet driver fails after transmitting a number of packages because SKBs are allocated but never freed. I fixed that and coudn't refrain from removing the most egregious warts. - mipsnet.h folded into mipsnet.c, as it doesn't provide any useful external interface. - Fr

Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0

2007-11-17 Thread Jarek Poplawski
Bill Fink wrote, On 11/16/2007 08:26 PM: ... > Regarding the Target IP, RFC 826 says: > > "The target protocol address is necessary in the request form > of the packet so that a machine can determine whether or not > to enter the sender information in a table or to send a reply.

Re: r8169 crash

2007-11-17 Thread Francois Romieu
Denys <[EMAIL PROTECTED]> : [...] > After that i have. > Nov 15 22:11:37 vzone NETDEV WATCHDOG: eth1: transmit timed out > Nov 15 22:11:49 vzone NETDEV WATCHDOG: eth1: transmit timed out > Nov 15 22:12:01 vzone NETDEV WATCHDOG: eth1: transmit timed out > Nov 15 22:12:13 vzone NETDEV WATCHDOG: eth1:

Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

2007-11-17 Thread Andi Kleen
> The 25.000.000 ns and 88.000.000 ns numbers where on an empty table, but > large (16 MB of memory) This would mean that cond_resched() needs ~4x as much time as checking an empty bucket. I find that somewhat hard to believe. -Andi - To unsubscribe from this list: send the line "unsubscribe net

Re: Netconsole and logging everything from /dev/console

2007-11-17 Thread Martin Michlmayr
* Matt Mackall <[EMAIL PROTECTED]> [2007-11-16 12:50]: > > Do you think that would be possible? > > It is, definitely, you just need to wire up a tty struct's write > method to netconsole's and add it to the console registration. But I > haven't had any time to work on this in a while. Where woul

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Herbert Xu
On Sat, Nov 17, 2007 at 05:18:35PM +0100, Eric Dumazet wrote: > > >This seems to be the only potentially softirq caller of rt_run_flush. > >However, I just checked the callers of it and most of them seem to > >hold the RTNL which would indicate that they're in process context. > > > >So do you know

Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

2007-11-17 Thread Eric Dumazet
Andi Kleen a écrit : Eric Dumazet <[EMAIL PROTECTED]> writes: So it may sound unnecessary but in the rt_check_expire() case, with a loop potentially doing XXX.XXX iterations, being able to bypass the function call is a clear win (in my bench case, 25 ms instead of 88 ms). Impact on I-cache is i

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Eric Dumazet
Herbert Xu a écrit : On Sat, Nov 17, 2007 at 09:41:47AM +, Eric Dumazet wrote: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue Thanks for your work on this Eric! It's very much needed. Thanks :) @@ -667,7 +697,7 @@ void rt_cache_flush(int delay)

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-17 Thread Jarek Poplawski
Jon Nelson wrote, On 11/17/2007 01:59 AM: ... > OK. This is what I did. > Using git I grabbed a copy of Linus' tree and using the latest files > for via-velocity.[c,h], commit > 99fee6d7e5748d96884667a4628118f7fc130ea0, I determined that if I > backed out change 44c10138fd4bbc4b6d6bff0873c24902f2a

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Herbert Xu
On Sat, Nov 17, 2007 at 09:41:47AM +, Eric Dumazet wrote: > > [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to > workqueue Thanks for your work on this Eric! It's very much needed. > @@ -667,7 +697,7 @@ void rt_cache_flush(int delay) > > if (delay <= 0) { >

[PATCH] tun: use iov_length()

2007-11-17 Thread Akinobu Mita
Use iov_length() instead of tun's homemade iov_total(). Cc: Maxim Krasnyansky <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- drivers/net/tun.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) Index: 2.6-mm/drivers/net/tun.c ==

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-17 Thread Andy Whitcroft
On Fri, Nov 16, 2007 at 09:16:58PM -0800, Andrew Morgan wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > This warning is just saying that you might want to reconsider > recompiling your dhclient with a newer libcap - which has native support > for 64-bit capabilities. This is

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-17 Thread Andi Kleen
Wang Chen <[EMAIL PROTECTED]> writes: > Herbert Xu said the following on 2007-11-16 12:11: >> Wang Chen <[EMAIL PROTECTED]> wrote: >>> So, I think the checksum in udp_queue_rcv_skb() actually does >>> the work, not that in udp_recvmsg() and udp_poll(). >>> >>> If I am wrong, please point out. >>

Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

2007-11-17 Thread Andi Kleen
Eric Dumazet <[EMAIL PROTECTED]> writes: > So it may sound unnecessary but in the rt_check_expire() case, with a > loop potentially doing XXX.XXX iterations, being able to bypass the > function call is a clear win (in my bench case, 25 ms instead of 88 > ms). Impact on I-cache is irrelevant here a

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-17 Thread Kevin Winchester
On November 17, 2007 01:16:58 am Andrew Morgan wrote: > Hi, > > This warning is just saying that you might want to reconsider > recompiling your dhclient with a newer libcap - which has native support > for 64-bit capabilities. This is supposed to be informative, and not be > associated with any pa

[2.6 patch] net/core/request_sock.c: remove unused exports

2007-11-17 Thread Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's: - reqsk_queue_alloc - __reqsk_queue_destroy - reqsk_queue_destroy Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/core/request_sock.c |5 - 1 file changed, 5 deletions(-) 3761f092ccd5d87a1517b55e2001ac9ef189b901 diff --gi

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 17:40:27 +0100 + unsigned long fake = 0, *flag_ptr; ... + /* +* This is a fast version of : +* if (process_context && need_resched()) +*/ +