Re: 2.6.24-rc1 fails with lockup - /sbin/ifconfig / inet_ioctl() / dev_close() / rtl8169_down()

2007-10-25 Thread Ingo Molnar
* Romano Giannetti <[EMAIL PROTECTED]> wrote: > > Does this help? > > I tried this, but although I have the D-state processes, I cannot see > any debug trace now. Results are at: > > http://www.dea.icai.upcomillas.es/romano/linux/info/2624rc1_3/ > > Can I try anything more? This is quite a sh

Re: [PATCH net-2.6.24][trivial] fix inconsistency of terms

2007-10-25 Thread David Miller
From: TAKANO Ryousei <[EMAIL PROTECTED]> Date: Tue, 09 Oct 2007 15:32:34 +0900 (JST) > > Fix inconsistency of terms: > 1) D-SACK > 2) F-RTO > > Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]> Patch applied, thank you! - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: Please pull 'fixes-davem' branch of wireless-2.6 (Use this one!)

2007-10-25 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 00:34:09 -0400 > Dave, > > (Use this one!) > > A few fixes for 2.6.24...also adds Johannes Berg as a mac80211 > maintainer, since he probably wrote most of the newest bugs > there... :-) Pulled, thanks John! - To unsubscribe fr

Please pull 'fixes-davem' branch of wireless-2.6 (Use this one!)

2007-10-25 Thread John W. Linville
Dave, (Use this one!) A few fixes for 2.6.24...also adds Johannes Berg as a mac80211 maintainer, since he probably wrote most of the newest bugs there... :-) Thanks, John --- Individual patches available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-10-25 Thread John W. Linville
On Thu, Oct 25, 2007 at 11:10:33PM -0400, John W. Linville wrote: > The following changes since commit c9927c2bf4f45bb85e8b502ab3fb79ad6483c244: > Linus Torvalds (1): > Linux 2.6.24-rc1 > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/linv

Please pull 'fixes-davem' branch of wireless-2.6

2007-10-25 Thread John W. Linville
Dave, A few fixes for 2.6.24...also adds Johannes Berg as a mac80211 maintainer, since he probably wrote most of the newest bugs there... :-) Thanks, John --- Individual patches available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-davem --- The

Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-10-25 Thread John W. Linville
Jeff, A few fixes for 2.6.24... Thanks, John --- Individual patches available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-jgarzik --- The following changes since commit c9927c2bf4f45bb85e8b502ab3fb79ad6483c244: Linus Torvalds (1): Linux

[PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

2007-10-25 Thread Mitsuru Chinen
While displaying ICMP out-going statistics as Out counters in /proc/net/snmp, the memory location for ICMP in-coming statistics was referred by mistake. Acked-by: David L Stevens <[EMAIL PROTECTED]> Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv4/proc.c |2 +- 1 files changed,

Re: [PATCH] UDP: Make use of inet_iif() when doing socket lookups.

2007-10-25 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Thu, 25 Oct 2007 14:58:29 -0700 > I don't see any problem with this. If you're using IP_MULTICAST_IF with > a bound socket, it forces you to use that interface, anyway. > > I'm not sure multicasting works as expected in some other cases with > bound s

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Thu, 25 Oct 2007 18:27:22 -0700 > [EMAIL PROTECTED] wrote on 10/25/2007 04:05:13 PM: > > > David Stevens <[EMAIL PROTECTED]> wrote: > > > > > What about just removing it, or do you think it's > > > useful for documentation of the order? Either way, >

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Stevens
[EMAIL PROTECTED] wrote on 10/25/2007 04:05:13 PM: > David Stevens <[EMAIL PROTECTED]> wrote: > > > What about just removing it, or do you think it's > > useful for documentation of the order? Either way, > > I don't know whether it's intended to be used for something, perhaps a > debugging macr

Re: Fried r8169.

2007-10-25 Thread Tom Prince
On Thu, Oct 25, 2007 at 11:36:45PM +0200, Francois Romieu wrote: > Tom Prince <[EMAIL PROTECTED]> : > > While testing Linux v2.6.24-rc1, I noticed that my onboard r8169 had > > disappeared, and the it remained gone when I rebooted to v2.6.23 and > > v2.6.22, > > where it had previously worked. >

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Stephen Hemminger
On Thu, 25 Oct 2007 13:29:08 -0700 "Dale Farnsworth" <[EMAIL PROTECTED]> wrote: > On Thu, Oct 25, 2007 at 09:41:14PM +0200, Domen Puncer wrote: > > On 25/10/07 11:57 -0700, Dale Farnsworth wrote: > > > Domen wrote: > > > > > use your platform's dma mapping functions, rather than virt_to_phys() > >

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Howells
David Stevens <[EMAIL PROTECTED]> wrote: > What about just removing it, or do you think it's > useful for documentation of the order? Either way, I don't know whether it's intended to be used for something, perhaps a debugging macro. Perhaps it should be #if'd out instead. David - To unsubscrib

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Jeff Garzik
Dale Farnsworth wrote: IMO, it's still a requirement that we call dma_unmap_single() for each call to dma_map_single(). Yep... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/major

Re: [2.6.25 patch] the planned eepro100 removal

2007-10-25 Thread Kok, Auke
Jeff Garzik wrote: > Bill Davidsen wrote: >> Adrian Bunk wrote: >>> This patch contains the planned removal of the eepro100 driver. >>> >> Are the e100 people satisfied that e100 now handles all known cases? I > > Nope. There are still e100 work outstanding that means we cannot kill > eepro100.

Re: [2.6.25 patch] the planned eepro100 removal

2007-10-25 Thread Jeff Garzik
Bill Davidsen wrote: Adrian Bunk wrote: This patch contains the planned removal of the eepro100 driver. Are the e100 people satisfied that e100 now handles all known cases? I Nope. There are still e100 work outstanding that means we cannot kill eepro100. Jeff - To unsubscribe f

Re: [PATCH] UDP: Make use of inet_iif() when doing socket lookups.

2007-10-25 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Thu, 25 Oct 2007 14:58:29 -0700 > I don't see any problem with this. If you're using IP_MULTICAST_IF with > a bound socket, it forces you to use that interface, anyway. > > I'm not sure multicasting works as expected in some other cases with > bound s

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Stevens
What about just removing it, or do you think it's useful for documentation of the order? Either way, Acked-by: David L Stevens <[EMAIL PROTECTED]> +-DLS - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTE

Re: [PATCH] UDP: Make use of inet_iif() when doing socket lookups.

2007-10-25 Thread David Stevens
I don't see any problem with this. If you're using IP_MULTICAST_IF with a bound socket, it forces you to use that interface, anyway. I'm not sure multicasting works as expected in some other cases with bound sockets (looks like there may be some holes to evade the binding), but that's in old code.

Re: Fried r8169.

2007-10-25 Thread Francois Romieu
Tom Prince <[EMAIL PROTECTED]> : > While testing Linux v2.6.24-rc1, I noticed that my onboard r8169 had > disappeared, and the it remained gone when I rebooted to v2.6.23 and v2.6.22, > where it had previously worked. [...] > I am running x86_64 ASUS Z92T laptop (an OEM version of the A6T). > > I

Re: [PATCH 1/4] e1000e: Fix jumbo frame receive code.

2007-10-25 Thread Kok, Auke
Auke Kok wrote: > Fix allocation and freeing of jumbo frames where several bugs > were recently introduced by cleanups after we forked this code > from e1000. This moves ps_pages to buffer_info where it really > belongs and makes it a dynamically allocated array. The penalty > is not that high sinc

[PATCH 3/4] e1000e: Re-enable SECRC - crc stripping

2007-10-25 Thread Auke Kok
This workaround code performed software stripping instead of the hardware which can do it much faster. None of the e1000e target hardware has issues with this feature and should work fine. This gives us some performance back on receive, and removes some kludging stripping the 4 bytes. Signed-off-b

[PATCH 2/4] e1000e: Fix PBA calculation for jumbo frame packets

2007-10-25 Thread Auke Kok
Upon inspection the rx FIFO size calculation code was found to have 2 significant flaws: A superfluous minus sign resulting in the wrong size to be used for jumbo frames on 82573 and ich9, as well as that this code rewrote the read-only adapter->pba variable resulting in different values at each ru

[PATCH 4/4] e1000e: Remove legacy jumbo frame receive code

2007-10-25 Thread Auke Kok
The legacy jumbo frame receive code is no longer needed since all hardware can do packet split and we're no longer offering a bypass kernel config option to disable packet split. Remove the unused code. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |1 drivers/

[PATCH 1/4] e1000e: Fix jumbo frame receive code.

2007-10-25 Thread Auke Kok
Fix allocation and freeing of jumbo frames where several bugs were recently introduced by cleanups after we forked this code from e1000. This moves ps_pages to buffer_info where it really belongs and makes it a dynamically allocated array. The penalty is not that high since it's allocated outside o

Re: [2.6.25 patch] the planned eepro100 removal

2007-10-25 Thread Bill Davidsen
Adrian Bunk wrote: This patch contains the planned removal of the eepro100 driver. Are the e100 people satisfied that e100 now handles all known cases? I remember that there were corner cases e100 didn't handle, have they all been fixed? -- Bill Davidsen <[EMAIL PROTECTED]> "We have more t

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Dale Farnsworth
On Thu, Oct 25, 2007 at 09:41:14PM +0200, Domen Puncer wrote: > On 25/10/07 11:57 -0700, Dale Farnsworth wrote: > > Domen wrote: > > > > use your platform's dma mapping functions, rather than virt_to_phys() > > > > > > > > it might be the exact same implementation, inside the platform > > > > int

Re: [Bugme-new] [Bug 9225] New: typhoon : "no descs for cmd, had (needed) 0 (1) cmd, 31 (7) resp"

2007-10-25 Thread Andrew Morton
On Thu, 25 Oct 2007 06:45:42 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9225 > >Summary: typhoon : "no descs for cmd, had (needed) 0 (1) cmd, 31 > (7) resp" >Product: Drivers >Version: 2.5 > Kernel

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Domen Puncer
On 25/10/07 11:57 -0700, Dale Farnsworth wrote: > Domen wrote: > > > use your platform's dma mapping functions, rather than virt_to_phys() > > > > > > it might be the exact same implementation, inside the platform > > > internals, but drivers should not be using this directly. > > > > I've repla

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Dale Farnsworth
Domen wrote: > > use your platform's dma mapping functions, rather than virt_to_phys() > > > > it might be the exact same implementation, inside the platform > > internals, but drivers should not be using this directly. > > I've replaced this with dma_map_single(), unmatched with > dma_unmap_sin

Re: BUG in sys_socketpair

2007-10-25 Thread Chuck Ebbert
On 10/25/2007 10:11 AM, Rich Paul wrote: > In 2.6.23, there seems to be a minor bug in sys_socketpair. When the > calls to sock_alloc_fd fail, it aborts the routine, but it returns the > variable err, which is not set in this case. > > The result is a silent failure if you have too many files ope

Re: on the topic of alternate MAC addresses

2007-10-25 Thread Eric W. Biederman
Rick Jones <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Duplicate mac addresses across interfaces on the same machine >> should generally be a don't care. Although there may some >> cases we don't mind. > > What might the switches think of that? Outside of the context of a > link-ag

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Eric W. Biederman
"Denis V. Lunev" <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Benjamin Thery <[EMAIL PROTECTED]> writes: >> >>> Eric W. Biederman wrote: Benjamin Thery <[EMAIL PROTECTED]> writes: > Denis V. Lunev wrote: >> The patch attached should help. The idea is simple. The "in

Re: on the topic of alternate MAC addresses

2007-10-25 Thread Rick Jones
Eric W. Biederman wrote: Duplicate mac addresses across interfaces on the same machine should generally be a don't care. Although there may some cases we don't mind. What might the switches think of that? Outside of the context of a link-aggregate I would think that could do some unhappy thi

Re: [Bugme-new] [Bug 9224] New: Settings to /proc/sys/net/ipv[46]/conf/all are not propagated

2007-10-25 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 25 Oct 2007 09:16:52 -0700), Andrew Morton <[EMAIL PROTECTED]> says: > > Most recent kernel where this bug did not occur: 2.6.22 (not sure) > Apparently a regression. I would say it is a bug, but it is not a regression. I mean, I believe this "bug" lives

Re: [linux-pm] QUESTION: How to fix race between .suspend routine and watchdog timer

2007-10-25 Thread Alan Stern
On Thu, 25 Oct 2007, Maxim Levitsky wrote: > Hi, > > Recently, trying to fix saa7134 suspend/resume problems I found that there > is a race between IRQ handler and .suspend , and that I cant let driver > access the device > while its in D3 since it can lock up some systems. > > Now I am lookin

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Denis V. Lunev
Eric W. Biederman wrote: > Benjamin Thery <[EMAIL PROTECTED]> writes: > >> Eric W. Biederman wrote: >>> Benjamin Thery <[EMAIL PROTECTED]> writes: >>> Denis V. Lunev wrote: > The patch attached should help. The idea is simple. The "init" should be > called only once without NETNS. Per

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Eric W. Biederman
Benjamin Thery <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Benjamin Thery <[EMAIL PROTECTED]> writes: >> >>> Denis V. Lunev wrote: The patch attached should help. The idea is simple. The "init" should be called only once without NETNS. Period. No need for any lists. >>> Th

Re: [Bugme-new] [Bug 9224] New: Settings to /proc/sys/net/ipv[46]/conf/all are not propagated

2007-10-25 Thread Andrew Morton
On Thu, 25 Oct 2007 04:44:06 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9224 > >Summary: Settings to /proc/sys/net/ipv[46]/conf/all are not > propagated >Product: Networking >Version: 2.5 > KernelV

Re: on the topic of alternate MAC addresses

2007-10-25 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > From: Jeff Garzik <[EMAIL PROTECTED]> > Date: Tue, 23 Oct 2007 22:25:05 -0400 > >> h. Using ethtool isn't a big deal, but IMO you probably want more >> than just an exported list for the usage you described... it sounds >> like some sort of reserv

Re: [IFGROUPv4 2/3] Interface group: core (netlink) part

2007-10-25 Thread Patrick McHardy
Laszlo Attila Toth wrote: Patrick McHardy írta: Laszlo Attila Toth wrote: Interface groups let handle different interfaces together especially in netfilter modules. Modified net device structure and netlink interface. @@ -891,6 +895,13 @@ static int do_setlink(struct net_device *dev, struct i

Fried r8169.

2007-10-25 Thread Tom Prince
On Wed, Oct 24, 2007 at 10:11:23PM -0600, Tom Prince wrote: While testing Linux v2.6.24-rc1, I noticed that my onboard r8169 had disappeared, and the it remained gone when I rebooted to v2.6.23 and v2.6.22, where it had previously worked. I have no idea where to begin debugging (or even reproduci

Re: D-Link DFE-580TX and snmpd problems, who's maintainer of sundance.c ?

2007-10-25 Thread Volker Sauer
On Mi, 24 Okt 2007, Francois Romieu <[EMAIL PROTECTED]> wrote: > > So the questions is: why? What is this good for? > > And: can I remove it? I can not abandon snmpd and the messages spam my > > syslog. > > Or: do I have to patch snmpd? > > Please try the attached patch. > Hi Francois, the patc

Re: [IFGROUPv4 2/3] Interface group: core (netlink) part

2007-10-25 Thread Laszlo Attila Toth
Patrick McHardy írta: Laszlo Attila Toth wrote: Interface groups let handle different interfaces together especially in netfilter modules. Modified net device structure and netlink interface. @@ -891,6 +895,13 @@ static int do_setlink(struct net_device *dev, struct ifinfomsg *ifm, }

Re: [IFGROUPv4 iptables] Interface group match

2007-10-25 Thread Patrick McHardy
Laszlo Attila Toth wrote: +++ extensions/libxt_ifgroup.c (revision 0) @@ -0,0 +1,196 @@ +/* + * Shared library add-on to iptables to match + * packets by the incoming interface group. + * + * (c) 2006, 2007 Balazs Scheidler <[EMAIL PROTECTED]>, + * Laszlo Attila Toth <[EMAIL PROTECTED]> + */

Re: [IFGROUPv4 3/3] Netfilter Interface group match

2007-10-25 Thread Patrick McHardy
Laszlo Attila Toth wrote: +++ b/net/netfilter/xt_ifgroup.c +static bool +ifgroup_match(const struct sk_buff *skb, +const struct net_device *in, +const struct net_device *out, +const struct xt_match *match, +const void *matchinfo, +int of

Re: [IFGROUPv4 2/3] Interface group: core (netlink) part

2007-10-25 Thread Patrick McHardy
Laszlo Attila Toth wrote: Interface groups let handle different interfaces together especially in netfilter modules. Modified net device structure and netlink interface. @@ -891,6 +895,13 @@ static int do_setlink(struct net_device *dev, struct ifinfomsg *ifm, } } + if

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
Eric W. Biederman wrote: > Benjamin Thery <[EMAIL PROTECTED]> writes: > >> Denis V. Lunev wrote: >>> The patch attached should help. The idea is simple. The "init" should be >>> called only once without NETNS. Period. No need for any lists. >> This is the kind of idea I had but I didn't think it c

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Eric W. Biederman
Benjamin Thery <[EMAIL PROTECTED]> writes: > Denis V. Lunev wrote: >> The patch attached should help. The idea is simple. The "init" should be >> called only once without NETNS. Period. No need for any lists. > > This is the kind of idea I had but I didn't think it could be > that simple. :) > T

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Eric W. Biederman
"Denis V. Lunev" <[EMAIL PROTECTED]> writes: > The patch attached should help. The idea is simple. The "init" should be > called only once without NETNS. Period. No need for any lists. > > I'll resend it to Dave after the ACK. First in the case of the code that is currently merged none of the __

[IFGROUPv4 iptables] Interface group match

2007-10-25 Thread Laszlo Attila Toth
Interface group values can be checked on both input and output interfaces with optional mask. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- Makefile |2 libip6t_ifgroup.man | 36 +++ libipt_ifgroup.man | 36 +++ libxt_ifgroup.c

[IFGROUPv4 3/3] Netfilter Interface group match

2007-10-25 Thread Laszlo Attila Toth
Interface group values can be checked on both input and output interfaces. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/netfilter/xt_ifgroup.h | 18 + net/netfilter/Kconfig| 16 + net/netfilter/Makefile |1 + net/netfilter/x

[IFGROUPv4 iproute 1/2] Added IFLA_NET_NS_PID as in kernel v2.6.24-rc1

2007-10-25 Thread Laszlo Attila Toth
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/if_link.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/if_link.h b/include/linux/if_link.h index 23b3a8e..c948395 100644 --- a/include/linux/if_link.h +++ b/include/linux/if_link.h @@

[IFGROUPv4 2/3] Interface group: core (netlink) part

2007-10-25 Thread Laszlo Attila Toth
Interface groups let handle different interfaces together especially in netfilter modules. Modified net device structure and netlink interface. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/if_link.h |2 ++ include/linux/netdevice.h |2 ++ net/core/rtnetlink.c

[IFGROUPv4 iproute 2/2] Interface group as new ip link option

2007-10-25 Thread Laszlo Attila Toth
Interfaces can be grouped and each group has an unique positive integer ID. It can be set via ip link. Symbolic names can be specified in /etc/iproute2/rt_ifgroup. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- include/linux/if_link.h |2 + include/rt_names.h |2 + ip/ipad

[IFGROUPv4 1/3] rtnetlink: setlink changes atomic with single notification

2007-10-25 Thread Laszlo Attila Toth
In do_setlink the device changes are atomic and notifications will be sent at the end of the function once if any modification occured and once if address has been changed. Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> --- net/core/rtnetlink.c | 34 -- 1

[IFGROUPv4 0/3 (+3)] Interface group patches

2007-10-25 Thread Laszlo Attila Toth
Hi Dave, This is the 4th version of our interface group patches. The only difference from the previous one is in the first patch (single notification and atomic changes in rtnetlink) plus in iptables code: parameter in-ifgroup changed to ifgroup-in (and ifgroup-out). I had to add IFLA_NET_NS_PID

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
Denis V. Lunev wrote: > The patch attached should help. The idea is simple. The "init" should be > called only once without NETNS. Period. No need for any lists. This is the kind of idea I had but I didn't think it could be that simple. :) Thanks Denis. > I'll resend it to Dave after the ACK.

BUG in sys_socketpair

2007-10-25 Thread Rich Paul
In 2.6.23, there seems to be a minor bug in sys_socketpair. When the calls to sock_alloc_fd fail, it aborts the routine, but it returns the variable err, which is not set in this case. The result is a silent failure if you have too many files open and call socketpair. Here is a simple UNTESTED p

Re: [Devel] Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n (resend, was wrong patch)

2007-10-25 Thread Denis V. Lunev
Denis V. Lunev wrote: > The patch attached should help. The idea is simple. The "init" should be > called only once without NETNS. Period. No need for any lists. > > I'll resend it to Dave after the ACK. > > Regards, > Den > > Benjamin Thery wrote: >> Hello Pavel, >> >> I've found a proble

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Domen Puncer
On 25/10/07 05:29 -0400, Jeff Garzik wrote: > Domen Puncer wrote: > >+static int mpc52xx_fec_alloc_rx_buffers(struct bcom_task *rxtsk) > >+{ > >+while (!bcom_queue_full(rxtsk)) { > >+struct sk_buff *skb; > >+struct bcom_fec_bd *bd; > >+ > >+skb = dev_alloc_sk

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Denis V. Lunev
The patch attached should help. The idea is simple. The "init" should be called only once without NETNS. Period. No need for any lists. I'll resend it to Dave after the ACK. Regards, Den Benjamin Thery wrote: > Hello Pavel, > > I've found a problem with one of your patch related to netn

[PATCH] NetLabel: correct usage of RCU locking

2007-10-25 Thread Paul Moore
This fixes some awkward, and perhaps even problematic, RCU lock usage in the NetLabel code as well as some other related trivial cleanups found when looking through the RCU locking. Most of the changes involve removing the redundant RCU read locks wrapping spinlocks in the case of a RCU writer. S

[PATCH] NetLabel fixes against 2.6.24-rc1

2007-10-25 Thread Paul Moore
There have been some good discussions on the list about RCU lately that made me realize NetLabel was doing some rather stupid things in regards to how it makes use of RCU. This is a small patch again against 2.6.24-rc1 which should fix the RCU problems. You can grab the patch from email or from h

[PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Howells
Mark snmp4_icmp_list[] as being unused to avoid the warning it would otherwise incur. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- net/ipv4/proc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/ipv4/proc.c b/net/ipv4/proc.c index fd16cb8..1c0854d 100644 --

[NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
Hello Pavel, I've found a problem with one of your patch related to netns: * [NETNS] Move some code into __init section when CONFIG_NET_NS=n (v2) http://www.spinics.net/lists/netdev/msg43310.html This patch introduces the __net_init/__net_exit/__net_initdata defines to save some memory when C

Re: [PATCH,RFC] Marvell Orion SoC ethernet driver

2007-10-25 Thread Lennert Buytenhek
On Thu, Oct 25, 2007 at 05:12:04AM -0400, Jeff Garzik wrote: > >+struct rx_desc { > >+u32 cmd_sts; > >+u16 size; > >+u16 count; > >+u32 buf; > >+u32 next; > >+}; > >+ > >+struct tx_desc { > >+u32 cmd_sts; > >+u16 l4i_chk; > >+u16 count; > >+u32 buf; > >+u32

Re: [PATCH v1.2.8] wan: new driver retina

2007-10-25 Thread Jeff Garzik
Matti Linnanvuori wrote: From: Matti Linnanvuori <[EMAIL PROTECTED]> Adding Retina G.703 and G.SHDSL driver. Signed-off-by: Matti Linnanvuori <[EMAIL PROTECTED]> Overall comment: very nice and clean, well done. diff -Napur linux-2.6.23/drivers/net/wan/Kconfig linux-2.6.24/drivers/net/wa

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Jeff Garzik
Domen Puncer wrote: +static int mpc52xx_fec_alloc_rx_buffers(struct bcom_task *rxtsk) +{ + while (!bcom_queue_full(rxtsk)) { + struct sk_buff *skb; + struct bcom_fec_bd *bd; + + skb = dev_alloc_skb(FEC_RX_BUFFER_SIZE); + if (skb == NUL

Re: [PATCH] wan: new driver retina

2007-10-25 Thread Jeff Garzik
Not sure what's going on, but your patch looks scrambled, as scripts look at it: From: Matti Linnanvuori <[EMAIL PROTECTED]>=0A=0AAdding Retina G.7= 03 and G.SHDSL driver.=0A=0ASigned-off-by: Matti Linnanvuori =0A---=0A=0AFixing bugs and style according to netdev mailing= list comments.=0A=0

Re: [PATCH,RFC] Marvell Orion SoC ethernet driver

2007-10-25 Thread Jeff Garzik
Lennert Buytenhek wrote: +struct rx_desc { + u32 cmd_sts; + u16 size; + u16 count; + u32 buf; + u32 next; +}; + +struct tx_desc { + u32 cmd_sts; + u16 l4i_chk; + u16 count; + u32 buf; + u32 next; +}; should use sparse type (__le32, etc

Re: [RFC][PATCH 0/3][XFRM]: Support packet processing error statistics.

2007-10-25 Thread Masahide NAKAMURA
Wednesday 24 October 2007 21:18, jamal wrote: > On Wed, 2007-24-10 at 12:30 +0900, Masahide NAKAMURA wrote: > > > At IPsec point of view, actually "SPI mismatch" caused by user configuration > > cannot be identified easily since identify of SAD is consist of SPI, > > address and > > protocol(ESP/

Re: Regression in current git - Network Manager fails (bisected)

2007-10-25 Thread Thomas Graf
* Dan Williams <[EMAIL PROTECTED]> 2007-10-23 10:10 > Should I make NM disable ACKs for now until it gets fixed? The reason libnl enables ACKs by default is to give the application using it clear synchronisation points. For change requests that means the interface function won't return until the c

[PATCH net-2.6] [TCP]: fix D-SACK cwnd handling

2007-10-25 Thread Ryousei Takano
In the current net-2.6 kernel, handling FLAG_DSACKING_ACK is broken. The flag is cleared to 1 just after FLAG_DSACKING_ACK is set. if (found_dup_sack) flag |= FLAG_DSACKING_ACK; : flag = 1; To fix it, this patch introduces a part of the tcp_sacktag_state pa

Re: [PATCH net-2.6] [TCP]: fix D-SACK cwnd handling

2007-10-25 Thread Ilpo Järvinen
On Thu, 25 Oct 2007, Ryousei Takano wrote: > In the current net-2.6 kernel, handling FLAG_DSACKING_ACK is broken. > The flag is cleared to 1 just after FLAG_DSACKING_ACK is set. > > if (found_dup_sack) > flag |= FLAG_DSACKING_ACK; > : > flag = 1; > > To fix it

[git patches] net driver updates

2007-10-25 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: Documentation/networking/00-INDEX|2 - Documentation/networking/net-modules.txt | 315 -- dri

Re: [PATCH 1/3] netdev: use ARRAY_SIZE() instead of sizeof(array) / ETH_GSTRING_LEN

2007-10-25 Thread Jeff Garzik
applied 1-3 to #upstream (2.6.25) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] forcedeth new device ids

2007-10-25 Thread Jeff Garzik
applied 1-2, after combining into a single patch - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] cpmac: use print_mac() instead of MAC_FMT

2007-10-25 Thread Jeff Garzik
Eugene Konev wrote: Switch to using DECLARE_MAC_BUF/print_mac() added by commit 0795af5729b18218767fab27c44b1384f72dc9ad [NET]: Introduce and use print_mac() and DECLARE_MAC_BUF(). Signed-off-by: Eugene Konev <[EMAIL PROTECTED]> applied 1-3 - To unsubscribe from this list: send the line "un

Re: [2.6 patch] remove Documentation/networking/net-modules.txt

2007-10-25 Thread Jeff Garzik
Adrian Bunk wrote: According to git, the only one who touched this file during the last 5 years was me when removing drivers... modinfo offers less ancient information. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Geert Uytterhoeven <[EMAIL PROTECTED]> Acked-by: Paul Gortmaker <[EMA

Re: [2.6 patch] drivers/net/ipg.c: cleanups

2007-10-25 Thread Jeff Garzik
Adrian Bunk wrote: This patch contains the following cleanups: - make ipg_nic_get_stats() static - move DefaultPhyParam[] from ipg.h to ipg.c and make it static applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majo

Re: [2.6 patch] make bonding/bond_main.c:bond_deinit() static

2007-10-25 Thread Jeff Garzik
applied both bonding patches - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html