Re: [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address

2007-10-23 Thread Timo Teräs
Hi, Alexey Kuznetsov wrote: The only dubious case is when next hop is set using routing tables. But code in ipgre_tunnel_xmit() is ready to accept this situation, it checks for zero destination address and fixes it when it is able to. Nevertheless, it does not work. Another thoughts? Could

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread Dave Jones
On Tue, Oct 23, 2007 at 04:03:38PM -0700, Kok, Auke wrote: > Dave Jones wrote: > > On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote: > > > > > > In any case, this patch should not be merged. We often send it around > > to users to > > > > debug their issue in case it involves e

Re: [BUG] 2.6.23-git19 - S390x: Kernel panic while bringing up the network interface

2007-10-23 Thread Heiko Carstens
On Wed, Oct 24, 2007 at 08:59:06AM +0530, Kamalesh Babulal wrote: > Hi, > > Kernel panic's while bringing up the network interface with the 2.6.23-git19 > > Setting network parameters: Ý OK ¨ > Bringing up loopback interface: Ý OK ¨ > Bringing up interface eth0: > Ý<002e2f72>¨ inet

Re: [PATCH] Cleanup the IPv6 addresses printing in /proc files

2007-10-23 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 21:15:36 -0700 > On Tue, 2007-10-23 at 21:10 -0700, David Miller wrote: > > We'll break things if we change it. > > Maybe, but definitely the macro names should > reflect this brokenness. That's a good point, we don't want to encourage

Re: [PATCH] Explicitly call fib_get_table() in fib_frontend.c

2007-10-23 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 22 Oct 2007 19:56:04 +0400 > In case the "multiple tables" config option is y, the ip_fib_local_table > is not a variable, but a macro, that calls fib_get_table(RT_TABLE_LOCAL). > > Some code uses this "variable" *3* times in one place, thus im

Re: [PATCH 3/3] Use BUILD_BUG_ON in net/core/flowi.c

2007-10-23 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 22 Oct 2007 19:28:22 +0400 > Instead of ugly extern not-existing function. I can take credit for this turd. Hey, it was the accepted way to do compile time assertions at the time :-) > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Appli

Re: [PATCH] Cleanup the IPv6 addresses printing in /proc files

2007-10-23 Thread Joe Perches
On Tue, 2007-10-23 at 21:10 -0700, David Miller wrote: > We'll break things if we change it. Maybe, but definitely the macro names should reflect this brokenness. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 2/3] Remove in-code externs for some functions from net/core/dev.c

2007-10-23 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 22 Oct 2007 19:25:50 +0400 > Inconsistent prototype and real type for functions may have > worse consequences, than those for variables, so move them > into a header. > > Since they are used privately in net/core, make this file > reside in the

Re: [PATCH 1/3] Don't declare extern variables in net/core/sysctl_net_core.c

2007-10-23 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 22 Oct 2007 19:22:43 +0400 > Some are already declared in include/linux/netdevice.h, while > some others (xfrm ones) need to be declared. > > The driver/net/rrunner.c just uses same extern as well, so > cleanup it also. > > Signed-off-by: Pav

Re: [PATCH] Cleanup the IPv6 addresses printing in /proc files

2007-10-23 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 21:04:01 -0700 > On Tue, 2007-10-23 at 20:43 -0700, David Miller wrote: > > From: Pavel Emelyanov <[EMAIL PROTECTED]> > > Date: Tue, 23 Oct 2007 20:37:22 +0400 > > > The /proc/net udp6, tcp6 and raw6 files print the IPs of > > > the conn

Re: [PATCH] Cleanup the IPv6 addresses printing in /proc files

2007-10-23 Thread Joe Perches
On Tue, 2007-10-23 at 20:43 -0700, David Miller wrote: > From: Pavel Emelyanov <[EMAIL PROTECTED]> > Date: Tue, 23 Oct 2007 20:37:22 +0400 > > The /proc/net udp6, tcp6 and raw6 files print the IPs of > > the connection ends. Make a NIP6Lxxx macros (L stands for > > "long") for making the printing c

Re: [RFC][PATCH 0/3][XFRM]: Support packet processing error statistics.

2007-10-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 23 Oct 2007 16:08:34 +0900), Masahide NAKAMURA <[EMAIL PROTECTED]> says: > Monday 22 October 2007 21:28, jamal wrote: > > On Mon, 2007-22-10 at 15:11 +0900, Masahide NAKAMURA wrote: : > This point is one of what I want to hear comment. > My patch uses "XFRM

Re: sch_prio.c vs CONFIG_NETDEVICES_MULTIQUEUE

2007-10-23 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 17:01:24 +0400 > Fix more users of netiff_subqueue_stopped. To check for the > queue id one must use the __netiff_subqueue_stoped call. > > These run out of my sight when I made the > 668f895a85b0c3a62a690425145f13dabebebd7a commit

Re: [PATCH] Cleanup the IPv6 addresses printing in /proc files

2007-10-23 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 20:37:22 +0400 > The /proc/net udp6, tcp6 and raw6 files print the IPs of > the connection ends. Make a NIP6Lxxx macros (L stands for > "long") for making the printing code look nicer. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROT

Re: [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address

2007-10-23 Thread David Miller
From: Alexey Kuznetsov <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 23:03:24 +0400 > Hello! > > > When GRE tunnel is in NBMA mode, this patch allows an application to use > > a PF_PACKET socket to: > > - send a packet to specific NBMA address with sendto() > > - use recvfrom() to receive packet and

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-23 Thread Benjamin Herrenschmidt
On Tue, 2007-10-23 at 20:57 -0500, Valentine Barshak wrote: > +static int m88e_init(struct mii_phy *phy) > +{ > + printk("%s: Marvell 88E Ethernet\n", __FUNCTION__); > + phy_write(phy, 0x14, 0x0ce3); > + phy_write(phy, 0x18, 0x4101); > + phy_write(phy, 0x09, 0x0e00); > +

[BUG] 2.6.23-git19 - S390x: Kernel panic while bringing up the network interface

2007-10-23 Thread Kamalesh Babulal
Hi, Kernel panic's while bringing up the network interface with the 2.6.23-git19 Setting network parameters: Ý OK ¨ Bringing up loopback interface: Ý OK ¨ Bringing up interface eth0: Ý<002e2f72>¨ inet_ioctl+0xd6/0x110 Ý<0027cae2>¨ sock_ioctl+0x26e/0x2a0 Ý<000b4c52

Re: [RFC][PATCH 0/3][XFRM]: Support packet processing error statistics.

2007-10-23 Thread Masahide NAKAMURA
Wednesday 24 October 2007 04:47, jamal wrote: > On Tue, 2007-23-10 at 16:08 +0900, Masahide NAKAMURA wrote: > > > Thanks. I would like you to find too much item at my patch > > for the statistics, too. > > I am not anywhere close to a machine where i can give you precise > details to this; the on

Re: [PATCH] Consolidate sctp_ulpq_renege_xxx functions

2007-10-23 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 11:57:42 -0400 > Pavel Emelyanov wrote: > > Both are equal, except for the list to be traversed. > > > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > > > > ACK. Good clean-up Pavel. Yep, nice work, applied. Thanks! - To u

Re: [PATCH] fix ACK processing after netlink_dump_start

2007-10-23 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 18:34:28 +0200 > * Denis V. Lunev <[EMAIL PROTECTED]> 2007-10-23 18:40 > > Revert to original netlink behavior. Do not reply with ACK if the > > netlink dump has bees successfully started. > > > > libnl has been broken by the cd40b7d398

Re: [VLAN]: MAINTAINERS update

2007-10-23 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 18:37:54 +0200 > [VLAN]: MAINTAINERS update > > Ben stepped down from VLAN maintainership due to a lack of time, > add myself as new maintainer. Applied, thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: [PATCH] UDP: Make use of inet_iif() when doing socket lookups.

2007-10-23 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 14:40:58 -0400 > UDP currently uses skb->dev->ifindex which may provide the wrong > information when the socket bound to a specific interface. > This patch makes inet_iif() accessible to UDP and makes UDP use it. > > The scenario we a

Re: on the topic of alternate MAC addresses

2007-10-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 22:25:05 -0400 > h. Using ethtool isn't a big deal, but IMO you probably want more > than just an exported list for the usage you described... it sounds > like some sort of reservation system should be used, to note which MAC >

[PATCH 2/3] cpmac: convert to napi_struct interface

2007-10-23 Thread Eugene Konev
Convert cpmac to new napi_struct API introduced by bea3348eef27e6044b6161fd04c3152215f96411 [NET]: Make NAPI polling independent of struct net_device objects. Only disable rx interrupts if napi actually has been scheduled. Signed-off-by: Eugene Konev <[EMAIL PROTECTED]> --- drivers/net/cpmac.c |

[PATCH 3/3] cpmac: update to new fixed phy driver interface

2007-10-23 Thread Eugene Konev
Use fixed_mdio_get_phydev for obtaining fixed phy instances and adopt to changed fixed phy device naming. Signed-off-by: Eugene Konev <[EMAIL PROTECTED]> --- drivers/net/cpmac.c | 64 -- 1 files changed, 46 insertions(+), 18 deletions(-) diff --g

[PATCH 1/3] cpmac: use print_mac() instead of MAC_FMT

2007-10-23 Thread Eugene Konev
Switch to using DECLARE_MAC_BUF/print_mac() added by commit 0795af5729b18218767fab27c44b1384f72dc9ad [NET]: Introduce and use print_mac() and DECLARE_MAC_BUF(). Signed-off-by: Eugene Konev <[EMAIL PROTECTED]> --- drivers/net/cpmac.c | 13 - 1 files changed, 4 insertions(+), 9 delet

[PATCH 0/0] cpmac: update to the net subsystem changes

2007-10-23 Thread Eugene Konev
This patchset includes cpmac updates for changed net subsystem interfaces. Please accept the following patches for cpmac driver: 1. cpmac: use print_mac() instead of MAC_FMT 2. cpmac: convert to napi_struct interface 3. cpmac: update to new fixed phy driver interface - To unsubscribe from thi

Re: [PATCH] NET: Validate device addr prior to interface-up

2007-10-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 22:33:13 -0400 > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > --- > David, I would actually prefer if you queued this one up, please... No worries, I will. Thanks Jeff. - To unsubscribe from this list: send the line "unsubscribe

[PATCH] NET: Validate device addr prior to interface-up

2007-10-23 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- David, I would actually prefer if you queued this one up, please... diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 4a3f54e..962d1de 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -669,6 +669,8

Re: on the topic of alternate MAC addresses

2007-10-23 Thread Jeff Garzik
Jeff Garzik wrote: h. Using ethtool isn't a big deal, but IMO you probably want more than just an exported list for the usage you described... it sounds like some sort of reservation system should be used, to note which MAC addresses are [not] in use? Then a virt client -- or anyone who

Re: on the topic of alternate MAC addresses

2007-10-23 Thread Jeff Garzik
David Miller wrote: I've been meaning to bring this up. A lot of cards that support multiple MAC addresses in hardware provide pre-cooked lists of alternate MAC addresses. This is either done via EEPROM, NVRAM, or OpenFirmware device properties. For example, the Sun Neptune cards can provide a

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-10-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 22:20:30 -0400 > David Miller wrote: > > From: Jeff Garzik <[EMAIL PROTECTED]> > > Date: Tue, 23 Oct 2007 21:03:36 -0400 > > > >> I'm wondering if there is a way to avoid adding > >> > >>if (!is_valid_ether_addr(dev->dev_addr)) > >>

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-10-23 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 21:03:36 -0400 I'm wondering if there is a way to avoid adding if (!is_valid_ether_addr(dev->dev_addr)) return -EINVAL; to every ethernet driver's ->open() hook. The first idea I get is:

[git patches] warning fixes

2007-10-23 Thread Jeff Garzik
The cgroup change was ack'd by the maintainer. The drivers/net/ were of course self-ack'd. Please pull from 'warnings' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git warnings to receive the following updates: drivers/net/eexpress.c |2 +- drivers/net/ni5010.c

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-23 Thread Jeff Garzik
Andy Gospodarek wrote: On Tue, Oct 23, 2007 at 06:00:01PM -0700, Jay Vosburgh wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: applied patches 1-6 Thanks. However, two issues: 1) Credit. Did Andy write these, as the Signed-off-by lines indicate? Andy did some of it and I di

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-23 Thread Andy Gospodarek
On Tue, Oct 23, 2007 at 06:00:01PM -0700, Jay Vosburgh wrote: > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > >applied patches 1-6 > > Thanks. > > >However, two issues: > > > >1) Credit. Did Andy write these, as the Signed-off-by lines indicate? > > Andy did some of it and I did some

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-10-23 Thread Adrian Bunk
On Tue, Oct 23, 2007 at 08:55:29PM -0400, Jeff Garzik wrote: > Actually, looking over the code I see obvious bugs in the logic: > > An invalid ethernet address should not cause device loading to fail, > because the user is given the opportunity to supply a MAC address via > userspace (ifconfig or

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-10-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 21:03:36 -0400 > I'm wondering if there is a way to avoid adding > > if (!is_valid_ether_addr(dev->dev_addr)) > return -EINVAL; > > to every ethernet driver's ->open() hook. The first idea I get is: 1) Create netd

on the topic of alternate MAC addresses

2007-10-23 Thread David Miller
I've been meaning to bring this up. A lot of cards that support multiple MAC addresses in hardware provide pre-cooked lists of alternate MAC addresses. This is either done via EEPROM, NVRAM, or OpenFirmware device properties. For example, the Sun Neptune cards can provide an array of up to 16 a

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-10-23 Thread Jeff Garzik
Jeff Garzik wrote: Actually, looking over the code I see obvious bugs in the logic: An invalid ethernet address should not cause device loading to fail, because the user is given the opportunity to supply a MAC address via userspace (ifconfig or whatever) before the interface goes up. I just

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-23 Thread Jay Vosburgh
Jeff Garzik <[EMAIL PROTECTED]> wrote: >applied patches 1-6 Thanks. >However, two issues: > >1) Credit. Did Andy write these, as the Signed-off-by lines indicate? Andy did some of it and I did some of it, so I presume that dual Signed-off-by is correct (vs. one Signed-off and

[PATCH] e1000, e1000e valid-addr fixes

2007-10-23 Thread Jeff Garzik
Actually, looking over the code I see obvious bugs in the logic: An invalid ethernet address should not cause device loading to fail, because the user is given the opportunity to supply a MAC address via userspace (ifconfig or whatever) before the interface goes up. I just created the attache

Re: [PATCH 1/6] Convert bonding timers to workqueues

2007-10-23 Thread Jeff Garzik
Jay Vosburgh wrote: Convert bonding timers to workqueues. This converts the various monitor functions to run in periodic work queues instead of timers. This patch introduces the framework and convers the calls, but does not resolve various locking issues, and does not stand alone. Sign

Re: [PATCH] pasemi_mac: fix typo

2007-10-23 Thread Jeff Garzik
Olof Johansson wrote: Add missing &: drivers/net/pasemi_mac.c: In function 'pasemi_mac_clean_rx': drivers/net/pasemi_mac.c:553: warning: passing argument 1 of 'prefetch' makes pointer from integer without a cast Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/pasemi

Re: [patch 1/2] : remove header_ops bug in qeth driver

2007-10-23 Thread Jeff Garzik
applied 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] defxx.c: dfx_bus_init() is __devexit not __devinit

2007-10-23 Thread Jeff Garzik
Maciej W. Rozycki wrote: The dfx_bus_uninit() call is called from dfx_unregister() which is __devexit and which is ultimately the ->remove call for the device. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- It should be obvious. Please apply. Maciej patch-mips-2.6.23-rc5-200709

Re: [PATCH][MIPS] AR7 ethernet

2007-10-23 Thread Jeff Garzik
Matteo Croce wrote: Il Monday 15 October 2007 20:24:21 Jeff Garzik ha scritto: applied Small update to the driver, please apply Signed-off-by: Matteo Croce <[EMAIL PROTECTED]> Signed-off-by: Eugene Konev <[EMAIL PROTECTED]> Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> applied Please p

Re: [MIPS] MIPSnet: Delete all the useless debugging printks.

2007-10-23 Thread Jeff Garzik
Ralf Baechle wrote: Plus minor formatting fixes. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sky2: crash on remove

2007-10-23 Thread Jeff Garzik
Stephen Hemminger wrote: Fix off-by one in remove logic that just got introduced. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- This only occurs in new post 2.6.23 code. applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: Please pull features branch of linux-2.6-mv643xx_eth.git

2007-10-23 Thread Jeff Garzik
Dale Farnsworth wrote: The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394: Linus Torvalds (1): Revert "kconfig: tristate choices with mixed tristate and boolean values" are available in the git repository at: git://farnsworth.org/dale/linux-2.6-mv643xx_eth.

Re: Please pull bug-fixes branch of linux-2.6-mv643xx_eth.git

2007-10-23 Thread Jeff Garzik
Dale Farnsworth wrote: The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394: Linus Torvalds (1): Revert "kconfig: tristate choices with mixed tristate and boolean values" are available in the git repository at: git://farnsworth.org/dale/linux-2.6-mv643xx_eth.

Re: [PATCH 00/13] r8169: pull request for 'upstream-jeff' branch

2007-10-23 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'upstream-jeff' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git upstream-jeff pulled, thanks. and thanks for continuing to CC RealTek. - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread Stephen Hemminger
On Tue, 23 Oct 2007 16:03:38 -0700 "Kok, Auke" <[EMAIL PROTECTED]> wrote: > Dave Jones wrote: > > On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote: > > > > > > In any case, this patch should not be merged. We often send it around > > to users to > > > > debug their issue in case it

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread Kok, Auke
David Miller wrote: > From: Dave Jones <[EMAIL PROTECTED]> > Date: Tue, 23 Oct 2007 17:20:26 -0400 > >> Indeed. This is a common enough problem that not including it causes >> more pain than its worth. I have two affected boxes myself that I >> actually thought the hardware was dead before I trie

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread Kok, Auke
Dave Jones wrote: > On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote: > > > > In any case, this patch should not be merged. We often send it around to > users to > > > debug their issue in case it involves eeproms, but merging it will just > conceal > > > the real issue and all of

Re: [PATCH 11/12] NET: fix subqueue bugs

2007-10-23 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 18:36:46 -0400 (EDT) net/sched/sch_prio.c: In function $,1rxprio_dequeue$,1ry: net/sched/sch_prio.c:139: warning: passing argument 2 of $,1rxnetif_subqueue_stopped$,1ry makes pointer from integer without a cas

Re: [PATCH 11/12] NET: fix subqueue bugs

2007-10-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 18:36:46 -0400 (EDT) > net/sched/sch_prio.c: In function $,1rx(Bprio_dequeue$,1ry(B: > net/sched/sch_prio.c:139: warning: passing argument 2 of > $,1rx(Bnetif_subqueue_stopped$,1ry(B makes pointer from integer without a > cast

[PATCH 8/12] ni5010: kill unused variable

2007-10-23 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- diff --git a/drivers/net/ni5010.c b/drivers/net/ni5010.c index 14a768f..a20005c 100644 --- a/drivers/net/ni5010.c +++ b/drivers/net/ni5010.c @@ -518,7 +518,6 @@ static void dump_packet(void *buf, int len) /* We have a good packet, get it out of t

[PATCH 11/12] NET: fix subqueue bugs

2007-10-23 Thread Jeff Garzik
net/sched/sch_prio.c: In function ‘prio_dequeue’: net/sched/sch_prio.c:139: warning: passing argument 2 of ‘netif_subqueue_stopped’ makes pointer from integer without a cast net/sched/sch_prio.c: In function ‘rr_dequeue’: net/sched/sch_prio.c:169: warning: passing argument 2 of ‘net

[PATCH 7/12] eexpress: fix !SMP unused-var warning

2007-10-23 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- diff --git a/drivers/net/eexpress.c b/drivers/net/eexpress.c index 9c85e50..70509ed 100644 --- a/drivers/net/eexpress.c +++ b/drivers/net/eexpress.c @@ -651,9 +651,9 @@ static void eexp_timeout(struct net_device *dev) */ static int eexp_xmit(st

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-23 Thread Bill Davidsen
Al Boldi wrote: [EMAIL PROTECTED] wrote: On Sat, 20 Oct 2007 06:40:02 +0300, Al Boldi said: Sure, the idea was to mark the filter table obsolete as to make people start using the mangle table to do their filtering for new setups. The filter table would then still be available for legacy/specia

Re: [VLAN]: MAINTAINERS update

2007-10-23 Thread Ben Greear
Patrick McHardy wrote: [VLAN]: MAINTAINERS update Ben stepped down from VLAN maintainership due to a lack of time, add myself as new maintainer. ACK. Thanks Patrick! Ben -- Ben Greear <[EMAIL PROTECTED]> Candela

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread David Miller
From: Dave Jones <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 17:20:26 -0400 > Indeed. This is a common enough problem that not including it causes > more pain than its worth. I have two affected boxes myself that I > actually thought the hardware was dead before I tried ajax's patch. > > People ar

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread David Miller
From: "Kok, Auke" <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 14:01:21 -0700 > We help everyone out, and if you merge this patch you will prevent > users from getting to us for support in the first place. If using the bad eeprom has to be explicitly enabled by the user, your argument holds no wate

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 16:40:01 -0400 > Sorry, I disagree. Just as with e100, if there is a clear way the user > can recover their setup -- and Adam says his was effective -- I don't > see why we should be denying users the ability to use their own hardware

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread Alan Cox
> People aren't going to report this as a bug. They aren't going to try out > patches, > they're going to do what I did and stick another network card in the box and > go on with life. > > Our users deserve better than this. Agreed. By all means warn people, or give them a 1-800 Intel number to

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread Dave Jones
On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote: > > In any case, this patch should not be merged. We often send it around to > > users to > > debug their issue in case it involves eeproms, but merging it will just > > conceal > > the real issue and all of a sudden a flood of pe

Please pull features branch of linux-2.6-mv643xx_eth.git

2007-10-23 Thread Dale Farnsworth
The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394: Linus Torvalds (1): Revert "kconfig: tristate choices with mixed tristate and boolean values" are available in the git repository at: git://farnsworth.org/dale/linux-2.6-mv643xx_eth.git features Dale Farns

Please pull bug-fixes branch of linux-2.6-mv643xx_eth.git

2007-10-23 Thread Dale Farnsworth
The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394: Linus Torvalds (1): Revert "kconfig: tristate choices with mixed tristate and boolean values" are available in the git repository at: git://farnsworth.org/dale/linux-2.6-mv643xx_eth.git bug-fixes Dale Farn

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread Kok, Auke
Jeff Garzik wrote: > Kok, Auke wrote: >> Adam Jackson wrote: >>> On Tue, 2007-10-23 at 09:18 -0700, Kok, Auke wrote: Adam Jackson wrote: > When the EEPROM gets corrupted, you can fix it with ethtool, but > only if > the module loads and creates a network device. But, without this

Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.

2007-10-23 Thread Jeff Garzik
Kok, Auke wrote: Adam Jackson wrote: On Tue, 2007-10-23 at 09:18 -0700, Kok, Auke wrote: Adam Jackson wrote: When the EEPROM gets corrupted, you can fix it with ethtool, but only if the module loads and creates a network device. But, without this option, if the EEPROM is corrupted, the driver

Re: [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address

2007-10-23 Thread Alexey Kuznetsov
Hello! Me wrote: > Ack. This is good idea. > > Frankly, I was sure ip_gre worked in this way all these years. > I do not remember any reasons why it was crippled. > > The only dubious case is when next hop is set using routing tables. > But code in ipgre_tunnel_xmit() is ready to accept this si

Re: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer allocations.

2007-10-23 Thread David Brownell
> From [EMAIL PROTECTED] Tue Oct 23 10:51:00 2007 > Date: Tue, 23 Oct 2007 21:40:18 +0400 > From: Valentine Barshak <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org > Subject: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer > allocations. > > On syst

Re: [RFC][PATCH 0/3][XFRM]: Support packet processing error statistics.

2007-10-23 Thread jamal
On Tue, 2007-23-10 at 16:08 +0900, Masahide NAKAMURA wrote: > Thanks. I would like you to find too much item at my patch > for the statistics, too. I am not anywhere close to a machine where i can give you precise details to this; the one thing that sticks out in my brain cells is the SPI mismatc

[PATCH] e1000: alternate MAC address support

2007-10-23 Thread Bill Hayes
Port alternate MAC address support from the sourceforge e1000 driver to the upstream e1000 driver. Signed-off-by: Bill Hayes <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.c | 42 +++--- drivers/net/e1000/e1000_hw.h |2 ++ 2 files changed, 41 insert

[PATCH] e1000e: alternate MAC address support

2007-10-23 Thread Bill Hayes
Port alternate MAC address support from the sourceforge e1000 driver to the upstream e1000e driver. Signed-off-by: Bill Hayes <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c |4 drivers/net/e1000e/lib.c | 39 +-- drivers/net/e1000e/hw.h

Re: [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address

2007-10-23 Thread Alexey Kuznetsov
Hello! > When GRE tunnel is in NBMA mode, this patch allows an application to use > a PF_PACKET socket to: > - send a packet to specific NBMA address with sendto() > - use recvfrom() to receive packet and check which NBMA address it came from > > This is required to implement properly NHRP over G

[PATCH] UDP: Make use of inet_iif() when doing socket lookups.

2007-10-23 Thread Vlad Yasevich
UDP currently uses skb->dev->ifindex which may provide the wrong information when the socket bound to a specific interface. This patch makes inet_iif() accessible to UDP and makes UDP use it. The scenario we are trying to fix is when a client is running on the same system and the server and both c

[PATCH] USB: net: Fix asix read transfer buffer allocations.

2007-10-23 Thread Valentine Barshak
On systems with noncoherent cache, allocating dma buffers on the stack for USB IN transfers causes kernel crash, because usb map_urb_for_dma() code calls dma_map_single(), that invalidates data cache for DMA_FROM_DEVICE transfer direction and causes stack data loss if transfer size is less than cac

Re: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer allocations.

2007-10-23 Thread Valentine Barshak
Ingo Oeser wrote: Valentine Barshak schrieb: Oliver Neukum wrote: Am Montag 22 Oktober 2007 schrieb Valentine Barshak: static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc) { struct usbnet *dev = netdev_priv(netdev); + void *buf; u16 res; m

Re: [PATCH][MIPS] AR7 ethernet

2007-10-23 Thread Matteo Croce
Il Monday 15 October 2007 20:24:21 Jeff Garzik ha scritto: > applied Small update to the driver, please apply Signed-off-by: Matteo Croce <[EMAIL PROTECTED]> Signed-off-by: Eugene Konev <[EMAIL PROTECTED]> Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]> diff --git a/drivers/net/cpmac.c b/driver

Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-23 Thread Scott Wood
On Mon, Oct 22, 2007 at 06:47:32AM -0700, Medve Emilian-EMMEDVE1 wrote: > Are you suggesting we leave those warnings there until somebody decides > to fix all the portability issues of this driver? My patch is a small > and insignificant improvement and not the revolution you're asking for, > but i

Re: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer allocations.

2007-10-23 Thread Ingo Oeser
Valentine Barshak schrieb: > Oliver Neukum wrote: > > Am Montag 22 Oktober 2007 schrieb Valentine Barshak: > >> static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc) > >> { > >> struct usbnet *dev = netdev_priv(netdev); > >> + void *buf; > >> u16 res; > >

[VLAN]: MAINTAINERS update

2007-10-23 Thread Patrick McHardy
[VLAN]: MAINTAINERS update Ben stepped down from VLAN maintainership due to a lack of time, add myself as new maintainer. Cc: Ben Greear <[EMAIL PROTECTED]> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 1fd6d02..0ad7447 100644 --- a/MAINTAINERS

[PATCH] Cleanup the IPv6 addresses printing in /proc files

2007-10-23 Thread Pavel Emelyanov
The /proc/net udp6, tcp6 and raw6 files print the IPs of the connection ends. Make a NIP6Lxxx macros (L stands for "long") for making the printing code look nicer. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 94bc996..5

Re: [PATCH] fix ACK processing after netlink_dump_start

2007-10-23 Thread Thomas Graf
* Denis V. Lunev <[EMAIL PROTECTED]> 2007-10-23 18:40 > Revert to original netlink behavior. Do not reply with ACK if the > netlink dump has bees successfully started. > > libnl has been broken by the cd40b7d3983c708aabe3d3008ec64ffce56d33b0 > The following command reproduce the problem: >/nl-

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-23 Thread Josh Boyer
On Tue, 23 Oct 2007 11:13:48 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Oct 23, 2007, at 10:20 AM, Josh Boyer wrote: > > > On Mon, 15 Oct 2007 14:27:23 -0400 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> Valentine Barshak wrote: > >>> This patch adds BCM5248 and Marvell 88E PHY

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-23 Thread Kumar Gala
On Oct 23, 2007, at 10:20 AM, Josh Boyer wrote: On Mon, 15 Oct 2007 14:27:23 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Valentine Barshak wrote: This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is

Re: [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address

2007-10-23 Thread Patrick McHardy
Timo Teräs wrote: When GRE tunnel is in NBMA mode, this patch allows an application to use a PF_PACKET socket to: - send a packet to specific NBMA address with sendto() - use recvfrom() to receive packet and check which NBMA address it came from This is required to implement properly NHRP over

[PATCH 10/11] [IPSEC]: Move flow construction into xfrm_dst_lookup

2007-10-23 Thread Herbert Xu
[IPSEC]: Move flow construction into xfrm_dst_lookup This patch moves the flow construction from the callers of xfrm_dst_lookup into that function. It also changes xfrm_dst_lookup so that it takes an xfrm state as its argument instead of explicit addresses. This removes any address-specific logi

[PATCH 9/11] [IPSEC]: Replace x->type->{local,remote}_addr with flags

2007-10-23 Thread Herbert Xu
[IPSEC]: Replace x->type->{local,remote}_addr with flags The functions local_addr and remote_addr are more than what they're needed for. The same thing can be done easily with flags on the type object. This patch does that and simplifies the wrapper functions in xfrm6_policy accordingly. Signed-

[PATCH 11/11] [IPSEC]: Merge common code into xfrm_bundle_create

2007-10-23 Thread Herbert Xu
[IPSEC]: Merge common code into xfrm_bundle_create Half of the code in xfrm4_bundle_create and xfrm6_bundle_create are common. This patch extracts that logic and puts it into xfrm_bundle_create. The rest of it are then accessed through afinfo. As a result this fixes the problem with inter-family

[PATCH 7/11] [IPSEC]: Set dst->input to dst_discard

2007-10-23 Thread Herbert Xu
[IPSEC]: Set dst->input to dst_discard The input function should never be invoked on IPsec dst objects. This is because we don't apply IPsec on input until after we've made the routing decision. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- net/ipv4/xfrm4_policy.c |3 ++- net/ipv6/xfrm

[PATCH 8/11] [IPSEC]: Make sure idev is consistent with dev in xfrm_dst

2007-10-23 Thread Herbert Xu
[IPSEC]: Make sure idev is consistent with dev in xfrm_dst Previously we took the device from the bottom route and idev from the top route. This is bad because idev may well point to a different device. This patch changes it so that we get the idev from the device directly. It also makes it an e

[PATCH 5/11] [NET]: Remove unnecessary inclusion of dst.h

2007-10-23 Thread Herbert Xu
[NET]: Remove unnecessary inclusion of dst.h The file net/netevent.h only refers to struct dst_entry * so it doesn't need to include dst.h. I've replaced it with a forward declaration. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- include/net/netevent.h |2 +- 1 files changed, 1 insert

[PATCH 6/11] [IPSEC]: Only set neighbour on top xfrm dst

2007-10-23 Thread Herbert Xu
[IPSEC]: Only set neighbour on top xfrm dst The neighbour field is only used by dst_confirm which only ever happens on the top-most xfrm dst. So it's a waste to duplicate for every other xfrm dst. This patch moves its setting out of the loop so that only the top one gets set. Signed-off-by: Her

[PATCH 4/11] [NET]: Eliminate duplicate copies of dst_discard

2007-10-23 Thread Herbert Xu
[NET]: Eliminate duplicate copies of dst_discard We have a number of copies of dst_discard scattered around the place which all do the same thing, namely free a packet on the input or output paths. This patch deletes all of them except dst_discard and points all the users to it. The only non-tri

[PATCH 2/11] [IPSEC]: Use dst->header_len when resizing on output

2007-10-23 Thread Herbert Xu
[IPSEC]: Use dst->header_len when resizing on output Currently we use x->props.header_len when resizing on output. However, if we're resizing at all we might as well go the whole hog and do it for the whole dst. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- net/xfrm/xfrm_output.c |3 ++

[PATCH 3/11] [IPV6]: Move nfheader_len into rt6_info

2007-10-23 Thread Herbert Xu
[IPV6]: Move nfheader_len into rt6_info The dst member nfheader_len is only used by IPv6. It's also currently creating a rather ugly alignment hole in struct dst. Therefore this patch moves it from there into struct rt6_info. It also reorders the fields in rt6_info to minimize holes. Signed-of

[0/11] Merge bundle creation and other misc fixes/clean-ups

2007-10-23 Thread Herbert Xu
Hi Dave: This series of patches fixes the bug where the bundle creation code treats IPv6 routes as IPv4 or vice versa. I think this is suitable for 2.6.25. They do fix bugs but I don't think any of them are serious enough for inclusion in 2.6.24. Cheers, -- Visit Openswan at http://www.openswa

  1   2   >