Re: [PATCH] smc91x Hitachi Solution Engine (SuperH) Support

2007-09-28 Thread Paul Mundt
On Sat, Sep 29, 2007 at 01:29:25AM -0400, Jeff Garzik wrote: > Nobuhiro Iwamatsu wrote: > >This patch supports Hitachi Solution Engine (SuperH) of smc91x. > >Please apply this patch . > > >diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h > >index 6ff3a16..af9e6bf 100644 > >--- a/drivers/n

Re: [PATCH] smc911x irq sense request and MPR2 board support

2007-09-28 Thread Paul Mundt
On Sat, Sep 29, 2007 at 01:24:47AM -0400, Jeff Garzik wrote: > Markus Brunner wrote: > >this are the changes to the smc911x driver, which were necessary > >to get it running on the Magic Panel R2 (smsc9115). > >It is a SH3-DSP based board. The other patches are available on > >the linuxsh-dev mail

[git patch] net driver fix

2007-09-28 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/mv643xx_eth.c |2 +- drivers/net/mv643xx_eth.h |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) Dale Far

Re: [RFC/PATCH 0/3] UDP memory usage accounting

2007-09-28 Thread Herbert Xu
On Fri, Sep 28, 2007 at 09:47:37PM -0700, David Miller wrote: > > There are two things we (might) need to guard against, one local and > one remote. Right I was focusing on the local threat. > If you do a per-user limit, apache would basically just stop at that > redzone point. In some sense mak

Re: [patch 08/17] sky2: avoid divide in receive path

2007-09-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Avoid divide (modulus) in receive buffer handling path. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/sky2.c |3 ++- 1 file changed, 2 insertions(+)

Re: [PATCH] PHYLIB: Spinlock fixes for softirqs

2007-09-28 Thread Andrew Morton
On Sat, 29 Sep 2007 01:31:52 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > doesn't Andrew have a version of these patches that move the useful > patch text into the area where it will get copied into the permanent > kernel changelog? > > also, your PHYLIB patches give no notion at all of prope

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-28 Thread Jeff Garzik
Overall, looks pretty clean, good job! Comments: 1) [major issue] Don't take and release a heavy lock on every single RX packet. 2) remove net_device_stats from private structure, and use net_device::stats 3) rx_ring_size should not be a module param, since that should be supported via etht

Re: [PATCH] PHYLIB: Spinlock fixes for softirqs

2007-09-28 Thread Jeff Garzik
doesn't Andrew have a version of these patches that move the useful patch text into the area where it will get copied into the permanent kernel changelog? also, your PHYLIB patches give no notion at all of proper patch order. - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH] smc91x Hitachi Solution Engine (SuperH) Support

2007-09-28 Thread Jeff Garzik
Nobuhiro Iwamatsu wrote: Hi, all. This patch supports Hitachi Solution Engine (SuperH) of smc91x. Please apply this patch . diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h index 6ff3a16..af9e6bf 100644 --- a/drivers/net/smc91x.h +++ b/drivers/net/smc91x.h @@ -284,6 +284,7 @@ SMC_out

Re: [PATCH] via-velocity: more cleanup

2007-09-28 Thread Jeff Garzik
Stephen Hemminger wrote: Per Al's suggestion, get rid of the stupid stuff: Remove cam_type switch, And deinline things that aren't important for speed. And make big macro and inline. And remove some dead/unused code. And use const char * for chip name. Signed-off-by: Stephen Hemminger <[EMAIL PR

Re: [PATCH] smc911x irq sense request and MPR2 board support

2007-09-28 Thread Jeff Garzik
Markus Brunner wrote: Hi, this are the changes to the smc911x driver, which were necessary to get it running on the Magic Panel R2 (smsc9115). It is a SH3-DSP based board. The other patches are available on the linuxsh-dev mailinglist. http://marc.info/?l=linuxsh-dev&r=1&b=200708&w=2 It was n

Re: [PATCH 1/9] fs_enet: Whitespace cleanup.

2007-09-28 Thread Jeff Garzik
Scott Wood wrote: Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet/mac-fcc.c |1 - drivers/net/fs_enet/mii-bitbang.c |3 - drivers/net/f

Re: [RFC/PATCH 0/3] UDP memory usage accounting

2007-09-28 Thread Herbert Xu
On Fri, Sep 28, 2007 at 09:51:59PM -0700, David Miller wrote: > > There is a per-socket send buffer limit, and there is a per-user open > file descriptor limit. Multiply the two to determine how much system > memory the user can consume using sockets. We do have these limits but they're per-proc

Re: [PATCH 3/9] fs_enet: Don't share the interrupt.

2007-09-28 Thread Jeff Garzik
Scott Wood wrote: This driver can't handle an interrupt immediately after request_irq You MUST assume that you will receive an interrupt immediately after request_irq(). If fs_enet cannot handle that, then that is what wants fixing. Please send along a fix for this, rather than band-aiding

Re: [PATCH] sb1250-mac: Driver model & phylib update

2007-09-28 Thread Jeff Garzik
Maciej W. Rozycki wrote: A driver model and phylib update. It includes the following changes: 1. Removal of unused module options. 2. Phylib support and the resulting removal of generic bits for handling the PHY. 3. Proper reserving of device resources and using ioremap()ped handles to

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-28 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Thu, 20 Sep 2007, Jeff Garzik wrote: Remove the "linux-" prefix. Hmm, it looks like a b

Re: [patch 02/18] sundance: PHY address form 0, only for device ID 0x0200 (IP100A) (20070605)

2007-09-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Jesse Huang <[EMAIL PROTECTED]> Search PHY address form 0, only for device ID 0x0200 (IP100A). Other device are from PHY address 1. Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

Re: [RFC/PATCH 0/3] UDP memory usage accounting

2007-09-28 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Fri, 28 Sep 2007 21:47:37 -0700 (PDT) > Per-user limits are not necessarily the answer. Seeing myself say this reminds me that it seems to have been missed in all of this that we do have a limit per user already. There is a per-socket send buffer limi

Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver

2007-09-28 Thread Jeff Garzik
Zang Roy-r61911 wrote: From: Roy Zang <[EMAIL PROTECTED]> Clean up redundant PHY write line for ULi526x Ethernet Driver. Signed-off-by: Roy Zang <[EMAIL PROTECTED]> --- drivers/net/tulip/uli526x.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) applied - To unsubscribe from this

Re: [PATCH] e1000e: Do not allow requeue of freed skb

2007-09-28 Thread Jeff Garzik
Auke Kok wrote: From: Krishna Kumar <[EMAIL PROTECTED]> Returning BUSY will make qdisc_restart enqueue the skb which was already freed. The bad skb was correctly freed and we should return NETDEV_TX_OK. First spotted by Jeff Garzik on 08/13/07. Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>

Re: [PATCH] [3/6] pasemi_mac: set interface speed correctly on XAUI ports

2007-09-28 Thread Jeff Garzik
Olof Johansson wrote: pasemi_mac: set interface speed correctly on XAUI ports Set interface speed for XAUI to 10G per default, not 1G. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 3-6 (davem already got 1-2) - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] mv643xx_eth: Check ETH_INT_CAUSE_STATE bit

2007-09-28 Thread Jeff Garzik
Dale Farnsworth wrote: Commit 468d09f8946d40228c56de26fe4874b2f98067ed masked the "state" interrupt (bit 20 of the cause register). This results in Radstone's PPC7D repeatedly re-entering the interrupt routine, locking up the board. The following patch returns the required handling for this inter

Re: [RFC/PATCH 0/3] UDP memory usage accounting

2007-09-28 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 29 Sep 2007 11:21:05 +0800 > Satoshi OSHIMA <[EMAIL PROTECTED]> wrote: > > > > In such case, from 300 to 500MB memory consumption will > > be fatal. Users can easily open 1000 sockets per process > > under default ulimit. If such sockets hold message

Re: [PATCH] rtnl: Simplify ASSERT_RTNL

2007-09-28 Thread Herbert Xu
Eric W. Biederman <[EMAIL PROTECTED]> wrote: > > Currently we have the call path: > macvlan_open -> dev_unicast_add -> __dev_set_rx_mode -> >__dev_set_promiscuity -> ASSERT_RTNL -> mutex_trylock > > When mutex debugging is on taking a mutex complains if we are not > allowed to sleep. At

Re: [PKT_SCHED]: Add stateless NAT

2007-09-28 Thread Herbert Xu
Herbert Xu <[EMAIL PROTECTED]> wrote: > On Fri, Sep 28, 2007 at 06:55:32PM +0200, Patrick McHardy wrote: >> >> Looking at ip_input.o as example (everything without forced inlining): >> >>textdata bss dec hex filename >>2076 8 02084 824 net/ipv4/ip_input.

Re: [RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-28 Thread Herbert Xu
Satoshi OSHIMA <[EMAIL PROTECTED]> wrote: > > I understand what you pointed out. But I think the accounting > method I'm proposing is very similar to TCP accounting and per > socket accounting. > How do you think of it? I think allowing Joe user to stop root from using TCP or UDP isn't much better

Re: [RFC/PATCH 0/3] UDP memory usage accounting

2007-09-28 Thread Herbert Xu
Satoshi OSHIMA <[EMAIL PROTECTED]> wrote: > > In such case, from 300 to 500MB memory consumption will > be fatal. Users can easily open 1000 sockets per process > under default ulimit. If such sockets hold messages but > user processes don't receive it. Almost all slab will > be occupied by sk_buff

Re: MSI interrupts and disable_irq

2007-09-28 Thread Stephen Hemminger
On Fri, 28 Sep 2007 22:47:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Ayaz Abdulla wrote: > > I am trying to track down a forcedeth driver issue described by bug 9047 > > in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load). > > I added a patch to synchronize the timer ha

Re: MSI interrupts and disable_irq

2007-09-28 Thread Jeff Garzik
Ayaz Abdulla wrote: I am trying to track down a forcedeth driver issue described by bug 9047 in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load). I added a patch to synchronize the timer handlers so that one handler doesn't accidently enable the IRQ while another timer handle

[PATCH 5/5] net: Make AF_UNIX per network namespace safe.

2007-09-28 Thread Eric W. Biederman
Because of the global nature of garbage collection, and because of the cost of per namespace hash tables unix_socket_table has been kept global. With a filter added on lookups so we don't see sockets from the wrong namespace. Currently I don't fold the namesapce into the hash so multiple namespa

[PATCH 4/5] net: Make AF_PACKET handle multiple network namespaces

2007-09-28 Thread Eric W. Biederman
This is done by making packet_sklist_lock and packet_sklist per network namespace and adding an additional filter condition on received packets to ensure they came from the proper network namespace. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/net/net_namespace.h |4 + ne

[PATCH 3/5] net: Make the netlink methods in rtnetlink handle multiple network namespaces

2007-09-28 Thread Eric W. Biederman
After the previous prep work this just consists of removing checks limiting the code to work in the initial network namespace, and updating rtmsg_ifinfo so we can generate events for devices in something other then the initial network namespace. Referring to network other network devices like the

Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address

2007-09-28 Thread YOSHIFUJI Hideaki / 吉藤英明
Dave, Brian, Let me double check this patch. Regards, --yoshfuji In article <[EMAIL PROTECTED]> (at Fri, 28 Sep 2007 17:50:38 -0700), David Stevens <[EMAIL PROTECTED]> says: > Brian, > A multicast address should never be the target of a neighbor > discovery request; the sender should

[PATCH 2/5] net: Make rtnetlink infrastructure network namespace aware

2007-09-28 Thread Eric W. Biederman
After this patch none of the netlink callback support anything except the initial network namespace but the rtnetlink infrastructure now handles multiple network namespaces. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/rtnetlink.h |8 ++-- include/net/net_namespac

[PATCH 1/5] net: Modify all rtnetlink methods to only work in the initial namespace

2007-09-28 Thread Eric W. Biederman
Before I can enable rtnetlink to work in all network namespaces I need to be certain that something won't break. So this patch deliberately disables all of the rtnletlink methods in everything except the initial network namespace. After the methods have been audited this extra check can be disab

[PATCH] rtnl: Simplify ASSERT_RTNL

2007-09-28 Thread Eric W. Biederman
Currently we have the call path: macvlan_open -> dev_unicast_add -> __dev_set_rx_mode -> __dev_set_promiscuity -> ASSERT_RTNL -> mutex_trylock When mutex debugging is on taking a mutex complains if we are not allowed to sleep. At that point we have called netif_tx_lock_bh so we are clear

delayed acks question

2007-09-28 Thread Andrea Arcangeli
Hello, I've a few questions about ICSK_ACK_PUSHED2. PUSHED2 is only meant to force the ack out immediately when pingpong is set to 1, but then if pingpong is 1 the delayed acks shouldn't be deferred anyway. However I think the trouble is that there's a race condition in reading pingpong, pingpong

Re: [PKT_SCHED]: Add stateless NAT

2007-09-28 Thread Herbert Xu
On Fri, Sep 28, 2007 at 06:55:32PM +0200, Patrick McHardy wrote: > > Looking at ip_input.o as example (everything without forced inlining): > >textdata bss dec hex filename >2076 8 02084 824 net/ipv4/ip_input.o >3483 8 03491 da3 n

Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address

2007-09-28 Thread David Stevens
Brian, A multicast address should never be the target of a neighbor discovery request; the sender should use the mapping function for all multicasts. So, I'm not sure that your example can ever happen, and it certainly is ok to send ICMPv6 errors to multicast addresses in general. But I don

Re: Null dereference in socket.c

2007-09-28 Thread Stephen Hemminger
On Fri, 28 Sep 2007 16:00:57 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Chuck Ebbert <[EMAIL PROTECTED]> > Date: Fri, 28 Sep 2007 18:58:36 -0400 > > > After debugging an oops > > (https://bugzilla.redhat.com/attachment.cgi?id=209231) > > I find it happens here in socket.c::sock_

Re: [PATCH] Update get_net_ns_by_pid

2007-09-28 Thread Serge E. Hallyn
Quoting Eric W. Biederman ([EMAIL PROTECTED]): > > In the -mm tree the rules for access an nsproxy have changed, > and in get_net_ns_by_pid we access the nsproxy, so update > it to follow the new rules. > > Signed-off-by: "Eric W. Biederman" <[EMAIL PROTECTED]> Yup, looks right. I assume Pavel'

Re: Null dereference in socket.c

2007-09-28 Thread David Miller
From: Chuck Ebbert <[EMAIL PROTECTED]> Date: Fri, 28 Sep 2007 18:58:36 -0400 > After debugging an oops (https://bugzilla.redhat.com/attachment.cgi?id=209231) > I find it happens here in socket.c::sock_ioctl() line 902: > >default: > => err = sock->ops->ioctl(s

Null dereference in socket.c

2007-09-28 Thread Chuck Ebbert
After debugging an oops (https://bugzilla.redhat.com/attachment.cgi?id=209231) I find it happens here in socket.c::sock_ioctl() line 902: default: => err = sock->ops->ioctl(sock, cmd, arg); /* * If this ioctl is

Re: sfq (iproute2 patches)

2007-09-28 Thread Corey Hickey
Corey Hickey wrote: These patches follow the ESFQ-->SFQ kernel patches. See the kernel patch summary for general information. Dang, I forgot to set the subject; these are the iproute2 patches. -Corey - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

Re: bind and O_NONBLOCK

2007-09-28 Thread David Miller
From: Ulrich Drepper <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 22:59:53 -0700 > It would be ideal if we'd have such an implementation in the next few > months so that we, in theory, can check whether the text in the > specification makes sense. It seems this functionality is only relevant for re

[PATCH 2/3] Change perturb_period to unsigned.

2007-09-28 Thread Corey Hickey
This corresponds to the kernel patch doing the same. Here, too, this will technically break binary compatibility with older kernels, but that shouldn't be a problem because negative perturb_period values aren't usable anyway. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- include/linux/pkt_

[PATCH 3/3] Use nested compat attributes for passing parameters to the kernel.

2007-09-28 Thread Corey Hickey
Note that I have left sfq_print_opt() alone. At this point, there can be no difference between the data in the nested rtattrs and the data in the compat rtattr, and I didn't want to add clutter that isn't useful. Let me know if I should do differently. Signed-off-by: Corey Hickey <[EMAIL PROTECTED

sfq

2007-09-28 Thread Corey Hickey
These patches follow the ESFQ-->SFQ kernel patches. See the kernel patch summary for general information. Thanks, Corey include/linux/pkt_sched.h | 23 ++- tc/q_sfq.c| 43 ++- 2 files changed, 52 insertions(+), 14

[PATCH 1/3] SFQ: Support changing depth and divisor.

2007-09-28 Thread Corey Hickey
This can safely be applied either before or after the kernel patches because the tc_sfq_qopt struct is unchanged: - old kernels will ignore the parameters from new iproute2 - new kernels will use the same default parameters Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- include/linux/pkt_sc

[PATCH 10/10] Use nested compat attributes to pass parameters.

2007-09-28 Thread Corey Hickey
This fixes the ambiguity between, for example: tc qdisc change ... perturb 0 tc qdisc change ... Without this patch, there is no way for SFQ to differentiate between a parameter specified to be 0 and a parameter that was omitted. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- include/linux/

[PATCH 05/10] Add divisor.

2007-09-28 Thread Corey Hickey
Make hash divisor user-configurable. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c index 34a299d..d72ea7c 100644 --- a/net/sched/sch_sfq.c

[PATCH 09/10] Change perturb_period to unsigned.

2007-09-28 Thread Corey Hickey
perturb_period is currently a signed integer, but I can't see any good reason why this is so--a negative perturbation period will add a timer that expires in the past, causing constant perturbation, which makes hashing useless. if (q->perturb_period) { q->perturb_timer.expi

[PATCH 08/10] Multiply perturb_period by HZ when used rather than when assigned.

2007-09-28 Thread Corey Hickey
perturb_period is the only parameter that doesn't match 1:1 with the value from userspace. This change makes it easy and clean to use a small macro for setting parameters (in a subsequent patch). Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 10 +- 1 files ch

[PATCH 07/10] Remove comments about hardcoded values.

2007-09-28 Thread Corey Hickey
None of these are true anymore (hooray!). Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- include/linux/pkt_sched.h |8 net/sched/sch_sfq.c | 17 +++-- 2 files changed, 3 insertions(+), 22 deletions(-) diff --git a/include/linux/pkt_sched.h b/include/linux/pk

[PATCH 06/10] Make qdisc changeable.

2007-09-28 Thread Corey Hickey
Re-implement sfq_change() and enable Qdisc_opts.change so "tc qdisc change" will work. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 61 ++- 1 files changed, 60 insertions(+), 1 deletions(-) diff --git a/net/sched/sch_

[PATCH 04/10] Make "depth" (number of queues) user-configurable:

2007-09-28 Thread Corey Hickey
* replace #define with a parameter * use old hardcoded value as a default * kcalloc() arrays in sfq_q_init() * free() arrays in sfq_q_destroy() Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 85 +++--- 1 files changed, 59 in

[PATCH 02/10] Preparatory refactoring part 2.

2007-09-28 Thread Corey Hickey
Factor code out of sfq_init() and sfq_destroy(), again so that the new functions can be used by sfq_change() later. Actually, as the diff itself shows, most of the sfq_q_init() code comes from the original sfq_change(), but sfq_change() is only called by sfq_init() right now. Thus, it is safe to r

[PATCH 03/10] Move two functions.

2007-09-28 Thread Corey Hickey
Move sfq_q_destroy() to above sfq_q_init() so that it can be used by an error case in a later patch. Move sfq_destroy() as well, for clarity. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-)

[PATCH 01/10] Preparatory refactoring part 1.

2007-09-28 Thread Corey Hickey
Make a new function sfq_q_enqueue() that operates directly on the queue data. This will be useful for implementing sfq_change() in a later patch. A pleasant side-effect is reducing most of the duplicate code in sfq_enqueue() and sfq_requeue(). Similarly, make a new function sfq_q_dequeue(). Signe

SFQ: backport some features from ESFQ (try 4)

2007-09-28 Thread Corey Hickey
Patchset try 2 addresses the review by Michael Buesch. Patchset try 3 addresses the review by Patrick McHardy. Patchset try 4 has a few cosmetic improvements. Nobody reviewed my last set of patches, and I wasn't pushy about asking. Since it's been a while, I ported the kernel and userspace patchs

Re: [RFC] Make TCP prequeue configurable

2007-09-28 Thread David Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Thu, 27 Sep 2007 22:26:02 -0400 > I think it really does help in case (4) with old NICs that don't do rx > checksumming. I'm not sure how many people really care about this > anymore, but probably some...? > > OTOH, it would be nice to get rid of sy

Re: [PATCH] IPoIB: Convert to netdevice internal stats

2007-09-28 Thread Roland Dreier
> How is that ibm_emac NAPI conversion coming along? :-) Sorry, trying to reduce my backlog first, but it is still on my list of things to work on :) - R. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [PATCH] IPoIB: Convert to netdevice internal stats

2007-09-28 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Fri, 28 Sep 2007 15:18:01 -0700 > Use the stats member of struct netdevice in IPoIB, so we can save > memory by deleting the stats member of struct ipoib_dev_priv, and save > code by deleting ipoib_get_stats(). > > Signed-off-by: Roland Dreier <[EMAIL

[PATCH] IPoIB: Convert to netdevice internal stats

2007-09-28 Thread Roland Dreier
Use the stats member of struct netdevice in IPoIB, so we can save memory by deleting the stats member of struct ipoib_dev_priv, and save code by deleting ipoib_get_stats(). Signed-off-by: Roland Dreier <[EMAIL PROTECTED]> --- Dave, can you queue this in net-2.6.24 please? I would ordinarily merge

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support"iwarp-only"interfacesto avoid 4-tuple conflicts.

2007-09-28 Thread Sean Hefty
Kanevsky, Arkady wrote: Exactly, it forces the burden on administrator. And one will be forced to try one mount for iWARP and it does not work issue another one TCP or UDP if it fails. Yack! And server will need to listen on different IP address and simple * will not work since it will need to l

Re: error(s) in 2.6.23-rc5 bonding.txt ?

2007-09-28 Thread Rick Jones
Well, I managed to concoct an updated test, this time with 1G's going into a 10G. A 2.6.23-rc8 kernel on the system with four, dual-port 82546GB's, connected to an HP ProCurve 3500 series switch with a 10G link to a system running 2.6.18-8.el5 (I was having difficulty getting cxgb3 going on my

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support"iwarp-only"interfacesto avoid 4-tuple conflicts.

2007-09-28 Thread Steve Wise
Kanevsky, Arkady wrote: Exactly, it forces the burden on administrator. And one will be forced to try one mount for iWARP and it does not work issue another one TCP or UDP if it fails. Yack! I see your point. I have no defense. My hands have been tied on fixing this properly... And serv

RE: [ofa-general] [PATCH v3] iw_cxgb3: Support"iwarp-only"interfacesto avoid 4-tuple conflicts.

2007-09-28 Thread Kanevsky, Arkady
Exactly, it forces the burden on administrator. And one will be forced to try one mount for iWARP and it does not work issue another one TCP or UDP if it fails. Yack! And server will need to listen on different IP address and simple * will not work since it will need to listen in two different dom

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-28 Thread Thomas Gleixner
On Fri, 2007-09-28 at 13:20 -0700, David Miller wrote: > That's not true with CAN. > > With this CAN stuff, any driver you write for it is intimately > integrated into the design and architecture of the CAN subsystem. Any > such driver cannot stand on it's own. Look at how these drivers can > ge

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-28 Thread David Miller
From: Thomas Gleixner <[EMAIL PROTECTED]> Date: Fri, 28 Sep 2007 18:27:19 +0200 > I'm not inclined either way and we really should not make this a > religious question whether that code goes in or not, especially not when > we granted the mac80211 to export everything w/o _GPL suffix not too > lon

Re: [RFC/PATCH 1/3] UDP memory usage accounting (take 2): fix send buffer check

2007-09-28 Thread David Miller
From: Satoshi OSHIMA <[EMAIL PROTECTED]> Date: Fri, 28 Sep 2007 22:37:54 +0900 > } else if (i < MAX_SKB_FRAGS) { > > +if (atomic_read(&sk->sk_wmem_alloc) + PAGE_SIZE > > +> 2 * sk->sk_sndbuf) { > > +err = -ENOBUFS; > > +

2.6.23-rc[68]-mm: network hangs

2007-09-28 Thread Laurent Riffard
Hi, >From time to time, I experience some complete network hangs: Suddenly, all network connections become unresponsive. Even "ping 127.0.0.1" doesn't work. SysRq-w does not show any blocked processus. When such hang happen, I have to reboot (shutdown does work). This is not easily reproducible

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support"iwarp-only"interfacesto avoid 4-tuple conflicts.

2007-09-28 Thread Steve Wise
Kanevsky, Arkady wrote: Sean, IB aside, it looks like an ULP which is capable of being both RDMA aware and RDMA not-aware, like iSER and iSCSI, NFS-RDMA and NFS, SDP and sockets, will be treated as two separete ULPs. Each has its own IP address, since there is a different IP address for iWARP

Re: [stable] [PATCH 2/3] sky2: fix VLAN receive processing

2007-09-28 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > I left it out on purpose because 2.6.22 doesn't support Yukon EX. OK, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

Re: [stable] [PATCH 2/3] sky2: fix VLAN receive processing

2007-09-28 Thread Stephen Hemminger
On Fri, 28 Sep 2007 12:20:44 -0700 Chris Wright <[EMAIL PROTECTED]> wrote: > * Stephen Hemminger ([EMAIL PROTECTED]) wrote: > > The length check for truncated frames was not correctly handling > > the case where VLAN acceleration had already read the tag. > > Also, the Yukon EX has some features t

Re: [stable] [PATCH 2/3] sky2: fix VLAN receive processing

2007-09-28 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > The length check for truncated frames was not correctly handling > the case where VLAN acceleration had already read the tag. > Also, the Yukon EX has some features that use high bit of status > as security tag. Did you leave out the GMR_FS_LEN chan

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-28 Thread Ilpo Järvinen
On Fri, 28 Sep 2007, Cedric Le Goater wrote: > Hello ! > > Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ > > I just found that warning in my logs. It seems that it's been > happening since rc7-mm1 at least. > > Thanks ! > >

Re: [PATCH 2/3] sky2: fix VLAN receive processing

2007-09-28 Thread Krzysztof Oledzki
On Fri, 28 Sep 2007, Stephen Hemminger wrote: The length check for truncated frames was not correctly handling the case where VLAN acceleration had already read the tag. Also, the Yukon EX has some features that use high bit of status as security tag. Thank you. Best regards

Re: [PATCH] sb1250-mac: Driver model & phylib update

2007-09-28 Thread Andrew Morton
On Fri, 28 Sep 2007 17:23:00 +0100 (BST) "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > On Mon, 24 Sep 2007, Andrew Morton wrote: > > > > Well, this is against Jeff's netdev-2.6 tree which hopefully is not as > > > crufty as Linus's old mainline; if it is not possible to queue this > > > ch

Re: [stable] Upgrading 2.6.21.7->2.6.22.9 kills my network (sky2): sky2 eth0: rx error, status 0x402300 length 60

2007-09-28 Thread Krzysztof Oledzki
On Fri, 28 Sep 2007, Greg KH wrote: On Fri, Sep 28, 2007 at 01:11:27PM +0200, Krzysztof Oledzki wrote: On Fri, 28 Sep 2007, Krzysztof Oledzki wrote: On Fri, 28 Sep 2007, Krzysztof Oledzki wrote: Hello, After upgrading my kernel from 2.6.21.7 to 2.6.22.9 my 88E8053 no longer works: S

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-28 Thread Oliver Hartkopp
Eric W. Biederman wrote: > Oliver Hartkopp <[EMAIL PROTECTED]> writes: > >> The CAN protocol family is some kind of a closed ecosystem with a >> complete different addressing scheme that uses the bare networking >> functionality of the Linux Kernel as well as DECNET or ARCNET. You would >> nev

[RFC/PATCH 0/3] UDP memory usage accounting(take 2)

2007-09-28 Thread Satoshi OSHIMA
This patch set try to introduce memory usage accounting for UDP(currently ipv4 only). 3 points are improved along with some feedback. (a) to improve scalability, avoiding atomic_*()s as small as possible (b) avoiding UDP specific code in IP layer (c) supporting socket destruction accou

Re: [PATCH]: Second preliminary release of Sun Neptune driver

2007-09-28 Thread Matheos Worku
David Miller wrote: Ok, this is rev2, changes: 1) Jumbo MTU support is now present. I got stuck on this for a while because I didn't realize that resetting the RX XMAC would reset the XMAC_MAX register. I thought that was a TX XMAC resource, ho hum... Fix this by re-initializing t

Re: 2.6.23-rc8: cannot make netconsole work

2007-09-28 Thread Andrey Borzenkov
On Friday 28 September 2007, Matt Mackall wrote: > On Fri, Sep 28, 2007 at 01:27:55PM +0400, Andrey Borzenkov wrote: [...] > > sudo modprobe netconsole netconsole=@/eth0,@/ > > [...] > What is your console log level set to? If the messages don't come out > on the local console, they won't get sent

MSI interrupts and disable_irq

2007-09-28 Thread Ayaz Abdulla
I am trying to track down a forcedeth driver issue described by bug 9047 in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load). I added a patch to synchronize the timer handlers so that one handler doesn't accidently enable the IRQ while another timer handler is running (see at

Re: UDP Out 0f Sequence

2007-09-28 Thread Randy Macleod
Rick Jones wrote: Majumder, Rajib wrote: Let's say we have 2 uniprocessor hosts connected back to back. Is there any possibility of an out-of-order scenario on recv? Your application should be written on the assumption that it is possible, regardless of the specifics of the hosts involved, h

Re: e1000 tcp checksum incorrect, x86 64b

2007-09-28 Thread Jon Smirl
On 9/28/07, Rick Jones <[EMAIL PROTECTED]> wrote: > Herbert Xu wrote: > > Jon Smirl <[EMAIL PROTECTED]> wrote: > > > >>App is writing seven bytes to the socket. Socket write timeout expires > >>and the seven bytes are sent. The checksum is not getting inserted > >>into the packet. It is set to a co

Re: /proc/net/ bad hard links count [Was: 2.6.23-rc8-mm2]

2007-09-28 Thread Eric W. Biederman
Jiri Slaby <[EMAIL PROTECTED]> writes: > On 09/27/2007 11:22 AM, Andrew Morton wrote: >> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ Yep. > # find /proc >/dev/null > find: WARNING: Hard link count is wrong for /proc/net: this may be a bug in > your

Re: [PKT_SCHED]: Add stateless NAT

2007-09-28 Thread Patrick McHardy
David Miller wrote: > From: jamal <[EMAIL PROTECTED]> > Date: Thu, 27 Sep 2007 08:39:45 -0400 > >>>+config NET_ACT_NAT >>>+tristate "Stateless NAT" >>>+depends on NET_CLS_ACT >>>+select NETFILTER >> >>I am gonna have to agree with Evgeniy on this Herbert;-> >>The rewards ar

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-28 Thread Eric W. Biederman
Oliver Hartkopp <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> >> Currently IFF_LOOPBACK set in dev->flags means we are dealing >> with drivers/net/loopback.c. >> > > This is a very general view, don't you think? The one is an interface > flag and the other one is an interface itsel

[PATCH 2/3] sky2: fix VLAN receive processing

2007-09-28 Thread Stephen Hemminger
The length check for truncated frames was not correctly handling the case where VLAN acceleration had already read the tag. Also, the Yukon EX has some features that use high bit of status as security tag. Signed-off-by: Pierre-Yves Ritschard <[EMAIL PROTECTED]> Signed-off-by: Stephen Hemminger <[

[PATCH 1/3] sky2: reduce impact of watchdog timer

2007-09-28 Thread Stephen Hemminger
This is the 2.6.22 version of a regression fix that is already in 2.6.23. Change the watchdog timer form 10 per second all the time, to 1 per second and only if interface is up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-09-17 10:39:47.0 -0

[PATCH 3/3] sky2: fix transmit state on resume

2007-09-28 Thread Stephen Hemminger
After resume, driver has reset the chip so the current state of transmit checksum offload state machine and DMA state machine will be undefined. The fix is to set the state so that first Tx will set MSS and offset values. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky

[PATCH 0/3] sky2: patches for 2.6.22.y

2007-09-28 Thread Stephen Hemminger
Fixes for power regression, VLAN and resume problems. These are all in 2.6.23. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.

Re: e1000 tcp checksum incorrect, x86 64b

2007-09-28 Thread Rick Jones
Herbert Xu wrote: Jon Smirl <[EMAIL PROTECTED]> wrote: App is writing seven bytes to the socket. Socket write timeout expires and the seven bytes are sent. The checksum is not getting inserted into the packet. It is set to a constant 0x8389 instead of the right value. App is gmpc 0.15.4.95, Re

Re: [PKT_SCHED]: Add stateless NAT

2007-09-28 Thread Patrick McHardy
David Miller wrote: > I still think the nf_*() prefixes should all go and the extern > prototypes should go into an independant header file. > > These are not netfilter routines, they are "INET" helpers. Agreed. Evgeniy, can you send a new patch for this? > And we should make similar treatment

/proc/net/ bad hard links count [Was: 2.6.23-rc8-mm2]

2007-09-28 Thread Jiri Slaby
On 09/27/2007 11:22 AM, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ # find /proc >/dev/null find: WARNING: Hard link count is wrong for /proc/net: this may be a bug in your filesystem driver. Automatically turning on find's -nole

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-28 Thread Thomas Gleixner
On Tue, 2007-09-25 at 14:09 -0700, David Miller wrote: > > > Then please make all exported symbols marked EXPORT_SYMBOL_GPL to make > > > sure that the other CAN protocol can not reuse your infrastructure. > > > > We don't want to force other CAN protocol implementations to be GPL > > also. AFAIR

[IPV6] Fix ICMPv6 redirect handling with target multicast address

2007-09-28 Thread Brian Haley
When the ICMPv6 Target address is multicast, Linux processes the redirect instead of dropping it. The problem is in this code in ndisc_redirect_rcv(): if (ipv6_addr_equal(dest, target)) { on_link = 1; } else if (!(ipv6_addr_type(target) & IPV6_ADDR_LINKLOCAL)) {

Re: [PATCH] sb1250-mac: Driver model & phylib update

2007-09-28 Thread Maciej W. Rozycki
On Mon, 24 Sep 2007, Andrew Morton wrote: > > Well, this is against Jeff's netdev-2.6 tree which hopefully is not as > > crufty as Linus's old mainline; if it is not possible to queue this change > > for 2.6.25 or suchlike, then I will try to resubmit later. > > Most of Jeff's netdev tree got

  1   2   >