[PATCH 3/3] netxen: ethtool fixes

2007-09-02 Thread Dhananjay Phadke
Resubmitting the patch. This patch improves ethtool support for printing correct ring statistics, segmentation offload status, etc. Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/netxen/netxen_nic.h

Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-02 Thread Michal Piotrowski
Hi, [Adding netdev and wireless to CC] On 02/09/07, Florian Lohoff <[EMAIL PROTECTED]> wrote: > > Hi, > with current git i got this when "ifconfig eth1" down. eth1 had a mac > address which looked really like an eth1394 ethernet although the module > was not loaded. Something is really broken in

Re: PROBLEM: 2.6.23-rc "NETDEV WATCHDOG: eth0: transmit timed out"

2007-09-02 Thread Karl Meyer
Hi, am am looking for this issue for some time now, but there where no errors in 2.6.22-r2 (gentoo speak, I guess this is 2.6.22.2 officially), I also ran git-bisect (for more information see the older messages in this thread). 2007/9/3, Michal Piotrowski <[EMAIL PROTECTED]>: > Hi, > > On 01/09/0

Re: PROBLEM: 2.6.23-rc "NETDEV WATCHDOG: eth0: transmit timed out"

2007-09-02 Thread Michal Piotrowski
Hi, On 01/09/07, Karl Meyer <[EMAIL PROTECTED]> wrote: > This is what happened today: > > Sep 1 21:08:01 frege NETDEV WATCHDOG: eth0: transmit timed out > frege ~ # uname -r > 2.6.22.5-cfs-v20.5 Can you reproduce this on 2.6.22 (not 2.6.22.x - it might be a -stable regression)? Regards, Michal

Re: 2.6.23-rc4-mm1: unpingable box and NULL dereference at tcp_rto_min()

2007-09-02 Thread Alexey Dobriyan
On Sun, Sep 02, 2007 at 01:52:45PM -0700, Andrew Morton wrote: > > On Sun, 2 Sep 2007 06:36:19 +0400 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > The bad news is something knocked off box from the net, then panicked it: > > Yeah, the net tree has been quite bad lately. Unusually bad - it's usua

Re: [PATCH 2/2]: [NET_SCHED]: Making rate table lookups more flexible.

2007-09-02 Thread Patrick McHardy
Jesper Dangaard Brouer wrote: On Sun, 2 Sep 2007, Patrick McHardy wrote: This is not a ATM/ADSL only patch. This patch simply adds more flexibility to the rate tables. Afterwards we can start the discussion about how to use this new flexibility in tc/iproute2. I know, but that discussion s

Re: 2.6.23-rc4-mm1: unpingable box and NULL dereference at tcp_rto_min()

2007-09-02 Thread Andrew Morton
> On Sun, 2 Sep 2007 06:36:19 +0400 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/ > > - dynticks-for-x86_64 has returned > > Good news is that,

Re: potentially kernel panic on lib/rbtree.c

2007-09-02 Thread slavon
Hm... Not good. After patch NETCONSOLE log: THERE MANY MESSAGES LIKE DOWN [16038.677029] WARNING: at net/sched/sch_htb.c:362 htb_safe_rb_erase() [16038.677031] [] htb_dequeue+0x13d/0x6d2 [sch_htb] [16038.677038] [] __qdisc_run+0x2a/0x16b [16038.677043] [] dev_queue_xmit+0x18b/0x2a6

[PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable warning

2007-09-02 Thread Satyam Sharma
net/sunrpc/svc.c: In function ‘__svc_create_thread’: net/sunrpc/svc.c:550: warning: ‘oldmask.bits[0u]’ may be used uninitialized in this function is a bogus warning, but gcc isn't smart enough to see why. We cannot just reorganize the code in the function, because we want the set_cpus_allowed()

Re: [PATCH 2/2]: [NET_SCHED]: Making rate table lookups more flexible.

2007-09-02 Thread Jesper Dangaard Brouer
On Sun, 2 Sep 2007, Patrick McHardy wrote: Jesper Dangaard Brouer wrote: On Sat, 1 Sep 2007, Patrick McHardy wrote: This is not a ATM/ADSL only patch. This patch simply adds more flexibility to the rate tables. Afterwards we can start the discussion about how to use this new flexibility

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Matthew Jacob
This has been pretty interesting for me to watch as I distribute my isp driver under a dual license (at least the portions of it which are common with the *BSD and Solaris ports) that is almost identical to Sam's verbiage. I'll admit that I hadn't thought about whether redistribution included the

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Al Viro
On Sun, Sep 02, 2007 at 03:00:46PM +0200, Igor Sobrado wrote: > >Not strictly true. They can either agree to a change and issue one or > >they can convey to other parties the right to change the terms. The GPL > >for example does this for version selection. > > So, under a dual-licensed BSD/GPL co

Re: RTNL: assertion failed at net/core/dev.c

2007-09-02 Thread Christian Kujau
On Sun, 2 Sep 2007, Stephen Hemminger wrote: Vendor module calls kernel api incorrectly. dev_set_promiscuity requires that the calling thread hold rtnl mutex (ie call rtnl_lock). It's their bug, netdev doesn't want to hear about it. OK, that's all I needed to know. Thank you both for your comme

Re: RTNL: assertion failed at net/core/dev.c

2007-09-02 Thread Johannes Berg
On Sun, 2007-09-02 at 18:05 +0200, Christian Kujau wrote: > but given the amount of changes currently > going into net/ I thought this might be interesting: > > [15604.137408] RTNL: assertion failed at net/core/dev.c (2595) > [15604.138807] [] __dev_set_promiscuity+0xc2/0xd0 > [15604.139163] [

Re: RTNL: assertion failed at net/core/dev.c

2007-09-02 Thread Stephen Hemminger
On Sun, 2 Sep 2007 18:05:33 +0200 (CEST) Christian Kujau <[EMAIL PROTECTED]> wrote: > Wow, I should really update more often. Skipping the last -rc versions > AND adding a new device (zd1211rw) to the box turns out to be quite > interesting ([0],[1]). > > However, this time loading of a (propri

RTNL: assertion failed at net/core/dev.c

2007-09-02 Thread Christian Kujau
Wow, I should really update more often. Skipping the last -rc versions AND adding a new device (zd1211rw) to the box turns out to be quite interesting ([0],[1]). However, this time loading of a (proprietary) module is involved. Knowing that lkml cannot really help here (and I should contact vmw

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Igor Sobrado
On Sun, 2 Sep 2007, Jeff Garzik wrote: Krzysztof Halasa wrote: WRT Atheros driver I'd probably leave the thing as is (i.e., BSD/GPL = in fact BSD), unless something like 50+% of the code is rewritten - it's mostly their hard work after all, isn't it? Not legal requirement, though. Yes. T

Re: [PATCH 3/5] Net: ath5k, use int as retval

2007-09-02 Thread Nick Kossifidis
2007/9/1, Jiri Slaby <[EMAIL PROTECTED]>: > John W. Linville napsal(a): > > On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote: > >> ath5k, use int as retval > >> > >> Convert some functions to return int and proper negative return value on > >> error as we are used to. > > > > Since I didn

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Bodo Eggert
Igor Sobrado <[EMAIL PROTECTED]> wrote: > When code is multi-licensed it must be distributed under *all* these > licensing terms concurrently. No. E.g.: If I don't agree to the GPL (or if I had violated it and therefore have lost it's privileges), I MUST NOT redistribute it under the GPL because

Re: [PATCH 2/2]: [NET_SCHED]: Making rate table lookups more flexible.

2007-09-02 Thread Patrick McHardy
Jesper Dangaard Brouer wrote: > > On Sat, 1 Sep 2007, Patrick McHardy wrote: > >> Am I guessing right that the intention is to resurrect the ATM patch? > > > Yes, you are right. > Remember, Jamal ACKed the patch, and you redrew your NAK. Mainly out of frustration/boredom with the discussion,

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Jeff Garzik
Krzysztof Halasa wrote: WRT Atheros driver I'd probably leave the thing as is (i.e., BSD/GPL = in fact BSD), unless something like 50+% of the code is rewritten - it's mostly their hard work after all, isn't it? Not legal requirement, though. Yes. This deserves to be reinforced: There is defi

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Krzysztof Halasa
IANAL, but: Igor Sobrado <[EMAIL PROTECTED]> writes: > So, under a dual-licensed BSD/GPL code the latter license allows a > developer to remove the GPL license itself and release a > single-licensed BSD code if other parties want to do it? Of course. If it wasn't legal, dual BSD/GPL would just b

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Alan Cox
> > Not strictly true. They can either agree to a change and issue one or > > they can convey to other parties the right to change the terms. The GPL > > for example does this for version selection. > > So, under a dual-licensed BSD/GPL code the latter license allows a > developer to remove the G

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Adrian Bunk
On Sun, Sep 02, 2007 at 03:00:46PM +0200, Igor Sobrado wrote: > On Sun, 2 Sep 2007, Alan Cox wrote: > >>> So, a multi-licensed file remains multi-licensed except when all authors >>> agree about a change in the licensing terms. And it is clear on the BSD >> >> Not strictly true. They can either ag

2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-02 Thread Christian Kujau
Hi, after upgrading to 2.6.23-rc5 (and applying davem's fix [0]), lockdep was quite noisy when I tried to shape my external (wireless) interface: [ 6400.534545] FahCore_78.exe/3552 just changed the state of lock: [ 6400.534713] (&dev->ingress_lock){-+..}, at: [] netif_receive_skb+0x2d5/0x3c0

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Igor Sobrado
On Sun, 2 Sep 2007, Alan Cox wrote: So, a multi-licensed file remains multi-licensed except when all authors agree about a change in the licensing terms. And it is clear on the BSD Not strictly true. They can either agree to a change and issue one or they can convey to other parties the right

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Igor Sobrado
On Sun, 2 Sep 2007, Alan Cox wrote: You can shout this all you like but you would be wrong. You can remove the licence if you have permission to do so. For the ath c files there was permission to do so. There was permission to do so from Reyk Floeter? Really? Your understanding isn't quite r

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Alan Cox
> So, a multi-licensed file remains multi-licensed except when all authors > agree about a change in the licensing terms. And it is clear on the BSD Not strictly true. They can either agree to a change and issue one or they can convey to other parties the right to change the terms. The GPL for

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Jeff Garzik
Igor Sobrado wrote: When code is multi-licensed it must be distributed under *all* these licensing terms concurrently. It is easy to understand. Removing (or changing) the conditions that apply to the program from the source code and documentation *without* an authorization from all the autho

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Alan Cox
On Sun, 02 Sep 2007 13:20:27 +0200 (CEST) Igor Sobrado <[EMAIL PROTECTED]> wrote: > On Sun, 2 Sep 2007, Alan Cox wrote: > > You can shout this all you like but you would be wrong. You can remove > > the licence if you have permission to do so. For the ath c files there > > was permission to do so.

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Igor Sobrado
On Sun, 2 Sep 2007, Adrian Bunk wrote: On Sun, Sep 02, 2007 at 01:20:27PM +0200, Igor Sobrado wrote: Reyk code was never dual licensed! His code is under truly free licensing terms (BSD). Jiri's patch touched both files containing BSD-only code by Reyk and code Reyk contributed to leaving the

Re: Oops in 2.6.23-rc5

2007-09-02 Thread Christian Kujau
On Sun, 2 Sep 2007, Herbert Xu wrote: You want this patch (by davem). I applied the patch and the box is up for 1hr now. Since I was able to reproduce the oops pretty reliable with this bittorrent thingy, I did the same a few times now, but the box did NOT crash :) Unfortunately people are

Re: [OOPS] 2.6.23-rc5 ? network/via-rhine [was: hang with CONFIG_MCYRIXIII]

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Mark Hindley wrote: > > BUG: unable to handle kernel NULL pointer dereference at virtual address > 0025 > [...] > Call Trace: > [] tcp_rtt_estimator+0xba/0x100 > [...] > EIP: [] tcp_rto_min+0x8/0x12 SS:ESP 0068:c0341dec Third report of this oops within past

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Adrian Bunk
On Sun, Sep 02, 2007 at 01:20:27PM +0200, Igor Sobrado wrote: > On Sun, 2 Sep 2007, Alan Cox wrote: >> You can shout this all you like but you would be wrong. You can remove >> the licence if you have permission to do so. For the ath c files there >> was permission to do so. > > There was permissio

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Jan Engelhardt
On Sep 1 2007 18:36, Theo de Raadt wrote: > >When companies have taken our wireless device drivers, many many of >them have given changes and fixes back. Some maybe didn't, but that >is OK. For companies it's ok, but for linux people it is not? (1) You do not know how much of the modifications

Re: Ethernet weirdness on 82xx

2007-09-02 Thread Denys
Thats normal. Check arp_filter sysctl : arp_filter - BOOLEAN 1 - Allows you to have multiple network interfaces on the same subnet, and have the ARPs for each interface be answered based on whether or not the kernel would route a packet from the ARP'd IP out that int

Re: Ethernet weirdness on 82xx

2007-09-02 Thread Denys
Sorry forgot, maybe also arp_ignore is related to that -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH -mm] net/sched/sch_cbq.c: Shut up uninitialized variable warning

2007-09-02 Thread Patrick McHardy
Satyam Sharma wrote: net/sched/sch_cbq.c: In function 'cbq_enqueue': net/sched/sch_cbq.c:383: warning: 'ret' may be used uninitialized in this function has been verified to be a bogus case. So let's shut it up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> Acked-by: Patrick McHardy <[EMAI

[OOPS] 2.6.23-rc5 ? network/via-rhine [was: hang with CONFIG_MCYRIXIII]

2007-09-02 Thread Mark Hindley
I have now got an oops trace out of this box, which I presume has been the cause of the previously observed hangs. To my inexperienced eye it looks like it is related to via-rhine. Thanks Mark BUG: unable to handle kernel NULL pointer dereference at virtual address 0025 prin

Re: [ofa-general] Re: [PATCH V4 10/10] net/bonding: Destroy bonding master when last slave is gone

2007-09-02 Thread Moni Shoua
Jay Vosburgh wrote: > Moni Shoua <[EMAIL PROTECTED]> wrote: > >> Jay Vosburgh wrote: >>> Moni Shoua <[EMAIL PROTECTED]> wrote: >>> When bonding enslaves non Ethernet devices it takes pointers to functions in the module that owns the slaves. In this case it becomes unsafe to keep th

[-mm patch] IPV6 must select XFRM

2007-09-02 Thread Adrian Bunk
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc3-mm1: >... > git-net.patch >... > git trees >... This patch fixes the following compile error: <-- snip --> ... LD .tmp_vmlinux1 net/built-in.o: In function `inet6_csk_xmit': (.text+0x72b0f):

[PATCH] ethtool: provide default behavior for a few sub-ioctls

2007-09-02 Thread Jeff Garzik
Just checked this in... commit 2c0205e3480ac39f5b52b2220ff0c77141502936 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sun Sep 2 07:13:36 2007 -0400 [ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls For the operations get-tx-csum get-sg get-

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-09-02 Thread Patrick McHardy
Herbert Xu wrote: Patrick McHardy <[EMAIL PROTECTED]> wrote: Thanks. I'm not sure either, it would require two concurrent requests to be processed, but AFAICS oidentd only uses a single netlink socket. Perhaps multiple running instances or something else using the inet_diag interface?

[PATCH 2/2] drivers/net/: all drivers/net/ cleanup with ARRAY_SIZE

2007-09-02 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- drivers/net/apne.c |2 +- drivers/net/arm/am79c961a.c|2 +- drivers/net/atarilance.c |2 +- drivers/net/atl1/atl1_hw.c |2 +- drivers/net/bnx2.c

[PATCH 1/2] net/: all net/ cleanup with ARRAY_SIZE

2007-09-02 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- net/atm/proc.c |2 +- net/decnet/dn_dev.c |2 +- net/ipv4/af_inet.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/atm/proc.c b/net/atm/proc.c index 99fc1fe..a3e52ff 100644 --- a/net/atm/proc.c +++ b/ne

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-02 Thread Alan Cox
> - If you receive ISC or BSD licensed code, you may not delete the > license. Same principle, since the notice says so. It's the law. > Really. You can shout this all you like but you would be wrong. You can remove the licence if you have permission to do so. For the ath c files there was per

Re: That whole "Linux stealing our code" thing

2007-09-02 Thread Alan Cox
> co-operation. Together we advance our detective work and knowledge of > the Macintosh platforms to the good of all Macintosh users dumped" > > Alan Cox circa 1999. > > http://lists.freedesktop.org/archives/xorg/2007-August/027419.html > > "well I'd be quite happy to see X go GPL but I'm aware

[PATCH] remove setup of platform device from jazzsonic.c

2007-09-02 Thread Thomas Bogendoerfer
remove setup platform device from jazzsonic, which is done in arch code now Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- diff --git a/drivers/net/jazzsonic.c b/drivers/net/jazzsonic.c index 75f6f44..435060a 100644 --- a/drivers/net/jazzsonic.c +++ b/drivers/net/jazzsonic.c @@ -45,7

Re: 2.6.23-rc4-mm1 OOPS in forcedeth?

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, [EMAIL PROTECTED] wrote: > > > > [EMAIL PROTECTED] wrote: > > > > > > > > On this machine (Athlon 64 X2 4600, 4 GiB memory, lots of disks), > > > > 2.6.23-rc1-mm2 runs fine. 2.6.23-rc4-mm1 reproducably dies within > > > > seconds of > > > > starting > > > > a rsync session

2.6.23-rc4-mm1 net bitops compile error

2007-09-02 Thread Adrian Bunk
defconfig fails with the following error on parisc: <-- snip --> ... CC net/core/gen_estimator.o In file included from include2/asm/bitops.h:111, from /home/bunk/linux/kernel-2.6/linux-2.6.23-rc4-mm1/net/core/gen_estimator.c:18: /home/bunk/linux/kernel-2.6/linux-2.6.23-

Re: Problem with implementation of TCP_DEFER_ACCEPT?

2007-09-02 Thread Andi Kleen
TJ <[EMAIL PROTECTED]> writes: > > Therefore, anyone deploying apache web servers in a web-farm behind the > Juniper DX load-balanders and using TCP multiplexing (for which they pay > a hefty licence fee!) If they ask for that much money they can surely fix it to work properly too? -Andi - To