[PATCH 3/3] 8139too: clean up I/O remapping

2007-08-07 Thread Jeff Garzik
commit 9ee6b32a47b9abc565466a9c3b127a5246b452e5 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed Aug 8 02:42:47 2007 -0400 [netdrvr] 8139too: clean up I/O remapping * no need to explicitly use ioport_map() for PIO. pci_iomap() works just fine for both PIO and MMIO. This pe

[PATCH 2/3] 8139too: clean up register defines and structs

2007-08-07 Thread Jeff Garzik
commit 23b0a2f0f4e98a23f6fdf5b7ae4a4d60ca0cc3e2 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed Aug 8 02:28:46 2007 -0400 [netdrvr] 8139too: tab-align enums and structs; remove dead code * (main change) tab-align hardware register value enums, and hw struct * MMIO_FLUSH_

[PATCH 1/3] 8139cp, 8139too: use generic DMA

2007-08-07 Thread Jeff Garzik
commit f09934422b162e0eb7a8fd3b4b25ffc92e31541a Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed Aug 8 02:16:04 2007 -0400 [netdrvr] 8139cp, 8139too: convert to generic DMA Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> drivers/net/8139cp.c | 31 +-

Re: [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset

2007-08-07 Thread Mariusz Kozlowski
> Please send wireless patches to [EMAIL PROTECTED], > and CC me. Ok. Did you pick the patch up? Regards, Mariusz - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

Re: TCP's initial cwnd setting correct?...

2007-08-07 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 6 Aug 2007 15:37:15 +0300 (EEST) > ...Another thing that makes me wonder, is the tp->mss_cache > 1460 check > as based on rfc3390 (and also it's precursor rfc2414) with up to 2190 > bytes MSS TCP can use 3 as initial cwnd... I did the researc

Re: [PATCH RFC]: napi_struct V5

2007-08-07 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 07 Aug 2007 20:56:40 -0700 > First, there's pretty much universal agreement that > patches should only contain one idea ("separate your changes"), that > cleanups should not be mixed in with other changes, etc, etc. Fine I'll revert. > Although

Re: [PATCH RFC]: napi_struct V5

2007-08-07 Thread Roland Dreier
> > > n = ib_poll_cq(priv->cq, t, priv->ibwc); > > > > > > - for (i = 0; i < n; ++i) { > > > + for (i = 0; i < n; i++) { > > > > it might be nicer to avoid noise like this in the patch. > That one was just too much of an eye sore to ignore

Re: [PATCH 6/14] nes: hardware init

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +struct nes_adapter *nes_init_adapter(struct nes_device *nesdev, u8 hw_rev) { + struct nes_adapter *nesadapter = NULL; + unsigned long num_pds; + u32 u32temp; + u32 port_count; + u16 max_rq_wrs; + u16 max_sq_wrs; + u32 max_mr; +

Re: [PATCH 5/14] nes: context structures and defines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: QP context structures and defines Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_context.h --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_context.h

Re: [PATCH 4/14] nes: connection manager structures and defines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +struct ietf_mpa_frame { + u8 key[IETF_MPA_KEY_SIZE]; + u8 flags; + u8 rev; + u16 priv_data_len; + u8 priv_data[0]; use unsigned long, not u8, for proper alignment. plus, as noted in other emails, you should not ever be using 'u8' for poi

[PATCH 1/14] nes: module and device initialization

2007-08-07 Thread root
Kernel module and device initialization routines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes.c --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes.c 2007-08-06 20:09:04.

Re: [PATCH 3/14] nes: connection manager routines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +atomic_t cm_connects; +atomic_t cm_accepts; +atomic_t cm_disconnects; +atomic_t cm_closes; +atomic_t cm_connecteds; +atomic_t cm_connect_reqs; +atomic_t cm_rejects; do you really want to take the hit of a LOCK prefix each time you increment a stat??? +static struc

Re: Please pull 'libertas-upstream' branch of wireless-2.6

2007-08-07 Thread John W. Linville
On Tue, Aug 07, 2007 at 06:22:59PM -0400, Jeff Garzik wrote: > John W. Linville wrote: > >Got a big patch bomb from the libertas guys. I tried to cherry-pick > >some of the fixes for 2.6.23, but they either were fixes to problems > >in new code or all the code cleanups made them difficult for me t

[PATCH 14/14] nes: kernel build infrastructure

2007-08-07 Thread ggrundstrom
Makefile kernel build file. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/Makefile --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/Makefile 2007-08-06 20:09:04.0 -0500 @@

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-07 Thread David Miller
From: Joy Latten <[EMAIL PROTECTED]> Date: Thu, 2 Aug 2007 15:56:47 -0500 > @@ -426,10 +426,15 @@ struct xfrm_audit > }; > > #ifdef CONFIG_AUDITSYSCALL > -extern void xfrm_audit_log(uid_t auid, u32 secid, int type, int result, > - struct xfrm_policy *xp, struct xfrm_state *x);

Re: [PATCH] TCP: H-TCP maxRTT estimation at startup

2007-08-07 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 3 Aug 2007 10:57:56 +0100 > Small patch to H-TCP from Douglas Leith. > > Fix estimation of maxRTT. The original code ignores rtt measurements > during slow start (via the check tp->snd_ssthresh < 0x) yet this > is probably a good time t

[PATCH 13/14] nes: kernel build infrastructure

2007-08-07 Thread ggrundstrom
Kconfig kernel build file. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/Kconfig --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/Kconfig2007-08-06 20:09:04.0 -0500 @@ -0

[PATCH 12/14] nes: OpenFabrics kernel verb includes

2007-08-07 Thread ggrundstrom
OpenFabrics kernel verbs provider structures and defines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_verbs.h --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_verbs.h

Re: TCP's initial cwnd setting correct?...

2007-08-07 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 6 Aug 2007 15:37:15 +0300 (EEST) > @@ -805,13 +805,13 @@ void tcp_update_metrics(struct sock *sk) > } > } > > -/* Numbers are taken from RFC2414. */ > +/* Numbers are taken from RFC3390. */ > __u32 tcp_init_cwnd(struct tcp_sock *tp,

[PATCH 10/14] nes: eeprom, phy, routines

2007-08-07 Thread ggrundstrom
Misc eeprom, phy, debug, etc routines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_utils.c --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_utils.c2007-08-06 20:09:

[PATCH 2.6.24]S2io: Enhance device error/alarm handling

2007-08-07 Thread Ramkrishna Vepa
- Added support to poll for entire set of device errors and alarms. - Optimized interrupt routine fast path. - Removed the unused variable, intr_type, in device private structure. Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> --- diff -Nurp

Re: [RFC] cubic: backoff after slow start

2007-08-07 Thread Injong Rhee
Hi Stephen, We have been working on slow start and we have a nice solution for this. We will send you a patch and test results. Thanks Injong - Original Message - From: "Stephen Hemminger" <[EMAIL PROTECTED]> To: "Injong Rhee" <[EMAIL PROTECTED]>; "Sangtae Ha" <[EMAIL PROTECTED]> Cc:

[PATCH 9/14] nes: kernel to userspace structures

2007-08-07 Thread ggrundstrom
Kernel to userspace includes, structures and defines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_user.h --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_user.h 2007-08-06

[PATCH 8/14] nes: nic device routines

2007-08-07 Thread ggrundstrom
Nic device routines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_nic.c --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_nic.c 2007-08-06 20:09:05.0 -0500 @@ -0,0 +

[PATCH 7/14] nes: hardware specific includes

2007-08-07 Thread ggrundstrom
Hardware structures and defines Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_hw.h --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_hw.h 2007-08-06 20:09:05.0 -0500

Re: [PATCH 2/14] nes: device structures and defines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +#ifndef PCI_VENDOR_ID_NETEFFECT/* not in pci.ids yet */ +#define PCI_VENDOR_ID_NETEFFECT 0x1678 this should be part of your patch +#define PCI_DEVICE_ID_NETEFFECT_NE020 0x0100 no need for a #define at all, just use the hex number if the ONLY place its use

[PATCH 5/14] nes: context structures and defines

2007-08-07 Thread ggrundstrom
QP context structures and defines Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_context.h --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_context.h 2007-08-06 20:09:04.

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-08-07 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Mon, 6 Aug 2007 16:13:21 -0400 > The following changes since commit d4ac2477fad0f2680e84ec12e387ce67682c5c13: > Linus Torvalds (1): > Linux 2.6.23-rc2 > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux

Re: [RFC] allow device to stop packet mirror behaviour

2007-08-07 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Tue, 07 Aug 2007 10:25:55 +0200 > The only way to solve this problem therefore seems to be to suppress the > mirroring out of the packet by dev_queue_xmit_nit(). The patch below > does that by way of adding a new netdev flag. Multicast packets also ge

Re: [PATCH] net/core/utils: fix sparse warning

2007-08-07 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Mon, 06 Aug 2007 18:37:26 +0200 > net_msg_warn is not defined because it is in net/sock.h which isn't > included. > > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> Applied, thanks Johannes. - To unsubscribe from this list: send the line "unsubscri

[PATCH 4/14] nes: connection manager structures and defines

2007-08-07 Thread ggrundstrom
NetEffect connection manager includes, structures and defines. Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_cm.h --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_cm.h 2007-

Re: [PATCH RFC]: napi_struct V5

2007-08-07 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Tue, 07 Aug 2007 08:52:35 -0400 > That doc is out of date on the split of work - it focusses mostly > describing the original tulip which did not mix rx and tx in the > napi_poll(). AFAIK, no driver does that today (although i really liked > that scheme, there

Re: [patch 1/1] NetLabel: add missing rcu_dereference() calls in the LSM domain mapping hash table

2007-08-07 Thread David Miller
From: "Paul Moore" <[EMAIL PROTECTED]> Date: Tue, 07 Aug 2007 16:54:50 -0400 > The LSM domain mapping head table pointer was not being referenced via the RCU > safe dereferencing function, rcu_dereference(). This patch adds those missing > calls to the NetLabel code. > > This has been tested usi

[PATCH 2/14] nes: device structures and defines

2007-08-07 Thread ggrundstrom
Main include file for device structures and defines Signed-off-by: Glenn Grundstrom <[EMAIL PROTECTED]> --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes.h --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes.h 2007-08-06 20:09:0

Re: [PATCH] xen-netfront: remove dead code

2007-08-07 Thread Jeremy Fitzhardinge
Jeff Garzik wrote: > Yes. It's in my pending-for-2.6.24 folder, since it's not a bug fix. Great, thanks. J - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/14] nes: NetEffect 10Gb RNIC Driver

2007-08-07 Thread ggrundstrom
NetEffect is proud to announce the following series of patches which contain the source code for the NE020 10Gb RNIC adapter. The driver is split into two components - a kernel driver module and a userspace library. The code can also be found in the following git trees. git.openfabrics.org/~gle

Re: [PATCH] xen-netfront: remove dead code

2007-08-07 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: Jeff Garzik wrote: Please send drivers/net/* through me and netdev... Sure. Did you pick this patch up? Yes. It's in my pending-for-2.6.24 folder, since it's not a bug fix. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in th

[git patches] net driver fixes

2007-08-07 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/atl1/atl1_main.c|4 +-- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_m

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2007-08-07 Thread Peter Korsgaard
> "Peter" == Peter Korsgaard <[EMAIL PROTECTED]> writes: Hi, Peter> I'll give your driver a try and report back. Ok, the driver seems to be working (after fixing up the accessor routines for my hw setup) and performance is comparable to Dustin's driver. It would be nice if the driver would

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-07 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 8 Aug 2007 00:04:59 +0100 > Please take a look at kernel/irq/handle.c. The irq handler is > always called with the right dev_id argument. Everything would be a complete > nightmare to handle because you usually need to access the device priv

Re: [PATCH RFC]: napi_struct V5

2007-08-07 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 07 Aug 2007 15:37:30 -0700 > >n = ib_poll_cq(priv->cq, t, priv->ibwc); > > > > - for (i = 0; i < n; ++i) { > > + for (i = 0; i < n; i++) { > > it might be nicer to avoid noise like this in the patch. That one

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-07 Thread Christoph Hellwig
On Wed, Aug 08, 2007 at 12:20:35AM +0200, Michael Buesch wrote: > On Wednesday 08 August 2007 00:15:47 Jeff Garzik wrote: > > Michael Buesch wrote: > > > On Wednesday 01 August 2007 10:31:17 Michael Chan wrote: > > >> +static irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance) > > >> +{ > >

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-07 Thread Roland Dreier
> > +static irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance) > > +{ > > + struct net_device *dev = dev_instance; > > You need to check if dev==NULL and bail out. > Another driver sharing the IRQ with this might choose to pass the dev > pointer as NULL. I don't really understand

RE: [PATCH 2.6.23 1/3]S2IO: Making MSIX as default intr_type

2007-08-07 Thread Ramkrishna Vepa
Jeff, Go ahead and apply these patches to netdev#upstream (queued for 2.6.24). Thanks, Ram > -Original Message- > From: Jeff Garzik [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 07, 2007 3:20 PM > To: Sivakumar Subramani > Cc: netdev@vger.kernel.org; support > Subject: Re: [PATCH 2.6

Re: [PATCH] xen-netfront: remove dead code

2007-08-07 Thread Jeremy Fitzhardinge
Jeff Garzik wrote: > Please send drivers/net/* through me and netdev... Sure. Did you pick this patch up? Thanks, J - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH RFC]: napi_struct V5

2007-08-07 Thread Roland Dreier
Thanks for looking at ipoib... overall looks fine, just a few comments. > --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c > @@ -281,63 +281,58 @@ static void ipoib_ib_handle_tx_wc(struct net_device > *dev, struct ib_wc *wc) >

Re: [PATCH] xen-netfront: remove dead code

2007-08-07 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: This patch removes some residual dead code left over from removing the "flip" receive mode. This patch doesn't change the generated output at all, since gcc already realized it was dead. This resolves the "regression" reported by Adrian. Signed-off-by: Jeremy Fitzhar

Re: Please pull 'libertas-upstream' branch of wireless-2.6

2007-08-07 Thread Jeff Garzik
John W. Linville wrote: Got a big patch bomb from the libertas guys. I tried to cherry-pick some of the fixes for 2.6.23, but they either were fixes to problems in new code or all the code cleanups made them difficult for me to intelligently backport. So, this is intended for 2.6.24... --- Th

Re: Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-08-07 Thread Jeff Garzik
John W. Linville wrote: These are intended for 2.6.24... --- The following changes since commit fdc8f43b5e49b64b251bb48da95193a13ac0132f: Michael Buesch (1): softmac: Fix deadlock of wx_set_essid with assoc work are available in the git repository at: git://git.kernel.org/pub/scm/

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-07 Thread Michael Buesch
On Wednesday 08 August 2007 00:15:47 Jeff Garzik wrote: > Michael Buesch wrote: > > On Wednesday 01 August 2007 10:31:17 Michael Chan wrote: > >> +static irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance) > >> +{ > >> + struct net_device *dev = dev_instance; > > > > You need to check if d

Re: [PATCH 2.6.23 1/3]S2IO: Making MSIX as default intr_type

2007-08-07 Thread Jeff Garzik
Sivakumar Subramani wrote: - Making MSIX as default intr_type - Driver will test MSI-X by issuing test MSI-X vector and if fails it will fallback to INTA Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> This patch series looks a bit bi

Re: [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: Jeff Garzik wrote: Brian King wrote: This patch adds the appropriate ethtool hooks to allow for enabling/disabling of hypervisor assisted checksum offload for TCP. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- linux-2.6-bjking1/drivers/net/ibmveth.c | 118 +

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-07 Thread Jeff Garzik
Michael Buesch wrote: On Wednesday 01 August 2007 10:31:17 Michael Chan wrote: +static irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance) +{ + struct net_device *dev = dev_instance; You need to check if dev==NULL and bail out. Another driver sharing the IRQ with this might choose

Re: [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-07 Thread Brian King
Jeff Garzik wrote: > Brian King wrote: >> This patch adds the appropriate ethtool hooks to allow for enabling/disabling >> of hypervisor assisted checksum offload for TCP. >> >> Signed-off-by: Brian King <[EMAIL PROTECTED]> >> --- >> >> linux-2.6-bjking1/drivers/net/ibmveth.c | 118 >> ++

Re: [PATCH 76] drivers/net/via-velocity.c: mostly kmalloc + memset conversion to kcalloc

2007-08-07 Thread Jeff Garzik
Mariusz Kozlowski wrote: Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/via-velocity.c | 88263 -> 88120 (-143 bytes) drivers/net/via-velocity.o | 254264 -> 253828 (-436 bytes) drivers/net/via-velocity.c | 24 ++-- 1 file changed, 10 insertions(+), 14 d

[PATCH] xen-netfront: remove dead code

2007-08-07 Thread Jeremy Fitzhardinge
This patch removes some residual dead code left over from removing the "flip" receive mode. This patch doesn't change the generated output at all, since gcc already realized it was dead. This resolves the "regression" reported by Adrian. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc:

Re: [PATCH 68] drivers/net/s2io.c: kmalloc + memset conversion to k[cz]alloc

2007-08-07 Thread Jeff Garzik
Mariusz Kozlowski wrote: Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/s2io.c | 235587 -> 235340 (-247 bytes) drivers/net/s2io.o | 460768 -> 460120 (-648 bytes) drivers/net/s2io.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) ACK but didn't apply

Re: [PATCH 69] drivers/net/sb1250-mac.c: kmalloc + memset conversion to kcalloc

2007-08-07 Thread Jeff Garzik
Mariusz Kozlowski wrote: Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/sb1250-mac.c | 76286 -> 76199 (-87 bytes) drivers/net/sb1250-mac.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH 6/6] ibmveth: Remove use of bitfields

2007-08-07 Thread Jeff Garzik
Brian King wrote: Removes the use of bitfields from the ibmveth driver. This results in slightly smaller object code. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- linux-2.6-bjking1/drivers/net/ibmveth.c | 90 linux-2.6-bjking1/drivers/net/ibmveth.h | 5

Re: [PATCH 4/6] ibmveth: Add ethtool driver stats hooks

2007-08-07 Thread Jeff Garzik
Brian King wrote: Add ethtool hooks to ibmveth to retrieve driver statistics. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- drivers/net/ibmveth.c | 53 +- 1 file changed, 52 insertions(+), 1 deletion(-) diff -puN drivers/net/ibmveth.c~ibmv

Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers

2007-08-07 Thread Jeff Garzik
Brian King wrote: Add handlers for get_tso and get_ufo to prevent errors being printed by ethtool. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- drivers/net/ibmveth.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso driver

Re: [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: This patch adds the appropriate ethtool hooks to allow for enabling/disabling of hypervisor assisted checksum offload for TCP. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- linux-2.6-bjking1/drivers/net/ibmveth.c | 118 +++- linux-2.6-bjking1/

Re: [RFT] sky2: backport patch

2007-08-07 Thread Stephen Hemminger
On Tue, 07 Aug 2007 17:33:51 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > Any volunteers to test this, it has a backport for the three main stability > > patches: > > 1. carrier management > > 2. lost irq timer > > 3. rechecking for packets in poll > > 4. overle

Re: [PATCH 1/6] ibmveth: Enable TCP checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: This patchset enables TCP checksum offload support for IPV4 on ibmveth. This completely eliminates the generation and checking of the checksum for packets that are completely virtual and never touch a physical network. A simple TCP_STREAM netperf run on a virtual network with ma

Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-07 Thread Jeff Garzik
Mariusz Kozlowski wrote: Looks like memset() is zeroing wrong nr of bytes. Good catch, however, I think we can just remove this memset altogether since the memory gets allocated via kzalloc. Correct, that memset() is superfluous. Ok. Then this should do it. Signed-off-by: Mariusz Koz

Re: [PATCH] phy layer: fix phy_mii_ioctl for autonegotiation

2007-08-07 Thread Jeff Garzik
Domen Puncer wrote: Fix a thinko (?) in setting phydev->autoneg. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- This fixes my "mii.h -> ethtool.h advertising #defines". I'm not sure why and how they're translated, but it does work now. Maybe they're just ignored, since mii-tool directly r

Re: [RESEND][PATCH 1/3] ehea: Fix workqueue handling

2007-08-07 Thread Jeff Garzik
Thomas Klein wrote: Fix: Workqueue ehea_driver_wq was not destroyed Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) applied 1-3 to #upstream-fixes - To unsubs

Re: [RFT] sky2: backport patch

2007-08-07 Thread Jeff Garzik
Stephen Hemminger wrote: Any volunteers to test this, it has a backport for the three main stability patches: 1. carrier management 2. lost irq timer 3. rechecking for packets in poll 4. overlength packet hang. I am away from any sky2 hardware for another week, but others maybe able to vali

Re: [PATCH 0/2] r8169: pull request for 'r8169-for-jeff-20070806' branch

2007-08-07 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'r8169-for-jeff-20070806' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169-for-jeff-20070806 to get the changes below. Distance from 'upstream-fixes' (c196d80f994ef4ffefd5a7c62e3f42bd75d538bc) ---

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-08-07 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit d4ac2477fad0f2680e84ec12e387ce67682c5c13: Linus Torvalds (1): Linux 2.6.23-rc2 are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git fixes-jgarzik John W. Linville

Re: [GIT PATCH] ucc_geth fixes for 2.6.22-rc1

2007-08-07 Thread Jeff Garzik
Li Yang wrote: Please pull from 'ucc_geth' branch of master.kernel.org:/pub/scm/linux/kernel/git/leo/fsl-soc.git ucc_geth to receive the following fixes: drivers/net/ucc_geth_ethtool.c |1 - drivers/net/ucc_geth_mii.c |3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) Domen

Re: [patch] sis190 check for ISA bridge on SiS966

2007-08-07 Thread Jeff Garzik
maximilian attems wrote: From: Neil Muller <[EMAIL PROTECTED]> sis190 driver assumes to find ISA only on SiS965. similar fix is in sis900 driver, see bug report http://bugs.debian.org/435547 Signed-off-by: maximilian attems <[EMAIL PROTECTED]> applied to #upstream-fixes - To unsubscribe fro

Re: [PATCH] atl1: use spin_trylock_irqsave()

2007-08-07 Thread Jeff Garzik
Jay Cliburn wrote: From: Ingo Molnar <[EMAIL PROTECTED]> use the simpler spin_trylock_irqsave() API to get the adapter lock. [ this is also a fix for -rt where adapter->lock is a sleeping lock. ] Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> ---

[RFT] sky2: backport patch

2007-08-07 Thread Stephen Hemminger
Any volunteers to test this, it has a backport for the three main stability patches: 1. carrier management 2. lost irq timer 3. rechecking for packets in poll 4. overlength packet hang. I am away from any sky2 hardware for another week, but others maybe able to validate this. --- a/drivers/n

[patch 1/1] NetLabel: add missing rcu_dereference() calls in the LSM domain mapping hash table

2007-08-07 Thread Paul Moore
h Content-Disposition: inline; filename=netlabel-rcu_deref_fix The LSM domain mapping head table pointer was not being referenced via the RCU safe dereferencing function, rcu_dereference(). This patch adds those missing calls to the NetLabel code. This has been tested using recent linux-2.6 git

Re: Distributed storage.

2007-08-07 Thread Jens Axboe
On Tue, Aug 07 2007, Daniel Phillips wrote: > On Tuesday 07 August 2007 05:05, Jens Axboe wrote: > > On Sun, Aug 05 2007, Daniel Phillips wrote: > > > A simple way to solve the stable accounting field issue is to add a > > > new pointer to struct bio that is owned by the top level submitter > > > (

Re: [stable] sky2: workaround for lost IRQ and 2.6.22-stable

2007-08-07 Thread Greg KH
On Tue, Aug 07, 2007 at 08:46:31PM +0200, Krzysztof Oledzki wrote: > Hello, > > > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.21.y.git;a=commitdiff;h=fe1fe7c982f86624c692644e8ed05e132f4753cc > > Is this fix going to be included in the next 2.6.22-stable release or is it > not

Linx

2007-08-07 Thread Stephen Hemminger
After seeing this article on Linx http://www.linuxdevices.com/news/NS8613439087.html I decided to give it a quick code review (long airline flight). Overall, it isn't awful, it just looks like every other piece of code that hasn't been managed for mainline kernel inclusion. Nice way of saying, thi

sky2: workaround for lost IRQ and 2.6.22-stable

2007-08-07 Thread Krzysztof Oledzki
Hello, http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.21.y.git;a=commitdiff;h=fe1fe7c982f86624c692644e8ed05e132f4753cc Is this fix going to be included in the next 2.6.22-stable release or is it not needed any more? Best regards, Krzysztof Olędzki

Re: sky2: workaround for lost IRQ and 2.6.22-stable

2007-08-07 Thread Stephen Hemminger
On Tue, 7 Aug 2007 20:46:31 +0200 (CEST) Krzysztof Oledzki <[EMAIL PROTECTED]> wrote: > Hello, > > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.21.y.git;a=commitdiff;h=fe1fe7c982f86624c692644e8ed05e132f4753cc > > Is this fix going to be included in the next 2.6.22-stable release or

[RFT] sky2: turn on pci power

2007-08-07 Thread Stephen Hemminger
This setup step got dropped in 2.6.23, Yukon-EX configuration, maybe this fixes your problem? --- a/drivers/net/sky2.c2007-08-06 04:39:36.0 -0400 +++ b/drivers/net/sky2.c2007-08-07 14:50:25.0 -0400 @@ -222,6 +222,8 @@ static void sky2_power_on(struct sky2_hw

[RFC] cubic: backoff after slow start

2007-08-07 Thread Stephen Hemminger
CUBIC takes several unnecessary iterations to converge out of slow start. This is most noticable over a link where the bottleneck queue size is much larger than BDP, and the sender has to "fill the pipe" in slow start before the first loss. Typical consumer broadband links seem to have large (up

Re: Distributed storage.

2007-08-07 Thread Daniel Phillips
On Tuesday 07 August 2007 05:05, Jens Axboe wrote: > On Sun, Aug 05 2007, Daniel Phillips wrote: > > A simple way to solve the stable accounting field issue is to add a > > new pointer to struct bio that is owned by the top level submitter > > (normally generic_make_request but not always) and is n

Re: e100

2007-08-07 Thread Kok, Auke
ericj wrote: I want to thank everyone who helped with this. It was proven to be a hardware issue. The board designer had left a GPIO pin in an indeterminate state because he was planning to use it later to do something with the battery charge circuitry. I apologize for wasting everyone's time.

Re: e100 (was: eepro100) - Nobody Cares (hardware?)

2007-08-07 Thread ericj
I want to thank everyone who helped with this. It was proven to be a hardware issue. The board designer had left a GPIO pin in an indeterminate state because he was planning to use it later to do something with the battery charge circuitry. I apologize for wasting everyone's time. On Mon, 06 Aug

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-07 Thread Jean-Baptiste Vignaud
> On Tue, Aug 07, 2007 at 11:21:07AM +0200, Jean-Baptiste Vignaud wrote: > > > > > > * interrupts (i use irqbalance, but problem was the same without) > > > > > > I wonder if you tried without SMP too? > > > > No i did not. Do you think that this can be a problem ? > > To test with no SMP, do i n

Re: [PATCH] e1000e: New pci-express e1000 driver (currently for ICH9 devices only)

2007-08-07 Thread Jeff Garzik
Kok, Auke wrote: From: Auke Kok <[EMAIL PROTECTED]> Date: Mon, 6 Aug 2007 14:14:44 -0700 Subject: [PATCH] e1000e: New pci-express e1000 driver (currently for ICH9 devices only) This driver implements support for the ICH9 on-board LAN ethernet device. The device is similar to ICH8. The driver

Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-07 Thread Brian King
Mariusz Kozlowski wrote: Looks like memset() is zeroing wrong nr of bytes. >>> Good catch, however, I think we can just remove this memset altogether >>> since the memory gets allocated via kzalloc. >> Correct, that memset() is superfluous. > > Ok. Then this should do it. Acked-by: Brian

Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-07 Thread Evgeniy Polyakov
On Tue, Aug 07, 2007 at 10:06:29AM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: > >On Tue, Aug 07, 2007 at 09:37:41AM -0500, Steve Wise > >([EMAIL PROTECTED]) wrote: > >>+static int cma_get_tcp_port(struct rdma_id_private *id_priv) > >>+{ > >>+ int ret; > >>+ struct socket *sock; > >>+ > >>+

Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-07 Thread Steve Wise
Evgeniy Polyakov wrote: Hi Steve. On Tue, Aug 07, 2007 at 09:37:41AM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: +static int cma_get_tcp_port(struct rdma_id_private *id_priv) +{ + int ret; + struct socket *sock; + + ret = sock_create_kern(AF_INET, SOCK_STREAM, IPPROTO_TCP,

Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-07 Thread Evgeniy Polyakov
Hi Steve. On Tue, Aug 07, 2007 at 09:37:41AM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: > +static int cma_get_tcp_port(struct rdma_id_private *id_priv) > +{ > + int ret; > + struct socket *sock; > + > + ret = sock_create_kern(AF_INET, SOCK_STREAM, IPPROTO_TCP, &sock); > + if (ret

[PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-07 Thread Steve Wise
Networking experts, I'd like input on the patch below, and help in solving this bug properly. iWARP devices that support both native stack TCP and iWARP (aka RDMA over TCP/IP/Ethernet) connections on the same interface need the fix below or some similar fix to the RDMA connection manager. T

[PATCH] [iputils] Print received packets as icmp_seq

2007-08-07 Thread Alexander Graf
Now, ping and ping6 print the packets which are actually received, too, not only the amount of sent packets. It has the format: icmp_seq=received/seq Signed-off-by: Alexander Graf <[EMAIL PROTECTED]> --- ping_common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ping

[PATCH] [iputils] Print packet loss with more precision

2007-08-07 Thread Alexander Graf
Signed-off-by: Alexander Graf <[EMAIL PROTECTED]> --- ping_common.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ping_common.c b/ping_common.c index 83be553..49acab2 100644 --- a/ping_common.c +++ b/ping_common.c @@ -795,9 +795,9 @@ void finish(void) if (ne

Fw: [Bug 8845] New: Kernel 2.6.23-RC2: TCP + ICH9 + Amule + Hours = Freeze of my Debian => Reboot

2007-08-07 Thread Stephen Hemminger
Any takers? Subject: [Bug 8845] New: Kernel 2.6.23-RC2: TCP + ICH9 + Amule + Hours = Freeze of my Debian => Reboot http://bugzilla.kernel.org/show_bug.cgi?id=8845 Summary: Kernel 2.6.23-RC2: TCP + ICH9 + Amule + Hours = Freeze of my Debian => Reboot Pr

Re: fscked clock sources revisited

2007-08-07 Thread jamal
On Mon, 2007-30-07 at 22:14 -0400, jamal wrote: > I am going to test with hpet when i get the chance Couldnt figure how to turn on/off hpet, so didnt test. > and perhaps turn off all the other sources if nothing good comes out; i > need my numbers ;-> Here are some numbers that make the mystery

[RFC] stuff from tcp-2.6 partially merged to upcoming net-2.6.24?

2007-08-07 Thread Ilpo Järvinen
Hi Dave, ...Noticed you were planning to open net-2.6.24 tree... IMHO, part of the stuff in tcp-2.6 could be merged to 2.6.24. I suggest that most of the stuff which is not directly related to the rbtree, new lost marker, nor sacktag reorganization are taken. Some of those things are very trivia

Re: e100 (was: eepro100) - Nobody Cares (hardware?)

2007-08-07 Thread ericj
On Mon, 06 Aug 2007 17:45:09 -0700, Kok, Auke wrote > [moving to netdev mailinglist] > Eric, > > please don't forget that an entire team here at Intel is > dedicated to supporting e100 and pro/1000 devices from Intel. > > Most of the pro/100 features are documented in the SDM which > contains s

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-07 Thread Jarek Poplawski
On Tue, Aug 07, 2007 at 02:13:39PM +0200, Jarek Poplawski wrote: > On Tue, Aug 07, 2007 at 11:52:46AM +0200, Jarek Poplawski wrote: > > On Tue, Aug 07, 2007 at 11:37:01AM +0200, Marcin Ślusarz wrote: ... > > > No, i don't need a break. I'll have more time in next weeks. > > > > Great! So, I'll try

Re: [PATCH RFC]: napi_struct V5

2007-08-07 Thread jamal
On Sun, 2007-05-08 at 23:24 -0700, David Miller wrote: > > 3) Attempt to bring NAPI howto as uptodate as is possible for such >a rotting document. :) That doc is out of date on the split of work - it focusses mostly describing the original tulip which did not mix rx and tx in the napi_poll()

  1   2   >