Re: [REGRESSION] tg3 dead after s2ram

2007-07-31 Thread Michael Chan
On Tue, 2007-07-31 at 17:45 -0700, Andrew Morton wrote: > On Tue, 31 Jul 2007 11:28:32 +0200 "Joachim Deguara" > <[EMAIL PROTECTED]> wrote: > > > On my Acer Ferrari 1000 the tg3 ethernet no longer is available > after a > > suspend to ram with the latet 2.6.23-rc1-git9. It seems to work for me on

Re: [OOPS] 2.6.23-rc1 Seems to be network related

2007-07-31 Thread Bongani Hlope
On Wednesday 01 August 2007 03:04:07 Andrew Morton wrote: > On Wed, 1 Aug 2007 02:57:48 +0200 Bongani Hlope <[EMAIL PROTECTED]> wrote: > > I'm not sure if the first email went through, resending without .config > > attachment. > > It did come through, and I replied ;) > Thank you ;) - To unsubsc

Re: [PATCH FINAL] Merge the Sonics Silicon Backplane subsystem

2007-07-31 Thread Andrew Morton
On Sun, 29 Jul 2007 13:24:54 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > The Sonics Silicon Backplane is a mini-bus used on > various Broadcom chips and embedded devices. A few probs with mips allmodconfig: drivers/ssb/driver_mipscore.c:121: warning: "struct ssb_serial_ports" declared ins

Re: [PATCH FINAL] Merge the Sonics Silicon Backplane subsystem

2007-07-31 Thread Andrew Morton
On Sun, 29 Jul 2007 13:24:54 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > The Sonics Silicon Backplane is a mini-bus used on > various Broadcom chips and embedded devices. Sigh. s390: drivers/ssb/main.c: In function 'ssb_ssb_read16': drivers/ssb/main.c:489: error: implicit declaration of f

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-07-31 Thread Vlad Yasevich
Sorry, coming in late due to list issues... Wei Yongjun wrote: >> On Tue, 2007-07-31 at 07:37 -0400, Neil Horman wrote: >> >>> On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: >>> If SCTP data sender received a SACK which contains Cumulative TSN Ack is not less than

Re: [PATCH] net/sched: mark "NET_CLS_RSVP6 depends on IPV6"

2007-07-31 Thread rae l
On 8/1/07, Gabriel C <[EMAIL PROTECTED]> wrote: > I thought the same but ... see > > http://marc.info/?l=linux-kernel&m=118440958516205&w=2 > http://marc.info/?l=linux-netdev&m=118442747709230&w=2 That sounds good. Thanks. -- Denis - To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH] net/sched: mark "NET_CLS_RSVP6 depends on IPV6"

2007-07-31 Thread Gabriel C
Denis Cheng wrote: > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> > --- > net/sched/Kconfig |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net/sched/Kconfig b/net/sched/Kconfig > index 8a74cac..5d3749c 100644 > --- a/net/sched/Kconfig > +++ b/net/sched/Kconfig > @

[PATCH] net/sched: mark "NET_CLS_RSVP6 depends on IPV6"

2007-07-31 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- net/sched/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/sched/Kconfig b/net/sched/Kconfig index 8a74cac..5d3749c 100644 --- a/net/sched/Kconfig +++ b/net/sched/Kconfig @@ -300,6 +300,7 @@ config NET_CLS_RSVP

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-31 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 16:48:06 -0700 > I'd like to see macros added to kernel.h for: > > pr_err > pr_notice > pr_warn > pr_alert > pr_crit > pr_emerge No objections here :) - To unsubscribe from this list: send the line "

Re: Removing the prism54 module

2007-07-31 Thread Luis R. Rodriguez
On 7/28/07, Edward Ando <[EMAIL PROTECTED]> wrote: > Dear All, > I am trying to set up software suspend 2 (TuxOnIce now it seems). This > has decided it wants to remove the prism54 module before starting the > hibernate process. > > When it tries to do this, (or when I manually do: "ifconfig eth1 >

Re: [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-07-31 Thread Wei Yongjun
> On Tue, 2007-07-31 at 07:37 -0400, Neil Horman wrote: > >> On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: >> >>> If SCTP data sender received a SACK which contains Cumulative TSN Ack is >>> not less than the Cumulative TSN Ack Point, and if this Cumulative TSN >>> Ack is

Re: [OOPS] 2.6.23-rc1 Seems to be network related

2007-07-31 Thread Andrew Morton
On Wed, 1 Aug 2007 02:57:48 +0200 Bongani Hlope <[EMAIL PROTECTED]> wrote: > I'm not sure if the first email went through, resending without .config > attachment. It did come through, and I replied ;) The below post-2.6.23-rc1 patch should fix it. commit b8c1c5da1520977cb55a358f20fc09567d40cad

[OOPS] 2.6.23-rc1 Seems to be network related

2007-07-31 Thread Bongani Hlope
Hi I'm not sure if the first email went through, resending without .config attachment. I got this partial Oops on my work laptop (DELL D800), while using the linux 2.6.23-rc1 kernel. I've been using this kernel ever since it was released and this is the first and only time it did not boot. It

Re: [REGRESSION] tg3 dead after s2ram

2007-07-31 Thread Andrew Morton
On Tue, 31 Jul 2007 11:28:32 +0200 "Joachim Deguara" <[EMAIL PROTECTED]> wrote: > On my Acer Ferrari 1000 the tg3 ethernet no longer is available after a > suspend to ram with the latet 2.6.23-rc1-git9. Thanks. cc's added, body retained.. > The tg3 works fine with s2ram > in 2.6.22.1. The t

[PATCH] atl1: use spin_trylock_irqsave()

2007-07-31 Thread Jay Cliburn
From: Ingo Molnar <[EMAIL PROTECTED]> use the simpler spin_trylock_irqsave() API to get the adapter lock. [ this is also a fix for -rt where adapter->lock is a sleeping lock. ] Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-31 Thread Joe Perches
On Mon, 2007-07-30 at 16:05 -0700, David Miller wrote: > I still don't know about this patch. Instead of the simple > transformation: > > - printk(foo); > + printk(KERN_INFO foo); > > we get this new macro, and the lines changes to use that macro. Actually, I agree. Many local macros c

[OOPS] 2.6.23-rc1 Seems to be network related

2007-07-31 Thread Bongani Hlope
Hi I got this partial Oops on my work laptop (DELL D800), while using the linux 2.6.23-rc1 kernel. I've been using this kernel ever since it was released and this is the first and only time it did not boot. It was around the time it should have been trying to connect to my linksys wireless rout

Re: [2.6 patch] drivers/net/cxgb3/xgmac.c: remove dead code

2007-07-31 Thread Divy Le Ray
Adrian Bunk wrote: This patch removes dead code ("tx_xcnt" can never be != 0 at this place) spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/xgmac.c |5 + 1 file changed, 1 insertion(+)

Re: [OOPS] 2.6.23-rc1 Seems to be network related

2007-07-31 Thread Andrew Morton
On Wed, 1 Aug 2007 01:35:23 +0200 Bongani Hlope <[EMAIL PROTECTED]> wrote: > I got this partial Oops on my work laptop (DELL D800), while using the linux > 2.6.23-rc1 kernel. I've been using this kernel ever since it was released and > this is the first and only time it did not boot. It was arou

Re: [PATCH 76] drivers/net/via-velocity.c: mostly kmalloc + memset conversion to kcalloc

2007-07-31 Thread Francois Romieu
Mariusz Kozlowski <[EMAIL PROTECTED]> : > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/net/via-velocity.c | 88263 -> 88120 (-143 bytes) > drivers/net/via-velocity.o | 254264 -> 253828 (-436 bytes) > > drivers/net/via-velocity.c | 24 ++-- > 1 file chan

Re: ATA over ethernet swapping

2007-07-31 Thread Pavel Machek
Hi! > ... > > Is the protocol documented somewhere? aoe.txt only points at > > HOWTO... aha, protocol is linked from wikipedia. > > http://www.coraid.com/documents/AoEr10.txt ... perhaps that should be > > linked from aoe.txt, too? > > Perhaps. Most people reading the aoe.txt file won't need to

[PATCH 76] drivers/net/via-velocity.c: mostly kmalloc + memset conversion to kcalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/via-velocity.c | 88263 -> 88120 (-143 bytes) drivers/net/via-velocity.o | 254264 -> 253828 (-436 bytes) drivers/net/via-velocity.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) --- linux-2.6.

[PATCH 69] drivers/net/sb1250-mac.c: kmalloc + memset conversion to kcalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/sb1250-mac.c | 76286 -> 76199 (-87 bytes) drivers/net/sb1250-mac.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/net/sb1250-mac.c 2007-07-26 13:07:43.0 +0200 +++ li

[PATCH 68] drivers/net/s2io.c: kmalloc + memset conversion to k[cz]alloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/s2io.c | 235587 -> 235340 (-247 bytes) drivers/net/s2io.o | 460768 -> 460120 (-648 bytes) drivers/net/s2io.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/net/s2io.c

[PATCH 67] net/ipv4/route.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/ipv4/route.c | 75650 -> 75628 (-22 bytes) net/ipv4/route.o | 256303 -> 256467 (+164 bytes) net/ipv4/route.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.23-rc1-mm1-a/net/ipv4/route.c 2007-07-26 13:07:

[PATCH 66] net/ipv4/raw.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/ipv4/raw.c | 21650 -> 21628 (-22 bytes) net/ipv4/raw.o | 179112 -> 179272 (+160 bytes) net/ipv4/raw.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.23-rc1-mm1-a/net/ipv4/raw.c 2007-07-26 13:07:44.000

Re: [BUG] ISIC + 2.6.22 (via-rhine)

2007-07-31 Thread Xose Vazquez Perez
Arjan van de Ven wrote: = [ INFO: inconsistent lock state ] 2.6.22 #1 - inconsistent {in-hardirq-W} -> {hardirq-on-W} usage. swapper/0 [HC0[0]:SC1[1]:HE1:SE0] takes: (&rp->lock){++..}, at: [] rhine_tx_timeout+0x6f/0xf4 [via_rhine]

Re: [BUG] ISIC + 2.6.22 (via-rhine)

2007-07-31 Thread Arjan van de Ven
> = > [ INFO: inconsistent lock state ] > 2.6.22 #1 > - > inconsistent {in-hardirq-W} -> {hardirq-on-W} usage. > swapper/0 [HC0[0]:SC1[1]:HE1:SE0] takes: > (&rp->lock){++..}, at: [] rhine_tx_timeout+0x6f/0xf4 [via_rhine] this is

Re: [PATCH 39] net/ipv4/ip_options.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
> Applied, but note that this patch changes behavior, previously > only the ip_options structure base was cleared out, but now > the whole memory region is cleared. > > I think it's OK for this case, but I'm just making note of it. Agrh. Sorry. I must have overlook this. Feel free to drop it if y

[RTNETLINK]: Fix warning for !CONFIG_KMOD

2007-07-31 Thread Thomas Graf
replay label is unused otherwise. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/core/rtnetlink.c === --- net-2.6.orig/net/core/rtnetlink.c 2007-07-22 11:41:46.0 +0200 +++ net-2.6/net/core/rtnetlink.c

Re: [RTNETLINK]: Fix warning for !CONFIG_KMOD

2007-07-31 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 23:12:58 +0200 > replay label is unused otherwise. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thanks Thomas. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTEC

[NEIGH]: Combine neighbour cleanup and release

2007-07-31 Thread Thomas Graf
Introduces neigh_cleanup_and_release() to be used after a neighbour has been removed from its neighbour table. Serves as preparation to add event notifications. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/core/neighbour.c =

[NEIGH]: Netlink notifications

2007-07-31 Thread Thomas Graf
Currently neighbour event notifications are limited to update notifications and only sent if the ARP daemon is enabled. This patch extends the existing notification code by also reporting neighbours being removed due to gc or administratively and removes the dependency on the ARP daemon. This allow

[BUG] ISIC + 2.6.22 (via-rhine)

2007-07-31 Thread Xose Vazquez Perez
hi, Running ISIC -- IP Stack Integrity Checker ( http://isic.sf.net ), in Fedora-7-i386 with 2.6.22, the NIC stopped to send packages. But one second latter it began to send out more of them. dmesg shows the bug. command is: # tcpsic -s rand -d 172.26.0.2 -I100 driver is: via-rhine.c:v1.10-L

Re: [PATCH 39] net/ipv4/ip_options.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 20:16:59 +0200 > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Applied, but note that this patch changes behavior, previously only the ip_options structure base was cleared out, but now the whole memory region is cleared.

Re: [PATCH 20] net/decnet/dn_route.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 19:33:33 +0200 > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Patch applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [RESEND][PATCH 1/3] PPPoE: improved hashing routine

2007-07-31 Thread David Miller
From: Florian Zumbiehl <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 13:05:47 +0200 > A few variations I tried back when I created the patch, using larger > things than a char for accumulating the pieces and then folding down > from that, turned out to be slower than what I finally submitted, at > le

[RFC][PATCH] Get rid of dead code in net/wanrouter/wanmain.c

2007-07-31 Thread Michal Piotrowski
Hi, File /home/devel/linux-rdc/net/wanrouter/wanmain.c line 569 Unknown CONFIG option! CONFIG_WANPIPE_MULTPPP File /home/devel/linux-rdc/net/wanrouter/wanmain.c line 590 Unknown CONFIG option! CONFIG_WANPIPE_MULTPPP File /home/devel/linux-rdc/net/wanrouter/wanmain.c line 663 Unknown CONFIG option!

[RFC][PATCH] Get rid of dead code in net/ipv4/fib_semantics.c

2007-07-31 Thread Michal Piotrowski
Hi, File /home/devel/linux-rdc/net/ipv4/fib_semantics.c line 525 Unknown CONFIG option! CONFIG_IP_ROUTE_PERVASIVE Regards, Michal -- LOG http://www.stardust.webpages.pl/log/ Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> --- linux-rdc-clean/net/ipv4/fib_semantics.c2007-07-31 17:17:3

Re: [Bugme-new] [Bug 8754] New: Kernel addrconf modifies MTU of non-kernel routes

2007-07-31 Thread Simon Arlott
On 15/07/07 10:29, Simon Arlott wrote: > On 14/07/07 23:09, Andrew Morton wrote: >> On Sat, 14 Jul 2007 14:54:32 -0700 (PDT) [EMAIL PROTECTED] wrote: >>> http://bugzilla.kernel.org/show_bug.cgi?id=8754 >>> >>> I have an MTU of 16110 set on eth0 on a network where the MTU is 1500 as >>> set by >>>

[PATCH] ethtool: Add support for setting multiple rx/tx queues

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool-copy.h | 23 + ethtool.8 | 23 + ethtool.c | 103 3 files changed, 149 insertions(+), 0 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.

[PATCH] ethtool: Add LRO support

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool-copy.h |8 ethtool.8 |8 ++-- ethtool.c | 39 +-- 3 files changed, 47 insertions(+), 8 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.h index 3a63224..ab9d688 100

[PATCH] [NET] ethtool: Add support for multiple queues

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/ethtool.h | 23 +++ net/core/ethtool.c | 34 ++ 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index ab9d68

[PATCH] [NET] ethtool: Add LRO support

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/ethtool.h |8 +++ include/linux/netdevice.h |1 + net/core/ethtool.c| 54 - 3 files changed, 62 insertions(+), 1 deletions(-) diff --git a/include/linux/ethtool.h b/i

[PATCHES] RFC: Ethtool patches to add multi queue support, LRO

2007-07-31 Thread Kok, Auke
All, Recently new features have been written to add multiqueue support and LRO. However, none of the patches touch on a basic configuration scheme and most use module parameters. I propose several patches to add support to change these features for LRO and multiqueue. Currently these patche

Re: [PATCH] [NET]: fix multicast list when cloning sockets

2007-07-31 Thread Flavio Leitner
On Tue, Jul 31, 2007 at 12:00:41AM -0300, Arnaldo Carvalho de Melo wrote: > On 7/30/07, David Miller <[EMAIL PROTECTED]> wrote: > > Allowing non-datagram sockets to end up with a non-NULL inet->mc_list > > in the first place is a bug. > > > > Multicast subscriptions cannot even be used with TCP and

[PATCH 39] net/ipv4/ip_options.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/ipv4/ip_options.c | 15425 -> 15368 (-57 bytes) net/ipv4/ip_options.o | 133668 -> 133588 (-80 bytes) net/ipv4/ip_options.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) --- linux-2.6.23-rc1-mm1-a/net/ipv4/ip_options.c

Re: [PATCH 2.6.23 1/2] Make the iw_cxgb3 module parameters writable.

2007-07-31 Thread Steve Wise
Roland Dreier wrote: ugh, missed these before my last merge... anyway: why do we want to parameters writable? a good changelog tells me what, why and how, and this changelog just covered the "what". Also, I assume you've checked that it's OK for these variables to change at any time? I want

Re: RFC: on [ab]use of skb->cb by VLAN code

2007-07-31 Thread Roland Dreier
> > Do we really need an 'unsigned int' for mac_len? Maybe we could use > > a 16-bit counter here, and then use the other 16 bits for the VLAN bits? > > Not knowing exactly if/how it interacts with that specific field I > will point-out that IPoIB in OFED 1.2 just took their MTU to 65520. >

[PATCH 20] net/decnet/dn_route.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/decnet/dn_route.c | 45013 -> 44991 (-22 bytes) net/decnet/dn_route.o | 199388 -> 199580 (+192 bytes) net/decnet/dn_route.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.23-rc1-mm1-a/net/decnet/dn_route.c

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-07-31 Thread Sridhar Samudrala
On Tue, 2007-07-31 at 07:37 -0400, Neil Horman wrote: > On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: > > If SCTP data sender received a SACK which contains Cumulative TSN Ack is > > not less than the Cumulative TSN Ack Point, and if this Cumulative TSN > > Ack is not used by the d

Re: RFC: on [ab]use of skb->cb by VLAN code

2007-07-31 Thread Rick Jones
Do we really need an 'unsigned int' for mac_len? Maybe we could use a 16-bit counter here, and then use the other 16 bits for the VLAN bits? Not knowing exactly if/how it interacts with that specific field I will point-out that IPoIB in OFED 1.2 just took their MTU to 65520. While that doesn

Disabling timestamps on AF_PACKET sockets

2007-07-31 Thread Unai Uribarri
Hello, I want to capture huge amounts of packets without timestamps, since the machine the program is running on has a very slow clock that only yields 200,000 timestamps per second and uses 70% of CPU. But tpacket_rcv reenables the timestamps every time it receives a packet at af_packet.c:643 if

Re: [patch] genirq: temporary fix for level-triggered IRQ resend

2007-07-31 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > Linus, > > with -rc2 approaching i think we should apply the minimal fix below to > get Marcin's ne2k-pci networking back in working order. The > WARN_ON_ONCE() will not prevent the system from working and it will be > a reminder. there's one more t

Re: [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows

2007-07-31 Thread Ilpo Järvinen
On Tue, 31 Jul 2007, Stephen Hemminger wrote: > I noticed no difference in the two flow tests. That is not a bad thing, just > that this test doesn't hit that code. ...I'm not too sure about your test setup but the bugs I fixed only cover cases that occur if flow is bidirectional (and obviously

[patch] genirq: temporary fix for level-triggered IRQ resend

2007-07-31 Thread Ingo Molnar
Linus, with -rc2 approaching i think we should apply the minimal fix below to get Marcin's ne2k-pci networking back in working order. The WARN_ON_ONCE() will not prevent the system from working and it will be a reminder. a better workaround would be to inhibit the resent vector via the IO-AP

Re: [TULIP] Need new maintainer

2007-07-31 Thread Grant Grundler
On Mon, Jul 30, 2007 at 03:31:58PM -0400, Kyle McMartin wrote: > On Mon, Jul 30, 2007 at 01:04:13PM -0600, Valerie Henson wrote: > > The Tulip network driver needs a new maintainer! I no longer have > > time to maintain the Tulip network driver and I'm stepping down. Jeff > > Garzik would be happ

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Gabriel C
Jarek Poplawski wrote: > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: >> Jarek Poplawski wrote: >>> On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: > On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> I got this c

Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-31 Thread Or Gerlitz
Michael S. Tsirkin wrote: Quoting Or Gerlitz <[EMAIL PROTECTED]>: Michael S. Tsirkin wrote: It's always wrong to copy symbols from another module without referencing it. Its the --first-- time you make this comment, It's really a well known fact. That's where the crash with modprobe -r com

[PATCH] Trivial Kconfig fact correction

2007-07-31 Thread Erik Ekman
[PATCH] Trivial Kconfig fact correction This error seems to have been in the kernel for a long time. Signed-off-by: Erik Ekman <[EMAIL PROTECTED]> --- orig/drivers/net/wireless/Kconfig 2007-07-23 10:01:46.0 +0200 +++ edit/drivers/net/wireless/Kconfig 2007-07-31 16:47:26.0 +02

Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-31 Thread Michael S. Tsirkin
> Quoting Or Gerlitz <[EMAIL PROTECTED]>: > Subject: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for?the?bonding > driver > > Michael S. Tsirkin wrote: > >>Quoting Or Gerlitz <[EMAIL PROTECTED]>: > > >>To be precise, bonding will copy all the symbols it copies today from > >>the slave mod

Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-31 Thread Or Gerlitz
Michael S. Tsirkin wrote: Quoting Or Gerlitz <[EMAIL PROTECTED]>: To be precise, bonding will copy all the symbols it copies today from the slave module (ipoib), see bond_setup_by_slave() in patch 3/7 Not really. This copying of symbols is something that you added, isn't it? So with this ap

Re: [ofa-general] Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-31 Thread Or Gerlitz
Michael S. Tsirkin wrote: Maybe we could use hard_header_cache/header_cache_update methods instead of neighbour cleanup calls. To do this, it is possible that we'll have to switch from storing pointers inside the neighbour to keeping an index there, but I expect the performance impact to be mi

Re: Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-31 Thread Michael S. Tsirkin
> Quoting Or Gerlitz <[EMAIL PROTECTED]>: > Subject: Re: Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for?the > bonding driver > > Michael S. Tsirkin wrote: > >Maybe we could use hard_header_cache/header_cache_update methods instead of > >neighbour cleanup calls. > > >To do this, it is

Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-31 Thread Michael S. Tsirkin
> Quoting Moni Shoua <[EMAIL PROTECTED]>: > Subject: Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for?the > bonding driver > > Roland Dreier wrote: > > > 1. When bonding enslaves an IPoIB device the bonding neighbor holds a > > > reference to a cleanup function in the IPoIB drives. Th

Re: [PATCH]: Fix sk_buff page offsets and lengths.

2007-07-31 Thread Evgeniy Polyakov
On Tue, Jul 31, 2007 at 01:23:29PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Tue, Jul 31, 2007 at 02:20:51PM +0400, Evgeniy Polyakov wrote: > > On Mon, Jul 30, 2007 at 06:50:28PM -0700, David Miller ([EMAIL PROTECTED]) > > wrote: > > > > > > Stephen Rothwell pointed out to me that

Re: [ofa-general] Re: [PATCH V3 7/7] net/bonding: Delay sending of gratuitous ARP to avoid failure

2007-07-31 Thread Moni Shoua
Jay Vosburgh wrote: > Moni Shoua <[EMAIL PROTECTED]> wrote: > >> Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit >> in dev->state field is on. This improves the chances for the arp packet to >> be transmitted. > > Under what circumstances were you seeing problems that d

Re: [ofa-general] Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver

2007-07-31 Thread Moni Shoua
Roland Dreier wrote: > > 1. When bonding enslaves an IPoIB device the bonding neighbor holds a > > reference to a cleanup function in the IPoIB drives. This makes it unsafe > to > > unload the IPoIB module if there are bonding neighbors in the air. So, to > > avoid this race one must unload

Re: [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows

2007-07-31 Thread Stephen Hemminger
I noticed no difference in the two flow tests. That is not a bad thing, just that this test doesn't hit that code. The anomaly is that first flow does slow start then gets loss and ends up reducing it's window size all the way to the bottom, finally it recovers. This happens with Cubic, H-TCP and

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-31 Thread Andrew Gallatin
Jan-Bernd Themann wrote: On Monday 30 July 2007 22:32, Andrew Gallatin wrote: Second, you still need to set skb->ip_summed = CHECKSUM_UNNECESSARY when modified packets are flushed, else the stack will see bad checksums for packets from CHECKSUM_COMPLETE drivers using the skb interface. Fixed

Re: 2.6.20->2.6.21 - networking dies after random time

2007-07-31 Thread Jarek Poplawski
On Mon, Jul 30, 2007 at 09:29:38AM +0200, Marcin Ślusarz wrote: ... > ps: I retested all patches posted in this thread on top of 2.6.22.1 > and behavior from 2.6.21.3 didn't changed. My next tests will be on > 2.6.22.x only. Marcin, I see you're quite busy, but if after testing this next Ingo's p

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 06:44:52AM -0500, Jason Wessel wrote: ... > kgdboe is completely useless without a network card that has a polling > driver. It seems to me that the simple and easy fix is to set it to > depend on NETDEVICES but allow it to use select on NETPOLL. Maybe I miss your point

Re: [PATCH]: Fix sk_buff page offsets and lengths.

2007-07-31 Thread Christoph Hellwig
On Tue, Jul 31, 2007 at 02:20:51PM +0400, Evgeniy Polyakov wrote: > On Mon, Jul 30, 2007 at 06:50:28PM -0700, David Miller ([EMAIL PROTECTED]) > wrote: > > > > Stephen Rothwell pointed out to me that the skb_frag_struct > > is broken on platforms using 64K or larger page sizes, it > > even genera

Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support

2007-07-31 Thread Joakim Koskela
On Tuesday 31 July 2007 14:14:30 Patrick McHardy wrote: > Joakim Koskela wrote: > > Ok, so changing int xfrm[46]_output(struct sk_buff*) to use the right PF > > & hook based on the skb's [current] family should put things through the > > right hoops, right? > > Almost, in xfrm4_output the condition

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > Jarek Poplawski wrote: > > On 28-07-2007 20:42, Gabriel C wrote: > >> Andrew Morton wrote: > >>> On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > >>> > Hi, > > I got this compile error with a randco

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jason Wessel
Gabriel C wrote: Jarek Poplawski wrote: On 28-07-2007 20:42, Gabriel C wrote: Andrew Morton wrote: On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.b

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-07-31 Thread Neil Horman
On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: > If SCTP data sender received a SACK which contains Cumulative TSN Ack is > not less than the Cumulative TSN Ack Point, and if this Cumulative TSN > Ack is not used by the data sender, SCTP data sender still accept this > SACK , and n

Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support

2007-07-31 Thread Patrick McHardy
Joakim Koskela wrote: > On Tuesday 31 July 2007 13:51:42 Patrick McHardy wrote: > >>Joakim Koskela wrote: >> >>>I'm not sure I really got this. IPv6/IPv4 means IPv6 inner, IPv4 outer, >>>right? Isn't that called from xfrm4_output_one and subsequently passed >>>through the right filters as well (as

Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support

2007-07-31 Thread Joakim Koskela
On Tuesday 31 July 2007 13:51:42 Patrick McHardy wrote: > Joakim Koskela wrote: > > I'm not sure I really got this. IPv6/IPv4 means IPv6 inner, IPv4 outer, > > right? Isn't that called from xfrm4_output_one and subsequently passed > > through the right filters as well (as it has a ipv4 header by th

Re: [RESEND][PATCH 1/3] PPPoE: improved hashing routine

2007-07-31 Thread Florian Zumbiehl
Hi, > > > Actually it might be simpler and more efficient to just make > > > PPPOE_HASH_SHIFT be 8. > > > > SHIFT? SIZE? BITS? > > You know what I meant :-) > > PPPOE_HASH_BITS. Actually, I wasn't sure, for "SHIFT" looks more similar to "SIZE" than to "BITS", plus numbers are somewhat same ord

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-31 Thread Jan-Bernd Themann
Hi, Thanks for finding these bugs! I'll post an updated version soon (2 patches with no separate Kconfig patches, one LRO and one eHEA patch). See comments below. Thanks, Jan-Bernd On Monday 30 July 2007 22:32, Andrew Gallatin wrote: > I was working on testing the myri10ge patch, and I ran into

Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support

2007-07-31 Thread Patrick McHardy
Joakim Koskela wrote: > On Thursday 19 July 2007 17:46:42 Patrick McHardy wrote: > >>Joakim Koskela wrote: >> >>>+skb_push(skb, hdrlen); >>>+iphv6 = ipv6_hdr(skb); >>>+ >>>+skb_reset_network_header(skb); >>>+top_iphv6 = ipv6_hdr(skb); >>>+ >>>+

Re: [PATCH 1/7] Preparatory refactoring part 1.

2007-07-31 Thread Patrick McHardy
Corey Hickey wrote: > Patrick McHardy wrote: > >>> -static int >>> -sfq_enqueue(struct sk_buff *skb, struct Qdisc* sch) >>> +static void sfq_q_enqueue(struct sk_buff *skb, struct sfq_sched_data >>> *q, unsigned int end) >> >> >> >> Please make sure to break at 80 chars and to keep the style >> in

Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support

2007-07-31 Thread Joakim Koskela
On Thursday 19 July 2007 17:46:42 Patrick McHardy wrote: > Joakim Koskela wrote: > > + skb_push(skb, hdrlen); > > + iphv6 = ipv6_hdr(skb); > > + > > + skb_reset_network_header(skb); > > + top_iphv6 = ipv6_hdr(skb); > > + > > + protocol = iphv6->next

Re: [PATCH]: Fix sk_buff page offsets and lengths.

2007-07-31 Thread Evgeniy Polyakov
On Mon, Jul 30, 2007 at 06:50:28PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > > Stephen Rothwell pointed out to me that the skb_frag_struct > is broken on platforms using 64K or larger page sizes, it > even generates warnings when (for example) the myri10ge driver > tries to assign PAGE_SIZ

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Gabriel C
Jarek Poplawski wrote: > On 28-07-2007 20:42, Gabriel C wrote: >> Andrew Morton wrote: >>> On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: >>> Hi, I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c

Scatter gather and TCP MD5

2007-07-31 Thread Siddharth Taneja
Hello, I am using a vanilla 2.6.22.1 kernel and I see the same kind of problem as had been mentioned some time back on this list http://lkml.org/lkml/2007/5/22/45 The issue is essentially that with the MD5 option enabled for the specific TCP connection, the SYN and SYN-ACKS are passed ok and the

Re: [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows

2007-07-31 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 10:51:13 +0100 > On Mon, 30 Jul 2007 22:21:12 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > > Date: Tue, 31 Jul 2007 07:59:10 +0300 (EEST) > > > > > I think it's probably

Re: [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows

2007-07-31 Thread Stephen Hemminger
On Mon, 30 Jul 2007 22:21:12 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Tue, 31 Jul 2007 07:59:10 +0300 (EEST) > > > I think it's probably good to add tp->snd_una != prior_snd_una > > check there too... It's not going to make a large di

Re: [RESEND][PATCH 1/3] PPPoE: improved hashing routine

2007-07-31 Thread David Miller
From: Florian Zumbiehl <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 11:01:59 +0200 > Assuming that it was supposed to read s/head/hash/: Same disclaimers > apply, but I'd say this considers only addr&0xff0fff0f000f and > sid&0x0fff, so, well, yes, it's better, but still not quite what I > think it s

Re: [IPSEC]: Ensure that state inner family is set

2007-07-31 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 16:53:56 +0800 > Hi Dave: > > [IPSEC]: Ensure that state inner family is set > > Similar to the issue we had with template families which > specified the inner families of policies, we need to set > the inner families of states as the m

Re: [RESEND][PATCH 1/3] PPPoE: improved hashing routine

2007-07-31 Thread Florian Zumbiehl
Hi, > > Erm, I'd say this not only produces different results than the old > > version, but it also produces "wrong" results, in that it ignores quite > > a bit of the data that's supposed to be hashed. If I didn't overlook > > something, it only considers addr&0x0f0f0f0f0f00 and sid&0x0f0f, given

Re: [RESEND][PATCH 1/3] PPPoE: improved hashing routine

2007-07-31 Thread Florian Zumbiehl
Hi, > > -static int hash_item(unsigned long sid, unsigned char *addr) > > +#if 8%PPPOE_HASH_BITS > > +#error 8 must be a multiple of PPPOE_HASH_BITS > > +#endif > > Since PPPOE_HASH_BITS is "4" I would think this check will break the > build. :-) Erm, I thought that 8 was 4*2, but maybe I didn't

[IPSEC]: Ensure that state inner family is set

2007-07-31 Thread Herbert Xu
Hi Dave: [IPSEC]: Ensure that state inner family is set Similar to the issue we had with template families which specified the inner families of policies, we need to set the inner families of states as the main xfrm user Openswan leaves it as zero. af_key is unaffected because the inner family i

Re: zd1211rw and mac80211: multicast/v6 doesn't work in 2.6.21.5

2007-07-31 Thread Pekka Savola
FWIW, multicast/v6 is still broken on zd1211rw on 2.6.22.1 based Fedora 7 kernel (2.6.22.1-33.fc7). On Thu, 28 Jun 2007, Pekka Savola wrote: On Fedora 7 (kernel 2.6.21-1.3228.fc7, based on 2.6.21.5), my zd1211rw_mac80211 WLAN USB stick and multicast/v6 no longer works. On Fedora 6 (kernel 2.

Re: [RESEND][PATCH 1/3] PPPoE: improved hashing routine

2007-07-31 Thread David Miller
From: Florian Zumbiehl <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 10:07:19 +0200 > Erm, I'd say this not only produces different results than the old > version, but it also produces "wrong" results, in that it ignores quite > a bit of the data that's supposed to be hashed. If I didn't overlook > s

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-07-31 Thread Jarek Poplawski
On 28-07-2007 20:42, Gabriel C wrote: > Andrew Morton wrote: >> On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: >> >>> Hi, >>> >>> I got this compile error with a randconfig ( >>> http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). >>> >>> ... >>> >>> net/core/

Re: [PATCH 2/7] Preparatory refactoring part 2.

2007-07-31 Thread Corey Hickey
Patrick McHardy wrote: Corey Hickey wrote: diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c index 8ae077f..0c46938 100644 --- a/net/sched/sch_sfq.c +++ b/net/sched/sch_sfq.c @@ -380,71 +380,71 @@ static void sfq_perturbation(unsigned long arg) } } -static int sfq_change(struct Q

Re: [PATCH 6/7] Make qdisc changeable.

2007-07-31 Thread Corey Hickey
Patrick McHardy wrote: Corey Hickey wrote: Re-implement sfq_change() and enable Qdisc_opts.change so "tc qdisc change" will work. Signed-off-by: Corey Hickey <[EMAIL PROTECTED]> --- net/sched/sch_sfq.c | 51 ++- 1 files changed, 50 insertions(+