Hi,
here another patch for the PPPoX/E code that makes sure that ENOTTY is
returned for unknown ioctl requests rather than 0 (and removes another
unneeded initializer which I didn't bother creating a separate patch for).
Florian
---
Hi,
and the last one for now: Acquire the sock lock in pppoe_sendmsg()
before accessing the sock - and in particular avoid releasing the lock
even though it hasn't been acquired.
Florian
---
Signed-off-by: Florian Zumbiehl <
Hi,
I'm not sure whether this is really worth it, but it looked so
extremely inefficient that I couldn't resist - so let's hope providers
will keep PPPoE around for a while, at least until terabit dsl ;-)
The new code produces the same results as the old version and is
~ 3 to 6 times faster for 4
On Sun, 29 Jul 2007, Domen Puncer wrote:
> On 29/07/07 00:02 +0200, Jesper Juhl wrote:
> > Hi,
> >
> > Here's a small patch, prompted by a find by the Coverity checker,
> > that removes a potential NULL pointer dereference from
> > drivers/net/sb1000.c::sb1000_dev_ioctl().
> > The checker spo
From: Krzysztof Halasa <[EMAIL PROTECTED]>
Date: Sun, 29 Jul 2007 00:25:07 +0200
> I wonder if it's dev_kfree_skb_irq() which should but fails to wake
> the thing up?
Software interrupts might be getting lost, dev_kfree_skb_irq() has to
queue the kfree_skb() to soft IRQ.
Therefore, dev_kfree_skb
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Sat, 28 Jul 2007 14:08:44 -0400
> That's a performance/parallelization regression from current NAPI :(
That's not true since current NAPI will only run on one cpu, the
one that the interrupt triggers on.
The existing cases that are not guarding the seq
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Sat, 28 Jul 2007 08:27:18 -0700
> > Most drivers are in good shape, although some still have very
> > questionable netif_rx_complete() handling, in that racy area that
> > Rusty and myself were discussing today.
> >
> > My inclination is to wrap
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Sat, 28 Jul 2007 08:21:58 -0700
> > Another area of consternation are drivers that were using
> > netif_rx_reschedule(), as that interface was removed because it
> > doesn't fit well with the caller managing the dev->quota et al. I
> > left race c
On 29/07/07 00:02 +0200, Jesper Juhl wrote:
> Hi,
>
> Here's a small patch, prompted by a find by the Coverity checker,
> that removes a potential NULL pointer dereference from
> drivers/net/sb1000.c::sb1000_dev_ioctl().
> The checker spotted that we do a NULL test of 'dev', yet we
> dereferenc
On Friday 27 July 2007 16:12, Andrew Morton wrote:
> On Fri, 27 Jul 2007 21:43:59 +0200
> Michael Buesch <[EMAIL PROTECTED]> wrote:
>
> > > Sure, but why is the locking interruptible rather than plain old
> > > mutex_lock()?
> >
> > Hm, well. We hold this mutex for several seconds, as writing tak
thanks, applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 27 July 2007, Michal Piotrowski wrote:
> IDE
>
> Subject : ide problems: 2.6.22-git17 working, 2.6.23-rc1* is not
> References : http://lkml.org/lkml/2007/7/27/298
> Last known good : ?
> Submitter : dth <[EMAIL PROTECTED]>
> Caused-By : ?
> Handled-By : ?
On 29/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> Hi,
>
> On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > Hello,
> >
> > This patch makes sure we don't dereference a NULL pointer in
> > drivers/net/usb/pegasus.c::write_bulk_callback() in the initial
> > struct net_device *net = pegasus
Hi,
On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> Hello,
>
> This patch makes sure we don't dereference a NULL pointer in
> drivers/net/usb/pegasus.c::write_bulk_callback() in the initial
> struct net_device *net = pegasus->net; assignment.
> The existing code checks if 'pegasus' is NULL an
Hi,
I have noticed an unexpected behaviour of a userland program sending
packets with AF_PACKET through a network device driver. The problem
is that the userland program waits on sock_wait_for_wmem() for a long
time even if the transmitter is ready and all skb packets have been
transmitted and fre
Hello,
This patch makes sure we don't dereference a NULL pointer in
drivers/net/usb/pegasus.c::write_bulk_callback() in the initial
struct net_device *net = pegasus->net; assignment.
The existing code checks if 'pegasus' is NULL and bails out if
it is, so we better not touch that pointer until
Andrew Morton wrote:
> On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote:
>
>> Hi,
>>
>> I got this compile error with a randconfig (
>> http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ).
>>
>> ...
>>
>> net/core/netpoll.c: In function 'netpoll_poll':
>> net/cor
Jeff Garzik wrote:
Andi Kleen wrote:
"Kok, Auke" <[EMAIL PROTECTED]> writes:
* Removed all multi-queue code
Why? With David's new multi NAPI work it will finally make sense, won't it?
It will come back, most definitely.
Not speaking for Auke, but I'm pretty sure this falls under the catego
David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Wed, 25 Jul 2007 22:00:31 -0400
David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Wed, 25 Jul 2007 21:55:08 -0400
I don't see any logic to your request, only added overhead for no reason.
There may be some flawed
Andi Kleen wrote:
"Kok, Auke" <[EMAIL PROTECTED]> writes:
* Removed all multi-queue code
Why? With David's new multi NAPI work it will finally make sense, won't it?
It will come back, most definitely.
Not speaking for Auke, but I'm pretty sure this falls under the category
of "start small
On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I got this compile error with a randconfig (
> http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ).
>
> ...
>
> net/core/netpoll.c: In function 'netpoll_poll':
> net/core/netpoll.c:155: error: 'struct
Hallo,
I tried suspend to RAM on my desktop. Surprisingly near everything worked
after the wakeup, except for the pcnet32 PCI card. Kernel is 2.6.23-rc1-git4
on x86_64.
Bootup:
pcnet32.c:v1.33-NAPI 27.Jun.2006 [EMAIL PROTECTED]
IOAPIC[0]: Set routing entry (2-21 -> 0x81 -> IRQ 21 Mode:1 Active:
Dear All,
I am trying to set up software suspend 2 (TuxOnIce now it seems). This
has decided it wants to remove the prism54 module before starting the
hibernate process.
When it tries to do this, (or when I manually do: "ifconfig eth1
down"), I start getting these messages on all terminals, ad inf
When application closes socket with unread data in receive buffer, tcp
stack sends rst packet from the wrong source port, not the source port
of the socket being closed.
This is the same problem that was described in my first post, witch
unfortunately nobody cared to look into.
This problem
Hi,
I got this compile error with a randconfig (
http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ).
...
net/core/netpoll.c: In function 'netpoll_poll':
net/core/netpoll.c:155: error: 'struct net_device' has no member named
'poll_controller'
net/core/netpoll.c:159: error: 'struct
> Most drivers are in good shape, although some still have very
> questionable netif_rx_complete() handling, in that racy area that
> Rusty and myself were discussing today.
>
> My inclination is to wrap those sequences around with an IRQ
> safe spinlock to fix the race provably, and then if
I've been on vacation so I missed most of this thread. I'm just
catching up now...
> Ok I converted everything with Rusty's suggestion to move napi_struct
> out of net_device, this was mostly mechanical but some devices took
> some unanticipated amount of work.
Actually you missed drivers/inf
"Kok, Auke" <[EMAIL PROTECTED]> writes:
> * Removed all multi-queue code
Why? With David's new multi NAPI work it will finally make sense, won't it?
-Andi (who would finally like to see a driver which is able to process
incoming packets and TX completion interrupts on multiple CPUs)
-
To unsub
28 matches
Mail list logo
