Re: [NET]: gen_estimator deadlock fix

2007-07-15 Thread Jarek Poplawski
On Fri, Jul 13, 2007 at 03:42:31PM +0200, Jarek Poplawski wrote: ... > On Fri, Jul 13, 2007 at 03:26:42PM +0300, Ranko Zivojnovic wrote: > I've been a bit tight on time today, and only now I see that maybe > you have done too much. Of course, you can do it your way, but I > think it should be easie

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-07-15 Thread Oliver Hartkopp
Original-Message Subject: Re: [patch 5/7] CAN: Add virtual CAN netdevice driver Date: Thu, 12 Jul 2007 00:52:58 +0200 From: Patrick McHardy <[EMAIL PROTECTED]> To: Oliver Hartkopp <[EMAIL PROTECTED]> Patrick McHardy wrote: > Oliver Hartkopp wrote: > >> Hi Patrick, >> >> what's

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-15 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sun, 15 Jul 2007 16:21:13 +0200 > This one is a regression in 2.6.22, so the patch should also go > in -stable IMO. I have it queued up for submission to -stable. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 16:01, Bryan Wu wrote: > drivers/net/e100.c: ns->tx_window_errors += > le32_to_cpu(s->tx_late_collisions); > drivers/net/e100.c: ns->tx_carrier_errors += > le32_to_cpu(s->tx_lost_crs); > drivers/net/e100.c: ns->tx_fifo_errors += > le32_

[PATCH 3/3] forcedeth bug fix: realtek phy

2007-07-15 Thread Ayaz Abdulla
This patch contains errata fixes for the realtek phy. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2007-07-15 06:31:00.0 -0400 +++ new/drivers/net/forcedeth.c 2007-07-15 06:40:29.0 -0400 @@ -551,6 +551,7 @@ #define PHY_OUI_MARVELL0x504

[PATCH 2/3] forcedeth bug fix: vitesse phy

2007-07-15 Thread Ayaz Abdulla
This patch contains errata fixes for the vitesse phy. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2007-07-15 06:25:01.0 -0400 +++ new/drivers/net/forcedeth.c 2007-07-15 06:29:38.0 -0400 @@ -550,6 +550,7 @@ /* PHY defines */ #define PHY_OUI_MA

[PATCH 1/3] forcedeth bug fix: cicada phy

2007-07-15 Thread Ayaz Abdulla
This patch contains errata fixes for the cicada phy. It only renamed the defines to be phy specific. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers/net/forcedeth.c 2007-07-15 06:20:14.0 -0400 +++ new/drivers/net/forcedeth.c 2007-07-15 06:24:20.0 -0400 @@ -557,12

Re: [Bugme-new] [Bug 8755] New: "ip -6 route change " behaves like "ip -6 route add"

2007-07-15 Thread Simon Arlott
On 15/07/07 16:07, Patrick McHardy wrote: >>>Changing an existing route: >>># ip -6 r show 2002::/16 >>>2002::/16 dev sit0 metric 1024 expires 4482618sec mtu 1480 advmss 7140 >>>hoplimit 4294967295 >>># ip -6 r change 2002::/16 dev sit0 mtu 1280 >>>RTNETLINK answers: File exists ^ This is clearly

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Robert Hancock
Bryan Wu wrote: On Sun, 2007-07-15 at 14:17 +0200, Michael Buesch wrote: On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: @@ -483,9 +487,12 @@ void setup_mac_addr(u8 * mac_addr) { + u32 addr_low = le32_to_cpu(*(u32 *) & mac_addr[0]); + u16 addr_hi = le16_to_cpu(*(u16 *) & mac_ad

[PATCH try#3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. [try#2] - add timeout control - kill dma_config_reg bitfields - some trivial cleanup [try#3] - add endianess check - add DRV_NAME, DRV_VERSION... driver information string

[PATCH 3/5] atl1: cleanup atl1_main

2007-07-15 Thread Jay Cliburn
Fix indentation, remove dead code, improve some comments, change dev_dbg to dev_printk. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c | 278 +- 1 files changed, 137 insertions(+), 141 deletions(-) diff --git a/drivers/net

[PATCH 2/5] atl1: header file cleanup

2007-07-15 Thread Jay Cliburn
Remove unused structure members, improve comments, break long comment lines, rename a constant to be consistent with others in the file. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1.h | 155 ++ drivers/net/atl1/atl1_main.c

[PATCH 1/5] atl1: remove irq_sem

2007-07-15 Thread Jay Cliburn
Remove unnecessary irq_sem code. Signed-off-by: Chris Snook <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1.h |1 - drivers/net/atl1/atl1_main.c |6 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/atl1/atl

[PATCH 4/5] atl1: fix excessively indented code

2007-07-15 Thread Jay Cliburn
Move excessively indented code to separate functions. Also move ring pointer initialization to its own function. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c | 86 - 1 files changed, 50 insertions(+), 36 deletions(-) d

[PATCH 0/5] atl1: miscellaneous cleanup and code reorganization

2007-07-15 Thread Jay Cliburn
Please accept the following patches for the atl1 driver. atl1: remove irq_sem atl1: header file cleanup atl1: cleanup atl1_main atl1: fix excessively indented code atl1: reorder atl1_main functions drivers/net/atl1/atl1.h | 156 ++-- drivers/net/atl1/atl1_main.c | 2176

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 09:12 -0400, Dan Williams wrote: > On Sun, 2007-07-15 at 02:49 +0800, Bryan Wu wrote: > > This patch implements the driver necessary use the Analog Devices > > Blackfin processor's on-chip ethernet MAC controller. > > > > - clean up coding style issues by Jeff's review > > >

Re: [Bugme-new] [Bug 8755] New: "ip -6 route change " behaves like "ip -6 route add"

2007-07-15 Thread Patrick McHardy
Andrew Morton wrote: > On Sat, 14 Jul 2007 15:21:21 -0700 (PDT) [EMAIL PROTECTED] wrote: > >>The "ip -6 route change" command behaves as though "ip -6 route add" was used. >>The source of iproute2 shows that "change" uses the "NLM_F_REPLACE" netlink >>flag only. >> >>ip utility, iproute2-ss070313

Re: IPSec freeze

2007-07-15 Thread Patrick McHardy
Beschorner Daniel wrote: > Today a new site joined our Linux IPSec VPN, now all the other routers > (all 2.6.22) freeze hard reproducible. Do the other routers all do IPsec or just one of them? > No oops, no sysreq, only hard reset rewakes them. > > The only difference of the new site compared

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-15 Thread Patrick McHardy
David Miller wrote: > From: Ranko Zivojnovic <[EMAIL PROTECTED]> > Date: Sat, 14 Jul 2007 19:45:35 +0300 > > Please try reverting commit 1936502d00ae6c2aa3931c42f6cf54afaba094f2, that should fix it. >>> >>> >>>Ranko, did you get a chance to test this? I've attached the patch >>>since it d

[PATCH v2 2/2] mac80211: implement ERP info change notifications

2007-07-15 Thread Daniel Drake
zd1211rw and bcm43xx are interested in being notified when ERP IE conditions change, so that they can reprogram a register which affects how control frames are transmitted. This patch adds an interface similar to the one that can be found in softmac. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]

[PATCH v2 1/2] mac80211: improved short preamble handling

2007-07-15 Thread Daniel Drake
Similarly to CTS protection, whether short preambles are used for 802.11b transmissions should be a per-subif setting, not device global. For STAs, this patch makes short preamble handling automatic based on the ERP IE. For APs, hostapd still uses the prism ioctls, but the write ioctl has been res

[PATCH v2] mac80211: STA reassociation improvements

2007-07-15 Thread Daniel Drake
My cheapy D-Link AP behaves strangely w.r.t reassociations. The following sequence of commands causes me to lose association and to be unable to regain it: ifconfig eth8 down ifconfig eth8 up iwconfig eth8 essid This is because mac80211 tries to reassociate, rather than

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 14:17 +0200, Michael Buesch wrote: > On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: > > @@ -483,9 +487,12 @@ > > > > void setup_mac_addr(u8 * mac_addr) > > { > > + u32 addr_low = le32_to_cpu(*(u32 *) & mac_addr[0]); > > + u16 addr_hi = le16_to_cpu(*(u16 *) & mac_addr[

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 09:04 -0400, Dan Williams wrote: > On Sat, 2007-07-14 at 16:38 -0400, Mike Frysinger wrote: > > On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > > > On Saturday 14 July 2007 21:49:21 Mike Frysinger wrote: > > > > On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > >

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Dan Williams
On Sun, 2007-07-15 at 02:49 +0800, Bryan Wu wrote: > This patch implements the driver necessary use the Analog Devices > Blackfin processor's on-chip ethernet MAC controller. > > - clean up coding style issues by Jeff's review > > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> > Cc: Jeff Garzik <[EM

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Dan Williams
On Sat, 2007-07-14 at 16:38 -0400, Mike Frysinger wrote: > On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > > On Saturday 14 July 2007 21:49:21 Mike Frysinger wrote: > > > On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > > > > On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > > > >

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: > @@ -483,9 +487,12 @@ > > void setup_mac_addr(u8 * mac_addr) > { > + u32 addr_low = le32_to_cpu(*(u32 *) & mac_addr[0]); > + u16 addr_hi = le16_to_cpu(*(u16 *) & mac_addr[4]); > + > /* this depends on a little-endian machine */ > -

[2.6 patch] ipt_iprange.h must #include

2007-07-15 Thread Adrian Bunk
ipt_iprange.h must #include since it uses __be32. This patch fixes kernel Bugzilla #7604. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.22-rc6-mm1/include/linux/netfilter_ipv4/ipt_iprange.h.old 2007-07-15 13:07:40.0 +0200 +++ linux-2.6.22-rc6-mm1/include/linux/netfil

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 11:53 +0100, Christoph Hellwig wrote: > On Sun, Jul 15, 2007 at 12:36:51PM +0200, Michael Buesch wrote: > > On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) >

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 12:36 +0200, Michael Buesch wrote: > On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) > > +#

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Christoph Hellwig
On Sun, Jul 15, 2007 at 12:36:51PM +0200, Michael Buesch wrote: > On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr)

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > +#if defined(CONFIG_BFIN_MAC_USE_L1) > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) > +#else > +# define bfin_mac_alloc(dma_handle, size) \ > + dma_al

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sun, 2007-07-15 at 11:36 +0200, Michael Buesch wrote: > On Sunday 15 July 2007 11:16:56 Bryan Wu wrote: > > In current Blackfin DMA allocation/free, the return value from > > bfin_mac_alloc() is used as the dma_handle, here it is the > > tx_desc/rx_desc. > > The "dma_handle" is useless in the

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-15 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sun, 15 Jul 2007 10:12:53 +0100 > I'm not sure that's a good idea. If current chips can't handle ipv6 > lro there is no way to actually test it and the code will surely bitrot. Christoph, you can do LRO pretty much completely in software. - To u

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 11:16:56 Bryan Wu wrote: > In current Blackfin DMA allocation/free, the return value from > bfin_mac_alloc() is used as the dma_handle, here it is the > tx_desc/rx_desc. > The "dma_handle" is useless in the following code. I think a comment has to be added, at least, as it

Re: [Bugme-new] [Bug 8754] New: Kernel addrconf modifies MTU of non-kernel routes

2007-07-15 Thread Simon Arlott
On 14/07/07 23:09, Andrew Morton wrote: > On Sat, 14 Jul 2007 14:54:32 -0700 (PDT) [EMAIL PROTECTED] wrote: >> http://bugzilla.kernel.org/show_bug.cgi?id=8754 >> >> I have an MTU of 16110 set on eth0 on a network where the MTU is 1500 as set >> by >> RAs. One of the other hosts on the network has

Re: [2.6 patch] more ACSI removal

2007-07-15 Thread Adrian Bunk
On Fri, Jul 13, 2007 at 09:10:42AM +0200, Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, Adrian Bunk wrote: > > This patch removes some code that became dead code after the ATARI_ACSI > > removal. > > When was it removed? >... Jens removed it in commit c2bcf3b8978c291e1b7f6499475c8403a259d4d6

[PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. - add timeout control - kill dma_config_reg bitfields - some trivial cleanup Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Cc: Michael Buesch <[EMAIL PROTECTED]> Cc: Mike Frys

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Bryan Wu
On Sat, 2007-07-14 at 21:38 +0200, Michael Buesch wrote: > On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) > >

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-15 Thread Christoph Hellwig
On Sat, Jul 14, 2007 at 11:57:48PM -0700, David Miller wrote: > only request is to make this thing able to handle ipv6 as > well even if no current chips could facilitate that yet. I'm not sure that's a good idea. If current chips can't handle ipv6 lro there is no way to actually test it and the

Re: [Bugme-new] [Bug 8756] New: Route advmss copied to ALL routes when interface MTU changes

2007-07-15 Thread Simon Arlott
On 15/07/07 05:48, Andrew Morton wrote: > On Sat, 14 Jul 2007 15:34:31 -0700 (PDT) [EMAIL PROTECTED] wrote: > >> http://bugzilla.kernel.org/show_bug.cgi?id=8756 > > It is unclear which kernel version this applies to? Linus' 2.6 tree, as of Mon Jul 9 15:50:56 2007 -0700 For some reason it says "

Re: Linux 2.6.22: Leak r=1 1

2007-07-15 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 10:53:57 +0300 (EEST) > Dave can then put that one to net-2.6 and to stable too. ... > [PATCH] [TCP]: Verify the presence of RETRANS bit when leaving FRTO > > For yet unknown reason, something cleared SACKED_RETRANS bit > underneat

Re: [PATCH updated] IPV6: Call inet6addr_chain notifiers on link down

2007-07-15 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 06 Jul 2007 09:32:09 -0400 > Currently if the link is brought down via ip link or ifconfig down, > the inet6addr_chain notifiers are not called even though all > the addresses are removed from the interface. This caused SCTP > to add duplicate ad

Re: [RFC NET_SCHED 00/05]: Kill NET_CLS_POLICE

2007-07-15 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 9 Jul 2007 22:46:12 +0200 (MEST) > [This is a resend because of a typo in Jamal's address that I believe > made vger reject the mails. Appologies in case they arrive twice.] > > > These patches update the NET_CLS_ACT code to fully replace NE