Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-14 Thread David Miller
I think this work is great. Thanks for doing it. Besides the fixups Evgeniy has selected, and the suggestion to receive into pages to cut down allocation costs, my only request is to make this thing able to handle ipv6 as well even if no current chips could facilitate that yet. - To unsubscribe

IPSec freeze

2007-07-14 Thread Beschorner Daniel
Today a new site joined our Linux IPSec VPN, now all the other routers (all 2.6.22) freeze hard reproducible. No oops, no sysreq, only hard reset rewakes them. The only difference of the new site compared to the others: ADSL, thus a MTU of 1492, the others have 1500. Disabling IPSec und doing norm

Re: [Bugme-new] [Bug 8756] New: Route advmss copied to ALL routes when interface MTU changes

2007-07-14 Thread Andrew Morton
On Sat, 14 Jul 2007 15:34:31 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8756 It is unclear which kernel version this applies to? >Summary: Route advmss copied to ALL routes when interface MTU > changes >Product: N

Re: [Bugme-new] [Bug 8755] New: "ip -6 route change " behaves like "ip -6 route add"

2007-07-14 Thread Andrew Morton
On Sat, 14 Jul 2007 15:21:21 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8755 > >Summary: "ip -6 route change " behaves like "ip -6 route add" >Product: Networking >Version: 2.5 > Platform: All > OS/Versio

Re: [PATCH] IPv4: Cleanup call to __neigh_lookup()

2007-07-14 Thread David Miller
From: Jean Delvare <[EMAIL PROTECTED]> Date: Sat, 14 Jul 2007 22:18:16 +0200 > Back in the times of Linux 2.2, negative values for the creat parameter > of __neigh_lookup() had a particular meaning, but no longer, so we > should pass 1 instead. > > Signed-off-by: Jean Delvare <[EMAIL PROTECTED]>

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-14 Thread David Miller
From: Ranko Zivojnovic <[EMAIL PROTECTED]> Date: Sat, 14 Jul 2007 19:45:35 +0300 > On Sat, 2007-07-14 at 17:43 +0200, Patrick McHardy wrote: > > Patrick McHardy wrote: > > > Andrew Morton wrote: > > > > > >>>http://bugzilla.kernel.org/show_bug.cgi?id=8736 > > >>> > > >>>Here is another scenario I

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-07-14 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Sat, 14 Jul 2007 18:59:35 -0700 (PDT) > From: "John W. Linville" <[EMAIL PROTECTED]> > Date: Thu, 12 Jul 2007 16:41:38 -0400 > > > This request is based off net-2.6, as it requires a patch that is in > > net-2.6 but not yet in Linus' tree > > (b3d88ad

Re: [NET]: Add ethtool support for NETIF_F_IPV6_CSUM devices.

2007-07-14 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 13 Jul 2007 19:03:22 -0700 > [NET]: Add ethtool support for NETIF_F_IPV6_CSUM devices. > > Add ethtool utility function to set or clear IPV6_CSUM feature flag. > Modify tg3.c and bnx2.c to use this function when doing ethtool -K > to change tx c

Re: [patch 3/3] s390: af_iucv: add lock when updating accept_q

2007-07-14 Thread David Miller
From: Ursula Braun <[EMAIL PROTECTED]> Date: Fri, 13 Jul 2007 10:50:56 +0200 > From: Ursula Braun <[EMAIL PROTECTED]> > > The accept_queue of an af_iucv socket will be corrupted, if > adding and deleting of entries in this queue occurs at the > same time (connect request from one client, while ac

Re: [patch 2/3] s390: iucv - avoid deadlock between iucv_path_connect and tasklet

2007-07-14 Thread David Miller
From: Ursula Braun <[EMAIL PROTECTED]> Date: Fri, 13 Jul 2007 10:50:55 +0200 > From: Ursula Braun <[EMAIL PROTECTED]> > > An iucv deadlock may occur, where one CPU is spinning on the > iucv_table_lock for iucv_tasklet_fn(), while another CPU is holding > the iucv_table_lock for an iucv_path_conne

Re: [patch 1/3] From: Jennifer Hunt <[EMAIL PROTECTED]>

2007-07-14 Thread David Miller
From: Ursula Braun <[EMAIL PROTECTED]> Date: Fri, 13 Jul 2007 10:50:54 +0200 > [PATCH] s390: iucv Kconfig. > > Improve description of IUCV and AFIUCV configuration options. > > Signed-off-by: Jennifer Hunt <[EMAIL PROTECTED]> > Signed-off-by: Ursula Braun >[EMAIL PROTECTED]> > Acked-by: Frank Pa

Re: [2.6 patch] make net/ipv4/inet_timewait_sock.c:__inet_twsk_kill() static

2007-07-14 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri, 13 Jul 2007 01:55:56 +0200 > This patch makes the needlessly global __inet_twsk_kill() static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks Adrian. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-07-14 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 16:41:38 -0400 > This request is based off net-2.6, as it requires a patch that is in > net-2.6 but not yet in Linus' tree (b3d88ad49a0623d09efcf998beb26288c8029f75). ... > git://git.kernel.org/pub/scm/linux/kernel/git/linville

Re: [PATCH] tcp: tcp probe add back ssthresh field

2007-07-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 12:45:11 -0700 > Sangtae noticed the ssthresh got missed. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mess

Re: [VLAN]: Fix memset length

2007-07-14 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 20:16:39 +0200 > [VLAN]: Fix memset length > > Fix sizeof(ETH_ALEN) Introduced by my rtnl_link patches. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubs

Re: [NET 05/05]: Add macvlan driver

2007-07-14 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 20:13:48 +0200 (MEST) > [NET]: Add macvlan driver > > Add macvlan driver, which allows to create virtual ethernet devices > based on MAC address. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Looks good, applied. - To uns

Re: [VLAN 04/05]: Use multicast list synchronization helpers

2007-07-14 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 20:13:46 +0200 (MEST) > [VLAN]: Use multicast list synchronization helpers > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [VLAN 03/05]: Fix promiscous/allmulti synchronization races

2007-07-14 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 20:13:44 +0200 (MEST) > [VLAN]: Fix promiscous/allmulti synchronization races > > The set_multicast_list function may be called without holding the rtnl > mutex, resulting in races when changing the underlying device's promiscous >

Re: [NET 02/05]: dev_mcast: add multicast list synchronization helpers

2007-07-14 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 20:13:42 +0200 (MEST) > [NET]: dev_mcast: add multicast list synchronization helpers > > The method drivers currently use to synchronize multicast lists is not > very pretty: > > - walk the multicast list > - search each entry on a

Re: [NET 01/05]: Add net_device change_rx_mode callback

2007-07-14 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 20:13:40 +0200 (MEST) > [NET]: Add net_device change_rx_mode callback > > Currently the set_multicast_list (and set_rx_mode) callbacks are > responsible for configuring the device according to the IFF_PROMISC, > IFF_MULTICAST and IF

Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support

2007-07-14 Thread David Miller
From: Joakim Koskela <[EMAIL PROTECTED]> Date: Thu, 12 Jul 2007 12:25:23 +0300 > This (resubmitted) patch adds support for ipv4/ipv6 interfamily > addressing for the ipsec BEET (Bound End-to-End Tunnel) mode, as > specified by the ietf draft found at: > > http://www.ietf.org/internet-drafts/draft

open() on sockets (sock_no_open)

2007-07-14 Thread Simon Arlott
There are sockets in /proc//fd/, but they can't be opened because of this function: /* * In theory you can't get an open on this inode, but /proc provides * a back door. Remember to keep it shut otherwise you'll let the * creepy crawlies in. */ static int sock_no_open(struct inode *irreleva

r8169 in 2.6.22 release still not detecting link

2007-07-14 Thread Andrew Paprocki
Francois, Just writing to let you know that I'm still not getting a link on either r8169 port with the stock 2.6.22 kernel. I haven't been able to get any other network interface working on this device yet, as it only has a mini-PCI slot and I haven't found working wireless hardware yet. If I had

Re: [Bugme-new] [Bug 8754] New: Kernel addrconf modifies MTU of non-kernel routes

2007-07-14 Thread Andrew Morton
On Sat, 14 Jul 2007 14:54:32 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8754 > >Summary: Kernel addrconf modifies MTU of non-kernel routes >Product: Networking >Version: 2.5 > Platform: All > OS/Version:

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Mike Frysinger
On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: On Saturday 14 July 2007 21:49:21 Mike Frysinger wrote: > On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > > On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > > > +static int __init bf537mac_probe(struct net_device *dev) > > > +{ > >

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Jeff Garzik
Michael Buesch wrote: Well, this bitfield _might_ be OK (although I don't like bitfields at all), but the above pointer casting stuff should really use leXX_to_cpu. It's so easy to use and it is easier to read and maintain the code afterwards. If the bitfield stays, a comment must be added. Reg

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Michael Buesch
On Saturday 14 July 2007 21:49:21 Mike Frysinger wrote: > On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > > On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > > > +static int __init bf537mac_probe(struct net_device *dev) > > > +{ > > > + struct bf537mac_local *lp = netdev_priv(dev); >

Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6

2007-07-14 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sat, 14 Jul 2007 17:36:14 +0200 > Gabriel C wrote: > > cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends > > on IPV6. > > > I can't see any functional dependency on IPv6, what exactly are you > refering to? People might want

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Mike Frysinger
On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > +static int __init bf537mac_probe(struct net_device *dev) > +{ > + struct bf537mac_local *lp = netdev_priv(dev); > + int retval; > + > + /* Grab the MAC address in the MAC */ > +

Re: Fwd: r8169 driver supporting the 8167 dev ID

2007-07-14 Thread Francois Romieu
Jonathan Larsen <[EMAIL PROTECTED]> : > >You should read the tutorial until you find the 'Using git for > >collaboration' > >part. You missed a: > > > >git clone > >git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git > > Alright sweet, i got somewhere :). i was able to pull tha

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Michael Buesch
On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > +#if defined(CONFIG_BFIN_MAC_USE_L1) > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) > +#else > +# define bfin_mac_alloc(dma_handle, size) \ > + dma_

[PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Bryan Wu
This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. - clean up coding style issues by Jeff's review Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6

2007-07-14 Thread Gabriel C
Patrick McHardy wrote: > Gabriel C wrote: > >> cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends >> on IPV6. >> > > > I can't see any functional dependency on IPv6, what exactly are you > refering to? People might want to use it on a bridge for example > without havin

Re: [PATCH #2] Merge the Sonics Silicon Backplane subsystem

2007-07-14 Thread Michael Buesch
On Saturday 14 July 2007 19:26:05 Christoph Hellwig wrote: > On Sat, Jul 14, 2007 at 07:18:20PM +0200, Michael Buesch wrote: > > --- /dev/null > > +++ b/drivers/ssb/Makefile > > @@ -0,0 +1,11 @@ > > +ssb-builtin-drivers-y += > > driver_chipcommon.o > > +ssb-bui

Re: [PATCH #2] Merge the Sonics Silicon Backplane subsystem

2007-07-14 Thread Christoph Hellwig
On Sat, Jul 14, 2007 at 07:18:20PM +0200, Michael Buesch wrote: > --- /dev/null > +++ b/drivers/ssb/Makefile > @@ -0,0 +1,11 @@ > +ssb-builtin-drivers-y+= > driver_chipcommon.o > +ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_MIPS)+= > driver_mips

Re: Fwd: r8169 driver supporting the 8167 dev ID

2007-07-14 Thread Jonathan Larsen
You should read the tutorial until you find the 'Using git for collaboration' part. You missed a: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Alright sweet, i got somewhere :). i was able to pull that down, do my previous steps and git commit and then the gi

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-14 Thread Ranko Zivojnovic
On Sat, 2007-07-14 at 17:43 +0200, Patrick McHardy wrote: > Patrick McHardy wrote: > > Andrew Morton wrote: > > > >>>http://bugzilla.kernel.org/show_bug.cgi?id=8736 > >>> > >>>Here is another scenario I bumped onto - qdisc_watchdog_cancel() and > >>>qdisc_restart() deadlock. > >>> > >>>[...] > >>>

Re: No cmsg for SOCK_STREAM?

2007-07-14 Thread Rémi Denis-Courmont
Le samedi 14 juillet 2007, Daniel Schaffrath a écrit : > 'man 7 ip' sais that IP_RECVOPTS is not supported for SOCK_STREAM > sockets. > > But what if for debugging/measuring purposes I wanted to record the > route of the datagrams containing the stream segments? Are there any > other ways to get th

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-14 Thread Patrick McHardy
Patrick McHardy wrote: > Andrew Morton wrote: > >>>http://bugzilla.kernel.org/show_bug.cgi?id=8736 >>> >>>Here is another scenario I bumped onto - qdisc_watchdog_cancel() and >>>qdisc_restart() deadlock. >>> >>>[...] >>>DEADLOCK! > > > > Good catch. > > Please try reverting commit 1936502d00ae

Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6

2007-07-14 Thread Patrick McHardy
Gabriel C wrote: > cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends > on IPV6. I can't see any functional dependency on IPv6, what exactly are you refering to? People might want to use it on a bridge for example without having IPv6 running locally. - To unsubscribe from

Re: [2.6 patch] eepro100 resume patch

2007-07-14 Thread David Fries
On Fri, Jul 13, 2007 at 09:11:28PM -0700, Kok, Auke wrote: > [adding netdev] > > David Fries wrote: > >When I did a software suspend to disk then resumed the Intel network > >card using eepro100 driver would be unable to transmit packets. I > >tracked this down and found a register write after th

Re: nicstat

2007-07-14 Thread Christoph Hellwig
On Sat, Jul 14, 2007 at 09:28:50AM -0400, James Morris wrote: > This might be of interest (there's a Linux version): > > http://blogs.sun.com/timc/entry/nicstat_the_solaris_network_monitoring The code has a comment: * CAVEATS * It appears there is no way to determine the speed of an inter

Re: d80211 deadlock with wpa_supplicant and rmmod

2007-07-14 Thread Jiri Benc
On Fri, 13 Jul 2007 23:45:16 +0200, Johannes Berg wrote: > On Fri, 2007-07-13 at 13:05 +0100, seventh guardian wrote: > > > Hello, sorry for the delay but I only managed to try it out today.. > > I've applied the patch and tortured the system as far as I could, and > > no hang at all :) > > > > I

[PATCH] NET_CLS_RSVP6 should depend on IPV6

2007-07-14 Thread Gabriel C
Hello, cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends on IPV6. Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> --- net/sched/Kconfig |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/sched/Kconfig b/net/sched/Kconfig index b466288..

No cmsg for SOCK_STREAM?

2007-07-14 Thread Daniel Schaffrath
Hello everybody, 'man 7 ip' sais that IP_RECVOPTS is not supported for SOCK_STREAM sockets. But what if for debugging/measuring purposes I wanted to record the route of the datagrams containing the stream segments? Are there any other ways to get the IP options? Like a second raw socket t

Re: [2.6 patch] cleanup congestion control options

2007-07-14 Thread Adrian Bunk
On Fri, Jul 13, 2007 at 11:54:42PM -0700, David Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Sat, 14 Jul 2007 06:09:54 +0200 > > > This patch contains the following cleanups: > > - note in the prompt if an option depends on EXPERIMENTAL > > - remove "default n"s that didn't have a