proposed change.
--- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29
19:43:39.010565000 -0700
+++ 2.6.20.fix/drivers/net/bonding/bond_main.c 2007-05-29
19:46:12.37698 -0700
@@ -1227,7 +1227,14 @@
int i;
bond_for_each_slave(bond, slave, i) {
- features &= (
If sky2 device poll routine is called from netpoll_send_skb, it
would deadlock. The netpoll_send_skb held the netif_tx_lock, and the
poll routine could acquire it to clean up skb's. Other drivers
might use same locking model.
The driver is correct, netpoll should not introduce more locking problem
Jeremy Fitzhardinge wrote:
Jeff Garzik wrote:
+t3_intr_handler(adapter, qs->rspq.polling) (0,
+(adapter->flags & USING_MSIX) ?
+(void *)qs : (void *)adapter);
Remove needless casts to void*
The two branches of ?: need to have the same type; witho
kernel version <= 2.6.20.1
file drivers/net/bonding/bonding_main.c
function bond_compute_features()
---
Given a system with two different NIC. One driver sets
dev->features |= NETIF_F_HW_CSUM
the other driver sets
dev->features |= NETIF_F_IP_CSUM
when enslaving the 2 d
It doesn't look like spidernet hardware can really checksum all protocols,
the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM
instead of NETIF_F_HW_CSUM.
The driver doesn't need it's own get/set for ethtool tx csum, and it
should use the standard ethtool_op_get_link.
NOT
I have problems with a M2V motherboard and atl1 driver with msi and kernel
2.6.22-rc3. With kernel 2.6.21 I had no problems.
I must add in drivers/pci/quirks.c (line 1723):
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS480,
quirk_disable_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDO
Jeff Garzik wrote:
>>
>> +t3_intr_handler(adapter, qs->rspq.polling) (0,
>> +(adapter->flags & USING_MSIX) ?
>> +(void *)qs : (void *)adapter);
>
> Remove needless casts to void*
The two branches of ?: need to have the same type; without the casts
the
On Tue, 29 May 2007 17:10:52 -0700
"Michael Chan" <[EMAIL PROTECTED]> wrote:
> On Wed, 2007-05-30 at 07:36 +1000, Herbert Xu wrote:
>
> >
> > I just checked e1000 and it's correct as it does use the csum_offset
> > when doing TX offload. However, you're definitely right that bnx2
> > seems to b
On Wed, May 30, 2007 at 12:20:41AM +0200, Francois Romieu wrote:
> 2. Hunk #5 clashes with John Linville's wireless-dev#master
Let's not worry too much about this fact -- I'll (make Michael)
fix-up things in my tree as appropriate. :-)
John
--
John W. Linville
[EMAIL PROTECTED]
-
To unsubscribe
On Wed, 2007-05-30 at 07:36 +1000, Herbert Xu wrote:
>
> I just checked e1000 and it's correct as it does use the csum_offset
> when doing TX offload. However, you're definitely right that bnx2
> seems to be broken.
>
> > A few devices take a offset, starting point, and insertion point. This
>
On Tue, 2007-05-29 at 18:39 -0400, Jeff Garzik wrote:
> We check for 0x because that is often how a fault is indicated,
> when the memory location is read during or immediately after hotplug (or
> if the PCI bus is truly faulty). So for most hardware, you see
>
> tmp = read(irq status)
On Wed, 30 May 2007 00:20:41 +0200
Francois Romieu <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger <[EMAIL PROTECTED]> :
> ⅜...]
> > Better to just get rid of using the lock as a transmit lock and
> > use netif_tx_lock instead.
> > --- a/drivers/net/b44.c 2007-05-29 09:51:43.0 -0700
> >
Gary Zambrano wrote:
The b44 interrupt status reg returns a value of 0 if no interrupts are
pending. The b44 uses a mask to determine which bits (events) can
generate device interrupts on the system. If the masked interrupt status
register bits are not asserted, then the b44 will return to the sy
Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
From: Divy Le Ray <[EMAIL PROTECTED]>
Bump FW version to 4.1.
Modify chip tuning in consequence.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/regs.h|4
drivers/net/cxgb3/t3_hw.c | 40
++-
On Tue, 2007-05-29 at 22:45 +0200, Michael Buesch wrote:
> On Tuesday 29 May 2007 16:14:35 Gary Zambrano wrote:
> > On Mon, 2007-05-28 at 16:55 +0200, Michael Buesch wrote:
> > > On Monday 28 May 2007 16:12:12 Maximilian Engelhardt wrote:
> > > > On Monday 28 May 2007, Michael Buesch wrote:
> > > >
Stephen Hemminger <[EMAIL PROTECTED]> :
???...]
> Better to just get rid of using the lock as a transmit lock and
> use netif_tx_lock instead.
> --- a/drivers/net/b44.c 2007-05-29 09:51:43.0 -0700
> +++ b/drivers/net/b44.c 2007-05-29 14:26:03.0 -0700
> @@ -607,6 +607,7 @
On Tue, 29 May 2007 20:23:45 +0200
"Lior Dotan" <[EMAIL PROTECTED]> wrote:
> NTP was not running. I'm not sure what do you mean by fixing the -1.
> The trace shows that vegas_cong_avoid() is called with -1, and the
> only way it can happen is from tcp_clean_rtx_queue() and the patch
> should elimi
On Wed, 30 May 2007 07:36:18 +1000
Herbert Xu <[EMAIL PROTECTED]> wrote:
> On Tue, May 29, 2007 at 01:58:13PM -0700, Stephen Hemminger wrote:
> > The flag NETIF_F_HW_SUM is being misused. The definition says that the
> > device
> > is capable of checksumming any packet. When in fact from usage it
On Tue, 29 May 2007 23:14:58 +0200
Francois Romieu <[EMAIL PROTECTED]> wrote:
> The irq handling thread (b44_interrupt) uses the same lock as the NAPI
> thread. This change should prevent a deadlock if something interrupts
> the b44 NAPI thread and tries to printk through netconsole.
>
> Signed-o
On Tue, May 29, 2007 at 01:58:13PM -0700, Stephen Hemminger wrote:
> The flag NETIF_F_HW_SUM is being misused. The definition says that the device
> is capable of checksumming any packet. When in fact from usage it seems to
> imply that the device is capable of doing IPV6 as well as IPV4.
That wou
On Tue, 29 May 2007 23:58:39 +0300 (EEST)
"Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
> On Tue, 29 May 2007, Stephen Hemminger wrote:
>
> > On Tue, 29 May 2007 23:07:00 +0300 (EEST)
> > "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
> >
> > > On Tue, 29 May 2007, Stephen Hemminger wrote:
> > >
> > >
I am busy bisecting the real cause. Unfortunately, oprofile doesn't work
on the laptop, and build time sucks...
This how I think the IRQ should work:
--- a/drivers/net/b44.c 2007-05-29 09:47:53.0 -0700
+++ b/drivers/net/b44.c 2007-05-29 09:49:50.0 -0700
@@ -908,9 +908,11 @@ static
The irq handling thread (b44_interrupt) uses the same lock as the NAPI
thread. This change should prevent a deadlock if something interrupts
the b44 NAPI thread and tries to printk through netconsole.
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
---
drivers/net/b44.c |8
1 file
The flag NETIF_F_HW_SUM is being misused. The definition says that the device
is capable of checksumming any packet. When in fact from usage it seems to
imply that the device is capable of doing IPV6 as well as IPV4.
Some devices like 8139too do "fake checksum offloading" because they always
have
On Tue, 29 May 2007, Stephen Hemminger wrote:
> On Tue, 29 May 2007 23:07:00 +0300 (EEST)
> "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
>
> > On Tue, 29 May 2007, Stephen Hemminger wrote:
> >
> > > Since we don't invoke congestion control modules until after the SYN
> > > handshake this is not a
On Tuesday 29 May 2007 16:14:35 Gary Zambrano wrote:
> On Mon, 2007-05-28 at 16:55 +0200, Michael Buesch wrote:
> > On Monday 28 May 2007 16:12:12 Maximilian Engelhardt wrote:
> > > On Monday 28 May 2007, Michael Buesch wrote:
> > > > Can you also test the following patch?
> > > > I think there's a
On Tue, 29 May 2007 12:18:19 +0300
"Lior Dotan" <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I had a divide by zero on kernel 2.4.33 running with Vegas enabled.
> The KDB back trace is:
> kdb> bt
> Stack traceback for pid 0
> 0x403a600000 10 R 0x403a6370 *swapper
> EBPEIP
On Tue, 29 May 2007 23:07:00 +0300 (EEST)
"Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
> On Tue, 29 May 2007, Stephen Hemminger wrote:
>
> > On Mon, 28 May 2007 13:27:03 +0300 (EEST)
> > "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
> >
> > > On Sun, 27 May 2007, Ilpo Järvinen wrote:
> > >
> > > [PA
On Tue, 29 May 2007, Stephen Hemminger wrote:
> On Mon, 28 May 2007 13:27:03 +0300 (EEST)
> "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
>
> > On Sun, 27 May 2007, Ilpo Järvinen wrote:
> >
> > [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules)
>
> Yes, thanks for fixing this.
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]>
Date: Fri, 20 Apr 2007 19:02:51 +0900
> I send patches to fix panic when using inter
> address family IPsec on loopback device.
>
> These patches can be applied to current linux-2.6 and
> should also be net-2.6.
>
> Best regards,
>
> Signed-off-by: K
The following changes since commit d7ea3be56adc95b17351221fd95e78115f3b01f4:
Brandon Craig Rhodes (1):
hostap: Allocate enough tailroom for TKIP
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstream
Akinobu Mita (1):
The following changes since commit c420bc9f09a0926b708c3edb27eacba434a4f4ba:
Linus Torvalds (1):
Linux 2.6.22-rc3
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstream-fixes
Akinobu Mita (2):
ieee80211: fix incompl
On 5/26/07, Patrick McHardy <[EMAIL PROTECTED]> wrote:
Patrick McHardy wrote:
> Ranjit Manomohan wrote:
>
>>Currently the HTB rate for a class is update very slowly (once
>>every 16 seconds). This patch updates the rate whenever the stats
>>are requested from user space. This enables more accurat
On Monday 28 May 2007, Thomas Gleixner wrote:
> On Mon, 2007-05-28 at 22:55 +0200, Maximilian Engelhardt wrote:
> > > > I additionally built my 2.6.22-rc2-mm1 kernel without High Resolution
> > > > Timer, but the high ping problem is still there.
> > >
> > > Hmm, that's mysterious. Wild guess is th
NTP was not running. I'm not sure what do you mean by fixing the -1.
The trace shows that vegas_cong_avoid() is called with -1, and the
only way it can happen is from tcp_clean_rtx_queue() and the patch
should eliminate this. Another way of solving this is by checking
vegas_rtt_calc() and see if i
On Sun, 27 May 2007 20:44:04 +0200
Patrick McHardy <[EMAIL PROTECTED]> wrote:
> Fix sky2 disabling VLAN completely when the first vid is unregistered.
>
> For some reason the VLAN code insists on the driver providing a
> vlan_rx_kill_vid function even if only NETIF_F_HW_VLAN_RX and not
> NETIF_F_
On Tuesday 29 May 2007, Gary Zambrano wrote:
> On Mon, 2007-05-28 at 13:55 -0700, Maximilian Engelhardt wrote:
> > On Monday 28 May 2007, Thomas Gleixner wrote:
> > > On Mon, 2007-05-28 at 19:44 +0200, Maximilian Engelhardt wrote:
> > > > > Can you please keep CONFIG_HIGH_RES_TIMERS and CONFIG_NOHZ
On Mon, 28 May 2007 13:27:03 +0300 (EEST)
"Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
> On Sun, 27 May 2007, Ilpo Järvinen wrote:
>
> > On Sun, 27 May 2007, Baruch Even wrote:
> >
> > > * Ilpo J?rvinen <[EMAIL PROTECTED]> [070527 14:16]:
> > > >
> > > > Thus, my original question basically culmi
Ok, I finally got some time to code this out and study it and Ihave some
questions.
Milton Miller wrote:
We add two flags to struct rx: one says this packet is EL, and one says
it is or was size 0. We create a function, find_mark_el(struct nic,
is_running) that is called after initial alloc a
On Mon, 2007-05-28 at 16:55 +0200, Michael Buesch wrote:
> On Monday 28 May 2007 16:12:12 Maximilian Engelhardt wrote:
> > On Monday 28 May 2007, Michael Buesch wrote:
> > > Can you also test the following patch?
> > > I think there's a bug in b44 that is doesn't properly discard
> > > shared IRQs,
On Mon, 2007-05-28 at 13:55 -0700, Maximilian Engelhardt wrote:
> On Monday 28 May 2007, Thomas Gleixner wrote:
> > On Mon, 2007-05-28 at 19:44 +0200, Maximilian Engelhardt wrote:
> > > > Can you please keep CONFIG_HIGH_RES_TIMERS and CONFIG_NOHZ and try the
> > > > following combinations on the ke
If ioremap_nocache() is unfortunate enough to fail, the error code is not
set correctly leading to a false success from dfx_register(). This change
fixes the problem.
Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]>
---
Please apply.
Maciej
patch-mips-2.6.21-20070502-defxx-ioremap-0
On Tue, 29 May 2007 14:56:20 +0200
Michal Piotrowski <[EMAIL PROTECTED]> wrote:
> Hi all,
>
> Here is a list of some known regressions in 2.6.22-rc3.
>
> Feel free to add new regressions/remove fixed etc.
> http://kernelnewbies.org/known_regressions
>
>
>
> Networking
>
> Subject: Networ
On Tue, 29 May 2007 12:18:19 +0300
"Lior Dotan" <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I had a divide by zero on kernel 2.4.33 running with Vegas enabled.
> The KDB back trace is:
> kdb> bt
> Stack traceback for pid 0
> 0x403a600000 10 R 0x403a6370 *swapper
> EBPEIP
On Tue, 2007-05-29 at 14:53 +0200, Michal Piotrowski wrote:
> Subject: OOPS triggered by ip(8) deconfiguring a network interface
> References : http://bugzilla.kernel.org/show_bug.cgi?id=8491
> Submitter : Ben Collins <[EMAIL PROTECTED]>
> Patch : http://marc.info/?l=linux-netdev&m=11791
Hi all,
Here is a list of some known regressions in 2.6.22-rc3.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
Networking
Subject: Network card not usable - sky2
References : http://bugzilla.kernel.org/show_bug.cgi?id=8539
Submitter : Ruben
Hi all,
Here is a list of some known regressions in 2.6.22-rc3
with patches available.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
Networking
Subject: Oops with prism54 in 2.6.22-rc3
References : http://lkml.org/lkml/2007/5/26/54
Submitter
rae l wrote:
> merge dst_discard in & out into one, this removed a duplicate function.
Your patch is whitespace damaged, please fix your mailer and resend
*once*.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
On 5/28/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
Uhm, just replace every invocation of dst_discard_in/_out() directly
by dst_discard ... don't add macros for that.
merge dst_discard in & out into one, this removed a duplicate function.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
I
Ben Greear wrote:
> Patrick McHardy wrote:
>
>> Fix sky2 disabling VLAN completely when the first vid is unregistered.
>>
>> For some reason the VLAN code insists on the driver providing a
>> vlan_rx_kill_vid function even if only NETIF_F_HW_VLAN_RX and not
>> NETIF_F_HW_VLAN_FILTER is set, so thi
Hi,
I had a divide by zero on kernel 2.4.33 running with Vegas enabled.
The KDB back trace is:
kdb> bt
Stack traceback for pid 0
0x403a600000 10 R 0x403a6370 *swapper
EBPEIPFunction (args)
0x403a7d48 0x4026ae51 vegas_cong_avoid+0x111 (0x5f3bb638, 0x73c92cbb
Francois Romieu wrote:
[...]
> As an option you can retrieve the url below which contains all the patches
above in a single patch-file:
http://www.fr.zoreil.com/people/francois/misc/20070522-2.6.22-rc2-r8169.patch
Thanks for providing the single patch file. I was able to compile the patched
Ayaz Abdulla <[EMAIL PROTECTED]> writes:
> This patch fixes the power management functions. It includes lowering
> the phy speed to conserve power.
Shouldn't there be some way to disable this? AFAIK a few old switches
have trouble with this. I assume a new ethtool option would be appropiate
since
53 matches
Mail list logo
