Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 24 May 2007 07:41:00 +0200 > David Miller wrote: > >>* Herbert Xu <[EMAIL PROTECTED]> wrote: > >> > >>>[NET_SCHED]: Fix qdisc_restart return value when dequeue is empty > > > > Applied, thanks everyone. > > > Even though it didn't fix this pro

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread Patrick McHardy
David Miller wrote: >>* Herbert Xu <[EMAIL PROTECTED]> wrote: >> >>>[NET_SCHED]: Fix qdisc_restart return value when dequeue is empty > > Applied, thanks everyone. Even though it didn't fix this problem, this patch I sent earlier is also needed. [NET_SCHED]: sch_htb: fix event cache time calcula

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-23 Thread Milton Miller
On May 23, 2007, at 4:32 PM, David Acker wrote: Milton Miller wrote: My current reading of the manual is that the C bit will not be set on an RFD that is size 0. It goes on to processes EL and S, and decides to stop and interrupt RNR or suspend, or just go to the next packet. I double checked t

[PATCH netdev] "wrong timeout value" in sk_wait_data() v2

2007-05-23 Thread Vasily Averin
sys_setsockopt() do not check properly timeout values for SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout values. POSIX do not defines behaviour for sys_setsockopt in case negative timeouts, but requires that setsockopt() shall fail with -EDOM if the send and receive time

Re: [PATCH netdev] "wrong timeout value" in sk_wait_data()

2007-05-23 Thread Eric Dumazet
Vasily Averin a écrit : sys_setsockopt() do not check properly timeout values for SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout values. POSIX do not defines behaviour for sys_setsockopt in case negative timeouts, but requires that setsockopt() shall fail with -EDOM if

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-23 Thread Chris Wright
* Herbert Xu ([EMAIL PROTECTED]) wrote: > On Wed, May 23, 2007 at 04:38:20PM -0700, Kok, Auke wrote: > > > > With that, please add my Acked-By... > > Sorry, I only read yours after Chris's message :) > > Chris, please add that Acked-By by Auke. Got it, thanks. -chris - To unsubscribe from this l

[PATCH netdev] "wrong timeout value" in sk_wait_data()

2007-05-23 Thread Vasily Averin
sys_setsockopt() do not check properly timeout values for SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout values. POSIX do not defines behaviour for sys_setsockopt in case negative timeouts, but requires that setsockopt() shall fail with -EDOM if the send and receive time

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-23 Thread Milton Miller
Auke Kok pointed out I had left an unfinished thought this morning ... well, here's a completion, but I will mostly think about David's latest proposal. I think I was debating proposing this, then got side tracked then hit send. On May 23, 2007, at 9:02 AM, Milton Miller wrote: What if we just

Re: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-23 Thread Patrick McHardy
jamal wrote: > + if (unlikely (ret != NETDEV_TX_BUSY && net_ratelimit())) > + printk(KERN_DEBUG " BUG %s code %d qlen %d\n",dev->name, ret, > q->q.qlen); This seems to be based on an old version, your latest patch changed this to KERN_WARNING. - To unsubscribe from this list: sen

[RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-23 Thread jamal
In light of Commit: 39e00c5634cd15e14f3e8d2717c4861178dba275 (from Herbert), heres an update of the qdisc_restart cleanup. Anyone using the batch patch, this is the patch needed on top of the latest net-2.6, before you apply the batch patch. The old patch wont apply (its a one line change but patc

Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

2007-05-23 Thread Masahide NAKAMURA
Ingo Oeser wrote: [EMAIL PROTECTED] schrieb: From: Masahide NAKAMURA <[EMAIL PROTECTED]> This patch makes MIPv6 loadable module named "mip6". Here is a modprobe.conf(5) example to load it automatically when user application uses XFRM state for MIPv6: alias xfrm-type-10-43 mip6 alias xfrm-type

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-23 Thread Herbert Xu
On Wed, May 23, 2007 at 04:38:20PM -0700, Kok, Auke wrote: > > With that, please add my Acked-By... Sorry, I only read yours after Chris's message :) Chris, please add that Acked-By by Auke. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> H

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-23 Thread Herbert Xu
On Wed, May 23, 2007 at 04:34:18PM -0700, Chris Wright wrote: > > Mind adding an updated changelog and signed-off-by please? Sure. [E1000]: Fix netif_poll_enable crash in e1000_open e1000_open calls e1000_up which will always call netif_poll_enable. However, it's illegal to call netif_poll_enab

[PATCH] zd1211rw: Add UW2453 RF support

2007-05-23 Thread Daniel Drake
This patch adds support for another radio appearing in new devices: the Ubec UW2453. It's more complicated than the other RF's we support, but Ubec publish full tech specs so we're able to understand the vendor code relatively well. Now that we support UW2453, we also support Atheros' new USB chip

[PATCH] zd1211rw: Make CCK gain patching conditional on RF type

2007-05-23 Thread Daniel Drake
The vendor driver code suggests that CR47 patching happens on every channel change for every RF (depending on bit 8 in POD). Due to a bug in their driver (upper bits of RF_Mode get zeroed out, then are examined for 1s when setting some other flags), this isn't actually what happens, and their gene

[PATCH] zd1211rw: Add ID for ZyXEL G-200v2

2007-05-23 Thread Daniel Drake
Tested by Guy Gallagher zd1211 chip 0586:3407 v4721 high 00-13-49 AL2230_RF pa0 g--- FCC ID SI5WUB200Z Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_usb.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Index: linux/drivers/net/wireless/zd1211rw/zd_usb.c =

[PATCH] zd1211rw: Extend RF layer

2007-05-23 Thread Daniel Drake
These changes are needed for UW2453 RF support: Add pointer which RF drivers can use to store private RF data Add exit hook so that RF drivers can free private data Allow RF's to disable the generic TX power integration handling code Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_chip.c

Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

2007-05-23 Thread Kim Phillips
On Wed, 23 May 2007 15:23:22 +0200 Jan Altenberg <[EMAIL PROTECTED]> wrote: > ucc_geth has been migrated to use the common phylib code. So lets add a > 'select PHYLIB' to the UCC_GETH Kconfig entry. > > Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> Acked-by: Kim Phillips <[EMAIL PROTECTED]>

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-23 Thread Kok, Auke
Chris Wright wrote: * Herbert Xu ([EMAIL PROTECTED]) wrote: On Tue, May 22, 2007 at 10:02:53AM -0700, Kok, Auke wrote: I've posted that before and it's up to the stable team. I think that it's a seriously toolarge change unless Herbert posts his short version of the fix for 2.6.21.1. I would b

Re: [BUG] local_softirq_pending storm

2007-05-23 Thread Anant Nitya
On Thursday 24 May 2007 00:08:40 Chuck Ebbert wrote: > Chuck Ebbert wrote: > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240982 > > Another; these started to appear after the below patch was merged: > > Index: linux/kernel/sched.c > > > > > ===

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-23 Thread Chris Wright
* Herbert Xu ([EMAIL PROTECTED]) wrote: > On Tue, May 22, 2007 at 10:02:53AM -0700, Kok, Auke wrote: > > > > I've posted that before and it's up to the stable team. I think that it's a > > seriously toolarge change unless Herbert posts his short version of the fix > > for 2.6.21.1. I would be OK

Re: Running multiple concurrent TCP stacks

2007-05-23 Thread Stephen Hemminger
On Wed, 23 May 2007 16:59:02 -0500 "Tony Petz" <[EMAIL PROTECTED]> wrote: > I'm working on a research project that requires two simultaneously > running but independent TCP implementations. Searching the archives I > was only able to come up with this: > http://www.spinics.net/lists/linux-net/msg

Re: [PATCH 1/1] [TIPC]: Fixed erroneous introduction of for_each_netdev

2007-05-23 Thread David Miller
From: Jon Paul Maloy <[EMAIL PROTECTED]> Date: Tue, 15 May 2007 20:21:14 -0400 > > Signed-off-by: Jon Paul Maloy <[EMAIL PROTECTED]> Patch applied, thanks Jon. I specifically had the developer of that change audit for this exact kind of bug, my apologies that this one case still slipped through

Re: Network activity LED trigger

2007-05-23 Thread jamal
You know that you posted this exact message last time? ;-> And i responded here: http://marc.info/?l=linux-netdev&m=117882888105536&w=2 cheers, jamal On Wed, 2007-23-05 at 23:02 +0200, Florian Fainelli wrote: > Here comes a basic patch that adds a network led activity. It is not > configurable

Running multiple concurrent TCP stacks

2007-05-23 Thread Tony Petz
I'm working on a research project that requires two simultaneously running but independent TCP implementations. Searching the archives I was only able to come up with this: http://www.spinics.net/lists/linux-net/msg09064.html I was wondering if anyone had any insight into the problem, or knew of

Re: [patch 7/8] Use menuconfig objects: tokenring

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:57 -0700 > From: Jan Engelhardt <[EMAIL PROTECTED]> > > Use menuconfigs instead of menus, so the whole menu can be disabled at once > instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > Signed-off-by:

Re: [patch 6/8] Use menuconfig objects: ARCNET

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:56 -0700 > From: Jan Engelhardt <[EMAIL PROTECTED]> > > Use menuconfigs instead of menus, so the whole menu can be disabled at once > instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > Signed-off-by:

Re: [patch 5/8] Use menuconfig objects: TIPC

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:55 -0700 > From: Jan Engelhardt <[EMAIL PROTECTED]> > > Use menuconfigs instead of menus, so the whole menu can be disabled at once > instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > Cc: Per Liden <

Re: [patch 4/8] Use menuconfig objects: SCTP

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:54 -0700 > From: Jan Engelhardt <[EMAIL PROTECTED]> > > Use menuconfigs instead of menus, so the whole menu can be disabled at once > instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > Cc: Vlad Yasevi

Re: [patch 3/8] Use menuconfig objects: IPVS

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:51 -0700 > From: Jan Engelhardt <[EMAIL PROTECTED]> > > Use menuconfigs instead of menus, so the whole menu can be disabled at once > instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > Acked-by: Simon

Re: [patch 2/8] Use menuconfig objects: DCCP

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:49 -0700 > From: Jan Engelhardt <[EMAIL PROTECTED]> > > Use menuconfigs instead of menus, so the whole menu can be disabled at once > instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > Cc: Arnaldo Car

Re: [patch 1/8] use mutex instead of binary semaphore in idt77252 driver

2007-05-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 23 May 2007 14:35:48 -0700 > From: Matthias Kaehlcke <[EMAIL PROTECTED]> > > Use mutex instead of binary semaphore in idt77252 driver. > > Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> > Cc: chas williams <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morto

[patch 2/8] Use menuconfig objects: DCCP

2007-05-23 Thread akpm
From: Jan Engelhardt <[EMAIL PROTECTED]> Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Cc: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTEC

[patch 7/8] Use menuconfig objects: tokenring

2007-05-23 Thread akpm
From: Jan Engelhardt <[EMAIL PROTECTED]> Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/tokenring/Kconfig | 33

[patch 3/8] Use menuconfig objects: IPVS

2007-05-23 Thread akpm
From: Jan Engelhardt <[EMAIL PROTECTED]> Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Acked-by: Simon Horman <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

[patch 1/8] use mutex instead of binary semaphore in idt77252 driver

2007-05-23 Thread akpm
From: Matthias Kaehlcke <[EMAIL PROTECTED]> Use mutex instead of binary semaphore in idt77252 driver. Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> Cc: chas williams <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/atm/idt77252.c | 27 ++-

[patch 8/8] networking: fix sending netlink message when replace route

2007-05-23 Thread akpm
From: Milan Kocian <[EMAIL PROTECTED]> When you replace route via ip r r command the netlink multicast message is not send. This patch corrects it. NL message is sent with NLM_F_REPLACE flag. Addresses http://bugzilla.kernel.org/show_bug.cgi?id=8320 Signed-off-by: Milan Kocian <[EMAIL PROTECTE

[patch 6/8] Use menuconfig objects: ARCNET

2007-05-23 Thread akpm
From: Jan Engelhardt <[EMAIL PROTECTED]> Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/arcnet/Kconfig | 17 +++

[patch 5/8] Use menuconfig objects: TIPC

2007-05-23 Thread akpm
From: Jan Engelhardt <[EMAIL PROTECTED]> Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Cc: Per Liden <[EMAIL PROTECTED]> Cc: Jon Maloy <[EMAIL PROTECTED]> Cc: Allan Stephens <[EMA

[patch 4/8] Use menuconfig objects: SCTP

2007-05-23 Thread akpm
From: Jan Engelhardt <[EMAIL PROTECTED]> Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Cc: Vlad Yasevich <[EMAIL PROTECTED]> Cc: Sridhar Samudrala <[EMAIL PROTECTED]> Signed-off-b

Re: [FIX][PATCH] ipv6 addrconf.c REMOVED #if patch

2007-05-23 Thread David Miller
From: Urs Thuermann <[EMAIL PROTECTED]> Date: 21 May 2007 20:20:51 +0200 > Oliver Hartkopp <[EMAIL PROTECTED]> writes: > > > Yep - you were right. It looks better like this as ARPHRD_SIT is > > defined in if_arp.h in any CONFIG_* case ... > > Oliver asked me to resend the patch with a sane maile

Network activity LED trigger

2007-05-23 Thread Florian Fainelli
Here comes a basic patch that adds a network led activity. It is not configurable yet, but is enough to make a LED configured with the "network-activity" trigger to blink on network activity. Netdev people can probably comment on the place of ledtrig_network_activity(), which is probably not ad

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-23 Thread David Acker
Milton Miller wrote: I agree with this part of the approach. I just think we need a bit more work on the "what to do when we are ready for hardware to not stop" part. Agreed. The sync is required to push both cache lines, but there is no ordering guarantee. This probably is why you saw size

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Wed, 23 May 2007 13:40:21 +0200 > > * Herbert Xu <[EMAIL PROTECTED]> wrote: > > > [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty > > > > My previous patch that changed the return value of qdisc_restart > > incorrectly made the case

RE: [NET] meth driver renovation

2007-05-23 Thread Shane McDonald
Should this be: > static void __exit meth_exit_module(void) > { > - unregister_netdev(meth_dev); > - free_netdev(meth_dev); > + platform_driver_register(&meth_driver); > } platform_driver_unregister(&meth_driver); ^^ Shan

Re: [BUG] local_softirq_pending storm

2007-05-23 Thread Chuck Ebbert
Chuck Ebbert wrote: > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240982 Another; these started to appear after the below patch was merged: > Index: linux/kernel/sched.c > > === > > --- linux.orig/kernel/sched.c > > +++ l

Re: [NET] napi: Call __netif_rx_complete in netif_rx_complete

2007-05-23 Thread Ingo Oeser
Hi Herbert, Herbert Xu schrieb: > [NET] napi: Call __netif_rx_complete in netif_rx_complete > > This patch kills a little bit of code duplication between the two > variants of netif_rx_complete. What about making it out of line? There is nothing the compiler can optimize away here and the cod

Re: [PATCH] Fix incorrect prototype for ipxrtr_route_packet()

2007-05-23 Thread Ingo Oeser
David Miller schrieb: > From: David Woodhouse <[EMAIL PROTECTED]> > Date: Fri, 18 May 2007 09:48:32 +0800 > > On Thu, 2007-05-17 at 15:27 -0700, Andrew Morton wrote: > > > If only we could find some way in which all callers of a function as > > > well as its definition can see the same declaration?

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread Patrick McHardy
Linus Torvalds wrote: > There appear to be other obvious problems in the recent "cleanups" in this > area.. > > Look at > > psched_tdiff_bounded(psched_time_t tv1, psched_time_t tv2, > psched_time_t bound) > { > return min(tv1 - tv2, bound); > } > > and compare

Help on token bucket filter queue

2007-05-23 Thread Ali Ozyagci
Hello, I am trying to imitate the medium access behavior in HSDPA using wired ethernet in my research in order to see how TCP behaves under such a MAC. What I want to do is to send packets (if there are any in the queue) for the duration of about 2 milliseconds and then keep silent for some time,

Re: sky2 hangs without any messages

2007-05-23 Thread Stephen Hemminger
Does this patch fix the problem? It is something I saw while doing review for support of newer chips. Subject: sky2: don't set bogus bit in PHY register This code inherited from the sk98lin driver is incorrect on the Yukon2. The definition used for these bits is incorrect. Act

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread Linus Torvalds
On Wed, 23 May 2007, Patrick McHardy wrote: > > Yes, that looks better, thanks. There appear to be other obvious problems in the recent "cleanups" in this area.. Look at psched_tdiff_bounded(psched_time_t tv1, psched_time_t tv2, psched_time_t bound) { return

Re: sky2 hangs without any messages

2007-05-23 Thread Tino Keitel
On Wed, May 23, 2007 at 07:50:26 -0700, Stephen Hemminger wrote: [...] > Don't use that patch, it isn't needed and probably causes problem. > > Please get output of 'ethtool -d eth0'; more recent versions of > ethtool can decode the register format. Older versions just print hex. Hi, see the a

Re: sky2 hangs without any messages

2007-05-23 Thread Stephen Hemminger
On Wed, 23 May 2007 09:54:31 +0200 Tino Keitel <[EMAIL PROTECTED]> wrote: > Hi folks, > > in the last 2 days, I had 2 outages of the NIC of my Mac mini Core Duo. > I checked the kernel log but I found nothing sky2 related. After > reloading the module, the interface worked again. > > Both freeze

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-23 Thread Milton Miller
I tried to remove anything we were in agreement with. On May 22, 2007, at 5:07 PM, David Acker wrote: Milton Miller wrote: Many of the issues you bring have been in the e100 for some time. If you ignore the s-bit patch, I basically did the the following: moved the el-bit to before the last b

[PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

2007-05-23 Thread Jan Altenberg
ucc_geth has been migrated to use the common phylib code. So lets add a 'select PHYLIB' to the UCC_GETH Kconfig entry. Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 + 1 file changed, 1 insertion(+) Index: linux-2.6/drivers/net/Kconfig =

Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

2007-05-23 Thread Kumar Gala
On May 18, 2007, at 10:33 AM, Kim Phillips wrote: On Fri, 18 May 2007 09:07:42 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: On May 17, 2007, at 8:53 PM, Jeff Garzik wrote: Kim Phillips wrote: On Tue, 15 May 2007 17:45:19 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Kim Phillips wrote: It

Re: UDP checksum broken since 2.6.18?

2007-05-23 Thread Herbert Xu
On Wed, May 23, 2007 at 10:33:16AM +, "Thomas B. Rücker" wrote: > > Does this also explain why wireshark thinks the checksum is right when > tested on <=2.6.17? Probably not. It would help if you use the same tool between the kernels. Cheers, -- Visit Openswan at http://www.openswan.org/ Em

[PATCH 2/2] tbf scheduler: TSO support (update 3)

2007-05-23 Thread Hirokazu Takahashi
Hi, This patch is as same as the previous one. I just cleaned up some code. Thanks, Hirokazu Takahashi. Signed-off-by: Hirokazu Takahashi <[EMAIL PROTECTED]> --- linux-2.6.21/net/sched/sch_tbf.c.ORG2007-05-08 20:59:28.0 +0900 +++ linux-2.6.21/net/sched/sch_tbf.c2007-05-21 2

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty > > My previous patch that changed the return value of qdisc_restart > incorrectly made the case where dequeue returns empty continue > processing packets. > > This patch is based on di

[PATCH 1/2] tbf scheduler: TSO support (update 3)

2007-05-23 Thread Hirokazu Takahashi
Hi, > > > @@ -924,7 +926,9 @@ cbq_dequeue_prio(struct Qdisc *sch, int > > > cl->xstats.borrows += skb->len; > > > #endif > > > } > > > - q->tx_len = skb->len; > > > + q->tx_segs = skb_shinfo(skb)->gso_segs ? : > > > +

[PATCH] asix.c - Add Belkin F5D5055 ids

2007-05-23 Thread David Hollis
(Originally sent to linux-usb-devel) The attached patch adds the device IDs for the Belkin F5D5055 device. Reported by Andy Juniper <[EMAIL PROTECTED]> Signed-off-by: David Hollis <[EMAIL PROTECTED]> -- David Hollis <[EMAIL PROTECTED]> --- a/drivers/net/usb/asix.c 2007-05-11 08:18:35.000

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread Patrick McHardy
Herbert Xu wrote: > On Wed, May 23, 2007 at 12:56:04PM +0200, Patrick McHardy wrote: > >>Looking at the recent changes to __qdisc_run, this indeed seems >>to be the case, when the qdisc is throttled and has packets queued >>we return a value != 0, causing __qdisc_run to loop until all >>packets ha

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread Herbert Xu
On Wed, May 23, 2007 at 12:56:04PM +0200, Patrick McHardy wrote: > > Looking at the recent changes to __qdisc_run, this indeed seems > to be the case, when the qdisc is throttled and has packets queued > we return a value != 0, causing __qdisc_run to loop until all > packets have been sent, which

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread Ingo Molnar
* Patrick McHardy <[EMAIL PROTECTED]> wrote: > How is this trace to be understood? Is it simply a call trace in > execution-order? [...] yeah. There's a help section at the top of the trace which explains the other fields too: _--=> CPU# / _-=> irqs-of

Re: bad networking related lag in v2.6.22-rc2

2007-05-23 Thread Patrick McHardy
Ingo Molnar wrote: > if you feel inclined to try the git-bisection then by all means please > do it (it will certainly be helpful and educative), but it's optional: i > dont think you should 'need' to go through extra debugging chores, my > analysis based on the excellent trace you provided stil

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-23 Thread Herbert Xu
On Tue, May 22, 2007 at 10:02:53AM -0700, Kok, Auke wrote: > > I've posted that before and it's up to the stable team. I think that it's a > seriously toolarge change unless Herbert posts his short version of the fix > for 2.6.21.1. I would be OK with that. This patch should work for 2.6.21. C

Re: UDP checksum broken since 2.6.18?

2007-05-23 Thread Thomas B. Rücker
Herbert Xu wrote: > "Thomas B. R??cker" <[EMAIL PROTECTED]> wrote: > >> Stephen Hemminger wrote: >> >>> The packet passed to packet capture programs may not have a valid checksum >>> if you have checksum offload configured on the device. What kind of >>> hardware >>> do you have on sender

Re: UDP checksum broken since 2.6.18?

2007-05-23 Thread Herbert Xu
"Thomas B. R??cker" <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: >> The packet passed to packet capture programs may not have a valid checksum >> if you have checksum offload configured on the device. What kind of hardware >> do you have on sender and receiver? > The c-snippet uses 127.x

Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

2007-05-23 Thread Ingo Oeser
Hi, [EMAIL PROTECTED] schrieb: > From: Masahide NAKAMURA <[EMAIL PROTECTED]> > > This patch makes MIPv6 loadable module named "mip6". > > Here is a modprobe.conf(5) example to load it automatically > when user application uses XFRM state for MIPv6: > > alias xfrm-type-10-43 mip6 > alias xfrm-ty

Re: [PATCH 2.6.16-stable] [IPV6]: Restore semantics of Routing Header processing.

2007-05-23 Thread Adrian Bunk
On Sat, May 12, 2007 at 01:17:39AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > The "fix" for emerging security threats was overkill and it broke > basic semantic of IPv6 routing header processing. We should assume > RT0 as "unknown" RH type so that we > - silently ignore the routing header if segleft

[PATCH] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-05-23 Thread Bryan Wu
From: "Wu, Bryan" <[EMAIL PROTECTED]> This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- driv

Re: [patch 089/181] Blackfin: on-chip ethernet MAC controller driver

2007-05-23 Thread Bryan Wu
On Wed, 2007-05-23 at 05:13 -0400, Jeff Garzik wrote: > Bryan Wu wrote: > > Hi Jeff: > > > > Could you please review this patch? Sorry for miss sending the patch to > > you for review at beginning. > > can you resend as a patch rather than a quoted patch? > > Jeff > > Oh, sorry, I forgo

Re: [NET] meth driver renovation

2007-05-23 Thread Ralf Baechle
On Wed, May 23, 2007 at 09:43:30AM +0100, Ralf Baechle wrote: > The meth ethernet driver for the SGI IP32 aka O2 is so far still an old > style driver which does not use the device driver model. This is now > causing issues with some udev based gadgetry in debian-stable. Fixed by > converting th

[NET] meth driver renovation

2007-05-23 Thread Ralf Baechle
The meth ethernet driver for the SGI IP32 aka O2 is so far still an old style driver which does not use the device driver model. This is now causing issues with some udev based gadgetry in debian-stable. Fixed by converting the meth driver to a platform device. Signed-off-by: Ralf Baechle <[EMAI

[PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.

2007-05-23 Thread nakam
From: Masahide NAKAMURA <[EMAIL PROTECTED]> This patch makes MIPv6 loadable module named "mip6". Here is a modprobe.conf(5) example to load it automatically when user application uses XFRM state for MIPv6: alias xfrm-type-10-43 mip6 alias xfrm-type-10-60 mip6 Some MIPv6 feature is not included

[PATCH 1/2] [IPV6] MIP6: Kill unnecessary ifdefs.

2007-05-23 Thread nakam
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Kill unnecessary CONFIG_IPV6_MIP6. o It is redundant for RAW socket to keep MH out with the config then it can handle any protocol. o Clean-up at AH. Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> --- include/net/flow.h |4 include/ne

sky2 hangs without any messages

2007-05-23 Thread Tino Keitel
Hi folks, in the last 2 days, I had 2 outages of the NIC of my Mac mini Core Duo. I checked the kernel log but I found nothing sky2 related. After reloading the module, the interface worked again. Both freezes were connected to access from a remote NFS client to a directory with ~4700 files in it

[PATCH 0/2] [IPV6] MIP6: Mobile IPv6 patch updates

2007-05-23 Thread Masahide NAKAMURA
Hello, There are Mobile IPv6 patches for net-2.6 (2.6.22-rc2), which are minor fixes and modularization. Please review and apply them. [IPV6] MIP6: Kill unnecessary ifdefs. [IPV6] MIP6: Loadable module support for MIPv6. -- Masahide NAKAMURA - To unsubscribe from this list: sen