Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp_generic: fix lockdep warning

2007-05-09 Thread Jarek Poplawski
On Thu, May 10, 2007 at 10:03:23AM +0400, Yuriy N. Shkandybin wrote: > Yes, there is no real lockup with pppoe > ll repeat my configuration: > vpn (pptp(mostly)+pppoe) concentrator > PPPoE provided through 802.1q > +OSPF (quagga) I think, it's a little too general... Probably at least ifconfig and

Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp_generic: fix lockdep warning

2007-05-09 Thread Yuriy N. Shkandybin
Yes, there is no real lockup with pppoe ll repeat my configuration: vpn (pptp(mostly)+pppoe) concentrator PPPoE provided through 802.1q +OSPF (quagga) Jura - Original Message - From: "Jarek Poplawski" <[EMAIL PROTECTED]> To: "Yuriy N. Shkandybin" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECT

Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp_generic: fix lockdep warning

2007-05-09 Thread Jarek Poplawski
On Thu, May 10, 2007 at 12:06:09AM +0400, Yuriy N. Shkandybin wrote: > After applying this patch i've got this: > > === > [ INFO: possible circular locking dependency detected ] > 2.6.21-gentoo #2 > ---

Re: [PATCH v4] powerpc: change rheap functions to use ulongs instead of pointers

2007-05-09 Thread Kumar Gala
On Tue, 8 May 2007, Timur Tabi wrote: > The rheap allocation functions return a pointer, but the actual value is based > on how the heap was initialized, and so it can be anything, e.g. an offset > into a buffer. A ulong is a better representation of the value returned by > the allocation functio

Re: [PATCH] sched: Optimize return value of qdisc_restart

2007-05-09 Thread Krishna Kumar2
Hi Jamal, J Hadi Salim <[EMAIL PROTECTED]> wrote on 05/09/2007 09:22:44 PM: > > Since I am holding a lock in these two changed areas till I return > > back to __qdisc_run (which clears the RUNNING bit) and then drop the > > lock, there is no way packets can be on the queue while I falsely > > ret

Re: Kconfig warnings on latest GIT

2007-05-09 Thread Simon Horman
On Tue, May 08, 2007 at 03:11:52PM -0500, Timur Tabi wrote: > Kim Phillips wrote: > >On Tue, 8 May 2007 00:04:14 +0300 > >Ismail Dönmez <[EMAIL PROTECTED]> wrote: > >>drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' > >>refers to undefined symbol 'UCC_FAST' > >looks like

Re: [PATCH 00/17] sky2 update for 2.6.22

2007-05-09 Thread Stephen Hemminger
On Wed, 09 May 2007 19:27:17 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Wed, 09 May 2007 00:16:48 -0400 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> Stephen Hemminger wrote: > >>> Patches are against netdev-2.6 upstream code branch. > >>> > >>> This incl

Re: Please pull 'upstream-rtl8187' branch of wireless-2.6

2007-05-09 Thread Michael Wu
On Thursday 10 May 2007 00:21, Jeff Garzik wrote: > Michael Wu wrote: > > On Wednesday 09 May 2007 19:12, Jeff Garzik wrote: > >> John W. Linville wrote: > >>> +static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 > >>> *eeprom) +{ > >>> + eeprom->reg_data_clock = 1; > >>> + eeprom->regis

Re: [BUG][debian-2.6.20-1-686] bridging + vlans + "vconfig rem" == stuck kernel

2007-05-09 Thread Kyle Moffett
On May 10, 2007, at 00:25:54, Ben Greear wrote: Kyle Moffett wrote: vconfig D 83CCD8CE 0 16564 16562 (NOTLB) efdd7e7c 0086 ee120afb 83ccd8ce 98f00788 b7083ffa 5384b49a c76c0b05 9ebaf791 0004 efdd7e4e 0007 f1468a90 2ab74174 0362 00

Re: [BUG][debian-2.6.20-1-686] bridging + vlans + "vconfig rem" == stuck kernel

2007-05-09 Thread Ben Greear
Kyle Moffett wrote: vconfig D 83CCD8CE 0 16564 16562 (NOTLB) efdd7e7c 0086 ee120afb 83ccd8ce 98f00788 b7083ffa 5384b49a c76c0b05 9ebaf791 0004 efdd7e4e 0007 f1468a90 2ab74174 0362 0326 f1468b9c c180e420 0001 0286 c

Re: Please pull 'upstream-rtl8187' branch of wireless-2.6

2007-05-09 Thread Jeff Garzik
Michael Wu wrote: On Wednesday 09 May 2007 19:12, Jeff Garzik wrote: John W. Linville wrote: +static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom) +{ + eeprom->reg_data_clock = 1; + eeprom->register_write(eeprom); + udelay(1); +} + +static inline void eeprom

RE: [PATCH] IPROUTE: Modify tc for new PRIO multiqueue behavior

2007-05-09 Thread Zhu Yi
On Tue, 2007-05-08 at 19:28 -0400, jamal wrote: > Wireless with CSMA/CA is a slightly different beast due to the shared > channels; its worse but not very different in nature than the case > where you have a shared ethernet hub (CSMA/CD) and you keep adding > hosts to it The difference is the hub

[BUG][debian-2.6.20-1-686] bridging + vlans + "vconfig rem" == stuck kernel

2007-05-09 Thread Kyle Moffett
I've managed to fairly reliably trigger a deadlock in some portion of the linux networking code on my Debian test box (using the debian kernel linux-image-2.6.20-1-686). I'm pretty sure that it's a race condition of some sort as it doesn't trigger if I ifdown the interfaces one by one, but

Re: Please pull 'upstream-rtl8187' branch of wireless-2.6

2007-05-09 Thread Michael Wu
On Wednesday 09 May 2007 19:12, Jeff Garzik wrote: > John W. Linville wrote: > > +static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom) > > +{ > > + eeprom->reg_data_clock = 1; > > + eeprom->register_write(eeprom); > > + udelay(1); > > +} > > + > > +static inline void eeprom

[PATCH]: Fix up AF-specific references in UDP

2007-05-09 Thread David Miller
As noticed we make some ipv4-specific references in the generic UDP code, I've fixed that up completely below. This should fix ipv6 and it should be fully functional. There is enough infrastructure there to write up the non-wildcard IPV6 hashing support. Eric and Yoshifuji had some ideas about

[git patches] few more net driver updates, fixes

2007-05-09 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/atl1/atl1_main.c| 12 drivers/net/pcmcia/ibmtr_cs.c | 14 +++-- drivers/net/skge.c

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-09 Thread Nick Piggin
David Howells wrote: +/* + * prepare a page for being written to + */ +static int afs_prepare_page(struct afs_vnode *vnode, struct page *page, + struct key *key, unsigned offset, unsigned to) +{ + unsigned eof, tail, start, stop, len; + loff_t i_size, pos; +

Re: SG_IO with >4k buffer size to iscsi sg device causes "Bad page" panic

2007-05-09 Thread Herbert Xu
Qi, Yanling <[EMAIL PROTECTED]> wrote: > @@ -2571,6 +2572,13 @@ sg_page_malloc(int rqSz, int lowDma, int >resp = (char *) __get_free_pages(page_mask, order); > /* try half */ >resSz = a_size; >} > + tmppage = virt_to_page(resp); > + for( m = PAGE_

Re: [PATCH 3/6] phylib: enable RGMII-ID on the Marvell m88e1111 PHY

2007-05-09 Thread Jeff Garzik
Kim Phillips wrote: Support for configuring RGMII-ID (RGMII with internal delay) mode on the 88e and 88e1145. Also renamed 88es -> 88e (no references to an 88es part were found), and fixed some whitespace. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/phy/marv

Re: [PATCH 2/6] phylib: add the ICPlus IP175C PHY driver

2007-05-09 Thread Jeff Garzik
Kim Phillips wrote: + /* master reset */ + err = phydev->bus->write(phydev->bus, 30, 0, 0x175c); + if (err < 0) + return err; + + /* data sheet specifies reset period is 2 msec */ + udelay(3000); + +

Re: [PATCH 0/6] RESEND of missed ucc_geth phylib and SGMII patches

2007-05-09 Thread Jeff Garzik
hmmm, I received #0 and #2-#6, but not patch #1 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/17] sky2 update for 2.6.22

2007-05-09 Thread Jeff Garzik
Stephen Hemminger wrote: On Wed, 09 May 2007 00:16:48 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: Patches are against netdev-2.6 upstream code branch. This includes a several bug fixes, and code cleanup to use standard functions. There are a couple of PCI changes. On

Re: [PATCH] atl1: add netconsole support

2007-05-09 Thread Jeff Garzik
Alexey Dobriyan wrote: Copied from b44 driver, but it works: netconsole: device eth0 not up yet, forcing it atl1: eth0 link is up 100 Mbps full duplex netconsole: network logging started Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c | 12 1

Re: [PATCH] Fix hang on IBM Token Ring PCMCIA card ejection

2007-05-09 Thread Jeff Garzik
Paul Walmsley wrote: Ejecting a PCMCIA IBM Token Ring card that has not had its dev->open() called will reliably trigger an uninitialized spinlock oops when spinlock debugging is enabled. The system then hangs, occasionally softlockup oopsing. Apparently ibmtr.c:tok_interrupt() doesn't expect to

Re: [PATCH 1/2] skge: default WOL should be magic only (rev2)

2007-05-09 Thread Jeff Garzik
Stephen Hemminger wrote: By default, the skge driver now enables wake on magic and wake on PHY. This is a bad default (bug), wake on PHY means machine will never shutdown if connected to a switch. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>a --- drivers/net/skge.c |4 +++- 1 fil

Re: [PATCH] [IrDA] KingSun/DonShine USB IrDA dongle support

2007-05-09 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Thu, 10 May 2007 01:40:27 +0300 > From: Alex Villac$,3u=(Bs Lasso <[EMAIL PROTECTED]> > > This dongle does not follow the usb-irda specification, so it needs its > own special driver. In addition, it uses interrupt endpoints instead of > bulk ones as

Re: Please pull 'upstream-rtl8187' branch of wireless-2.6

2007-05-09 Thread Jeff Garzik
John W. Linville wrote: +static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom) +{ + eeprom->reg_data_clock = 1; + eeprom->register_write(eeprom); + udelay(1); +} + +static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom) +{ + eeprom->reg_da

Re: Please pull 'upstream' branch of wireless-2.6

2007-05-09 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 5b94f675f57e4ff16c8fda09088d7480a84dcd91: Linus Torvalds (1): Merge master.kernel.org:/.../davem/sparc-2.6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream

[PATCH] [IrDA] KingSun/DonShine USB IrDA dongle support

2007-05-09 Thread Samuel Ortiz
From: Alex Villac�s Lasso <[EMAIL PROTECTED]> This dongle does not follow the usb-irda specification, so it needs its own special driver. In addition, it uses interrupt endpoints instead of bulk ones as the rest of USB IrDA dongles supported by Linux (just to be different?) and data reads need to

[patch 1/1] icom: Add new sub-device-id to support new adapter

2007-05-09 Thread wendy xiong
This patch add new sub-device-id to support new adapter and changed the interrupt irq number for unsigned char to unsigned int. Signed-off by: Wendy Xiong <[EMAIL PROTECTED]> diff -Nuar linux-2.6.21-rc7.orig/drivers/serial/icom.c linux-2.6.21-rc7.new/drivers/serial/icom.c --- linux-2.6.21-rc7.o

Re: [PATCH 06/17] sky2: advanced error reporting

2007-05-09 Thread Stephen Hemminger
On Wed, 9 May 2007 12:05:51 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: > On Tue, May 08, 2007 at 08:49:55PM -0700, Stephen Hemminger wrote: > > Use the kernel interfaces for advanced error reporting. > > This should be cleaner and clear up errors on boot. > > Hmm. I thought that the AER funct

a wrinkle to consider when benchmarking with LRO

2007-05-09 Thread Rick Jones
At the risk of pointing-out the known/obvious... I have been evaluating a system and its ability to source data across a 10G link. My number of 10G sink's is a triffle minimal. To maximize the sinks' ability to sink data I enabled large receive offload. The kernel on the sinks was 2.6.21.1.

Re: linkwatch bustage in git-net

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 14:39:25 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > > where'd it go? > > Look at the two individual changes, Herbert implemented the > delay calculations different in the second changeset. So > the code is much different there now. ah, OK, I just haven't learned t

Re: linkwatch bustage in git-net

2007-05-09 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 9 May 2007 14:11:03 -0700 > On Wed, 09 May 2007 00:18:14 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > > > Thanks for working this out, applied and pushed to net-2.6.git > > I'm

Re: linkwatch bustage in git-net

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 00:18:14 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Thanks for working this out, applied and pushed to net-2.6.git I'm all confused. I just pulled your tree and I see in the log commit 4cba637dbb9a13706

Re: [IPV6] ROUTE: Assign rt6i_idev for ip6_{prohibit,blk_hole}_entry.

2007-05-09 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 09 May 2007 19:21:21 +0900 (JST) > I think this is less critical, but is also suitable for -stable > release. > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Applied, thanks! - To unsubscribe from this list: send the line "un

Re: [PATCH] [IPV6]: Do no rely on skb->dst before it is assigned.

2007-05-09 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 09 May 2007 19:18:35 +0900 (JST) > Because skb->dst is assigned in ip6_route_input(), it is really > bad to use it in hop-by-hop option handler(s). > > This fix is also needed for -stable. > > Closes: Bug #8450 (Eric Sesterhenn <[EMAI

Re: Bluetooth fixes for 2.6.22

2007-05-09 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Wed, 09 May 2007 14:24:50 +0200 > here are some minor additional fixes that should go into 2.6.22 before > Linus closes the merge window. ... > Please pull from > > > git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

Re: [PATCH] AF_RXRPC: Reduce debugging noise.

2007-05-09 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Wed, 09 May 2007 14:51:47 +0100 > Reduce debugging noise generated by AF_RXRPC. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> Applied, thanks David. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

Re: [IPV6] send ICMPv6 error on scope violations

2007-05-09 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Wed, 9 May 2007 13:55:15 -0600 > When an IPv6 router is forwarding a packet with a link-local scope source > address off-link, RFC 4007 requires it to send an ICMPv6 destination > unreachable with code 2 ("not neighbor"), but Linux doesn't. Fix below.

Re: [PATCH 3/3] [SCTP] Do not include ABORT chunk header in the notification.

2007-05-09 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Wed, 9 May 2007 15:43:50 -0400 > The socket API draft is unclear about whether to include the > chunk header or not. Recent discussion on the sctp implementors > mailing list clarified that the chunk header shouldn't be included, > but the error para

Re: [PATCH 1/3] [SCTP] Prevent OOPS if hmac modules didn't load

2007-05-09 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Wed, 9 May 2007 15:43:48 -0400 > SCTP was checking for NULL when trying to detect hmac > allocation failure where it should have been using IS_ERR. > Also, print a rate limited warning to the log telling the > user what happend. > > Signed-off-by: Vl

Re: [PATCH 2/3] [SCTP] Correctly copy addresses in sctp_copy_laddrs

2007-05-09 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Wed, 9 May 2007 15:43:49 -0400 > I broke the non-wildcard case recently. This is to fixes it. > Now, explictitly bound addresses can ge retrieved using the API. > > Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Applied. - To unsubscribe from th

Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp_generic: fix lockdep warning

2007-05-09 Thread Yuriy N. Shkandybin
After applying this patch i've got this: === [ INFO: possible circular locking dependency detected ] 2.6.21-gentoo #2 --- ospfd/3984 is trying to acquire lock: (&ppp->wlock){-...}, at: [] ppp_x

[IPV6] send ICMPv6 error on scope violations

2007-05-09 Thread David Stevens
When an IPv6 router is forwarding a packet with a link-local scope source address off-link, RFC 4007 requires it to send an ICMPv6 destination unreachable with code 2 ("not neighbor"), but Linux doesn't. Fix below. +-DLS [in-line for viewing, attache

[PATCH 3/3] [SCTP] Do not include ABORT chunk header in the notification.

2007-05-09 Thread Vlad Yasevich
The socket API draft is unclear about whether to include the chunk header or not. Recent discussion on the sctp implementors mailing list clarified that the chunk header shouldn't be included, but the error parameter header still needs to be there. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]>

[PATCH 2/3] [SCTP] Correctly copy addresses in sctp_copy_laddrs

2007-05-09 Thread Vlad Yasevich
I broke the non-wildcard case recently. This is to fixes it. Now, explictitly bound addresses can ge retrieved using the API. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> --- net/sctp/socket.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/net/sctp/socke

[PATCH] [SCTP]: More bugfixes

2007-05-09 Thread Vlad Yasevich
Hi David This is yet more bugfixes for SCTP: [SCTP] Prevent OOPS if hmac modules didn't load [SCTP] Correctly copy addresses in sctp_copy_laddrs [SCTP] Do not include ABORT chunk header in the notification. Please apply. Thanks -vlad - To unsubscribe from this list: send the

[PATCH 1/3] [SCTP] Prevent OOPS if hmac modules didn't load

2007-05-09 Thread Vlad Yasevich
SCTP was checking for NULL when trying to detect hmac allocation failure where it should have been using IS_ERR. Also, print a rate limited warning to the log telling the user what happend. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> --- net/sctp/socket.c |7 ++- 1 files changed, 6 i

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

2007-05-09 Thread Marc St-Jean
Thanks for the feedback Jeff. I have made all modifications but I have one question regarding the SKB recycling. Removing the backwards compatibility for the linux 2.4 eliminated the badness in mspeth_skb_headerinit(). However there is still some SKB code in mspeth_alloc_skb(). You didn't specific

Re: [PATCH 06/17] sky2: advanced error reporting

2007-05-09 Thread Linas Vepstas
On Tue, May 08, 2007 at 08:49:55PM -0700, Stephen Hemminger wrote: > Use the kernel interfaces for advanced error reporting. > This should be cleaner and clear up errors on boot. Hmm. I thought that the AER functions would eventually be handled by the struct pci_error_handlers callbacks, so that

[PATCH] From: Paul Walmsley <[EMAIL PROTECTED]>

2007-05-09 Thread Paul Walmsley
Ejecting a PCMCIA IBM Token Ring card that has not had its dev->open() called will reliably trigger an uninitialized spinlock oops when spinlock debugging is enabled. The system then hangs, occasionally softlockup oopsing. Apparently ibmtr.c:tok_interrupt() doesn't expect to be called before tok_o

Re: [PATCH 1/1] Fix hang on IBM Token Ring PCMCIA card ejection

2007-05-09 Thread Paul Walmsley
On Tue, 8 May 2007, Jeff Garzik wrote: ACK but does not apply Thanks. Some mailer trouble I guess - will resend via quilt. - Paul - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 12:07:39 +0100 David Howells <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > set_page_dirty() will set I_DIRTY_PAGES only. ie: the inode has dirty > > pagecache data. > > > > To tell the VFS that the inode itself is dirty one needs to run > > mark

RE: SG_IO with >4k buffer size to iscsi sg device causes "Bad page" panic

2007-05-09 Thread Qi, Yanling
> -Original Message- > From: Mike Christie [mailto:[EMAIL PROTECTED] > Qi, Yanling wrote: > Yeah, this problem should occur in the upstream open-iscsi iscsi code. > open-iscsi works very similar to linux-scsi where it just sends pages > around with sock->ops-sendpage, and it looks like sg

Re: [PATCH] sched: Optimize return value of qdisc_restart

2007-05-09 Thread jamal
Krishna, On Wed, 2007-09-05 at 20:17 +0530, Krishna Kumar2 wrote: > Concurrently is not possible, since everyone needs the queue_lock > to add/delete. Did I misunderstand your comment ? > I think so, more below where you explain it: > The dev->queue_lock is held by both enqueue'r and dequeue'r

Enable netem in my Linux box

2007-05-09 Thread Koon Wah Yick
Hi: My Linux box has CentOS5 installed. But I could not run tc command with any netem parameters in command line. as shown in web site http://linux-net.osdl.org/index.php/Netem. I suspect, Netem was either not part of the installed OS or has not been enabled. Can you tell how to verified? When

[PATCH] atl1: add netconsole support

2007-05-09 Thread Alexey Dobriyan
Copied from b44 driver, but it works: netconsole: device eth0 not up yet, forcing it atl1: eth0 link is up 100 Mbps full duplex netconsole: network logging started Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c | 12 1 file changed, 12 inserti

Re: [PATCH 00/17] sky2 update for 2.6.22

2007-05-09 Thread Stephen Hemminger
On Wed, 09 May 2007 00:16:48 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > Patches are against netdev-2.6 upstream code branch. > > > > This includes a several bug fixes, and code cleanup to use standard > > functions. There are a couple of PCI changes. One bug fix,

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Michael-Luke Jones
On 9 May 2007, at 15:22, David Acker wrote: Big endian is the natural setup for the NPEs on this hardware according to the intel documentation. Please don't stop this driver from moving forward so that a few folks can run their hardware in slow mode. No-one is saying that this driver shou

Re: [PATCH] sched: Optimize return value of qdisc_restart

2007-05-09 Thread Krishna Kumar2
Hi Jamal, J Hadi Salim <[EMAIL PROTECTED]> wrote on 05/09/2007 06:26:43 PM: > On Wed, 2007-09-05 at 01:12 -0700, David Miller wrote: > > > Something this evening is obviously making it impossible > > for my brain to understand this function and your patch, > > so I'm going to sleep on it and try

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread David Acker
Lennert Buytenhek wrote: The people who need a LE network driver can use Christian's driver, as Christian's driver works in LE just fine. The people who care about LE support can add LE support to the driver that Krzysztof wrote. I don't think that not supporting LE is a reason not to merge Krz

RE: [PATCH] IPROUTE: Modify tc for new PRIO multiqueue behavior

2007-05-09 Thread Johannes Berg
On Tue, 2007-05-08 at 09:28 -0400, jamal wrote: > Those virtual devices you have right now. They are a hack that needs to > go at some point. Actually, if we're talking about mac80211, the "master" device we have that does the qos stuff must go, but the other virtual devices need to stay for WDS/

[PATCH] AF_RXRPC: Reduce debugging noise.

2007-05-09 Thread David Howells
Reduce debugging noise generated by AF_RXRPC. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- net/rxrpc/ar-peer.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/ar-peer.c b/net/rxrpc/ar-peer.c index ce08b78..90fa107 100644 --- a/net/rxrpc/ar-peer.c +++

[PATCH] AFS: Further write support fixes

2007-05-09 Thread David Howells
Further fixes for AFS write support: (1) The afs_send_pages() outer loop must do an extra iteration if it ends with 'first == last' because 'last' is inclusive in the page set otherwise it fails to send the last page and complete the RxRPC op under some circumstances. (2) Similar

[PATCH (take 2)] vlan: lockdep class for ppp _xmit_lock Re: ppp_generic: fix lockdep warning

2007-05-09 Thread Jarek Poplawski
On Wed, May 09, 2007 at 02:32:24AM -0700, David Miller wrote: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Wed, 9 May 2007 11:35:37 +0200 > > > After rethinking there is the 3-rd way (as usual): > > > > c) vlan should use different lockdep lock subclasses or > > classes for different types

Re: [PATCH] sched: Optimize return value of qdisc_restart

2007-05-09 Thread jamal
On Wed, 2007-09-05 at 01:12 -0700, David Miller wrote: > Something this evening is obviously making it impossible > for my brain to understand this function and your patch, > so I'm going to sleep on it and try again tomorrow :-) It is one of those areas that are hard to size-up in a blink;-> Gut

[PATCH] AFS: Write support fixes

2007-05-09 Thread David Howells
AFS write support fixes: (1) Support large files using the 64-bit file access operations if available on the server. (2) Use kmap_atomic() rather than kmap() in afs_prepare_page(). (3) Don't do stuff in afs_writepage() that's done by the caller. Signed-off-by: David Howells <[EMAIL PROT

Bluetooth fixes for 2.6.22

2007-05-09 Thread Marcel Holtmann
Hi Dave, here are some minor additional fixes that should go into 2.6.22 before Linus closes the merge window. Regards Marcel Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git This will update the following files: drivers/bluetooth/hci_ldisc.

Re: [patch 7/9] lguest: the net driver

2007-05-09 Thread Rusty Russell
On Wed, 2007-05-09 at 22:00 +1000, Herbert Xu wrote: > Hi Rusty: > > On Wed, May 09, 2007 at 09:55:25PM +1000, Rusty Russell wrote: > > > > NO_CSUM because it really doesn't need a checksum. The > > LGUEST_NET_F_NOCSUM is only set for local inter-guest networking. If > > some guest were to

Re: [patch 7/9] lguest: the net driver

2007-05-09 Thread Herbert Xu
Hi Rusty: On Wed, May 09, 2007 at 09:55:25PM +1000, Rusty Russell wrote: > > NO_CSUM because it really doesn't need a checksum. The > LGUEST_NET_F_NOCSUM is only set for local inter-guest networking. If > some guest were to route the packets outside the machine, this would be > an issue,

Re: [patch 7/9] lguest: the net driver

2007-05-09 Thread Rusty Russell
On Wed, 2007-05-09 at 20:12 +1000, Herbert Xu wrote: > [EMAIL PROTECTED] wrote: > > > > + if (desc->features & LGUEST_NET_F_NOCSUM) > > + dev->features |= NETIF_F_NO_CSUM; > > Any reason why you're using NO_CSUM here instead of HW_CSUM? > Practically there is no difference but

Re: smp_affinity, MSI-X and 2.6.21.1

2007-05-09 Thread Andi Kleen
> That's true, but we are talking about software state so in some sense > it might be better that the affinity-to-be is reported to the user in > this case. > > Delayed register updates are an implementation detail the user does > not need to know about here. This patch should fix it. -Andi Repo

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 12:35:40PM +0200, Mikael Pettersson wrote: > > > Does that mean that the Debian ARM people have their heads so far > > > up their collective asses that they think that every form of change > > > is bad and are unable to accept that some forms of change might be > > > for th

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-09 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > set_page_dirty() will set I_DIRTY_PAGES only. ie: the inode has dirty > pagecache data. > > To tell the VFS that the inode itself is dirty one needs to run > mark_inode_dirty(). But what's the difference in this case? I don't need to write the inode b

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 11:35:03AM +0200, Marcus Better wrote: > > Does that mean that the Debian ARM people have their heads so far > > up their collective asses that they think that every form of change > > is bad and are unable to accept that some forms of change might be > > for the better? >

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Tomasz Chmielewski
On Wed, 9 May 2007 11:35:03 +0200, Marcus Better wrote: Lennert Buytenhek wrote: > Does that mean that the Debian ARM people have their heads so far > up their collective asses that they think that every form of change > is bad and are unable to accept that some forms of change might be > for the

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 11:25:47 +0100 David Howells <[EMAIL PROTECTED]> wrote: > > > + set_page_dirty(page); > > > + > > > + if (PageDirty(page)) > > > + _debug("dirtied"); > > > + > > > + return 0; > > > +} > > > > One would normally run mark_inode_dirty() after any i_size_write()? > > Not

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Mikael Pettersson
On Wed, 9 May 2007 11:35:03 +0200, Marcus Better wrote: > Lennert Buytenhek wrote: > > Does that mean that the Debian ARM people have their heads so far > > up their collective asses that they think that every form of change > > is bad and are unable to accept that some forms of change might be > >

Re: D-Link DFE-580TX 4 port NIC problems

2007-05-09 Thread Andrew Morton
On Wed, 9 May 2007 12:01:42 +0200 Mario Doering <[EMAIL PROTECTED]> wrote: > Hello, > > we have a D-Link DFE-580TX 4 port network card in our main router. > > It works pretty well most of the time, even though an error > message pops up in dmesg every now and then (sometimes once a day > sometim

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-09 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > > + BUG_ON(i_size > 0x); // TODO: use 64-bit store > > You're sure this isn't user-triggerable? Hmmm... I'm not. I'll whip up a patch for this. > kmap_atomic() could be used here and is better. Yeah. It used to have something that slept i

Re: [patch 7/9] lguest: the net driver

2007-05-09 Thread Herbert Xu
[EMAIL PROTECTED] wrote: > > + if (desc->features & LGUEST_NET_F_NOCSUM) > + dev->features |= NETIF_F_NO_CSUM; Any reason why you're using NO_CSUM here instead of HW_CSUM? Practically there is no difference but NO_CSUM could be treated differently in future and I'm not sure whe

Re: [1/1 take 2] Unified socket storage. (with small bench).

2007-05-09 Thread Evgeniy Polyakov
On Wed, May 09, 2007 at 03:02:00AM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Wed, 9 May 2007 13:57:40 +0400 > > > That is only because we have very different way of working with udp. > > In udp hash table we can have multiple sockets bound

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-09 Thread Lennert Buytenhek
On Tue, May 08, 2007 at 06:59:36PM +0200, Krzysztof Halasa wrote: > >> There may be up to 6 Ethernet ports (not sure about hardware > >> status, not yet supported even by Intel) - 7 queues * 128 entries > >> each = ~ 3.5 KB. Add 2 long queues (RX) for HSS and something > >> for TX, and then crypto

[IPV6] ROUTE: Assign rt6i_idev for ip6_{prohibit,blk_hole}_entry.

2007-05-09 Thread YOSHIFUJI Hideaki / 吉藤英明
I think this is less critical, but is also suitable for -stable release. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 452a82c..d1a9827 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -4060,6 +4060,10 @@ int __init

[PATCH] [IPV6]: Do no rely on skb->dst before it is assigned.

2007-05-09 Thread YOSHIFUJI Hideaki / 吉藤英明
Because skb->dst is assigned in ip6_route_input(), it is really bad to use it in hop-by-hop option handler(s). This fix is also needed for -stable. Closes: Bug #8450 (Eric Sesterhenn <[EMAIL PROTECTED]>) Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/ipv6/exthdrs.c b/net/i

Re: [1/1 take 2] Unified socket storage. (with small bench).

2007-05-09 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Wed, 9 May 2007 13:57:40 +0400 > That is only because we have very different way of working with udp. > In udp hash table we can have multiple sockets bound to different ip > addresses, but with the same port, so it will be placed into the same > ha

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Marcus Better
Lennert Buytenhek wrote: > Does that mean that the Debian ARM people have their heads so far > up their collective asses that they think that every form of change > is bad and are unable to accept that some forms of change might be > for the better? Well, I am not one of the Debian ARM people, jus

Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp_generic: fix lockdep warning

2007-05-09 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Wed, 9 May 2007 11:35:37 +0200 > After rethinking there is the 3-rd way (as usual): > > c) vlan should use different lockdep lock subclasses or > classes for different types of devices, used at the same > time. Perhaps we should just bite the bulle

Re: [1/1 take 2] Unified socket storage. (with small bench).

2007-05-09 Thread Evgeniy Polyakov
On Wed, May 09, 2007 at 02:44:45AM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Wed, 9 May 2007 13:34:43 +0400 > > > On Tue, May 08, 2007 at 11:48:28PM -0700, David Miller ([EMAIL PROTECTED]) > > wrote: > > > One thing that will need to be a

Re: smp_affinity, MSI-X and 2.6.21.1

2007-05-09 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: 09 May 2007 12:35:29 +0200 > Rick Jones <[EMAIL PROTECTED]> writes: > > > Folks - > > > > Is it a bug, or a feature that after changing a device's smp_affinity > > via echo "N" >> /proc/irq/M/smp_affinity that the new mask isn't > > visible via cat /pro

Re: [1/1 take 2] Unified socket storage. (with small bench).

2007-05-09 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Wed, 9 May 2007 13:34:43 +0400 > On Tue, May 08, 2007 at 11:48:28PM -0700, David Miller ([EMAIL PROTECTED]) > wrote: > > One thing that will need to be adjust for current tree is the UDP > > hashing mechanism. But as far as I can tell your code sh

Re: smp_affinity, MSI-X and 2.6.21.1

2007-05-09 Thread Andi Kleen
Rick Jones <[EMAIL PROTECTED]> writes: > Folks - > > Is it a bug, or a feature that after changing a device's smp_affinity > via echo "N" >> /proc/irq/M/smp_affinity that the new mask isn't > visible via cat /proc/irq/M/smp_affinity until after actual interrupts > are taken? Intel chipsets can o

Re: [1/1 take 2] Unified socket storage. (with small bench).

2007-05-09 Thread Evgeniy Polyakov
On Tue, May 08, 2007 at 11:48:28PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Tue, 8 May 2007 21:43:32 +0400 > > > This is second patch which implements unified cache of sockets for > > network instead of old hash tables. It stores all type

[PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp_generic: fix lockdep warning

2007-05-09 Thread Jarek Poplawski
On Thu, Apr 26, 2007 at 12:49:50PM +0200, Jarek Poplawski wrote: ... > But there is also a second, very similar lockdep report, > probably also false (lockdep cannot see the difference > between locks of two different, I hope, vlan devices), > which needs more work: > a) vlan should use different l

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 10:58:06AM +0200, Marcus Better wrote: > >> There _is_ an ARM BE version of Debian. > >> > >> It's not an official port, but it's not maintained any worse than > >> the 'official' LE ARM Debian port is. > > > Hmm... That changes a bit. Perhaps we should forget about > > th

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Marcus Better
Krzysztof Halasa wrote: > Lennert Buytenhek <[EMAIL PROTECTED]> writes: >> There _is_ an ARM BE version of Debian. >> >> It's not an official port, but it's not maintained any worse than >> the 'official' LE ARM Debian port is. > Hmm... That changes a bit. Perhaps we should forget about > that LE

bus id in PHY Abstraction Layer

2007-05-09 Thread Sascha Hauer
Hi, I made a quick shot to port the at91 network driver to the phy abstraction layer. While doing so I stumbled upon the (struct mii_bus)->id field. Currently the network driver registering the bus has to set this field. au1000_eth.c for example uses 0 or 1. mii-fec.c uses the id field of the corr

Re: [IPV6] ROUTE: Assign rt6i_idev for ip6_{prohibit,blk_hole}_entry.

2007-05-09 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 09 May 2007 17:42:28 +0900 (JST) > Wait for a moment, please. > I thought it should fix the issue, but > I must say, the fix does not seem sufficient... > > I'm now analysing further. Ok, I'll tell -stable to hold on this patch. - To

Re: [IPV6] ROUTE: Assign rt6i_idev for ip6_{prohibit,blk_hole}_entry.

2007-05-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 09 May 2007 01:13:33 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Wed, 09 May 2007 17:05:50 +0900 (JST) > > > We need to assign rt6i_idev for ip6_{prohibit,blk_hole}_entry as well > > as

  1   2   >