net-2.6.22 and tcp-2.6 rebased...

2007-04-20 Thread David Miller
It was a multi-day uphill battle but I got it done just now. kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.22.git kernel.org:/pub/scm/linux/kernel/git/davem/tcp-2.6.git As before, tcp-2.6.git is net-2.6.22 cloned with the TCP RB-Tree work added. An allmodconfig build went o

Re: [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp, ...) -> func(sk, ...)

2007-04-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 16 Apr 2007 19:19:02 +0300 (EEST) > [PATCH] [TCP]: Sed magic converts func(sk, tp, ...) -> func(sk, ...) I decided to apply this to my net-2.6.22 tree, I'll deal with the tcp-2.6 merge conflicts as best as I can. - To unsubscribe from this list

Re: [GIT PATCH] Exporting IPv6 statistics via netlink.

2007-04-20 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Thu, 19 Apr 2007 21:04:54 +0900 (JST) > [IPV6] SNMP: Export statistics via netlink without CONFIG_PROC_FS. > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> I applied this to my net-2.6.22 tree, thank you. - To unsubscribe from this

Re: [GIT PATCH] Exporting IPv6 statistics via netlink.

2007-04-20 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Thu, 19 Apr 2007 15:42:09 +0900 (JST) > [IPV6] SNMP: Netlink interface. > [IPV6] SNMP: Move some statistic bits to net/ipv6/proc.c. > [IPV4] SNMP: Move some statistic bits to net/ipv4/proc.c. I applied these as patches to my net

Re: [PATCH] fix comments for register_netdev()

2007-04-20 Thread David Miller
From: Borislav Petkov <[EMAIL PROTECTED]> Date: Wed, 18 Apr 2007 14:49:52 +0200 > Correct the function name in the comments supplied with register_netdev() > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> Patch applied, thank you. - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 7/7] [IrDA] Misc spelling corrections.

2007-04-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 00:32:09 +0300 > From: Guennadi Liakhovetski <[EMAIL PROTECTED]> > > Spelling corrections, from "to" to "too". > > Signed-off-by: G. Liakhovetski <[EMAIL PROTECTED]> > Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> Also applied to net-2.6.22, than

Re: [PATCH 6/7] [IrDA] Adding carriage returns to mcs7780 debug statements

2007-04-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 00:32:08 +0300 > Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> Applied to net-2.6.22, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

Re: [PATCH 5/7] [IrDA] IrDA monitor mode

2007-04-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 00:32:07 +0300 > Through a protocol specific ioctl, one can disable IrDA TX in order to > monitor an IrDA link. > > Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> I'd really rather see IRDA use netlink instead of these wonky ioctls, but whatever, i

Re: [PATCH 4/7] [IrDA] af_irda: IRDA_ASSERT cleanups

2007-04-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 00:32:06 +0300 > In af_irda.c, the multiple IRDA_ASSERT() are either hiding bugs, useless, or > returning the wrong value. > Let's clean that up. > > Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> Applied to net-2.6.22, thanks. - To unsubscribe fro

Re: [PATCH 3/7] [IrDA] af_irda: irda_accept cleanup

2007-04-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 00:32:05 +0300 > This patch removes a cut'n'paste copy of wait_event_interruptible > from irda_accept. > > Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> > Acked-by: Olaf Kirch <[EMAIL PROTECTED]> Applied to net-2.6.22, thanks. - To unsubscribe fro

Re: [PATCH 2/7] [IrDA] af_irda: Silence kernel message in irda_recvmsg_stream

2007-04-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 00:32:04 +0300 > From: Olaf Kirch <[EMAIL PROTECTED]> > > This patch silences an IRDA_ASSERT in irda_recvmsg_stream, as described in > http://bugzilla.kernel.org/show_bug.cgi?id=7512 irda_disconnect_indication > would set sk->sk_err to ECONNRESET, an

Re: [PATCH 1/7] [IrDA] af_irda: irda_recvmsg_stream cleanup

2007-04-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 00:32:03 +0300 > From: Olaf Kirch <[EMAIL PROTECTED]> > > This patch cleans up some code in irda_recvmsg_stream, replacing some > homebrew code with prepare_to_wait/finish_wait, and by making the > code honor sock_rcvtimeo. > > Signed-off-by: Olaf K

Re: [PATCH] TCP Illinois congestion control (rev3)

2007-04-20 Thread Stephen Hemminger
On Fri, 20 Apr 2007 17:08:13 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Wed, 4 Apr 2007 08:07:43 -0700 > > > This is an implementation of TCP Illinois invented by Shao Liu > > at University of Illinois. It is a another variant of Reno

Re: [PATCH 4/4] PPPoE: race between interface going down and release()

2007-04-20 Thread David Miller
From: Florian Zumbiehl <[EMAIL PROTECTED]> Date: Sat, 21 Apr 2007 01:44:05 +0200 > > This patch doesn't apply becuase in the actual pppoe.c code: > > [...] > > > So I'm having trouble figuring out what tree you generated > > that patch against :-) Perhaps there was an earlier patch > > I missed

Re: [PATCH] Eliminate some unnecessary gotos in tcp v4 hash handling

2007-04-20 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Thu, 5 Apr 2007 12:48:44 +0200 > > The compiler eliminates them anyways and this makes the code easier to read > and shorter. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Actually I won't apply this patch, ever, -ENOCOMPILE. Andi, please spare me

Re: [PATCH] Eliminate some unnecessary gotos in tcp v4 hash handling

2007-04-20 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Thu, 5 Apr 2007 12:48:44 +0200 > The compiler eliminates them anyways and this makes the code easier to read > and shorter. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> It depends upon who you ask :-) For someone trying to verify "all code paths l

Re: [PATCH] Move sk_setup_caps out of line

2007-04-20 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Thu, 5 Apr 2007 12:46:21 +0200 > It is far too large to be an inline and not in any hot paths. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Also applied, thanks Andi. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH] Uninline tcp_done

2007-04-20 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Thu, 5 Apr 2007 12:44:03 +0200 > > The function is quite big and has several call sites and nothing > to collapse by compiler optimization on inlining. > > Besides it's nicer to read in a in .c file. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> A

Re: [PATCH RFC] Clean up sk_buff walkers

2007-04-20 Thread David Miller
From: Jean Delvare <[EMAIL PROTECTED]> Date: Wed, 4 Apr 2007 18:03:04 +0200 > Hmm, no comment? The cleanup seems worth the effort, both for source > code readability and binary size. It's still in my patch backlog do not worry :-) I will get to it eventually. - To unsubscribe from this list: sen

Re: [PATCH] net: cleanup extra semicolons

2007-04-20 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 3 Apr 2007 12:00:09 -0700 > Spring cleaning time... > > There seems to be a lot of places in the network code that have > extra bogus semicolons after conditionals. Most commonly is a > bogus semicolon after: switch() { } > > Signed-off-by:

Re: [PATCH] TCP Illinois congestion control (rev3)

2007-04-20 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 4 Apr 2007 08:07:43 -0700 > This is an implementation of TCP Illinois invented by Shao Liu > at University of Illinois. It is a another variant of Reno which adapts > the alpha and beta parameters based on RTT. The basic idea is to increase >

Re: [PATCH 4/4] PPPoE: race between interface going down and release()

2007-04-20 Thread Florian Zumbiehl
Hi, > This patch doesn't apply becuase in the actual pppoe.c code: [...] > So I'm having trouble figuring out what tree you generated > that patch against :-) Perhaps there was an earlier patch > I missed or something. > > But I won't second guess and leave it to you to let me know > what I sh

Re: [RFC] Get rid of netdev_nit

2007-04-20 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 13 Mar 2007 14:26:35 -0700 > It isn't any faster to test a boolean global variable than do a > simple check for empty list. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> I'll apply this, thanks Stephen. I think the history is th

Re: [PATCH 4/4] PPPOE: Fix device tear-down notification.

2007-04-20 Thread David Miller
From: Michal Ostrowski <[EMAIL PROTECTED]> Date: Tue, 13 Mar 2007 09:09:35 -0500 > pppoe_flush_dev() kicks all sockets bound to a device that is going down. > In doing so, locks must be taken in the right order consistently (sock lock, > followed by the pppoe_hash_lock). However, the scan process

Re: [PATCH 3/4] PPPOE: memory leak when socket is release()d before PPPIOCGCHAN has been called on it

2007-04-20 Thread David Miller
From: Michal Ostrowski <[EMAIL PROTECTED]> Date: Tue, 13 Mar 2007 09:09:34 -0500 > below you find a patch that fixes a memory leak when a PPPoE socket is > release()d after it has been connect()ed, but before the PPPIOCGCHAN ioctl > ever has been called on it. > > This is somewhat of a security p

Re: [PATCH 2/4] PPPOE: race between interface going down and connect()

2007-04-20 Thread David Miller
From: Michal Ostrowski <[EMAIL PROTECTED]> Date: Tue, 13 Mar 2007 09:09:33 -0500 > below you find a patch that (hopefully) fixes a race between an interface > going down and a connect() to a peer on that interface. Before, > connect() would determine that an interface is up, then the interface > c

Re: [PATCH 1/4] PPPoE: miscellaneous smaller cleanups

2007-04-20 Thread David Miller
From: Michal Ostrowski <[EMAIL PROTECTED]> Date: Tue, 13 Mar 2007 09:09:32 -0500 > below is a patch that just removes dead code/initializers without any > effect (first access is an assignment) that I stumbled accross while > reading the source. > > Signed-off-by: Florian Zumbiehl <[EMAIL PROTECT

Re: [PATCH] skbuff: skb_store_bits const is backwards

2007-04-20 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 20 Apr 2007 16:13:14 -0700 > Getting warnings becuase skb_store_bits has skb as constant, > but the function overwrites it. Looks like const was on the > wrong side. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Also applied, than

Re: [Bugme-new] [Bug 8057] New: slab corruption running ip6sic

2007-04-20 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Mon, 12 Mar 2007 11:24:03 +0100 > > the ipcomp handler is xfrm6_rcv(), which calls xfrm6_rcv_spi(), which > > contrary > > to all other handlers returns -1 instead of 0 after calling kfree_skb() on > > the > > skb. Changing the return value to 0 in

Re: [PATCH 4/4] PPPoE: race between interface going down and release()

2007-04-20 Thread David Miller
From: Michal Ostrowski <[EMAIL PROTECTED]> Date: Sun, 11 Mar 2007 21:36:56 -0500 > Attached below is my take on how to address this problem. > This addresses any concerns you may have had about checking > po->pppoe_dev==NULL, > because accesses to this field are now synchronized with pppoe_hash

[PATCH] skbuff: skb_store_bits const is backwards

2007-04-20 Thread Stephen Hemminger
Getting warnings becuase skb_store_bits has skb as constant, but the function overwrites it. Looks like const was on the wrong side. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/skbuff.h |4 ++-- net/core/skbuff.c |2 +- 2 files changed, 3 insertions(+), 3

Re: [PATCH 3/3] Convert to use modern wait queue API

2007-04-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Sun, 11 Mar 2007 22:53:22 + > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> I finally applied this one, thanks for waiting so long :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

Re: [PATCH] NET: Add packet sock option to return orig_dev to userspace when bonded

2007-04-20 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 18:17:39 -0800 > Peter P. Waskiewicz Jr. <[EMAIL PROTECTED]> > NET: Add packet sock option to return orig_dev to userspace when > bonded I'm going to apply this patch (by hand, your email client corrupted the patch mas

Re: Getting the new RxRPC patches upstream

2007-04-20 Thread Oleg Nesterov
On 04/20, Andrew Morton wrote: > > On Fri, 20 Apr 2007 11:41:46 +0100 > David Howells <[EMAIL PROTECTED]> wrote: > > > There are only two non-net patches that AF_RXRPC depends on: > > > > (1) The key facility changes. That's all my code anyway, and shouldn't be > > a > > problem to merge

Re: [Bugme-new] [Bug 8330] New: lmc: copy_to/from_user cals while spinlock is held

2007-04-20 Thread Andrew Morton
On Sun, 15 Apr 2007 14:28:42 -0700 [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8330 > >Summary: lmc: copy_to/from_user cals while spinlock is held > Kernel Version: 2.6.20 > Status: NEW > Severity: normal > Owner: [EMAIL

Re: [PATCH 0/0] Re-try changes for PMTUDISC_PROBE

2007-04-20 Thread David Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Wed, 18 Apr 2007 21:07:10 -0400 > This backs out the the transport layer MTU checks that don't work. As a > consequence, I had to back out the PMTUDISC_PROBE patch as well. These > patches should fix the problem with ipv6 that the transport layer ch

Associating connection tracking with a physical device.

2007-04-20 Thread Ben Greear
I am trying to NAT routed connections between pairs of devices very much like the etun patch recently posted. As far as I can tell, this is failing because the connection tracking does not take the interface into account. The result is that if you send on etun1a, receive on etun1b, and then rout

Re: SIOCGIFCOUNT

2007-04-20 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Sat, 21 Apr 2007 00:04:51 +0200 > 0x8938 is SIOCGIFCOUNT. As far as I can see it is only defined in > sockios.h, but not implemented? > > Should it be removed from the include file or implemented? Unless we can be %100 certain not one build will break by

Re: [Bugme-new] [Bug 8342] New: sctp_getsockopt_local_addrs_old() calls copy_to_user() while a spinlock is held

2007-04-20 Thread Andrew Morton
On Mon, 16 Apr 2007 14:34:22 -0700 [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8342 > >Summary: sctp_getsockopt_local_addrs_old() calls copy_to_user() > while a spinlock is held > Kernel Version: 2.6.20 > Status: NEW >

Re: FYI: Xen or kernel bug? (fwd)

2007-04-20 Thread Stephen Hemminger
On Fri, 20 Apr 2007 16:39:27 -0400 (EDT) James Morris <[EMAIL PROTECTED]> wrote: > Could be an upstream kernel issue lurking. > > > -- Forwarded message -- > Date: Fri, 20 Apr 2007 22:21:26 +0200 > From: Mark Stier <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Subject: FYI: Xen o

FYI: Xen or kernel bug? (fwd)

2007-04-20 Thread James Morris
Could be an upstream kernel issue lurking. -- Forwarded message -- Date: Fri, 20 Apr 2007 22:21:26 +0200 From: Mark Stier <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: FYI: Xen or kernel bug? Hello, tcp_vegas produces division by zero kernel oopses in dom0 when running a Xe

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Stephen Hemminger
On Fri, 20 Apr 2007 13:21:10 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > On Fri, Apr 20, 2007 at 11:15:26AM -0700, Andrew Morton wrote: > > On Fri, 20 Apr 2007 18:51:13 +0900 > > Keiichi KII <[EMAIL PROTECTED]> wrote: > > > > > > I started to do some cleanups and fixups here, but abandoned it

Re: Getting the new RxRPC patches upstream

2007-04-20 Thread Andrew Morton
On Fri, 20 Apr 2007 11:41:46 +0100 David Howells <[EMAIL PROTECTED]> wrote: > There are only two non-net patches that AF_RXRPC depends on: > > (1) The key facility changes. That's all my code anyway, and shouldn't be a > problem to merge unless someone else has put some changes in there th

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Matt Mackall
On Fri, Apr 20, 2007 at 11:15:26AM -0700, Andrew Morton wrote: > On Fri, 20 Apr 2007 18:51:13 +0900 > Keiichi KII <[EMAIL PROTECTED]> wrote: > > > > I started to do some cleanups and fixups here, but abandoned it when it > > > was > > > all getting a bit large. > > > > > > Here are some fixes ag

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Andrew Morton
On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII <[EMAIL PROTECTED]> wrote: > > I started to do some cleanups and fixups here, but abandoned it when it was > > all getting a bit large. > > > > Here are some fixes against this patch: > > I'm going to fix my patches by following your reviews and sen

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-20 Thread Daniele Venzano
Il giorno 20/apr/07, alle ore 15:54, Neil Horman ha scritto: Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff cannot be alloc

Re: [PATCH 2.6.20] networking: bonding documentation fix for multiple bonding interfaces

2007-04-20 Thread Jay Vosburgh
Alexandra N. Kossovsky <[EMAIL PROTECTED]> wrote: >Fix bonding driver documentation for the case of multiple bonding interfaces. > >Signed-off-by: "Alexandra N. Kossovsky" <[EMAIL PROTECTED]> I don't see a problem with this; users running distros that require the multiple load fru fru sti

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-20 Thread Jeff Garzik
Neil Horman wrote: Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff cannot be allocated, the driver simply leaves a hole in the rx

[PATCH 4/7] NetXen: Removal of redundant macros

2007-04-20 Thread Mithlesh Thukral
NetXen: Remove 2 redundant macro definitions from header file. Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_phan_reg.h |2 -- 1 files changed, 2 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_phan_reg.h b/drivers/net/netxen/netxen_nic_phan

[PATCH 5/7] NetXen: Port swap feature for multi port cards

2007-04-20 Thread Mithlesh Thukral
NetXen: Port Swap feature This patch will allow a port numbers on the card to be swapped in host driver. This feature is applicable to cards having more than 1 port. Signed-off by: Milan Bag <[EMAIL PROTECTED]> Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_

[PATCH 6/7] NetXen: Fixes for Power PC architecture

2007-04-20 Thread Mithlesh Thukral
NetXen: Fix PPC architecture specific bugs Fixes some issues seen on Big endian machines. Signed-off by: Milan Bag <[EMAIL PROTECTED]> Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h |6 +++--- drivers/net/netxen/netxen_nic_hw.c |3 +-- dr

[PATCH 7/7] NetXen: Fix for vmalloc issues

2007-04-20 Thread Mithlesh Thukral
NetXen: Fix vmalloc errors on seen on some X86 high end machines. Signed-off by: Milan Bag <[EMAIL PROTECTED]> Acked-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netxen/netxe

[PATCH 3/7] NetXen: Multi PCI support for Quad cards

2007-04-20 Thread Mithlesh Thukral
NetXen: Fix the multi PCI function for cards with more than 2 ports. This patch fixes the working of multi PCI capable driver on cards with more than 2 ports by adding the addresses for their rings and sizes. Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic

[PATCH 0/7] NetXen: Make driver use multiple PCI functions

2007-04-20 Thread Mithlesh Thukral
hi All, Thanks Stephen for your suggestion. I am resending the 7 patches after incorporating the suggestion. These patches are with respect to netdev#upstream and we wish their inclusion in 2.6.22 kernel. Out of these the first 2 patches were already accepted into the netdev tree, but we have r

[PATCH 2/7] NetXen: Removal of redundant argument passing

2007-04-20 Thread Mithlesh Thukral
NetXen: Removal of redundant function call parameters and bug fixes. This patch will remove the redundant paramters which were being passed to many functions since now adapter->portnum can be used. Signed-off-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h |

Re: [PATCH][IPSEC] fix panic when using inter address familiy IPsec on loopback

2007-04-20 Thread James Morris
On Fri, 20 Apr 2007, Kazunori MIYAZAWA wrote: > Hello, > > I send patches to fix panic when using inter > address family IPsec on loopback device. > > These patches can be applied to current linux-2.6 and > should also be net-2.6. Looks good to me, although I wonder why the !IFF_LOOPBACK check

[patch 1/1] networking: fix sending netlink message when replace route

2007-04-20 Thread Milan Kocian
From: Milan Kocian <[EMAIL PROTECTED]> When you replace route via ip r r command the netlink multicast message is not send. This patch corrects it. NL message is sent with NLM_F_REPLACE flag. [Bug 8320] --- --- a/net/ipv4/fib_hash.c 2007-04-18 12:50:11.0 +0200 +++ b/net/ipv4/fib_has

[PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-20 Thread Neil Horman
Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff cannot be allocated, the driver simply leaves a hole in the rx ring, which causes th

Re: [1/3] 2.6.21-rc6: known regressions

2007-04-20 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > [...] I think the hangs that Ingo sees with forcedeth were preceded by > mysterious and "impossible" NULL pointer oopses. Ingo? update: the 'forcedeth NULL pointer oops' problem got resolved by one of these commits: commit 3ba4d093fe8a26f5f2da944

Re: [1/3] 2.6.21-rc6: known regressions

2007-04-20 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > The 6b6b6b6b pattern is POISON_FREE, implying some kind of slab > > misuse, most likely a use-after-free, although possibly just due to > > overrunning a slab into the next one or something like that. > > unfortunately, while being at -rc6 based ker

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread Aubrey Li
On 4/20/07, David Howells <[EMAIL PROTECTED]> wrote: Aubrey Li <[EMAIL PROTECTED]> wrote: > as checked in packet_set_ring, buffer size must be a multiple of PAGE_SIZE, > packet_set_ring > if (unlikely(req->tp_block_size & (PAGE_SIZE - 1))) > > So why n

Re: ESP interfamily tunnel bug?

2007-04-20 Thread Kazunori Miyazawa
Hi Diego, I was probably misunderstanding your problem. Ok, I used two machines, which were connected to different networks. My topology was [Host1][Router]-[Host2] I configured Host1 and Host2 to communicate by using IPv6 over IPv4 IPsec ESP tunnel mode. And they could communicate wit

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread David Howells
Eric Dumazet <[EMAIL PROTECTED]> wrote: > Is it really possible to allocate an order-10 page, then release part of it > (say an order-8 subpage) ? Yes. David - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Getting the new RxRPC patches upstream

2007-04-20 Thread David Howells
David Miller <[EMAIL PROTECTED]> wrote: > Now that Herbert cleared up the crypto layer issues > the only problem left is that there are generic changes > in there which are not strictly networking but which > your subsequent networking changes depend upon. > > This is a mess, and makes merging you

[PATCH][IPSEC] fix panic when using inter address familiy IPsec on loopback

2007-04-20 Thread Kazunori MIYAZAWA
Hello, I send patches to fix panic when using inter address family IPsec on loopback device. These patches can be applied to current linux-2.6 and should also be net-2.6. Best regards, Signed-off-by: Kazunori MIYAZAWA <[EMAIL PROTECTED]> --- net/ipv4/xfrm4_input.c |6 ++ net/ipv

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Keiichi KII
Please include an update to Documentation/networking/netconsole.txt OK, I update the documnet for the added functions in next patches. Thank you for your comments. -- Keiichi KII NEC Corporation OSS Promotion Center E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsub

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Keiichi KII
I started to do some cleanups and fixups here, but abandoned it when it was all getting a bit large. Here are some fixes against this patch: I'm going to fix my patches by following your reviews and send new patches on the LKML and the netdev ML in a few days. Thank you for your comments and

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread Eric Dumazet
On Fri, 20 Apr 2007 09:58:52 +0100 David Howells <[EMAIL PROTECTED]> wrote: > > Because kmalloc() may be able to get us a smaller chunk of memory. Actually, > calling __get_free_pages() might be a better, and then release the excess > pages. Interesting, that rings a bell here. I wonder why we

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread David Howells
Aubrey Li <[EMAIL PROTECTED]> wrote: > as checked in packet_set_ring, buffer size must be a multiple of PAGE_SIZE, > packet_set_ring > if (unlikely(req->tp_block_size & (PAGE_SIZE - 1))) > > So why not use __get_free_pages rather than kmalloc, Because

Re: Getting the new RxRPC patches upstream

2007-04-20 Thread David Miller
From: David Howells <[EMAIL PROTECTED]> Date: Fri, 20 Apr 2007 09:02:07 +0100 > David Miller <[EMAIL PROTECTED]> wrote: > > > I applied already the patches I thought were appropriate, > > you had some crypto layer changes that you need to work > > out with Herbert Xu before the rest can be applie

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread Aubrey Li
On 4/20/07, David Howells <[EMAIL PROTECTED]> wrote: Aubrey Li <[EMAIL PROTECTED]> wrote: > The patch works properly on my side. But > 1) I'm not sure why you re-wrote alloc/free_pg_vec function, doesn't > the current implement work for NOMMU? I know you want to allocate the > entire data buffer

Re: Getting the new RxRPC patches upstream

2007-04-20 Thread David Howells
David Miller <[EMAIL PROTECTED]> wrote: > I applied already the patches I thought were appropriate, > you had some crypto layer changes that you need to work > out with Herbert Xu before the rest can be applied. Should the rest of it go via Andrew's tree then? David - To unsubscribe from this li

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread David Howells
Aubrey Li <[EMAIL PROTECTED]> wrote: > The patch works properly on my side. But > 1) I'm not sure why you re-wrote alloc/free_pg_vec function, doesn't > the current implement work for NOMMU? I know you want to allocate the > entire data buffer as one contiguous lump, but is it really necessary? Y