Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-08 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 08:51:45 +0100 David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> BTW I missed the patch on netdev, is it just me or netdev have problems ? He definitely posted it, perhaps netdev is running a lit

Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-08 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 08:51:45 +0100 > David Miller a écrit : > > From: Eric Dumazet <[EMAIL PROTECTED]> > >> > >> BTW I missed the patch on netdev, is it just me or netdev have problems ? > > > > He definitely posted it, perhaps netdev is running a little

Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-08 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> BTW I missed the patch on netdev, is it just me or netdev have problems ? He definitely posted it, perhaps netdev is running a little slow or wonky today... I can confirm netdev didnt handled it, I cannot find it on archives. ht

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-08 Thread David Miller
From: Amit Choudhary <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 23:22:15 -0800 > Description: Check the return value of kmalloc() in function > wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. > > Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> This kind of patch has been submitted

[PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-08 Thread Amit Choudhary
Description: Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> diff --git a/net/ipv4/multipath_wrandom.c b/net/ipv4/multipath_wrandom.c index 92b0482..bcdb1f1 100644 --- a/net/ipv4/multipa

[PATCH] drivers/char/synclink.c: check kmalloc() return value.

2007-03-08 Thread Amit Choudhary
Description: Check the return value of kmalloc() in function mgsl_alloc_intermediate_txbuffer_memory(), in file drivers/char/synclink.c. Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c index 06784ad..24f99bc 100644 --- a/drivers/ch

Re: [PATCH 0/2] NET: Multiple queue network device support REPOST

2007-03-08 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 23:16:58 -0800 > It seems expensive to change all the skb's if this type of > event occurs, The reset functions have to walk all the SKBs anyways. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH 1/2] NET: Multiple queue network device support

2007-03-08 Thread Jarek Poplawski
On 07-03-2007 23:42, David Miller wrote: > I didn't say to use skb->priority, I said to shrink skb->priority down > to a u16 and then make another u16 which will store your queue mapping > value. Peter is right: this is fully used by schedulers (prio, CBQ, HTB, HFSC...) and would break users' scri

RE: [PATCH 0/2] NET: Multiple queue network device support REPOST

2007-03-08 Thread Waskiewicz Jr, Peter P
> This is not a problem. > > Since the ->enqueue function stores references to the SKBs, > any change of the dev->qdisc has to flush those references > somehow, and it is at that point that you can fixup the skb > queue mappings. > > This happens via invoking the qdisc->ops->reset() method. >

Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-08 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 07:59:50 +0100 > David Miller a écrit : > > From: Eric Dumazet <[EMAIL PROTECTED]> > > Date: Fri, 09 Mar 2007 07:34:15 +0100 > > > >> I gently ask that any new sysctl is '__read_mostly' tagged. > > > > People are lazy because you are

Re: Fw: [Bugme-new] [Bug 8151] New: Established connections not displayed in /proc/tcp/netstat

2007-03-08 Thread Herbert Xu
Andrew Morton <[EMAIL PROTECTED]> wrote: > > Date: Thu, 8 Mar 2007 07:53:57 -0800 > From: [EMAIL PROTECTED] > To: [EMAIL PROTECTED] > Subject: [Bugme-new] [Bug 8151] New: Established connections not displayed in > /proc/tcp/netstat Please try running 'ss -nt' to see if it displays the missing co

Re: [PATCH 0/2] NET: Multiple queue network device support REPOST

2007-03-08 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 22:42:19 -0800 > This was taken into consideration, and I did reply that my concern for > doing that could cause stale data in the skb if the queue mapping > changed. This is not a problem. Since the ->enqueue function stor

Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-08 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 07:34:15 +0100 I gently ask that any new sysctl is '__read_mostly' tagged. People are lazy because you are so gifted at finding this stuff :-) I seee ;) BTW I missed the patch on netdev, is it just me

Re: [PATCH 0/2] NET: Multiple queue network device support REPOST

2007-03-08 Thread Kok, Auke
David Miller wrote: You didn't address my correction the other day wherein I clarified for you that my idea was not to store the queue mapping in skb->priority but rather to shrink skb->priority to a u16 and add a new u16 skb->queue_mapping or whatever field to store the necessary information. Y

RE: [PATCH 0/2] NET: Multiple queue network device support REPOST

2007-03-08 Thread Waskiewicz Jr, Peter P
> -Original Message- > From: David Miller [mailto:[EMAIL PROTECTED] > Sent: Thursday, March 08, 2007 10:22 PM > To: Waskiewicz Jr, Peter P > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > Leech, Christopher > Subject: Re: [PATCH 0/2] NET: Multiple queue network device > supp

TSO performance wrt 2.614

2007-03-08 Thread anandvelu thulasiram
Hi all, I'm working on TCP segmentation Offload and I'm using Linux -2.6.14 kernel for this. I'm getting about a 6x increase in sending by turning off TCP segmentation offload. But When I turn on the TSO my performance is getting degraded. But when I switched back to Linux 2.6.9 ker

Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-08 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 07:34:15 +0100 > I gently ask that any new sysctl is '__read_mostly' tagged. People are lazy because you are so gifted at finding this stuff :-) > [PATCH] NET : New sysctls should use __read_mostly tags > > net_msg_warn should be pla

about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-08 Thread Eric Dumazet
Hello David and Stephen I see git commit 8e2101a9faab43dcf307d46784a1ede7997fe729 and its potential problems : Here on my x86_64 machine : 806e7520 d rtnl_mutex 806e7538 D net_msg_cost 806e753c D net_msg_burst 806e7540 D net_msg_warn 806e7560 d lweventlis

Re: [PATCH 0/2] NET: Multiple queue network device support REPOST

2007-03-08 Thread David Miller
You didn't address my correction the other day wherein I clarified for you that my idea was not to store the queue mapping in skb->priority but rather to shrink skb->priority to a u16 and add a new u16 skb->queue_mapping or whatever field to store the necessary information. You're just posting a

[PATCH]: Fix RB-tree comparisons

2007-03-08 Thread David Miller
While reviewing Ilpo's lost marking code I noticed that the RB-tree code was doing raw comparisons on sequence numbers which is always wrong. I checked the following into net-2.6.22 to cure that: [TCP]: Fix sequence number comparisons in RB-tree code. Need to use after(), before(), etc. to hand

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-08 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 10:13:28 +0900 (JST) > Bug noticed by Chris Wright <[EMAIL PROTECTED]>. > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH 1/2] [IPV6]: Return correct result for sticky options.

2007-03-08 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 10:11:52 +0900 (JST) > We returned incorrect result with IPV6_RTHDRDSTOPTS, IPV6_RTHDR and > IPV6_DSTOPTS. > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "u

Re: [PATCH 8/8] udp: deinline

2007-03-08 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 08 Mar 2007 12:52:22 -0800 > A couple of functions are exported or used indirectly > so it is pointless to mark them as inline. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line

Re: [PATCH 7/8] net: deinline some functions

2007-03-08 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 08 Mar 2007 12:52:21 -0800 > Several functions are marked inline or forced inline, but it > would be better to let the compiler decide. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send t

Re: [PATCH 6/8] tcp: whitespace cleanup

2007-03-08 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 08 Mar 2007 12:52:20 -0800 > Add whitespace around keywords. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 5/8] ipv4 cleanup

2007-03-08 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 08 Mar 2007 12:52:19 -0800 > Add whitespace around keywords. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 4/8] wireless: use ARRAY_SIZE()

2007-03-08 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 08 Mar 2007 12:52:18 -0800 > Use ARRAY_SIZE() macro now. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 3/8] network core: whitespace cleanup

2007-03-08 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 08 Mar 2007 12:52:17 -0800 > Fix whitespace around keywords. Fix indentation especially of switch > statements. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH 2/8] udp: ipv6 style cleanup

2007-03-08 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 08 Mar 2007 12:52:16 -0800 > Fix whitespace around keywords. Eliminate unnecessary ()'s on return > statements. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH 1/8] udp: ipv4 whitespace cleanup

2007-03-08 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 08 Mar 2007 12:52:15 -0800 > Fix whitespace around keywords. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec resolution

2007-03-08 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 15:17:57 +0100 > [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec > resolution > > Now network timestamps use ktime_t infrastructure, we can add a new ioctl() > SIOCGSTAMPNS command to get timestamps in 'stru

Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-03-08 Thread Valdis . Kletnieks
On Thu, 08 Mar 2007 22:48:29 GMT, David Howells said: > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index 779aa78..ce092fe 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -40,7 +40,10 @@ > #define CRYPTO_ALG_LARVAL0x0010 > #define CR

Rare NIC "crash" with 3c905B

2007-03-08 Thread Pierre Ynard
Hello, I think that I found a problem with 3c905B Cyclone 100baseTx cards, supported by the 3c59x driver. Please have a look at: http://bugzilla.kernel.org/show_bug.cgi?id=7440 In short, the device stores received packets through DMA into buffers on a rx_ring, which has a default size of 32 pack

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-08 Thread Tony Breeds
On Wed, Mar 07, 2007 at 03:00:57PM -0800, Andrew Morton wrote: > On Wed, 7 Mar 2007 23:41:16 +0100 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > On Tue, Mar 06, 2007 at 12:44:08AM -0800, Andrew Morton wrote: > > >... > > > Changes since 2.6.20-rc2-mm1: > > >... > > > git-netdev-all.patch > > >..

[PATCH] NET: Add packet sock option to return orig_dev to userspace when bonded

2007-03-08 Thread Waskiewicz Jr, Peter P
This patch applies against commit 704e0b01791bfcb75355f269a6f0054a75c9c563 of branch 'master' from davem/net-2.6.22 --- Summary: Peter P. Waskiewicz Jr. <[EMAIL PROTECTED]> NET: Add packet sock option to return orig_dev to userspace when bonded --- Add a packet socket option to allow the

Re: [PATCH 1/2] [IPV6]: Return correct result for sticky options.

2007-03-08 Thread Chris Wright
* YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote: > We returned incorrect result with IPV6_RTHDRDSTOPTS, IPV6_RTHDR and > IPV6_DSTOPTS. This makes a lot more sense. I wondered about that, thanks. -chris - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

[PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-08 Thread YOSHIFUJI Hideaki / 吉藤英明
Bug noticed by Chris Wright <[EMAIL PROTECTED]>. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/ipv6_sockglue.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 44ccdf0..6ad8921 100644 --- a/ne

Re: IPV6: make ipv6_getsockopt_sticky honor user's buffer size

2007-03-08 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 09:49:32 +0900 (JST) > We should give truncated result and return full length > from the POSIX POV. True, and the user would know what happened because it knows both the original length it gave and the larger one the kernel

[PATCH 1/2] [IPV6]: Return correct result for sticky options.

2007-03-08 Thread YOSHIFUJI Hideaki / 吉藤英明
We returned incorrect result with IPV6_RTHDRDSTOPTS, IPV6_RTHDR and IPV6_DSTOPTS. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/ipv6_sockglue.c | 27 +++ 1 files changed, 23 insertions(+), 4 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c b/net/ip

Re: IPV6: make ipv6_getsockopt_sticky honor user's buffer size

2007-03-08 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 08 Mar 2007 14:38:04 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > From: Chris Wright <[EMAIL PROTECTED]> > Date: Wed, 7 Mar 2007 23:10:48 -0800 > > > Make sure not to copy_to_user more than user's buffer can handle (we > > already checked the min

[PATCH] spidernet: Fix problem sending IP fragments

2007-03-08 Thread Linas Vepstas
Jeff, Please apply. The rather long patch description is from the submitter, Norbert Eicker, I don't know if that's alright, or if I should ask to have it trimmed. Thanks, --linas From: Norbert Eicker <[EMAIL PROTECTED]> I found out that the spidernet-driver is unable to send fragmented IP

Re: skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch)

2007-03-08 Thread Chris Stromsoe
On Thu, 8 Mar 2007, Jay Vosburgh wrote: If you're running active-backup and not using the ARP monitor (arp_interval), then I'm not aware of any possible locking problems in bonding for the kernel version you reference (2.6.20.1). I'm not using arp_interval. On Thu, 8 Mar 2007, Jay Vosburgh

[PATCH 1/2] r8169: revert bogus BMCR reset

2007-03-08 Thread Francois Romieu
Added during bf793295e1090af84972750898bf8470df5e5419 The current code requests a reset but prohibits autoneg, 1000 Mb/s, 100 Mb/s and full duplex. The 8168 does not like it at all. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |4 ++-- 1 files changed, 2 inserti

[PATCH 2/2] r8169: fix a race between PCI probe and dev_open

2007-03-08 Thread Francois Romieu
Initialize the timer with the rest of the private-struct. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r

Re: skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch)

2007-03-08 Thread Jay Vosburgh
Chris Stromsoe <[EMAIL PROTECTED]> wrote: >It's active-backup. Testing with the same setup and e100 works fine. I've >done a few tests without the bonding module, using the dual-port >separately. Somebody else a couple of weeks ago was having similar issues running bonding with skge (in

Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-03-08 Thread David Howells
David Howells <[EMAIL PROTECTED]> wrote: > These patches together supply secure client-side RxRPC connectivity as a Linux > kernel socket family. Only the transport/session side is supplied - the > presentation side (marshalling the data) is left to the client. The patches can also be downloaded

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Pavel Roskin
On Thu, 2007-03-08 at 14:17 -0800, Randy Dunlap wrote: > I think that this is not actually an option since > powerpc64 is all 32-bit userspace. > Maybe some other arch-es are like this also (?). I think all other architectures except x86_64 and maybe ia64 would prefer to stay 32-bit for performanc

[PATCH 2/5] AF_RXRPC: Move generic skbuff stuff from XFRM code to generic code

2007-03-08 Thread David Howells
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can use it too. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/linux/skbuff.h |4 + include/net/esp.h |2 - net/core/skbuff.c | 173 net/xfr

[PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work

2007-03-08 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/linux/workqueue.h | 21 + kernel/timer.c

[PATCH 4/5] AF_RXRPC: Key facility changes for AF_RXRPC

2007-03-08 Thread David Howells
Export the keyring key type definition. Add extra alternative types into the key's type_data union to make it more useful. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/linux/key.h |2 ++ security/keys/keyring.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-)

[PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-03-08 Thread David Howells
Add blkcipher accessors for using kernel data directly without the use of scatter lists. Also add a CRYPTO_ALG_DMA algorithm capability flag to permit or deny the use of DMA and hardware accelerators. A hardware accelerator may not be used to access any arbitrary piece of kernel memory lest it no

[PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-03-08 Thread David Howells
These patches together supply secure client-side RxRPC connectivity as a Linux kernel socket family. Only the transport/session side is supplied - the presentation side (marshalling the data) is left to the client. The userspace access methods make use of the control data passed to/by sendmsg()

Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

2007-03-08 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 08:47:51 +0100 > On 25-02-2007 10:08, Simon Arlott wrote: > > This happens on every boot if more information is needed: > > > > [ 37.393715] = > > [ 37.393830] [ INFO: inconsistent lock state ] > >

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 14:30 -0800, Jean Tourrilhes wrote: > Then, I assume that the powerpc64 must be using a magic > version of iwconfig to configure wireless interfaces, because I only > ever got one other bug report on the issue. They should have sent the > patch to Johannes, because now

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 11:22:06PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 14:11 -0800, Jean Tourrilhes wrote: > > > This is exactly what I was pointing out earlier. Well, > > actually, there may be ways of fixing it in the kernel, but that would > > be real ugly, and I don't want

Re: IPV6: make ipv6_getsockopt_sticky honor user's buffer size

2007-03-08 Thread David Miller
From: Chris Wright <[EMAIL PROTECTED]> Date: Wed, 7 Mar 2007 23:10:48 -0800 > Make sure not to copy_to_user more than user's buffer can handle (we > already checked the min, just use it) in ipv6_getsockopt_sticky. And > while there, minor whitespace cleanup now that ipv6_getsockopt_sticky > call

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 14:11 -0800, Jean Tourrilhes wrote: > First possiblity, we could stick with this band-aid > permanently. It sucks for various reasons, one for example being that I don't even understand your recognition code but all userspace programs that use wext will have to include

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 14:17:56 -0800 > I think that this is not actually an option since > powerpc64 is all 32-bit userspace. > Maybe some other arch-es are like this also (?). sparc64 is like this too - To unsubscribe from this list: send the line "unsubscr

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 02:17:56PM -0800, Randy Dunlap wrote: > On Thu, 8 Mar 2007 14:11:28 -0800 Jean Tourrilhes wrote: > > > > Third possibility : we declare 32 bit userspace on 64 bit > > kernel as not supported and advise users to get a 64 bit > > userspace. The number of bug report on tha

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Randy Dunlap
On Thu, 8 Mar 2007 14:11:28 -0800 Jean Tourrilhes wrote: > On Thu, Mar 08, 2007 at 08:40:01PM +0100, Johannes Berg wrote: > > On Thu, 2007-03-08 at 11:34 -0800, Jouni Malinen wrote: > > > > > Yes, workaround in just iwlib is not enough. If the only possible > > > solution is user space workaround

Re: skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch)

2007-03-08 Thread Chris Stromsoe
On Thu, 8 Mar 2007, Stephen Hemminger wrote: On Thu, 8 Mar 2007 13:31:13 -0800 (PST) Chris Stromsoe <[EMAIL PROTECTED]> wrote: Thanks. That fixes the soft lockup. I've got another problem now. The cards I'm using are dual port (sk-9844). I am bonding both ports together. The card presents

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 14:11 -0800, Jean Tourrilhes wrote: > This is exactly what I was pointing out earlier. Well, > actually, there may be ways of fixing it in the kernel, but that would > be real ugly, and I don't want to go there. Yeah, it would be extremely ugly and involve a lot of cop

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 08:40:01PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 11:34 -0800, Jouni Malinen wrote: > > > Yes, workaround in just iwlib is not enough. If the only possible > > solution is user space workaround, it better be documented (and > > communicated to maintainers of us

Re: asm volatile

2007-03-08 Thread David Miller
From: Sami Farin <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 20:23:57 +0200 > On Wed, Mar 07, 2007 at 00:24:35 +0200, Sami Farin wrote: > > On Tue, Mar 06, 2007 at 23:53:49 +0200, Sami Farin wrote: > > ... > > > And I found bug in gcc-4.1.2, it gave 0 for ncubic results > > > when doing 1000 loops t

Re: We have FUSE, could we have NUSE ?

2007-03-08 Thread David Miller
From: Matti Aarnio <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 12:53:20 +0200 > We do have a support of file-system engine in userspace process. > Could we have a socket interfaced network protocol engine in userspace ? People can and have done this using the TUN/TAP device. There is even an ad-hoc

Re: skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch)

2007-03-08 Thread Stephen Hemminger
On Thu, 8 Mar 2007 13:31:13 -0800 (PST) Chris Stromsoe <[EMAIL PROTECTED]> wrote: > Thanks. That fixes the soft lockup. > > I've got another problem now. The cards I'm using are dual port > (sk-9844). I am bonding both ports together. > > The card presents as eth2 and eth3. If I remove eth2

Re: skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch)

2007-03-08 Thread Jay Vosburgh
Chris Stromsoe <[EMAIL PROTECTED]> wrote: >Within 2 or 3 minutes after issuing > >ip link set bond1 mtu 9000 > >I get one "NETDEV WATCHDOG: eth2: transmit timed out" to the console, and >then this starts to repeat: > >BUG: soft lockup detected on CPU#0! I believe this is the same bug that

Re: skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch)

2007-03-08 Thread Chris Stromsoe
Thanks. That fixes the soft lockup. I've got another problem now. The cards I'm using are dual port (sk-9844). I am bonding both ports together. The card presents as eth2 and eth3. If I remove eth2 from the bond so that eth3 is the active interface, I get a hard lock (nothing prints to s

Re: netlink regression (since 2.6.18)

2007-03-08 Thread Stephen Hemminger
On Wed, 7 Mar 2007 14:28:30 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On a Ubuntu x86_64 machine the command: > tc qdisc ls > gets a RTNETLINK error. It looks like some data structure alignment > issue got introduced between 2.6.18 and 2.6.19-rc1 and continues on. > Since netlink da

Re: brctl issue

2007-03-08 Thread Stephen Hemminger
On Wed, 7 Mar 2007 22:30:09 -0500 "Hai Wang" <[EMAIL PROTECTED]> wrote: > Hello, > > I have a question regarding brctl and br2684, I have a network scenrio > where I have to add br2684-rt into a bridge. but I could not do so with > brctl, please let me if you have any suggestion on the is

[PATCH 6/8] tcp: whitespace cleanup

2007-03-08 Thread Stephen Hemminger
Add whitespace around keywords. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/tcp_hybla.c |2 - net/ipv4/tcp_input.c | 57 +++ net/ipv4/tcp_minisocks.c |6 ++-- net/ipv4/tcp_output.c| 34 ++--

[PATCH 3/8] network core: whitespace cleanup

2007-03-08 Thread Stephen Hemminger
Fix whitespace around keywords. Fix indentation especially of switch statements. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/compat.c | 30 +- net/core/ethtool.c |4 net/core/net-sysfs.c |4 net/core/pktgen.c| 16 - net/core/sock.c | 710

[PATCH 7/8] net: deinline some functions

2007-03-08 Thread Stephen Hemminger
Several functions are marked inline or forced inline, but it would be better to let the compiler decide. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/core/dev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- net-2.6.22.orig/net/core/dev.c 2007-03-07

[PATCH 5/8] ipv4 cleanup

2007-03-08 Thread Stephen Hemminger
Add whitespace around keywords. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/af_inet.c |2 net/ipv4/arp.c |2 net/ipv4/cipso_ipv4.c|2 net/ipv4/devinet.c |4 net/ipv4/fib_trie.c | 17 net/ipv4/ip_fragm

[PATCH 2/8] udp: ipv6 style cleanup

2007-03-08 Thread Stephen Hemminger
Fix whitespace around keywords. Eliminate unnecessary ()'s on return statements. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv6/udp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) --- net-2.6.22.orig/net/ipv6/udp.c 2007-03-07 10:18:04.0 -08

[PATCH 1/8] udp: ipv4 whitespace cleanup

2007-03-08 Thread Stephen Hemminger
Fix whitespace around keywords. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/udp.c | 95 - 1 file changed, 48 insertions(+), 47 deletions(-) --- net-2.6.22.orig/net/ipv4/udp.c 2007-03-07 10:18:04.0 -0800

[PATCH 4/8] wireless: use ARRAY_SIZE()

2007-03-08 Thread Stephen Hemminger
Use ARRAY_SIZE() macro now. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/core/wireless.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- net-2.6.22.orig/net/core/wireless.c 2007-03-07 15:16:15.0 -0800 +++ net-2.6.22/net/core/wireless.c 2007-03-07 1

[PATCH 8/8] udp: deinline

2007-03-08 Thread Stephen Hemminger
A couple of functions are exported or used indirectly so it is pointless to mark them as inline. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/udp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) --- net-2.6.22.orig/net/ipv4/udp.c 2007-03-07 14:51:07.0

[PATCH 0/8] net-2.6.22 spring cleaning

2007-03-08 Thread Stephen Hemminger
Tis the time of year to clean house. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] sky2: turn off Rx checksum on bad hardware

2007-03-08 Thread Stephen Hemminger
On Yukon FE, occasional hardware receive checksum errors are seen. An early indication of the problem is single bit differences in the two checksum engines. Use this as a detection mechanism to turn off Rx checksumming. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c

Re: [PATCH] Add xfrm policy change auditing to pfkey_spdget

2007-03-08 Thread Paul Moore
On Thursday, March 8 2007 11:20:15 am Eric Paris wrote: > I lose at using git. Sorry. I'll be more careful to check that all of > my changes on the current branch are committed before I run my git diff. > Or maybe someone will convince me to use git in an all new better way. [NOTE: I stripped a

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 11:34 -0800, Jouni Malinen wrote: > Yes, workaround in just iwlib is not enough. If the only possible > solution is user space workaround, it better be documented (and > communicated to maintainers of user space apps) well so that > all user space programs not using iwlib can

Re: skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch)

2007-03-08 Thread Stephen Hemminger
[SKGE]: Fix deadlock in skge_tx_timeout dev_watchdog() already holds the device lock, don't take it again in skge_tx_clean(). Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 0b1cfafa6f6b8a168d5811d1f65cf540942c52b1 tree 4d3f252d6618adfe812e9da95cd496bb798e7c7b parent 1ca949299260a

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jouni Malinen
On Thu, Mar 08, 2007 at 08:27:22PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 10:49 -0800, Jean Tourrilhes wrote: > > A proper fix would involve forcing the alignement in the > > kernel. Unfortunately, that would break 64bit->64bit configs. I think > > I can build a workaround for this

Re: asm volatile [Was: [RFC] div64_64 support]

2007-03-08 Thread Sami Farin
On Wed, Mar 07, 2007 at 00:24:35 +0200, Sami Farin wrote: > On Tue, Mar 06, 2007 at 23:53:49 +0200, Sami Farin wrote: > ... > > And I found bug in gcc-4.1.2, it gave 0 for ncubic results > > when doing 1000 loops test... gcc-4.0.3 works. > > Found it. > > --- cbrt-test.c~ 2007-03-07 00:20:54

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 10:49 -0800, Jean Tourrilhes wrote: > A proper fix would involve forcing the alignement in the > kernel. Unfortunately, that would break 64bit->64bit configs. I think > I can build a workaround for this in iwlib. Actually, other tools like network manager, wpa supplican

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 11:13 -0800, Jean Tourrilhes wrote: > I'm looking into that. The good thing is that we have > redundant information, so we can check that things don't match. It's a > bit more complex because some of those take variable parameters. Yeah, and it also only happens with t

skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch)

2007-03-08 Thread Chris Stromsoe
Within 2 or 3 minutes after issuing ip link set bond1 mtu 9000 I get one "NETDEV WATCHDOG: eth2: transmit timed out" to the console, and then this starts to repeat: BUG: soft lockup detected on CPU#0! [] show_trace_log_lvl+0x19/0x2e [] show_trace+0x12/0x14 [] dump_stack+0x14/0x16 [] softl

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 08:08:29PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 10:49 -0800, Jean Tourrilhes wrote: > > > A proper fix would involve forcing the alignement in the > > kernel. Unfortunately, that would break 64bit->64bit configs. I think > > I can build a workaround for t

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 10:49 -0800, Jean Tourrilhes wrote: > A proper fix would involve forcing the alignement in the > kernel. Unfortunately, that would break 64bit->64bit configs. I think > I can build a workaround for this in iwlib. Not easily I think. You'd have to get something that has

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 03:39:07PM +0100, Johannes Berg wrote: > On Tue, 2007-03-06 at 18:03 -0800, Jean Tourrilhes wrote: > > > Ok, please check the patch attached. I don't have a box to > > test that on, and on my 32 bit kernel it is not even compiled, but I > > believe I got everything all

Fw: [Bugme-new] [Bug 8151] New: Established connections not displayed in /proc/tcp/netstat

2007-03-08 Thread Andrew Morton
Begin forwarded message: Date: Thu, 8 Mar 2007 07:53:57 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 8151] New: Established connections not displayed in /proc/tcp/netstat http://bugzilla.kernel.org/show_bug.cgi?id=8151 Summary: Established connecti

Re: [RFC] use ktime for packet scheduling

2007-03-08 Thread Patrick McHardy
Stephen Hemminger wrote: > Here is the lastest version of the netem patch to use hrtimers. > It is against the current net tree, so it will need adjusting to fit > with new psched/ktime stuff. Thanks, I'll add whats still needed to my patches. - To unsubscribe from this list: send the line "unsubs

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 15:39 +0100, Johannes Berg wrote: > Oh, btw, this also means that we have an information leak on 64-bit > kernels. Those alignment bytes aren't ever cleared or anything, they > come right from the stack since most users of this just use a struct > iw_event on the stack which

Re: [PATCH] Add xfrm policy change auditing to pfkey_spdget

2007-03-08 Thread James Morris
On Thu, 8 Mar 2007, Eric Paris wrote: > which didn't have my fix up because i didn't commit it to my local > branch. Is there a better way to get a diff between my miller tree and > 'everything in the branch I have checked out even if it is not > committed'? I'd suggest you commit all your chang

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Johannes Berg
On Thu, 2007-03-08 at 15:39 +0100, Johannes Berg wrote: > Now, I don't know what gcc for ia64 does and I don't have a cross > compiler to check, but on powerpc it does this. As expected, the same happens on x86_64 (thanks to Michael Wu for the debug dump): <1>: Abbrev Number: 17 (DW_TAG_structu

Re: [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec resolution

2007-03-08 Thread Patrick McHardy
Eric Dumazet wrote: > On Thursday 08 March 2007 17:28, Patrick McHardy wrote: >>>--- a/include/asm-mips/sockios.h >>>+++ b/include/asm-mips/sockios.h >>>@@ -20,6 +20,7 @@ #define SIOCATMARK _IOR('s', 7, int) >>> #define SIOCSPGRP _IOW('s', 8, pid_t) >>> #define SIOCGPGRP _IOR('s', 9, pid_t) >>>

Re: [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec resolution

2007-03-08 Thread Eric Dumazet
On Thursday 08 March 2007 17:28, Patrick McHardy wrote: > Eric Dumazet wrote: > > --- a/include/asm-mips/sockios.h > > +++ b/include/asm-mips/sockios.h > > @@ -20,6 +20,7 @@ #define SIOCATMARK_IOR('s', 7, int) > > #define SIOCSPGRP _IOW('s', 8, pid_t) > > #define SIOCGPGRP _IOR('s', 9,

Re: [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec resolution

2007-03-08 Thread Patrick McHardy
Eric Dumazet wrote: > --- a/include/asm-mips/sockios.h > +++ b/include/asm-mips/sockios.h > @@ -20,6 +20,7 @@ #define SIOCATMARK _IOR('s', 7, int) > #define SIOCSPGRP_IOW('s', 8, pid_t) > #define SIOCGPGRP_IOR('s', 9, pid_t) > > -#define SIOCGSTAMP 0x8906 /* Get stam

Re: [PATCH] Add xfrm policy change auditing to pfkey_spdget

2007-03-08 Thread Eric Paris
On Wed, 2007-03-07 at 16:07 -0800, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Wed, 07 Mar 2007 15:43:16 -0800 (PST) > > > From: Eric Paris <[EMAIL PROTECTED]> > > Date: Fri, 02 Mar 2007 13:51:24 -0500 > > > > > pfkey_spdget neither had an LSM security hook nor auditing f

  1   2   >