Re: [GIT PATCH (TAKE 2)] [NET]: Use {htons,htonl,cpu_to_le16}() where appropriate.

2007-03-06 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 07 Mar 2007 16:08:21 +0900 (JST) > Dave, > > In article <[EMAIL PROTECTED]> (at Wed, 07 Mar 2007 14:58:07 +0900 (JST)), > YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says: > > > Please consider pulling following changesets from the

Re: [PATCH] NETLINK: convert NLMSG_GOODSIZE to constant expression.

2007-03-06 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 07 Mar 2007 16:34:01 +0900 (JST) > This fixes the following error: > : > | CC [M] net/ipv4/netfilter/ipt_ULOG.o > |net/ipv4/netfilter/ipt_ULOG.c:82: error: braced-group within expression > allowed only inside a function > |net/ipv4/n

[PATCH] NETLINK: convert NLMSG_GOODSIZE to constant expression.

2007-03-06 Thread YOSHIFUJI Hideaki / 吉藤英明
This fixes the following error: : | CC [M] net/ipv4/netfilter/ipt_ULOG.o |net/ipv4/netfilter/ipt_ULOG.c:82: error: braced-group within expression allowed only inside a function |net/ipv4/netfilter/ipt_ULOG.c:82: error: syntax error before "void" |make[1]: *** [net/ipv4/netfilter/ipt_ULOG.o] Erro

Re: Multipath routing in Linux 2.6

2007-03-06 Thread Jarek Poplawski
On 06-03-2007 21:36, Tore Anderson wrote: > > Hello list, > > I've been trying to figure out how to make equal-cost multipath > routing work, with no luck. Asked on the LARTC list with no success, It is probably one of the most often asked questions on the LARTC, so I'd suggest to look at

[GIT PATCH (TAKE 2)] [NET]: Use {htons,htonl,cpu_to_le16}() where appropriate.

2007-03-06 Thread YOSHIFUJI Hideaki / 吉藤英明
Dave, In article <[EMAIL PROTECTED]> (at Wed, 07 Mar 2007 14:58:07 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says: > Please consider pulling following changesets from the > "net-2.6.22-20070307a-byteorder-20070307" branch at > . Argh, I found more places to convert in bluetooth

Re: [RFC] ARP notify option

2007-03-06 Thread Pekka Savola
On Tue, 6 Mar 2007, Chris Friesen wrote: Stephen Hemminger wrote: +arp_notify - BOOLEAN + Define mode for notification of address and device changes. + 0 - (default): do nothing + 1 - Generate gratuitous arp replies when device is brought up + or hardware address cha

Update to cube root benchmark code

2007-03-06 Thread Willy Tarreau
Hi Stephen, Thanks for this code, it's easy to experiment with it. Let me propose this simple update with a variation on your ncubic() function. I noticed that all intermediate results were far below 32 bits, so I did a new version which is 30% faster on my athlon with the same results. This is be

[NET]: Use {htons,htonl,cpu_to_le16}() where appropriate.

2007-03-06 Thread YOSHIFUJI Hideaki / 吉藤英明
Dave, Please consider pulling following changesets from the "net-2.6.22-20070307a-byteorder-20070307" branch at . Thank you. HEADLINES - [NET] 802: Use hton{s,l}() where appropriate. [NET] 8021Q: Use htons() where appropriate. [NET] ATM: Use htons() where appropriate. [N

Re: [ubuntu-marketing] Why should we teach students Linux??

2007-03-06 Thread Melissa Draper
Roel Bindels wrote: > Hello listers, > > I'm tutor on the Faculty ICT, department NID. This is a bachelor degree > and we are preparing our students to become something more then just > System Administrators (such as manager, consulting, etc). Since this > department is part of the Microsoft ca

Re: [UDP]: Clean up UDP-Lite receive checksum

2007-03-06 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 12:41:00 +1100 > Hi Dave: > > [UDP]: Clean up UDP-Lite receive checksum > > This patch eliminates some duplicate code for the verification of > receive checksums between UDP-Lite and UDP. It does this by > introducing __skb_checksum_com

Re: [UDP6]: Restore sk_filter optimisation

2007-03-06 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 12:20:10 +1100 > Hi Dave: > > [UDP6]: Restore sk_filter optimisation > > This reverts the changeset > > [IPV6]: UDPv6 checksum. > > We always need to check UDPv6 checksum because it is mandatory. > > The sk_filter optimisation

Re: [UDP]: Reread uh pointer after pskb_trim

2007-03-06 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 12:00:20 +1100 > Hi Dave: > > [UDP]: Reread uh pointer after pskb_trim > > The header may have moved when trimming. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> IPV6 got this case right :-) Applied, and I'll push this to -stable

Re: [PATCH] NET : Optimizes inet_getpeer()

2007-03-06 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 11:33:20 +0100 > [PATCH] NET : Optimizes inet_getpeer() > > 1) Some sysctl vars are declared __read_mostly > > 2) We can avoid updating stack[] when doing an AVL lookup only. > > lookup() macro is extended to receive a second para

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Ralf Baechle
On Tue, Mar 06, 2007 at 07:39:21PM -0800, Michael K. Edwards wrote: > On 3/6/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: > >This small change btw. delivers about ~ 3% extra performance on a very > >slow test system. > > Has this change been tested / benchmarked under VMWare? pcnet32 is > the (de

Re: [PATCH] TCP Yeah: cleanup

2007-03-06 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 14:56:05 -0800 > > Eliminate need for full 6/4/64 divide to compute queue. > Variable maxqueue was really a constant. > Fix indentation. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsub

Re: [PATCH] tcp_cubic: faster cube root

2007-03-06 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 14:47:06 -0800 > The Newton-Raphson method is quadratically convergent so > only a small fixed number of steps are necessary. > Therefore it is faster to unroll the loop. Since div64_64 is no longer > inline it won't cause code expl

Re: [ATM] ENI: Convert to struct timeval to ktime_t.

2007-03-06 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 07 Mar 2007 11:31:39 +0900 (JST) > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More major

Re: IPv6 Davelopment Tree

2007-03-06 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Wed, 07 Mar 2007 11:30:30 +0900 (JST) > Please pull from "net-2.6.22-20070307-FOR_DAVEM-20070307" branch at > . Pulled, thank you very much. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
Rick Jones wrote: The timeout is also to cover datagrams which just got "stuck" somewhere too (IIRC) and may not necessarily require a multiple path situation. I guess that's a fair point. Originally, the only possible place for a packet to get "stuck" was in a router but I suppose that may no

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Michael K. Edwards
On 3/6/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: This small change btw. delivers about ~ 3% extra performance on a very slow test system. Has this change been tested / benchmarked under VMWare? pcnet32 is the (default?) virtual device presented by VMWare Workstation, and that's probably a la

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread David Stevens
> >Marking the master down would, I believe, issue notifiers that > > the device has gone down. Various things, network manager sort of > > applications in particular, listen to those, so I'm not sure it's a good > > idea. I think there are other side effects as well, I'm thinking it > > wo

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Ralf Baechle
On Tue, Mar 06, 2007 at 10:45:23AM -0800, Don Fry wrote: > The patch below moves the init_block out of the private struct and > only allocates init block with pci_alloc_consistent. > > This has two effects: > > 1. Performance increase for non cache coherent machines, because the >CPU only d

[ATM] ENI: Convert to struct timeval to ktime_t.

2007-03-06 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index 8fccf01..0d3a38b 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c @@ -536,7 +536,7 @@ static int rx_aal0(struct atm_vcc *vcc) return 0; } skb_put

Re: IPv6 Davelopment Tree

2007-03-06 Thread YOSHIFUJI Hideaki / 吉藤英明
Dave, In article <[EMAIL PROTECTED]> (at Tue, 06 Mar 2007 13:36:11 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Fri, 23 Feb 2007 12:53:01 +0900 (JST) > > > I have cooked up new git tree for IPv6 development. > > It is available as br

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Jean Tourrilhes
On Tue, Mar 06, 2007 at 07:43:06PM +0100, Michael Buesch wrote: > > Ok, it is wrapping the following ioctls: > > HANDLE_IOCTL(SIOCGIWRANGE, do_wireless_ioctl) > HANDLE_IOCTL(SIOCSIWSPY, do_wireless_ioctl) > HANDLE_IOCTL(SIOCGIWSPY, do_wireless_ioctl) > HANDLE_IOCTL(SIOCSIWTHRSPY, do_wireless_ioct

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread Andy Gospodarek
On Tue, Mar 06, 2007 at 03:15:41PM -0800, Jay Vosburgh wrote: > > David Stevens <[EMAIL PROTECTED]> wrote: > > >It looks to me like "rejoin" is essentially ip_mc_up(), and it'd be better > >to call that than add a nearly identical function. > > Won't ip_mc_up() acquire an additional refere

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Jean Tourrilhes
On Tue, Mar 06, 2007 at 07:43:06PM +0100, Michael Buesch wrote: > > > > Yep, and it's even in fs/compat_ioctl.c. Hint, hint ;-) > > Ok, it is wrapping the following ioctls: > > HANDLE_IOCTL(SIOCGIWRANGE, do_wireless_ioctl) > HANDLE_IOCTL(SIOCSIWSPY, do_wireless_ioctl) > HANDLE_IOCTL(SIOCGIWS

[PATCH 2/2] S2IO: Save/Restore unused buffer mappings in 2/3 buffer mode

2007-03-06 Thread Ramkrishna Vepa
- Save/Restore unused buffer mappings in 2/3 buffer mode to avoid frequent mapping - Save/Restore adapter reset count during adapter reset (Resending; forgot to cc netdev) Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> --- diff -Nurp patch1/drivers/net/s2io.c patch2/drivers/net/s2io.c ---

[PATCH 1/2] S2IO: Remove unused variables

2007-03-06 Thread Ramkrishna Vepa
- Remove unused variables from s2io_nic structure - Changed the memory failure printk messages to print only in debug mode - Updated the copyright messages (Resending; forgot to cc netdev) Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> --- diff -Nurp patch/drivers/net/s2io.c patch1/drive

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread David Stevens
[EMAIL PROTECTED] wrote on 03/06/2007 03:15:41 PM: > > David Stevens <[EMAIL PROTECTED]> wrote: > > >It looks to me like "rejoin" is essentially ip_mc_up(), and it'd be better > >to call that than add a nearly identical function. > >Won't ip_mc_up() acquire an additional reference (via > i

RE: [PATCH] s2io: add PCI error recovery support

2007-03-06 Thread Ramkrishna Vepa
Jeff, Please apply and forward this patch upstream. Ram > -Original Message- > From: Ramkrishna Vepa > Sent: Monday, March 05, 2007 2:34 PM > To: 'Linas Vepstas' > Cc: Wen Xiong; linux-kernel@vger.kernel.org; linux- > [EMAIL PROTECTED]; netdev@vger.kernel.org; Jeff Garzik; Andrew > Morton

Re: [patch 2/2] div64_64: common code

2007-03-06 Thread Andrew Morton
On Tue, 06 Mar 2007 15:21:40 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Tue, 6 Mar 2007 14:32:06 -0800 > > > ho hum, I didn't know that, so we missed rc2-mm2. > > > > Could I have symlinks in /pub/scm/linux/kernel/git/davem/ to net-lates

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Herbert Xu
On Tue, Mar 06, 2007 at 04:05:57PM -0800, David Miller wrote: > > Actually, more accurately it's using PAGE_SIZE. :) Aha it's you non-i386 people :) > I see, so the better fix would be to make glibc's > netlink_request() function start with a getpagesize()'d > buffer. Yes that's a good idea. Ch

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 7 Mar 2007 11:04:19 +1100 > On Tue, Mar 06, 2007 at 04:02:02PM -0800, David Miller wrote: > > > > Create a lot of intefaces, try to dump them :-) > > Dumps should be done using 4K (NLMSG_GOODSIZE) skb's, where is the problem? Actually, more accurat

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Herbert Xu
On Tue, Mar 06, 2007 at 03:57:50PM -0800, Stephen Hemminger wrote: > > I know some commands send big blocks down of configuration information. > One example is netem statistical data, but there are others. You mean dumps? Unless someone is coalescing them I don't see a problem there. Cheers, --

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Herbert Xu
On Tue, Mar 06, 2007 at 04:02:02PM -0800, David Miller wrote: > > Create a lot of intefaces, try to dump them :-) Dumps should be done using 4K (NLMSG_GOODSIZE) skb's, where is the problem? > GLIBC can even hit this via it's ifaddrs.c code. Do you have a simple test case that I can run? Thanks,

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 07 Mar 2007 10:49:07 +1100 > Which netlink family generates (or needs to generate) unbounded > messages to user-space? Or indeed which ones generate messages > greater than 64K (or 4K for that matter)? Create a lot of intefaces, try to dump them :-)

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Stephen Hemminger
On Wed, 07 Mar 2007 10:49:07 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > David Miller <[EMAIL PROTECTED]> wrote: > > > > I guess one thing the user could do when it sees MSG_TRUNC > > is keep calling recvmsg() until the receive queue is emptied > > of packets, in order to get that pesky nlk->cb

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > I guess one thing the user could do when it sees MSG_TRUNC > is keep calling recvmsg() until the receive queue is emptied > of packets, in order to get that pesky nlk->cb cleared to > NULL, then resubmit. > > But that's rediculous and complicated. > >

Re: netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread James Morris
On Tue, 6 Mar 2007, David Miller wrote: > I guess one thing the user could do when it sees MSG_TRUNC > is keep calling recvmsg() until the receive queue is emptied > of packets, in order to get that pesky nlk->cb cleared to > NULL, then resubmit. > > But that's rediculous and complicated. > > An

Re: [RFC] div64_64 support

2007-03-06 Thread Sami Farin
On Tue, Mar 06, 2007 at 23:53:49 +0200, Sami Farin wrote: ... > And I found bug in gcc-4.1.2, it gave 0 for ncubic results > when doing 1000 loops test... gcc-4.0.3 works. Found it. --- cbrt-test.c~2007-03-07 00:20:54.735248105 +0200 +++ cbrt-test.c 2007-03-07 00:21:03.964864343 +0200 @@

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
Stephen Hemminger wrote: TCP can not assume anything about the path that a packet may take. We have declared a moratorium on loopback benchmark foolishness. Go optimize the idle loop instead ;-) Sure - A delay loop with fewer instructions is a worthwhile optimization because it has less impact o

Re: [patch 2/2] div64_64: common code

2007-03-06 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 14:32:06 -0800 > ho hum, I didn't know that, so we missed rc2-mm2. > > Could I have symlinks in /pub/scm/linux/kernel/git/davem/ to net-latest and > sparc-latest please? When we are in a merge window, I have only one tree for sparc an

netlink recvmsg() and MSG_TRUNC

2007-03-06 Thread David Miller
So if you don't give a large enough buffer to recvmsg() for the netlink response a few things happen: 1) MSG_TRUNC is set 2) The length returned and the amount of data copied is the size given in the recvmsg() call 3) If enough other packets remain in the receive buffer, nlk->cb is left at

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread Jay Vosburgh
David Stevens <[EMAIL PROTECTED]> wrote: >It looks to me like "rejoin" is essentially ip_mc_up(), and it'd be better >to call that than add a nearly identical function. Won't ip_mc_up() acquire an additional reference (via ip_mc_inc_group) to the IGMP_ALL_HOSTS im->users that would never

Re: [RFC] div64_64 support

2007-03-06 Thread Sami Farin
On Tue, Mar 06, 2007 at 10:29:41 -0800, Stephen Hemminger wrote: > Don't count the existing Newton-Raphson out. It turns out that to get enough > precision for 32 bits, only 4 iterations are needed. By unrolling those, it > gets much better timing. > > Slightly gross test program (with original cu

cube root benchmark code

2007-03-06 Thread Stephen Hemminger
Here is a better version of the benchmark code. It has the original code used in 2.4 version of Cubic for comparison --- /* Test and measure perf of cube root algorithms. */ #include #include #include #include #include #ifdef __x86_64

[PATCH] TCP Yeah: cleanup

2007-03-06 Thread Stephen Hemminger
Eliminate need for full 6/4/64 divide to compute queue. Variable maxqueue was really a constant. Fix indentation. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/tcp_yeah.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deleti

Re: TCP 2MSL on loopback

2007-03-06 Thread Stephen Hemminger
On Tue, 06 Mar 2007 14:07:09 -0800 Howard Chu <[EMAIL PROTECTED]> wrote: > David Miller wrote: > > From: Rick Jones <[EMAIL PROTECTED]> > > Date: Tue, 06 Mar 2007 13:25:35 -0800 > > > >>> On the other hand, being able to configure a small MSL for the loopback > >>> device is perfectly safe. Bein

Re: [RFC] ARP notify option

2007-03-06 Thread Stephen Hemminger
On Tue, 06 Mar 2007 15:18:07 -0600 "Chris Friesen" <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > > +arp_notify - BOOLEAN > > + Define mode for notification of address and device changes. > > + 0 - (default): do nothing > > + 1 - Generate gratuitous arp replies when device is bro

[PATCH] tcp_cubic: faster cube root

2007-03-06 Thread Stephen Hemminger
The Newton-Raphson method is quadratically convergent so only a small fixed number of steps are necessary. Therefore it is faster to unroll the loop. Since div64_64 is no longer inline it won't cause code explosion. Also fixes a bug that can occur if x^2 was bigger than 32 bits. Signed-off-by: St

Re: [patch 2/2] div64_64: common code

2007-03-06 Thread Andrew Morton
On Tue, 06 Mar 2007 10:11:40 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: [EMAIL PROTECTED] > Date: Tue, 06 Mar 2007 02:42:28 -0800 > > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > > > Implement div64_64(): 64-bit by 64-bit division. Needed by networking (at > > least). > >

Re: [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread David Stevens
It looks to me like "rejoin" is essentially ip_mc_up(), and it'd be better to call that than add a nearly identical function. Also, real interfaces already do gratuitous IGMP advertisements when they are bounced (the reason there is an ip_mc_up()). Could bonding, when failing over, simply mark the

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread David Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 14:26:04 +0100 > David Miller writes: > > > Actually, more accurately, the conflict exists in how this GC > > logic is implemented. The core issue is that hash table size > > guides the GC processing, and hash table growth therefo

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
David Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 06 Mar 2007 13:25:35 -0800 On the other hand, being able to configure a small MSL for the loopback device is perfectly safe. Being able to configure a small MSL for other interfaces may be safe, depending on the rest of the ne

Re: [RFC] ARP notify option

2007-03-06 Thread Chris Friesen
Stephen Hemminger wrote: +arp_notify - BOOLEAN + Define mode for notification of address and device changes. + 0 - (default): do nothing + 1 - Generate gratuitous arp replies when device is brought up + or hardware address changes. Did you consider using gratuitous

Re: [RFC PATCH] [TCP]: Reworked recovery's TCPCB_LOST marking functions

2007-03-06 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Wed, 7 Mar 2007 00:01:46 +0200 > * David Miller <[EMAIL PROTECTED]> [070306 23:47]: > > From: Baruch Even <[EMAIL PROTECTED]> > > Date: Tue, 6 Mar 2007 21:42:59 +0200 > > > > > * Ilpo J?rvinen <[EMAIL PROTECTED]> [070306 14:52]: > > > > +

Re: [RFC PATCH] [TCP]: Reworked recovery's TCPCB_LOST marking functions

2007-03-06 Thread Baruch Even
* David Miller <[EMAIL PROTECTED]> [070306 23:47]: > From: Baruch Even <[EMAIL PROTECTED]> > Date: Tue, 6 Mar 2007 21:42:59 +0200 > > > * Ilpo J?rvinen <[EMAIL PROTECTED]> [070306 14:52]: > > > + newtp->highest_sack = treq->snt_isn + 1; > > > > That's the only initialization that you have

Re: [RFC] div64_64 support

2007-03-06 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 10:29:41 -0800 > /* calculate the cubic root of x using Newton-Raphson */ > static uint32_t ncubic(uint64_t a) > { > uint64_t x; > > /* Initial estimate is based on: >* cbrt(x) = exp(log(x) / 3) >*/ >

Re: [RFC PATCH] [TCP]: Reworked recovery's TCPCB_LOST marking functions

2007-03-06 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 21:42:59 +0200 > * Ilpo J?rvinen <[EMAIL PROTECTED]> [070306 14:52]: > > + newtp->highest_sack = treq->snt_isn + 1; > > That's the only initialization that you have for highest_sack, I think > that you should initialize it when

Re: [patch 2/2] div64_64: common code

2007-03-06 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 19:46:32 + > On Tue, Mar 06, 2007 at 02:42:28AM -0800, [EMAIL PROTECTED] wrote: > > > Implement div64_64(): 64-bit by 64-bit division. Needed by networking (at > > least). > > Your patch only implements div64_64() for 32-bit MIPS.

Re: [PATCH] fix compat_sock_common_getsockopt typo

2007-03-06 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 10:06:00 -0500 (EST) > On Tue, 6 Mar 2007, Johannes Berg wrote: > > > This patch fixes a typo in compat_sock_common_getsockopt. > > > > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> > > > > --- wireless-dev.orig/net/core/sock.c

Re: IPv6 Davelopment Tree

2007-03-06 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 23 Feb 2007 12:53:01 +0900 (JST) > I have cooked up new git tree for IPv6 development. > It is available as branch named > 2.6.21-rc1-net-2.6-20070223-FOR_DAVEM-20070223 > at > . > > I will shift to new branch time to time (e.g. e

Re: TCP 2MSL on loopback

2007-03-06 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 06 Mar 2007 13:25:35 -0800 > > On the other hand, being able to configure a small MSL for the loopback > > device is perfectly safe. Being able to configure a small MSL for other > > interfaces may be safe, depending on the rest of the network layo

Re: many sockets, slow sendto

2007-03-06 Thread Zacco
Hi, Thx a lot you for the advice, I'll have a try. And sorry for the stupid webmail, I will not use it again. Zacco Andi Kleen wrote: Zaccomer Lajos <[EMAIL PROTECTED]> writes: I'm playing around with a simulation, in which many thousands of IP addresses (on interface aliases) are used

Re: TCP 2MSL on loopback

2007-03-06 Thread Rick Jones
On the other hand, being able to configure a small MSL for the loopback device is perfectly safe. Being able to configure a small MSL for other interfaces may be safe, depending on the rest of the network layout. A peanut gallery question - I seem to recall prior discussions about how one cann

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
Eric Dumazet wrote: Arf... dont tell me you forgot to do this... echo 1 >/proc/sys/net/ipv4/tcp_tw_recycle echo 1 >/proc/sys/net/ipv4/tcp_tw_reuse That does not appear to me to be a safe thing to do on a production machine. Tweaks that are only good in a test environment really don't help t

Multipath routing in Linux 2.6

2007-03-06 Thread Tore Anderson
Hello list, I've been trying to figure out how to make equal-cost multipath routing work, with no luck. Asked on the LARTC list with no success, and attempts to contact the two authors privately yielded one bounce while the other declined to answer in private and pointed me to this list

Re: [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread Andy Gospodarek
On 3/6/07, Jay Vosburgh <[EMAIL PROTECTED]> wrote: Brian Haley <[EMAIL PROTECTED]> wrote: >Andy Gospodarek wrote: >> If we are easily able to differentiate between the multicast addresses >> in the mc_list as to which are for ipv4 and which are for ipv6 then it >> would be easy to call-out to so

Re: TCP 2MSL on loopback

2007-03-06 Thread Rick Jones
With transparant bridging, nobody knows how long the datagram may be out there. Admittedly, the chances of a datagram living for a full two minutes these days is probably nil, but just being in the same IP subnet doesn't really mean anything when it comes to physical locality. Bridging isn't

Re: TCP 2MSL on loopback

2007-03-06 Thread Eric Dumazet
Howard Chu a écrit : Eric Dumazet wrote: Let me see, any chance you can try the prog on 2.6.20 ? Not any time soon. If not, please send : grep . /proc/sys/net/ipv4/* This is the output on the laptop: /proc/sys/net/ipv4/icmp_echo_ignore_all:0 /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts:

Re: [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread Jay Vosburgh
Brian Haley <[EMAIL PROTECTED]> wrote: >Andy Gospodarek wrote: >> If we are easily able to differentiate between the multicast addresses >> in the mc_list as to which are for ipv4 and which are for ipv6 then it >> would be easy to call-out to something in the ipv6 mcast code when >> needed instead

[NET] netxen: fix warnings

2007-03-06 Thread Ralf Baechle
CC [M] drivers/net/netxen/netxen_nic_hw.o drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_hw_resources': drivers/net/netxen/netxen_nic_hw.c:231: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'dma_addr_t' drivers/net/netxen/netxen_nic_hw.c:250:

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
Eric Dumazet wrote: Let me see, any chance you can try the prog on 2.6.20 ? Not any time soon. If not, please send : grep . /proc/sys/net/ipv4/* This is the output on the laptop: /proc/sys/net/ipv4/icmp_echo_ignore_all:0 /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts:1 /proc/sys/net/ipv4/i

Re: [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread Brian Haley
Andy Gospodarek wrote: If we are easily able to differentiate between the multicast addresses in the mc_list as to which are for ipv4 and which are for ipv6 then it would be easy to call-out to something in the ipv6 mcast code when needed instead of always calling out to ipv4 code. I've been un

Re: [RFC] div64_64 support

2007-03-06 Thread Stephen Hemminger
On Tue, 6 Mar 2007 20:48:41 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Tue, Mar 06, 2007 at 10:29:41AM -0800, Stephen Hemminger wrote: > > Don't count the existing Newton-Raphson out. It turns out that to get enough > > precision for 32 bits, only 4 iterations are needed. By unrolling those,

Re: TCP 2MSL on loopback

2007-03-06 Thread Eric Dumazet
Howard Chu a écrit : Eric Dumazet wrote: On Tuesday 06 March 2007 10:22, Howard Chu wrote: It's a combination of 2MSL and /proc/sys/net/ipv4/ip_local_port_range - on my system the default port range is 32768-61000. That means if I use up 28232 ports in less than 2MSL then everything stops. net

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-06 Thread Greg KH
On Tue, Mar 06, 2007 at 12:10:09AM -0600, Matt Mackall wrote: > On Mon, Mar 05, 2007 at 08:03:50PM -0800, Greg KH wrote: > > On Mon, Mar 05, 2007 at 09:39:47PM -0600, Matt Mackall wrote: > > > On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: > > > > If so, can you disable the option and str

Re: [patch 2/2] div64_64: common code

2007-03-06 Thread Ralf Baechle
On Tue, Mar 06, 2007 at 02:42:28AM -0800, [EMAIL PROTECTED] wrote: > Implement div64_64(): 64-bit by 64-bit division. Needed by networking (at > least). Your patch only implements div64_64() for 32-bit MIPS. Below patch adds the trivial 64-bit bits. Ralf Signed-off-by: Ralf Baechle <[EMAIL

Re: [RFC] div64_64 support

2007-03-06 Thread Andi Kleen
On Tue, Mar 06, 2007 at 10:29:41AM -0800, Stephen Hemminger wrote: > Don't count the existing Newton-Raphson out. It turns out that to get enough > precision for 32 bits, only 4 iterations are needed. By unrolling those, it > gets much better timing. But did you fix the >2^43 bug too? SGI has alr

Re: [ofa-general] [PATCH 2.6.21-rc2] iw_cxgb3: Don't use mm after its freed in iwch_mmap().

2007-03-06 Thread Roland Dreier
Thanks, applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] [TCP]: Reworked recovery's TCPCB_LOST marking functions

2007-03-06 Thread Baruch Even
* Ilpo J?rvinen <[EMAIL PROTECTED]> [070306 14:52]: > Complete rewrite for update_scoreboard and mark_head_lost. Couple > of hints became unnecessary because of this change. Changes > !TCPCB_TAGBITS check from the original to !(S|L) but it shouldn't > make a difference, and if there ever is an R on

Re: when having to acquire an SA, ipsec drops the packet

2007-03-06 Thread James Morris
On Tue, 6 Mar 2007, Joy Latten wrote: > > I saw something similar to this some time ago when testing various > > failure modes, and discused it with Herbert. > > > > IIRC, there's a larval SA which is not torn down properly by Racoon once > > the full SA is established, and the larval SA keeps

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
Rick Jones wrote: This is probably not something that happens in real world deployments. I But it's not 60,000 concurrent connections, it's 60,000 within a 2 minute span. Sounds like a case of Doctor! Doctor! It hurts when I do this. I guess. In the cases where it matters, we use LDAP over U

[PATCH]: Revert accept queue backlog change.

2007-03-06 Thread David Miller
Wei, I have to revert your change, it is incorrect as pointed out by other people here on netdev. BSD sockets basically define the 'backlog' parameter to listen() to mean "allow backlog + 1" connections to be queued to the socket. This allows a backlog parameter of "0" to allow 1 connection, and

Re: [NET]: Please revert disallowing zero listen queues

2007-03-06 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 06 Mar 2007 10:54:00 -0800 > > So we're not "disallowing" a backlog argument of zero to > > listen(). We'll accept that just fine, the only thing that > > happens is that you'll get what you ask for, that being > > no connections :-) > > I'm not su

[PATCH] ixgb: Use ARRAY_SIZE macro when appropriate.

2007-03-06 Thread Auke Kok
From: Ahmed S. Darwish <[EMAIL PROTECTED]> Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_param.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgb/ixgb_param.c b/drivers/net/ixg

Re: [RFC] ARP notify option

2007-03-06 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > This adds another inet device option to enable gratuitous ARP > when device is brought up or address change. This is handy for > clusters or virtualization. This looks good. I'll test with Xen. What about the source addr selection? thanks, -chris

Re: [RFC] ARP notify option

2007-03-06 Thread Jeremy Fitzhardinge
Stephen Hemminger wrote: > This adds another inet device option to enable gratuitous ARP > when device is brought up or address change. This is handy for > clusters or virtualization. > Thanks Stephen. Haven't tested this yet, but it definitely cleans up a warty corner of netfront. J - To

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-06 Thread Greg KH
On Tue, Mar 06, 2007 at 12:10:09AM -0600, Matt Mackall wrote: > On Mon, Mar 05, 2007 at 08:03:50PM -0800, Greg KH wrote: > > On Mon, Mar 05, 2007 at 09:39:47PM -0600, Matt Mackall wrote: > > > On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: > > > > If so, can you disable the option and str

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Robert Olsson
Eric Dumazet writes: > With 2^20 entries, your actual limit of 2^19 entries in root node will > probably show us quite different numbers for order-1,2,3,4... tnodes Yeep trie will get deeper and lookup more costly as insert and delete. The 2^19 was that was getting memory alloction problem

Re: [NET]: Please revert disallowing zero listen queues

2007-03-06 Thread Rick Jones
So we're not "disallowing" a backlog argument of zero to listen(). We'll accept that just fine, the only thing that happens is that you'll get what you ask for, that being no connections :-) I'm not sure where HP-UX inherited the 0 = 1 bit - perhaps from BSD, nor am I sure there is official ch

[PATCH 2/2] pcnet32: change to use netdev_priv

2007-03-06 Thread Don Fry
use netdev_priv() instead of dev->priv Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.6.21-rc2/drivers/net/one.pcnet32.c 2007-03-06 10:48:37.0 -0800 +++ linux-2.6.21-rc2/drivers/net/pcnet32.c 2007-03-05 18:03:32.

Re: [RFC] div64_64 support

2007-03-06 Thread H. Peter Anvin
Andi Kleen wrote: Let me see... You throw code like that and expect someone to actually understand it in one year, and be able to correct a bug ? To be honest I don't expect any bugs in this function. Please add something, an URL or even better a nice explanation, per favor... It's stra

[RFC] ARP notify option

2007-03-06 Thread Stephen Hemminger
This adds another inet device option to enable gratuitous ARP when device is brought up or address change. This is handy for clusters or virtualization. Tested on a normal device (not Xen). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- Documentation/networking/ip-sysctl.txt |6 ++

Re: [RFC] div64_64 support II

2007-03-06 Thread H. Peter Anvin
Andi Kleen wrote: The problem with these algorithms that tradoff one or more multiplies in order to avoid a divide is that they don't give anything and often lose when both multiplies and divides are emulated in software. Actually on rereading this: is there really any Linux port that emulates

Re: TCP 2MSL on loopback

2007-03-06 Thread Rick Jones
This is probably not something that happens in real world deployments. I But it's not 60,000 concurrent connections, it's 60,000 within a 2 minute span. Sounds like a case of Doctor! Doctor! It hurts when I do this. I'm not saying this is a high priority problem, I only encountered it in a

Re: [NET]: Please revert disallowing zero listen queues

2007-03-06 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 06 Mar 2007 10:37:06 -0800 (PST) > Everything I've ever seen clearly states that a backlog of > zero means that zero connections are allowed. > > So we're not "disallowing" a backlog argument of zero to > listen(). We'll accept that just fine, th

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Michael Buesch
On Tuesday 06 March 2007 18:13, Jean Tourrilhes wrote: > On Tue, Mar 06, 2007 at 02:27:26AM +0100, Johannes Berg wrote: > > Hi, > > > > Wtf! After struggling with some strange problems with zd1211rw (see some > > other mail) I decided to think again about what could possibly cause all > > the othe

Re: linux 2.6 Ipv4 routing enhancement (fwd)

2007-03-06 Thread Robert Olsson
Richard Kojedzinszky writes: > Sorry for sending the tgz with .svn included. And i did not send > instructions. > To do a test with fib_trie, issue > $ make clean all ROUTE_ALG=TRIE & ./try a > with fib_radix: > $ make clean all ROUTE_ALG=RADIX & ./try a > with fib_lef: > $ make clean al

  1   2   3   >