Re: [PATCH 1/3] Advance fast path pointer for first block only

2007-01-31 Thread Baruch Even
* David Miller <[EMAIL PROTECTED]> [070131 22:48]: > From: Baruch Even <[EMAIL PROTECTED]> > Date: Mon, 29 Jan 2007 09:13:39 +0200 > > > Only advance the SACK fast-path pointer for the first block, the fast-path > > assumes that only the first block advances next time so we should not move > > th

Re: [PATCH 3/3] Check num sacks in SACK fast path

2007-01-31 Thread Baruch Even
* David Miller <[EMAIL PROTECTED]> [070131 22:52]: > From: Baruch Even <[EMAIL PROTECTED]> > Date: Mon, 29 Jan 2007 09:13:49 +0200 > > > When we check for SACK fast path make sure that we also have the same > > number of > > SACK blocks in the cache and in the new SACK data. This prevents us from

Re: [PATCH] HTB O(1) class lookup

2007-01-31 Thread Simon Lodal
On Thursday 01 February 2007 07:08, Patrick McHardy wrote: > Simon Lodal wrote: > > This patch changes HTB's class storage from hash+lists to a two-level > > linear array, so it can do constant time (O(1)) class lookup by classid. > > It improves scalability for large number of classes. > > > > Wit

Re: [PATCH] HTB O(1) class lookup

2007-01-31 Thread Patrick McHardy
Simon Lodal wrote: > This patch changes HTB's class storage from hash+lists to a two-level linear > array, so it can do constant time (O(1)) class lookup by classid. It improves > scalability for large number of classes. > > Without the patch, ~14k htb classes can starve a Xeon-3.2 at only 15kpp

[PATCH] HTB O(1) class lookup

2007-01-31 Thread Simon Lodal
This patch changes HTB's class storage from hash+lists to a two-level linear array, so it can do constant time (O(1)) class lookup by classid. It improves scalability for large number of classes. Without the patch, ~14k htb classes can starve a Xeon-3.2 at only 15kpps, using most of it's cycle

[RFC][PATCH][XFRM][1/5] extension to XFRM for dynamic endpoint update (MIGRATE)

2007-01-31 Thread Shinta Sugimoto
Signed-off-by: Shinta Sugimoto <[EMAIL PROTECTED]> diff --git a/include/net/xfrm.h b/include/net/xfrm.h index e476541..eb61a99 100644 --- a/include/net/xfrm.h +++ b/include/net/xfrm.h @@ -12,6 +12,7 @@ #include #include #include #include +#include #include #include @@ -29,6 +30,8 @@

[RFC][PATCH][XFRM][4/5] extension to XFRM for dynamic endpoint update (MIGRATE)

2007-01-31 Thread Shinta Sugimoto
Signed-off-by: Shinta Sugimoto <[EMAIL PROTECTED]> diff --git a/include/linux/pfkeyv2.h b/include/linux/pfkeyv2.h index 265bafa..26a518b 100644 --- a/include/linux/pfkeyv2.h +++ b/include/linux/pfkeyv2.h @@ -251,7 +251,8 @@ #define SADB_X_SPDSETIDX20 #define SADB_X_SPDEXPIRE 21 #define

[RFC][PATCH][XFRM][0/5] extension for XFRM databases

2007-01-31 Thread Shinta Sugimoto
Hello, Let me issue a request for comments for the patch set developed by the USAGI project. The patch set aims to extend the XFRM framework so that endpoint addresses in the XFRM databases, namely XFRM policy and XFRM state can be dynamically updated according to a request from user application.

[RFC][PATCH][XFRM][2/5] extension to XFRM for dynamic endpoint update (MIGRATE)

2007-01-31 Thread Shinta Sugimoto
Signed-off-by: Shinta Sugimoto <[EMAIL PROTECTED]> diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 82f36d3..637318d 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -1632,6 +1632,184 @@ static int xfrm_add_acquire(struct sk_bu return 0; } +#ifdef CONFIG_XFR

[RFC][PATCH][XFRM][5/5] extension to XFRM for dynamic endpoint update (MIGRATE)

2007-01-31 Thread Shinta Sugimoto
Signed-off-by: Shinta Sugimoto <[EMAIL PROTECTED]> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index 0faab63..fbaab2f 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -34,4 +41,14 @@ config NET_KEY Say Y unless you know what you are doing. +config NET_KEY_MIGRATE +

[RFC][PATCH][XFRM][3/5] extension to XFRM for dynamic endpoint update (MIGRATE)

2007-01-31 Thread Shinta Sugimoto
Signed-off-by: Shinta Sugimoto <[EMAIL PROTECTED]> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index 0faab63..fbaab2f 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -24,6 +24,13 @@ config XFRM_SUB_POLICY If unsure, say N. +config XFRM_MIGRATE + bool "Transformatio

[PATCH] [v4] PA Semi PWRficient Ethernet driver

2007-01-31 Thread Olof Johansson
Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) Basic enablement, will be complemented with performance enhancements over time. PHY support will be added as well. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- v4 changes: * Check for dma mapping error * Sparse cleanups * Move

Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver

2007-01-31 Thread Olof Johansson
On Wed, Jan 31, 2007 at 05:34:06AM -0500, Jeff Garzik wrote: > Olof Johansson wrote: > >Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) > > > >Basic enablement, will be complemented with performance enhancements > >over time. PHY support will be added as well. > > > >Signed-off-by: Olof

Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver

2007-01-31 Thread Olof Johansson
On Wed, Jan 31, 2007 at 10:38:06AM -0800, Stephen Hemminger wrote: > O > > +static noinline void pasemi_mac_free_tx_resources(struct net_device *dev) > > Why tell compiler how to do it's job. marking it noinline? Leftover from debugging. Gone in the next version. > Mixing definitions and struct

Re: [PATCH] r8169: fix a race between PCI probe and dev_open

2007-01-31 Thread Herbert Xu
Francois Romieu <[EMAIL PROTECTED]> wrote: > > rtl8169_init_phy is only used on rtl8169_init_one so it's fine to never > ask it to activate the timer: the racing dev->open will do it anyway. Does rtl8169_init_phy need to occur after register_netdev? Normally register_netdev should be the very las

Re: [PATCH 1/10] cxgb3 - FW versioning

2007-01-31 Thread Divy Le Ray
Hi Jeff, Please see my replies in line. You need to submit a patch to remove the following ioctls: CHELSIO_SETREG: CHELSIO_GETREG: These will get removed. CHELSIO_SET_QSET_PARAMS: (use ethtool instead) CHELSIO_GET_QSET_PARAMS: (use ethtool instead) The T3 adapter supports multiple Tx/Rx q

Re: [Ipw2100-devel] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Zhu Yi
On Wed, 2007-01-31 at 07:52 +, Matthew Garrett wrote: > Based on previous discussions, I've implemented a rough attempt at > providing some level of basic runtime power management on the ipw2100 > chipset. This patch does the following: > > 1) On load, it initialises the hardware and then qu

Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.

2007-01-31 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Offload packets may be DMAed long after their SGE Tx descriptors are done so they must remain mapped until they are freed rather than until their descriptors are freed. Unmap such packets through an skb destructor.

[PATCH 2.6.20-rc7 2/2] atl1: add ethtool set ring params functionality

2007-01-31 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> Fix up some constants relating to max and min ring descriptor counts. Also add functionality to enable ethtool to set tx and rx ring parameters. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1.h |4 +- drivers/net/atl1/a

[PATCH 2.6.20-rc7 1/2] atl1: get rid of pci_module_init

2007-01-31 Thread Jay Cliburn
From: Jay Cliburn <[EMAIL PROTECTED]> pci_module_init is deprecated. Use pci_register_driver instead. Discovered by and modification suggested by Alan Cox. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |5 + 1 files changed, 1 insertions(+), 4 deletion

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-31 Thread Marcelo Tosatti
Hi Jiri, On Sat, Jan 20, 2007 at 06:15:54PM -0200, Marcelo Tosatti wrote: > On Wed, Jan 17, 2007 at 04:43:28PM +0100, Jiri Benc wrote: > > On Wed, 17 Jan 2007 10:01:12 -0500, Dan Williams wrote: > > > But could we please be constructive here, and actually take a look at > > > the driver and point

Re: [PATCH] r8169: fix a race between PCI probe and dev_open

2007-01-31 Thread Linus Torvalds
On Wed, 31 Jan 2007, Francois Romieu wrote: > Call chain: > -> rtl8169_init_one >-> register_netdev (dev_open starts to race...) >-> rtl8169_init_phy > -> rtl8169_set_speed > -> tp->set_speed > -> mod_timer(&tp->timer, ...) (if netif_running() is

[PATCH] ieee80211: Fix sparse warning

2007-01-31 Thread Larry Finger
Sparse issues the warning "warning: symbol 'crypt' shadows an earlier one" in net/ieee80211/ieee80211_tx.c. Signed-off-by: Larry Finger <[EMAIL PROTECTED]> --- Index: wireless-2.6/net/ieee80211/ieee80211_tx.c === --- wireless-2.6.ori

[PATCH ethtool] marvell chip decode formatting

2007-01-31 Thread Stephen Hemminger
Fix some typo's and formatting on Marvell ethtool output. If sync transmit queue is not used, don't print settings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- marvell.c | 37 - 1 files changed, 24 insertions(+), 13 deletions(-) diff --git a/mar

[NET_SCHED]: act_ipt: fix regression in ipt action

2007-01-31 Thread Patrick McHardy
[NET_SCHED]: act_ipt: fix regression in ipt action The x_tables patch broke target module autoloading in the ipt action by replacing the ipt_find_target call (which does autoloading) by xt_find_target (which doesn't do autoloading). Additionally xt_find_target may return ERR_PTR values in case of

Re: PC300too alternative WAN driver

2007-01-31 Thread Krzysztof Halasa
Jeff Garzik <[EMAIL PROTECTED]> writes: > Please make sure to provides updates ensuring that it passes sparse > checks (see Documentation/sparse.txt) Ok. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More maj

[PATCH] r8169: fix a race between PCI probe and dev_open

2007-01-31 Thread Francois Romieu
Call chain: -> rtl8169_init_one -> register_netdev (dev_open starts to race...) -> rtl8169_init_phy -> rtl8169_set_speed -> tp->set_speed -> mod_timer(&tp->timer, ...) (if netif_running() is true) As netif_running() is true just before dev->open() is

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-31 Thread Neil Horman
On Wed, Jan 31, 2007 at 01:16:29AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Tue, 30 Jan 2007 08:02:08 -0500), Neil > Horman <[EMAIL PROTECTED]> says: > > > > I do not think we should copy neighbor information from (one of) > > > default routers, but use temporar

Re: [PATCH 4/6] d80211: don't display name of invisible network device

2007-01-31 Thread Johannes Berg
On Tue, 2007-01-30 at 15:00 +0100, Jan Kiszka wrote: > > If the master netdev no longer has a name, how can you still use `tc' on > > it? > > I hope you can't, You know, being able to is the only (user interface) reason for the master dev's existence. > because that was recently proven to be ab

Re: [PATCH 3/3] Check num sacks in SACK fast path

2007-01-31 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Mon, 29 Jan 2007 09:13:49 +0200 > When we check for SACK fast path make sure that we also have the same number > of > SACK blocks in the cache and in the new SACK data. This prevents us from > mistakenly taking the cache data if the old data in the SACK

Re: [PATCH 2/3] Seperate DSACK from SACK fast path

2007-01-31 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Mon, 29 Jan 2007 09:13:44 +0200 > + for (i = 0; i < num_sacks; i++) { > + __be32 start_seq = sp[i].start_seq; > + __be32 end_seq = sp[i].end_seq; This is not sufficient, you have to also fix up the type of the recv_sack_cache

Re: [PATCH 1/3] Advance fast path pointer for first block only

2007-01-31 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Mon, 29 Jan 2007 09:13:39 +0200 > Only advance the SACK fast-path pointer for the first block, the fast-path > assumes that only the first block advances next time so we should not move the > skb for the next sack blocks. > > Signed-Off-By: Baruch Even

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 31 Jan 2007 16:23:49 +0100 > Jarek Poplawski wrote: > > This patch adds a dump_stats callback to enable > > printing of basic statistics of prio classes. > > (With help of Patrick McHardy). > > > > Signed-off-by: Jarek Poplawski <[EMAIL PROTECT

Re: [Bugme-new] [Bug 7909] New: malfunction of udp_get_port() in wildcard ports assigning

2007-01-31 Thread David Miller
This was fixed several weeks ago. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] d80211: Add software sequence support

2007-01-31 Thread Ivo van Doorn
Most hardware can keep track of sequence numbers themselves, unfortunately *most* doesn't cover all devices. ;) This patch will keep track of the sequence number if the flag IEEE80211_HW_SOFTWARE_SEQUENCE has been set. Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rNU3 dscape/include

[PATCH 1/2] d80211: Add software RTS support

2007-01-31 Thread Ivo van Doorn
Not all hardware are capable of generating their own RTS frames. This patch will add support for creating the RTS frame in software, when the driver requests this through the flag IEEE80211_HW_SOFTWARE_RTS Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]> --- diff --git a/include/net/d80211.h b/in

RE: [PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

2007-01-31 Thread Sivakumar Subramani
Hi Jeff, Synced up the patches to the latest code from netdev#upstream branch and also taken care of the Whitespaces. I have resubmitted all the five patches again. Please apply it. Thanks, ~Siva -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 31

[PATCH 2.6.20 4/5] s2io: Removed enabling of some of the unused interrupts.

2007-01-31 Thread Sivakumar Subramani
Removed unused code in en_dis_able_nic_intrs(), TX_DMA_INTR, RX_DMA_INTR, TX_XGXS_INTR, MC_INTR Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> --- diff -urpN patch3/drivers/net/s2io.c patch4/drivers/net/s2io.c --- patch3/drivers/net/s2io.c 2007-01-31 22:50:24.0 +0530 +++ patch4/d

Re: [PATCH] d80211: fix default key symlink creation/cleanup

2007-01-31 Thread Jiri Benc
On Wed, 10 Jan 2007 21:42:01 +0100, Jan Kiszka wrote: > here is the revised version of 'don't symlink empty default keys'. Run-tested > and diff'ed against your repos. Applied, thanks for the patch and sorry for the delay. Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the l

Re: [PATCH] d80211: select CRC32 functions

2007-01-31 Thread Jiri Benc
On Wed, 24 Jan 2007 10:35:10 +0100, Marcus Better wrote: > The d80211 stack requires CRC32 functions for the WEP implementation. Your mail client converts tabs to spaces, please check its settings next time (and Cc: me and John Linville on d80211 patches). Applied to my tree, thanks for the patch

Re: [RFC] Alternative hidden netwirk device interface

2007-01-31 Thread Stephen Hemminger
On Wed, 31 Jan 2007 19:26:47 +0100 Jiri Benc <[EMAIL PROTECTED]> wrote: > On Mon, 29 Jan 2007 14:09:58 -0800, Stephen Hemminger wrote: > > Change to allow register_netdevice() to be called with a blank name. > > If name is blank, it is not put in name hash list, and doesn't > > show up in /sys or

Fw: [Bug 7909] New: malfunction of udp_get_port() in wildcard ports assigning

2007-01-31 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 31 Jan 2007 03:50:39 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 7909] New: malfunction of udp_get_port() in wildcard ports assigning http://bugzilla.kernel.org/show_bug.cgi?id=7909 Summary: malfunction of udp_get_port() in

Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver

2007-01-31 Thread Stephen Hemminger
O > +static noinline void pasemi_mac_free_tx_resources(struct net_device *dev) Why tell compiler how to do it's job. marking it noinline? > Index: merge/drivers/net/pasemi_mac.h > === > --- /dev/null > +++ merge/drivers/net/pasemi_m

Fw: [Bugme-new] [Bug 7909] New: malfunction of udp_get_port() in wildcard ports assigning

2007-01-31 Thread Andrew Morton
Begin forwarded message: Date: Wed, 31 Jan 2007 03:50:56 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 7909] New: malfunction of udp_get_port() in wildcard ports assigning http://bugzilla.kernel.org/show_bug.cgi?id=7909 Summary: malfunction of udp_g

[PATCH 2.6.20 3/5] s2io: Fixes in updating skb->truesize and code cleanup.

2007-01-31 Thread Sivakumar Subramani
1. Fix for updating skb->truesize properly. 2. Disable NAPI only if more than one ring configured in case of MSI/MSI-X interrupts. Previously we were disabling NAPI irrespective of number of rings when MSI/MSI-X interrupts were used. 3. Code cleanup. Signed-off-by: Sivakumar Subramani <[EMAI

[PATCH 1/1] NetXen: Fixes for ppc architecture.

2007-01-31 Thread Amit S. Kale
NetXen: Fixes for ppc architecture. Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> --- Sorry, I wanted to send only one patch so please ignore [PATCH 0/2] in the subject of my last mail. It should be [PATCH 0/1]. netxen_nic.h | 98 --

[PATCH 2.6.20 2/5] S2IO: Fixes for reset and link handling.

2007-01-31 Thread Sivakumar Subramani
1. Fix for reset and link handling. 2. Allow for promiscuos mode and multicast state be maintained through ifconfig up and down. 3. Support to print adapter serial number. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> --- diff -urpN patch1/drivers/net/s2io.c patch2/drivers/net/s2io.c -

[PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

2007-01-31 Thread Sivakumar Subramani
This patch adds two load parameters napi and ufo. Previously NAPI was compilation option with these changes wan enable disable NAPI using load parameter. Also we are introducing ufo load parameter to enable/disable ufo feature Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> --- diff -urpN o

Re: [RFC] Alternative hidden netwirk device interface

2007-01-31 Thread Jiri Benc
On Mon, 29 Jan 2007 14:09:58 -0800, Stephen Hemminger wrote: > Change to allow register_netdevice() to be called with a blank name. > If name is blank, it is not put in name hash list, and doesn't > show up in /sys or /proc What about things like neigh_sysctl_register which expects nonempty dev na

[PATCH 0/2] NetXen: NetXen 1G/10G Ethernet Driver update

2007-01-31 Thread Amit S. Kale
Hi All, I will be sending NetXen: 1G/10G Ethernet Driver update for ppc fix in the subsequent email. I will send the update for flash code later. Thanks, --Amit - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: d80211: a patch for standalone d80211 tarball

2007-01-31 Thread Jiri Benc
On Mon, 29 Jan 2007 15:23:07 -0500, Pavel Roskin wrote: > Both cases are highly unlikely for the above macros, but please keep in > mind that some aspiring programmers view the kernel as an example of > good programming style. This wasn't meant to be included in the kernel (that would be indeed ba

Re: [announce] iproute2 2.6.19-061214

2007-01-31 Thread Bill Davidsen
Stephen Hemminger wrote: This is an update to the iproute2 command set. It can be downloaded from: http://developer.osdl.org/dev/iproute2/download/iproute2-2.6.18-061214.tar.gz The 2.6.18 should be 2.6.19. Am I the first person to actually try that link? Repository: git://git.kernel.or

Re: [PATCH 1/2] NetXen: Added ethtool support for user level tools

2007-01-31 Thread Amit Kale
Ueimor, Jeff, Thanks for reviewing. We are integrating these into our code and will send an update tomorrow. -Amit On Wednesday 31 January 2007 15:46, Jeff Garzik wrote: > Amit S. Kale wrote: > > Added ethtool support for user level firmware management utilities. > > > > Signed-off-by: Amit S.

Re: sky2 problems on Intel Mac Mini

2007-01-31 Thread Chris Lightfoot
On Wed, Jan 31, 2007 at 09:15:22AM +, Chris Lightfoot wrote: > On Wed, Jan 31, 2007 at 12:09:37AM +, Chris Lightfoot wrote: > > On Tue, Jan 30, 2007 at 11:15:20AM -0800, Stephen Hemminger wrote: > > > a) hardware flow control problems > > >look at ethtool -S eth0 statistics, are there f

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Patrick McHardy
Jarek Poplawski wrote: > This patch adds a dump_stats callback to enable > printing of basic statistics of prio classes. > (With help of Patrick McHardy). > > Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> Acked-by: Patrick McHardy <[EMAIL PROTECTED]> - To unsubscribe from this list: send th

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Patrick McHardy
Jarek Poplawski wrote: > On Wed, Jan 31, 2007 at 04:06:05PM +0100, Patrick McHardy wrote: > >>The class passed to both ->dump and ->dump_stats is not a classid but >>a qdisc-internal identifier (pointer, integer, whatever) which comes >>from either ->get or ->walk, and thus is valid unless these f

[PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Jarek Poplawski
(Take 3) This patch adds a dump_stats callback to enable printing of basic statistics of prio classes. (With help of Patrick McHardy). Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> --- diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c linux-2.6.20-rc6/net/sched/sch_prio.c --- linux-2.6.20

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Jarek Poplawski
On Wed, Jan 31, 2007 at 04:06:05PM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: > >>From sch_api.c: > > > > > >> if (cl_ops->dump && cl_ops->dump(q, cl, skb, tcm) < 0) > >> goto rtattr_failure; > >> > >> if (gnet_stats_start_copy_compat(skb, TCA_STATS2, TCA_STA

Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver

2007-01-31 Thread Olof Johansson
Hi, On Wed, Jan 31, 2007 at 01:44:31PM +0100, Ingo Oeser wrote: > You might want to write these loops like that: [...] > That way you: > - Let you give other processes a chance to run, > while you wait for your hardware state to change > (if your hardware can tolerate these latencies). > -

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Patrick McHardy
Jarek Poplawski wrote: >>From sch_api.c: > > >> if (cl_ops->dump && cl_ops->dump(q, cl, skb, tcm) < 0) >> goto rtattr_failure; >> >> if (gnet_stats_start_copy_compat(skb, TCA_STATS2, TCA_STATS, >> TCA_XSTATS, q->stats_lock, &d) < 0) >>

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Jarek Poplawski
On Wed, Jan 31, 2007 at 03:37:25PM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: > > +static int prio_dump_class_stats(struct Qdisc *sch, unsigned long cl, > > +struct gnet_dump *d) > > +{ > > + struct prio_sched_data *q = qdisc_priv(sch); > > + struct Qdisc

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Patrick McHardy
Jarek Poplawski wrote: > +static int prio_dump_class_stats(struct Qdisc *sch, unsigned long cl, > + struct gnet_dump *d) > +{ > + struct prio_sched_data *q = qdisc_priv(sch); > + struct Qdisc *cl_q; > + > + if (cl - 1 > q->bands) > + return -1;

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Patrick McHardy
Jarek Poplawski wrote: > On Wed, Jan 31, 2007 at 02:47:55PM +0100, Patrick McHardy wrote: > >>>+static int prio_dump_class_stats(struct Qdisc *sch, unsigned long cl, >>>+struct gnet_dump *d) >> >>Please align with struct Qdisc. > > > I'm not su

[PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Jarek Poplawski
(Take 2) This patch adds a dump_stats callback to enable printing of basic statistics of prio classes. Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> --- diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c linux-2.6.20-rc6/net/sched/sch_prio.c --- linux-2.6.20-rc6-/net/sched/sch_prio.c

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Jarek Poplawski
On Wed, Jan 31, 2007 at 02:47:55PM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: > > This patch adds a dump_stats callback to enable > > printing of basic statistics of prio classes. > > > diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c > > linux-2.6.20-rc6/net/sched/sch_prio.c > > ---

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Matthew Garrett
On Wed, Jan 31, 2007 at 02:44:16PM +0100, Pavel Machek wrote: > Okay, but I'm somehow not sure if ipw2100 can do this kind of > tricks. Yes, n800 is likely very nice toy :-). Well, to an extent - if you use the wext power features, you can get it into a relatively low-power state at the cost of

Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled

2007-01-31 Thread Patrick McHardy
Jarek Poplawski wrote: > This patch adds a dump_stats callback to enable > printing of basic statistics of prio classes. > diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c > linux-2.6.20-rc6/net/sched/sch_prio.c > --- linux-2.6.20-rc6-/net/sched/sch_prio.c2007-01-08 20:23:58.0 > +01

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Pavel Machek
Hi! > > > Yes. Low power states without ability to respond to wakeup interrupts > > > would be broken behaviour generally. > > > > Do you realy expect wifi to save significant ammount of power, while > > still listening for packets on wireless network? > > >From N800 specs (not meant as a shamel

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Amit Kucheria
On Wed, 2007-01-31 at 14:04 +0100, ext Pavel Machek wrote: > On Wed 2007-01-31 13:53:20, Amit Kucheria wrote: > > > > Yes. Low power states without ability to respond to wakeup interrupts > > would be broken behaviour generally. > > Do you realy expect wifi to save significant ammount of power, w

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread samuel
On 1/31/2007, "Pavel Machek" <[EMAIL PROTECTED]> wrote: >On Wed 2007-01-31 13:53:20, Amit Kucheria wrote: >> On Wed, 2007-01-31 at 11:48 +0100, ext Andi Kleen wrote: >> > On Wednesday 31 January 2007 11:27, Matthew Garrett wrote: >> > > On Wed, Jan 31, 2007 at 12:13:04PM +0100, Andi Kleen wrote:

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Oliver Neukum
Am Mittwoch, 31. Januar 2007 14:04 schrieb Pavel Machek: > On Wed 2007-01-31 13:53:20, Amit Kucheria wrote: > > On Wed, 2007-01-31 at 11:48 +0100, ext Andi Kleen wrote: > > > On Wednesday 31 January 2007 11:27, Matthew Garrett wrote: > > > > On Wed, Jan 31, 2007 at 12:13:04PM +0100, Andi Kleen wrot

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Pavel Machek
On Wed 2007-01-31 13:53:20, Amit Kucheria wrote: > On Wed, 2007-01-31 at 11:48 +0100, ext Andi Kleen wrote: > > On Wednesday 31 January 2007 11:27, Matthew Garrett wrote: > > > On Wed, Jan 31, 2007 at 12:13:04PM +0100, Andi Kleen wrote: > > > > Matthew Garrett <[EMAIL PROTECTED]> writes: > > > > >

Re: [PATCH 1/10] cxgb3 - FW versioning

2007-01-31 Thread Jeff Garzik
Christoph Hellwig wrote: On Wed, Jan 31, 2007 at 05:40:02AM -0500, Jeff Garzik wrote: honestly it looks like just about every ioctl except load-firmware should go And while we're at it a load-firmware sounds like a nice addition for ethtool aswell. Or we may want to extent the firmware loader

Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver

2007-01-31 Thread Ingo Oeser
Hi, Olof Johansson schrieb: [...] > +static int pasemi_mac_close(struct net_device *dev) > +{ [..] > + do { > + pci_read_config_dword(mac->dma_pdev, > + PAS_DMA_TXCHAN_TCMDSTA(mac->dma_txch), > + &stat); > + }

Re: [PATCH 1/10] cxgb3 - FW versioning

2007-01-31 Thread Christoph Hellwig
On Wed, Jan 31, 2007 at 05:40:02AM -0500, Jeff Garzik wrote: > honestly it looks like just about every ioctl except load-firmware should go And while we're at it a load-firmware sounds like a nice addition for ethtool aswell. Or we may want to extent the firmware loader to deal with updating firm

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Amit Kucheria
On Wed, 2007-01-31 at 11:48 +0100, ext Andi Kleen wrote: > On Wednesday 31 January 2007 11:27, Matthew Garrett wrote: > > On Wed, Jan 31, 2007 at 12:13:04PM +0100, Andi Kleen wrote: > > > Matthew Garrett <[EMAIL PROTECTED]> writes: > > > > > > > > PCI seems to require a delay of 10ms when sequenci

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-01-31 Thread Ivo van Doorn
> Hope you will be resubmitting this. And here is the new version, I didn't make the name const as requested that field is being passed to the class_device_create method which requires a char* argument. But I have made the flag field. And now this time the patch actually includes the changes I pr

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Amit Kucheria
On Wed, 2007-01-31 at 09:48 +, ext Matthew Garrett wrote: > On Wed, Jan 31, 2007 at 11:13:07AM +0200, Amit Kucheria wrote: > > > What is the latency in changing between different PCI power states for > > peripherals? > > I'm not sure in the general case, but the power-down path for the > ipw

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Andi Kleen
On Wednesday 31 January 2007 11:27, Matthew Garrett wrote: > On Wed, Jan 31, 2007 at 12:13:04PM +0100, Andi Kleen wrote: > > Matthew Garrett <[EMAIL PROTECTED]> writes: > > > > > > PCI seems to require a delay of 10ms when sequencing from D3 to D0, > > > which probably isn't acceptable latency fo

Re: PC300too alternative WAN driver

2007-01-31 Thread Jeff Garzik
Krzysztof Halasa wrote: The attached patch adds an alternative driver "pc300too" for PCI WAN cards PC300/RSV and PC300/X21 made by Cyclades Corp. (now Avocent Corp). Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> applied to #upstream Please make sure to provides updates ensuring that it

Re: [PATCH 1/10] cxgb3 - FW versioning

2007-01-31 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Clean up FW version checking. The supported FW version is now 3.1. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> applies patches 1-7, 9-10 to #upstream - To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.

2007-01-31 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Offload packets may be DMAed long after their SGE Tx descriptors are done so they must remain mapped until they are freed rather than until their descriptors are freed. Unmap such packets through an skb destructor. Signed-off-by: Divy Le

Re: [PATCH 1/10] cxgb3 - FW versioning

2007-01-31 Thread Jeff Garzik
You need to submit a patch to remove the following ioctls: CHELSIO_SETREG: CHELSIO_GETREG: CHELSIO_SET_QSET_PARAMS: (use ethtool instead) CHELSIO_GET_QSET_PARAMS: (use ethtool instead) CHELSIO_SET_QSET_NUM: (use ethtool instead) CHELSIO_GET_QSET_NUM: (use ethtool instead) CHELSIO_SETMTUTAB: CHELS

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-01-31 Thread Ivo van Doorn
Hi, > > + /* > > +* Pointer to rfkill structure > > +* that was filled in by key driver. > > +*/ > > + struct rfkill *rfkill; > > Since rfkill is basically a function pointer table, > can it be made const? Sounds good to me. > > + /* > > +* Once key status change has been

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Pavel Machek
Hi! > Based on previous discussions, I've implemented a rough attempt at > providing some level of basic runtime power management on the ipw2100 > chipset. This patch does the following: > > 1) On load, it initialises the hardware and then quiesces it again > 2) On interface up, it powers the h

Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver

2007-01-31 Thread Jeff Garzik
Olof Johansson wrote: Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) Basic enablement, will be complemented with performance enhancements over time. PHY support will be added as well. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Looks generally pretty clean, well done. Comme

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Matthew Garrett
On Wed, Jan 31, 2007 at 12:13:04PM +0100, Andi Kleen wrote: > Matthew Garrett <[EMAIL PROTECTED]> writes: > > > > PCI seems to require a delay of 10ms when sequencing from D3 to D0, > > which probably isn't acceptable latency for an "up" state. > > It might be if the interface has been idle for

Re: [PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

2007-01-31 Thread Jeff Garzik
Ananda Raju wrote: This patch adds two load parameters napi and ufo. Previously NAPI was compilation option with these changes wan enable disable NAPI using load parameter. Also we are introducing ufo load parameter to enable/disable ufo feature Signed-off-by: Sivakumar Subramani <[EMAIL PROTECT

Re: [PATCH 1/2] NetXen: Added ethtool support for user level tools

2007-01-31 Thread Jeff Garzik
Amit S. Kale wrote: Added ethtool support for user level firmware management utilities. Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> You will need to resend against netdev#upstream, which now contains Al Viro's netxen annotations. Please add sparse checking (read Documentation/sparse.txt

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Andi Kleen
Matthew Garrett <[EMAIL PROTECTED]> writes: > > PCI seems to require a delay of 10ms when sequencing from D3 to D0, > which probably isn't acceptable latency for an "up" state. It might be if the interface has been idle for some time (and the delay is not busy looping of course) How idle should

Re: [PATCH 5/5] sky2: version 1.11.1

2007-01-31 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Version update to 1.11.1. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] sky2: use dev_err for error reports

2007-01-31 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Use the standard dev_printk functions instead of printk directly for error reports. Fix a bug where the initialization would return 0 if allocation of network device failed. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> ACK but failed to apply - To unsubscribe

Re: [PATCH 4/5] sky2: software rx/tx stats

2007-01-31 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Maintain packet statistics in software rather than hardware. This is slightly slower, but allows easier debugging of problems where packets are still being received by PHY but not being handled by hardware. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied

Re: [PATCH 2/5] sky2: add Wake On Lan support

2007-01-31 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Adds basic magic packet wake on lan support to the sky2 driver. Note: initial WOL value is based on BIOS settings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> ACK, but failed to apply - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 1/5] sky2: handle network device allocation failure

2007-01-31 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: If alloc_etherdev() failed, then sky2_init_netdev will return NULL, and sky2_probe would end up returning 0 instead of -ENOMEM. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [USBNET] ASIX: Add IO-DATA ETG-US2 Support.

2007-01-31 Thread Jeff Garzik
YOSHIFUJI Hideaki / 吉藤英明 wrote: Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [USBNET] PEGASUS: Fix typo in Corega products.

2007-01-31 Thread Jeff Garzik
YOSHIFUJI Hideaki / 吉藤英明 wrote: s/FEter/FEther/. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Amit Kucheria
On Wed, 2007-01-31 at 07:52 +, ext Matthew Garrett wrote: > Based on previous discussions, I've implemented a rough attempt at > providing some level of basic runtime power management on the ipw2100 > chipset. This patch does the following: > > 1) On load, it initialises the hardware and the

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Matthew Garrett
On Wed, Jan 31, 2007 at 11:13:07AM +0200, Amit Kucheria wrote: > What is the latency in changing between different PCI power states for > peripherals? I'm not sure in the general case, but the power-down path for the ipw2100 involves a static wait of 100ms in ipw2100_hw_stop_adapter(). > Would

Re: igmp: possible NULL dereference after GFP_ATOMIC allocation?

2007-01-31 Thread Jarek Poplawski
On 30-01-2007 16:04, Alexey Dobriyan wrote: > On Tue, Jan 30, 2007 at 03:34:18AM -0800, David Stevens wrote: >> I think you're correct-- looks like it needs: >> >> if (!skb) >> return NULL; >> >> just before the skb_put(), since an allocation (and failure) >> could o

  1   2   >