Re: [PATCH] Fix sorting of SACK blocks

2007-01-25 Thread Baruch Even
* David Miller <[EMAIL PROTECTED]> [070126 01:55]: > From: Baruch Even <[EMAIL PROTECTED]> > Date: Thu, 25 Jan 2007 20:29:03 +0200 > > > The sorting of SACK blocks actually munges them rather than sort, causing > > the > > TCP stack to ignore some SACK information and breaking the assumption of >

[PATCH] TCP: Replace __kfree_skb() with kfree_skb()

2007-01-25 Thread Masayuki Nakagawa
This patch simply replaces __kfree_skb() in exit path with kfree_skb(). In tcp_rcv_state_process(), generally skbs should be destroyed only when the ref count is zero. That is the way things are supposed to be done in the kernel. This change might reveals a memory leak of skb. If it happens, it wo

Re: [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.

2007-01-25 Thread Masayuki Nakagawa
David, Yoshifuji-san, Herbert, I appreciate your feedback. I made an another patch that simply replaced __kfree_skb() in exit path with kfree_skb(). I tested it overnight with a chat benchmark tool and my test program, which can reproduce the original problem. As a result, I didn't see any probl

Re: + oops-in-drivers-net-shaperc.patch added to -mm tree

2007-01-25 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 24 Jan 2007 19:54:51 -0800 > Hi, > > The following code: > [...] > > Causes the following oops: > ... > [ 66.355188] [] error_code+0x7c/0x84 > [ 66.355192] [] packet_sendmsg+0x147/0x201 [af_packet] > [ 66.355199] [] sock_sendmsg+0xf9/0x116 > [ 66.3

Re: [PATCH] bcm43xx-d80211: Interrogate hardware-enable switch and update LEDs

2007-01-25 Thread John W. Linville
On Sat, Dec 30, 2006 at 11:25:15PM -0600, Larry Finger wrote: > The current bcm43xx driver ignores any wireless-enable switches on mini-PCI > and mini-PCI-E cards. This patch implements a new routine to interrogate the > radio hardware enabled bit in the interface, logs the initial state and any >

wireless-dev updated 2007-01-25

2007-01-25 Thread John W. Linville
The following changes since commit a4893aa0bb61c7bbced8fcdea874cb8d0e1d3a8d: John W. Linville (1): Merge branch 'from-linus' are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git Gertjan van Wingerde (1): d80211: Select CRYP

[PATCH] d80211: configure hardware when the interface is brought up

2007-01-25 Thread Pavel Roskin
ieee80211_hw_config() is called from scanning functions and ioctl handlers, but not when the interface is brought up. This is unreasonable. Since the config function is provided by hardware drivers to d80211, the later should be responsible for calling it in all situations when the hardware needs

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 25 Jan 2007 14:45:00 -0500), Neil Horman <[EMAIL PROTECTED]> says: > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 2a7e461..46f91ee 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -830,7 +830,8 @@ retry: > ift = !m

Re: [PATCH] Fix sorting of SACK blocks

2007-01-25 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Thu, 25 Jan 2007 20:29:03 +0200 > The sorting of SACK blocks actually munges them rather than sort, causing the > TCP stack to ignore some SACK information and breaking the assumption of > ordered SACK blocks after sorting. > > The sort takes the data f

Re: [BUG] problem with BPF in PF_PACKET sockets, introduced in linux-2.6.19

2007-01-25 Thread David Miller
From: Alexey Kuznetsov <[EMAIL PROTECTED]> Date: Thu, 25 Jan 2007 16:22:20 +0300 > Actually, it can. Return value was used only as sign of error, > so that the mistake was to return original unsigned result casted to int. > > Alternative fix is enclosed. To be honest, it is not better than > your

Re: [PATCH] net: decnet handle a failure in neigh_parms_alloc (take 2)

2007-01-25 Thread David Miller
From: Steven Whitehouse <[EMAIL PROTECTED]> Date: Thu, 25 Jan 2007 11:43:18 + > Hi, > > On Wed, Jan 24, 2007 at 09:55:45PM -0700, Eric W. Biederman wrote: > > > > While enhancing the neighbour code to handle multiple network > > namespaces I noticed that decnet is assuming neigh_parms_alloc

Re: [BNX2]: Fix 2nd port's MAC address.

2007-01-25 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 24 Jan 2007 21:35:45 -0800 > [BNX2]: Fix 2nd port's MAC address. > > On the 5709, we need to add the proper offset to calculate the shared > memory base address of the 2nd port correctly. Otherwise, the 2nd > port's MAC address and other inform

[PATCH] RFC: Broadcom PHY forcing fix

2007-01-25 Thread Kumar Gala
Maciej, I've got a BCM5461 that requires this fix to be able to force the speeds on the PHY. Not sure if its needed on the other variants or not. The problem is the genphy_config_aneg resets the PHY when forcing the speed and once we reset the BCM5461 it doesn't remember any of its settings.

Re: [take34 0/10] kevent: Generic event handling mechanism.

2007-01-25 Thread Evgeniy Polyakov
On Thu, Jan 25, 2007 at 04:48:30PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > Changes from 'take33' patchset: > * Added optional header pointer and its size into aio_sendfile_path(), >which allows to send header and file in one syscall instead of >send(header), open file, sendf

Re: [ANNOUNCE] PRO/1000 PCI-e Software Developer Manual is now available

2007-01-25 Thread John W. Linville
On Thu, Jan 25, 2007 at 01:40:23PM -0800, John Ronciak wrote: > The Software Developer Manual for the PRO/1000 PCI-e controllers is > now available via the http://e1000.sf.net/ web site. The file is > OpenSDM_8257x-10.pdf. I know it's been a long time coming but > sometimes that's just how it goe

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Vlad Yasevich
Hi Neil I went through the RFC again it seems like the following is missing: Section 3.3: > * (modifies section 5.4.2) The host MUST join the all-nodes multicast >address and the solicited-node multicast address of the >Tentative address. The host SHOULD NOT delay before sending >Ne

Re: owner-Match in 2.6.20-rc5 (fwd)

2007-01-25 Thread Jan Engelhardt
>> >> The report below was posted on the netfilter user list. Isn't there any >> >> ill side effect by reverting the change? >> > >> >Performance regression :-( >> > >> >This optimization saves a whole handful of heavy atomic operations in >> >the packet transmit path of TCP. >> > >> >As I unders

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Vlad Yasevich
Hi Neil > > I prefer to be more explicit in my order of operation, but that does seem more > consistent with the prevaling style. New patch attached. > Looks good to me. One question thought. What causes the stack to send via Default Router instead of sending an NS (Section 3.2). I see ther

Re: owner-Match in 2.6.20-rc5 (fwd)

2007-01-25 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Thu, 25 Jan 2007 22:07:07 +0100 (MET) > > >> The report below was posted on the netfilter user list. Isn't there any > >> ill side effect by reverting the change? > > > >Performance regression :-( > > > >This optimization saves a whole handful of he

Re: [ANNOUNCE] PRO/1000 PCI-e Software Developer Manual is now available

2007-01-25 Thread Jeff Garzik
John Ronciak wrote: The Software Developer Manual for the PRO/1000 PCI-e controllers is now available via the http://e1000.sf.net/ web site. The file is OpenSDM_8257x-10.pdf. I know it's been a long time coming but sometimes that's just how it goes. Enjoy. Nice, thanks for posting it!

[ANNOUNCE] PRO/1000 PCI-e Software Developer Manual is now available

2007-01-25 Thread John Ronciak
The Software Developer Manual for the PRO/1000 PCI-e controllers is now available via the http://e1000.sf.net/ web site. The file is OpenSDM_8257x-10.pdf. I know it's been a long time coming but sometimes that's just how it goes. Enjoy. -- Cheers, John - To unsubscribe from this list: send the

Re: [PATCH] Fix sorting of SACK blocks

2007-01-25 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Thu, 25 Jan 2007 20:29:03 +0200 > The sorting of SACK blocks actually munges them rather than sort, causing the > TCP stack to ignore some SACK information and breaking the assumption of > ordered SACK blocks after sorting. > > The sort takes the data f

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Neil Horman
On Thu, Jan 25, 2007 at 03:18:59PM -0500, Vlad Yasevich wrote: > Hi Neil > > > @@ -1027,15 +1029,17 @@ int ipv6_dev_get_saddr(struct net_device *daddr_dev, > > } > > } > > > > - /* Rule 3: Avoid deprecated address */ > > +

Re: owner-Match in 2.6.20-rc5 (fwd)

2007-01-25 Thread Jan Engelhardt
>> The report below was posted on the netfilter user list. Isn't there any >> ill side effect by reverting the change? > >Performance regression :-( > >This optimization saves a whole handful of heavy atomic operations in >the packet transmit path of TCP. > >As I understand it, the owner-Match is

Re: owner-Match in 2.6.20-rc5 (fwd)

2007-01-25 Thread David Miller
From: Jozsef Kadlecsik <[EMAIL PROTECTED]> Date: Thu, 25 Jan 2007 21:31:56 +0100 (CET) > The report below was posted on the netfilter user list. Isn't there any > ill side effect by reverting the change? Performance regression :-( This optimization saves a whole handful of heavy atomic operatio

Re: [PATCH RFC 1/31] net: Add net_namespace_type.h to allow for per network namespace variables.

2007-01-25 Thread Eric W. Biederman
Stephen Hemminger <[EMAIL PROTECTED]> writes: > Can all this be a nop if a CONFIG option is not selected? That is exactly what this infrastructure supports. What you see is the version that comes into effect when the CONFIG option is not selected. >From using an empty structure to replace a poin

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread John W. Linville
On Thu, Jan 25, 2007 at 11:51:27AM -0500, Michael Wu wrote: > On Thursday 25 January 2007 01:50, Pavel Roskin wrote: > > If the hardware drivers are supposed to do it, here's my patch. It is > > working fine for me and ready to be applied. The changelog is in the > > subject. > Let's fix this in

Re: [PATCH RFC 1/31] net: Add net_namespace_type.h to allow for per network namespace variables.

2007-01-25 Thread Stephen Hemminger
Can all this be a nop if a CONFIG option is not selected? > > diff --git a/include/linux/net_namespace_type.h > b/include/linux/net_namespace_type.h > new file mode 100644 > index 000..8173f59 > --- /dev/null > +++ b/include/linux/net_namespace_type.h > @@ -0,0 +1,52 @@ > +/* > + * Defini

Re: [PATCH RFC 2/31] net: Implement a place holder network namespace

2007-01-25 Thread Eric W. Biederman
Stephen Hemminger <[EMAIL PROTECTED]> writes: >> + >> +#define __per_net_start ((char *)0) >> +#define __per_net_end ((char *)0) > > Don't use these use NULL NULL has the wrong data type. These are compiled out character array normally generated by the linker script. I'm not even certa

Re: [PATCH RFC 31/31] net: Add etun driver

2007-01-25 Thread Eric W. Biederman
Ben Greear <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted >> >> etun is a simple two headed tunnel driver that at the link layer >> looks like ethernet. It's target audience is communicating >> between network namespaces but it is

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Vlad Yasevich
Hi Neil > @@ -1027,15 +1029,17 @@ int ipv6_dev_get_saddr(struct net_device *daddr_dev, > } > } > > - /* Rule 3: Avoid deprecated address */ > + /* Rule 3: Avoid deprecated and optimistic address */ >

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Neil Horman
On Thu, Jan 25, 2007 at 12:16:59PM -0500, Vlad Yasevich wrote: > I tend to agree with Neil here. Marking optimistic addresses as deprecated > doesn't > buy as much since the address can transition in and out of deprecated state > regardless > of DAD. > > However, there is a problem with the c

Re: [PATCH RFC 31/31] net: Add etun driver

2007-01-25 Thread Ben Greear
Eric W. Biederman wrote: From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted etun is a simple two headed tunnel driver that at the link layer looks like ethernet. It's target audience is communicating between network namespaces but it is general enough it may have other uses as well. This

Re: [PATCH RFC 2/31] net: Implement a place holder network namespace

2007-01-25 Thread Stephen Hemminger
On Thu, 25 Jan 2007 12:00:04 -0700 "Eric W. Biederman" <[EMAIL PROTECTED]> wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > Many of the changes to the network stack will simply be adding a > network namespace parameter to function calls or moving variables > from globals to bei

Possible bugs in SACK processing

2007-01-25 Thread Baruch Even
In addition to the patch I've provided there are two more issues that I believe are bugs in the SACK processing code. Since I'm not certain but I don't have the time to look into them I'd like to raise them for other folks to look at. First issue is the checking of the applicability of the fast pa

Re: [PATCH] Fix sorting of SACK blocks

2007-01-25 Thread Baruch Even
* Stephen Hemminger <[EMAIL PROTECTED]> [070125 20:47]: > On Thu, 25 Jan 2007 20:29:03 +0200 > Baruch Even <[EMAIL PROTECTED]> wrote: > > > The sorting of SACK blocks actually munges them rather than sort, causing > > the > > TCP stack to ignore some SACK information and breaking the assumption o

[PATCH RFC 10/31] net: Make socket creation namespace safe.

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This patch passes in the namespace a new socket should be created in and has the socket code do the appropriate reference counting. By virtue of this all socket create methods are touched. In addition the socket create methods are modified s

[PATCH RFC 12/31] net: Make packet reception network namespace safe

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This patch modifies every packet receive function registered with dev_add_pack() to drop packets if they are not from the initial network namespace, in addition to ensure consistency of argument passing the unnecessary device parameter is remo

[PATCH RFC 14/31] net: Support multiple network namespaces with netlink

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Each netlink socket will live in exactly one network namespace, this includes the controlling kernel sockets. This patch updates all of the existing netlink protocols to only support the initial network namespace. Request by clients in other

[PATCH RFC 21/31] net: Implement the guts of the network namespace infrastructure

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Support is added for the .data.pernet section where all of the variables who have a single instance in each network namespace will live. Every architectures linker script is modified so is should work. Summarizing the functions: net_ns_init

[PATCH RFC 2/31] net: Implement a place holder network namespace

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Many of the changes to the network stack will simply be adding a network namespace parameter to function calls or moving variables from globals to being per network namespace. When those variables have initializers that cannot statically comp

[PATCH RFC 18/31] net: Implment network device movement between namespaces

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This patch introduces NETIF_F_NETNS_LOCAL a flag to indicate a network device is local to a single network namespace and should never be moved. Useful for pseudo devices that we need an instance in each network namespace (like the loopback de

[PATCH RFC 9/31] net: Implement the per network namespace sysctl infrastructure

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The user interface is: register_net_sysctl_table and unregister_net_sysctl_table. Very much like the current interface except there is an network namespace parameter. This this any sysctl in the net_root_table and it's subdirectories are reg

[PATCH RFC 25/31] net: Make wireless netlink event generation handle multiple network namespaces

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/core/wireless.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/net/core/wireless.c b/net/core/wireless.c index 9036359..d534617 100644 --- a

[PATCH RFC 29/31] net: Make AF_PACKET handle multiple network namespaces

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This is done by making all of the relevant global variables per network namespace. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/packet/af_packet.c | 125 +++- 1 files changed, 81 i

[PATCH RFC 20/31] net: Implement CONFIG_NET_NS

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Add the config option to enable multiple network namespaces. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/Kconfig |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/net/Kconfig b/net/Kconfig index

[PATCH RFC 24/31] net: Make rtnetlink network namespace aware

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted After this patch none of the netlink callback support anything except the initial network namespace but the rtnetlink infrastructure now handles multiple network namespaces. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/li

[PATCH RFC 17/31] net: Factor out __dev_alloc_name from dev_alloc_name

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted When forcibly changing the network namespace of a device I need something that can generate a name for the device in the new namespace without overwriting the old name. __dev_alloc_name provides me that functionality. Signed-off-by: Eric W.

[PATCH RFC 11/31] net: Initialize the network namespace of network devices.

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Except for carefully selected pseudo devices all network interfaces should start out in the initial network namespace. Ultimately it will be register_netdev that examines what dev->nd_net is set to and places a device in a network namespace.

[PATCH RFC 28/31] net: Make the SOMAXCONN sysctl per network namespace

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/socket.h |3 ++- net/core/sysctl_net_core.c | 16 net/socket.c |7 --- 3 files changed, 14 insertions(+), 12 deletions(-)

[PATCH RFC 27/31] net: Make the xfrm sysctls per network namespace.

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted In particalure I moved: /proc/sys/net/core/xfrm_aevent_etime /proc/sys/net/core/xfrm_aevent_rseqth Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/net/xfrm.h |4 ++-- net/core/sysctl_net_core.c | 37 +++

[PATCH RFC 22/31] net: Add network namespace clone support.

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This patch allows you to create a new network namespace using sys_clone(...). Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/sched.h|1 + kernel/nsproxy.c | 11 +++ net/core/net_namespace.c |

[PATCH RFC 26/31] net: Make the netlink methods in rtnetlink handle multiple network namespaces

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted It turns out after a quick audit that except for removing the checks there is really nothing to do here. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/core/rtnetlink.c | 21 +++-- 1 files changed, 3 insertion

[PATCH RFC 5/31] net: Add a network namespace parameter to struct sock

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Sockets need to get a reference to their network namespace, or possibly a simple hold if someone registers on the network namespace notifier and will free the sockets when the namespace is going to be destroyed. Signed-off-by: Eric W. Biederm

[PATCH RFC 6/31] net: Add a helper to get a reference to the initial network namespace.

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The initial network namespace is special and we need to use it for various things. Probably the biggest initial use will be to ensure code that can't cope with multiple namespaces only sees the initial network namespace. For that reason and

[PATCH RFC 4/31] net: Add a network namespace tag to struct net_device

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Please note that network devices do not increase the count count on the network namespace. The are inside the network namespace and so the network namespace tag is in the nature of a back pointer and so getting and putting the network namespa

[PATCH RFC 19/31] net: sysfs interface support for moving devices between network namespaces.

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted I haven't a clue if this interface will meet with widespread approval but at this point it is simple, and very useful. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/core/net-sysfs.c | 35 +++

[PATCH RFC 13/31] net: Make device event notification network namespace safe

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Every user of the network device notifiers is either a protocol stack or a pseudo device. If a protocol stack that does not have support for multiple network namespaces receives an event for a device that is not in the initial network namespa

[PATCH RFC 15/31] net: Make the loopback device per network namespace

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This patch makes the loopback_dev per network namespace. The loopback device registers itself as a pernet_device so we can register the new loopback_dev instance when we add a new network namespace and so we can unregister the loopback device

[PATCH RFC 23/31] net: Modify all rtnetlink methods to only work in the initial namespace

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Before I can enable rtnetlink to work in all network namespaces I need to be certain that something won't break. So this patch deliberately disables all of the methods and when they are audited this extra check can be disabled. Signed-off-by

[PATCH RFC 31/31] net: Add etun driver

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted etun is a simple two headed tunnel driver that at the link layer looks like ethernet. It's target audience is communicating between network namespaces but it is general enough it may have other uses as well. Signed-off-by: Eric W. Biederman

[PATCH RFC 30/31] net: Make AF_UNIX per network namespace safe.

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Because of the global nature of garbage collection, and because of the cost of per namespace hash tables unix_socket_table has been kept global. With a filter added on lookups so we don't see sockets from the wrong namespace. Currently I don

[PATCH RFC 8/31] net: Make /sys/class/net handle multiple network namespaces

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted In combination with the sysfs support I am in the process of merging with gregkh, creates a separate instance of the /sys/class/net directory for each network namespace so two devices with the same name do not conflict. Then a network namespac

[PATCH RFC 1/31] net: Add net_namespace_type.h to allow for per network namespace variables.

2007-01-25 Thread Eric W. Biederman
The problem: To properly implement a ``level 2'' network namespace we need to move many of the networking stack global variables into the network namespace. We want to keep it explicit that the code is accessing a variable in a network namespace. We want to be able to completely compile out th

[PATCH RFC 3/31] net: Add a network namespace parameter to tasks

2007-01-25 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This is the network namespace from which all which all sockets and anything else under user control ultimately get their network namespace parameters. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/nsproxy.h |2 ++

[RFC PATCH 0/31] An introduction and A path for merging network namespace work

2007-01-25 Thread Eric W. Biederman
The idea of a network namespace is fundamentally quite simple. We create a mechanism that from the users perspective allows creation of separate instances of the network stack. When combined with mechanism like chroot this results in a much more complete isolation. When seen in the context of a

[PATCH] Fix sorting of SACK blocks

2007-01-25 Thread Baruch Even
The sorting of SACK blocks actually munges them rather than sort, causing the TCP stack to ignore some SACK information and breaking the assumption of ordered SACK blocks after sorting. The sort takes the data from a second buffer which isn't moved causing subsequent data moves to occur from the w

Re: [PATCH] Fix sorting of SACK blocks

2007-01-25 Thread Stephen Hemminger
On Thu, 25 Jan 2007 20:29:03 +0200 Baruch Even <[EMAIL PROTECTED]> wrote: > The sorting of SACK blocks actually munges them rather than sort, causing the > TCP stack to ignore some SACK information and breaking the assumption of > ordered SACK blocks after sorting. > > The sort takes the data fro

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Vlad Yasevich
Neil Horman wrote: > On Wed, Jan 24, 2007 at 05:54:47PM -0800, Sridhar Samudrala wrote: >> Sec 2.1 of RFC 4429 says >> >>Unless noted otherwise, components of the IPv6 protocol stack should >>treat addresses in the Optimistic state equivalently to those in the >>Deprecated state, indica

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Michael Wu
On Thursday 25 January 2007 01:50, Pavel Roskin wrote: > If the hardware drivers are supposed to do it, here's my patch. It is > working fine for me and ready to be applied. The changelog is in the > subject. Let's fix this in the stack. This problem will be fixed for most users once auto channe

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-01-25 Thread Vlad Yasevich
BTW, if anyone needs a reproducer, I can provide one. -vlad - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-01-25 Thread Vlad Yasevich
Hi Steve Steve Hill wrote: > On Wed, 10 Jan 2007, Sridhar Samudrala wrote: > >> So looks like there may be an issue with PR-SCTP(partial reliability) >> support and packet loss. I will take a look into this. >> >> Do you still see this problem even if you don't set timetolive? > > No, the proble

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Dan Williams
On Thu, 2007-01-25 at 09:36 -0600, Larry Finger wrote: > Gene Heskett wrote: > > On Thursday 25 January 2007 07:50, Jiri Benc wrote: > >> On Thu, 25 Jan 2007 12:47:08 +0100, Ivo Van Doorn wrote: > >>> Correct, similar problems have been detected in rt2x00. The temporary > >>> solution in there is t

Re: [tipc-discussion] [RFC: 2.6 patch] net/tipc/: possible cleanups

2007-01-25 Thread Jon Maloy
Adrian Bunk wrote: This patch contains the following possible cleanups: - make needlessly global functions static - #if 0 unused functions Thanks. I think most of those were due for our next release, anyway. But we'll get it in, one way or another. - remove all EXPORT_SYMBOL's My impress

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Larry Finger
Gene Heskett wrote: > On Thursday 25 January 2007 07:50, Jiri Benc wrote: >> On Thu, 25 Jan 2007 12:47:08 +0100, Ivo Van Doorn wrote: >>> Correct, similar problems have been detected in rt2x00. The temporary >>> solution in there is to demand a scanning operation after the >>> interface has been br

Re: Marvell Libertas 8388 802.11 USB - added to Orbit

2007-01-25 Thread John W. Linville
On Thu, Jan 25, 2007 at 10:24:40AM -0500, Luis R. Rodriguez wrote: > I've slapped the two Marvell Libertas 8388 802.11 USB cards onto > Winlab's Orbit testbed on sandbox 8. This allows anyone willing to > help hack on the driver with access to a node with the wireless card. > > http://www.orbit-la

Marvell Libertas 8388 802.11 USB - added to Orbit

2007-01-25 Thread Luis R. Rodriguez
I've slapped the two Marvell Libertas 8388 802.11 USB cards onto Winlab's Orbit testbed on sandbox 8. This allows anyone willing to help hack on the driver with access to a node with the wireless card. http://www.orbit-lab.org/wiki/Documentation/Developers Luis - To unsubscribe from this list:

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Gene Heskett
On Thursday 25 January 2007 07:50, Jiri Benc wrote: >On Thu, 25 Jan 2007 12:47:08 +0100, Ivo Van Doorn wrote: >> Correct, similar problems have been detected in rt2x00. The temporary >> solution in there is to demand a scanning operation after the >> interface has been brought up. > >Scanning? No n

RE: bonding: bug in balance-alb mode (incorrect update-ARP-replie s)

2007-01-25 Thread JUNG, Christian
> Jay Vosburgh <[EMAIL PROTECTED]> wrote: > > Is your test occuring on an isolated network, and is there other > concurrent network traffic that might be affecting things? The problem still persists as long as the box is connected to our Ciscos. I tried to simulate it with a dumb switch wi

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Gene Heskett
On Thursday 25 January 2007 09:23, Jiri Benc wrote: >On Thu, 25 Jan 2007 09:05:32 -0500, Gene Heskett wrote: >> Oh? I'm sitting here watching the tty0 screen of my lappy after x has >> been started, and I have established a connection, but SoftMAC is >> still logging its scan activity, starting wi

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Jiri Benc
On Thu, 25 Jan 2007 09:05:32 -0500, Gene Heskett wrote: > Oh? I'm sitting here watching the tty0 screen of my lappy after x has > been started, and I have established a connection, but SoftMAC is still > logging its scan activity, starting with channel 1 and scanning 14 > channels. Its doing t

Re: [BUG] problem with BPF in PF_PACKET sockets, introduced in linux-2.6.19

2007-01-25 Thread Alexey Kuznetsov
Hello! > So this whole idea to make run_filter() return signed integers > and fail on negative is entirely flawed, it simply cannot work > and retain the expected semantics which have been there forever. Actually, it can. Return value was used only as sign of error, so that the mistake was to ret

[take34 10/10] kevent: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

2007-01-25 Thread Evgeniy Polyakov
Kevent based AIO (aio_sendfile()/aio_sendfile_path()). aio_sendfile()/aio_sendfile_path() contains of two major parts: AIO state machine and page processing code. The former is just a small subsystem, which allows to queue callback for theirs invocation in process' context on behalf of pool of

[take34 9/10] kevent: Private userspace notifications.

2007-01-25 Thread Evgeniy Polyakov
Private userspace notifications. Allows to register notifications of any private userspace events over kevent. Events can be marked as readt using kevent_ctl(KEVENT_READY) command. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/kernel/kevent/kevent_unotify.c b/kernel/kevent/k

[take34 3/10] kevent: poll/select() notifications.

2007-01-25 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy Po

[take34 0/10] kevent: Generic event handling mechanism.

2007-01-25 Thread Evgeniy Polyakov
Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but it is more scalable, it is faster and allows to work with essentially eny kind of events. Ev

[take34 7/10] kevent: Signal notifications.

2007-01-25 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are use

[take34 8/10] kevent: Kevent posix timer notifications.

2007-01-25 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extensions to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git

[take34 5/10] kevent: Timer notifications.

2007-01-25 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of nanosec

[take34 4/10] kevent: Socket notifications.

2007-01-25 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Using trivial web server based on kevent and this features instead of epoll it's performance increased more than noticebly. More details about various benchmarks and server itself (evserver_kevent.c) can be found on

[take34 1/10] kevent: Description.

2007-01-25 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..d6e126f --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,271 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int flags)

[take34 6/10] kevent: Pipe notifications.

2007-01-25 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index 68090e8..0c75bf1 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include @@ -313,6 +314,7 @@ redo: break; } if

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Neil Horman
On Wed, Jan 24, 2007 at 05:54:47PM -0800, Sridhar Samudrala wrote: > Sec 2.1 of RFC 4429 says > >Unless noted otherwise, components of the IPv6 protocol stack should >treat addresses in the Optimistic state equivalently to those in the >Deprecated state, indicating that the address is

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Ivo Van Doorn
Hi, > Correct, similar problems have been detected in rt2x00. The temporary > solution in there is to demand a scanning operation after the interface > has been brought up. Scanning? No no no, please! That would be a clear bug and misbehaviour. Hmm, I think I forgot to add one little thing in

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Jiri Benc
On Thu, 25 Jan 2007 12:47:08 +0100, Ivo Van Doorn wrote: > Correct, similar problems have been detected in rt2x00. The temporary > solution in there is to demand a scanning operation after the interface > has been brought up. Scanning? No no no, please! That would be a clear bug and misbehaviour.

Re: [PATCH] net: decnet handle a failure in neigh_parms_alloc (take 2)

2007-01-25 Thread Steven Whitehouse
Hi, On Wed, Jan 24, 2007 at 09:55:45PM -0700, Eric W. Biederman wrote: > > While enhancing the neighbour code to handle multiple network > namespaces I noticed that decnet is assuming neigh_parms_alloc > will allways succeed, which is clearly wrong. So handle the > failure. > > Signed-off-by: E

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Ivo Van Doorn
Hi, I have discovered that while I can indeed associate without wpa_supplicant using bcm43xx_d80211 driver, I have to set the channel every time the interface is brought down and up. It turns out d80211 uses the "config" method of the hardware drivers very sparingly. It's only used for scannin

Re: [RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-25 Thread Jiri Benc
On Thu, 25 Jan 2007 01:50:54 -0500, Pavel Roskin wrote: > It turns out d80211 uses the "config" method of the hardware drivers > very sparingly. It's only used for scanning and in ioctl commands. It > is not called after the interface has been brought up with the "open" > method. > > I don't kno