Re: [PATCH 7/8] NetXen: Fix for PPC machines.

2006-12-26 Thread Christoph Hellwig
On Mon, Dec 18, 2006 at 05:53:59AM -0800, Amit S. Kale wrote: > Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> > > netxen_nic.h |2 +- > netxen_nic_init.c | 12 ++-- > netxen_nic_main.c |4 ++-- > 3 files changed, 9 insertions(+), 9 deletions(-) Please use __le* types f

Re: Network card IRQ balancing with Intel 5000 series chipsets

2006-12-26 Thread Robert Iakobashvili
On 12/27/06, jamal <[EMAIL PROTECTED]> wrote: On Wed, 2006-27-12 at 01:28 +0100, Arjan van de Ven wrote: > current irqbalance accounts for napi by using the number of packets as > indicator for load, not the number of interrupts. (for network > interrupts obviously) > Sounds a lot more promisin

Re: [PATCH] netxen: remove private ioctl

2006-12-26 Thread Amit S. Kale
On Friday 15 December 2006 21:27, Stephen Hemminger wrote: > The netxen driver includes a private ioctl that provides access > to functionality that is already available in other ways. The PCI > layer has application access hooks (see setpci), and the statistics > are available in ethtool/netstats.

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-26 Thread Noriaki TAKAMIYA
Hi, >> Wed, 27 Dec 2006 13:57:23 +0900 >> [Subject: Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for >> mobility header.] >> Masahide NAKAMURA <[EMAIL PROTECTED]> wrote > > Anyway, we have 4 options. > > > > 1. IPV6_CHECKSUM default for IPPROTO_MH == 4 > >omit checksumming

Re: [PATCH 7/8] NetXen: Fix for PPC machines.

2006-12-26 Thread Amit Kale
Thanks a lot for applying. We'll definitely take care of the patch format problems you've pointed out. -Amit On Wednesday 27 December 2006 03:19, Jeff Garzik wrote: > Amit S. Kale wrote: > > Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> > > > > netxen_nic.h |2 +- > > netxen_nic_init.

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-26 Thread Masahide NAKAMURA
YOSHIFUJI Hideaki / wrote: If it is okay to defer the checksumming after checking the next header protocol, we can omit the checksumming in mip6_mh_filter(), and leave it to rawv6_rcv() and rawv6_recvmsg(). Anyway, we have 4 options. 1. IPV6_CHECKSUM default for IPPROTO_MH == 4 omit ch

Re: Network card IRQ balancing with Intel 5000 series chipsets

2006-12-26 Thread jamal
On Wed, 2006-27-12 at 01:28 +0100, Arjan van de Ven wrote: > current irqbalance accounts for napi by using the number of packets as > indicator for load, not the number of interrupts. (for network > interrupts obviously) > Sounds a lot more promising. Although still insufficient in certain cases

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-26 Thread YOSHIFUJI Hideaki / 吉藤英明
Happy Holidays! In article <[EMAIL PROTECTED]> (at Sun, 10 Dec 2006 22:50:55 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Tue, 05 Dec 2006 20:02:42 +0900 (JST) > > > In article <[EMAIL PROTECTED]> (at Tue, 5 Dec 2006 19:03:27 +0900)

Re: Network card IRQ balancing with Intel 5000 series chipsets

2006-12-26 Thread Arjan van de Ven
On Tue, 2006-12-26 at 17:46 -0500, jamal wrote: > On Tue, 2006-26-12 at 23:06 +0100, Arjan van de Ven wrote: > > > it is; that's why irqbalance tries really hard (with a few very rare > > exceptions) to keep networking irqs to the same cpu all the time... > > > > The problem with irqbalance when

Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver

2006-12-26 Thread Russell King
On Tue, Dec 26, 2006 at 10:42:27PM +0100, Lennert Buytenhek wrote: > On Tue, Dec 26, 2006 at 04:41:17PM -0500, Jeff Garzik wrote: > > > >Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL > > >pointer before dereferencing it instead of after. Remove unreferenced > > >variabl

Re: Network card IRQ balancing with Intel 5000 series chipsets

2006-12-26 Thread jamal
On Tue, 2006-26-12 at 23:06 +0100, Arjan van de Ven wrote: > it is; that's why irqbalance tries really hard (with a few very rare > exceptions) to keep networking irqs to the same cpu all the time... > The problem with irqbalance when i last used it is it doesnt take into consideration CPU utili

Re: Pull request for 'r8169-upstream-fixes-20061226-00' tag

2006-12-26 Thread Jeff Garzik
Francois Romieu wrote: Please pull from tag 'r8169-upstream-fixes-20061226-00' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git tag r8169-upstream-fixes-20061226-00 pulled - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Pull request for 'r8169-upstream-fixes-20061226-00' tag

2006-12-26 Thread Francois Romieu
Please pull from tag 'r8169-upstream-fixes-20061226-00' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git tag r8169-upstream-fixes-20061226-00 to get the changes below. Distance from 'netdev-2.6

Re: Network card IRQ balancing with Intel 5000 series chipsets

2006-12-26 Thread jamal
On Tue, 2006-26-12 at 21:51 +0200, Robert Iakobashvili wrote: BTW, turn on PCI-E on in the kernel build and do cat /proc/interupts to see what i mean. > In meanwhile I have removed all userland processes from CPU0, > that handles network card interrupts and all packet-processing (kernel-space). >

Re: Network card IRQ balancing with Intel 5000 series chipsets

2006-12-26 Thread Arjan van de Ven
On Tue, 2006-12-26 at 13:44 -0500, jamal wrote: > If you compile in PCI-E support you should have more control of the > MSI-X, no? I would tie the MSI to a specific processor statically; my > past experiences with any form of interupt balancing with network loads > has been horrible. it is; that'

Re: [PATCH] forcedeth: modified comment header

2006-12-26 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch removes comment that forcedeth is not supported by NVIDIA. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

[git patch] Remove NetXen private ioctl

2006-12-26 Thread Jeff Garzik
IMO this should not make it out into general release, and most kernel hackers seemed to agree. Please pull from 'netxen-ioctl' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git netxen-ioctl to receive the following updates: drivers/net/netxen/netxen_nic.h |

Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver

2006-12-26 Thread Jeff Garzik
Lennert Buytenhek wrote: On Tue, Dec 26, 2006 at 04:41:17PM -0500, Jeff Garzik wrote: Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL pointer before dereferencing it instead of after. Remove unreferenced variable. Signed-off-by: Yan Burman <[EMAIL PROTECTED]> Cc: Jeff

Re: [PATCH 7/8] NetXen: Fix for PPC machines.

2006-12-26 Thread Jeff Garzik
Amit S. Kale wrote: Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> netxen_nic.h |2 +- netxen_nic_init.c | 12 ++-- netxen_nic_main.c |4 ++-- applied 7-8. your patch format is also broken: please read Documentation/SubmittingPatches, in particular: 12) The cano

Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver

2006-12-26 Thread Lennert Buytenhek
On Tue, Dec 26, 2006 at 10:42:27PM +0100, Lennert Buytenhek wrote: > > >Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL > > >pointer before dereferencing it instead of after. Remove unreferenced > > >variable. > > > > > >Signed-off-by: Yan Burman <[EMAIL PROTECTED]> > > >

Re: [PATCH 6/8] NetXen: work queue fixes.

2006-12-26 Thread Jeff Garzik
Amit S. Kale wrote: Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> netxen_nic.h |3 +-- netxen_nic_init.c |2 +- netxen_nic_main.c | 15 +++ applied your patches need more description though - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH 1/8] NetXen: Adding new device ids.

2006-12-26 Thread Jeff Garzik
Amit S. Kale wrote: Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> applied 1-5 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 0/6] sky2 driver update (v1.11)

2006-12-26 Thread Jeff Garzik
Stephen Hemminger wrote: Patches are in order of severity. 1-3 are bug fixes, 4 is a cleanup of the power state code, and 5 adds wake on lan support. IMHO, it is bad security policy to allow wake on lan to enabled by default. The sky2 driver doesn't do WOL until enabled with ethtool. While in

Re: [patch 3/7] driver for Silan SC92031 netdev

2006-12-26 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Cesar Eduardo Barros <[EMAIL PROTECTED]> This is a driver for the Silan SC92031/Rsltek 8139D NIC chip. This chip is found on at least one counterfeit Encore ENL832-TX-RENT NIC [1], which came with a mini-CD with the 2.4 driver. A slightly older version of the dri

Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver

2006-12-26 Thread Lennert Buytenhek
On Tue, Dec 26, 2006 at 04:41:17PM -0500, Jeff Garzik wrote: > >Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL > >pointer before dereferencing it instead of after. Remove unreferenced > >variable. > > > >Signed-off-by: Yan Burman <[EMAIL PROTECTED]> > >Cc: Jeff Garzik <[

Re: [patch 4/7] remove the broken SKMC driver

2006-12-26 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Adrian Bunk <[EMAIL PROTECTED]> The SKMC driver has: - already been marked as BROKEN in 2.6.0 three years ago and - is still marked as BROKEN. Drivers that had been marked as BROKEN for such a long time seem to be unlikely to be revived in the forseeable future.

Re: [patch 6/7] PHY probe not working properly for ibm_emac (PPC4xx)

2006-12-26 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Hynek Petrak <[EMAIL PROTECTED]> I have a system with AMCC PowerPC 405EP and PHY Intel LXT971A. Linux 2.6.18.3 is not able to detect the PHY ID correctly. The PHY ID detected is 0, but should be 0x1d. This is because phy_read() (__emac_mdio_read() resp.) from dr

Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver

2006-12-26 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Yan Burman <[EMAIL PROTECTED]> Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL pointer before dereferencing it instead of after. Remove unreferenced variable. Signed-off-by: Yan Burman <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED

Re: Please pull 'upstream' branch of wireless-2.6

2006-12-26 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 0c234ae655a45ac3ee53a25b2e56e9bb6c27d71d: Ulrich Kunitz (1): ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/

Re: Please pull 'upstream-fixes' branch of wireless-2.6

2006-12-26 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit e25db641c0e6dd49c5db24dbe154048d4a466727: Linus Torvalds (1): Merge master.kernel.org:/.../davej/cpufreq are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-f

Re: [patch 4/6] sky2: better power state management

2006-12-26 Thread Jeff Garzik
Stephen Hemminger wrote: Improve power management and error handling by using pci_set_power_state(), instead of driver doing PCI PM register changes in the driver. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [patch 1/6] sky2: dual port NAPI problem

2006-12-26 Thread Jeff Garzik
applied 1-3 to upstream-fixes - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Pull request for 'r8169-upstream-20061223-00' tag

2006-12-26 Thread Jeff Garzik
Francois Romieu wrote: Please pull from tag 'r8169-upstream-20061223-00' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git tag r8169-upstream-20061223-00 will request a resend once current netdev-2.6.git mirrors out to the outside world Jeff - To unsubscri

Re: [PATCH 0/5] qla3xxx:resubmit support for Qlogic 4032 and fixes.

2006-12-26 Thread Jeff Garzik
Ron Mercer wrote: These 5 patches were submitted on Dec 5th (1&2) and Dec 11th (3-5). They add/fix the following 1. Add support for Qlogic 4032 chip. 2. Change minor version for 4032 support. 3. Add delay when accessing NVRAM. 4. Remove NETIF_F_LLTX flag from features. It was left over from t

Re: [PATCH] smc911x

2006-12-26 Thread Jeff Garzik
Pierre TARDY wrote: Attached a patch on smc911x driver, which corrects obvious errors in the 16bit chips support of this driver. Please note that this driver still do NOT support 16bit chips (9115 and 9117), as it claims to, there may be mistakes in the data fifo managment, this patch enable

Re: [PATCH 1/5] myri10ge: match number of save_state and restore

2006-12-26 Thread Jeff Garzik
Brice Goglin wrote: Since pci_save_state() pushes MSI and PCIe states on a kind of stack, myri10ge saving the state in advance for parity recovery will push the state again on the stack on suspend. This leads to some memory leak. We add a couple additional calls to save_state and restore_state so

Re: [PATCH] via-velocity uses INET interfaces

2006-12-26 Thread Jeff Garzik
Randy Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-26 Thread Jeff Garzik
Herbert Xu wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: +#ifdef CONFIG_DEBUG_SLAB + /* 82544's work arounds do not play nicely with DEBUG SLAB */ + if (adapter->hw.mac_type == e1000_82544) + netdev->features &= ~NETIF_F_TSO; +#endif NAK, same reason as the others Any ch

Re: [PATCH] r8169: use the broken_parity_status field in pci_dev

2006-12-26 Thread Jeff Garzik
Francois Romieu wrote: The former option is removed and platform code can now specify the expected behavior. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] netpoll: drivers must not enable IRQ unconditionally in their NAPI handler

2006-12-26 Thread Jeff Garzik
Francois Romieu wrote: net/core/netpoll.c::netpoll_send_skb() calls the poll handler when it is available. As netconsole can be used from almost any context, IRQ must not be enabled blindly in the NAPI handler of a driver which supports netpoll. b57bd06655a028aba7b92e1c19c2093e7fcfb341 fixed the

Re: [PATCH 0/3] chelsio driver changes

2006-12-26 Thread Jeff Garzik
Stephen Hemminger wrote: One error path bug fix, and a couple of changes to improve receive performance. The performance is now up to 5+ Gbits/sec which is about the limit of the memory/bus on the test systems. I request a rediff+resend against netdev-2.6.git#upstream, giving sufficient time

Re: [PATCH 1/14] Spidernet DMA coalescing

2006-12-26 Thread Jeff Garzik
Linas Vepstas wrote: The current driver code performs 512 DMA mappings of a bunch of 32-byte ring descriptor structures. This is silly, as they are all in contiguous memory. This patch changes the code to dma_map_coherent() each rx/tx ring as a whole. Signed-off-by: Linas Vepstas <[EMAIL PROT

Re: [PATCH 0/7] chelsio: introduction

2006-12-26 Thread Jeff Garzik
Francois Romieu wrote: The serie applies against netdev-2.6#upstream-linus or linux-2.6#master Patches have been compiled. No further test. It is available as: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#chelsio Perfect pull. Pulled, thanks. Jeff - To unsubscribe

Re: [PATCH 1/10] cxgb3 - main header files

2006-12-26 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the main header files of the Chelsio T3 network driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> Once you think it's ready, email me a URL to a single patch that adds the driver to the latest linux-2.6.git k

Re: Network card IRQ balancing with Intel 5000 series chipsets

2006-12-26 Thread Robert Iakobashvili
On 12/26/06, jamal <[EMAIL PROTECTED]> wrote: If you compile in PCI-E support you should have more control of the MSI-X, no? I would tie the MSI to a specific processor statically; my past experiences with any form of interupt balancing with network loads has been horrible. cheers, jamal Than

Re: Network card IRQ balancing with Intel 5000 series chipsets

2006-12-26 Thread jamal
If you compile in PCI-E support you should have more control of the MSI-X, no? I would tie the MSI to a specific processor statically; my past experiences with any form of interupt balancing with network loads has been horrible. cheers, jamal On Mon, 2006-25-12 at 14:54 +0200, Robert Iakobashvil

Re: [patch] ifb double-counts packets

2006-12-26 Thread jamal
On Sat, 2006-23-12 at 13:58 -0800, dean gaudet wrote: > Signed-off-by: dean gaudet <[EMAIL PROTECTED]> Acked-by: Jamal Hadi Salim <[EMAIL PROTECTED]> cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo

[patch] ebtables: don't compute gap before checking struct type

2006-12-26 Thread Chuck Ebbert
We cannot compute the gap until we know we have a 'struct ebt_entry' and not 'struct ebt_entries'. Failure to check can cause crash. Tested by Santiago Garcia Mantinan <[EMAIL PROTECTED]> Signed-off-by: Chuck Ebbert <[EMAIL PROTECTED]> --- Can we get this upstream quickly? The bug's also in 2.6

[ANNOUNCE] new home for atl1 driver

2006-12-26 Thread Chris Snook
Happy Boxing Day! If you just turned on your shiny new box and discovered that it's got an Attansic L1 gigabit ethernet chip in it, and can't get Linux to recognize it, fear not. Jay and I are still working on getting the driver ready for merging. A lot of the fancy stuff is un(der)tested,

Re: bcm43xx-softmac broken on 2.6.20-rc2

2006-12-26 Thread Andreas Schwab
Larry Finger <[EMAIL PROTECTED]> writes: > The patch does not apply because your mailer is breaking the white space and > substituting spaces for > tabs. No, it does not apply because it was space-stuffed. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Max

Re: fix for 2.9.20-rc2 null pointer dereference in SoftMAC? was Re: [PATCH] softmac: Fix for work struct changes

2006-12-26 Thread Larry Finger
bert hubert wrote: On Sun, Dec 10, 2006 at 03:37:27PM -0600, Larry Finger wrote: casted to (void*). This compiled correctly but resulted in a softlock, because mutex_lock was called with the wrong memory address. The patch fixes the problem. Another issue was a wrong (quickly, between christma

Re: bcm43xx-softmac broken on 2.6.20-rc2

2006-12-26 Thread Larry Finger
bert hubert wrote: On Sun, Dec 24, 2006 at 09:51:50AM -0600, Larry Finger wrote: This is a heads-up for anyone wishing to use bcm43xx-softmac on Linus's git tree, which is now at v2.6.20-rc2. There are two serious bugs in that code. Fixes are found below. For some reason your patch does not a

Re: bcm43xx-softmac broken on 2.6.20-rc2

2006-12-26 Thread bert hubert
On Sun, Dec 24, 2006 at 09:51:50AM -0600, Larry Finger wrote: > This is a heads-up for anyone wishing to use bcm43xx-softmac on Linus's git > tree, which is now at > v2.6.20-rc2. There are two serious bugs in that code. Fixes are found below. For some reason your patch does not apply to stock 2.6

fix for 2.9.20-rc2 null pointer dereference in SoftMAC? was Re: [PATCH] softmac: Fix for work struct changes

2006-12-26 Thread bert hubert
On Sun, Dec 10, 2006 at 03:37:27PM -0600, Larry Finger wrote: > casted to (void*). This compiled correctly but resulted in a > softlock, because mutex_lock was called with the wrong memory > address. The patch fixes the problem. Another issue was a wrong (quickly, between christmas dinner preparat