Re: watchdog timeout panic in e1000 driver

2006-12-11 Thread Kenzo Iwami
Hi, > There are several issues that are conflicting and mixing that make it less > than > intuitive to decide what the better fix is. > > Most of all, we discussed that adding a spinlock is not going to fix the > underlying > problem of contention, as the code that would need to be spinlocked

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-11 Thread Ivo Van Doorn
Hi, > > > > > 2 - Hardware key that does not control the hardware radio and does not report anything to userspace > > > > > > > > Kind of uninteresting button ;) > > > > > > And this is the button that rfkill was originally designed for. > > > Laptops with integrated WiFi cards from Ralink have

[take27 5/8] kevent: Timer notifications.

2006-12-11 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of nanosec

[take27 8/8] kevent: Kevent posix timer notifications.

2006-12-11 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extensions to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git

[take27 4/8] kevent: Socket notifications.

2006-12-11 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Using trivial web server based on kevent and this features instead of epoll it's performance increased more than noticebly. More details about various benchmarks and server itself (evserver_kevent.c) can be found on

[take27 3/8] kevent: poll/select() notifications.

2006-12-11 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy Po

[take27 0/8] kevent: Generic event handling mechanism.

2006-12-11 Thread Evgeniy Polyakov
Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but it is more scalable, it is faster and allows to work with essentially eny kind of events. Ev

[take27 1/8] kevent: Description.

2006-12-11 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..2e03a3f --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,240 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int flags)

[take27 6/8] kevent: Pipe notifications.

2006-12-11 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index f3b6f71..aeaee9c 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include @@ -312,6 +313,7 @@ redo: break; } if

[take27 7/8] kevent: Signal notifications.

2006-12-11 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are use

dhcpclient netlink bugs (was Re: [NETLINK]: Schedule removal of old macros exported to userspace)

2006-12-11 Thread Stefan Rompf
Am Sonntag, 10. Dezember 2006 13:15 schrieb Thomas Graf: > > Please send me the list of bugs you've spotted. Of course I want to fix > > them. > > Sure... > > static void nl_handlemsg(struct nlmsghdr *msg, unsigned int len) { > if (len < sizeof(*msg)) return; > > while(NLMSG_OK(msg,len)) { >

Re: [patch sungem] improved locking

2006-12-11 Thread Eric Lemoine
On 12/12/06, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: On Tue, 2006-12-12 at 06:33 +0100, Eric Lemoine wrote: > On 12/12/06, David Miller <[EMAIL PROTECTED]> wrote: > > [...] > > Anyways, Eric your changes look fine as far as I can tell, can you > > give them a really good testing on some

Re: [take26-resend1 7/8] kevent: Signal notifications.

2006-12-11 Thread Evgeniy Polyakov
On Mon, Dec 11, 2006 at 12:32:55PM -0400, Mauricio Lin ([EMAIL PROTECTED]) wrote: > Hi Evgeniy, Hi Mauricio. > I have used kobject_uevent() to notify userspace about some events. > For instance, when memory comsumption reaches a predefined watermark, > a signal is sent to userspace to allow appl

Re: [take26-resend1 0/8] kevent: Generic event handling mechanism.

2006-12-11 Thread Evgeniy Polyakov
On Mon, Dec 11, 2006 at 10:16:30AM -0500, Jeff Garzik ([EMAIL PROTECTED]) wrote: > Comments: > > * [oh, everybody will hate me for saying this, but...] to me, "kevent" > implies an internal kernel subsystem. I would rather call it "uevent" > or anything else lacking a 'k' prefix. It is kernel

Re: [patch sungem] improved locking

2006-12-11 Thread Benjamin Herrenschmidt
On Tue, 2006-12-12 at 06:33 +0100, Eric Lemoine wrote: > On 12/12/06, David Miller <[EMAIL PROTECTED]> wrote: > > [...] > > Anyways, Eric your changes look fine as far as I can tell, can you > > give them a really good testing on some SMP boxes? > > Unfortunately I can't, I don't have the hardware

[PATCH] drivers/net: spidernet driver on Celleb

2006-12-11 Thread Ishizaki Kou
Following are the changes. -This patch enables auto-negotiation. -Loading firmware is done when spidernet_open() is called. -And this patch adds other several small changes for Celleb. -This patch is not tested on CellBlade. Signed-off-by: Kou Ishizaki --- Dear everyone, This is the patch (be

Re: [patch sungem] improved locking

2006-12-11 Thread Eric Lemoine
On 12/12/06, David Miller <[EMAIL PROTECTED]> wrote: [...] Anyways, Eric your changes look fine as far as I can tell, can you give them a really good testing on some SMP boxes? Unfortunately I can't, I don't have the hardware (only an old ibook here). -- Eric - To unsubscribe from this list: s

Re: Kevent POSIX timers support.

2006-12-11 Thread Evgeniy Polyakov
On Mon, Dec 11, 2006 at 05:36:44PM -0800, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Tue, 28 Nov 2006 22:22:36 +0300 > > > And, btw, last time I checked, aligned_u64 was not exported to > > userspace. > > It is in linux/types.h and not protected

[PATCH] add init_dummy_netdev() for napi only dummy intefaces

2006-12-11 Thread Benjamin Herrenschmidt
This adds an init_dummy_netdev() function that gets a network device structure (allocation and lifetime entirely under caller's control) and initialize the minimum amount of fields so it can be used to schedule NAPI polls without registering a full blown interface. This is to be used by drivers tha

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-11 Thread Dmitry Torokhov
Hi Ivo, On Thursday 07 December 2006 16:53, Ivo van Doorn wrote: > Hi, > > > > > >  2 - Hardware key that does not control the hardware radio and does > > > > > not report anything to userspace > > > > > > > > Kind of uninteresting button ;) > > > > > > And this is the button that rfkill was ori

Re: d80211-drivers pull request (week-48)

2006-12-11 Thread Michael Wu
On Monday 11 December 2006 22:51, Daniel Drake wrote: > It's ugly, in my mind not necessary, and it will kill performance. We > haven't had to make such compromises in a long time. We got a large TX > speed boost when the driver was modified to queue up multiple transmit > URBs (i.e. don't wait for

ieee80211 sleeping in invalid context

2006-12-11 Thread Ray Lee
Hey all, more data on my bcm43xx problem report from a few weeks back. By random chance I acquired a brain, and decided to rebuild my latest kernel pull with as many debugging options on as I could stand. Got the below, plus a dead keyboard (except for Magic SysRq) (but only if I let userspace com

Re: d80211-drivers pull request (week-48)

2006-12-11 Thread Daniel Drake
Michael Wu wrote: I don't think this race is such a big deal. It will only happen when someone is really trying to mess with the link, and would cause the rate control to jump to the highest speed. However, if someone is really trying to mess with the link this way, the stability of the link is

Re: d80211-drivers pull request (week-48)

2006-12-11 Thread Michael Wu
On Monday 11 December 2006 20:07, Daniel Drake wrote: > Michael Wu wrote: > > zd1211rw-d80211: Use ieee80211_tx_status > > I've thought some more about this and I'm not so sure that this is the > right approach. > > Can't devicescape be taught that the ZD1211 handles retries in hardware > and

Re: [patch sungem] improved locking

2006-12-11 Thread David Miller
From: "Eric Lemoine" <[EMAIL PROTECTED]> Date: Wed, 29 Nov 2006 11:56:30 +0100 > I don't understand why we'd need all this. > > I think the following code for gem_interrupt should do the trick: ... > The important thing is: we __netif_rx_schedule even if gem_status is 0 > (shared irq case) becaus

Re: Kevent POSIX timers support.

2006-12-11 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Tue, 28 Nov 2006 22:22:36 +0300 > And, btw, last time I checked, aligned_u64 was not exported to > userspace. It is in linux/types.h and not protected by __KERNEL__ ifdefs. Perhaps you mean something else? - To unsubscribe from this list: send the

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-12-11 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 1 Dec 2006 15:37:55 +1100 > So in general when allocating packets we have two scenarios: > > 1) The dst is known and fixed, i.e., all datagram protocols. This is > the easy case where the headroom is known exactly beforehand. > > 2) The dst is unk

Re: [PATCH] zd1211rw-d80211: Use LED class

2006-12-11 Thread Michael Wu
On Monday 11 December 2006 17:55, Ulrich Kunitz wrote: > I cannot accknowledge this patch. Michael, the LED does not only > show the link status, but also indicate that packets are sent, > which is done by the firmware. However the LED flags have to be > reset every second, because if an odd number

Re: [IPROUTE2 PATCH][GENETLINK] Add controller support for new features exposed

2006-12-11 Thread jamal
On Mon, 2006-11-12 at 17:37 +0100, Ingo Oeser wrote: > Hi Jamal, > > jamal wrote: > > + > > + if (fl & GENL_ADMIN_PERM) > > + fprintf(fp, " requires admin permission;"); > > + if (fl & GENL_CMD_CAP_DO) > > + fprintf(fp, " can doit;"); > > + if (fl & GE

[PATCH] zd1211rw: Consistency for address space constants

2006-12-11 Thread Daniel Drake
The zd1211rw address space has confused me once too many times. This patch introduces the following naming notation: Memory space is split into segments (cr, fw, eeprom) and segments may contain components (e.g. boot code inside eeprom). These names are arbitrary and only for the description below

[PATCH] zd1211rw: Remove addressing abstraction

2006-12-11 Thread Daniel Drake
Instead of passing our own custom 32-bit addresses around and translating them, this patch makes all our register address constants absolute and removes the translation. There are two ugly parts: - fw_reg_addr() is needed to compute addresses of firmware registers, as this is dynamic based upo

[PATCH] zd1211rw: Generic HMAC initialization

2006-12-11 Thread Daniel Drake
Many of the registers written during ZD1211 HMAC initialization are duplicated exactly for ZD1211B. Move the identical ones into a generic part, and write the hardware-specific ones separately. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> Index: linux/drivers/net/wireless/zd1211rw/zd_chip.c ==

[PATCH] zd1211rw: 2 new ZD1211B device ID's

2006-12-11 Thread Daniel Drake
Philips SNU5600, tested by unibrow zd1211b chip 0471:1236 v4810 high 00-12-bf AL2230_RF pa0 g-- SMC Ez Connect 802.11g (SMCWUSB-G), tested by Victorino Sanz Prat zd1211b chip 083a:4505 v4810 full 00-13-f7 AL2230_RF pa0 g--N Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_usb.c |2 ++

Re: d80211-drivers pull request (week-48)

2006-12-11 Thread Daniel Drake
Michael Wu wrote: zd1211rw-d80211: Use ieee80211_tx_status I've thought some more about this and I'm not so sure that this is the right approach. Can't devicescape be taught that the ZD1211 handles retries in hardware and the stack doesn't need to worry about it? What does devicesca

Please pull 'upstream' branch of wireless-2.6

2006-12-11 Thread John W. Linville
The following changes since commit 9202f32558601c2c99ddc438eb3218131d00d413: Ralf Baechle: [MIPS] Export local_flush_data_cache_page for sake of IDE. are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Roy Marples:

[PATCH 5/7] chelsio: useless test in cxgb2::remove_one

2006-12-11 Thread Francois Romieu
pci_get_drvadata() is necessarily distinct from NULL if cxgb2::init_one succeeded. cxgb2::remove_one is solely issued through the PCI device callback. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c | 32 1 files changed, 16 in

[PATCH 7/7] chelsio: tabulate the update of the statistic counters

2006-12-11 Thread Francois Romieu
Let's try to avoid some code duplication. - cxgb2 The data are contiguous. Use plain memcpy. - ixf1010/pm3393/vsc7326 The cast of &mac->stats to (u64 *) is not wonderful but it is not clear if it is worth to add an ad-hoc union under the struct cmac_statistics. vsc7326_reg.h suggests that

[PATCH 6/7] chelsio: misc cleanups in sge

2006-12-11 Thread Francois Romieu
- duplicated code in sge::free_cmdQ_buffers ; - NET_IP_ALIGN is already defined in (included) ; - pci_alloc_consistent() returns void * ; - pci_alloc_consistent() returns a zeroed chunk of memory ; - early return in restart_tx_queues. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- driver

[PATCH 2/7] chelsio: the return statement is not a function

2006-12-11 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/chelsio/my3126.c | 16 drivers/net/chelsio/vsc7326.c | 12 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/chelsio/my3126.c b/drivers/net/chelsio/my3126.c index c7731b

[PATCH 4/7] chelsio: useless curly braces

2006-12-11 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c |3 +-- drivers/net/chelsio/mv88e1xxx.c |4 ++-- drivers/net/chelsio/sge.c |3 +-- drivers/net/chelsio/vsc7326.c |3 +-- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/dri

[PATCH 3/7] chelsio: spaces, tabs and friends

2006-12-11 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/chelsio/common.h|2 - drivers/net/chelsio/cpl5_cmd.h | 18 +++--- drivers/net/chelsio/cxgb2.c | 64 ++-- drivers/net/chelsio/elmer0.h| 40 ++-- drivers/net/chelsio/espi.c | 41 +

[PATCH 1/7] chelsio: move return, break and continue statements on their own line

2006-12-11 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/chelsio/espi.c |3 ++- drivers/net/chelsio/ixf1010.c |9 ++--- drivers/net/chelsio/mv88e1xxx.c |6 -- drivers/net/chelsio/subr.c |6 -- drivers/net/chelsio/vsc7326.c |3 ++- drivers/net

[PATCH 0/7] chelsio: introduction

2006-12-11 Thread Francois Romieu
The serie applies against netdev-2.6#upstream-linus or linux-2.6#master Patches have been compiled. No further test. It is available as: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#chelsio Former 'chelsio' branch is archived as 'chelsio-20061211'. Distanc

Re: [PATCH] zd1211rw-d80211: Use LED class

2006-12-11 Thread Ulrich Kunitz
On 06-12-11 00:44 Michael Wu wrote: > This makes zd1211rw-d80211 register an LED class to control the link LED > instead of trying to determine when the LED should be on based on the > current bssid. No default trigger is set since d80211 doesn't currently > have a link on/off LED trigger. I cann

Re: [PATCH 11/22] e1000: Fire a link even interrupt instead of a watchdog at init.

2006-12-11 Thread Shaw Vrana
On Fri, Dec 08, 2006 at 03:03:09PM -0800, Kok, Auke wrote: > > Instead of calling a watchdog event we let our interrupt handler > cascade a link event. This allows us to spot link up immediately > after _up() without racing against a new watchdog. > > Signed-off-by: Jesse Brandeburg <[EMAIL PROTE

[PATCH 2/3] qla3xxx: Remove NETIF_F_LLTX from driver features.

2006-12-11 Thread Ron Mercer
The TX locking was removed some time ago but this flag was overlooked. Signed-off-by: Ron Mercer <[EMAIL PROTECTED]> --- drivers/net/qla3xxx.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index 5aef8aa..24205c6 100644 --- a

[PATCH 3/3] qla3xxx: Fixed rx checksum warning.

2006-12-11 Thread Ron Mercer
Signed-off-by: Ron Mercer <[EMAIL PROTECTED]> --- drivers/net/qla3xxx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index 24205c6..f384e40 100644 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -1879,7 +1879,7 @

[PATCH 1/3] qla3xxx: Add delay to NVRAM register access.

2006-12-11 Thread Ron Mercer
Some platforms showed issues when no delay was used. This code only runs during the probe. Signed-off-by: Ron Mercer <[EMAIL PROTECTED]> --- drivers/net/qla3xxx.c | 37 +++-- 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/net/qla3xxx.c

Re: [PATCH] ieee80211softmac: Fix errors related to the work_struct changes

2006-12-11 Thread John W. Linville
On Sun, Dec 10, 2006 at 10:24:27PM -0600, Larry Finger wrote: > I thought that when someone _BROKE_ an interface with this kind of change, > it was their duty to fix _ALL_ parts of the system that uses this facility. > At a minimum, shouldn't all maintainers get a heads up? I don't subscribe >

RE: [PATCH 03/22] ixgb: Write RA register high word first, increment version

2006-12-11 Thread Brandeburg, Jesse
Jeff Garzik wrote: >> -IXGB_WRITE_REG_ARRAY(hw, RA, (i << 1), 0); >> +/* Write high reg first to disable the AV bit first */ >> IXGB_WRITE_REG_ARRAY(hw, RA, ((i << 1) + 1), 0); >> +IXGB_WRITE_REG_ARRAY(hw, RA, (i << 1), 0); > > Are you sure the orde

Re: Fw: [Bugme-new] [Bug 7665] New: getsockopt(IPV6_*CAST_HOPS) returns -1

2006-12-11 Thread Brian Haley
Andrew Morton wrote: Where fd is a socket (datagram or raw) with IPv6 protocol family, getsockopt(fd, IPPROTO_IPV6, IPV6_UNICAST_HOPS, ...) succeeds, but the returned hop limit is -1. connect()'ing the socket first does not solve the problem. An IPv6 socket's hoplimit value is not set at creat

kernel panic with the newly merged md5 signature support

2006-12-11 Thread Leigh Brown
Hello, I decided to try out the md5 signature support, with a view to eventually fixing up Quagga to make use of it. As the API has changed quite a bit, I modified a simple echo client/server as a simple test. I compiled up 2.6.19-git17 and ran it under debian etch. Unfortunately, both the clie

Re: [PATCH 3/16] Spidernet RX Locking

2006-12-11 Thread Linas Vepstas
On Sat, Dec 09, 2006 at 09:47:05AM +1100, Benjamin Herrenschmidt wrote: > A spinlock is expensive in the fast path, which is why Jeff says it's > invasive. > > > spider_net_decode_one_descr() is called from > > spider_net_poll() (which is the netdev->poll callback) > > and also from spider_net_han

Re: [PATCH v3 00/13] 2.6.20 Chelsio T3 RDMA Driver

2006-12-11 Thread Divy Le Ray
Divy Le Ray wrote: Steve Wise wrote: On Sun, 2006-12-10 at 20:02 -0800, Roland Dreier wrote: I haven't seen any evidence of the corresponding ethernet NIC driver being merged for 2.6.20 (which is a prerequisite, right). What's the status of that? It is on its third or fourth round of

Re: [PATCH v3 00/13] 2.6.20 Chelsio T3 RDMA Driver

2006-12-11 Thread Divy Le Ray
Steve Wise wrote: On Sun, 2006-12-10 at 20:02 -0800, Roland Dreier wrote: I haven't seen any evidence of the corresponding ethernet NIC driver being merged for 2.6.20 (which is a prerequisite, right). What's the status of that? It is on its third or fourth round of review. The last

Re: [PATCH] [FS_ENET] OF-related update for FEC and SCC MAC's

2006-12-11 Thread Vitaly Bordug
On Mon, 11 Dec 2006 21:00:49 +0300 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > > Updated direct resource pass with ioremap call, make it grant proper IRQ > mapping, stuff incompatible with the new approach were respectively put > under > #ifndef CONFIG_PPC_MERGE. Hrm, Signed-off-by: missed, I'

[PATCH] [FS_ENET] OF-related update for FEC and SCC MAC's

2006-12-11 Thread Vitaly Bordug
Updated direct resource pass with ioremap call, make it grant proper IRQ mapping, stuff incompatible with the new approach were respectively put under #ifndef CONFIG_PPC_MERGE. --- drivers/net/fs_enet/mac-fec.c | 13 + drivers/net/fs_enet/mac-scc.c |6 -- drivers/net/phy/

Fw: [Bugme-new] [Bug 7665] New: getsockopt(IPV6_*CAST_HOPS) returns -1

2006-12-11 Thread Andrew Morton
Begin forwarded message: Date: Mon, 11 Dec 2006 07:18:20 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 7665] New: getsockopt(IPV6_*CAST_HOPS) returns -1 http://bugzilla.kernel.org/show_bug.cgi?id=7665 Summary: getsockopt(IPV6_*CAST_HOPS) returns -1

Re: [PATCH] ieee80211softmac: Fix errors related to the work_struct changes

2006-12-11 Thread Larry Finger
Andrew Morton wrote: On Sun, 10 Dec 2006 19:35:36 +0100 Ulrich Kunitz <[EMAIL PROTECTED]> wrote: The problem is that you there are now different work structures: struct work_struct and struct delayed_work. The quick fix seems to have been to change all old work_structs as associnfo's work to de

Re: linux-2.6.19-g3263263f build #185 failed

2006-12-11 Thread Randy Dunlap
On Mon, 11 Dec 2006 10:43:31 +0100 Toralf Förster wrote: > > Hello, > > the build with the attached .config failed, make ends with: > ... > LD drivers/media/dvb/bt8xx/built-in.o > LD drivers/media/dvb/cinergyT2/built-in.o > LD drivers/media/dvb/dvb-core/built-in.o > LD

Re: [take26-resend1 7/8] kevent: Signal notifications.

2006-12-11 Thread Mauricio Lin
Hi Evgeniy, I have used kobject_uevent() to notify userspace about some events. For instance, when memory comsumption reaches a predefined watermark, a signal is sent to userspace to allow applications to free resources. But I am not sure if kobject_uevent() is the more appropriate way for that s

[git patches] net driver updates

2006-12-11 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/Kconfig |8 + drivers/net/chelsio/cxgb2.c | 23 +- drivers/net/chelsio/sge.c | 115 -

Re: [PATCH v3 00/13] 2.6.20 Chelsio T3 RDMA Driver

2006-12-11 Thread Steve Wise
On Sun, 2006-12-10 at 20:02 -0800, Roland Dreier wrote: > I haven't seen any evidence of the corresponding ethernet NIC driver > being merged for 2.6.20 (which is a prerequisite, right). > > What's the status of that? > It is on its third or fourth round of review. The last driver posted on 12/

Re: [take26-resend1 0/8] kevent: Generic event handling mechanism.

2006-12-11 Thread Jeff Garzik
Comments: * [oh, everybody will hate me for saying this, but...] to me, "kevent" implies an internal kernel subsystem. I would rather call it "uevent" or anything else lacking a 'k' prefix. * I like the absolute timespec (and use of timespec itself) * more on naming: I think kevent_open w

[take26-resend1 5/8] kevent: Timer notifications.

2006-12-11 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of nanosec

Re: [PATCH 1/7] myri10ge: indentation cleanups

2006-12-11 Thread Jeff Garzik
Brice Goglin wrote: Indentation cleanups to synchronize to our tree which is automatically indent'ed. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> applied 1-7 thanks for splitting the page alloc stuff, that helped - To unsubscribe from this list: send the line "unsubscribe netdev" in the

[take26-resend1 7/8] kevent: Signal notifications.

2006-12-11 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are use

[take26-resend1 6/8] kevent: Pipe notifications.

2006-12-11 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index f3b6f71..aeaee9c 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include @@ -312,6 +313,7 @@ redo: break; } if

[take26-resend1 4/8] kevent: Socket notifications.

2006-12-11 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Using trivial web server based on kevent and this features instead of epoll it's performance increased more than noticebly. More details about various benchmarks and server itself (evserver_kevent.c) can be found on

Re: [PATCH 14/22] e1000: always turn on receives on esb2

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: In rare occasions, esb2 systems would end up started without the RX unit being turned on. Add a check that runs post-init to make sure. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |7 +++

[take26-resend1 8/8] kevent: Kevent posix timer notifications.

2006-12-11 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extensions to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git

Re: [PATCH] chelsio: working NAPI

2006-12-11 Thread Jeff Garzik
Stephen Hemminger wrote: This driver tries to enable/disable NAPI at runtime, but does so in an unsafe manner, and the NAPI interrupt handling is a mess. Replace it with a compile time selected NAPI implementation. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied - To unsubscrib

Re: [PATCH 20/22] e1000: Fix poor quad port performance with NAPI

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: This fix attempts to solve a customer reported issue with NAPI enabled e1000 having bad performance when transmitting simultaneously on four ports. The issue comes down to an interaction between NAPI hardware interrupt balancing, and the driver rescheduling poll on the same proc

Re: [PATCH 13/22] e1000: disable TSO when debugging slab

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: CONFIG_DEBUG_SLAB kills TSO on the 82544, so we're better off turing TSO off in this rare case, assuming performance is not an issue for people running slab debugging. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/n

Re: [PATCH 21/22] e1000: Version increment 7.3.20-k2 and minor cleanups

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ACK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[take26-resend1 3/8] kevent: poll/select() notifications.

2006-12-11 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy Po

Re: [PATCH 15/22] e1000: simplify msi specific interrupt handler

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: Simplify the msi interrupt handler to avoid issues with delayed ICR reads. This avoids adapter specific problems at the cost of some performance. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000.h

[take26-resend1 0/8] kevent: Generic event handling mechanism.

2006-12-11 Thread Evgeniy Polyakov
Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but it is more scalable, it is faster and allows to work with essentially eny kind of events. Ev

[take26-resend1 1/8] kevent: Description.

2006-12-11 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..2e03a3f --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,240 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int flags)

Re: [PATCH 12/22] e1000: Fix powerdown link loss when forced to gig speed

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: disable phy power mode to prevent the NIC from attempting to autoneg to i10/100mbit when running in forced gig mode as it would lose link at shutdown. This allows you to force gig speed and still use WoL/IPMI after shutdow. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Sig

Re: [PATCH] myri10ge: pci msi and express state save/restore

2006-12-11 Thread Brice Goglin
Jeff Garzik wrote: > Stephen Hemminger wrote: >> The PCI MSI and express state are already saved and restored by the >> current versions of pci_save_state/pci_restore_state. >> Therefore it should no longer be necessary for the driver to do it. >> This patch has not been tested on the hardware. >>

Re: [PATCH 07/22] e1000: omit stats for broken counter in 82543

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: 82543 does not count tx_carrier_errors properly in FD mode. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers

Re: [PATCH 06/22] e1000: minor tso ipv6 cleanups

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: Zero descriptor ip_config field and use skb_shinfo to detect IPV6 packet. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ACK patches 4-6 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mess

Re: [PATCH 08/22] e1000: Fix all manageability workarounds

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: + /* enable receiving management packets to the host */ + /* this will probably generate destination unreachable messages +* from the host OS, but the packets will be handled on SMBUS */ + if (adapter->hw.mac_type >= e1000

Re: [PATCH 02/22] ixgb: Maybe stop TX if not enough free descriptors

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: A similar patch to commit 65c7973fa5b46b024f38be208aa477e8daf9a603 but now for ixgb. Cc: Herbert Xu <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ACK - To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 03/22] ixgb: Write RA register high word first, increment version

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: We need to disable the AV bit before flushing the low register. Signed-off-by: <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_hw.c |3 ++- drivers/net/ixgb/ixgb_main.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH 01/22] e1000: Fix early TSO completion

2006-12-11 Thread Jeff Garzik
Kok, Auke wrote: This fix was already merged in commit 96f9c2e277768099479fbed7c3b69c294b1fadef but reverted in commit 989316ddfeafd0e8fb51a4d811383769ad62637a. After stresstesting we found that the fix does not add new regressions and works around a TX hang spotted by several users. Signed-off-

Re: [PATCH] MACB: Use struct delayed_work instead of struct work_struct

2006-12-11 Thread Jeff Garzik
Haavard Skinnemoen wrote: The macb driver calls schedule_delayed_work() and friends, so we need to use a struct delayed_work along with it. The conversion was explained by David Howells on lkml Dec 5 2006: http://lkml.org/lkml/2006/12/5/269 Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]>

Re: [PATCH 1/2] ucc_geth: compilation error fixes

2006-12-11 Thread Jeff Garzik
Scott Wood wrote: Fix compilation failures when building the ucc_geth driver with spinlock debugging. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> applied 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [PATCH] myri10ge: pci msi and express state save/restore

2006-12-11 Thread Jeff Garzik
Stephen Hemminger wrote: The PCI MSI and express state are already saved and restored by the current versions of pci_save_state/pci_restore_state. Therefore it should no longer be necessary for the driver to do it. This patch has not been tested on the hardware. On suspend, handle pci_set_power_

Re: [RFC 0/3] more power to cfg80211

2006-12-11 Thread Jiri Benc
On Wed, 22 Nov 2006 20:18:53 +0100, Johannes Berg wrote: > The following patches are mostly proof-of-concept code for moving over > stuff to cfg80211 (like the wiphy thing). > > I've changed net_dev->ieee80211_ptr to be of struct wiphy because it > allows accessing the wiphy by netdev easily then,

[PATCH 7/7] myri10ge: update driver version to 1.1.0

2006-12-11 Thread Brice Goglin
Update driver version to 1.1.0. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-git/drivers/net/myri10ge/myri10ge.c === --- li

[PATCH 5/7] myri10ge: Full vlan frame in small_bytes

2006-12-11 Thread Brice Goglin
Receive full vlan frames into smalls when running with a jumbo MTU. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-git/drivers/net/myri10ge/myri10ge.c ==

[PATCH 6/7] myri10ge: fix big_bytes in case of vlan frames

2006-12-11 Thread Brice Goglin
Fix sizing of big_bytes in the case of vlan frames. The 4 VLAN_HLEN bytes were omitted, leading to sizing the big buffer 4 bytes smaller than it should be. Due to how rx buffers are carved from pages, this was harmless for the common (9000, 1500) byte MTUs, but could lead to data corruption for so

[PATCH 0/7] myri10ge updates

2006-12-11 Thread Brice Goglin
Hi Jeff, The following 7 patches update/fix myri10ge: 1. indentation cleanups 2. add page-based skb routines 3. switch to page-based skb 4. drop contiguous skb routines 5. full vlan frame in small_bytes 6. fix big_bytes in case of vlan frames 7. update driver version to 1.1.0 #1 is independent, w

[PATCH 4/7] myri10ge: drop contiguous skb routines

2006-12-11 Thread Brice Goglin
Drop the old routines that used the physically contigous skb now that we use the physical pages. And rename myri10ge_page_rx_done() to myri10ge_rx_done() as it was previously. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 212 +-

[PATCH 2/7] myri10ge: add page-based skb routines

2006-12-11 Thread Brice Goglin
Add physical page skb allocation routines and page based rx_done, to be used by upcoming patches. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 190 1 file changed, 190 insertions(+) Index: linux-git/drivers/net/my

[PATCH 3/7] myri10ge: switch to page-based skb

2006-12-11 Thread Brice Goglin
Switch to physical page skb, by calling the new page-based allocation routines and using myri10ge_page_rx_done(). Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 180 +--- 1 file changed, 97 insertions(+), 83 deletions(-)

[PATCH 1/7] myri10ge: indentation cleanups

2006-12-11 Thread Brice Goglin
Indentation cleanups to synchronize to our tree which is automatically indent'ed. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-git/drivers/net/myri10ge/myri10ge.c