Re: [PATCH] zd1211rw: Support for multicast addresses

2006-11-30 Thread Ulrich Kunitz
On 06-11-30 20:57 Daniel Drake wrote: > Stephen Hemminger wrote: > >Why all the trouble do it off work queue? Is someone calling > >set_multicast_list with IRQ's disabled? > > Register I/O involves sleeping, so we need to be in process context. > > in_atomic() returns non-zero in the set_multica

Re: [PATCH][IPSEC][6/7] inter address family ipsec tunnel

2006-11-30 Thread Kazunori MIYAZAWA
David Miller wrote: From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 14:39:01 +0900 This patch fixes mtu calculation of IPv4 ip_append_data should refer the mtu of "dst" not "path". if "dst" is stacked, "path" is the actual dst_entry in the routing table. therefore the mtu of

Re: [2.6 patch] NET_SCH_ATM doesn't need ipcommon.o

2006-11-30 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 06:04:37 + > On Mon, Nov 27, 2006 at 01:59:34AM +0100, Adrian Bunk wrote: > > NET_SCH_ATM doesn't need ipcommon.o > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- linux-2.6.19-rc6-mm1/net/atm/Makefile.old

Re: [PATCH][IPSEC][4/7] inter address family ipsec tunnel

2006-11-30 Thread Kazunori MIYAZAWA
David Miller wrote: From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 14:38:39 +0900 What is going on here? + /* Without this, the atomic inc below segfaults */ + if (encap_family == AF_INET6) { + rt->pe

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-30 Thread Herbert Xu
On Thu, Nov 30, 2006 at 08:22:06PM -0800, David Miller wrote: > > What MAX_HEADER's setting is trying to do is optimistically allocate > enough for a single level of tunnelling. It does not handle nested > tunneling at all, of course. Agreed, I should've said MAX_HEADER. > Actually, I wonder ho

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-30 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 29 Nov 2006 17:51:46 +1100 > I'm just emphasising that LL_MAX_HEADER is by no means the *maximum* > header size in a Linux system. But it is the maximum "link level" singular header size. It is MAX_HEADER which is the hack and the main issue. What

Re: pktgen

2006-11-30 Thread David Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 09:33:43 -0800 > Robert Olsson wrote: > > @@ -3673,6 +3673,8 @@ static void __exit pg_cleanup(void) > > struct list_head *q, *n; > > wait_queue_head_t queue; > > init_waitqueue_head(&queue); > > + > > + schedule_timeout_i

Re: [NET_SCHED]: policer: restore compatibility with old iproute binaries

2006-11-30 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 06:43:36 -0500 > On 11/26/06, Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > > > > > > [NET_SCHED]: policer: restore compatibility with old iproute binaries > > > > The tc actions increased the size of struct tc_police, which broke > > compa

Re: RFC: remove NET_CLS_POLICE?

2006-11-30 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 09:56:14 +0100 > * Patrick McHardy <[EMAIL PROTECTED]> 2006-11-26 14:21 > > One more thing NET_CLS_POLICE affects is CBQ reshape/reclassify > > handling, reshape_fail seems to be completely unhandled without > > NET_CLS_POLICE and reclas

Re: [2.6 patch] net/sched/: remove unused exports

2006-11-30 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 26 Nov 2006 07:29:31 +0100 > This patch removes the following unused EXPORT_SYMBOL's: > - sch_api.c: qdisc_lookup > - sch_generic.c: __netdev_watchdog_up > - sch_generic.c: noop_qdisc_ops > - sch_generic.c: qdisc_alloc > > Signed-off-by: Adrian Bun

Re: [PATCH 2/5] NetXen: temp monitoring, newer firmware support, mm footprint reduction

2006-11-30 Thread Stephen Hemminger
> > @@ -869,7 +937,10 @@ static inline void netxen_nic_disable_in > > /* > > * ISR_INT_MASK: Can be read from window 0 or 1. > > */ > > - writel(0x7ff, (void __iomem *)(adapter->ahw.pci_base + ISR_INT_MASK)); > > + writel(0x7ff, > > + (void __iomem > > + *)(PCI

Re: [PATCH] zd1211rw: Support for multicast addresses

2006-11-30 Thread Daniel Drake
Stephen Hemminger wrote: Why all the trouble do it off work queue? Is someone calling set_multicast_list with IRQ's disabled? Register I/O involves sleeping, so we need to be in process context. in_atomic() returns non-zero in the set_multicast_list handler. I couldn't tell you which codepath

Re: [PATCH] zd1211rw: Support for multicast addresses

2006-11-30 Thread Stephen Hemminger
On Fri, 1 Dec 2006 00:58:07 + (GMT) Daniel Drake <[EMAIL PROTECTED]> wrote: > From: Ulrich Kunitz <[EMAIL PROTECTED]> > > Support for multicast adresses is implemented by supporting the > set_multicast_list() function of the network device. Address > filtering is supported by a group hash ta

Re: [PATCH 0/5 addendum] NetXen

2006-11-30 Thread Jeff Garzik
Don Fry wrote: On Thu, Nov 30, 2006 at 07:15:50PM -0500, Jeff Garzik wrote: Don Fry wrote: The NetXen patches fix many problems in the current #upstream version of the driver. It has warts and probably lots of bugs still, but it is better than what is queued for mainline inclusion at this time

Re: [-mm patch] net/: possible cleanups

2006-11-30 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 22:58:20 +0100 > This patch contains the following possible cleanups: > - make the following needlessly global functions statis: > - ipv4/tcp.c: __tcp_alloc_md5sig_pool() > - ipv4/tcp_ipv4.c: tcp_v4_reqsk_md5_lookup() > - ipv4/udpl

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-30 Thread Greg KH
On Fri, Dec 01, 2006 at 02:08:28AM +0100, Rafael J. Wysocki wrote: > On Thursday, 30 November 2006 22:32, Rafael J. Wysocki wrote: > > [Trimmed the Cc list a bit.] > > > > On Thursday, 30 November 2006 22:12, Andrew Morton wrote: > > > On Thu, 30 Nov 2006 21:21:27 +0100 > > > "Rafael J. Wysocki" <

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-30 Thread Greg KH
On Wed, Nov 29, 2006 at 06:18:09PM -0800, Andrew Morton wrote: > On Thu, 30 Nov 2006 02:04:15 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > > > > git-netdev-all.patch > > > > git-netdev-all-fixup.patch > > > > libphy-dont-do-that.patch > > > > > > Are you able to eliminate l

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-30 Thread Rafael J. Wysocki
On Thursday, 30 November 2006 22:32, Rafael J. Wysocki wrote: > [Trimmed the Cc list a bit.] > > On Thursday, 30 November 2006 22:12, Andrew Morton wrote: > > On Thu, 30 Nov 2006 21:21:27 +0100 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > On Thursday, 30 November 2006 02:04, Rafae

Re: [PATCH][IPSEC][6/7] inter address family ipsec tunnel

2006-11-30 Thread David Miller
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 14:39:01 +0900 > This patch fixes mtu calculation of IPv4 > > ip_append_data should refer the mtu of "dst" not "path". > if "dst" is stacked, "path" is the actual dst_entry in > the routing table. > therefore the mtu of "path" equ

Re: [PATCH][IPSEC][7/7] inter address family ipsec tunnel

2006-11-30 Thread David Miller
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 14:39:17 +0900 > ip6_append_data should refer mtu of "dst" > because of the same reasone of the previous patch. Same comments of mine for ipv4 side of this change also apply here. - To unsubscribe from this list: send the line "un

[PATCH] zd1211rw: Support for multicast addresses

2006-11-30 Thread Daniel Drake
From: Ulrich Kunitz <[EMAIL PROTECTED]> Support for multicast adresses is implemented by supporting the set_multicast_list() function of the network device. Address filtering is supported by a group hash table in the device. This is based on earlier work by Benoit Papillaut. Fixes multicast packe

[PATCH] zd1211rw: Fill enc_capa in GIWRANGE handler

2006-11-30 Thread Daniel Drake
This is needed for NetworkManager users to connect to WPA networks. Pointed out by Matthew Campbell. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_mac.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) Index: linux-2.6/drivers/net/wireless/zd1211rw/zd_mac.c =

[PATCH] zd1211rw: zd_mac_rx isn't always called in IRQ context

2006-11-30 Thread Daniel Drake
e.g. usb 1-7: rx_urb_complete() *** first fragment *** usb 1-7: rx_urb_complete() *** second fragment *** drivers/net/wireless/zd1211rw/zd_mac.c:1063 ASSERT (((current_thread_info()->preempt_count) & (((1UL << (12))-1) << ((0 + 8) + 8 VIOLATED! [] zd_mac_rx+0x3e7/0x47a [zd1211rw] [] rx_urb_c

Re: [PATCH][IPSEC][5/7] inter address family ipsec tunnel

2006-11-30 Thread David Miller
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 14:38:52 +0900 > +static inline void ip6ip_ecn_decapsulate(struct sk_buff *skb) > +{ > + if (INET_ECN_is_ce(ipv6_get_dsfield(skb->nh.ipv6h))) > + IP_ECN_set_ce(skb->h.ipiph); > +} > + Please fix this extra

Re: [PATCH][IPSEC][4/7] inter address family ipsec tunnel

2006-11-30 Thread David Miller
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 14:38:39 +0900 What is going on here? > + /* Without this, the atomic inc below segfaults */ > + if (encap_family == AF_INET6) { > + rt->peer = NULL; > +

Re: [PATCH][IPSEC][3/7] inter address family ipsec tunnel

2006-11-30 Thread David Miller
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 10:54:26 +0900 > Hello, > > I found a bug in my previous patch for af_key. > The patch breaks transport mode. > This is a fixed version. > > Signed-off-by: Miika Komu <[EMAIL PROTECTED]> > Signed-off-by: Diego Beltrami <[EMAIL PR

Re: [PATCH][IPSEC][2/7] inter address family ipsec tunnel

2006-11-30 Thread David Miller
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 14:38:17 +0900 > This patch adds netlink interface of the family > > Signed-off-by: Miika Komu <[EMAIL PROTECTED]> > Signed-off-by: Diego Beltrami <[EMAIL PROTECTED]> > Signed-off-by: Kazunori Miyazawa <[EMAIL PROTECTED]> Applied

Re: [PATCH][IPSEC][1/7] inter address family ipsec tunnel

2006-11-30 Thread David Miller
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Fri, 24 Nov 2006 14:38:07 +0900 > This patch adds encapsulation family. > > Signed-off-by: Miika Komu <[EMAIL PROTECTED]> > Signed-off-by: Diego Beltrami <[EMAIL PROTECTED]> > Signed-off-by: Kazunori Miyazawa <[EMAIL PROTECTED]> Applied to net-2.

Re: [PATCH 0/5 addendum] NetXen

2006-11-30 Thread Don Fry
On Thu, Nov 30, 2006 at 07:15:50PM -0500, Jeff Garzik wrote: > Don Fry wrote: > >The NetXen patches fix many problems in the current #upstream version of > >the driver. It has warts and probably lots of bugs still, but it is > >better than what is queued for mainline inclusion at this time. Pleas

Re: [PATCH 0/5 addendum] NetXen

2006-11-30 Thread Jeff Garzik
Don Fry wrote: The NetXen patches fix many problems in the current #upstream version of the driver. It has warts and probably lots of bugs still, but it is better than what is queued for mainline inclusion at this time. Please apply to 2.6.20. Please resync with netdev#upstream, and update fo

Re: [PATCH 1/1] additional ipsec audit patch

2006-11-30 Thread James Morris
On Thu, 30 Nov 2006, Joy Latten wrote: > I ran a stress test overnight using labeled ipsec on a patched lspp55 kernel > using racoon last week. > > The additional patch to xfrm_state.c was my fault when rebasing to > 2.6.19-rc6 to send upstream. I plan to run an ipv4 and ipv6 stress test > tonig

Re: [PATCH 2/5] NetXen: temp monitoring, newer firmware support, mm footprint reduction

2006-11-30 Thread Francois Romieu
Don Fry <[EMAIL PROTECTED]> : > NetXen: 1G/10G Ethernet Driver updates > - Temparature monitoring and device control > - Memory footprint reduction > - Driver changes to support newer version of firmware > > Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> > Signed-off-by: Don Fry

Re: [PATCH 1/1] additional ipsec audit patch

2006-11-30 Thread Joy Latten
On Wed, 2006-11-29 at 19:32 -0500, James Morris wrote: > On Wed, 29 Nov 2006, James Morris wrote: > > > On Wed, 29 Nov 2006, Joy Latten wrote: > > > > > This patch disables auditing in ipsec when CONFIG_AUDITSYSCALL is > > > disabled in the kernel. > > > > > > This patch also includes a bug fix

[PATCH 1/1] additional change to ipsec audit

2006-11-30 Thread Joy Latten
Sorry! Sign off included this time. This patch disables auditing in ipsec when CONFIG_AUDITSYSCALL is disabled in the kernel. This patch also includes a bug fix for xfrm_state.c as a result of original ipsec audit patch. regards, Joy Signed-off-by: Joy Latten [EMAIL PROTECTED] --

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-30 Thread Rafael J. Wysocki
[Trimmed the Cc list a bit.] On Thursday, 30 November 2006 22:12, Andrew Morton wrote: > On Thu, 30 Nov 2006 21:21:27 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Thursday, 30 November 2006 02:04, Rafael J. Wysocki wrote: > > > On Thursday, 30 November 2006 00:26, Andrew Morton

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-30 Thread Andrew Morton
On Thu, 30 Nov 2006 21:21:27 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Thursday, 30 November 2006 02:04, Rafael J. Wysocki wrote: > > On Thursday, 30 November 2006 00:26, Andrew Morton wrote: > > > On Thu, 30 Nov 2006 00:08:21 +0100 > > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wro

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 21:49:08 +0100 > So i dont support the scheme proposed here, the blatant bending of the > priority scale towards the TCP workload. I don't support this scheme either ;-) That's why my proposal is to find a way to allow input packet pr

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > [...] Instead what i'd like to see is more TCP performance (and a > nicer over-the-wire behavior - no retransmits for example) /with the > same 10% CPU time used/. Are we in rough agreement? put in another way: i'd like to see the "TCP bytes transferr

RE: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Wenji Wu
>if you still have the test-setup, could you nevertheless try setting the >priority of the receiving TCP task to nice -20 and see what kind of >performance you get? A process with nice of -20 can easily get the interactivity status. When it expires, it still go back to the active array. It just h

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > > disk I/O is typically not CPU bound, and i believe these TCP tests > > /are/ CPU-bound. Otherwise there would be no expiry of the timeslice > > to begin with and the TCP receiver task would always be boosted to > > 'interactive' status by the sched

RE: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Wenji Wu
> It steals timeslices from other processes to complete tcp_recvmsg() > task, and only when it does it for too long, it will be preempted. > Processing backlog queue on behalf of need_resched() will break > fairness too - processing itself can take a lot of time, so process > can be scheduled away

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > I want to point out something which is slightly misleading about this > kind of analysis. > > Your disk I/O speed doesn't go down by a factor of 10 just because 9 > other non disk I/O tasks are running, yet for TCP that's seemingly OK > :-) disk I/O

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 21:30:26 +0100 > disk I/O is typically not CPU bound, and i believe these TCP tests /are/ > CPU-bound. Otherwise there would be no expiry of the timeslice to begin > with and the TCP receiver task would always be boosted to 'interactiv

Re: Linux 2.6.19

2006-11-30 Thread Malte Schröder
On Thursday 30 November 2006 03:15, David Miller wrote: > From: Phil Oester <[EMAIL PROTECTED]> > Date: Wed, 29 Nov 2006 17:49:04 -0800 > > > Getting an oops on boot here, caused by commit > > e81c73596704793e73e6dbb478f41686f15a4b34 titled > > "[NET]: Fix MAX_HEADER setting". > > > > Reverting tha

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Christoph Lameter
On Thu, 30 Nov 2006, Peter Zijlstra wrote: > > > Sure, but there is nothing wrong with using a slab page with a lower > > > allocation rank when there is memory aplenty. > > What does "a slab page with a lower allocation rank" mean? Slab pages have > > no allocation ranks that I am aware of. > I

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Peter Zijlstra
On Thu, 2006-11-30 at 12:11 -0800, Christoph Lameter wrote: > On Thu, 30 Nov 2006, Peter Zijlstra wrote: > > > Sure, but there is nothing wrong with using a slab page with a lower > > allocation rank when there is memory aplenty. > > What does "a slab page with a lower allocation rank" mean? Sla

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Ingo Molnar
* Wenji Wu <[EMAIL PROTECTED]> wrote: > >The solution is really simple and needs no kernel change at all: if > >you want the TCP receiver to get a larger share of timeslices then > >either renice it to -20 or renice the other tasks to +19. > > Simply give a larger share of timeslices to the TC

Re: 2.6.19-rc6-mm2: uli526x only works after reload

2006-11-30 Thread Rafael J. Wysocki
On Thursday, 30 November 2006 02:04, Rafael J. Wysocki wrote: > On Thursday, 30 November 2006 00:26, Andrew Morton wrote: > > On Thu, 30 Nov 2006 00:08:21 +0100 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > On Wednesday, 29 November 2006 22:31, Rafael J. Wysocki wrote: > > > > On We

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 11:32:40 +0100 > Note that even without the change the TCP receiving task is already > getting a disproportionate share of cycles due to softirq processing! > Under a load of 10.0 it went from 500 mbits to 74 mbits, while the > 'fair'

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 13:22:06 +0300 > It steals timeslices from other processes to complete tcp_recvmsg() > task, and only when it does it for too long, it will be preempted. > Processing backlog queue on behalf of need_resched() will break > fairness t

Re: [PATCH] bonding: change spinlocks and remove timers in favor of workqueues

2006-11-30 Thread Andy Gospodarek
On 11/30/06, Jay Vosburgh <[EMAIL PROTECTED]> wrote: Andy Gospodarek <[EMAIL PROTECTED]> wrote: >The main purpose of this patch is to clean-up the bonding code so that >several important operations are not done in the incorrect (softirq) >context. Whenever a kernel is compiled with CONFIG_DEBUG_

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Christoph Lameter
On Thu, 30 Nov 2006, Peter Zijlstra wrote: > Sure, but there is nothing wrong with using a slab page with a lower > allocation rank when there is memory aplenty. What does "a slab page with a lower allocation rank" mean? Slab pages have no allocation ranks that I am aware of. - To unsubscribe f

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread David Miller
From: Wenji Wu <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 10:08:22 -0600 > If the higher prioirty processes become runnable (e.g., interactive > process), you better yield the CPU, instead of continuing this process. If > it is the case that the process within tcp_recvmsg() is expriring, then, you

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Peter Zijlstra
On Thu, 2006-11-30 at 11:37 -0800, Christoph Lameter wrote: > On Thu, 30 Nov 2006, Peter Zijlstra wrote: > > > On Thu, 2006-11-30 at 10:52 -0800, Christoph Lameter wrote: > > > > > I would think that one would need a rank with each cached object and > > > free slab in order to do this the right

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Peter Zijlstra
On Thu, 2006-11-30 at 11:33 -0800, Christoph Lameter wrote: > On Thu, 30 Nov 2006, Peter Zijlstra wrote: > > > No, the forced allocation is to test the allocation hardness at that > > point in time. I could not think of another way to test that than to > > actually to an allocation. > > Typically

Re: [PATCH] bonding: change spinlocks and remove timers in favor of workqueues

2006-11-30 Thread Jay Vosburgh
Andy Gospodarek <[EMAIL PROTECTED]> wrote: >The main purpose of this patch is to clean-up the bonding code so that >several important operations are not done in the incorrect (softirq) >context. Whenever a kernel is compiled with CONFIG_DEBUG_SPINLOCK_SLEEP >all sorts of backtraces are spewed to t

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Christoph Lameter
On Thu, 30 Nov 2006, Peter Zijlstra wrote: > On Thu, 2006-11-30 at 10:52 -0800, Christoph Lameter wrote: > > > I would think that one would need a rank with each cached object and > > free slab in order to do this the right way. > > Allocation hardness is a temporal attribute, ie. it changes ov

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Christoph Lameter
On Thu, 30 Nov 2006, Peter Zijlstra wrote: > No, the forced allocation is to test the allocation hardness at that > point in time. I could not think of another way to test that than to > actually to an allocation. Typically we do this by checking the number of free pages in a zone compared to th

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Peter Zijlstra
On Thu, 2006-11-30 at 10:52 -0800, Christoph Lameter wrote: > I would think that one would need a rank with each cached object and > free slab in order to do this the right way. Allocation hardness is a temporal attribute, ie. it changes over time. Hence I do it per slab. - To unsubscribe from

Re: e100 breakage located

2006-11-30 Thread Jesse Brandeburg
sorry for the delay, your mail got marked as spam. In the future please copy networking issues to netdev@vger.kernel.org, and be sure to copy the maintainers of the driver you're having problems with (they are in the MAINTAINERS file) On 11/22/06, Amin Azez <[EMAIL PROTECTED]> wrote: I notice a

[take26 3/8] kevent: poll/select() notifications.

2006-11-30 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy Po

[take26 1/8] kevent: Description.

2006-11-30 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..2e03a3f --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,240 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int flags)

[take26 0/8] kevent: Generic event handling mechanism.

2006-11-30 Thread Evgeniy Polyakov
Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but it is more scalable, it is faster and allows to work with essentially eny kind of events. Ev

[take26 8/8] kevent: Kevent posix timer notifications.

2006-11-30 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extensions to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git

[take26 4/8] kevent: Socket notifications.

2006-11-30 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Using trivial web server based on kevent and this features instead of epoll it's performance increased more than noticebly. More details about various benchmarks and server itself (evserver_kevent.c) can be found on

[take26 5/8] kevent: Timer notifications.

2006-11-30 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of nanosec

[take26 6/8] kevent: Pipe notifications.

2006-11-30 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index f3b6f71..aeaee9c 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include @@ -312,6 +313,7 @@ redo: break; } if

[take26 7/8] kevent: Signal notifications.

2006-11-30 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are use

Re: [RFC][PATCH 5/6] slab: kmem_cache_objs_to_pages()

2006-11-30 Thread Peter Zijlstra
On Thu, 2006-11-30 at 11:06 -0800, Christoph Lameter wrote: > On Thu, 30 Nov 2006, Peter Zijlstra wrote: > > > Right, perhaps my bad in wording the intent; the needed information is > > how many more pages would I need to grow the slab with in order to store > > so many new object. > > Would you

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Peter Zijlstra
On Thu, 2006-11-30 at 10:52 -0800, Christoph Lameter wrote: > On Thu, 30 Nov 2006, Peter Zijlstra wrote: > > > The slab has some unfairness wrt gfp flags; when the slab is grown the gfp > > flags are used to allocate more memory, however when there is slab space > > available, gfp flags are igno

Re: [RFC][PATCH 5/6] slab: kmem_cache_objs_to_pages()

2006-11-30 Thread Christoph Lameter
On Thu, 30 Nov 2006, Peter Zijlstra wrote: > Right, perhaps my bad in wording the intent; the needed information is > how many more pages would I need to grow the slab with in order to store > so many new object. Would you not have to take objects currently available in caches into account? If y

Re: [RFC][PATCH 5/6] slab: kmem_cache_objs_to_pages()

2006-11-30 Thread Peter Zijlstra
On Thu, 2006-11-30 at 10:55 -0800, Christoph Lameter wrote: > On Thu, 30 Nov 2006, Peter Zijlstra wrote: > > > +unsigned int kmem_cache_objs_to_pages(struct kmem_cache *cachep, int nr) > > +{ > > + return ((nr + cachep->num - 1) / cachep->num) << cachep->gfporder; > > cachep->num refers to the

Re: [PATCH] r8169: Fix iteration variable sign

2006-11-30 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : [...] > should this go into #upstream rather than #upstream-fixes? It's already in. The attribution does not follow the ordering of the Signed-off-by but the S-o-b are fine. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [RFC][PATCH 5/6] slab: kmem_cache_objs_to_pages()

2006-11-30 Thread Christoph Lameter
On Thu, 30 Nov 2006, Peter Zijlstra wrote: > +unsigned int kmem_cache_objs_to_pages(struct kmem_cache *cachep, int nr) > +{ > + return ((nr + cachep->num - 1) / cachep->num) << cachep->gfporder; cachep->num refers to the number of objects in a slab of gfporder. thus return (nr + cachep->num

[PATCH 0/5 addendum] NetXen

2006-11-30 Thread Don Fry
The NetXen patches fix many problems in the current #upstream version of the driver. It has warts and probably lots of bugs still, but it is better than what is queued for mainline inclusion at this time. Please apply to 2.6.20. -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send

Re: [RFC][PATCH 1/6] mm: slab allocation fairness

2006-11-30 Thread Christoph Lameter
On Thu, 30 Nov 2006, Peter Zijlstra wrote: > The slab has some unfairness wrt gfp flags; when the slab is grown the gfp > flags are used to allocate more memory, however when there is slab space > available, gfp flags are ignored. Thus it is possible for less critical > slab allocations to succ

[PATCH 5/5] NetXen: Fix cast error

2006-11-30 Thread Don Fry
Fix for pointer casting error. Signed-off-by: Don Fry <[EMAIL PROTECTED]> diff -Nupr netdev-2.6/drivers/net/netxen.four/netxen_nic_hw.c netdev-2.6/drivers/net/netxen/netxen_nic_hw.c --- netdev-2.6/drivers/net/netxen.four/netxen_nic_hw.c 2006-11-30 10:06:24.0 -0800 +++ netdev-2.6/drive

[PATCH 3/5] NetXen: 64-bit memory fixes and driver cleanup

2006-11-30 Thread Don Fry
NetXen: 1G/10G Ethernet Driver updates - These fixes take care of driver on machines with >4G memory - Driver cleanup Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> diff -Nupr netdev-2.6/drivers/net/netxen.two/netxen_nic_ethtool.c netde

[PATCH 1/5] NetXen: Fixed /sys mapping between device and driver

2006-11-30 Thread Don Fry
Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> diff -Nupr netdev-2.6/drivers/net/netxen.orig/netxen_nic_main.c netdev-2.6/drivers/net/netxen/netxen_nic_main.c --- netdev-2.6/drivers/net/netxen.orig/netxen_nic_main.c2006-11-29 12:13:58.0 -0800 +++ netdev-2.6/drivers/net/netxen/n

[PATCH 0/5] NetXen: 1G/10G Ethernet Driver updates

2006-11-30 Thread Don Fry
The first patch sent by Amit on 29 Nov applied, but the following three patches did not apply to Jeff's #upstream tree. Here are the corrected 2nd, 3rd, and 4th patches, with a repeat of the 1st for completeness. There is a 5th patch which fixes a bug caused by casting a 16-bit variable into a 32-

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

2006-11-30 Thread Maciej W. Rozycki
On Mon, 23 Oct 2006, Maciej W. Rozycki wrote: > > I'm not too enthusiastic about requiring the ethernet drivers to call > > phy_disconnect in a separate thread after "close" is called. Assuming > > there's > > not some sort of "squash work queue" function that can be invoked with > > rtnl_lock h

Re: pktgen

2006-11-30 Thread Ben Greear
Robert Olsson wrote: Hello! Seems you found a race when rmmod is done before it's fully started Try: diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 733d86d..ac0b4b1 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -160,7 +160,7 @@ #include/* do_div */ #include

Re: [Devel] Re: Network virtualization/isolation

2006-11-30 Thread Herbert Poetzl
On Thu, Nov 30, 2006 at 05:38:16PM +0100, Daniel Lezcano wrote: > Vlad Yasevich wrote: > > Daniel Lezcano wrote: > >> Brian Haley wrote: > >>> Eric W. Biederman wrote: > I think for cases across network socket namespaces it should > be a matter for the rules, to decide if the connection s

RE: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Wenji Wu
>The solution is really simple and needs no kernel change at all: if you >want the TCP receiver to get a larger share of timeslices then either >renice it to -20 or renice the other tasks to +19. Simply give a larger share of timeslices to the TCP receiver won't solve the problem. No matter what

Re: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Lee Revell
On Thu, 2006-11-30 at 09:33 +, Christoph Hellwig wrote: > On Wed, Nov 29, 2006 at 07:56:58PM -0600, Wenji Wu wrote: > > Yes, when CONFIG_PREEMPT is disabled, the "problem" won't happen. That is > > why I put "for 2.6 desktop, low-latency desktop" in the uploaded paper. > > This "problem" happ

Re: [Devel] Re: Network virtualization/isolation

2006-11-30 Thread Daniel Lezcano
Vlad Yasevich wrote: Daniel Lezcano wrote: Brian Haley wrote: Eric W. Biederman wrote: I think for cases across network socket namespaces it should be a matter for the rules, to decide if the connection should happen and what error code to return if the connection does not happen. There is a

[PATCH] skge: restore device multicast membership after link down/up

2006-11-30 Thread Andy Gospodarek
Yukon hardware will lose multicast membership data and promiscuous mode information if a link is disconnected and reconnected without taking the interface down. A call to yukon_reset in yukon_link_down will clear the hardware's multicast list, so it needs to be added back on link_up. It does no

Re: [Devel] Re: Network virtualization/isolation

2006-11-30 Thread Vlad Yasevich
Daniel Lezcano wrote: > Brian Haley wrote: >> Eric W. Biederman wrote: >>> I think for cases across network socket namespaces it should >>> be a matter for the rules, to decide if the connection should >>> happen and what error code to return if the connection does not >>> happen. >>> >>> There is

[PATCH] bonding: change spinlocks and remove timers in favor of workqueues

2006-11-30 Thread Andy Gospodarek
The main purpose of this patch is to clean-up the bonding code so that several important operations are not done in the incorrect (softirq) context. Whenever a kernel is compiled with CONFIG_DEBUG_SPINLOCK_SLEEP all sorts of backtraces are spewed to the log since might_sleep will kindly remind us

RE: [patch 1/4] - Potential performance bottleneck for Linxu TCP

2006-11-30 Thread Wenji Wu
>We can make explicitl preemption checks in the main loop of >tcp_recvmsg(), and release the socket and run the backlog if >need_resched() is TRUE. >This is the simplest and most elegant solution to this problem. I am not sure whether this approach will work. How can you make the explicit pree

Re: [PATCH] r8169: Fix iteration variable sign

2006-11-30 Thread Michael Buesch
On Thursday 30 November 2006 12:20, Jeff Garzik wrote: > Francois Romieu wrote: > > This changes the type of variable "i" in rtl8169_init_one() > > from "unsigned int" to "int". "i" is checked for < 0 later, > > which can never happen for "unsigned". This results in broken > > error handling. > >

Re: [PKT_SCHED] act_gact: division by zero

2006-11-30 Thread Patrick McHardy
Nordlund Kim (Nokia-NET/Helsinki) wrote: > On Thu, 30 Nov 2006, ext Patrick McHardy wrote: > >>I think it should reject an invalid configuration or handle >>the zero case correctly by not dividing. > > > You are correct. Not returning -EINVAL, because someone might > want to use the value zero i

Re: [PKT_SCHED] act_gact: division by zero

2006-11-30 Thread Nordlund Kim (Nokia-NET/Helsinki)
On Thu, 30 Nov 2006, ext Patrick McHardy wrote: > I think it should reject an invalid configuration or handle > the zero case correctly by not dividing. You are correct. Not returning -EINVAL, because someone might want to use the value zero in some future gact_prob algorithm? Signed-off-by: Kim

[PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel

2006-11-30 Thread Maciej W. Rozycki
The onboard LANCE of I/O ASIC systems is not a TURBOchannel device, at least from the software point of view. Therefore it does not rely on any kernel TURBOchannel bus services and can be supported even if support for TURBOchannel has not been enabled in the configuration. Signed-off-by: Maci

Re: [PKT_SCHED] act_gact: division by zero

2006-11-30 Thread Patrick McHardy
Nordlund Kim (Nokia-NET/Helsinki) wrote: > tc qdisc add dev eth1 handle : ingress > tc filter add dev eth1 protocol ip parent : pref 99 basic \ >flowid 1:1 action pass random determ drop 0 > ^ > the above cause a division by zero in the kerne

Re: [PATCH][NET_SCHED] sch_htb: turn intermediate classes into leaves

2006-11-30 Thread Jarek Poplawski
On Thu, Nov 30, 2006 at 01:26:34PM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: > > [NET_SCHED] sch_htb: > > > > [PATCH 2.6.19-rc6 with "Fix endless loops" set of patches] > > > > - turn intermediate classes into leaves again when their > > last child is deleted (struct htb_class chan

Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2006-11-30 Thread Patrick McHardy
First, sorry for letting you wait so long .. Russell Stuart wrote: > On Tue, 2006-10-24 at 18:19 +0200, Patrick McHardy wrote: > >>No, my patch works for qdiscs with and without RTABs, this >>is where they overlap. > > > Could you explain how this works? I didn't see how > qdiscs that used RTA

[PATCH 2.6.18] declance: Fix RX ownership handover

2006-11-30 Thread Maciej W. Rozycki
The change for PMAD support introduced a bug, where the ownership of RX descriptors was given back to the LANCE in the wrong way. Occasional lockups would happen as a result. This is a fix for this problem. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Tested with the onboard LANC

Re: [PATCH][NET_SCHED] sch_htb: turn intermediate classes into leaves

2006-11-30 Thread Patrick McHardy
Jarek Poplawski wrote: > On Thu, Nov 30, 2006 at 01:26:34PM +0100, Patrick McHardy wrote: > >>Jarek Poplawski wrote: >> >>>[NET_SCHED] sch_htb: >>> >>>[PATCH 2.6.19-rc6 with "Fix endless loops" set of patches] >>> >>>- turn intermediate classes into leaves again when their >>> last child is delet

Re: [PATCH][NET_SCHED] sch_htb: turn intermediate classes into leaves

2006-11-30 Thread Patrick McHardy
Jarek Poplawski wrote: > [NET_SCHED] sch_htb: > > [PATCH 2.6.19-rc6 with "Fix endless loops" set of patches] > > - turn intermediate classes into leaves again when their > last child is deleted (struct htb_class changed) Looks good to me too, but it still seems to be missing class level adjust

  1   2   >