netdev@vger.kernel.org

2006-11-27 Thread Auke Kok
Willy Tarreau wrote: Hi Auke, On Mon, Nov 27, 2006 at 09:31:34AM -0800, Auke Kok wrote: Willy Tarreau wrote: Hi guys, I'm about to apply this fix to 2.4. 2.6 is not affected. Do you have any objection ? Willy, you didn't CC netdev. linux-net is a users list, you didn't CC the maintainers o

[PATCH] [IPVS] use msleep_interruptable() instead of ssleep() aka msleep()

2006-11-27 Thread Horms
Dean Manners notices that when an IPVS synchonisation daemons are started the system load slowly climbs up to 1. This seems to be related to the call to ssleep(1) (aka msleep(1000) in the main loop. Replacing this with a call to msleep_interruptable() seems to make the problem go away. Though I'm n

[PATCH][NET_SCHED] sch_htb: turn intermediate classes into leaves

2006-11-27 Thread Jarek Poplawski
[NET_SCHED] sch_htb: [PATCH 2.6.19-rc6 with "Fix endless loops" set of patches] - turn intermediate classes into leaves again when their last child is deleted (struct htb_class changed) Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> --- diff -Nurp linux-2.6.19-rc6-endless-/net/sched/sch_

[PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc.

2006-11-27 Thread Jarek Poplawski
[NET_SCHED] sch_cbq: [PATCH 2.6.19-rc6 with "Fix endless loops" set of patches] - P. McHardy's "Fix endless loops" patch supplement (cbq_graft, cbq_qlen_notify, cbq_delete, cbq_class_ops) - deactivating of active classes when q.qlen drops to zero (cbq_drop) - a redundant instruction removed

Re: [PATCH 1/1] [INET]: Change protocol field in struct inet_protosw to u16

2006-11-27 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Tue, 28 Nov 2006 03:14:11 -0200 > Hi David, > > Last one tonight, please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git Pulled, thanks a lot! - To unsubscribe from this list: send the line

[PATCH 1/1] [INET]: Change protocol field in struct inet_protosw to u16

2006-11-27 Thread Arnaldo Carvalho de Melo
Hi David, Last one tonight, please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git - Arnaldo [EMAIL PROTECTED] net-2.6.20]$ pahole /tmp/tcp_ipv6.o inet_protosw /* /pub/scm/linux/kernel/git/acme/net-2.6.20/include/net/protocol.h:69 */ struct inet_pr

Re: [PATCH 1/1] add auditing to ipsec

2006-11-27 Thread James Morris
On Mon, 27 Nov 2006, Joy Latten wrote: > This patch adds auditing to ipsec in > support of labeled ipsec. > An audit message occurs when an ipsec SA > or ipsec policy is created/deleted. > > Patch was built against linux kernel 2.6.19-rc6. > Please let me know if this is acceptable. Looks ok

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread Arnaldo Carvalho de Melo
On 11/28/06, Andrew Morton <[EMAIL PROTECTED]> wrote: On Mon, 27 Nov 2006 11:21:25 + David Howells <[EMAIL PROTECTED]> wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > files with the actual functions. > > You ca

Re: [PATCHES 0/2][TCP]: pack tcp_sock

2006-11-27 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Tue, 28 Nov 2006 01:15:46 -0200 > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git Looks great, pulled and pushed out, thanks Arnaldo. - To unsubscribe from this list: send the line "u

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread Andrew Morton
On Mon, 27 Nov 2006 11:21:25 + David Howells <[EMAIL PROTECTED]> wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > files with the actual functions. > > You can if you like. Can you slap a blank line before each

Re: [PATCH 0/7][IP] IProute2 ip command updates

2006-11-27 Thread Masahide NAKAMURA
Stephen Hemminger wrote: Plan is to put out new iproute2 release after 2.6.19 final OK. As you know, netlink related interface is changed at 2.6.19. I have another patches for iproute2 (libnetlink fix and Mobile IPv6 support). Those are depends on 2.6.19 headers. So this time I'd like to know

[PATCH 2/2] [TCP]: Renove the __ prefix on the struct tcp_sock members

2006-11-27 Thread Arnaldo Carvalho de Melo
As this struct is not userland visible at all. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> --- include/linux/tcp.h | 156 ++- 1 files changed, 78 insertions(+), 78 deletions(-) diff --git a/include/linux/tcp.h b/include/linux/tcp.h

[PATCH 1/2] [TCP]: Change tcp_header_len member in tcp_sock to u16

2006-11-27 Thread Arnaldo Carvalho de Melo
With this we eliminate the last hole in struct tcp_sock. End result: [EMAIL PROTECTED] net-2.6.20]$ codiff -sV /tmp/tcp.o.before net/ipv4/tcp.o /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp.c: struct tcp_sock | -4 tcp_header_len; from: int /* 1000(0) 4

[PATCHES 0/2][TCP]: pack tcp_sock

2006-11-27 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git Regards, - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: [PATCH 1/2] chelsio: T200 support

2006-11-27 Thread Andrew Morton
On Tue, 28 Nov 2006 00:17:38 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> : > > This patch is experimental, it applies after the earlier 6 chelsio cleanup > > patches. Tested on a pair of T210 board's. > > The whole serie is stored as branch 'chelsio' a

[2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread Adrian Bunk
On Mon, Nov 27, 2006 at 11:21:25AM +, David Howells wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > files with the actual functions. > > You can if you like. Can you slap a blank line before each EXPORT_SYMBOL

netdev@vger.kernel.org

2006-11-27 Thread Willy Tarreau
Hi Auke, On Mon, Nov 27, 2006 at 09:31:34AM -0800, Auke Kok wrote: > Willy Tarreau wrote: > >Hi guys, > > > >I'm about to apply this fix to 2.4. 2.6 is not affected. > >Do you have any objection ? > > Willy, > > you didn't CC netdev. linux-net is a users list, you didn't CC the > maintainers of

Re: [PATCH 1/1] add auditing to ipsec

2006-11-27 Thread Steve Grubb
On Monday 27 November 2006 17:26, Joy Latten wrote: > This patch adds auditing to ipsec in > support of labeled ipsec. The audit changes in this patch look good to me. -Steve Grubb - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mo

Re: [PATCH 1/2] chelsio: T200 support

2006-11-27 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : > This patch is experimental, it applies after the earlier 6 chelsio cleanup > patches. Tested on a pair of T210 board's. The whole serie is stored as branch 'chelsio' at: git://electric-eye.fr.zoreil.com/home/romieu/linux/linux-2.6-out/.git chelsio I have

[PATCH 1/1] add auditing to ipsec

2006-11-27 Thread Joy Latten
This patch adds auditing to ipsec in support of labeled ipsec. An audit message occurs when an ipsec SA or ipsec policy is created/deleted. Patch was built against linux kernel 2.6.19-rc6. Please let me know if this is acceptable. Regards, Joy -

Re: [PATCH] potential NULL pointer deref in net/key/af_key.c

2006-11-27 Thread Jesper Juhl
On 27/11/06, David Miller <[EMAIL PROTECTED]> wrote: From: Jesper Juhl <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 22:44:07 +0100 > In net/key/af_key.c::pfkey_send_policy_notify() there's a check at the > beginning of the function : > > if (xp && xp->type != XFRM_POLICY_TYPE_MAIN) > > this im

Re: [PATCH] potential NULL pointer deref in net/key/af_key.c

2006-11-27 Thread David Miller
From: Jesper Juhl <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 22:44:07 +0100 > In net/key/af_key.c::pfkey_send_policy_notify() there's a check at the > beginning of the function : > > if (xp && xp->type != XFRM_POLICY_TYPE_MAIN) > > this implies that 'xp' may be null when the function is ca

Re: [PATCH 0/3][NET] Pack some structs

2006-11-27 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 18:03:24 -0200 > Hi David, > > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git > > Already rebased from your net-2.6.20 tree. Looks great, pulled and push bac

[PATCH take2] softmac: remove netif_tx_disable when scanning

2006-11-27 Thread Larry Finger
From: Michael Buesch <[EMAIL PROTECTED]> In the scan section of ieee80211softmac, network transmits are disabled. When SoftMAC re-enables transmits, it may override the wishes of a driver that may have very good reasons for disabling transmits. At least one failure in bcm43xx can be traced to this

Re: Intel 82559 NIC corrupted EEPROM

2006-11-27 Thread Jesse Brandeburg
On 11/27/06, John <[EMAIL PROTECTED]> wrote: John wrote: >> -0009 : System RAM >> 000a-000b : Video RAM area >> 000f-000f : System ROM >> 0010-0ffe : System RAM >> 0010-00296a1a : Kernel code >> 00296a1b-0031bbe7 : Kernel data >> 0fff-0fff2fff : AC

[PATCH 1/3] [INET_CONNECTION_SOCK]: Pack struct inet_connection_sock_af_ops

2006-11-27 Thread Arnaldo Carvalho de Melo
We have a hole in: [EMAIL PROTECTED] net-2.6.20]$ pahole net/ipv6/tcp_ipv6.o inet_connection_sock_af_ops /* /pub/scm/linux/kernel/git/acme/net-2.6.20/include/net/inet_connection_sock.h:38 */ struct inet_connection_sock_af_ops { int(*queue_xmit)(); /* 0

[PATCH 2/3] [NET]: Pack struct hh_cache

2006-11-27 Thread Arnaldo Carvalho de Melo
[EMAIL PROTECTED] net-2.6.20]$ pahole net/ipv4/tcp.o hh_cache /* /pub/scm/linux/kernel/git/acme/net-2.6.20/include/linux/netdevice.h:190 */ struct hh_cache { struct hh_cache * hh_next; /* 0 4 */ atomic_t hh_refcnt;/* 4

[PATCH 0/3][NET] Pack some structs

2006-11-27 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git Already rebased from your net-2.6.20 tree. Regards, - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED

[PATCH 3/3] [XFRM]: Pack struct xfrm_policy

2006-11-27 Thread Arnaldo Carvalho de Melo
[EMAIL PROTECTED] net-2.6.20]$ pahole net/ipv4/tcp.o xfrm_policy /* /pub/scm/linux/kernel/git/acme/net-2.6.20/include/linux/security.h:67 */ struct xfrm_policy { struct xfrm_policy * next; /* 0 4 */ struct hlist_node bydst;/*

Re: [take25 1/6] kevent: Description.

2006-11-27 Thread Ulrich Drepper
Evgeniy Polyakov wrote: It _IS_ how previous interface worked. EXACTLY! No, the old interface committed everything not only up to a given index. This is the huge difference which makes or breaks it. -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ - To unsu

Re: [take25 1/6] kevent: Description.

2006-11-27 Thread Ulrich Drepper
Evgeniy Polyakov wrote: That index is provided by kernel for userspace so that userspace could determine where indexes are - of course userspace can maintain it itself, but it can also use provided by kernel. Indeed. That's what I said. But I also pointed out that the field is only useful i

Re: [take25 1/6] kevent: Description.

2006-11-27 Thread Ulrich Drepper
Evgeniy Polyakov wrote: If kernel has put data asynchronously it will setup special flag, thus kevent_wait() will not sleep and will return, so thread will check new entries and process them. This is not sufficient. The userlevel code does not commit the events until they are processed. So

Re: e100: inappropriate handling of shared interrupt ?

2006-11-27 Thread Auke Kok
Shaw Vrana wrote: Hello All, I'm seeing some odd behavior using the e100 driver for an intel ethernet controller 82557/8/9 (revv 10). It appears as if the e100 driver is handling interrupts generated by another device, though I am not certain of this.. Using some printks, I see some odd packet

Re: [take24 0/6] kevent: Generic event handling mechanism.

2006-11-27 Thread Ulrich Drepper
Evgeniy Polyakov wrote: It just sets hrtimer with abs time and sleeps - it can achieve the same goals using similar to wait_event() mechanism. I don't follow. Of course it is somehow possible to wait until an absolute deadline. But it's not part of the parameter list and hence easily and _q

e100: inappropriate handling of shared interrupt ?

2006-11-27 Thread Shaw Vrana
Hello All, I'm seeing some odd behavior using the e100 driver for an intel ethernet controller 82557/8/9 (revv 10). It appears as if the e100 driver is handling interrupts generated by another device, though I am not certain of this.. Using some printks, I see some odd packets received that are

Re: Kevent POSIX timers support.

2006-11-27 Thread David Miller
From: Ulrich Drepper <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 10:36:06 -0800 > David Miller wrote: > > Now we'll have to have a compat layer for 32-bit/64-bit environments > > thanks to POSIX timers, which is rediculious. > > We already have compat_sys_timer_create. It should be sufficient jus

Re: Kevent POSIX timers support.

2006-11-27 Thread Ulrich Drepper
David Miller wrote: Now we'll have to have a compat layer for 32-bit/64-bit environments thanks to POSIX timers, which is rediculious. We already have compat_sys_timer_create. It should be sufficient just to add the conversion (if anything new is needed) there. The pointer value can be pass

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

2006-11-27 Thread Stephen Hemminger
On Fri, 24 Nov 2006 01:17:31 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote: > >... > > Changes since 2.6.19-rc5-mm2: > >... > > +chelsio-22-driver.patch > >... > > netdev updates > > It is suspicious that the following newly added co

Re: [take24 0/6] kevent: Generic event handling mechanism.

2006-11-27 Thread Ulrich Drepper
Evgeniy Polyakov wrote: With provided patch it is possible to wakeup 'for-free' - just call kevent_ctl(ready) with zero number of ready events, so thread will be awakened if it was in poll(kevent_fd), kevent_wait() or kevent_get_events(). Yes, I realize that. But I wrote something else: >> R

[PATCH] [version 2] Remove support for old-style ethtool ioctl handlers

2006-11-27 Thread Matthew Wilcox
During the transition to the ethtool_ops way of doing things, we supported calling the device's ->do_ioctl method to allow unconverted drivers to continue working. Those days are long behind us, all in-tree drivers use the ethtool_ops way, and so we no longer need to support this. The bonding dr

Re: Kevent POSIX timers support.

2006-11-27 Thread David Miller
From: Ulrich Drepper <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 10:20:50 -0800 > Evgeniy Polyakov wrote: > >> We need to pass the data in the sigev_value meember of the struct > >> sigevent structure passed to timer_create to the caller. I don't see it > >> being done here nor when the timer is

Re: [PATCH 3/3] NetXen: 64-bit memory fixes, driver cleanup

2006-11-27 Thread Stephen Hemminger
On Thu, 23 Nov 2006 08:32:52 -0800 Sanjeev Jorapur <[EMAIL PROTECTED]> wrote: > > > > You should then set the same value for pci_set_dma_mask, because then the > > IOMMU > > can help. See both b44 or tg3 drivers, they have to deal with odd size > > masks. > > I don't think you have to do all th

Re: Kevent POSIX timers support.

2006-11-27 Thread Ulrich Drepper
Evgeniy Polyakov wrote: We need to pass the data in the sigev_value meember of the struct sigevent structure passed to timer_create to the caller. I don't see it being done here nor when the timer is created. Do I miss something? The sigev_value value should be stored in the user/ptr member o

Re: [PATCH 0/7][IP] IProute2 ip command updates

2006-11-27 Thread Stephen Hemminger
On Fri, 24 Nov 2006 12:31:23 +0900 Masahide NAKAMURA <[EMAIL PROTECTED]> wrote: > Hello, > > # First of all, I'm sorry I sent wrong email two times from > # "[EMAIL PROTECTED]" which is not a valid addresss. > # Please delete them! > > These are iproute2 updates. Please review and apply them. >

Re: [PATCH] [UDP(-Lite)]: consolidate v4 and v6 get|setsockopt code

2006-11-27 Thread Gerrit Renker
Quoting David Miller: | >   if (level == SOL_UDP  ||  level == SOL_UDPLITE) | > - return do_udpv6_setsockopt(sk, level, optname, optval, optlen); | > + return udp_lib_setsockopt(sk, level, optname, optval, optlen, | > +   udp_v6_p

Re: [NETLINK]: Remove unused dst_pid field in netlink_skb_parms

2006-11-27 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 10:02:38 +0100 > The destination PID is passed directly to netlink_unicast() > respectively netlink_multicast(). > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Nothing but assignments to that thing :-) Good catch, applied, thanks

Re: [PATCH] [UDP(-Lite)]: consolidate v4 and v6 get|setsockopt code

2006-11-27 Thread David Miller
From: Gerrit Renker <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 10:44:33 + > [UDP(-Lite)]: consolidate v4 and v6 get|setsockopt code > > This is for 2.6.20. > > This patch consolidates set/getsockopt code between UDP(-Lite) v4 and 6. The > justification is that UDP(-Lite) is a transport-laye

Re: [RTNETLINK]: Add rtnl_put_cacheinfo() to unify some code

2006-11-27 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 10:13:20 +0100 > Resend: Need to export rtnl_put_cacheinfo() for IPv6 > > IPv4, IPv6, and DECNet all use struct rta_cacheinfo in a similiar > way, therefore rtnl_put_cacheinfo() is added to reuse code. > > Signed-off-by: Thomas Graf <[

netdev@vger.kernel.org

2006-11-27 Thread Auke Kok
Willy Tarreau wrote: Hi guys, I'm about to apply this fix to 2.4. 2.6 is not affected. Do you have any objection ? Willy, you didn't CC netdev. linux-net is a users list, you didn't CC the maintainers of the driver. Please do this. We're more than happy to help, even for 2.4 kernels. Patc

Re: VM deadlock avoidance

2006-11-27 Thread David Miller
From: Peter Zijlstra <[EMAIL PROTECTED]> Date: Mon, 27 Nov 2006 15:06:25 +0100 > The patches definitely need more work but would you agree with the > general direction I'm working in or would you suggest yet another > direction? You're definitely going to have to wait at least a week or so before

Re: [Cbe-oss-dev] [RFC][PATCH] spidernet: enable fiber autonegotiation

2006-11-27 Thread Arnd Bergmann
On Monday 27 November 2006 16:46, Jens Osterkamp wrote: > Thanks for pointing me to this, I must have overlooked it. Some of it seems > only applicable to the Celleb copper interface, but some of it is quite > usable for us too. > > Is it already queued upstream ? No, I'm currently waiting for

Re: [PATCH] softmac: remove netif_tx_disable when scanning

2006-11-27 Thread Michael Buesch
On Sunday 26 November 2006 17:37, Daniel Drake wrote: > Johannes Berg wrote: > > The problem is that queue disabling isn't refcounted so that a scan that > > collides with bcm43xx having disabled the queue for calibration might > > re-enable the queue while bcm43xx is still calibrating. > > I agre

Re: [Cbe-oss-dev] [RFC][PATCH] spidernet: enable fiber autonegotiation

2006-11-27 Thread Jens Osterkamp
> There was a patch from Ishizaki Kou recently, to set up autonegotiate > and other things, see http://patchwork.ozlabs.org/linuxppc/patch?id=8121 . > > Are you sure that you don't need any of those changes as well? Thanks for pointing me to this, I must have overlooked it. Some of it seems only

Re: [Cbe-oss-dev] [RFC][PATCH] spidernet: enable fiber autonegotiation

2006-11-27 Thread Arnd Bergmann
On Monday 27 November 2006 15:47, Jens Osterkamp wrote: > > While experimenting with a copper passthrough module in bladecenter I found > out that this needs autonegotiation enabled in order to work properly. > This quick hack enables it with the sideeffect of breaking other bladecenter > switch

[RFC][PATCH] spidernet: enable fiber autonegotiation

2006-11-27 Thread Jens Osterkamp
While experimenting with a copper passthrough module in bladecenter I found out that this needs autonegotiation enabled in order to work properly. This quick hack enables it with the sideeffect of breaking other bladecenter switch configurations. If anyone has any suggestions or has experimented

Re: Intel 82559 NIC corrupted EEPROM

2006-11-27 Thread John
John wrote: -0009 : System RAM 000a-000b : Video RAM area 000f-000f : System ROM 0010-0ffe : System RAM 0010-00296a1a : Kernel code 00296a1b-0031bbe7 : Kernel data 0fff-0fff2fff : ACPI Non-volatile Storage 0fff3000-0fff : ACPI Tables 2000-2

VM deadlock avoidance

2006-11-27 Thread Peter Zijlstra
Hi Dave, I have a new version of these patches; I'm still using SOCK_VMIO socket tagging and skb->emergency marks, since I have not come up with another approach that might work and my RFC to netdev has so far been ignored. Other than this though, it changed quite a bit; - I now use the regular

Re: [PATCH][NET_SCHED] sch_htb: turn intermediate classes into leaves

2006-11-27 Thread Jarek Poplawski
On Mon, Nov 27, 2006 at 11:12:23AM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: > > Here is a trial to do something suggested by Patrick McHardy. > > > > [NET_SCHED] sch_htb: > > > > - turn intermediate classes into leaves again when their last child is > > deleted > > (qdisc of del

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread David Howells
Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > files with the actual functions. You can if you like. Can you slap a blank line before each EXPORT_SYMBOL() though please? David - To unsubscribe from this list: send the line "un

[PATCH] [UDP(-Lite)]: consolidate v4 and v6 get|setsockopt code

2006-11-27 Thread Gerrit Renker
[UDP(-Lite)]: consolidate v4 and v6 get|setsockopt code This is for 2.6.20. This patch consolidates set/getsockopt code between UDP(-Lite) v4 and 6. The justification is that UDP(-Lite) is a transport-layer protocol and therefore the socket option code (at least in theory) should be AF-independe

Re: [PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc.

2006-11-27 Thread Patrick McHardy
Jarek Poplawski wrote: > On Mon, Nov 27, 2006 at 10:55:39AM +0100, Patrick McHardy wrote: > >>Your patch looks good, but it conflicts with my patches. > > > I know, but I wasn't sure which version this changes > are needed for. If there will be something more to do, > name the version, please.

Re: [PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc.

2006-11-27 Thread Jarek Poplawski
On Mon, Nov 27, 2006 at 10:55:39AM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: > > Here are some fixes proposals suggested by Patrick McHardy. > > > > [NET_SCHED] sch_cbq: > > > > - deactivating of active classes when grafting > > > > - purging of queue/q.qlen adjustment when deleting

Re: [PATCH][NET_SCHED] sch_htb: turn intermediate classes into leaves

2006-11-27 Thread Patrick McHardy
Jarek Poplawski wrote: > Here is a trial to do something suggested by Patrick McHardy. > > [NET_SCHED] sch_htb: > > - turn intermediate classes into leaves again when their last child is deleted > (qdisc of deleted class is reused; struct htb_class changed) > > - sch_tree_lock added in htb_

Re: [PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc.

2006-11-27 Thread Patrick McHardy
Jarek Poplawski wrote: > Here are some fixes proposals suggested by Patrick McHardy. > > [NET_SCHED] sch_cbq: > > - deactivating of active classes when grafting > > - purging of queue/q.qlen adjustment when deleting an active class > > - deactivating of active classes when q.qlen drops to zero

[RTNETLINK]: Add rtnl_put_cacheinfo() to unify some code

2006-11-27 Thread Thomas Graf
Resend: Need to export rtnl_put_cacheinfo() for IPv6 IPv4, IPv6, and DECNet all use struct rta_cacheinfo in a similiar way, therefore rtnl_put_cacheinfo() is added to reuse code. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.20/net/core/rtnetlink.c ===

[RTNETLINK]: Add rtnl_put_cacheinfo() to unify some code

2006-11-27 Thread Thomas Graf
IPv4, IPv6, and DECNet all use struct rta_cacheinfo in a similiar way, therefore rtnl_put_cacheinfo() is added to reuse code. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.20/net/core/rtnetlink.c === --- net-2.6.20.or

[NETLINK]: Remove unused dst_pid field in netlink_skb_parms

2006-11-27 Thread Thomas Graf
The destination PID is passed directly to netlink_unicast() respectively netlink_multicast(). Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.20/include/linux/netlink.h === --- net-2.6.20.orig/include/linux/netlink.h

Re: RFC: remove NET_CLS_POLICE?

2006-11-27 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2006-11-26 14:21 > One more thing NET_CLS_POLICE affects is CBQ reshape/reclassify > handling, reshape_fail seems to be completely unhandled without > NET_CLS_POLICE and reclassification looks like it behaves > differently with tc actions. I'm not really sure w