Re: [PATCH 0/3] netpoll/netconsole fixes

2006-10-19 Thread Andrew Morton
On Thu, 19 Oct 2006 10:15:41 -0700 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > The netpoll transmit skb management is a mess, it has two > paths and it's on Txq. These patches try and clean this up. > I got a reject storm when applying the third patch then screwed it up rather than fixing it

Re: revert mv643xx change from ubuntu tree

2006-10-19 Thread Olaf Hering
On Fri, Oct 20, Ben Collins wrote: > On Thu, 2006-10-19 at 14:18 +0200, Olaf Hering wrote: > > Somehow the Ubuntu guys managed to sneak this compile error into the > > tree: > > > > commit ce9e3d9953c8cb67001719b5516da2928e956be4 > > > > [mv643xx] Add pci device table for auto module loadi

Re: revert mv643xx change from ubuntu tree

2006-10-19 Thread Ben Collins
On Thu, 2006-10-19 at 14:18 +0200, Olaf Hering wrote: > Somehow the Ubuntu guys managed to sneak this compile error into the > tree: > > commit ce9e3d9953c8cb67001719b5516da2928e956be4 > > [mv643xx] Add pci device table for auto module loading. > > drivers/net/mv643xx_eth.c:1560: error: ar

Re: [PATCH 0/4][CRYPTO][IPsec] support XCBC

2006-10-19 Thread Herbert Xu
On Wed, Oct 18, 2006 at 11:25:55AM +0900, Kazunori MIYAZAWA wrote: > > I send patches to support XCBC mode of IPsec. > This patch is for linux-2.6.19-rc2. I checked to also apply > this to net-2.6. Thanks a lot for the patches Miyazawa-san. I'll put them into cryptodev-2.6 for 2.6.20. Cheers, -

Re: [RFC] Ethernet Cheap Cryptography

2006-10-19 Thread David Miller
From: [EMAIL PROTECTED] (Stephen J. Bevan) Date: Thu, 19 Oct 2006 19:18:41 -0700 > Pawel Foremski writes: > > Secondly, IPsec won't decrease MSS in TCP encapsulated in PPPoE > > traffic, for example. > > Various, commercial, IPsec products decrease the MSS for TCP > encapsulated in PPPoE. I'v

Re: [PATCH 4/6] net: use bitrev8

2006-10-19 Thread Akinobu Mita
On Thu, Oct 19, 2006 at 01:39:51PM -0700, Andrew Morton wrote: > A bunch of drivers. > > > === > > --- work-fault-inject.orig/drivers/net/Kconfig > > +++ work-fault-inject/drivers/net/Kconfig > > @@ -2500,6 +2500,7 @@ config DEFXX >

smallish review of acx1xx-wireless-driver.patch

2006-10-19 Thread Alexey Dobriyan
Main griefs: a) home-grown lock debugger (what can it do what lockdep can't?) b) lack of endian annotations. c) driver fallbacks to USA regulatory domain if it can't find valid one from the list. My gut feeling is that this can bring an unattentive Linux user to police on bad day. lesser gri

Re: [RFC] Ethernet Cheap Cryptography

2006-10-19 Thread Stephen J. Bevan
Pawel Foremski writes: > First, ccrypts task is to secure Ethernet, not IP. Understood, but the vast majority of traffic running over Ethernet that a user cares about is IP and so IPsec does the job. Obviously IPsec cannot handle non-IP traffic but the question is what non-IP traffic do users wa

Re: AF_KEY extended xfrm_state selector handling

2006-10-19 Thread jamal
On Thu, 2006-19-10 at 18:26 +0100, Michal Ruzicka wrote: > Hello > > In an effort to configure an L2TP/IPsec server on Linux capable of supporting > multiple clients behind a single NAT device I ran into difficulties with > pf_key > protocol implementation not being able to exploit all the inform

Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2006-10-19 Thread jamal
On Thu, 2006-19-10 at 16:38 +0200, Patrick McHardy wrote: > jamal wrote: > > ACKed-by: Jamal Hadi Salim > > > > When Patrick has his patch ready after this goes in we can revisit. > > NACK. > > I still think this patch shouldn't go in. There's no point in doing the > same thing twice, and I have

Re: [PATCH] bcm43xx: Drain TX status before starting IRQs

2006-10-19 Thread Benjamin Herrenschmidt
On Thu, 2006-10-19 at 17:29 +0200, Michael Buesch wrote: > Drain the Microcode TX-status-FIFO before we enable IRQs. > This is required, because the FIFO may still have entries left > from a previous run. Those would immediately fire after enabling > IRQs and would lead to an oops in the DMA TXstat

Re: Please pull 'we21-fix' branch of wireless-2.6.git

2006-10-19 Thread Jean Tourrilhes
On Thu, Oct 19, 2006 at 05:56:53PM -0400, John W. Linville wrote: > Jeff, > > Here is my ugly patch to fix userland ABI compatibility for WE-21. > It tries to detect WE <= 20 by the request length or the inclusion of > '\0' in the length for the ESSID and NICKN ioctls. If it finds that, > it temp

Please pull 'we21-fix' branch of wireless-2.6.git

2006-10-19 Thread John W. Linville
Jeff, Here is my ugly patch to fix userland ABI compatibility for WE-21. It tries to detect WE <= 20 by the request length or the inclusion of '\0' in the length for the ESSID and NICKN ioctls. If it finds that, it temporarily adjusts the length value and puts it back before reporting back to use

[PATCH] ethtool: more sky2 decode

2006-10-19 Thread Stephen Hemminger
More marvell register decode. Add chip table, pci config info and other bits useful for debug. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- marvell.c | 80 + 1 files changed, 59 insertions(+), 21 deletions(-) diff --git a/

Re: [PATCH 4/6] net: use bitrev8

2006-10-19 Thread Andrew Morton
On Thu, 19 Oct 2006 01:46:47 +0900 Akinobu Mita <[EMAIL PROTECTED]> wrote: > Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers. > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Cc: Paul Mackerras <[EMAIL PROTECTED]> > Cc: Mirko Lindner <[EMAIL PROTECTED]> > Cc: Thomas Bogendoerfer <[EMAIL

Re: [IPROUTE] manpage for ss

2006-10-19 Thread Alexander Wirt
Stephen Hemminger schrieb am Donnerstag, den 19. Oktober 2006: > Revised version now in iproute2 repository. Great, thank you very much. Alex - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [IPROUTE] manpage for ss

2006-10-19 Thread Stephen Hemminger
Revised version now in iproute2 repository. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-19 Thread Andy Gospodarek
On Tue, Oct 17, 2006 at 10:16:21AM +0200, Dawid Ciezarkiewicz wrote: > > In fact - as default weight is being set to 1, without changing it wrr > bonding > mode works like plain round-robin one. But it have little more overhead > (recharging tokens), and code is a bit more complicated. I was no

[PATCH 0/3] netpoll/netconsole fixes

2006-10-19 Thread Stephen Hemminger
The netpoll transmit skb management is a mess, it has two paths and it's on Txq. These patches try and clean this up. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.

[PATCH 2/3] netpoll: rework skb transmit queue

2006-10-19 Thread Stephen Hemminger
The original skb management for netpoll was a mess, it had two queue paths and a callback. This changes it to have a per-instance transmit queue and use a tasklet rather than a work queue for the congested case. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/netconsole.c |

[PATCH 3/3] netpoll: use skb_buff_head for skb cache

2006-10-19 Thread Stephen Hemminger
The private skb cache should be managed with normal skb_buff_head rather than a DIY queue. If pool is exhausted, don't print anything that just makes the problem worse. After a number of attempts, punt and drop the message (callers handle it already). Signed-off-by: Stephen Hemminger <[EMAIL PROTE

[PATCH 1/3] netpoll: initialize skb for UDP

2006-10-19 Thread Stephen Hemminger
Need to fully initialize skb to keep lower layers and queueing happy. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.orig/net/core/netpoll.c 2006-10-18 15:26:36.0 -0700 +++ linux-2.6/net/core/netpoll.c2006-10-19 08:28:04.0 -0700 @@ -331,13 +331,13 @@

Re: BCM5461 phy issue in 10M/Full duplex

2006-10-19 Thread Maciej W. Rozycki
On Wed, 18 Oct 2006, Rick Jones wrote: > > I believe, but need to double check, that if I leave the BCM5461 in > > autoneg, and foce the switch to 10M/full that the BCM5461 will autoneg at > > 10M/half duplex. > > Indeed, if one side is hardcoded, autoneg will "fail" and the side trying to > aut

AF_KEY extended xfrm_state selector handling

2006-10-19 Thread Michal Ruzicka
Hello In an effort to configure an L2TP/IPsec server on Linux capable of supporting multiple clients behind a single NAT device I ran into difficulties with pf_key protocol implementation not being able to exploit all the information passed to it as a SADB_EXT_ADDRESS_PROXY info. Perhaps as the or

Re: sky2 crash

2006-10-19 Thread Stephen Hemminger
On Thu, 19 Oct 2006 08:10:33 -0700 Shane <[EMAIL PROTECTED]> wrote: > Hello, > > I am experiencing an intermittent crash with a Gigabit > controler using the sky2 driver under load. Confirmed on > 2.6.19-rc2 but also present with 2.6.18. After the lockup, > the system works as normally but the

Re: [PATCH] d80211: extend extra_hdr_room to be a bytecount

2006-10-19 Thread Jiri Benc
On Wed, 11 Oct 2006 07:59:23 -0700, David Kimdon wrote: > Perhaps rename it to extra_tx_headroom? > - existing users would then need to take notice of the change > - the name 'extra_tx_headroom' is more descriptive of what it actually is Extend ieee80211_hw's extra_hdr_room to be a bytecount for

Re: [PATCH 2.6.18] AT91RM9200 Ethernet update

2006-10-19 Thread Andrew Victor
hi, > ACK, but patch doesn't apply to 2.6.18 The patch failed due to AT91_ID_EMAC being renamed to AT91RM9200_ID_EMAC. Updated patch for 2.6.19-rc2 attached. Regards, Andrew Victor - This patch contains a few updates to the AT91RM9200 Ethernet driver. The changes are: 1. Remove the gl

Re: [RFC] Ethernet Cheap Cryptography

2006-10-19 Thread Pawel Foremski
Stephen J. Bevan wrote: > Dawid Ciezarkiewicz writes: > > It enforces to use upper level encryption with internal > > fragmentation which is problem because of more more frames that > > those bridges have to handle, bigger traffic etc. > > Where did the fragmentation come from? If you are sen

Re: [PATCH] d80211: ieee80211_hw handlers should be allowed to sleep

2006-10-19 Thread Jiri Benc
On Wed, 18 Oct 2006 19:27:37 +0200, Ivo van Doorn wrote: > Would something like the patch below be better? > It keeps the flush_scheduled_work() at the same location, but a second > is added in case local->scan_work.data != sdata->dev Applied to my tree, thanks for the patch! Jiri -- Jiri Benc

[PATCH] [NET] One NET_INC_STATS() could be NET_INC_STATS_BH in tcp_v4_err()

2006-10-19 Thread Eric Dumazet
I believe this NET_INC_STATS() call can be replaced by NET_INC_STATS_BH(), a little bit cheaper. Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> --- linux/net/ipv4/tcp_ipv4.c.orig 2006-10-19 17:37:22.0 +0200 +++ linux-ed/net/ipv4/tcp_ipv4.c2006-10-19 17:37:43.0 +0200

Re: watchdog timeout panic in e1000 driver

2006-10-19 Thread Auke Kok
Kenzo Iwami wrote: A watchdog timeout panic occurred in e1000 driver (7.2.9-NAPI). where's the panic message ? Please CC the maintainers of the driver at all times. Our e-mail addresses are widely visible everywhere. If e1000_watchdog is called when processing ioctl from ethtool, the syste

[PATCH] bcm43xx: Drain TX status before starting IRQs

2006-10-19 Thread Michael Buesch
Drain the Microcode TX-status-FIFO before we enable IRQs. This is required, because the FIFO may still have entries left from a previous run. Those would immediately fire after enabling IRQs and would lead to an oops in the DMA TXstatus handling code. Signed-off-by: Michael Buesch <[EMAIL PROTECTE

Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2006-10-19 Thread Patrick McHardy
jamal wrote: > ACKed-by: Jamal Hadi Salim > > When Patrick has his patch ready after this goes in we can revisit. NACK. I still think this patch shouldn't go in. There's no point in doing the same thing twice, and I haven't heard a compelling argument why it has to be done in a way that only hel

revert mv643xx change from ubuntu tree

2006-10-19 Thread Olaf Hering
Somehow the Ubuntu guys managed to sneak this compile error into the tree: commit ce9e3d9953c8cb67001719b5516da2928e956be4 [mv643xx] Add pci device table for auto module loading. drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type drivers/net/mv643xx_eth.c:1561:

[PATCH] [NET] inet_peer : group together avl_left, avl_right, v4daddr to speedup lookups on some CPUS

2006-10-19 Thread Eric Dumazet
Hi David Lot of routers/embedded devices still use CPUS with 16/32 bytes cache lines. (486, Pentium, ... PIII) It makes sense to group together fields used at lookup time so they fit in one cache line. This reduce cache footprint and speedup lookups. Signed-off-by: Eric Dumazet <[EMAIL PROTECT

Re: (usagi-core 31424) Re: [PATCH 7/13] [RFC] [IPV6] Move source address selection into route lookup.

2006-10-19 Thread Mitsuru Chinen
Hello Ville, Ville Nuorvala wrote: Mitsuru-san, could you apply patch #12 and rerun the test? I think this particular problem is caused by the routing cache entry not having a valid source address in the first place. As ip6_dst_lookup() doesn't do the source address lookup anymore, it is critic

watchdog timeout panic in e1000 driver

2006-10-19 Thread Kenzo Iwami
Hi, A watchdog timeout panic occurred in e1000 driver (7.2.9-NAPI). If e1000_watchdog is called when processing ioctl from ethtool, the system could stop inside e1000_watchdog interrupt handler for about 16 seconds, and the system panicked as a result of a watchdog timeout. This problem only occu

[PATCH] [NET] Size listen hash tables using backlog hint

2006-10-19 Thread Eric Dumazet
Hi David Here is the second try for this patch. Many thanks for your feedback. [PATCH] [NET] Size listen hash tables using backlog hint We currently allocate  a fixed size 512 (TCP_SYNQ_HSIZE) slots hash table for each LISTEN socket, regardless of various parameters (listen backlog for example

Re: (usagi-core 31424) Re: [PATCH 7/13] [RFC] [IPV6] Move source address selection into route lookup.

2006-10-19 Thread Ville Nuorvala
Mitsuru-san, could you apply patch #12 and rerun the test? I think this particular problem is caused by the routing cache entry not having a valid source address in the first place. As ip6_dst_lookup() doesn't do the source address lookup anymore, it is critical that we only store cache entries wi

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-19 Thread Eric Dumazet
On Thursday 19 October 2006 10:41, David Miller wrote: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Thu, 19 Oct 2006 10:29:00 +0200 > > > Cons : > > TLB cost > > For those hot x86 and x86_64 cpus you tend to be using, this > particular cost is relatively small. :-) It's effectively like > anot

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-19 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 19 Oct 2006 10:29:00 +0200 > Cons : > TLB cost For those hot x86 and x86_64 cpus you tend to be using, this particular cost is relatively small. :-) It's effectively like another memory reference in the worst case, in the best case it's "free".

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-19 Thread Eric Dumazet
On Thursday 19 October 2006 08:57, David Miller wrote: > Switch to vmalloc() at the kmalloc() cut-off point, just like > I did for the other hashes in the tree. Yes, so you basically want option 4) :) 4) Use vmalloc() if size_lopt > PAGE_SIZE keep a power_of two : nr_table_entries = 2 ^ X; si