Re: [PATCH] d80211: remove unused Super AG definitions, purge comment

2006-10-16 Thread Johannes Berg
On Mon, 2006-10-16 at 11:39 -0700, David Kimdon wrote: > - MODE_ATHEROS_PRIME = 5 /* Atheros Dynamic Turbo mode */, > - MODE_ATHEROS_PRIMEG = 6 /* Atheros Dynamic Turbo mode G */, > NUM_IEEE80211_MODES = 7 You want to adjust that last constant there too, I guess. Why is it an enum a

Re: [take19 1/4] kevent: Core files.

2006-10-16 Thread Chase Venters
On Tuesday 17 October 2006 00:09, Johann Borck wrote: > Regarding mukevent I'm thinking of a event-type specific struct, that is > filled by the originating code, and placed into a per-event-type ring > buffer (which requires modification of kevent_wait). I'd personally worry about an implementat

Re: [PATCH] Bound TSO defer time (resend)

2006-10-16 Thread David Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 00:18:33 -0400 > Stephen Hemminger wrote: > > On Mon, 16 Oct 2006 20:53:20 -0400 (EDT) > > John Heffner <[EMAIL PROTECTED]> wrote: > > >> This patch limits the amount of time you will defer sending a TSO segment > >> to less than two c

Re: [PATCH 7/13] [RFC] [IPV6] Move source address selection into route lookup.

2006-10-16 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 03:13:17 +0300 > This patch moves the normal source address selection from > ip6_dst_lookup() into ip6_pol_route_output(), but shouldn't > change the routing or source address selection behavior in > any way. > > Signed-off-by: Ville

Re: [PATCH 6/13] [IPV6] Always copy rt->u.dst.error when copying a rt6_info.

2006-10-16 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 03:10:49 +0300 > Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> Looks good, applied. Ville, can you fixup Thunderbird to not corrupt your patches? The specific corruption is that if the patch has a completely empty line with just

Re: [PATCH 5/13] [IPV6] Make IPV6_SUBTREES depend on IPV6_MULTIPLE_TABLES.

2006-10-16 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 03:08:35 +0300 > As IPV6_SUBTREES can't work without IPV6_MULTIPLE_TABLES have IPV6_SUBTREES > depend on it. > > Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> Good catch, patch applied, thanks. - To unsubscribe from this list: s

Re: [PATCH 4/13] [IPV6] Clean up BACKTRACK().

2006-10-16 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 03:06:27 +0300 > The fn check is unnecessary as fn can never be NULL in BACKTRACK(). > > Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> Applied, especially valid since we're walking parents up to the, we break out at hitting root

Re: [PATCH 3/13] [IPV6] Make sure error handling is done when calling ip6_route_output().

2006-10-16 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 03:04:08 +0300 > As ip6_route_output() never returns NULL, error checking must be done by > looking at dst->error in stead of comparing dst against NULL. > > Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> Good catch, patch applie

Re: [PATCH 1/13] [IPV6] Remove struct pol_chain.

2006-10-16 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 02:54:27 +0300 > Struct pol_chain has existed since at least the 2.2 kernel, but isn't used > anymore. As the IPv6 policy routing is implemented in a totally different > way in the current kernel, just get rid of it. > > Signed-off-b

Re: [PATCH 2/13] [SCTP] Fix minor typo

2006-10-16 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Tue, 17 Oct 2006 02:56:55 +0300 > Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> Also applied, thanks. Please format your changelog headers properly, make it "[TOPIC]: " instead of "[TOPIC] ". Thanks. - To unsubscribe from this list: send the li

Re: [take19 1/4] kevent: Core files.

2006-10-16 Thread Johann Borck
Ulrich Drepper wrote: > Evgeniy Polyakov wrote: >> Existing design does not allow overflow. > > And I've pointed out a number of times that this is not practical at > best. There are event sources which can create events which cannot be > coalesced into one single event as it would be required wit

Re: [PATCH 0/14] TIPC updates

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:23 +0200 (CEST) > This patch set includes a number TIPC fixes/cleanups. Please see each > individual patch for further description. > > Please pull from: > > git://tipc.cslab.ericsson.net/pub/git/tipc.git > > (rebased on linux/

Re: [PATCH 14/14] [TIPC] Updated TIPC version number to 1.6.2

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:55 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > Signed-off-by: Allan Stephens <[EMAIL PROTECTED]> > Signed-off-by: Per Liden <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH 13/14] [TIPC] Unrecognized configuration command now returns error message

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:54 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > This patch causes TIPC to return an error message when it receives > an unrecognized configuration command. (Previously, the sender > received no feedback.) > > Signed-off-by

Re: [PATCH 12/14] [TIPC] Added subscription cancellation capability

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:53 +0200 > From: Lijun Chen <[EMAIL PROTECTED]> > > This patch allows a TIPC application to cancel an existing > topology service subscription by re-requesting the subscription > with the TIPC_SUB_CANCEL filter bit set. (All other

Re: [PATCH 10/14] [TIPC] Fixed slow link reactivation when link tolerance is large

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:51 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > This patch corrects an issue wherein a previouly failed node could > not reestablish a links to a non-failing node in the TIPC network > until the latter node detected the link

Re: [PATCH 11/14] [TIPC] Can now list multicast link on an isolated network node

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:52 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > This patch fixes a minor bug that prevents "tipc-config -l" from > displaying the multicast link if a TIPC node has never successfully > established at least one unicast link.

Re: [PATCH 9/14] [TIPC] Name publication events now delivered in chronological order

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:50 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > This patch tivially re-orders the entries in TIPC's list of local > publications so that applications will receive publication events > in the order they were published. > > S

Re: [PATCH 8/14] [TIPC] Fix socket receive queue NULL pointer dereference on SMP systems

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:49 +0200 > From: P Litov <[EMAIL PROTECTED]> > > This patch corrects an SMP system-specific race condition which allowed > TIPC to prematurely dereference the first sk_buff in a socket receive > queue that was changing from empty to

Re: [PATCH 7/14] [TIPC] Add support for Ethernet VLANs

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:48 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > This patch enhances TIPC's Ethernet support to include VLAN interfaces. > > Signed-off-by: Allan Stephens <[EMAIL PROTECTED]> > Signed-off-by: Per Liden <[EMAIL PROTECTED]> A

Re: [PATCH 6/14] [TIPC] Remove code bloat introduced by print buffer rework

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:47 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > This patch allows the compiler to optimize out any code that tries to > send debugging output to the null print buffer (TIPC_NULL), a capability > that was unintentionally brok

Re: [PATCH 5/14] [TIPC] Optimize wakeup logic when socket has no waiting processes

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:46 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > This patch adds a simple test so TIPC doesn't try waking up processes > waiting on a socket if there are none waiting. > > Signed-off-by: Allan Stephens <[EMAIL PROTECTED]> >

Re: [PATCH 4/14] [TIPC] Added duplicate node address detection capability

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:45 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > TIPC now rejects and logs link setup requests from node if the > receiving node already has a functional link to that node on the associated > interface, or if the requestor i

Re: [PATCH 3/14] [TIPC] Stream socket can now send > 66000 bytes at a time

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:44 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > The stream socket send code was not initializing some required fields > of the temporary msghdr structure it was utilizing; this is now fixed. > A check has also been added to

Re: [PATCH 2/14] [TIPC] Debug print buffer enhancements and fixes

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:43 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > This change modifies TIPC's print buffer code as follows: > 1) Now supports small print buffers (min. size reduced from 512 bytes to 64) > 2) Now uses TIPC_NULL print buffer st

Re: [PATCH 1/14] [TIPC] Add missing unlock in port timeout code.

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:42 +0200 > From: Allan Stephens <[EMAIL PROTECTED]> > > Signed-off-by: Allan Stephens <[EMAIL PROTECTED]> > Signed-off-by: Per Liden <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH] Bound TSO defer time (resend)

2006-10-16 Thread John Heffner
Stephen Hemminger wrote: On Mon, 16 Oct 2006 20:53:20 -0400 (EDT) John Heffner <[EMAIL PROTECTED]> wrote: This patch limits the amount of time you will defer sending a TSO segment to less than two clock ticks, or the time between two acks, whichever is longer. Okay, but doing any timing on

Re: [PATCH] Bound TSO defer time (resend)

2006-10-16 Thread Stephen Hemminger
On Mon, 16 Oct 2006 20:53:20 -0400 (EDT) John Heffner <[EMAIL PROTECTED]> wrote: > The original message didn't show up on the list. I'm assuming it's > because the filters didn't like the attached postscript. I posted PDFs of > the figures on the web: > > http://www.psc.edu/~jheffner/tmp/a.pdf

Re: socket/IP on Linux

2006-10-16 Thread Jingping Lin
Arnaldo: Sorry, I have to bother you again with another Linux socket question. Suppose that I have a Linux IP socket connected for a TCP connection and the socket is set as a non-blocking one with fcntl(). Even the socket is set as non-blocking, is it really possible to perform Non-Blocking Clos

[PATCH] Bound TSO defer time (resend)

2006-10-16 Thread John Heffner
The original message didn't show up on the list. I'm assuming it's because the filters didn't like the attached postscript. I posted PDFs of the figures on the web: http://www.psc.edu/~jheffner/tmp/a.pdf http://www.psc.edu/~jheffner/tmp/b.pdf http://www.psc.edu/~jheffner/tmp/c.pdf -John ---

RE: PATCH zero-copy send completion callback

2006-10-16 Thread Eric Barton
David, > Also, the correct mailing list to get to the networking developers > is [EMAIL PROTECTED] "linux-net" is for users. Noted. > Finally, I very much doubt you have much chance getting this > change in, the infrastructure is implemented in a very ad-hoc > fashion and it takes into consider

[PATCH 9/13] [RFC] [SCTP] Merge IPv4 and IPv6 versions of get_saddr() with their corresponding get_dst().

2006-10-16 Thread Ville Nuorvala
Oops, this almost more than any other patch was RFC. Sorry about that! Regards, Ville - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 13/13] [RFC] [IPV6] Fix source prefix routing problems when source address undefined.

2006-10-16 Thread Ville Nuorvala
With IPv6 routing subtrees we need to take into account that the source address is typically not specified at the time of the route lookup. There are two separate cases where this can happen. In the typical case the source address hasn't been selected before the route lookup. Skipping a source pr

[PATCH 12/13] [RFC] [IPV6] Make sure route cache entries have a valid source address.

2006-10-16 Thread Ville Nuorvala
Leaving out the source address from routing cache entries when using routing subtrees causes all kinds of problems. Make sure this doesn't happen. Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/route.c | 31 +-- 1 files changed, 17 insertions(+), 14

[PATCH 11/13] [RFC] [IPV6] Merge ipv6_dev_get_saddr() and ipv6_get_saddr().

2006-10-16 Thread Ville Nuorvala
The split into ipv6_get_saddr() and ipv6_dev_get_saddr() isn't necessary anymore, so they can be merged into just the function ipv6_get_saddr(). Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- include/net/addrconf.h |5 + net/ipv6/addrconf.c| 21 ++--- net/ipv6

[PATCH 10/13] [RFC] [IPV6] Don't export ipv6_get_saddr().

2006-10-16 Thread Ville Nuorvala
To make sure the source address selection is done correctly, don't let users outside the ipv6 module call ipv6_get_saddr() directly. In stead have them go through ip6_route_output(). Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/ipv6_syms.c |1 - 1 files changed, 0 insertion

[PATCH 9/13] [SCTP] Merge IPv4 and IPv6 versions of get_saddr() with their corresponding get_dst().

2006-10-16 Thread Ville Nuorvala
As the IPv6 route lookup now also returns the selected source address there is no need for a separate source address lookup. In fact, the source address selection needs to be moved to get_dst() because the selected IPv6 source address isn't always stored in the route. Sometimes this makes it impos

[PATCH 8/13] [RFC] [IPV6] Get rid of ipv6_get_saddr() in xfrm6_get_saddr().

2006-10-16 Thread Ville Nuorvala
As the source address is already selected in ip6_pol_route_output() there is no need to do the source address lookup a second time. Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/xfrm6_policy.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/ipv6/xf

[PATCH 7/13] [RFC] [IPV6] Move source address selection into route lookup.

2006-10-16 Thread Ville Nuorvala
This patch moves the normal source address selection from ip6_dst_lookup() into ip6_pol_route_output(), but shouldn't change the routing or source address selection behavior in any way. Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/ip6_output.c |6 -- net/ipv6/route.c

[PATCH 6/13] [IPV6] Always copy rt->u.dst.error when copying a rt6_info.

2006-10-16 Thread Ville Nuorvala
Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/route.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 263c057..aa96be8 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -618,8 +618,6 @@ static struct rt6_in

[PATCH 5/13] [IPV6] Make IPV6_SUBTREES depend on IPV6_MULTIPLE_TABLES.

2006-10-16 Thread Ville Nuorvala
As IPV6_SUBTREES can't work without IPV6_MULTIPLE_TABLES have IPV6_SUBTREES depend on it. Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/Kconfig | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig index a2d21

[PATCH 4/13] [IPV6] Clean up BACKTRACK().

2006-10-16 Thread Ville Nuorvala
The fn check is unnecessary as fn can never be NULL in BACKTRACK(). Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/route.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a1b0f07..263c057 100644 --- a/net/ipv6/ro

[PATCH 3/13] [IPV6] Make sure error handling is done when calling ip6_route_output().

2006-10-16 Thread Ville Nuorvala
As ip6_route_output() never returns NULL, error checking must be done by looking at dst->error in stead of comparing dst against NULL. Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/xfrm6_policy.c | 12 +++- net/sctp/ipv6.c | 10 +- 2 files changed, 12

Re: 2.6.18-mm2 boot failure on x86-64

2006-10-16 Thread Andrew Morton
On Mon, 16 Oct 2006 14:16:13 -0400 Vivek Goyal <[EMAIL PROTECTED]> wrote: > > Can you please have a look at the attached patch Looks like a fine patch to me, although it could benefit from a comment explaining why all those PAGE_ALIGN()s are in there. > and include it in -mm. Does it fix a pat

[PATCH 2/13] [SCTP] Fix minor typo

2006-10-16 Thread Ville Nuorvala
Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/sctp/socket.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 79c3e07..185d480 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -821,7 +821,7 @@ out: * addrs

[PATCH 1/13] [IPV6] Remove struct pol_chain.

2006-10-16 Thread Ville Nuorvala
Struct pol_chain has existed since at least the 2.2 kernel, but isn't used anymore. As the IPv6 policy routing is implemented in a totally different way in the current kernel, just get rid of it. Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- include/net/ip6_route.h |7 --- 1 files

[PATCH 0/13] [RFC] Fix problems with IPv6 routing subtrees and source address selection

2006-10-16 Thread Ville Nuorvala
Hi, here are a bunch of more or less related patches having to do with fixing the IPv6 routing subtrees and source address selection. Most of the code is a cleaned up version of what I've written earlier for MIPL 2, where it has worked pretty well for a couple of years now. The SCTP code, howe

[PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2006-10-16 Thread Russell Stuart
The Linux traffic's control engine inaccurately calculates transmission times for packets sent over ADSL links. For some packet sizes the error rises to over 50%. This occurs because ADSL uses ATM as its link layer transport, and ATM transmits packets in fixed sized 53 byte cells. This changes t

[PATCH 1/2] sky2: multicast pause frame receive

2006-10-16 Thread Stephen Hemminger
When using flow control, the PHY needs to accept multicast pause frames. Without this fix, these frames were getting discarded by the PHY before doing any flow control. This maybe related to http://bugzilla.kernel.org/show_bug.cgi?id=6839 Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> ---

[PATCH 2/2] sky2: don't process pause frames in recveiver.

2006-10-16 Thread Stephen Hemminger
This reverts earlier change that attempted to fix flow control; but was broken. Device needs to discard pause frames at the receive DMA engine, otherwise the pause frames get received and passed up the stack! Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.h |2 +-

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-16 Thread Andy Gospodarek
On Mon, Oct 16, 2006 at 09:07:57PM +0200, Dawid Ciezarkiewicz wrote: > > > > Before getting into the technical bits of the patch, what's the > > reason for wanting to do this, and why is this rather complex manual > > weight assignment better than an automatic system based on, e.g., link > > s

[PATCH] Fixed a number of bugs in the PHY Layer

2006-10-16 Thread Andy Fleming
* genphy_update_link is now exported * Added a fix from [EMAIL PROTECTED] which changes forcing so it only updates the link. Otherwise, it never tries the lower values, since it is always overwriting the speed/duplex values with the current ones, rather than the intended ones. * Fixed a bug

Re: [PATCH 9/14] [TIPC] Name publication events now delivered in chronological order

2006-10-16 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Mon, 16 Oct 2006 10:50:40 +0200 (CEST) > I'm fairly sure this is a problem on your side. I received patch 10/14 > from the netdev list and the two list archives I checked also had it. I also got 2 copies which means it hit netdev for me too. - To unsubsc

Re: [PATCH] NET : Suspicious locking in reqsk_queue_hash_req()

2006-10-16 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 16 Oct 2006 11:00:22 +0200 > While browsing include/net/request_sock.h I found this suspicious locking > protecting the SYN table hash table. I think this patch is necessary. > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> People get tripped

Re: [patch 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-16 Thread Michael Buesch
On Monday 16 October 2006 21:34, Simon Barber wrote: > Removing the bitfields makes the code much harder to read and maintain. > Here we are working around a problem with the compiler by making the > code ugly - rather than fixing the compiler. The compilers are getting > better and better (GCC 4 h

Re: poll problem with PF_PACKET when using PACKET_RX_RING

2006-10-16 Thread Joan Raventos
Is this a bug in PF_PACKET? Should the socket queue be emptied by packet_set_ring (called via setsockopt when PACKET_RX_RING is used) so the above cannot happen? Should the user-space app drain the socket queue with recvfrom prior to (4) -quite unlikely in practice-? >> >> >>>I

RE: [patch 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-16 Thread Simon Barber
Removing the bitfields makes the code much harder to read and maintain. Here we are working around a problem with the compiler by making the code ugly - rather than fixing the compiler. The compilers are getting better and better (GCC 4 has much better handling of this type of optimization) but the

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

2006-10-16 Thread Andrew Morton
On Mon, 16 Oct 2006 15:50:55 +0100 (BST) "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > Andrew, > > > I don't get it. If some code does > > > > rtnl_lock(); > > flush_scheduled_work(); > > > > and there's some work scheduled which does rtnl_lock() then it'll deadlock. > > > > But it

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-16 Thread Dawid Ciezarkiewicz
On Monday, 16 October 2006 20:50, you wrote: > > Dawid Ciezarkiewicz <[EMAIL PROTECTED]> wrote: > [...] > >+weighted-rr or 7 > >+ > >+Weighted round-robin bonding. In this mode bonding > >+interface will use weights assigned to it's slaves. > >+ > >+Each sla

Re: [e1000]: flow control on by default - good idea really?

2006-10-16 Thread Auke Kok
jamal wrote: On Thu, 2006-06-07 at 23:59 -0700, David Miller wrote: It's autonegotiated, check you kernel message logs when the link came up, you'll see this: tg3: eth0: Flow control is on for TX and on for RX. yikes - yes, this would be it. I could be wrong and i will double check: I thi

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-16 Thread Jay Vosburgh
Dawid Ciezarkiewicz <[EMAIL PROTECTED]> wrote: [...] >+ weighted-rr or 7 >+ >+ Weighted round-robin bonding. In this mode bonding >+ interface will use weights assigned to it's slaves. >+ >+ Each slave can have weight assigned via ioctl (ifenslave). >+

[PATCH] d80211: remove unused Super AG definitions, purge comment

2006-10-16 Thread David Kimdon
Remove unused Super AG structure members, enums. In struct ieee80211_tx_status the queue_length and queue_number could be useful outside the context of Super AG, so remove the comment and leave the members. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-16 Thread Dawid Ciezarkiewicz
On Monday, 16 October 2006 20:21, Dawid Ciezarkiewicz wrote: > This patch is little thinner then the previous one. I'm sorry for that. I've just ... nevermind. Here goes the patch. Should I post patch for ifenslave here, too? diff -Nur linux-2.6.17.orig/Documentation/networking/bonding.txt li

PATCH zero-copy send completion callback

2006-10-16 Thread Eric Barton
This patch has been used with the lustre cluster file system (www.lustre.org) to give notification when page buffers used to send bulk data via TCP/IP may be overwritten. It implements... a) A general-purpose callback to inform higher-level protocols when a zero-copy send of a set of page

Re: 2.6.18-mm2 boot failure on x86-64

2006-10-16 Thread Vivek Goyal
On Mon, Oct 09, 2006 at 10:53:58AM +0100, Mel Gorman wrote: > On Fri, 6 Oct 2006, Vivek Goyal wrote: > > >On Fri, Oct 06, 2006 at 01:03:50PM -0500, Steve Fox wrote: > >>On Fri, 2006-10-06 at 18:11 +0100, Mel Gorman wrote: > >>>On (06/10/06 11:36), Vivek Goyal didst pronounce: > Where is bss pl

[RFC] wrr (weighted round-robin) bonding

2006-10-16 Thread Dawid Ciezarkiewicz
This patch is little thinner then the previous one. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] NET : Suspicious locking in reqsk_queue_hash_req()

2006-10-16 Thread Eric Dumazet
On Monday 16 October 2006 18:56, Eric Dumazet wrote: > On Monday 16 October 2006 18:16, Arnaldo Carvalho de Melo wrote: > > On 10/16/06, Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > (Sorry, patch inlined this time) > > > > > > Hi David > > > > > > While browsing include/net/request_sock.h I found

PATCH zero-copy send completion callback

2006-10-16 Thread Eric Barton
This patch has been used with the lustre cluster file system (www.lustre.org) to give notification when page buffers used to send bulk data via TCP/IP may be overwritten. It implements... a) A general-purpose callback to inform higher-level protocols when a zero-copy send of a set of page

Re: [PATCH] NET : Suspicious locking in reqsk_queue_hash_req()

2006-10-16 Thread Eric Dumazet
On Monday 16 October 2006 18:16, Arnaldo Carvalho de Melo wrote: > On 10/16/06, Eric Dumazet <[EMAIL PROTECTED]> wrote: > > (Sorry, patch inlined this time) > > > > Hi David > > > > While browsing include/net/request_sock.h I found this suspicious locking > > protecting the SYN table hash table. I

Re: [patch 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-16 Thread Michael Buesch
On Friday 13 October 2006 21:20, David Kimdon wrote: > All one-bit bitfields have been subsumed into the new 'flags' > structure member and the new IEEE80211_TXCTL_* definitions. The > multiple bit members were converted to u8, s8 or u16 as appropriate. And, eh, did this increase or decrease the

Re: [PATCH] NET : Suspicious locking in reqsk_queue_hash_req()

2006-10-16 Thread Arnaldo Carvalho de Melo
On 10/16/06, Eric Dumazet <[EMAIL PROTECTED]> wrote: (Sorry, patch inlined this time) Hi David While browsing include/net/request_sock.h I found this suspicious locking protecting the SYN table hash table. I think this patch is necessary. Thank you Interesting, just checked and it was there

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

2006-10-16 Thread Maciej W. Rozycki
Andrew, > I don't get it. If some code does > > rtnl_lock(); > flush_scheduled_work(); > > and there's some work scheduled which does rtnl_lock() then it'll deadlock. > > But it'll deadlock whether or not the caller of flush_scheduled_work() is > keventd. > > Calling flush_schedul

Re: Hardware bug or kernel bug?

2006-10-16 Thread David Johnson
On Monday 16 October 2006 11:25, Jarek Poplawski wrote: > > Was this lock-up effect visible during above 2.6.19-rc1 tests? No, I've not seen anything in Linux other than the reboots, which are instant without any preceding lock-up. > If not I'd try to continue linux debbuging: > - is 2.6.19-rc1

Re: [PATCH] bcm43xx-softmac: add PCI-E code

2006-10-16 Thread Michael Buesch
On Monday 16 October 2006 06:18, Larry Finger wrote: > From: Stefano Brivio <[EMAIL PROTECTED]> > > The current bcm43xx driver does not contain code to handle PCI-E interfaces > such as the BCM4311 and BCM4312. This patch, originally written by Stefano > Brivio adds the necessary code to enable th

Re: [Bugme-new] [Bug 7366] New: BUG: unable to handle kernel paging request at virtual address d0cb03e0

2006-10-16 Thread Patrick McHardy
Please use reply to _all_. Quoting manually .. Patrick McHardy wrote: >> Does it also happen without external patches like ipp2p? Did you >> load/unload any netfilter modules before? > > This happens after loading all specific, ip_conntrackmodules, flushing > al iptables rules, reseting counters,

Re: [take19 1/4] kevent: Core files.

2006-10-16 Thread Evgeniy Polyakov
On Mon, Oct 16, 2006 at 03:16:15AM -0700, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >The whole idea of mmap buffer seems to be broken, since those who asked > >for creation do not like existing design and do not show theirs... > > What kind of argumentation is that? >

Re: [take19 0/4] kevent: Generic event handling mechanism.

2006-10-16 Thread Evgeniy Polyakov
On Mon, Oct 16, 2006 at 02:59:48AM -0700, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >One can set number of events before the syscall and do not remove them > >after syscall. It can be updated if there is need for that. > > Nobody doubts that it is possible. But it is

Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set

2006-10-16 Thread Alan Cox
Ar Sul, 2006-10-15 am 16:44 -0700, ysgrifennodd Andrew Morton: > Let me restore the words from my earlier email which you removed so that > you could say that: > > For you the driver author to make assumptions about what's happening > inside pci_set_mwi() is a layering violation. Maybe the br

Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set

2006-10-16 Thread Alan Cox
Ar Sul, 2006-10-15 am 17:16 -0700, ysgrifennodd David Brownell: > Signed-off-by: David Brownell <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> > > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -499,7 +499,7 @@ int __must_check pci_enable_device_bars( > void pci_disable_d

Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set

2006-10-16 Thread Alan Cox
Ar Sul, 2006-10-15 am 18:10 -0700, ysgrifennodd Andrew Morton: > Question is, should pci_set_mwi() ever return -EFOO? I guess it should, in > the case where setting the line size didn't work out. It does no harm, no driver will ever check anything but 0 v !0 because the handling is no different i

Re: Hardware bug or kernel bug?

2006-10-16 Thread Jarek Poplawski
On Fri, Oct 13, 2006 at 05:24:39PM +0100, David Johnson wrote: > On Friday 13 October 2006 14:06, Jarek Poplawski wrote: > > > > Probably - but only with networking. So I'd try with this debugging > > like in my first reply plus maybe 2.6.19-rc1 (e1000 - btw. I hope > > this other tested card was d

Re: [take19 1/4] kevent: Core files.

2006-10-16 Thread Ulrich Drepper
Evgeniy Polyakov wrote: The whole idea of mmap buffer seems to be broken, since those who asked for creation do not like existing design and do not show theirs... What kind of argumentation is that? "Because my attempt to implement it doesn't work and nobody right away has a better sugg

Re: [take19 0/4] kevent: Generic event handling mechanism.

2006-10-16 Thread Ulrich Drepper
Evgeniy Polyakov wrote: One can set number of events before the syscall and do not remove them after syscall. It can be updated if there is need for that. Nobody doubts that it is possible. But it is a) potentially much expensive and b) an alien concept to have the signal mask to set durin

[PATCH] NET : Suspicious locking in reqsk_queue_hash_req()

2006-10-16 Thread Eric Dumazet
(Sorry, patch inlined this time) Hi David While browsing include/net/request_sock.h I found this suspicious locking protecting the SYN table hash table. I think this patch is necessary. Thank you Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> --- linux-2.6.18/include/net/request_sock.h.orig

[PATCH] NET : Suspicious locking in reqsk_queue_hash_req()

2006-10-16 Thread Eric Dumazet
Hi David While browsing include/net/request_sock.h I found this suspicious locking protecting the SYN table hash table. I think this patch is necessary. Thank you Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> --- linux-2.6.18/include/net/request_sock.h.orig2006-10-16 10:53:11.000

Re: [PATCH 9/14] [TIPC] Name publication events now delivered in chronological order

2006-10-16 Thread Per Liden
I'm fairly sure this is a problem on your side. I received patch 10/14 from the netdev list and the two list archives I checked also had it. /Per On Fri, 13 Oct 2006, Bill Fink wrote: > FYI, > > At least here, I received two copies of patch 9/14 and no copy > of patch 10/14. > >

Re: [take19 1/4] kevent: Core files.

2006-10-16 Thread Evgeniy Polyakov
On Sun, Oct 15, 2006 at 04:22:45PM -0700, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >Existing design does not allow overflow. > > And I've pointed out a number of times that this is not practical at > best. There are event sources which can create events which cannot

Re: [take19 0/4] kevent: Generic event handling mechanism.

2006-10-16 Thread Evgeniy Polyakov
On Sun, Oct 15, 2006 at 03:43:39PM -0700, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >In context you have cut, one updated signal mask between calls to event > >delivery mechanism (using for example signal()), so it has exactly the > >same price. > > No, it does not. I

Re: Patch to remove masq/NAT in description of IP6_NF_IPTABLES in ipv6/netfilter/Kconfig

2006-10-16 Thread Patrick McHardy
Peter Bieringer wrote: > afaik, NAT (and therefore masquerading also) is left out by design in > IPv6, looks like a copy&paste issue. > > Patch attached to fix this. Applied, thanks. But please sign off future patches. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: Suppress / delay SYN-ACK

2006-10-16 Thread Lennert Buytenhek
On Thu, Oct 12, 2006 at 10:08:53AM +0200, Martin Schiller wrote: > I'm searching for a solution to suppress / delay the SYN-ACK packet of a > listening server (-application) until he has decided (e.g. analysed the > requesting ip-address or checked if the corresponding other end of a > connection

Patch to remove masq/NAT in description of IP6_NF_IPTABLES in ipv6/netfilter/Kconfig

2006-10-16 Thread Peter Bieringer
Hi, afaik, NAT (and therefore masquerading also) is left out by design in IPv6, looks like a copy&paste issue. Patch attached to fix this. Peter -- Dr. Peter Bieringer http://www.bieringer.de/pb/ GPG/PGP Key 0x958F422D mailto:[EMAIL PROTECTED] D