Re: Tigon3 crash when used with any torrent app

2006-10-10 Thread Herbert Xu
Michael Chan <[EMAIL PROTECTED]> wrote: > Sebastian Alfredo Salvino wrote: > >> However when I am booted up into 2.6.18 and try to connect to >> any p2p network >> via BitTorrent, KTorrent, etc., it just hang. > > Did the same setup work in 2.6.17? If yes, can you bisect > the tg3 patches bet

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 20:49:09 -0700 > David> non-sendfile() paths will generate big packets just fine, > David> as long as the application is providing that much data. > > OK, cool. Will the big packets be non-linear skbs? If you had SG enabled

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread Roland Dreier
David> non-sendfile() paths will generate big packets just fine, David> as long as the application is providing that much data. OK, cool. Will the big packets be non-linear skbs? Because then it would make sense for a device with a huge MTU to want to accept them without linearizing them

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 20:42:20 -0700 > On the other hand I'm not sure how useful such a netdevice would be -- > will non-sendfile() paths generate big packets even if the MTU is 64KB? non-sendfile() paths will generate big packets just fine, as long as the

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread Roland Dreier
David> Also, if you don't do checksumming on the card we MUST copy David> the data (be it from a user buffer, or from a filesystem David> page cache page) into a private buffer since if the data David> changes the checksum would become invalid, as I mentioned David> in another e

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 20:33:46 -0700 > Michael> My guess was, an extra pass over data is likely to be > Michael> expensive - dirtying the cache if nothing else. But I do > Michael> plan to measure that, and see. > > I don't get it -- where's th

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread Roland Dreier
Michael> My guess was, an extra pass over data is likely to be Michael> expensive - dirtying the cache if nothing else. But I do Michael> plan to measure that, and see. I don't get it -- where's the extra pass? If you can't compute the checksum on the NIC then you have to compute some

Re: [PATCH] Customizable TCP backoff patch

2006-10-10 Thread David Miller
Actually, your entire patch uses spaces for indentation of every new line added, not just those two new struct members I pointed out. Please use tabs for all of those cases. Thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTE

Re: [PATCH] Customizable TCP backoff patch

2006-10-10 Thread David Miller
From: Ben Woodard <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 18:46:58 -0700 > @@ -257,6 +259,8 @@ > __u8frto_counter; /* Number of new acks after RTO */ > __u8nonagle;/* Disable Nagle algorithm? */ > __u8keepalive_probes; /* num of allowed keep a

Re: Tigon3 crash when used with any torrent app

2006-10-10 Thread Michael Chan
Sebastian Alfredo Salvino wrote: > However when I am booted up into 2.6.18 and try to connect to > any p2p network > via BitTorrent, KTorrent, etc., it just hang. > Did the same setup work in 2.6.17? If yes, can you bisect the tg3 patches between 2.6.17 and 2.6.18? Looking at the patches be

Re: [RFC] [TCP]: TCP MD5 Signature Option (RFC2385) Support.

2006-10-10 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Wed, 11 Oct 2006 11:39:00 +0900 (JST) > [TCP]: Use TCPOLEN_TSTAMP_ALIGNED macro instead of magic number. > [NET]: Use hton{l,s}() for non-initializers. > [NET]: Use typesafe inet_twsk() inline function instead of cast. > [NET]: Intr

Re: [PATCH-update][RFC] net: consolidated UDP / UDP-Lite code

2006-10-10 Thread David Miller
From: Gerrit Renker <[EMAIL PROTECTED]> Date: Mon, 9 Oct 2006 10:51:44 +0100 > csum_copy_err: > - UDP_INC_STATS_BH(UDP_MIB_INERRORS); > + UDP_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite); > + UDP_DEC_STATS_BH(UDP_MIB_INDATAGRAMS, is_udplite); I'm not a big fan at all of these "statisti

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread David Miller
From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> Date: Wed, 11 Oct 2006 02:13:38 +0200 > Maybe I can patch linux to allow SG without checksum? > Dave, maybe you could drop a hint or two on whether this is worthwhile > and what are the issues that need addressing to make this work? > > I imagine it'

Re: is each frag of a skb always less than 1 page?

2006-10-10 Thread David Miller
From: "Ronghua Zhang" <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 16:26:58 -0700 > Thank you for your explanation, David. > > But pci_map_page should work fine if we have multiple contiguous pages > in one frag that are allocated using alloc_pages, ie: > > frag->page = alloc_pages(GFP_KERNEL, 2

Re: [PATCH] Customizable TCP backoff patch

2006-10-10 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 10 Oct 2006 18:46:58 -0700), Ben Woodard <[EMAIL PROTECTED]> says: > diff -ru linux-2.6.18/net/ipv4/tcp.c linux-2.6.18.new/net/ipv4/tcp.c > --- linux-2.6.18/net/ipv4/tcp.c 2006-09-19 20:42:06.0 -0700 > +++ linux-2.6.18.new/net/ipv4/tcp.c 200

Re: [PATCH] Customizable TCP backoff patch

2006-10-10 Thread Ben Woodard
David Miller wrote: From: Ben Woodard <[EMAIL PROTECTED]> Date: Tue, 03 Oct 2006 11:14:38 -0700 Other issues: 1) 2 "u32" in the tcp_sock is a lot of space to devote to this new state. If it can fit in 2 "u16"'s or even less space, please use that. 2) the expression "(tp->foo ? : sysctl

Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-10 Thread Geoff Levand
jschopp wrote: > Linas Vepstas wrote: >> The current driver code performs 512 DMA mappns of a bunch of >> 32-byte structures. This is silly, as they are all in contiguous >> memory. Ths patch changes the code to DMA map the entie area >> with just one call. >> >> Signed-off-by: Linas Vepstas <[E

Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag

2006-10-10 Thread David Kimdon
On Tue, Oct 10, 2006 at 11:04:05PM +0200, Michael Buesch wrote: > On Tuesday 10 October 2006 15:45, David Kimdon wrote: > > On Tue, Oct 10, 2006 at 12:00:12PM +0200, Michael Buesch wrote: > > > On Monday 09 October 2006 19:03, David Kimdon wrote: > > > > This flag is unused by all in tree drivers.

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread Michael S. Tsirkin
Quoting r. Roland Dreier <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > Michael> Maybe I can patch linux to allow SG without checksum? > Michael> Dave, maybe you could drop a hint or two on whether this > Michael> is worthwhile and what are the i

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread Roland Dreier
Michael> Maybe I can patch linux to allow SG without checksum? Michael> Dave, maybe you could drop a hint or two on whether this Michael> is worthwhile and what are the issues that need Michael> addressing to make this work? What do you really gain by allowing SG without checksum?

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread Michael S. Tsirkin
Quoting r. Stephen Hemminger <[EMAIL PROTECTED]>: > > > > I'm trying to build a network device driver supporting a very large MTU > > > > (around 64K) on top of an infiniband connection, and I've hit a couple > > > > of issues I'd appreciate some feedback on: > > > > > > > > 1. On the send side, >

Re: [patch 2/2] round_jiffies users

2006-10-10 Thread Arjan van de Ven
Paul Dickson wrote: On Tue, 10 Oct 2006 18:04:23 +0200, Arjan van de Ven wrote: + mod_timer(&adapter->phy_info_timer, round_jiffies(jiffies + 2 * HZ)); Shouldn't round_jiffies_relative be used for some of these, a la: + mod_timer(&adapter->phy_inf

Re: is each frag of a skb always less than 1 page?

2006-10-10 Thread Ronghua Zhang
Thank you for your explanation, David. But pci_map_page should work fine if we have multiple contiguous pages in one frag that are allocated using alloc_pages, ie: frag->page = alloc_pages(GFP_KERNEL, 2); // get 4 pages frag->page_offset = 0; frag->size = 4 * PAGE_SIZE; dma_addr = pci_map_p

Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-10 Thread jschopp
Linas Vepstas wrote: The current driver code performs 512 DMA mappns of a bunch of 32-byte structures. This is silly, as they are all in contiguous memory. Ths patch changes the code to DMA map the entie area with just one call. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewi

is each frag of a skb always less than 1 page?

2006-10-10 Thread Ronghua Zhang
From the code of tcp_sendmsg, it seems to me that each frag is at most one page. Is it a guaranteed property or the driver should not assume it? Thanks Ronghua - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 2/2] round_jiffies users

2006-10-10 Thread Paul Dickson
On Tue, 10 Oct 2006 18:04:23 +0200, Arjan van de Ven wrote: > + mod_timer(&adapter->phy_info_timer, > round_jiffies(jiffies + 2 * HZ)); Shouldn't round_jiffies_relative be used for some of these, a la: + mod_timer(&adapter->phy_info_timer, round_jiffie

Re: is each frag of a skb always less than 1 page?

2006-10-10 Thread David Miller
From: "Ronghua Zhang" <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 15:37:04 -0700 > >From the code of tcp_sendmsg, it seems to me that each frag is at most > one page. Is it a guaranteed property or the driver should not assume > it? Thanks This assumption basically already exists everywhere since

Re: [PATCH 02/02 V3] net/ipv6: seperate sit driver to extra module (addrconf.c changes)

2006-10-10 Thread David Miller
From: Joerg Roedel <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 17:43:55 +0200 > This patch contains the changes to net/ipv6/addrconf.c to remove sit > specific code if the sit driver is not selected. > > Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PRO

Re: [PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-10-10 Thread David Miller
From: Joerg Roedel <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 17:37:45 +0200 > This patch removes the driver of the IPv6-in-IPv4 tunnel driver (sit) > from the IPv6 module. It adds an option to Kconfig which makes it > possible to compile it as a seperate module. > > Signed-off-by: Joerg Roedel <

Re: bcm43xx scan oops!!!

2006-10-10 Thread Jory A. Pratt
Michael Buesch wrote: On Tuesday 10 October 2006 16:23, Jory A. Pratt wrote: Michael Buesch wrote: On Tuesday 10 October 2006 05:14, Jory A. Pratt wrote: http://home.nctv.com/anarchy/dscape-clean.jpg That's hardly readable. But which firmware are you running? v

Re: [BUG 2.6.18] unaligned access in ipvv6_rcv, nf_ip6_checksum, tcp_error, __ipv6_addr_type, fib6_lookup_1

2006-10-10 Thread David Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Tue, 10 Oct 2006 18:28:03 +0200 > The NIC in use is a tulip: > eth1: Digital DS21143 Tulip rev 65 at 01ff2000, 00:40:C7:97:6B:0D, > IRQ 15. > > Since there is no other tulip nic (only 3c59x and sunhme) in that box, > it might be a tulip driver

[patch 2/7] b44: fix eeprom endianess issue

2006-10-10 Thread akpm
From: Michael Buesch <[EMAIL PROTECTED]> This fixes eeprom read on big-endian architectures. readw returns the data in CPU order. With cpu_to_le16 we convert it to little endian, because "ptr" is a pointer to a _byte_ arrray. See the cast above. A byte array is little endian. The bug is: Rea

[patch 6/7] pci_module_init() convertion in olympic.c

2006-10-10 Thread akpm
From: Henrik Kretzschmar <[EMAIL PROTECTED]> pci_module_init() convertion in olympic.c Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/tokenring/olympic.c |2 +- 1 files changed, 1

[patch 1/7] Update smc91x driver with ARM Versatile board info

2006-10-10 Thread akpm
From: Deepak Saxena <[EMAIL PROTECTED]> We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new generic IRQ layer will complain thusly: No IRQF_TRIGGER set_type function for IRQ 25 () Signed-off-by: Deepak Saxena <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Russell

[patch 5/7] 8139too: force media setting cleanup

2006-10-10 Thread akpm
From: Bernard Lee <[EMAIL PROTECTED]> Setting bit 4 & 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4 & 5 to take effect. The

[patch 3/7] forcedeth: power management support

2006-10-10 Thread akpm
From: Francois Romieu <[EMAIL PROTECTED]> Tobias Diedrich <[EMAIL PROTECTED]> sayeth: Vanilla forcedeth doesn't seem to support suspend and an ifdown/up-cycle is needed to get it working again after suspend. Francois Romieu's "Awfully experimental" patch is working just fine for me (with message

[patch 7/7] ibmveth irq fix

2006-10-10 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> drivers/net/ibmveth.c:939: error: too many arguments to function `ibmveth_interrupt' Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Anton Blanchard <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> ---

[patch 4/7] Remove unnecessary check in drivers/net/depca.c

2006-10-10 Thread akpm
From: Eric Sesterhenn <[EMAIL PROTECTED]> This was spotted by coverity (cid #793). All callers dereference dev before calling this functions, and we dereference it earlier in the function, when initializing lp. Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]

[PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-10 Thread Linas Vepstas
The current driver code performs 512 DMA mappns of a bunch of 32-byte structures. This is silly, as they are all in contiguous memory. Ths patch changes the code to DMA map the entie area with just one call. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]>

[PATCH 15/21]: powerpc/cell spidernet refine locking

2006-10-10 Thread Linas Vepstas
The transmit side of the spider ethernet driver currently places locks around some very large chunks of code. This results in a fair amount of lock contention is some cases. This patch makes the locks much more fine-grained, protecting only the cirtical sections. One lock is used to protect thre

[PATCH 18/21]: powerpc/cell spidernet variable name change

2006-10-10 Thread Linas Vepstas
Cosmetic patch: give the variable holding the numer of descriptors a more descriptive name, so to avoid confusion. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c | 12 ++---

[PATCH 17/21]: powerpc/cell spidernet reduce DMA kicking

2006-10-10 Thread Linas Vepstas
The current code attempts to start the TX dma every time a packet is queued. This is too conservative, and wastes CPU time. This patch changes behaviour to call the kick-dma function less often, only when the tx queue is at risk of emptying. This reduces cpu usage, improves performance. Signed-

[PATCH 13/21]: powerpc/cell spidernet low watermark patch.

2006-10-10 Thread Linas Vepstas
Implement basic low-watermark support for the transmit queue. Hardware low-watermarks allow a properly configured kernel to continously stream data to a device and not have to handle any interrupts at all in doing so. Correct zero-interrupt operation can be actually observed for this driver, when

[PATCH 14/21]: powerpc/cell spidernet NAPI polling info.

2006-10-10 Thread Linas Vepstas
This patch moves transmit queue cleanup code out of the interrupt context, and into the NAPI polling routine. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> drivers/net/spider_net.c | 16 ---

[PATCH 19/21]: powerpc/cell spidernet DMA direction fix

2006-10-10 Thread Linas Vepstas
The ring buffer descriptors are DMA-accessed bidirectionally, but are not declared in this way. Fix this. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c | 26 +-

[PATCH 16/21]: powerpc/cell spidernet

2006-10-10 Thread Linas Vepstas
Remove a dummy register read that is not needed. This reduces CPU usage notably during transmit. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> drivers/net/spider_net.c |2 -- 1 file changed, 2 deletions(-)

[PATCH 20/21]: powerpc/cell spidernet release all descrs

2006-10-10 Thread Linas Vepstas
Bugfix: rx descriptor release function fails to visit the last entry while walking receive descriptor ring. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c |4 ++-- 1 file changed, 2 i

[PATCH 10/21]: powerpc/cell spidernet fix error interrupt print

2006-10-10 Thread Linas Vepstas
The print message associated with the descriptor chain end interrupt prints a bogs value. Fix that. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c |2 +- 1 file changed, 1 insertion(

Re: bcm43xx scan oops!!!

2006-10-10 Thread Michael Buesch
On Tuesday 10 October 2006 16:23, Jory A. Pratt wrote: > Michael Buesch wrote: > > On Tuesday 10 October 2006 05:14, Jory A. Pratt wrote: > > > >> http://home.nctv.com/anarchy/dscape-clean.jpg > >> > > > > That's hardly readable. > > But which firmware are you running? v4.x by chance? > > >

[PATCH 8/21]: Spidernet stop queue when queue is full.

2006-10-10 Thread Linas Vepstas
This patch adds a call to netif_stop_queue() when there is no more room for more packets on the transmit queue. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c | 33 ++---

[PATCH 12/21]: powerpc/cell spidernet incorrect offset

2006-10-10 Thread Linas Vepstas
Bugfix -- the rx chain is in memory after the tx chain -- the offset being used was wrong, resulting in memory corruption when the size of the rx and tx rings weren't exactly the same. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAI

[PATCH 4/21]: powerpc/cell spidernet force-end fix

2006-10-10 Thread Linas Vepstas
Bugfix: when cleaning up the transmit queue upon device close, be sure to walk the entire queue. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c |5 - 1 file changed, 4 insertions(

[PATCH 6/21]: powerpc/cell spidernet add missing netdev watchdog

2006-10-10 Thread Linas Vepstas
Set the netdev watchdog timer. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.18-mm2/drivers/net/spider_net.c ==

Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag

2006-10-10 Thread Michael Buesch
On Tuesday 10 October 2006 15:45, David Kimdon wrote: > On Tue, Oct 10, 2006 at 12:00:12PM +0200, Michael Buesch wrote: > > On Monday 09 October 2006 19:03, David Kimdon wrote: > > > This flag is unused by all in tree drivers. Furthermore, the way that > > > it is documented is not consistent with

[PATCH 7/21]: Spidernet fix register field definitions

2006-10-10 Thread Linas Vepstas
This patch fixes the names of a few fields in the DMA control register. There is no functional change. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c |2 +- drivers/net/spider_net.h

[PATCH 11/21]: powerpc/cell spidernet stop error printing patch.

2006-10-10 Thread Linas Vepstas
Turn off mis-interpretation of the queue-empty interrupt status bit as an error. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Signed-off-by: James K Lewis <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c | 13 + 1 file changed, 9 i

[PATCH 5/21]: powerpc/cell spidernet zlen min packet length

2006-10-10 Thread Linas Vepstas
Polite device drivers pad short packets to 60 bytes, so that mean-spirited users don't accidentally DOS some other OS that can't handle short packets. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net

Re: [PATCH 0/21]: powerpc/cell spidernet bugfixes, etc.

2006-10-10 Thread Andrew Morton
On Tue, 10 Oct 2006 15:49:47 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: > > Andrew, please apply/forward upstream. s/Andrew/Jeff/;) > I tried to base these on linux-2.6.19-rc1-mm1 but hit a > kernel BUG in copy_fdtable at fs/file.c:138! > (reported earlire today by Olof) yup, ftp://ftp.k

[PATCH 9/21]: powerpc/cell spidernet bogus rx interrupt bit

2006-10-10 Thread Linas Vepstas
The current receive interrupt mask sets a bogus bit that doesn't even belong to the definition of this register. Remove it. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.h |5 ++--- 1

[PATCH 1/21]: powerpc/cell spidernet ethtool -i version number info.

2006-10-10 Thread Linas Vepstas
This patch adds version information as reported by ethtool -i to the Spidernet driver. From: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_n

[PATCH 2/21]: powerpc/cell spidernet burst alignment patch.

2006-10-10 Thread Linas Vepstas
This patch increases the Burst Address alignment from 64 to 1024 in the Spidernet driver. This improves transmit performance for large packets. From: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Acked-by: Arnd

[PATCH 3/21]: Spidernet module parm permissions

2006-10-10 Thread Linas Vepstas
The module param permsissions should bw read-only, not writable. From: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c |4 ++-- 1 file chan

[PATCH 0/21]: powerpc/cell spidernet bugfixes, etc.

2006-10-10 Thread Linas Vepstas
Andrew, please apply/forward upstream. The following set of 21 patches (!) are all aimed at the the spidernet ethernet device driver. The spidernet is an etherenet controller built into the Toshiba southbridge for the PowerPC Cell processor. (This is the only device in existance that with this e

Re: Request to postpone WE-21

2006-10-10 Thread Jean Tourrilhes
On Tue, Oct 10, 2006 at 03:40:04PM -0400, John W. Linville wrote: > > I think this patch still has two problems. One is that the length > modification does not happen until after the "Check what user space > is giving us" clause. So, max length requests will fail. (Did you > check SIOCGIWESSID

Re: Request to postpone WE-21

2006-10-10 Thread John W. Linville
On Thu, Oct 05, 2006 at 03:12:46PM -0700, Jean Tourrilhes wrote: > On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > > On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: > > > > > Based on the feedback, I formally request you to back out all > > > of WE-21 from 2.

Re: socket/IP on Linux

2006-10-10 Thread Arnaldo Carvalho de Melo
On 10/5/06, Jingping Lin <[EMAIL PROTECTED]> wrote: Hello, Linux Kernel: For a project I will work on for mobile, I am looking into the IP stacks on Linux. I have a few questions to bother you: No bothering, so far, please see the below answers and try to check them all before "bothering" agai

Re: [PATCH] ixgb: Delete IXGB_DBG() macro and call pr_debug() directly.

2006-10-10 Thread Auke Kok
Robert P. J. Day wrote: On Tue, 10 Oct 2006, Auke Kok wrote: Robert P. J. Day wrote: ... snip ... if someone wants to tell me what, in the context of ixgb_main.c, i would use as that "dev" argument [for dev_dbg], i'm all for that. (CC netdev since it's a network driver topic). all our m

Re: [Bugme-new] [Bug 7297] New: modprobe -v -r causes crash in xt_unregister_match

2006-10-10 Thread Andrew Morton
On Tue, 10 Oct 2006 05:10:47 -0700 [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=7297 > >Summary: modprobe -v -r causes crash in xt_unregister_match > Kernel Version: 2.6.16 / 2.6.19-rc1-git6 > Status: NEW > Severity: normal >

Re: [PATCH] ixgb: Delete IXGB_DBG() macro and call pr_debug() directly.

2006-10-10 Thread Robert P. J. Day
On Tue, 10 Oct 2006, Auke Kok wrote: > Robert P. J. Day wrote: ... snip ... > > if someone wants to tell me what, in the context of ixgb_main.c, > > i would use as that "dev" argument [for dev_dbg], i'm all for > > that. > > (CC netdev since it's a network driver topic). > > all our macro's (e

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread Stephen Hemminger
On Tue, 10 Oct 2006 16:43:30 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote: > Quoting r. Stephen Hemminger <[EMAIL PROTECTED]>: > > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > > > On Mon, 9 Oct 2006 19:47:05 +0200 > > "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote: > >

Re: [patch 2/2] round_jiffies users

2006-10-10 Thread Arjan van de Ven
On Tue, 2006-10-10 at 18:47 +0200, Ingo Oeser wrote: > Hi Arjan, > > Arjan van de Ven wrote: > > Index: linux-2.6.19-rc1-git6/mm/slab.c > > === > > --- linux-2.6.19-rc1-git6.orig/mm/slab.c > > +++ linux-2.6.19-rc1-git6/mm/slab.c > > @

Re: [PATCH] ixgb: Delete IXGB_DBG() macro and call pr_debug() directly.

2006-10-10 Thread Auke Kok
Robert P. J. Day wrote: On Tue, 10 Oct 2006, Auke Kok wrote: Robert P. J. Day wrote: Delete the minimally-useful IXGB_DBG() macro and call pr_debug() directly from the main routine. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb

Re: [patch 2/2] round_jiffies users

2006-10-10 Thread Ingo Oeser
Hi Arjan, Arjan van de Ven wrote: > Index: linux-2.6.19-rc1-git6/mm/slab.c > === > --- linux-2.6.19-rc1-git6.orig/mm/slab.c > +++ linux-2.6.19-rc1-git6/mm/slab.c > @@ -926,7 +926,7 @@ static void __devinit start_cpu_timer(in > i

[patch 2/2] round_jiffies users

2006-10-10 Thread Arjan van de Ven
From: Arjan van de Ven <[EMAIL PROTECTED]> Subject: round_jiffies users CC: [EMAIL PROTECTED] CC: netdev@vger.kernel.org This patch introduces users of the round_jiffies() function. These timers all were of the "about once a second" or "about once every X seconds" variety and several showed up i

[PATCH 02/02 V3] net/ipv6: seperate sit driver to extra module (addrconf.c changes)

2006-10-10 Thread Joerg Roedel
This patch contains the changes to net/ipv6/addrconf.c to remove sit specific code if the sit driver is not selected. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff -upr -X linux-2.6.18/Documentation/dontdiff linux-2.6.18-vanilla/net/ipv6

[PATCH 02/02 V3] net/ipv6: seperate sit driver to extra module (addrconf.c changes)

2006-10-10 Thread Joerg Roedel
This patch contains the changes to net/ipv6/addrconf.c to remove sit specific code if the sit driver is not selected. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH 01/02 V2] net/ipv6: seperate sit driver to extra module

2006-10-10 Thread Joerg Roedel
On Mon, Oct 09, 2006 at 09:38:56PM -0700, David Miller wrote: > Joerg, when you make resubmissions, please always restate the full > changelog and all signed-off-by lines. > > If you want to say "Changed since last version" do that seperately > at the top of the email, right before the main change

[PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-10-10 Thread Joerg Roedel
This patch removes the driver of the IPv6-in-IPv4 tunnel driver (sit) from the IPv6 module. It adds an option to Kconfig which makes it possible to compile it as a seperate module. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -upr -X linux-2.6.18/Documentation/dontdiff linux-2.6.18-vanill

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-10 Thread Michael S. Tsirkin
Quoting r. Stephen Hemminger <[EMAIL PROTECTED]>: > Subject: Re: Dropping NETIF_F_SG since no checksum feature. > > On Mon, 9 Oct 2006 19:47:05 +0200 > "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote: > > > Hi! > > I'm trying to build a network device driver supporting a very large MTU > > (aroun

Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag

2006-10-10 Thread Michael Wu
On Tuesday 10 October 2006 09:45, David Kimdon wrote: > On Tue, Oct 10, 2006 at 12:00:12PM +0200, Michael Buesch wrote: > > On Monday 09 October 2006 19:03, David Kimdon wrote: > > > This flag is unused by all in tree drivers. Furthermore, the way that > > > it is documented is not consistent with

Re: [patch 5/5] d80211: allow wireless vlan interface to havesameMAC an AP interface

2006-10-10 Thread Johannes Berg
On Tue, 2006-10-10 at 06:42 -0700, David Kimdon wrote: > no, still broadcasts, but in a typical deployment some for of encryption > is used. Each vlan has a unique broadcast key so stations on one vlan > cannot decrypt packets from another vlan. Oh ok, that makes sense. Thanks. johannes - To u

Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag

2006-10-10 Thread David Kimdon
On Tue, Oct 10, 2006 at 12:00:12PM +0200, Michael Buesch wrote: > On Monday 09 October 2006 19:03, David Kimdon wrote: > > This flag is unused by all in tree drivers. Furthermore, the way that > > it is documented is not consistent with the way it is actually used by > > ieee80211.c. The original

Re: bcm43xx scan oops!!!

2006-10-10 Thread Jory A. Pratt
Michael Buesch wrote: On Tuesday 10 October 2006 05:14, Jory A. Pratt wrote: http://home.nctv.com/anarchy/dscape-clean.jpg That's hardly readable. But which firmware are you running? v4.x by chance? No that is version 3.x. - To unsubscribe from this list: send the line "unsubscrib

Re: [patch 5/5] d80211: allow wireless vlan interface to havesameMAC an AP interface

2006-10-10 Thread David Kimdon
On Tue, Oct 10, 2006 at 12:50:27PM +0200, Johannes Berg wrote: > On Mon, 2006-10-09 at 14:38 -0700, Jouni Malinen wrote: > > > Yes, I just merged in support for this (dynamic VLANs) into hostapd. > > RADIUS Access-Accept is used select VLAN is being used and the STA is > > bound at that point to a

Re: [patch 5/5] d80211: allow wireless vlan interface to have sameMAC an AP interface

2006-10-10 Thread Johannes Berg
On Mon, 2006-10-09 at 14:38 -0700, Jouni Malinen wrote: > Yes, I just merged in support for this (dynamic VLANs) into hostapd. > RADIUS Access-Accept is used select VLAN is being used and the STA is > bound at that point to another virtual interface, if needed. Different question. How do broadcas

Re: bcm43xx scan oops!!!

2006-10-10 Thread Michael Buesch
On Tuesday 10 October 2006 05:14, Jory A. Pratt wrote: > http://home.nctv.com/anarchy/dscape-clean.jpg That's hardly readable. But which firmware are you running? v4.x by chance? -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag

2006-10-10 Thread Michael Buesch
On Monday 09 October 2006 19:03, David Kimdon wrote: > This flag is unused by all in tree drivers. Furthermore, the way that > it is documented is not consistent with the way it is actually used by > ieee80211.c. The original attempt appears to be something to do with > adding extra header room f