[PATCH] Fix for IPsec leakage with SELinux enabled

2006-09-30 Thread James Morris
Please review this patch carefully. It addresses a couple of issues. When a security module is loaded (in this case, SELinux), the security_xfrm_policy_lookup() hook can return an access denied permission (or other error). We were not handling that correctly, and in fact inverting the return

[PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-09-30 Thread Ismail Donmez
This time with correct description too, *sigh* With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns true when the node is empty as expected. Hence Patrick McHardy's fix for sched_htb.c should be reverted. [1] http://www.kernel.org/git/?p=lin

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-09-30 Thread Ismail Donmez
On Sunday 01 October 2006 04:52, Herbert Xu wrote: > On Sat, Sep 30, 2006 at 10:23:46PM +0300, Ismail Donmez wrote: > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > > changed behaviour so it returns false when the node is empty as expected. > > Hence Herbert's fix for

netdev-2.6.git frozen

2006-09-30 Thread Jeff Garzik
Similar to David's recent announcement, netdev-2.6.git is now closed to new features. Though really, [my fault] I should have posted this as soon as the merge window opened. The stuff that goes into each new release, when the merge window opens, should be stuff that has already been through a

Re: netdev-2.6.git frozen

2006-09-30 Thread Jeff Garzik
Jeff Garzik wrote: Similar to David's recent announcement, netdev-2.6.git is now closed to new features. Though really, [my fault] I should have posted this as soon as the merge window opened. The stuff that goes into each new release, when the merge window opens, should be stuff that has al

[patch 2/2] bluetooth: use GFP_ATOMIC in *_sock_create's sk_alloc

2006-09-30 Thread akpm
From: Frederik Deweerdt <[EMAIL PROTECTED]> I think that the bluetooth-guard-bt_proto-with-rwlock.patch introduced the following BUG: [ 43.232000] BUG: sleeping function called from invalid context at mm/slab.c:2903 [ 43.232000] in_atomic():1, irqs_disabled():0 [ 43.232000] [] show_trace_

[patch 1/2] bluetooth: guard bt_proto with rwlock

2006-09-30 Thread akpm
From: Masatake YAMATO <[EMAIL PROTECTED]> I found that bt_proto manipulated in bt_sock_register is not guarded from race condition. Look at net/bluetooth/af_bluetooth.c: static struct net_proto_family *bt_proto[BT_MAX_PROTO]; int bt_sock_register(int proto, struct net_proto_family *ops)

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-09-30 Thread Herbert Xu
On Sat, Sep 30, 2006 at 10:23:46PM +0300, Ismail Donmez wrote: > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > changed behaviour so it returns false when the node is empty as expected. > Hence Herbert's fix for sched_htb.c should be reverted. I've fixed sched_htb

Re: [PATCH 0/3] myri10ge Large Receive Offload

2006-09-30 Thread Brice Goglin
Evgeniy Polyakov a écrit : > On Sat, Sep 30, 2006 at 12:16:44AM +0200, Brice Goglin ([EMAIL PROTECTED]) > wrote: > >> Jeff Garzik a écrit : >> >>> Brice Goglin wrote: >>> The complete driver code in our CVS actually also supports high-order allocations instead of single ph

Re: [BUG 2.6.18] unaligned access in ipvv6_rcv, nf_ip6_checksum, tcp_error, __ipv6_addr_type, fib6_lookup_1

2006-09-30 Thread David Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Sat, 30 Sep 2006 22:20:40 +0200 > Kernel unaligned access at TPC[10022cf0] ipv6_rcv+0xb8/0x320 [ipv6] > Kernel unaligned access at TPC[10023800] __ipv6_addr_type+0x8/0x140 [ipv6] > Kernel unaligned access at TPC[1002fd64] fib6_lookup_1+0x2c/0x120 [ipv6]

[BUG 2.6.18] unaligned access in ipvv6_rcv, nf_ip6_checksum, tcp_error, __ipv6_addr_type, fib6_lookup_1

2006-09-30 Thread Harald Welte
Hi! I've just built 2.6.18 on a sparc64 box (Ultra 5) using gcc-3.3.5 (debian woody). After booting the kernel, I get tons of unaligned access messages related to various bits of the IPv6 code: Kernel unaligned access at TPC[10022cf0] ipv6_rcv+0xb8/0x320 [ipv6] Kernel unaligned access at TPC[100

Re: 2.6.18-mm2

2006-09-30 Thread Andrew Morton
On Sat, 30 Sep 2006 15:37:06 +0200 Tobias Diedrich <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > > - More updates to the MSI code. If your machine has Message Signalled > > Interrupts, please enable it and give it a try. > > I'm happy to report, that with 2.6.18-mm2 suspend to disk wo

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-09-30 Thread Ismail Donmez
On Saturday 30 September 2006 22:23, you wrote: > Hi, > > With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE > changed behaviour so it returns false when the node is empty as expected. ^ make it : so it return

[PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-09-30 Thread Ismail Donmez
Hi, With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns false when the node is empty as expected. Hence Herbert's fix for sched_htb.c should be reverted. [1] http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-30 Thread Michael Chan
On Sat, 2006-09-30 at 12:13 +0200, Brice Goglin wrote: > What if the machine has such a bridge and board, but the board is not > actually located somewhere behind the bridge? I would rather walk the > PCI hierarchy from the board to the top and check whether we find a > AMD8132. Probably something

[NET_SCHED]: Remove old estimator implementation

2006-09-30 Thread Patrick McHardy
[NET_SCHED]: Remove old estimator implementation Remove unused file, estimators live in net/core/gen_estimator.c now. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 45cb5c100bbb42077eaab1ad6da7976bbe627603 tree e701f213eb170a3ceafbb17c807461b9b821f827 parent bf603625660b1742004bf8

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-30 Thread James Morris
On Sat, 30 Sep 2006, Evgeniy Polyakov wrote: > On Sat, Sep 30, 2006 at 10:36:29AM -0400, James Morris ([EMAIL PROTECTED]) > wrote: > > On Sat, 30 Sep 2006, Evgeniy Polyakov wrote: > > > > > I need to cofirm that broken system in my setup does have selinux enabled > > > with enforcing mode. > >

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-30 Thread Evgeniy Polyakov
On Sat, Sep 30, 2006 at 06:40:18PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Sat, Sep 30, 2006 at 10:36:29AM -0400, James Morris ([EMAIL PROTECTED]) > wrote: > > On Sat, 30 Sep 2006, Evgeniy Polyakov wrote: > > > > > I need to cofirm that broken system in my setup does have selinux

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-30 Thread Evgeniy Polyakov
On Sat, Sep 30, 2006 at 10:36:29AM -0400, James Morris ([EMAIL PROTECTED]) wrote: > On Sat, 30 Sep 2006, Evgeniy Polyakov wrote: > > > I need to cofirm that broken system in my setup does have selinux enabled > > with enforcing mode. > > I've changed it to permissive mode and it fixed setup (I d

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-30 Thread James Morris
On Sat, 30 Sep 2006, Evgeniy Polyakov wrote: > I need to cofirm that broken system in my setup does have selinux enabled > with enforcing mode. > I've changed it to permissive mode and it fixed setup (I do not see any > warnings in dmesg). Something better in your case would likely be to rebuil

Re: [PATCH 0/3] myri10ge Large Receive Offload

2006-09-30 Thread Brice Goglin
Brice Goglin a écrit : > Could we get patch #1 merged anyway (page-based skb allocation)? > Oops, actually, one hunk has to be dropped (it reverts const'ification of ethtool_ops by mistake). If it is ok to merge the patch apart from this hunk, will resend an updated patch. Brice - To unsubsc

/proc/net/tcp6 missing entries

2006-09-30 Thread James Cloos
Has anything changed recently that would affect /ptoc/net/tcp6? None of the outgoing tcp/ip6 sockets show up there on my laptop. I'm currently at Linus' tree as of f164c42161d21368d9cd4d6d6efc158baa2618db with the then-upstream branch of libata (since merged into Linus' tree) and Ingo's 18-rt3 pa

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-30 Thread Evgeniy Polyakov
On Sat, Sep 30, 2006 at 01:14:27AM -0400, James Morris ([EMAIL PROTECTED]) wrote: > On Sat, 30 Sep 2006, James Morris wrote: > > > I've just seen something similar and can recreate it with static keying > > via setkey. > > It's SELinux related. Things work when the one system in this setup wit

[PATCH 2.6.18] 8139too: force media setting cleanup

2006-09-30 Thread Bernard Lee
From: Bernard Lee <[EMAIL PROTECTED]> Setting bit 4 & 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4 & 5 to take effect. The hi

Re: [PATCH] tcp-lp: prevent chance for oops

2006-09-30 Thread Wong Edison
oic i learn it and will change it in coming on version On 9/30/06, David Miller <[EMAIL PROTECTED]> wrote: From: "Wong Edison" <[EMAIL PROTECTED]> Date: Sat, 30 Sep 2006 03:27:00 +0800 > I do this since i have a sourceforge homepage for it. I update the > CVS version there, test, and then submi

Re: [PATCH 0/6]: powerpc/cell spidernet ethernet patches

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:05 schrieb Linas Vepstas: > Although these patches have not been baking in > any -mm tree, they have been tested and are > generally available as a part of the Cell SDK 2.0 > overseen by Arnd Bergmann. (Arnd, if you want > to lend a voice of authority here, or to co

Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:21 schrieb Linas Vepstas: > This patch adds version information as reported by > ethtool -i to the Spidernet driver. > > From: James K Lewis <[EMAIL PROTECTED]> > Signed-off-by: James K Lewis <[EMAIL PROTECTED]> > Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> > C

Re: [PATCH 5/6]: powerpc/cell spidernet ethtool -i version number

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:26 schrieb Linas Vepstas: > This patch moves transmit queue cleanup code out of the > interrupt context, and into the NAPI polling routine. > > Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> > Cc: James K Lewis <[EMAIL PROTECTED]> > Cc: Arnd Bergmann <[EMAIL PROTE

Re: [PATCH 3/6]: powerpc/cell spidernet stop error printing patch.

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:19 schrieb Linas Vepstas: > Turn off mis-interpretation of the queue-empty interrupt > status bit as an error. This bit is set as a part of > the previous low-watermark patch. > > Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> > Signed-off-by: James K Lewis <[EMAI

Re: [PATCH 1/6]: powerpc/cell spidernet burst alignment patch.

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:15 schrieb Linas Vepstas: > This patch increases the Burst Address alignment from 64 to 1024 in the > Spidernet driver. This improves transmit performance for large packets. > > From: James K Lewis <[EMAIL PROTECTED]> > Signed-off-by: James K Lewis <[EMAIL PROTECTED

Re: [PATCH 2/6]: powerpc/cell spidernet low watermark patch.

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:17 schrieb Linas Vepstas: > Implement basic low-watermark support for the transmit queue. > Hardware low-watermarks allow a properly configured kernel > to continously stream data to a device and not have to handle > any interrupts at all in doing so. Correct zero-i

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-30 Thread Brice Goglin
Michael Chan a écrit : > AMD believes this incompatibility is unique to the 5706, and > prefers to locally disable MSI rather than globally disabling it > using pci_msi_quirk. > FYI, pci_msi_quirk is the extreme solution, there is something in the middle :) It is possible to disable MSI for onl

Re: [PATCH 0/3] myri10ge Large Receive Offload

2006-09-30 Thread Evgeniy Polyakov
On Sat, Sep 30, 2006 at 12:16:44AM +0200, Brice Goglin ([EMAIL PROTECTED]) wrote: > Jeff Garzik a écrit : > > Brice Goglin wrote: > >> This is a complete rework of the myri10ge receive path. The first > >> patch converts skb allocation to use physical pages. The second one > >> adds a software imp

Re: Makefile for linux modules

2006-09-30 Thread Sam Ravnborg
Hi Robert. >I have a makefielt to make several driver modules: > obj-$(CONFIG_FUSION_SPI) += mptbase.o mptscsih.o > mptspi.o > obj-$(CONFIG_FUSION_FC) += mptbase.o mptscsih.o > mptfc.o > obj-m += mptbase.o mptscsih.o mptsas.o > obj-$(CONFIG_FUSION_LAN

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-30 Thread Andrew Morton
On Sat, 30 Sep 2006 03:50:43 -0400 [EMAIL PROTECTED] wrote: > On Fri, 29 Sep 2006 23:31:07 EDT, [EMAIL PROTECTED] said: > > Fair enough, I'm going to try reverting the 2 commits and see if things > > behave better. > > OK, it's definitely something in those 2 commits - I reverted them and the >

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-30 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 23:31:07 EDT, [EMAIL PROTECTED] said: > Fair enough, I'm going to try reverting the 2 commits and see if things > behave better. OK, it's definitely something in those 2 commits - I reverted them and the resulting 2.6.18-mm2 kernel has been up and stable for 4 hours, even with

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-30 Thread James Morris
On Sat, 30 Sep 2006, James Morris wrote: > SELinux enabled is changed to permissive mode. Ok, in the case where unencrypted packets are leaking, the problem is that xfrm_lookup() is returning a false zero on a polmatch denial like: avc: denied { polmatch } for scontext=system_u:system_r:f

[IPROUTE2][PATCH] Add missing macros which was removed from kernel header. (Re: [GIT PATCH] NET: Fixes for net-2.6.19)

2006-09-30 Thread Masahide NAKAMURA
> David Miller wrote: > >> commit 0844565fb8a9418f5a860aa480c1aef70319c9a2 > >> Author: Thomas Graf <[EMAIL PROTECTED]> > >> Date: Fri Aug 4 23:05:56 2006 -0700 > >> > >> [NET]: Move netlink interface bits to linux/if.h > >> > >> Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> > >>