Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Johannes Berg
On Thu, 2006-08-31 at 19:57 +0200, Michael Buesch wrote: > It is. Nobody says different. I think with "mainline" Johannes meant > the wireless-dev tree. Merging nl80211 with softmac would indeed not > make sense to me, too. Actually, I do say different. I want softmac to be a consumer of nl80211

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Johannes Berg
On Thu, 2006-08-31 at 10:12 -0700, Jean Tourrilhes wrote: > And I strongly disagree with your disagrement ;-) You're of course free to do that :) But let me explain. > I'm sorry to say it like this, but I hope my work will not be > impacted by vaporware. How many drivers are currentl

Re: [GENL]: Provide more information to userspace about registered genl families

2006-08-31 Thread Johannes Berg
On Thu, 2006-08-31 at 17:46 -0400, jamal wrote: > I think it would be valuable to specify a set of flags for filtering > what gets sent to user space instead of unconditionally. > > Example, > filter level 0: > - what we have before your patch > filter level 1: > - protocol version > - hea

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-08-31 Thread Johannes Berg
On Fri, 2006-09-01 at 11:37 +0800, Hong Liu wrote: > > + local->sta_scanning = 1; > + if (local->hw->hw_scan) > + return local->hw->hw_scan(dev, ssid, ssid_len); > + My question still stands, is it proper to assign sta_scanning to 1 even if the function returns an error? joh

Re: high latency with TCP connections

2006-08-31 Thread David Miller
From: "Ian McDonald" <[EMAIL PROTECTED]> Date: Fri, 1 Sep 2006 15:39:37 +1200 > > > I'm ready to rip out ABC entirely, to be honest. Or at least > > > turn it off by default. > > > > Turn it off for 2.6.18, by default then evaluate more for 2.6.19 > > > If it goes out in 2.6.18 there could probab

[PATCH] xfrm: remove xerr_idxp from __xfrm_policy_check()

2006-08-31 Thread James Morris
It seems that during the MIPv6 respin, some code which was originally conditionally compiled around CONFIG_XFRM_ADVANCED was accidently left in after the config option was removed. This patch removes an extraneous pointer (xerr_idxp) which is no longer needed. Please review & apply. Signed-of

Re: LRO fix needed

2006-08-31 Thread Herbert Xu
On Fri, Sep 01, 2006 at 09:43:47AM +1000, herbert wrote: > > It might be better to set it to the biggest frag you see rather > than the first. I've coded it up. BTW Ananda, what hardware assistance do your chips currently provide for LRO? What are the timeouts used before it gives up on aggregat

Re: [RFC][IPSEC]: tunnel mode processing

2006-08-31 Thread Herbert Xu
On Thu, Aug 31, 2006 at 08:55:27PM -0400, jamal wrote: > > Would it be reasonable to do a check so that incase a skb->dst doesnt > exist, the inner headers values can be used i.e something along > xfrm4_tunnel_output():: If you didn't care what values they were, couldn't you just stuff some bogu

Re: [PATCH]d80211: fix "iwconfig key [x]" behavior

2006-08-31 Thread Hong Liu
On Thu, 2006-08-31 at 01:24, Jiri Benc wrote: > On Mon, 28 Aug 2006 16:36:39 +0800, Hong Liu wrote: > > "iwconfig key [x]" behavior is not correctly handled in the stack, also > > modify the giwencode method to show the key info. > > Thanks for spotting and fixing these bugs! > > > @@ -2869,7 +28

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-08-31 Thread Hong Liu
On Thu, 2006-08-31 at 01:10, Jiri Benc wrote: > On Fri, 25 Aug 2006 16:32:13 +0800, Hong Liu wrote: > > Add hardware scan callback to support cards like ipw3945 which > > implements the scan command in firmware. > > How ipw3945 performs scan? From the patch, it looks like it switches > channels (a

Re: [PATCH 1/2]d80211: fix wpa_supplicant reassoc problem

2006-08-31 Thread Hong Liu
On Thu, 2006-08-31 at 00:57, Jiri Benc wrote: > On Fri, 25 Aug 2006 16:32:08 +0800, Hong Liu wrote: > > After key negotiation completed using wpa_supplicant, wpa_supplicant > > can't reassoc with the AP if we reboot the AP. It always fails at the > > 4-way handshake. > > The problem is the key info

Re: high latency with TCP connections

2006-08-31 Thread Ian McDonald
> I'm ready to rip out ABC entirely, to be honest. Or at least > turn it off by default. Turn it off for 2.6.18, by default then evaluate more for 2.6.19 If it goes out in 2.6.18 there could probably be a good argument for going into the stable tree as well... to stop the likes of the JVM type

Re: high latency with TCP connections

2006-08-31 Thread Stephen Hemminger
On Thu, 31 Aug 2006 16:57:01 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Alexey Kuznetsov <[EMAIL PROTECTED]> > Date: Fri, 1 Sep 2006 03:29:23 +0400 > > > > 2) a way to take delayed ACKs into account for cwnd growth > > > > This part is OK now, right? > > This part of ABC is not

Re: [PATCH] [XFRM] STATE: Fix flusing with hash mask.

2006-08-31 Thread Masahide NAKAMURA
David Miller wrote: Masahide-san, please provide a Signed-off-by: line in the future, even for simple changes like this one. OK, I'll :-) Regards, -- Masahide NAKAMURA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majord

[RFC][IPSEC]: tunnel mode processing

2006-08-31 Thread jamal
At the moment transport mode processing is not dependent on skb->dst being passed. Tunnel mode derives the ip->id and ttl from it. More like computes ip->id. I am trying to generate traffic via pktgen and it would be nice if i could get the same behavior on tunnel mode as in transport mode. I don

Re: [IPSEC]: output mode to take an xfrm state as input param

2006-08-31 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 20:29:36 -0400 > On Thu, 2006-31-08 at 17:24 -0700, David Miller wrote: > > Are you too cool to give "Signed-off-by:" lines? > > :-) > > > > Dang. Just too brain congested to give you one ;-> > > signed-off-by: Jamal Hadi Salim <[EMAIL PROT

Re: [IPSEC]: output mode to take an xfrm state as input param

2006-08-31 Thread jamal
On Thu, 2006-31-08 at 17:24 -0700, David Miller wrote: > Are you too cool to give "Signed-off-by:" lines? > :-) > Dang. Just too brain congested to give you one ;-> signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> cheers, jamal - To unsubscribe from this list: send the line "unsubscribe net

Re: [IPSEC]: output mode to take an xfrm state as input param

2006-08-31 Thread David Miller
Are you too cool to give "Signed-off-by:" lines? :-) Please give me one for this patch so I can add it to net-2.6.19 Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

[IPSEC]: output mode to take an xfrm state as input param

2006-08-31 Thread jamal
Against net-2.6.19 cheers, jamal Expose IPSEC modes output path to take an xfrm state as input param. This makes it consistent with the input mode processing (which already takes the xfrm state as a param). --- commit 0169ac1c2a64f04deeff3dae704f34e22ae59cb7 tree 8ae315bf21444eec3f845538ac0

Re: high latency with TCP connections

2006-08-31 Thread David Miller
From: Alexey Kuznetsov <[EMAIL PROTECTED]> Date: Fri, 1 Sep 2006 03:29:23 +0400 > > 2) a way to take delayed ACKs into account for cwnd growth > > This part is OK now, right? This part of ABC is not on by default, and was broken until last week :-) Test in tcp_slow_start() used to be:

Re: NAPI: netif_rx_reschedule() ??

2006-08-31 Thread Alexey Kuznetsov
Hello! > However I'm confused about a couple of things, and there are only two > uses of netif_rx_reschedule() in the kernel, so I'm a little stuck. First, do not believe to even single bit of code or docs about netif_rx_reschedule(). It was used once in the first version of NAPI for 3com driver

Re: LRO fix needed

2006-08-31 Thread Herbert Xu
On Thu, Aug 31, 2006 at 04:42:27PM -0700, David Miller wrote: > > So could you please make the S2io driver LRO path > set skb_shared_info(skb)->gso_size appropriately? > Probably the easiest is to use the length of the > first frag of a multiple frag LRO sequence. It might be better to set it to

LRO fix needed

2006-08-31 Thread David Miller
Ananda, Herbert Xu recently found a problem in the TCP stack input path for LRO capable receive paths. The issue is that the receive MSS estimator in tcp_measure_rcv_mss() uses skb->len for the MSS estimation. This is wrong for LRO frames. Herbert noticed this using Xen which pused TSO frames o

Re: [RFC] Enable/Disable VLAN HW filters

2006-08-31 Thread Ben Greear
Mitch Williams wrote: We've had a few internal requests for a way to enable and disable the hardware VLAN filter at runtime. I'm posting it here for discussion and to see if anybody else is interested in this feature. Originally I had planned to do this as an Ethtool ioctl, but decided instead

Re: high latency with TCP connections

2006-08-31 Thread Alexey Kuznetsov
Hello! > 2) a way to take delayed ACKs into account for cwnd growth This part is OK now, right? > 1) protection against ACK division But Linux never had this problem... Congestion window was increased only when a whole skb is ACKed, flag FLAG_DATA_ACKED. (TSO could break this, but should not).

[RFC] Wake-on-LAN flex filters

2006-08-31 Thread Mitch Williams
Most modern Ethernet hardware supports flexible filters for wake-on-LAN, probably because it's a requirement for certification with Another Operating System. This patch implements this feature on e1000 via Ethtool. The kernel portion of this code is fairly well polished, but the changes to the to

Re: RTL8136

2006-08-31 Thread Darren Salt
I demand that Francois Romieu may or may not have written... > Darren Salt <[EMAIL PROTECTED]> : > [...] >> The former. Without that, the connection is persistently re-negotiated >> (though, according to the switch's LEDs, it's fine before the module is >> loaded). > The state of the LEDs at star

[RFC] Enable/Disable VLAN HW filters

2006-08-31 Thread Mitch Williams
We've had a few internal requests for a way to enable and disable the hardware VLAN filter at runtime. I'm posting it here for discussion and to see if anybody else is interested in this feature. Originally I had planned to do this as an Ethtool ioctl, but decided instead to handle it through the

Re: high latency with TCP connections

2006-08-31 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 15:14:56 -0700 > On Fri, 1 Sep 2006 01:46:35 +0400 > Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > > > > Expecting any performance with one byte write's is silly. > > > > I am not sure why you are so confident about status of ABC

Re: [PATCH] fix sk->sk_filter field access

2006-08-31 Thread David Miller
From: Dmitry Mishin <[EMAIL PROTECTED]> Date: Wed, 30 Aug 2006 17:07:14 +0400 > Function sk_filter() is called from tcp_v{4,6}_rcv() functions with argue > needlock = 0, while socket is not locked at that moment. In order to avoid > this and similar issues in the future, use rcu for sk->sk_filte

Re: SNMPv2 "ipFragFails" counter error

2006-08-31 Thread David Miller
From: weidong <[EMAIL PROTECTED]> Date: Fri, 01 Sep 2006 10:39:35 -0400 > Hi, All > When I tested Linux kernel 2.6.17.7 about statistics > "ipFragFails",found that this counter couldn't increase correctly. The > criteria is RFC2011: > RFC2011 > ipFragFails OBJECT-TYPE > SYNTAX Counter

Re: [PATCH] rate limiting for socket allocation failure messages

2006-08-31 Thread David Miller
From: Akinobu Mita <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 18:59:21 +0900 > (Resending due to local mail server trouble) > > This patch limits the warning messages when socket allocation > failures happen. It happens under memory pressure. > > Cc: David Miller <[EMAIL PROTECTED]> > Signed-off

Re: [IPV6] MIP6: Fix to update IP6CB when cloned skbuff is received at HAO.

2006-08-31 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 21:05:41 +0900 > > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > > Date: Thu, 24 Aug 2006 00:02:24 +0900 > > > > > In receiving Mobile IPv6 home address option which is a TLV carried > > > by destination options header, kernel wil

Re: high latency with TCP connections

2006-08-31 Thread Stephen Hemminger
On Fri, 1 Sep 2006 01:46:35 +0400 Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: > Hello! > > > Expecting any performance with one byte write's is silly. > > I am not sure why you are so confident about status of ABC. > I missed the discussions, when it was implemented. Apparently, > it was noticed

Re: [PATCH] [XFRM] STATE: Fix flusing with hash mask.

2006-08-31 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 21:00:17 +0900 > This is a minor fix about transformation state flushing > for net-2.6.19. Please apply it. Thank you for finding this bug. Patch applied. Masahide-san, please provide a Signed-off-by: line in the future, even fo

Re: [TCP]: Fix rcv mss estimate for LRO

2006-08-31 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 23:18:33 +1000 > The Xen performance problem turned out to be something else altogether. > It was an incorrect rcv mss estimate which leads to delayed acks. So > it's not a bug in Linux yet :) However, since we need this for LRO as > wel

Re: [NET]: Fix typo causing wrong skb to be freed

2006-08-31 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 23:26:51 +0200 > A typo introduced by myself which leads to freeing the skb > containing the netlink message when it should free the newly > allocated skb for the reply. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thank

Re: [PATCH] change somaxconn sysctl to __read_mostly

2006-08-31 Thread David Miller
From: Brian Haley <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 16:35:33 -0400 > Change sysctl_somaxconn to __read_mostly. > > Signed-off-by: Brian Haley <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mo

Re: [PATCH] change max_dgram_qlen sysctl to __read_mostly

2006-08-31 Thread David Miller
From: Brian Haley <[EMAIL PROTECTED]> Date: Thu, 31 Aug 2006 16:35:37 -0400 > Change AF_UNIX sysctl_unix_max_dgram_qlen to __read_mostly. > > Signed-off-by: Brian Haley <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [E

Re: NAPI: netif_rx_reschedule() ??

2006-08-31 Thread jamal
On Thu, 2006-31-08 at 14:29 -0700, Stephen Hemminger wrote: > On Wed, 30 Aug 2006 16:39:14 -0700 > Roland Dreier <[EMAIL PROTECTED]> wrote: > > > Roland> makes sense -- especially since the caller probably also > > Roland> deducted N from *budget, and netif_rx_reschedule() doesn't > >

Re: [PATCH 00/26] e100, e1000, ixgb updates

2006-08-31 Thread Jeff Garzik
pulled into #upstream, thanks - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: high latency with TCP connections

2006-08-31 Thread Alexey Kuznetsov
Hello! > Expecting any performance with one byte write's is silly. I am not sure why you are so confident about status of ABC. I missed the discussions, when it was implemented. Apparently, it was noticed that ABC in its pure form does not make sense with snd_cwnd counted in packets and there wer

Re: [GENL]: Provide more information to userspace about registered genl families

2006-08-31 Thread jamal
Useful stuff. There are things along these lines that i have been contemplating myself. I think it would be valuable to specify a set of flags for filtering what gets sent to user space instead of unconditionally. Example, filter level 0: - what we have before your patch filter level 1: - p

Re: NAPI: netif_rx_reschedule() ??

2006-08-31 Thread Stephen Hemminger
On Wed, 30 Aug 2006 16:39:14 -0700 Roland Dreier <[EMAIL PROTECTED]> wrote: > Roland> makes sense -- especially since the caller probably also > Roland> deducted N from *budget, and netif_rx_reschedule() doesn't > Roland> touch that. > > Actually, why does undoing the change to quota

Re: [PATCH 0/7] 8139cp: misc minor changes

2006-08-31 Thread Pierre Ossman
Ehm... why am I included in this? :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/26] e100, e1000, ixgb updates

2006-08-31 Thread Auke Kok
Jeff, I have adjusted several things in our queue after comments. Here is a summary of those changes against the original summary. These changes are available through git. Please pull: git pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream (against netdev-2.6#upstream 699a7123

[NET]: Fix typo causing wrong skb to be freed

2006-08-31 Thread Thomas Graf
A typo introduced by myself which leads to freeing the skb containing the netlink message when it should free the newly allocated skb for the reply. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19/net/core/rtnetlink.c ==

Re: [PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-31 Thread Auke Kok
Brandeburg, Jesse wrote: Jeff Garzik wrote: Kok, Auke wrote: Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 and ethtool has this functionality in working order. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> This doesn't "deprec

[GENL]: Provide more information to userspace about registered genl families

2006-08-31 Thread Thomas Graf
Additionaly exports the following information when providing the list of registered generic netlink families: - protocol version - header size - maximum number of attributes - list of available operations including - id - flags - avaiability of policy and doit/dumpit funct

Re: high latency with TCP connections

2006-08-31 Thread Ian McDonald
The word performance in this list seems to always mean 'throughput'. It seems though that there could be some knob to tweak for those of us who don't care so much about throughput but care a great deal about latency. SCTP has been mentioned. There is also DCCP - http://www.read.cs.ucla.edu/dccp/

Re: RTL8136

2006-08-31 Thread Francois Romieu
Darren Salt <[EMAIL PROTECTED]> : [...] > The former. Without that, the connection is persistently re-negotiated > (though, according to the switch's LEDs, it's fine before the module is > loaded). The state of the LEDs at startup is not necessarily significant (it can come from the eeprom). I ha

[PATCH 7/7] 8139cp: use PCI_DEVICE() to shorten the PCI device table

2006-08-31 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/8139cp.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) cccb20d3a9b7c6d4b6e1b52ee02814e6094aaa12 diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index a123d28..bbdaa18 100644 --- a/drivers/net/8139cp.c

[PATCH 6/7] 8139cp: pci_get_drvdata(pdev) can not be NULL in suspend handler

2006-08-31 Thread Francois Romieu
1) pci_set_drvdata() is used in cp_{init/remove}_one to initialize/reset driver_data to the relevant value (resp. net_device * and NULL). 2) each of the 3 relevant functions is issued under (device *)->sem: 2.1) pci_unregister_driver -> driver_unregister -> bus_remove_driv

[PATCH 3/7] 8139cp: ring_info removal for the receive path

2006-08-31 Thread Francois Romieu
The ring_info.len field is not used at all. cp_private.rx_skb is turned into an array of sk_buff *. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/8139cp.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) 0ba894d420b845667e2981c2147af974a755fba2 diff

[PATCH 2/7] 8139cp: remove gratuitous indirection

2006-08-31 Thread Francois Romieu
dev is an argument of the current function. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/8139cp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) c48e9399e895834f26dff9149de1930ba18a0d6c diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index 8f5d779.

[PATCH 4/7] 8139cp: sync the device private data with its r8169 counterpart

2006-08-31 Thread Francois Romieu
struct cp_private is reorganized to be more easily compared between the r8169 and the 8139cp drivers. The alignment should not be impacted. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/8139cp.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) d03d376

[PATCH 1/7] 8139cp: trim ring_info

2006-08-31 Thread Francois Romieu
Fat removal: the mapping address is available from the Rx/Tx descriptors. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/8139cp.c | 33 - 1 files changed, 16 insertions(+), 17 deletions(-) 3598b57be449a2ee9178e5c511bdb1a8aaccba20 diff --git

[PATCH 5/7] 8139cp: removal of useless BUG_ON() check

2006-08-31 Thread Francois Romieu
netdev_priv() will provide a nice oops a few lines before the BUG_ON() check. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/8139cp.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) e68970e7543815133224f79a858e7c9e0c42f4de diff --git a/drivers/net/8139cp.c b/driv

[PATCH 0/7] 8139cp: misc minor changes

2006-08-31 Thread Francois Romieu
The serie contains the patches summarized below: - 1/7 trim ring_info - 2/7 remove gratuitous indirection - 3/7 ring_info removal for the receive path - 4/7 sync the device private data with its r8169 counterpart - 5/7 removal of useless BUG_ON() check - 6/7 pci_get_drvdata(pdev) can not be NULL in

[PATCH] change max_dgram_qlen sysctl to __read_mostly

2006-08-31 Thread Brian Haley
Change AF_UNIX sysctl_unix_max_dgram_qlen to __read_mostly. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 7c91c20..b43a278 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -117,7 +117,7 @@ #include #include -int sysctl_u

[PATCH] change somaxconn sysctl to __read_mostly

2006-08-31 Thread Brian Haley
Change sysctl_somaxconn to __read_mostly. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/socket.c b/net/socket.c index f4d143c..e3d67fe 100644 --- a/net/socket.c +++ b/net/socket.c @@ -1336,7 +1336,7 @@ asmlinkage long sys_bind(int fd, struct * ready for listening. */ -int

Re: high latency with TCP connections

2006-08-31 Thread Rick Jones
Kelly Burkhart wrote: On 8/30/06, David Miller <[EMAIL PROTECTED]> wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> > Expecting any performance with one byte write's is silly. This is absolutely true. TCP_NODELAY can only save you when you are sending a small amount of data "in aggregate",

Re: Probably e1000 related Oops in 2.6.18-rc5

2006-08-31 Thread Auke Kok
Krzysztof Oledzki wrote: Hello, My testing workstation running 2.6.18-rc5 Oopsed. It has a dualport e1000 card with bonding and vlans. All I have is three fotos made by a digital camera: http://www.ans.pl/Oops/1/ Hope it is enough. unfortunately the top of the OOPS is gone, and bonding+v

Re: high latency with TCP connections

2006-08-31 Thread Kelly Burkhart
On 8/30/06, David Miller <[EMAIL PROTECTED]> wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> > Expecting any performance with one byte write's is silly. This is absolutely true. TCP_NODELAY can only save you when you are sending a small amount of data "in aggregate", such as in an SSH or tel

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Michael Buesch
On Thursday 31 August 2006 19:12, Jean Tourrilhes wrote: > On Thu, Aug 31, 2006 at 03:32:18PM +0200, Johannes Berg wrote: > > On Tue, 2006-08-29 at 17:56 -0700, Jean Tourrilhes wrote: > > > o modulation > > > o long/short retry > > > o relative power saving. > > > > I

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 03:32:18PM +0200, Johannes Berg wrote: > On Tue, 2006-08-29 at 17:56 -0700, Jean Tourrilhes wrote: > > o modulation > > o long/short retry > > o relative power saving. > > I strongly disagree to these. And I strongly disagree wit

Probably e1000 related Oops in 2.6.18-rc5

2006-08-31 Thread Krzysztof Oledzki
Hello, My testing workstation running 2.6.18-rc5 Oopsed. It has a dualport e1000 card with bonding and vlans. All I have is three fotos made by a digital camera: http://www.ans.pl/Oops/1/ Hope it is enough. Best regards, Krzysztof Olędzki

Re: [PATCH] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 09:57:45AM -0400, John W. Linville wrote: > On Thu, Aug 31, 2006 at 08:22:22AM -0500, Larry Finger wrote: > > > John, have you merged, or do you plan to merge, "[PATCH 2.6.18] WE-21 > > support (core API)" into > > wireless-2.6? > > I guess that is still up for discussion

Re: [PATCH 2.6.18] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 03:09:04PM +0200, Johannes Berg wrote: > Jean, > > > This is the version of the patch for out-of-tree, I guess you > > will need it. Not tested. > > We don't, neither softmac nor bcm43xx is maintained out-of-tree any > more. > > johannes Cool. I should have c

Re: high latency with TCP connections

2006-08-31 Thread Sridhar Samudrala
Alexander Vodomerov wrote: On Wed, Aug 30, 2006 at 02:39:55PM -0700, David Miller wrote: Expecting any performance with one byte write's is silly. This is absolutely true. TCP_NODELAY can only save you when you are sending a small amount of data "in aggregate", such as in an SSH or t

Re: Unable to halt or reboot due to - unregister_netdevice: waiting for eth0.20 to become free. Usage count = 1

2006-08-31 Thread Jesper Juhl
On 31/08/06, Ben Greear <[EMAIL PROTECTED]> wrote: Jesper Juhl wrote: > Hi, > > I've got a small problem with 2.6.18-rc5-git2. > > I've got a vlan setup on eth0.20, eth0 does not have an IP. > > When I attempt to reboot or halt the machine I get the following > message from the loop in net/core/d

Re: Unable to halt or reboot due to - unregister_netdevice: waiting for eth0.20 to become free. Usage count = 1

2006-08-31 Thread Ben Greear
Jesper Juhl wrote: Hi, I've got a small problem with 2.6.18-rc5-git2. I've got a vlan setup on eth0.20, eth0 does not have an IP. When I attempt to reboot or halt the machine I get the following message from the loop in net/core/dev.c::netdev_wait_allrefs() where it waits for the ref-count to

Unable to halt or reboot due to - unregister_netdevice: waiting for eth0.20 to become free. Usage count = 1

2006-08-31 Thread Jesper Juhl
Hi, I've got a small problem with 2.6.18-rc5-git2. I've got a vlan setup on eth0.20, eth0 does not have an IP. When I attempt to reboot or halt the machine I get the following message from the loop in net/core/dev.c::netdev_wait_allrefs() where it waits for the ref-count to drop to zero. Unfort

RE: [PATCH 0/3] secid reconciliation-v01: Repost patchset with up dates

2006-08-31 Thread Venkat Yekkirala
> Assuming the permission is granted the packet's secmark is > replaced with > the updated context. This updated secmark context would then > be used in > sock_rcv_skb() to make an access decision, yes? You got it. > > >> The ability to make access decisions based on the process > >>consuming

Re: PROBLEM: kernel BUG at net/ipv6/ip6_output.c:718

2006-08-31 Thread cagri coltekin
Hi Again, It took a while to find equipment for test environment, but now I have a test environment that I can test. Here is the result: --- [17180051.768000] ip6_fragment: hlen = 0x818, len = 0x7ce, nexthdr=4 [17180051.8400

Re: IPSec kernel oops on ppc64

2006-08-31 Thread Joy Latten
It works! I applied the patch to linux-2.6.17 + patch-2.6.17-rc1 and tried icmp, tcp and udp as well as sftp with ipsec and they all worked. Thanks Regards, Joy >Herbert Xu writes: > >> Interesting. We were previously off by 28 bytes, now we're off by 8 :) > >You missed a couple of 'beql

[PATCH] Wireless-2.6 changes for bcm43xx and SoftMAC for WE-21

2006-08-31 Thread Larry Finger
John, As discussed earlier, here is the wireless-2.6 patch for WE-21 in bcm43xx-softmac. The core patch for the SSID length, which I believe is non-controversial, must be applied first. Larry -- Patch to make bcm43xx-softmac be compatible w

Re: [PATCH 0/3] secid reconciliation-v01: Repost patchset with up dates

2006-08-31 Thread Paul Moore
Venkat Yekkirala wrote: >>My main concern with these patches is that moving the >>NetLabel check out >>of selinux_socket_sock_rcv_skb() and into >>selinux_skb_policy_check() (as >>it is currently written) would force us to compare a packet's NetLabel >>with either the IPsec label or the secmark l

[RFC][PATCH] Add netpoll/netconsole support to vlan devices

2006-08-31 Thread Jesper Juhl
Greetings, I recently tried running netconsole via a vlan interface without luck, and decided to do something about it (see patch below). My interfaces look like this: eth0 Link encap:Ethernet HWaddr 00:14:5E:28:3C:2E UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1

[PATCH 2.6.17 9/9] NetXen: CRB reg definitions

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/drivers/net/netxen/netxen_nic_phan_reg.h linux-2.6.17/drivers/net/netxen/netxen_nic_phan_reg.h --- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_phan_reg.h 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.17/drivers/n

[PATCH 2.6.17 8/9] NetXen: Header file and ioctl header file

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hdr.h linux-2.6.17/drivers/net/netxen/netxen_nic_hdr.h --- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hdr.h 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.17/drivers/net/netxen/

[PATCH 2.6.17 7/9] NetXen: hw access routines header file

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.h linux-2.6.17/drivers/net/netxen/netxen_nic_hw.h --- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.h1969-12-31 16:00:00.0 -0800 +++ linux-2.6.17/drivers/net/netxen/ne

[PATCH 2.6.17 6/9] NetXen: Main header file

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/drivers/net/netxen/netxen_nic.h linux-2.6.17/drivers/net/netxen/netxen_nic.h --- linux-2.6.17.orig/drivers/net/netxen/netxen_nic.h 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.17/drivers/net/netxen/netxen_nic.h

[PATCH 2.6.17 5/9] NetXen: ethtool interface

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/drivers/net/netxen/netxen_nic_ethtool.c linux-2.6.17/drivers/net/netxen/netxen_nic_ethtool.c --- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_ethtool.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.17/drivers/net

[PATCH 2.6.17 4/9] NetXen: intr routines and niu handling

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/drivers/net/netxen/netxen_nic_isr.c linux-2.6.17/drivers/net/netxen/netxen_nic_isr.c --- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_isr.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.17/drivers/net/netxen/

[PATCH 2.6.17 3/9] NetXen: hw initialization routines

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/drivers/net/netxen/netxen_nic_init.c linux-2.6.17/drivers/net/netxen/netxen_nic_init.c --- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_init.c 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.17/drivers/net/netxe

[PATCH 2.6.17 2/9] NetXen: Hardware access routines

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.c linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c --- linux-2.6.17.orig/drivers/net/netxen/netxen_nic_hw.c1969-12-31 16:00:00.0 -0800 +++ linux-2.6.17/drivers/net/netxen/ne

[PATCH 2.6.17 1/9] NetXen: Makefile and driver main file

2006-08-31 Thread Amit S. Kale
diff -Narup -X linux-2.6.17.orig/Documentation/dontdiff linux-2.6.17.orig/MAINTAINERS linux-2.6.17/MAINTAINERS --- linux-2.6.17.orig/MAINTAINERS 2006-08-30 06:51:57.0 -0700 +++ linux-2.6.17/MAINTAINERS2006-08-30 06:56:27.0 -0700 @@ -1987,6 +1987,13 @@ L: netdev@vge

RE: [PATCH 0/3] secid reconciliation-v01: Repost patchset with up dates

2006-08-31 Thread Venkat Yekkirala
> My main concern with these patches is that moving the > NetLabel check out > of selinux_socket_sock_rcv_skb() and into > selinux_skb_policy_check() (as > it is currently written) would force us to compare a packet's NetLabel > with either the IPsec label or the secmark label Yes you would do t

[PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver

2006-08-31 Thread Amit S. Kale
Hi All, Thank you Stephen, Don and Wendy. We have incorporated feedbacks which have received since after last post. I'll be resending updated patchset in subsequent emails. We are working on finding out good way of using tables to manage compatibility between firmware version number and drive

Re: [PATCH] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread John W. Linville
On Thu, Aug 31, 2006 at 08:22:22AM -0500, Larry Finger wrote: > John, have you merged, or do you plan to merge, "[PATCH 2.6.18] WE-21 support > (core API)" into > wireless-2.6? I guess that is still up for discussion. It looks like at least part of it is desirable, but maybe not other parts. P

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Johannes Berg
On Thu, 2006-08-31 at 06:51 -0700, Jouni Malinen wrote: > I don't know about the others, but long/short retry limits have users > (e.g., Host AP driver) and these drivers are currently forced to use a > hack to do this without this cleanup. Furthermore, this part does not > add a new ioctl. It do

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Jouni Malinen
On Thu, Aug 31, 2006 at 03:32:18PM +0200, Johannes Berg wrote: > On Tue, 2006-08-29 at 17:56 -0700, Jean Tourrilhes wrote: > > o modulation > > o long/short retry > > o relative power saving. > What's the point of adding more ioctls that we'll be implementing th

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Johannes Berg
On Tue, 2006-08-29 at 17:56 -0700, Jean Tourrilhes wrote: > o modulation > o long/short retry > o relative power saving. I strongly disagree to these. What's the point of adding more ioctls that we'll be implementing them as wrappers around nl80211? Right

Re: [PATCH] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Larry Finger
Michael Buesch wrote: > On Thursday 31 August 2006 02:57, Larry Finger wrote: >> >> +#if WIRELESS_EXT > 20 >> +#define IW_ESSID_FIX0 >> +#else >> +#define IW_ESSID_FIX1 >> +#endif > > Eh, was this useless #if in the original patch I signed-off, too? > Because I want to revert my si

[TCP]: Fix rcv mss estimate for LRO

2006-08-31 Thread Herbert Xu
Hi Dave: The Xen performance problem turned out to be something else altogether. It was an incorrect rcv mss estimate which leads to delayed acks. So it's not a bug in Linux yet :) However, since we need this for LRO as well, here's a patch for net-2.6.19. [TCP]: Fix rcv mss estimate for LRO By

[PATCH] drivers/net/{ne,smc-ultra}.c: Avoid compilation warnings by registering init and exit functions

2006-08-31 Thread shaulka
This patch is against 2.6.17-11. 1) Meant to get rid of the following compilation warnings WARNING: drivers/net/ne.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0xeb) and 'ne_close' WARNING: drivers/net/smc-ultra.o - Section mismatch

Re: [PATCH 2.6.18] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Johannes Berg
Jean, > This is the version of the patch for out-of-tree, I guess you > will need it. Not tested. We don't, neither softmac nor bcm43xx is maintained out-of-tree any more. johannes - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTEC

Re: [PATCH] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Michael Buesch
On Thursday 31 August 2006 02:57, Larry Finger wrote: > John, > > Please apply Jean's patch to wireless-2.6. It should apply cleanly to the > version you pushed earlier > today (8/30). I have compiled and tested. For complete operation with WE-21, > it also needs the patch > entitled [PATCH 2.6.

dropping [EMAIL PROTECTED]

2006-08-31 Thread Johannes Berg
As there were no real objections, I will be dropping this list shortly. No real traffic here anyway. Please use netdev until (if ever) we have a wireless-specific list. johannes - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

  1   2   >